osr-plastic/osr-discourse-src
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

FIX: prevents scrollbar jumping in the emoji picker (#10749)

Browse Source 
This was mostly due to `content-visibility: auto;` but setting the width/height is also a good practice.
This commit is contained in:
Joffrey JAFFEUX
2020-09-28 13:23:46 +02:00
committed by GitHub
parent e00abbe1b7
commit c230d2e443
6 changed files with 19 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/javascripts/models/topic-test.js
+2 -2
View File
@@ -129,7 +129,7 @@ QUnit.test("fancyTitle", (assert) => {
assert.equal(
topic.get("fancyTitle"),
`<img src='/images/emoji/emoji_one/smile.png?v=${v}' title='smile' alt='smile' class='emoji'> with all <img src='/images/emoji/emoji_one/slight_smile.png?v=${v}' title='slight_smile' alt='slight_smile' class='emoji'> the emojis <img src='/images/emoji/emoji_one/pear.png?v=${v}' title='pear' alt='pear' class='emoji'><img src='/images/emoji/emoji_one/peach.png?v=${v}' title='peach' alt='peach' class='emoji'>`,
`<img width=\"20\" height=\"20\" src='/images/emoji/emoji_one/smile.png?v=${v}' title='smile' alt='smile' class='emoji'> with all <img width=\"20\" height=\"20\" src='/images/emoji/emoji_one/slight_smile.png?v=${v}' title='slight_smile' alt='slight_smile' class='emoji'> the emojis <img width=\"20\" height=\"20\" src='/images/emoji/emoji_one/pear.png?v=${v}' title='pear' alt='pear' class='emoji'><img width=\"20\" height=\"20\" src='/images/emoji/emoji_one/peach.png?v=${v}' title='peach' alt='peach' class='emoji'>`,
"supports emojis"
);
});
@@ -159,7 +159,7 @@ QUnit.test("excerpt", (assert) => {
assert.equal(
topic.get("escapedExcerpt"),
`This is a test topic <img src='/images/emoji/emoji_one/smile.png?v=${v}' title='smile' alt='smile' class='emoji'>`,
`This is a test topic <img width=\"20\" height=\"20\" src='/images/emoji/emoji_one/smile.png?v=${v}' title='smile' alt='smile' class='emoji'>`,
"supports emojis"
);
});