From c32ac45b29556c253f5ce1fa1d7623a3cd8444cb Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Thu, 7 Jul 2022 07:28:40 +0200 Subject: [PATCH] DEV: Reduce test noise (#17362) --- .../discourse/tests/acceptance/composer-uploads-uppy-test.js | 4 ++++ .../javascripts/discourse/tests/acceptance/unknown-test.js | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/app/assets/javascripts/discourse/tests/acceptance/composer-uploads-uppy-test.js b/app/assets/javascripts/discourse/tests/acceptance/composer-uploads-uppy-test.js index 1149efaa2f..23de74d4fa 100644 --- a/app/assets/javascripts/discourse/tests/acceptance/composer-uploads-uppy-test.js +++ b/app/assets/javascripts/discourse/tests/acceptance/composer-uploads-uppy-test.js @@ -12,6 +12,7 @@ import { click, fillIn, settled, visit } from "@ember/test-helpers"; import I18n from "I18n"; import { skip, test } from "qunit"; import { Promise } from "rsvp"; +import sinon from "sinon"; function pretender(server, helper) { server.post("/uploads/lookup-urls", () => { @@ -387,6 +388,9 @@ acceptance("Uppy Composer Attachment - Upload Error", function (needs) { }); test("should show an error message for the failed upload", async function (assert) { + // Don't log the upload error + sinon.stub(console, "error"); + await visit("/"); await click("#create-topic"); await fillIn(".d-editor-input", "The image:\n"); diff --git a/app/assets/javascripts/discourse/tests/acceptance/unknown-test.js b/app/assets/javascripts/discourse/tests/acceptance/unknown-test.js index b14e9f08df..90e9dae7f0 100644 --- a/app/assets/javascripts/discourse/tests/acceptance/unknown-test.js +++ b/app/assets/javascripts/discourse/tests/acceptance/unknown-test.js @@ -1,6 +1,7 @@ import { acceptance, exists } from "discourse/tests/helpers/qunit-helpers"; import { click, currentURL, visit } from "@ember/test-helpers"; import { test } from "qunit"; +import sinon from "sinon"; acceptance("Category 404", function (needs) { needs.pretender((server, helper) => { @@ -12,7 +13,11 @@ acceptance("Category 404", function (needs) { }); }); }); + test("Navigating to a bad category link does not break the router", async function (assert) { + // Don't log the XHR error + sinon.stub(console, "error"); + await visit("/t/internationalization-localization/280"); await click('[data-for-test="category-404"]');