DEV: Update linting setup and fix issues (#17345)

Re-lands #16119 and #17298

* Update eslint-config-discourse
* Update linting workflow
* Prettier-ignore stuff
* Update template-lint config
* Auto-fix template issues
* Fix various template issues
  Mostly incorrect attributes and unused templates
* Prettier js files
* Fix template auto-fix regressions
* Small css tweak

Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>

plugins/poll/assets/javascripts/discourse/templates/modal/poll-ui-builder.hbs

@@ -26,7 +26,7 @@
     <div class="poll-options">
       {{#if this.showAdvanced}}
         <label class="input-group-label">{{i18n "poll.ui_builder.poll_options.label"}}</label>
-        <Textarea @value={{this.pollOptionsText}} @input={{action "onOptionsTextChange"}} />
+        <Textarea @value={{this.pollOptionsText}} {{on "input" (action "onOptionsTextChange")}} />
         {{#if this.showMinNumOfOptionsValidation}}
           {{#unless this.minNumOfOptionsValidation.ok}}
             <InputTip @validation={{this.minNumOfOptionsValidation}} />
@@ -56,18 +56,18 @@
     <div class="options">
       <div class="input-group poll-number">
         <label class="input-group-label">{{i18n "poll.ui_builder.poll_config.min"}}</label>
-        <Input @type="number" @value={{this.pollMin}} @valueProperty="value" class="poll-options-min" @min={{1}} />
+        <Input @type="number" @value={{this.pollMin}} class="poll-options-min" min="1" />
       </div>
 
       <div class="input-group poll-number">
         <label class="input-group-label">{{i18n "poll.ui_builder.poll_config.max"}}</label>
-        <Input @type="number" @value={{this.pollMax}} @valueProperty="value" class="poll-options-max" @min={{1}} />
+        <Input @type="number" @value={{this.pollMax}} class="poll-options-max" min="1" />
       </div>
 
       {{#if this.isNumber}}
         <div class="input-group poll-number">
           <label class="input-group-label">{{i18n "poll.ui_builder.poll_config.step"}}</label>
-          <Input @type="number" @value={{this.pollStep}} @valueProperty="value" @min="1" class="poll-options-step" />
+          <Input @type="number" @value={{this.pollStep}} min="1" class="poll-options-step" />
         </div>
       {{/if}}
     </div>

plugins/poll/assets/javascripts/initializers/extend-for-poll.js

@@ -24,8 +24,8 @@ function cleanUpPolls() {
 
 function initializePolls(api) {
   const register = getRegister(api),
-    pollGroupableUserFields = api.container.lookup("site-settings:main")
-      .poll_groupable_user_fields;
+    pollGroupableUserFields =
+      api.container.lookup("site-settings:main").poll_groupable_user_fields;
   cleanUpPolls();
 
   api.modifyClass("controller:topic", {