From c8f4a2cfb99d7bae8cdfcce49b65097dc18217e1 Mon Sep 17 00:00:00 2001 From: David Taylor Date: Thu, 2 Feb 2023 09:52:44 +0000 Subject: [PATCH] DEV: Use template-only for RenderGlimmer helper (#20138) We don't need a full glimmer component here - the class definition was empty. We can use templateOnly() for slightly improved performance. Setting `component.name` improves how MountWidget is displayed for debugging in the Ember Inspector browser extension. --- .../javascripts/discourse/app/widgets/render-glimmer.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/app/widgets/render-glimmer.js b/app/assets/javascripts/discourse/app/widgets/render-glimmer.js index e4db7d87ca..d5b23c0f55 100644 --- a/app/assets/javascripts/discourse/app/widgets/render-glimmer.js +++ b/app/assets/javascripts/discourse/app/widgets/render-glimmer.js @@ -1,4 +1,4 @@ -import Component from "@glimmer/component"; +import templateOnly from "@ember/component/template-only"; import { setComponentTemplate } from "@ember/component"; import { tracked } from "@glimmer/tracking"; import { assert } from "@ember/debug"; @@ -129,7 +129,8 @@ export default class RenderGlimmer { connectComponent() { const { element, template, widget } = this; - const component = class extends Component {}; + const component = templateOnly(); + component.name = "Widgets/RenderGlimmer"; setComponentTemplate(template, component); this._componentInfo = {