From d0f4f408af07ea4e49a9fc8cf4ccd38194eb7574 Mon Sep 17 00:00:00 2001 From: Dan Ungureanu Date: Fri, 21 Jan 2022 19:51:04 +0200 Subject: [PATCH] DEV: Simplify emoji-uploader tests (#15672) Removes one layer of indirection in the tests. `emoji-uploader`'s `uploadDone` can call the test handler directly without going through an additional action method. --- .../tests/integration/components/emoji-uploader-test.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/app/assets/javascripts/discourse/tests/integration/components/emoji-uploader-test.js b/app/assets/javascripts/discourse/tests/integration/components/emoji-uploader-test.js index 50bcd63e6c..927837dd9f 100644 --- a/app/assets/javascripts/discourse/tests/integration/components/emoji-uploader-test.js +++ b/app/assets/javascripts/discourse/tests/integration/components/emoji-uploader-test.js @@ -17,7 +17,7 @@ discourseModule("Integration | Component | emoji-uploader", function (hooks) { const template = hbs` {{emoji-uploader emojiGroups=emojiGroups - done=(action "emojiUploaded") + done=doneUpload id="emoji-uploader" }}`; @@ -25,11 +25,6 @@ discourseModule("Integration | Component | emoji-uploader", function (hooks) { requestNumber = 1; this.setProperties({ emojiGroups: ["default", "coolemojis"], - actions: { - emojiUploaded: (upload, group) => { - this.doneUpload(upload, group); - }, - }, }); pretender.post("/admin/customize/emojis.json", () => {