From d2d3c7d24e733b1db8bd187df1f2b004d18d6ca2 Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Mon, 23 Apr 2018 10:21:51 +0800 Subject: [PATCH] FIX: Only show offline page when user is offline. https://meta.discourse.org/t/cannot-load-app-in-firefox-sometimes-refresh-fixes-it/85258 --- app/assets/javascripts/service-worker.js.erb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/service-worker.js.erb b/app/assets/javascripts/service-worker.js.erb index 7202c6b6f0..f091e07dc2 100644 --- a/app/assets/javascripts/service-worker.js.erb +++ b/app/assets/javascripts/service-worker.js.erb @@ -80,7 +80,11 @@ self.addEventListener('fetch', function(event) { // If fetch() returns a valid HTTP response with an response code in the 4xx or 5xx // range, the catch() will NOT be called. If you need custom handling for 4xx or 5xx // errors, see https://github.com/GoogleChrome/samples/tree/gh-pages/service-worker/fallback-response - return caches.match(OFFLINE_URL); + if (!navigator.onLine) { + return caches.match(OFFLINE_URL); + } else { + throw error; + } }) ); }