From d52d479bd4f4659ce315570f4cd909d527eaecef Mon Sep 17 00:00:00 2001 From: David Taylor Date: Thu, 14 Jul 2022 12:17:01 +0100 Subject: [PATCH] DEV: Remove 'legacy ember' logic from discourse-root component (#17494) This logic should no longer be triggered. The EMBER_GLIMMER_SET_COMPONENT_TEMPLATE gets removed in recent versions of Ember, which can cause it to accidently trigger and cause layout issues with some plugins/themes. --- .../javascripts/discourse/app/components/discourse-root.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/app/assets/javascripts/discourse/app/components/discourse-root.js b/app/assets/javascripts/discourse/app/components/discourse-root.js index c1c6ac93a2..a0849beaba 100644 --- a/app/assets/javascripts/discourse/app/components/discourse-root.js +++ b/app/assets/javascripts/discourse/app/components/discourse-root.js @@ -2,10 +2,4 @@ import Component from "@ember/component"; let componentArgs = { tagName: "div", classNames: ["discourse-root"] }; -// TODO: Once we've moved to Ember CLI completely we can remove this block -// eslint-disable-next-line no-undef -if (!Ember.FEATURES.EMBER_GLIMMER_SET_COMPONENT_TEMPLATE) { - componentArgs = { tagName: "" }; -} - export default Component.extend(componentArgs);