From dc15486f0ad966d7ea6041783147c70e8641c994 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Tue, 11 Jun 2019 13:34:25 +0200 Subject: [PATCH] Revert "DEV: resets csrf ajax prefilter only if present (#7747)" This reverts commit 6612218a4eee1496c4aefe6d5ff7b18157fd2881. --- .../discourse/initializers/csrf-token.js.es6 | 21 ++++--------------- test/javascripts/helpers/qunit-helpers.js.es6 | 2 -- 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/app/assets/javascripts/discourse/initializers/csrf-token.js.es6 b/app/assets/javascripts/discourse/initializers/csrf-token.js.es6 index 26e532fd1e..fd95c274d9 100644 --- a/app/assets/javascripts/discourse/initializers/csrf-token.js.es6 +++ b/app/assets/javascripts/discourse/initializers/csrf-token.js.es6 @@ -1,29 +1,16 @@ // Append our CSRF token to AJAX requests when necessary. -let _crsfCallbacks; - export default { name: "csrf-token", - - initialize(container) { - const session = container.lookup("session:main"); - _crsfCallbacks = $.Callbacks(); + initialize: function(container) { + var session = container.lookup("session:main"); // Add a CSRF token to all AJAX requests session.set("csrfToken", $("meta[name=csrf-token]").attr("content")); - _crsfCallbacks.add(function(options, originalOptions, xhr) { + $.ajaxPrefilter(function(options, originalOptions, xhr) { if (!options.crossDomain) { - xhr.setRequestHeader("X-CSRF-Token", session.csrfToken); + xhr.setRequestHeader("X-CSRF-Token", session.get("csrfToken")); } }); - - $.ajaxPrefilter(_crsfCallbacks); } }; - -export function resetCsrfCallbacks() { - if (_crsfCallbacks) { - _crsfCallbacks.empty(); - _crsfCallbacks = null; - } -} diff --git a/test/javascripts/helpers/qunit-helpers.js.es6 b/test/javascripts/helpers/qunit-helpers.js.es6 index 4927156802..759e64f706 100644 --- a/test/javascripts/helpers/qunit-helpers.js.es6 +++ b/test/javascripts/helpers/qunit-helpers.js.es6 @@ -16,7 +16,6 @@ import { resetDecorators } from "discourse/widgets/widget"; import { resetDecorators as resetPostCookedDecorators } from "discourse/widgets/post-cooked"; import { resetCache as resetOneboxCache } from "pretty-text/oneboxer"; import { resetCustomPostMessageCallbacks } from "discourse/controllers/topic"; -import { resetCsrfCallbacks } from "discourse/initializers/csrf-token"; export function currentUser() { return Discourse.User.create( @@ -129,7 +128,6 @@ export function acceptance(name, options) { resetPostCookedDecorators(); resetOneboxCache(); resetCustomPostMessageCallbacks(); - resetCsrfCallbacks(); Discourse.reset(); } });