From e3144fc0c72a0ffd4bb6e5fb43e477ca541d2234 Mon Sep 17 00:00:00 2001 From: Penar Musaraj Date: Mon, 19 Jul 2021 19:01:09 -0400 Subject: [PATCH] FIX: Toggle search menu when click the same button (#13781) --- .../discourse/app/widgets/search-menu.js | 2 +- .../discourse/tests/acceptance/search-test.js | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/app/widgets/search-menu.js b/app/assets/javascripts/discourse/app/widgets/search-menu.js index 6514e9a1d4..2ea06cdab6 100644 --- a/app/assets/javascripts/discourse/app/widgets/search-menu.js +++ b/app/assets/javascripts/discourse/app/widgets/search-menu.js @@ -286,7 +286,7 @@ export default createWidget("search-menu", { }); }, - mouseDownOutside() { + clickOutside() { this.sendWidgetAction("toggleSearchMenu"); }, diff --git a/app/assets/javascripts/discourse/tests/acceptance/search-test.js b/app/assets/javascripts/discourse/tests/acceptance/search-test.js index a61257e3c3..64224c8cee 100644 --- a/app/assets/javascripts/discourse/tests/acceptance/search-test.js +++ b/app/assets/javascripts/discourse/tests/acceptance/search-test.js @@ -52,6 +52,22 @@ acceptance("Search - Anonymous", function (needs) { ); }); + test("search button toggles search menu", async function (assert) { + await visit("/"); + + await click("#search-button"); + assert.ok(exists(".search-menu")); + + await click(".d-header"); // click outside + assert.ok(!exists(".search-menu")); + + await click("#search-button"); + assert.ok(exists(".search-menu")); + + await click("#search-button"); // toggle same button + assert.ok(!exists(".search-menu")); + }); + test("search for a tag", async function (assert) { await visit("/");