diff --git a/spec/serializers/basic_user_serializer_spec.rb b/spec/serializers/basic_user_serializer_spec.rb index 7480f07f87..1e0b90832d 100644 --- a/spec/serializers/basic_user_serializer_spec.rb +++ b/spec/serializers/basic_user_serializer_spec.rb @@ -2,28 +2,20 @@ require 'rails_helper' require_dependency 'user' describe BasicUserSerializer do - - context "name" do + describe '#as_json' do let(:user) { Fabricate.build(:user) } let(:serializer) { BasicUserSerializer.new(user, scope: Guardian.new(user), root: false) } let(:json) { serializer.as_json } it "returns the username" do - expect(json[:username]).to be_present - end - - it "returns the name it when `enable_names` is true" do - SiteSetting.enable_names = true - expect(json[:name]).to be_present + expect(json[:username]).to eq(user.username) + expect(json[:name]).to eq(user.name) + expect(json[:avatar_template]).to eq(user.avatar_template) end it "doesn't return the name it when `enable_names` is false" do SiteSetting.enable_names = false - expect(json[:name]).to be_blank - end - - it "returns the avatar_template" do - expect(json[:avatar_template]).to be_present + expect(json[:name]).to eq(nil) end end end