From e6843afa9e8c4cdff90cbfc74e7540230137b2ff Mon Sep 17 00:00:00 2001 From: Neil Lalonde Date: Mon, 6 May 2019 15:45:06 -0400 Subject: [PATCH] FIX: don't send post edit notification when hidden tags are changed --- lib/post_revisor.rb | 1 + spec/components/post_revisor_spec.rb | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/lib/post_revisor.rb b/lib/post_revisor.rb index 9e8842f561..a177d57067 100644 --- a/lib/post_revisor.rb +++ b/lib/post_revisor.rb @@ -451,6 +451,7 @@ class PostRevisor return if @skip_revision # don't create an empty revision if something failed return unless successfully_saved_post_and_topic + return if only_hidden_tags_changed? @version_changed ? create_revision : update_revision end diff --git a/spec/components/post_revisor_spec.rb b/spec/components/post_revisor_spec.rb index 26ad1b7de6..e540ce9911 100644 --- a/spec/components/post_revisor_spec.rb +++ b/spec/components/post_revisor_spec.rb @@ -763,6 +763,12 @@ describe PostRevisor do expect(result).to eq(true) }.to_not change { topic.reload.bumped_at } end + + it "doesn't create revision" do + expect { + subject.revise!(Fabricate(:admin), raw: post.raw, tags: topic.tags.map(&:name) + ['secret']) + }.to_not change { post.reload.revisions.size } + end end end