From f1a184eaffa2d13d5f6dcd53d2c1d82f05d9ba70 Mon Sep 17 00:00:00 2001
From: Leonardo Mosquera <ldmosquera@gmail.com>
Date: Tue, 15 Nov 2022 20:59:17 +0000
Subject: [PATCH] WIP - add FIXMEs to fix progress reporting for records
 without imported_id

---
 script/bulk_import/base.rb         | 3 +++
 script/bulk_import/generic_bulk.rb | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/script/bulk_import/base.rb b/script/bulk_import/base.rb
index e46cdaf55f..7537c87ec5 100644
--- a/script/bulk_import/base.rb
+++ b/script/bulk_import/base.rb
@@ -773,6 +773,9 @@ class BulkImport::Base
       end
     end
 
+    # FIXME: this does not count succesfully inserted records that do not happen to have an imported_id field,
+    # which is misguiding and can results in lots of wasted time double checking "0 records imported" prints
+
     if imported_ids.size > 0
       print "\r%7d - %6d/sec" % [imported_ids.size, imported_ids.size.to_f / (Time.now - start)]
       puts
diff --git a/script/bulk_import/generic_bulk.rb b/script/bulk_import/generic_bulk.rb
index 62e14caa9c..d81985e517 100644
--- a/script/bulk_import/generic_bulk.rb
+++ b/script/bulk_import/generic_bulk.rb
@@ -176,6 +176,7 @@ class BulkImport::Generic < BulkImport::Base
       user_id = user_id_from_imported_id(imported_user_id)
       added += 1
       {
+        # FIXME: missing imported_id
         topic_id: topic_id,
         user_id: user_id
       }
@@ -227,6 +228,7 @@ class BulkImport::Generic < BulkImport::Base
       next if @imported_likes.add?([post_id, user_id]).nil?
 
       {
+        # FIXME: missing imported_id
         post_id: post_id_from_imported_id(row["post_id"]),
         user_id: user_id_from_imported_id(row["user_id"]),
         post_action_type_id: 2,