osr-plastic/osr-discourse-src
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

FIX: Don't load images that don't exist in test

Browse Source 
This makes 404 requests and fills up the logs with junk
This commit is contained in:
Robin Ward
2020-07-17 14:12:47 -04:00
parent 0ecca3a2d2
commit f68ea29236
5 changed files with 22 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/javascripts/lib/oneboxer-test.js
+1 -1
View File
@@ -41,7 +41,7 @@ QUnit.test("load - successful onebox", async assert => {
<a href="http://test.com/somepage" target="_blank">test.com</a>
</header>
<article class="onebox-body">
<div class="aspect-image" style="--aspect-ratio:690/362;"><img src="https://test.com/image.png" class="thumbnail"></div>
<div class="aspect-image" style="--aspect-ratio:690/362;"><img src="" class="thumbnail"></div>
<h3><a href="http://test.com/somepage" target="_blank">Test Page</a></h3>
<p>Yet another collaboration tool</p>
</article>
test/javascripts/lib/upload-short-url-test.js
+8 -8
View File
@@ -15,17 +15,17 @@ function stubUrls(imageSrcs, attachmentSrcs, otherMediaSrcs) {
imageSrcs = [
{
short_url: "upload://a.jpeg",
url: "/uploads/default/original/3X/c/b/1.jpeg",
url: "/images/avatar.png?a",
short_path: "/uploads/short-url/a.jpeg"
},
{
short_url: "upload://b.jpeg",
url: "/uploads/default/original/3X/c/b/2.jpeg",
url: "/images/avatar.png?b",
short_path: "/uploads/short-url/b.jpeg"
},
{
short_url: "upload://z.jpeg",
url: "/uploads/default/original/3X/c/b/9.jpeg",
url: "/images/avatar.png?z",
short_path: "/uploads/short-url/z.jpeg"
}
];
@@ -89,14 +89,14 @@ QUnit.test("resolveAllShortUrls", async assert => {
lookup = lookupCachedUploadUrl("upload://a.jpeg");
assert.deepEqual(lookup, {
url: "/uploads/default/original/3X/c/b/1.jpeg",
url: "/images/avatar.png?a",
short_path: "/uploads/short-url/a.jpeg"
});
lookup = lookupCachedUploadUrl("upload://b.jpeg");
assert.deepEqual(lookup, {
url: "/uploads/default/original/3X/c/b/2.jpeg",
url: "/images/avatar.png?b",
short_path: "/uploads/short-url/b.jpeg"
});
@@ -136,8 +136,8 @@ QUnit.test(
.eq(1);
let link = fixture().find("a");
assert.equal(image1.attr("src"), "/uploads/default/original/3X/c/b/1.jpeg");
assert.equal(image2.attr("src"), "/uploads/default/original/3X/c/b/2.jpeg");
assert.equal(image1.attr("src"), "/images/avatar.png?a");
assert.equal(image2.attr("src"), "/images/avatar.png?b");
assert.equal(link.attr("href"), "/uploads/short-url/c.pdf");
}
);
@@ -176,7 +176,7 @@ QUnit.test("resolveAllShortUrls - scoped", async assert => {
lookup = lookupCachedUploadUrl("upload://z.jpeg");
assert.deepEqual(lookup, {
url: "/uploads/default/original/3X/c/b/9.jpeg",
url: "/images/avatar.png?z",
short_path: "/uploads/short-url/z.jpeg"
});