Commit Graph

1614 Commits

Author SHA1 Message Date
Régis Hanol
0210a7f2bf FIX: social login buttons were not working 2018-02-22 18:06:28 +01:00
Guo Xiang Tan
7bcc0c1da9 FIX: Login buttons not working on sign up modal. 2018-02-22 14:01:07 +08:00
Arpit Jalan
d170c8fccc Revert 'Accessibility: focus management in topics'
reverts:

- 3df0626aa5
- 3212cdda78
- 59b7760e2e
- bfc1301823
2018-02-22 10:32:37 +05:30
Kane York
3212cdda78 UX: Use focus as the first selector for J/K navigation 2018-02-22 11:55:36 +08:00
Sam
f4418ae884 PERF: fast docking of timeline so it does not overlap
In the past we debounced all dock check this causes situations where
sometimes timeline would not dock in time especially on slow computers

This works around it by performing the dock by hand.

Also there was missing integer casting causing over aggressive re-rendering
2018-02-22 12:52:43 +11:00
Joffrey JAFFEUX
6f5acfe783 Login with email/forget password UI refactoring
* move button into login modal with social buttons
* adds email link next to login field when filling it
* adds proper validation messages
* improves forgot password flash clearing
* more tests
2018-02-22 08:06:15 +08:00
Jeff Wong
f4f8a293e7 FEATURE: Implement 2factor login TOTP
implemented review items.

Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator

add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests

add qunit tests - password reset, preferences

fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.

Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP

add two factor to email signin link

rate limit if second factor token present

add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
Régis Hanol
60ec483caa FIX: include title in local onebox when linking to a different topic 2018-02-19 22:40:14 +01:00
Joffrey JAFFEUX
b3b6373f77
FIX: do not show mail-forward icon if not needed 2018-02-19 09:52:35 +01:00
Robin Ward
a03e7cee63 FIX: Group posts had the wrong paths in subfolders 2018-02-14 20:33:31 -05:00
Sam
f028ffaf29 SECURITY: correct local onebox category checks
Also removes ugly "source_topic_id" from cooked posts

Patch was authored by @zogstrip

Signed-off-by: Sam <sam.saffron@gmail.com>
2018-02-14 10:40:46 +11:00
Sam
b34b1b6fe3 FIX: invite to message was not allowing groups
Previously we were incorrectly checking mentionable instead of messageable

Also fix edge case where multiple groups sharing a name mean that exact match override is not working

Also cleans up params sent to user selector
2018-02-13 13:28:46 +11:00
Robin Ward
dedeb2deb8 FIX: Don't show the link button in the composer if linking is disabled 2018-02-08 12:56:10 -05:00
Neil Lalonde
ce26f48f97 FIX: only send up to 100 selected tags in the tag search request to avoid sending a query string that's too long 2018-02-06 17:54:57 -05:00
Joffrey JAFFEUX
cdded801c5
FIX: correctly shows link to post number when editing 2018-02-06 22:17:27 +01:00
Joffrey JAFFEUX
5cd5d5aca5
FIX: prevents a regression where enter wasn't working in inputs 2018-02-05 09:55:58 +01:00
Joffrey JAFFEUX
9923829402
FEATURE: Menu toggle for different reply modes
Allow users to access different reply modes from the composer.

Actions introduced:

- reply_as_new_topic
- reply_as_private_message
- reply_to_topic
- reply_as_whisper/not
2018-02-01 16:42:56 +01:00
Robin Ward
96710754d9
Merge pull request #5540 from discourse/mixed-text-direction-support
FEATURE: Mixed text direction support
2018-02-01 07:29:15 -08:00
Arpit Jalan
ff0376a80b rename 'enable_private_messages' to 'enable_personal_messages' 2018-02-01 13:25:29 +05:30
Arpit Jalan
25ec077eca rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length' 2018-02-01 13:25:29 +05:30
Régis Hanol
826584b9c1 UX: prevent anons from clearing pins in topic view 2018-01-31 20:34:53 +01:00
scossar
41f1e7430c Refactor code; add tests 2018-01-29 17:42:19 -08:00
Neil Lalonde
fcc86d5be3 FIX: time read on users directory was not rendering correctly on mobile 2018-01-29 13:31:18 -05:00
Joffrey JAFFEUX
52fbf9d3ae
FIX: emoji-picker improvements
* fix a performance issue on mobile when modifying filtering query, thanks to David Taylor and Jorge Manrubia for the initial finding and solution
* minor refactoring
* better positioning of the picker on mobile
2018-01-29 11:05:35 +01:00
scossar
caa38aaaad Add support for mixed text directions 2018-01-28 18:33:55 -08:00
Joffrey JAFFEUX
4c19088084
FIX: hides upload link on mobile 2018-01-28 09:48:41 +01:00
Joffrey JAFFEUX
3d595a52ca
FIX: improves UI state when no extensions are allowed for upload 2018-01-26 18:12:23 +01:00
Vinoth Kannan
4a70248311 UX: Trim selected text while copying to the link building modal 2018-01-24 18:58:54 +05:30
Joffrey JAFFEUX
3a290ee625
FEATURE: replaces category/tag dropdowns by select-kit 2018-01-24 11:48:20 +01:00
Robin Ward
0351565731 Add span to make extensibility easier 2018-01-23 15:45:09 -05:00
Vinoth Kannan
86e142b39f UX: Copy selected text to the link building modal 2018-01-24 02:02:12 +05:30
Robin Ward
782d75069e FIX: UX improvements for system messages when PMs are disabled 2018-01-23 13:12:11 -05:00
Robin Ward
8d454156b3 Rename css class to something that makes more sense 2018-01-17 11:38:43 -05:00
Kane York
ff91c43087 FEATURE: Keyboard shortcut to refocus composer (#5506)
It was very annoying to get back to the composer after losing it!

Added to the keyboard shortcuts help dialog, and reshuffled it a bit.
Translation keys were intentionally kept so our translators don't have
to copy paste to update.

This commit also fixes an incidental listener leak.
2018-01-17 17:15:03 +11:00
Joffrey JAFFEUX
ec2ce8f763
FEATURE: replace period-chooser by a select-kit component 2018-01-15 11:55:16 +01:00
Sam
114294d899 PERF: cache messages so re-opening composer on same topic does not issue a req 2018-01-10 14:39:39 +11:00
Robin Ward
c1ae562389 Add support for app events in plugin api, plus an event for custom html 2018-01-05 16:45:57 -05:00
Gerhard Schlager
a0b2b3c8a7 FIX: Canceling upload on mobile did not work 2018-01-02 11:26:23 +01:00
Régis Hanol
f5e170c6b5 FIX: catch all server-side error when uploading a file
UX: always show a message to the user whenever an error happens on the server when uploading a file
2017-12-27 16:33:25 +01:00
Maja Komel
2a32536645 grey out disabled badges in admin overview (#5416)
* gray out disabled badges in admin overview

* fix style
2017-12-27 16:57:21 +11:00
Vinoth Kannan
688f39447c Skip tab delimited lists in plain text to table conversion 2017-12-26 15:52:22 +05:30
Régis Hanol
779efd9235 FIX: don't set properties on destroyed components 2017-12-22 20:33:33 +01:00
Robin Ward
ea9c1e5cf8 Add extensibility endpoints for clicking on topic list item rows 2017-12-22 14:01:17 -05:00
Vinoth Kannan
4935ae4338 Remove unwanted spaces between HTML tags and support Word documents 2017-12-22 09:28:24 +05:30
Robin Ward
2908aab0da Allow extensibility on username route format (non-english usernames) 2017-12-21 14:32:51 -05:00
Sam
62a27f9d57 FEATURE: warn if attempting to mention a group with too many members 2017-12-21 16:13:57 +11:00
Robin Ward
2735914cf6 FIX: ESlint 2017-12-19 17:55:41 -05:00
Robin Ward
b3fda0ea86 FIX: details tags broke excerpts 2017-12-19 17:28:55 -05:00
Robin Ward
c1716d41c7 Add some plugin outlets to the user card 2017-12-19 15:04:54 -05:00
Sam
9472821331 Allow plugins to specify custom nav items on mobile 2017-12-19 16:50:25 +11:00