Joffrey JAFFEUX
bc14452585
FIX: ensures events have access to correct context ( #7621 )
2019-05-28 19:40:28 +02:00
Guo Xiang Tan
b1d3c678ca
FEATURE: Support [description|attachment](upload://<short-sha>) in MD. ( #7603 )
2019-05-28 11:18:21 -04:00
Robin Ward
9bdfaa195e
FIX: We shouldn't memoize the last time something is read
2019-05-28 10:51:18 -04:00
Arpit Jalan
028121b95b
FIX: delete system generated message when user_export record is deleted ( #7595 )
...
FIX: system generated message for user export should be closed by default
2019-05-28 16:38:41 +05:30
Joffrey JAFFEUX
6decdfce5c
DEV: reduces memory footprint of tests - step 1 ( #7591 )
2019-05-28 12:15:12 +02:00
Bianca Nenciu
07b80d491b
FIX: Refresh automatic groups after inviting moderators.
2019-05-28 17:19:34 +08:00
Ralph Rooding
0d9fdbf8fe
FEATURE: Allow import of hidden site settings ( #7601 )
...
* Allow optional import of hidden site settings
* Always import hidden settings
2019-05-28 16:20:18 +10:00
Rafael dos Santos Silva
315a38e0e3
FEATURE: Allow running message_bus in a different redis instance ( #7616 )
...
Adds `DISCOURSE_MESSAGE_BUS_REDIS_ENABLED` env var, that when set
to true, will allow Discourse to connect to a different redis
instance for MessageBus needs.
When enabled you can configure the same env vars user for redis,
but prefixed by `MESSAGE_BUS`, eg:
`DISCOURSE_MESSAGE_BUS_REDIS_HOST`
2019-05-28 15:52:43 +10:00
Sam Saffron
7429700389
FIX: ensure we can download maxmind without redis or db config
...
This also corrects FileHelper.download so it supports "follow_redirect"
correctly (it used to always follow 1 redirect) and adds a `validate_url`
param that will bypass all uri validation if set to false (default is true)
2019-05-28 10:28:57 +10:00
Robin Ward
b85fa62882
FIX: Don't send replies to flags that are ignored by expiry
...
The `AutoQueueHandler` will ignore really old flags. In that case, don't
notify the user that the moderator is looking into it. They probably
never saw it because it didn't meet the reviewable minimum priority.
2019-05-27 17:24:36 -04:00
Robin Ward
03b4131933
FIX: When deleting a user via queued posts, block urls, ip and email
2019-05-27 15:54:01 -04:00
Robin Ward
d26c4509ea
FIX: Adding a user to a group twice under concurrency
...
This prevents an error from being raised / logged.
2019-05-27 15:42:40 -04:00
Penar Musaraj
dfcc2e7ad8
Revert "FEATURE: Send notification when member was accepted to group. ( #7503 )"
...
This reverts commit 42c82d544e
2019-05-27 15:19:59 -04:00
Penar Musaraj
c108131ad4
Revert "Fix JS error in group summary notification message"
...
This reverts commit b1268e00b8
2019-05-27 15:19:38 -04:00
Penar Musaraj
b1268e00b8
Fix JS error in group summary notification message
2019-05-27 14:54:51 -04:00
Robin Ward
d95a68b837
FEATURE: When suspending a user, allow the Delete + Replies action
...
Previously you could only delete the post
2019-05-27 12:27:16 -04:00
Joffrey JAFFEUX
192562745f
DEV: uses focus helper for d-editor tests ( #7610 )
2019-05-27 17:31:11 +02:00
Bianca Nenciu
42c82d544e
FEATURE: Send notification when member was accepted to group. ( #7503 )
2019-05-27 17:28:41 +03:00
Joffrey JAFFEUX
395f0ca126
FIX: attempts to prevent stacked-chart from being cut off ( #7608 )
2019-05-27 15:43:27 +02:00
Bianca Nenciu
e284b6e075
FIX: Update tags on change. ( #7581 )
2019-05-27 16:04:26 +03:00
Joffrey JAFFEUX
d93f753b17
apply prettier on gigantic find and replace ( #7604 )
2019-05-27 10:42:53 +02:00
Joffrey JAFFEUX
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 ( #7592 )
2019-05-27 10:15:39 +02:00
Dan Ungureanu
da39d66e83
DEV: Improve support for plugins. ( #7332 )
...
* DEV: Allow NewPostManager handlers handle PMs.
* DEV: Add custom fields topic option to PostCreator.
* DEV: Add topic_id to serializer data.
* DEV: Wrap topic title from notification item in a span.
2019-05-25 16:53:03 +03:00
Joffrey JAFFEUX
6398ded798
Revert "FIX: ensures selection is lookedup into async content ( #7586 )"
...
This reverts commit c238f0d223
2019-05-25 15:50:41 +02:00
Régis Hanol
d6aacadc4e
make 🤖 happy
2019-05-25 00:32:29 +02:00
Robin Ward
4b796eebe0
UX: Try tweaking how soon images are lazily loaded
2019-05-24 15:52:48 -04:00
Robin Ward
89b84651c3
Migrate score settings to use sensitivities
...
We hide scores so these settings no longer made sense.
2019-05-24 15:44:24 -04:00
Robin Ward
fad5d9c49b
Use an Enum class for the Reviewable Priority Site Setting
2019-05-24 15:44:24 -04:00
Kris
dbd14a805c
UX: Wrap long names on user admin page
2019-05-24 13:39:16 -04:00
Penar Musaraj
963f6fbd40
Add icon for "Move to Inbox" footer button
2019-05-24 11:53:14 -04:00
Osama Sayegh
e20c30987c
FEATURE: detect theme errors and catch them ( #7589 )
...
* FEATURE: detect theme errors and catch them
* Bump COMPILER_VERSION
* Feedback
* Override eslint no console for one line
* Can't use our ajax method
* remove emoji from translation file
2019-05-24 17:25:55 +03:00
Joffrey JAFFEUX
049561ac49
FIX: introduces onSelectAny (regroup onSelect and onSelectNone) ( #7594 )
2019-05-24 13:11:33 +02:00
Gerhard Schlager
f4a471f0eb
FIX: Correctly cache hash of extra translations
2019-05-24 11:38:26 +02:00
Gerhard Schlager
c1e9a70d59
FIX: Fallback locale was not available for extra translations
...
Translations from fallback locales were not sent to the client
for admin_js and wizard_js.
2019-05-24 11:38:26 +02:00
Guo Xiang Tan
fd0eff6ce3
Revert "FIX: Add missing unique index on user_id for user_profiles."
...
Oops `user_id` is the primary key.
This reverts commit 5478aa63ab
2019-05-24 12:58:36 +08:00
Guo Xiang Tan
5aed463649
Update annotation.
2019-05-24 12:58:26 +08:00
Guo Xiang Tan
5478aa63ab
FIX: Add missing unique index on user_id for user_profiles.
2019-05-24 12:11:49 +08:00
Guo Xiang Tan
4f5c9bb8d3
DEV: Prefer create! over create.
...
We want to know when stuff fails.
2019-05-24 12:07:22 +08:00
Blake Erickson
1fbe078ae0
FIX: Undefined method when serializing a user
...
Apparently is is possible to have a user without a user_profile. This
fix will return nil for any user_profile fields during serialization
(like the after delete web hook) instead of blowing up.
2019-05-23 19:44:55 -06:00
Guo Xiang Tan
1babc3bec6
Follow up to 3388872991.
2019-05-24 09:02:39 +08:00
Kris
3388872991
UX: Separate section for 2FA settings, more consistent layout
2019-05-24 08:58:12 +08:00
Robin Ward
648af78298
FIX: Linting
2019-05-23 12:16:45 -04:00
Robin Ward
f73988acd2
Remove unused computed property.
2019-05-23 12:06:18 -04:00
Robin Ward
e74cd54fc6
REFACTOR: Replace score bonuses with low/med/high priorities
...
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
2019-05-23 11:54:45 -04:00
Joffrey JAFFEUX
30961dd875
Revert "UX: Prevent long names from overflowing on user admin"
...
This reverts commit 6207b71c36
2019-05-23 16:56:30 +02:00
Régis Hanol
943fdc1762
make eslint happy
2019-05-23 12:51:40 +02:00
Régis Hanol
0cc81f95a5
FIX: popover should use target when no data attributes
2019-05-23 12:41:36 +02:00
Guo Xiang Tan
ca6c919299
DEV: Remove unused variable.
...
Follow up to df1e6eed5a07f49eeda4c0bbd8c63d539aefdb3b..
2019-05-23 16:42:42 +08:00
Joffrey JAFFEUX
f0a776f05d
FIX: allows scrolling when a lot of categories are used ( #7590 )
2019-05-23 10:04:53 +02:00
Guo Xiang Tan
df1e6eed5a
FIX: Pull hotlinked images for lightbox links as well.
2019-05-23 15:44:37 +08:00
Arpit Jalan
553ffbfcb5
FEATURE: add OpenGraph data to /login page
2019-05-23 07:03:01 +05:30
Sam Saffron
954293655f
FEATURE: rake posts:destroy_old_user_data_exports
...
Historically we would keep the user data export posts around but delete
the uploads.
This leaves a lot of broken uploads in the system.
This rake task allows us to clean up old mess.
2019-05-23 11:11:37 +10:00
Kris
6207b71c36
UX: Prevent long names from overflowing on user admin
2019-05-22 15:10:09 -04:00
Kris
9f6af5f8a7
UX: Prevent long names from overflowing on user profiles
2019-05-22 15:03:50 -04:00
Kris
881c832a2f
UX: Remove padding from empty row
2019-05-22 14:27:17 -04:00
Robin Ward
ca03baf2b2
UX: Hide pending score statuses
2019-05-22 11:26:17 -04:00
Joffrey JAFFEUX
cf63a9bb53
FIX: exception when pressing backspace on empty selection ( #7587 )
2019-05-22 17:18:46 +02:00
Joffrey JAFFEUX
c238f0d223
FIX: ensures selection is lookedup into async content ( #7586 )
2019-05-22 17:11:19 +02:00
Gerhard Schlager
58f72cd439
Remove duplicate translations
2019-05-22 16:15:22 +02:00
Joffrey JAFFEUX
40c903ec23
FIX: ie11 exception on new category popup ( #7585 )
2019-05-22 15:17:28 +02:00
Gerhard Schlager
e224100023
FIX: Don't convert :) into Emoji when emojis or emoji shurtcuts are disabled
2019-05-22 11:44:39 +02:00
Sam Saffron
d9413a61d2
PERF: move crawl_topic_links to the low queue
...
Crawling topic links can be somewhat delayed no need to run it in the default
queue.
2019-05-22 10:18:49 +10:00
Joffrey JAFFEUX
0ed1cfd8d9
FIX: ensures we have an elementFromPoint before using it ( #7583 )
2019-05-21 21:26:54 +02:00
Vinoth Kannan
793915fe6a
DEV: should ignore missing post uploads when a user export destroyed
2019-05-21 13:32:36 +05:30
Joffrey JAFFEUX
236adc9ccb
FIX: shows parent category name in title anchor ( #7576 )
2019-05-21 08:33:22 +02:00
Osama Sayegh
0b5924d61e
Refactor keyboard shortcuts modal to fix RTL locales ( #7545 )
...
* Refactor keyboard shortcuts modal to fix RTL locales
* Feedback
* Remove lowercase modifier keys
2019-05-21 06:39:32 +03:00
Joffrey JAFFEUX
bc8c77723e
FIX: puts focus-event at application level ( #7568 )
...
Also attempts to use simpler and newer APIs
2019-05-20 13:48:03 +02:00
Gerhard Schlager
b788948985
FEATURE: English locale with international date formats
...
Makes en_US the new default locale
2019-05-20 13:47:20 +02:00
Joffrey JAFFEUX
9bbf421125
FIX: better node check for clickoutside in widgets ( #7573 )
2019-05-20 12:45:33 +02:00
Joffrey JAFFEUX
0ddfeb9c64
FIX: ensures mousetrap is reset with the application ( #7569 )
2019-05-20 10:45:31 +02:00
Osama Sayegh
14bae6d52d
Make email_excerpt method take an optional post param ( #7570 )
...
The spoiler alert plugin replaces spoiler text found in email excerpts with posts URL, which means it needs to have a reference to the post it's processing.
This change makes `email_excerpt` accepts an optional post param, which calls `PrettyText.format_for_email` which then triggers the `reduce_cooked` event that the plugin subscribes to.
2019-05-20 10:04:23 +02:00
Kris
7eea2e35e4
Upload image preview needs width on desktop
2019-05-17 11:25:35 -04:00
Joffrey JAFFEUX
b05d7042ae
FIX: prevents events on toolbar when in form ( #7567 )
...
If a button is not of type button, pressing enter inside an `<input>` inside a `<form>` without the action attribute will trigger the first available `<button>` as most browsers default the type of an unspecified button to submit.
This commit also prevents d-editor-modal to be filled when it's hidden.
2019-05-17 11:14:09 +02:00
Guo Xiang Tan
148bfc9be5
DEV: Simplify client and server side code to support removing tags.
...
Follow up to 834c86678f
2019-05-17 16:39:20 +08:00
David Taylor
5666316285
FEATURE: Display 'last updated' on dashboard, improve release notes link ( #7560 )
2019-05-17 15:42:45 +10:00
Guo Xiang Tan
834c86678f
FIX: Missing post revision when editing the first post.
2019-05-17 12:54:27 +08:00
Guo Xiang Tan
e2444e0d31
DEV: Fix another frozen string error.
2019-05-17 10:07:37 +08:00
Sam Saffron
25137554ed
FIX: _.include is no longer imported from lodash
...
Instead use toArray and indexOf which is also clearer
2019-05-17 08:58:39 +10:00
Kris
80b3560050
IE11: Login form needs full flex shorthand
2019-05-16 14:07:49 -04:00
Robin Ward
225593d445
FIX: Small tweak to percentiles based on feedback
2019-05-16 13:45:36 -04:00
Joffrey JAFFEUX
ad4d01233b
DEV: attempts to make d-editor tests more resilient ( #7556 )
2019-05-16 14:42:01 +02:00
Joffrey JAFFEUX
244c03573a
FIX: btn class was duplicated on admin-menu-buttons ( #7555 )
2019-05-16 14:37:53 +02:00
Joffrey JAFFEUX
0c6ebe66ce
EXPERIMENTAL: clicks outside seem unreliable with absolute nodes ( #7557 )
2019-05-16 14:37:37 +02:00
Joffrey JAFFEUX
1afe6d0aee
FIX: share-and-invite modal was too narrow ( #7559 )
2019-05-16 14:37:19 +02:00
Vinoth Kannan
0e677daaee
FIX: include posts with data-orig-src attribute in have_uploads scope query.
2019-05-16 16:39:38 +05:30
Vinoth Kannan
56ada8374f
DEV: wrap find_missing_uploads method in distributed mutex
...
And skip posts with deleted topics.\ne8fafbc123170dd1f7d2a8adea4e7810585d3e76
2019-05-16 15:17:53 +05:30
Régis Hanol
a5a4f9dc1a
DEV: make prettier happy
...
(cc @jjaffeux)
2019-05-16 11:38:47 +02:00
Joffrey JAFFEUX
d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 ( #7546 )
2019-05-16 10:34:19 +02:00
Guo Xiang Tan
a36fe019bb
DEV: Fix race condition when enqueuing edit wiki-ed notification.
2019-05-16 13:48:46 +08:00
Vinoth Kannan
636b75fa16
REFACTOR: remove duplicate reject loop and implicit return
...
e8fafbc123
2019-05-16 10:04:04 +05:30
Guo Xiang Tan
227bedebf7
DEV: Fix modifying a frozen string.
2019-05-16 11:30:31 +08:00
Kris
7cd1067f3d
FIX: Select-kit too narrow in topic timer
2019-05-15 17:58:40 -04:00
Régis Hanol
501bee56b7
Make prettier happy
2019-05-15 23:46:50 +02:00
Neil Lalonde
7eea55d564
PERF: remove "new posts" stat from summary email
...
It performs horribly and isn't a personalized stat like the others.
2019-05-15 16:28:21 -04:00
Régis Hanol
db89722a98
UX: ignore leading/trailing whitespaces in site settings search
2019-05-15 22:22:20 +02:00
Bianca Nenciu
b9fcb2bcdf
DEV: Add before button hook in post-menu. ( #7550 )
2019-05-15 22:48:23 +03:00
Kris
0ef25f7a66
prettier
2019-05-15 13:35:58 -04:00
Kris
a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles ( #7549 )
2019-05-15 13:26:25 -04:00
Maja Komel
9a17b19636
FIX: don't hide back button at the bottom of timeline ( #7544 )
2019-05-15 19:02:48 +02:00
Penar Musaraj
fc5bb39096
FIX: Do not send duplicate alerts for the same post ( #7476 )
2019-05-15 18:47:36 +02:00
David Taylor
1299c94a52
FIX: Make serverside and clientside omniauth origin redirects consistent
...
Previously external domains were allowed in the client-side redirects, but not the server-side redirects. Now the behavior is to only allow local origins.
2019-05-15 12:40:51 +01:00
Bianca Nenciu
1d3375b176
FEATURE: Preserve notifications levels when splitting topics. ( #7494 )
2019-05-15 17:29:29 +10:00
Vinoth Kannan
42b10a646d
FIX: return 404 only if upload url also not internal.
2019-05-15 02:06:54 +05:30
Maja Komel
e0fe01925e
FIX: make frozen string mutable in incoming_domain
2019-05-14 17:44:53 +02:00
Joffrey JAFFEUX
d127119549
REFACTOR: user-selector take 2 ( #7540 )
2019-05-14 09:43:29 +02:00
Sam Saffron
624184560e
PERF: improve performance of publish_notifications_state
...
User.publish_notifications_state is called every time a notification is
created, this can become a very critical code path.
On some heavy notification related sites this can be a major CPU user on PG
This index makes it much cheaper to publish notification state, cause a
simple index lookup does the trick.
2019-05-14 16:02:55 +10:00
Neil Lalonde
6f747c6b71
FIX: don't allow username to be changed to same as password
...
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
2019-05-13 16:43:40 -04:00
Gerhard Schlager
bbab60fa9b
FIX: Don’t try to delete inactive moderators
...
follow-up to 6d77156a
2019-05-13 21:44:03 +02:00
Régis Hanol
7707d5db2d
Revert "REFACTOR: user-selector ( #7529 )"
...
This reverts commit 9a56df89f0
2019-05-13 19:39:30 +02:00
Arpit Jalan
a2b1789c3e
FIX: do not log username change if the save process was unsuccessful
2019-05-13 22:20:27 +05:30
Robin Ward
fb1da53dff
FIX: Issue with incorrect heights when cloaking plugin content in posts
...
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.
Co-authored-by: nlalonde
Co-authored-by: pmusaraj
2019-05-13 11:29:21 -04:00
Joffrey JAFFEUX
7326ddea6d
REFACTOR: tags mixin ( #7533 )
2019-05-13 17:05:21 +02:00
Joffrey JAFFEUX
b8db702a02
REFACTOR: admin-user-index route ( #7534 )
2019-05-13 17:04:41 +02:00
Joffrey JAFFEUX
717aa764b6
FIX: more efficient topic-footer-button-api ( #7535 )
2019-05-13 17:04:24 +02:00
David Taylor
750c125707
DEV: Include foreign keys in model annotations
2019-05-13 15:53:42 +01:00
Penar Musaraj
607c671003
Fix string literal when switching theme in dev env
2019-05-13 10:25:51 -04:00
Penar Musaraj
f1b0782624
UI: Adjust footer nav bar size in iOS app
2019-05-13 10:25:51 -04:00
David Taylor
1bff81419e
DEV: Update annotations
2019-05-13 15:24:24 +01:00
Gerhard Schlager
53d2232731
FIX: Remove trailing slash from topic URL
...
this lead to duplicate slashes in concatenated URLs
2019-05-13 14:51:45 +02:00
Joffrey JAFFEUX
df18243827
FIX: prevents exception if report doest define filters ( #7532 )
2019-05-13 13:34:28 +02:00
Joffrey JAFFEUX
9a56df89f0
REFACTOR: user-selector ( #7529 )
2019-05-13 13:03:12 +02:00
Arpit Jalan
25b39b86ae
FIX: reload the user record instead of fetching via email
2019-05-13 15:16:53 +05:30
Joffrey JAFFEUX
e64ed9dbc1
REFACTOR: edit-category controller ( #7527 )
2019-05-13 11:30:32 +02:00
Guo Xiang Tan
64c117519e
Fix modifying frozen strings errors take 3.
2019-05-13 16:45:23 +08:00
Guo Xiang Tan
74989783da
Fix modifying frozen strings error in OneboxController.
2019-05-13 16:25:52 +08:00
Guo Xiang Tan
b584e30902
Fix modifying frozen strings error take 2.
2019-05-13 16:23:45 +08:00
Joffrey JAFFEUX
9b75320d63
FIX: track mutations on topic edit category-chooser only on select ( #7528 )
2019-05-13 10:22:28 +02:00
Sam Saffron
d643294c9d
FIX: delete duplicate invites earlier in the process
...
There was a race condition when 2 invites existed for 1 user where in some
cases data from both invites would be used for the redeem. Depending on DB
ordering.
Fix is to delete duplicate invites earlier in the process prior to
`redeem_from_email` being called.
2019-05-13 17:42:39 +10:00
Gerhard Schlager
81c329fbb8
FIX: Customizing missing pluralized translations didn't work
2019-05-13 09:36:05 +02:00
Guo Xiang Tan
d369b84ced
Fix modifying frozen strings error.
2019-05-13 14:31:20 +08:00
Guo Xiang Tan
8165ceb320
Make rubocop happy.
2019-05-13 09:55:44 +08:00
Sam Saffron
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
Penar Musaraj
a859ddc77e
Improve theme/component delete modal warning
2019-05-10 14:14:12 -04:00
Joffrey JAFFEUX
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases ( #7525 )
2019-05-10 17:12:10 +02:00
Robin Ward
643c75c419
FIX: Don't increment version if the reviewable operation fails
...
In fact, roll back the entire operation in the database.
2019-05-10 09:53:25 -04:00
David Taylor
abbe812a0d
FIX: Correct CSS for instagram video play icon
2019-05-10 10:46:07 +01:00
Joffrey JAFFEUX
4096d559b5
REFACTOR: user-stream model ( #7515 )
2019-05-10 10:05:43 +02:00
Joffrey JAFFEUX
a85b7feef4
REFACTOR: composer controller ( #7516 )
2019-05-10 10:05:29 +02:00
Joffrey JAFFEUX
7aedc92a35
REFACTOR: login-controller ( #7514 )
2019-05-10 10:05:11 +02:00
Guo Xiang Tan
63a3caa516
FIX: Don't display option for users to flag and notify a bot.
2019-05-10 10:05:03 +08:00
Sam Saffron
0ab6c6e24e
PERF: speed up spec suite, avoid featuring topics
...
Before: 6:05
After: 5:42
Featuring topics for `list/categories` is a very expensive operation that
happened each time we created a topic. This introduces a test only bypass
2019-05-10 11:37:53 +10:00
Gerhard Schlager
34684af195
FIX: Show error message if message exists
2019-05-09 22:12:51 +02:00
Robin Ward
b380ed5282
FEATURE: Claim Reviewables by Topic
...
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
Bianca Nenciu
8dfb15a2e5
FIX: Do not show self edits in Post Edits report. ( #7510 )
2019-05-09 20:39:17 +03:00
Bianca Nenciu
ea3004ef11
UX: Save scroll position in tags topic list. ( #7511 )
2019-05-09 20:39:03 +03:00
Penar Musaraj
2a45933ff2
FIX: reduce iPad app nav padding
2019-05-09 10:25:22 -04:00
Dan Ungureanu
c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. ( #7509 )
2019-05-09 14:08:10 +03:00
Guo Xiang Tan
4e91839c97
FIX: Remove default val for colors step if a default theme has been set.
...
Running through the wizard after a default theme has been configured
will always revert the default theme to the light theme.
2019-05-09 17:25:09 +08:00
Joffrey JAFFEUX
977ffa20f4
FIX: variable is different from key ( #7512 )
2019-05-09 10:03:33 +02:00
Arpit Jalan
427979e7e5
FEATURE: use full screen login by default for social login methods ( #7481 )
2019-05-09 10:03:01 +05:30
Guo Xiang Tan
8ec1f8cf07
DEV: Correct naming convention for JS file.
2019-05-09 10:18:29 +08:00
Vinoth Kannan
8c07c272f2
make rubocop happy.
2019-05-09 05:25:44 +05:30
Vinoth Kannan
87cd4701b8
FEATURE: option to skip posts with ignored missing uploads
2019-05-09 05:11:15 +05:30
Joffrey JAFFEUX
e6cfc584d0
Revert "FIX: frozen string exception ( #7506 )"
...
This reverts commit c4b7fb2754
2019-05-08 17:27:09 +02:00
Joffrey JAFFEUX
497c0ba418
Revert "FIX: frozen string exception ( #7505 )"
...
This reverts commit 2938e3f033
2019-05-08 17:27:03 +02:00
Maja Komel
24ca074f3f
FIX: short description title on client side when empty description
...
follow-up 77af097c
2019-05-08 17:07:12 +02:00
David Taylor
e84531a6a6
FIX: Correctly clear theme stylesheet cache when changing color scheme
2019-05-08 16:02:55 +01:00
Joffrey JAFFEUX
54c2f24ee9
REFACTOR: composer model ( #7499 )
2019-05-08 16:53:12 +02:00
Joffrey JAFFEUX
2938e3f033
FIX: frozen string exception ( #7505 )
...
Initial backtrace:
```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```
* this might fail too
2019-05-08 16:52:38 +02:00
Joffrey JAFFEUX
4aaee7ee35
REFACTOR: change-timestamp controller ( #7498 )
2019-05-08 16:26:51 +02:00
Joffrey JAFFEUX
c4b7fb2754
FIX: frozen string exception ( #7506 )
...
Initial backtrace:
```
/var/www/discourse/app/models/incoming_domain.rb:29:in `to_url'
/var/www/discourse/app/models/incoming_link.rb:83:in `referer'
/var/www/discourse/app/models/incoming_link.rb:106:in `referer_valid'
```
2019-05-08 16:25:54 +02:00
Robin Ward
b409dab77f
Rename flags_default_topics to reviewable_default_topics
...
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
2019-05-08 10:07:10 -04:00
Maja Komel
77af097ce0
FIX: add short description to title on client side
2019-05-08 15:03:33 +02:00
David Taylor
b717e23ceb
FIX: Dynamically adjust scale when rendering wizard canvases
...
This was a typo in fd0de64
2019-05-08 13:14:28 +01:00
Bianca Nenciu
861023f0d6
FIX: Skip attachments in click track.
2019-05-08 11:55:31 +03:00
Guo Xiang Tan
f04518fdf9
DEV: Reduce number of jobs enqueued.
...
Apply code review suggestion from
405ba00c08
2019-05-08 15:58:08 +08:00
Guo Xiang Tan
405ba00c08
FEATURE: Create notifications on wiki edits for watching users.
...
* Moves creation of notification into background job.
2019-05-08 15:31:10 +08:00
Guo Xiang Tan
46ea69a73c
UX: Initialize client side category model with right search_priority.
...
This is strictly a UX change since the default value of the column is 0.
2019-05-08 14:16:20 +08:00
Robin Ward
5af7c90bab
FEATURE: Hide Reviewable scores, change score filter to Priority
...
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.
You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
Blake Erickson
5b5b5a5931
FIX: return an error if a user tries to whisper
...
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.
https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
2019-05-07 11:42:26 -06:00
Joffrey JAFFEUX
626534ad94
FIX: lighten instead of adding transparency to consolidated pageviews ( #7495 )
2019-05-07 18:14:13 +02:00
Roman Rizzi
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign ( #7497 )
2019-05-07 12:25:10 -03:00
Saurabh Patel
e20f13ebb7
fix css of prev and next page links, move them to bottom of page ( #7465 )
...
Thanks 👍
2019-05-07 17:04:27 +02:00
Penar Musaraj
446ec1b44a
Set input and textarea font size to 16px on iOS ( #7480 )
2019-05-07 10:44:43 -04:00
Bianca Nenciu
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
Arpit Jalan
ed70595314
UX: add information about the use of permalinks
2019-05-07 17:13:26 +05:30
Bianca Nenciu
71fb8a4195
DEV: Fix failing click-track tests.
2019-05-07 13:54:12 +03:00
Joffrey JAFFEUX
4bbb34f7cb
REFACTOR: admin-user ( #7475 )
2019-05-07 10:53:21 +02:00
Joffrey JAFFEUX
f73ed45429
REFACTOR: color-scheme model ( #7477 )
2019-05-07 10:51:52 +02:00
Joffrey JAFFEUX
9507eff927
REFACTOR: resumable-upload ( #7474 )
2019-05-07 10:51:11 +02:00
Bianca Nenciu
4ff1195537
FEATURE: Use Beacon API for tracking clicks. ( #7483 )
2019-05-07 16:37:43 +10:00
Joe
cf99431c18
Fix like and flag button count alignment ( #7487 )
2019-05-07 16:34:29 +10:00
Guo Xiang Tan
abbc639e0d
FIX: Only unregister service workers that belongs to Discourse.
2019-05-07 13:08:06 +08:00
Arpit Jalan
03169401ff
UX: correct order of site statistics on /about page
2019-05-07 09:50:41 +05:30
Guo Xiang Tan
451f7842ff
DEV: More send -> public_send.
2019-05-07 10:05:58 +08:00
Sam Saffron
cac80cdc3b
DEV: more send -> public_send changes
...
This is a work in progress commit for more send to public_send conversions
Also adds some comments for cases where we need to keep send
2019-05-07 11:58:06 +10:00
Guo Xiang Tan
61cc0f8c5f
Follow up to 152238b4cf.
2019-05-07 09:57:27 +08:00
Guo Xiang Tan
152238b4cf
DEV: Prefer public_send over send.
2019-05-07 09:33:21 +08:00
Sam Saffron
9be70a22cd
DEV: introduce new API to look up dynamic site setting
...
This removes all uses of both `send` and `public_send` from consumers of
SiteSetting and instead introduces a `get` helper for dynamic lookup
This leads to much cleaner and safer code long term as we are always explicit
to test that a site setting is really there before sending an arbitrary
string to the class
It also removes a couple of risky stubs from the auth provider test
2019-05-07 11:00:30 +10:00
Robin Ward
47995d2d89
FIX: Your own likes were missing on posts
2019-05-06 20:03:50 -04:00
Robin Ward
31e100530f
FEATURE: Flag count in post menu
...
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.
We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
Penar Musaraj
5e546ba7d1
Standardize viewport rules for mobile and desktop
...
Also removes`maximum-scale` on non-mobile devices, better for accessibility.
2019-05-06 10:28:29 -04:00
Régis Hanol
e2e72f4e8e
DEV: rename ReadOnly module to ReadOnlyHeader
2019-05-06 16:07:49 +02:00
Dan Ungureanu
33e06dd796
FIX: Make select all and below skip small actions. ( #7425 )
2019-05-06 16:22:11 +03:00
Dan Ungureanu
a40dcbde9b
FIX: Do not move hidden post actions. ( #7424 )
...
Hidden (staff-only) post actions are whisper posts with no content, that
are later transformed by the client into post actions (discourse-assign
uses this).
2019-05-06 16:21:42 +03:00
Guo Xiang Tan
8217d5be78
UX: Switch mobile header back for 5s when notification comes in.
2019-05-06 16:58:25 +08:00
Sam Saffron
f8eddd40ad
PERF: remove avg_time calculations and regular jobs from posts and topics
...
After careful analysis of large data-sets it became apparent that avg_time
had no impact whatsoever on "best of" topic scoring. Calculating avg_time
was a very costly operation especially on large databases.
We have some longer term plans of introducing other weighting that is read
time based into our scoring for "best of" and "top" topics, but in the
interim to stop a large amount of work that is not achieving any value we
are removing the jobs.
Column removal will follow once we decide on a new replacement metric.
2019-05-06 15:59:01 +10:00
Guo Xiang Tan
ba3cf7109c
DEV: Remove unused lines of code.
2019-05-06 13:48:51 +08:00
Sam Saffron
267d129f38
FEATURE: only scroll to bottom for discobot
...
Non discobot replies on PMs triggering scroll cause confusion.
2019-05-06 10:55:58 +10:00
Robin Ward
99a2a769d4
FIX: Conflict error (version was already used)
2019-05-03 16:36:37 -04:00
Vinoth Kannan
e8fafbc123
List and restore missing post uploads from S3 inventory.
2019-05-04 01:16:20 +05:30
David Taylor
d82da69c2c
FIX: Fail gracefully if username parameter is missing when creating user
2019-05-03 17:17:06 +01:00
Robin Ward
15c9b00307
FEATURE: Show edit indicator on review queue
...
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
2019-05-03 11:21:33 -04:00
Joffrey JAFFEUX
5f78bbebe9
FIX: forces a reload of emoji list if clicked on more ( #7473 )
...
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
2019-05-03 16:11:03 +02:00
Régis Hanol
0d41d58d27
FIX: add ReadOnly hear to /srv/status
2019-05-03 12:21:07 +02:00
Sam Saffron
16ef060a76
DEV: correct Rails 6 deprecation
...
render template is backwards compatible with Rails 5, code is simpler.
Thanks @jhawthorn, this is our last Rails 6 deprecation
2019-05-03 16:20:18 +10:00
Penar Musaraj
b948d97c8f
FEATURE: Show diff of local changes before updating remote theme ( #7443 )
2019-05-02 21:43:54 -04:00
Sam Saffron
3dc4ab905c
DEV: annotate models
...
(also looks like renaming of bigint(8) -> bigint in annotate
which seems fine)
2019-05-03 08:34:12 +10:00
Robin Ward
3cb0d27d38
DEV: Upgrade our widget handlebars compiler
...
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
2019-05-02 15:47:57 -04:00
Joffrey JAFFEUX
e696903c31
FIX: uses translatedTitle to check validity of topic footer btn ( #7472 )
2019-05-02 20:56:27 +02:00
Joffrey JAFFEUX
35212036f2
FIX: ensures click on topic link has link for target and not children ( #7471 )
2019-05-02 13:43:02 +02:00
Guo Xiang Tan
d252dad4f0
FIX: Can't remove user profile uploads.
...
Follow up to 24347ace10
2019-05-02 16:54:10 +08:00
Guo Xiang Tan
ebca588fd0
DEV: Remove unused line of code.
2019-05-02 16:54:10 +08:00
Joffrey JAFFEUX
75591664e7
FIX: better handling of category filter deselection ( #7468 )
2019-05-02 10:03:12 +02:00
Guo Xiang Tan
d5c9ac7196
PERF: Use cdn when serving site settings upload.
2019-05-02 15:35:07 +08:00
Guo Xiang Tan
24347ace10
FIX: Properly associate user_profiles background urls via upload id.
...
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
2019-05-02 14:58:24 +08:00
Sam Saffron
96360a779f
DEV: add a few frozen string literals
2019-05-02 16:57:12 +10:00
Sam Saffron
1be01f8dd4
DEV: Add support for Rails 6
...
Minor fixes to add Rails 6 support to Discourse, we now will boot
with RAILS_MASTER=1, all specs pass
Only one tiny deprecation left
Largest change was the way ActiveModel:Errors changed interface a
bit but there is a simple backwards compat way of working it
2019-05-02 16:23:25 +10:00
Joe
5a834a05ea
FIX: crawler layout CSS adjustments ( #7469 )
...
* Fix header size to fit the viewport
Setting the header to border-box means that the padding is factored in when calculating its width. If this is not done, the header width would be 100% of the viewport width + any padding when set on it. That causes some parts of the header to be rendered off-screen and causes horizontal scrolling.
* prevent code in posts from causing horizontal overflow
We are currently not wrapping code in posts in the crawler view. This affects both unformatted code and inline code blocks. This commit forces such code to wrap in order to prevent horizontal overflow which the Google bot complains about since it causes some content to be rendered outside of the viewport for the mobile crawler.
2019-05-02 13:00:29 +08:00
Sam Saffron
157dc5e298
FEATURE: disable native share API on non tablets/phones
...
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
2019-05-02 13:18:29 +10:00
Robin Ward
885f1e7e5f
FIX: Allow category group reviewers to edit queued posts
...
They can edit title, body and tags. Category is disabled for now as it
could lead to some odd security issues.
2019-05-01 14:48:49 -04:00
Robin Ward
0f01c9d25f
FIX: Posts in the approval queue were sometimes dropping category
2019-05-01 14:40:38 -04:00
Arpit Jalan
b5ea50a154
FIX: use full screen login for new-topic route ( #7467 )
...
DEV: add javascript tests for new-topic and new-message routes
DEV: fix an existing test that was being skipped
2019-05-01 22:54:29 +05:30
Vinoth Kannan
7869a10d18
Revert "FEATURE: Added unlisted topics option to advanced search ( #7447 )"
...
This reverts commit 539723f8ff
2019-05-01 21:06:20 +05:30
Joffrey JAFFEUX
ae493f4722
UX: fills picker with emoji autocomplete state on more click ( #7466 )
2019-05-01 16:19:45 +02:00
David Taylor
0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons ( #7372 )
...
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.
## Core
- Adds an SiteIconManager module which manages automatic resizing and fallback
- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon).
- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.
- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations
## Wizard
- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload
- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"
- Various copy updates to support the changes
- Remove the "upload-time" resizing for `large_icon`. This is no longer required.
## Site Settings UX
- Move logo/icon settings under a new "Branding" tab
- Various copy changes to support the changes
- Adds placeholder support to the `image-uploader` component
- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings
- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name
## Dashboard Warnings
- Remove PWA icon and PWA title warnings. Both are now handled automatically.
## Bonus
- Updated the sketch logos to use @awesomerobot's new high-res designs
2019-05-01 14:44:45 +01:00
Vinoth Kannan
9c78c18256
Check both site and global setting for s3 enabled value.
2019-05-01 10:49:53 +05:30
Arpit Jalan
c6409fd2cc
FIX: pass correct date arguments to server when exporting CSV
2019-05-01 10:46:30 +05:30
Arpit Jalan
002e1f560a
FIX: initialize empty object if no custom filters are present
2019-05-01 10:27:19 +05:30
Tim Lange
539723f8ff
FEATURE: Added unlisted topics option to advanced search ( #7447 )
2019-05-01 12:31:13 +10:00
Robin Ward
404b35bd04
FEATURE: Category Reviewable by Group
...
Allow a group to review content in a particular category.
2019-04-30 15:23:06 -04:00
Robin Ward
dd29af4475
REFACTOR: {{avatar}} and {{date}} helpers in vdom templates
...
This is a step towards a nicer flag display under posts.
2019-04-30 15:22:38 -04:00
Roman Rizzi
404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin ( #7433 )
2019-04-30 15:36:54 -03:00
Robin Ward
812905cbb6
FIX: Recursively delete nested replies
...
Previously we were only deleting top level replies
2019-04-30 12:54:53 -04:00
David Taylor
5edb5c8b03
FIX: Mark invited admins as 'approved' ( #7459 )
...
This prevents invited admins appearing as no-op reviewables in the queue when invite_only or require_approval is enabled.
2019-04-30 17:26:39 +01:00
David Taylor
583226d295
FIX: Linking to /new-topic from /latest
...
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.
This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.
Unfortunately I have not been able to reproduce the issue in a QUnit test.
2019-04-30 16:25:25 +01:00
Joffrey JAFFEUX
8e68244eea
FIX: prevents google to track certain pages ( #7463 )
2019-04-30 15:57:51 +02:00
Joffrey JAFFEUX
726dd0fe37
Revert "FIX: prevents google to track certain pages ( #7455 )"
...
This reverts commit c863e62998
2019-04-30 10:17:12 +02:00
Guo Xiang Tan
587cfd4545
DEV: Use frozen_string_literal: true on models/theme.rb.
2019-04-30 16:02:55 +08:00
Joffrey JAFFEUX
c863e62998
FIX: prevents google to track certain pages ( #7455 )
2019-04-30 13:59:55 +08:00
Rafael dos Santos Silva
1fdeec564b
PERF: Move where clause up to speed up CalculateAvgTime daily job ( #7462 )
...
Cuts down affected posts earlier in the query, so the generated plan
deals with less rows, and runs faster.
https://meta.discourse.org/t/post-calculate-avg-time-taking-up-a-long-time/49750/13?u=falco
2019-04-30 13:34:46 +10:00
Guo Xiang Tan
dca7f8ecf2
FIX: Loading more broken on groups page.
...
Regressed in 1f17d52f55
2019-04-30 10:35:17 +08:00
Neil Lalonde
a00354f11f
Prettier site-settings/group-list.js.es6
2019-04-29 16:26:13 -04:00
Neil Lalonde
1ba72ccab8
DEV: add site setting type group_list for a list of groups
...
Add a js test
2019-04-29 16:15:22 -04:00
Rafael dos Santos Silva
526e76ced2
FIX: Use PostgreSQL 'ON CONFLICT' to deal with race condition
...
On busy sites, concurrent requests to insert into post_timings can
occur, which was dealt with using Ruby exceptions.
This moves the handling to PostgreSQL which makes it a bit faster,
and prevents a spam of ERROR in the database logs.
2019-04-29 16:34:42 -03:00
Penar Musaraj
bfadb1fabc
FIX: use more specific target for ".tag-box"
...
This avoids tags named "box" from receiving styling aimed at this specific element on the tag list page.
2019-04-29 13:55:40 -04:00
Neil Lalonde
f8f7091e57
FIX: staff-only tags visible on /tags page when restricted to a category
...
If a tag group is set to only be visible to staff, and is restricted
to a category that is visible by everyone, the tags in the group were
being shown on the /tags page. They weren't visible anywhere else.
This commit fixes it so they don't show on the /tags page.
2019-04-29 12:38:28 -04:00
Penar Musaraj
b75720d911
FIX: skip click-tracking for mentions
2019-04-29 12:05:47 -04:00
Gerhard Schlager
876c4f20b3
FIX: Remove duplicate Emoji names from blurb
...
The blurb contained the value of the alt and title attribute of Emojis. Both values are always the same.
2019-04-29 17:26:39 +02:00
Gerhard Schlager
71d19f6e1f
FIX: Reduce mentions in blurbs to @username or @groupname
...
The link to the user profile or group is useless and the URL encoded username or group name looks awful for Unicode names
2019-04-29 17:26:39 +02:00
Joffrey JAFFEUX
5768011cad
FIX: prevents exception in the composer with regexp flags
2019-04-29 16:58:17 +02:00
Penar Musaraj
629ae7a5b7
FIX: Revert tracking links in quotes
2019-04-29 10:30:04 -04:00
Bianca Nenciu
aef35faefc
FIX: Open links in external tabs. ( #7444 )
2019-04-29 10:27:29 -04:00
Penar Musaraj
ca9fd95a08
FIX: Respect "open external links in new window" in quotes and edit history
2019-04-29 10:13:53 -04:00
Gerhard Schlager
7a27c93c03
FIX: URL encode username and first letter in avatar URL
...
And it adds specs as a follow-up to aadb7da7
2019-04-29 15:08:14 +02:00
Joffrey JAFFEUX
286f2abc65
FIX: prevents exception when clicking directly on site text
2019-04-29 12:07:30 +02:00
Sam Saffron
ac3dab93f5
DEV: lint the files
2019-04-29 17:40:53 +10:00
Sam Saffron
45285f1477
DEV: remove update_attributes which is deprecated in Rails 6
...
See: https://github.com/rails/rails/pull/31998
update_attributes is a relic of the past, it should no longer be used.
2019-04-29 17:32:25 +10:00
Saurabh Patel
1b1cfd4507
add no_subcategories query param in url only if its true ( #7439 )
2019-04-29 15:10:59 +08:00
Joffrey JAFFEUX
fe86941cb6
FIX: prevents exception when search q params is a hash ( #7437 )
...
* FIX: prevents exception when searh q params is a hash
* raise when invalid format
2019-04-29 15:09:25 +08:00
Tim Lange
574f39f9d0
FIX: Fixed uploadPlaceholder regex failing on not escaped characters ( #7442 )
2019-04-29 12:32:48 +10:00
Joffrey JAFFEUX
de79313f62
FIX: ensures file extension doesnt have a leading point ( #7449 )
2019-04-27 14:00:51 +02:00
Joffrey JAFFEUX
6952510fc4
FIX: restores skipHeader computed property
2019-04-26 23:43:49 +02:00
Tim Lange
1486328756
UX: Changed post stream placeholder to animation ( #7434 )
2019-04-26 17:29:48 +01:00
Sam Saffron
8fc2b0124f
PERF: destroy users in batches of 50 users
...
This speeds up the process as we no longer need to commit a transaction
per user deleted
2019-04-26 22:51:33 +10:00
Sam Saffron
b8c65cc6cf
PERF: add index on user auth tokens (for user lookups)
...
This speeds up user destroy cause we cascade looking up all the tokens
for a user
2019-04-26 22:38:54 +10:00
Sam Saffron
378fe1c1cf
PERF: allow looking up incoming email by user_id
...
This speeds up the ability to remove users from the system
2019-04-26 22:33:01 +10:00
Sam Saffron
26b4dbde41
PERF: use delete_all to remove notifications and topic_users
...
Previously we used destroy here which could be extremely expensive
2019-04-26 22:26:48 +10:00
Joffrey JAFFEUX
bcca2b5d73
FEATURE: initial implementation of generic filters for reports
2019-04-26 12:17:10 +02:00
Maja Komel
4b455e741e
DEV: Ember 3.8.0
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-04-26 12:16:21 +02:00
Sam Saffron
c617e512ad
annotate new indexes
2019-04-26 18:23:27 +10:00
Sam Saffron
c009a6ae36
PERF: speed up user deletion logic
...
Previously any user deletion would scan a very large number of tables
This avoids scans on 6 tables/indexes on delete
2019-04-26 18:11:39 +10:00
Vinoth Kannan
be0ae2e487
FIX: plain text table detection should work even if html content not found.
2019-04-26 11:16:41 +05:30
Vinoth Kannan
dc2ee78f7a
UX: Only do plain text table detection in outside code if HTML pasting enabled
...
Co-authored-by: Tim Lange <tim.lange@titanhq.de>
PR: https://github.com/discourse/discourse/pull/7436
2019-04-26 09:20:21 +05:30
Guo Xiang Tan
abecb3aea8
Update annotations.
2019-04-26 10:36:21 +08:00
romanrizzi
34b772575e
FIX: Return 'failed' attribute when catching an ajax error and the attribute is present
2019-04-25 14:49:52 -03:00
Guo Xiang Tan
761e1e25f7
Remove tables incorrectly excluded in Upload.migrate_to_new_scheme.
...
Follow up to 4a03b21f80
2019-04-25 20:27:52 +08:00
Joffrey JAFFEUX
7cbc4c1e46
FIX: uses no tags label for tag-drop header ( #7438 )
2019-04-25 13:16:06 +02:00
Gerhard Schlager
6d77156a94
FIX: Don't try to delete inactive admins
2019-04-25 11:59:50 +02:00
Maja Komel
422237391e
FIX: fix notifications for flag PMs and show topics with moderator posts in inbox ( #7331 )
...
Some old moderator posts that were not correctly processed before this change and 993d8f34
2019-04-25 11:15:13 +02:00
Maja Komel
996e5e5dfa
FIX: category list order using category featured topics ( #7283 )
2019-04-25 11:07:19 +02:00
Joffrey JAFFEUX
e386fa7674
FIX: ensures we have touches when starting pan event ( #7435 )
2019-04-25 10:36:41 +02:00
Tarek Khalil
d8ff94ecaa
FEATURE: Ignoring users from the preferences page in a cleaner way ( #7289 )
...
* FEATURE: Ignoring users from the preferences page in a cleaner way
2019-04-25 09:26:49 +01:00
Vinoth Kannan
84cfe30c1f
Use update_all instead of save to select and update particular columns
...
9ec6ef85b6
2019-04-25 11:56:57 +05:30
Guo Xiang Tan
4a03b21f80
Exclude large tables when remapping in Upload.migrate_to_new_scheme.
...
Those tables do not carry any information about uploads.
2019-04-25 11:55:48 +08:00
Gerhard Schlager
aadb7da7d3
FIX: Use first grapheme cluster for letter avatar
2019-04-24 23:20:46 +02:00
Gerhard Schlager
03f9564804
FIX: Handle missing letter avatar
2019-04-24 23:20:46 +02:00
Dan Ungureanu
3aa143a52c
SECURITY: Fix tab nabbing.
2019-04-25 00:11:28 +03:00
Kris
505c5addca
Allow signup form width to increase when no external logins are present
2019-04-24 13:08:39 -04:00
Penar Musaraj
6df8c4b8f0
FIX: Fall back to large logo on mobile no_ember pages
2019-04-24 11:39:11 -04:00
Tarek Khalil
e4d8d80cf8
FIX: Make sure we hide the first post in a topic by an ignored user ( #7428 )
2019-04-24 16:00:20 +01:00
Penar Musaraj
1a8c6577e0
FIX: refactor padding when exiting composer
...
Previously, when existing composer, the `#main-outlet` element padding was set to zero. This inline style would override any CSS set for that element, causing issues with the mobile footer nav.
The fix removes the inline padding style instead of setting it to zero. It also uses integers for the set values, and removes a duplicate style.
2019-04-24 10:26:35 -04:00
Tarek Khalil
ad61d87ffb
FIX: Do not replace text of collapsed ignore posts ( #7422 )
2019-04-24 13:54:46 +01:00
Penar Musaraj
a452933071
FIX: disable input zoom on search in iOS
2019-04-24 08:41:20 -04:00
Guo Xiang Tan
be88ac8b7e
Additional old Upload#url format for Upload.migrate_to_new_scheme.
2019-04-24 18:19:25 +08:00
Guo Xiang Tan
9ec6ef85b6
Don't validate post when saving in Upload.migrate_to_new_scheme.
2019-04-24 17:17:31 +08:00
Guo Xiang Tan
3c9495b989
DEV: Put a mutex around Upload.migrate_to_new_scheme.
...
This ensures that only one migration is running at any given point in
time across the instances.
2019-04-24 17:07:10 +08:00
Guo Xiang Tan
55f406bb79
Follow up to 845b68f9ab.
2019-04-24 16:57:45 +08:00
Tim Lange
104a9e79f9
UX: User card loading ( #7404 )
2019-04-24 11:55:09 +03:00
Joffrey JAFFEUX
7334362b77
FEATURE: generic theme component bbcode wrapper ( #7400 )
...
Usage:
```
[wrap=name foo=bar]
hello world
[/wrap]
```
2019-04-24 10:37:34 +02:00
Guo Xiang Tan
845b68f9ab
Update possible upload url format for Upload.migrate_to_new_scheme.
2019-04-24 16:26:54 +08:00
Guo Xiang Tan
c811e59898
Avoid hardcoding db name in Upload.migrate_to_new_scheme.
2019-04-24 15:25:24 +08:00
Chris Butler
8673bd832a
FEATURE: use failed_to_login for SSO error ( #7394 )
...
The error displayed when logging into suspended accounts via SSO never includes
the suspension reason, unlike non-SSO logins. By re-using the failed_to_login
method when generating the error message for SSO we can ensure the message is
consistent between the SSO and non-SSO paths.
2019-04-24 16:38:56 +10:00
Saurabh Patel
d4bec7fdfb
use description_text instead of description to show correct sanitized description ( #7420 )
2019-04-24 16:33:58 +10:00
Guo Xiang Tan
e351b2ee26
Revert "FEATURE: stop running migrate to new scheme once done"
...
This reverts commit 2e346e6ea2573ddcbbd0
2019-04-24 14:03:31 +08:00
Guo Xiang Tan
573ddcbbd0
Disable migrate_to_new_scheme once there is nothing to migrate.
2019-04-24 14:00:00 +08:00
Sam Saffron
2e346e6ea2
FEATURE: stop running migrate to new scheme once done
...
This setting will automatically disable itself when there are no longer any
problem uploads
2019-04-24 14:32:39 +10:00
Guo Xiang Tan
3094a603b7
Follow up to 149411ec90.
2019-04-24 12:20:53 +08:00
Guo Xiang Tan
149411ec90
PERF: Speed up Upload.migrate_to_new_scheme by limiting remap scope.
...
Doing a `LIKE` on `Post#raw` and `Post#cooked` takes forever on large
sites.
2019-04-24 11:56:48 +08:00
Guo Xiang Tan
a8baa6d9e7
FIX: Old Upload#url scheme support for Upload.get_from_url.
...
This is for backwards compatibility purposes. Even if `Upload#url` has a
format that we don't recognize, we should still return the upload object
as long as the upload record is present.
2019-04-24 10:15:47 +08:00
Robin Ward
646cdfa449
FIX: Approved posts were not enqueueing alerts
2019-04-23 17:30:12 -04:00
Bianca Nenciu
b9339e15a1
FIX: Do not track a elements with no href.
2019-04-23 23:13:23 +03:00
Bianca Nenciu
b81d169e2a
FIX: Do not track user mentions.
2019-04-23 23:08:00 +03:00
Robin Ward
fca3f53e9c
FIX: Safer scoring with concurrency
2019-04-23 15:53:37 -04:00
Robin Ward
70097966ed
FIX: Don't add the reviewable score twice
2019-04-23 15:46:18 -04:00
Robin Ward
6f56fba016
UX: Update post actions to "Approve Post" and "Reject Post"
...
This should be more clear.
2019-04-23 12:19:11 -04:00
Joffrey JAFFEUX
c99faa6b25
FIX: improves locale support in tag-drop ( #7418 )
2019-04-23 17:53:59 +02:00
Joffrey JAFFEUX
d4e788c136
FIX: improves share/invite behavior on mobile and especially iOS ( #7416 )
2019-04-23 17:07:31 +02:00
Tarek Khalil
dc60128355
FIX: Hide ignoring users in preference for users with TL less than a member ( #7415 )
...
* FIX: Hide ignoring users in preference for users with TL less than a member
2019-04-23 14:47:37 +01:00
David Taylor
a2ddb6cf2d
DEV: Increase max length of theme_field name column
...
Now that we have custom SCSS files with arbitrary names, it's easy to exceed 30 characters
2019-04-23 12:34:32 +01:00
Gerhard Schlager
a7bc1ecbae
FEATURE: Add support for Unicode usernames and group names
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2019-04-23 13:00:27 +02:00
Guo Xiang Tan
d07605d885
DEV: Fix failing spec.
2019-04-23 18:25:28 +08:00
Bianca Nenciu
1867f2dda0
FEATURE: Always track clicks using AJAX. ( #7373 )
2019-04-23 12:41:36 +03:00
Dan Ungureanu
c048b71b29
UX: Replace staff notice icon with user-shield.
2019-04-23 10:37:33 +03:00
Guo Xiang Tan
87cca0fb80
FIX: Return the right response code for invalid theme id.
2019-04-23 14:57:14 +08:00
Guo Xiang Tan
3ac18b92b3
UX: Editing theme name stays active when switching themes.
...
* Also fix length of input field.
2019-04-23 14:57:14 +08:00
Saurabh Patel
3658be42f5
FIX: remove like_count and <hr> tag from post crawler layout ( #7413 )
...
* show likes value in crawler view if count is > 0
* remove <hr> since horizontal line is already provided by css - this removes one of 2 horizontal lines in post crawler view
2019-04-23 15:35:57 +10:00
Michał Frąckiewicz
8f7cfc29db
FIX: Detect SNS notifications for SES correctly ( #7284 )
...
* Fix handling SNS notifications for AWS SES
This fixes detection of email bounce by:
- removing hard requirement for email ID, ID in webhook msg never equals this in email_log
- gets bounce_score from user stats instead of nonexistent field in webhook msg
* Remove empty line
* Prettify access to EmailLog for parsing SNS notification
Co-Authored-By: SystemZ <SystemZ@users.noreply.github.com>
2019-04-23 13:03:31 +10:00
Bianca Nenciu
58fe45ffd9
UX: Do not close login modal and search menu on outside mouse up event. ( #7366 )
2019-04-23 13:01:44 +10:00
Bianca Nenciu
9050b1bf5a
FIX: Add unique index on group_requests(group_id, user_id). ( #7399 )
2019-04-23 12:51:30 +10:00
Robin Ward
a8e3ac90a0
FIX: nil error in list, incorrect count in reviewable pending
2019-04-22 12:18:57 -04:00
Saurabh Patel
3f9ec197e7
FIX: use last_activity_date instead of created_at for crawler view
2019-04-22 11:38:48 -04:00
Arpit Jalan
a63ef4cfc8
FEATURE: better wizard privacy controls ( #7391 )
2019-04-22 19:47:29 +05:30
Dan Ungureanu
f112f279ae
UX: Reorder post admin actions for greater consistency.
2019-04-22 10:57:14 +03:00
Guo Xiang Tan
caeb035b61
FIX: Automatic scrolling in PM not working.
...
See https://stackoverflow.com/questions/18779708/scrolltop-with-animate-not-working
2019-04-22 10:52:46 +08:00
Guo Xiang Tan
0210b0aabc
REFACTOR: Prefer accessing instance variables directly.
...
* No need to wrap instance variables with another method to read it.
* Remove memoization that wasn't really memozing anything.
2019-04-20 09:39:25 +08:00
Joffrey JAFFEUX
151da50e7c
FIX: prevents exception when the node doesnt exist anymore ( #7408 )
2019-04-19 18:27:23 +02:00
Dan Ungureanu
57d1dea8a2
FEATURE: Let staff add custom post notices. ( #7377 )
2019-04-19 17:53:58 +03:00
Vinoth Kannan
5de483a1b9
PERF: Very post upload's existence by preloaded upload sha1s array
2019-04-19 17:27:16 +05:30
Joe
b150a57383
UX: don't clip staff shield in user cards ( #7398 )
2019-04-19 01:53:23 -07:00
Régis Hanol
19905e587b
Revert "UX: Show user card on load ( #7380 )" ( #7403 )
...
This reverts commit 66789d73c9
2019-04-19 10:45:25 +02:00
Tim Lange
66789d73c9
UX: Show user card on load ( #7380 )
2019-04-19 09:20:03 +02:00
Tim Lange
1d0816b2cf
UX: Changed error draft status to icon ( #7369 )
2019-04-19 09:18:01 +02:00
Kris
cbe7166d87
UX: Move total user count
2019-04-19 00:35:50 -04:00
Kris
f62828f14d
Break long group names, don't truncate
2019-04-18 14:10:52 -04:00
Robin Ward
85d8d5d092
FIX: Lint
2019-04-18 13:49:28 -04:00
Robin Ward
8e77b4d58e
FIX: Replace references to flags in the header with review
2019-04-18 13:25:23 -04:00
Tarek Khalil
6e46197bc8
FIX: Disable webhooks on 410 and 404 HTTP responses ( #7392 )
...
FIX: Disable webhooks on 410 and 404 HTTP responses (#7392 )
2019-04-18 12:36:37 +01:00
Sam Saffron
7068b58e85
PERF: flush topic timings less frequently
...
This is a first step of a performance optimisation, more will follow
Previously we did not properly account for previously read topics while
"rushing" marking times on posts.
The new mechanism now avoids "rushing" sending timings to server if all
the posts were read.
Also to alleviate some server load we only "ping" the server with old timings
once a minute (it used to be every 20 seconds)
2019-04-18 17:31:08 +10:00
Maja Komel
1f17d52f55
UX: new layout for groups page, allow changes to automatic group bio ( #7350 )
2019-04-17 22:44:30 -04:00
Kris
bf712a8598
break long words/urls to prevent overflow
2019-04-17 21:11:02 -04:00
Kris
ec4cd09210
UX: Improve review queue layout on small screens
2019-04-17 16:17:54 -04:00
Robin Ward
cd2e93b598
FIX: Show when a post has been deleted in the flag review queue
2019-04-17 16:14:36 -04:00
Joe
ee808dc682
UX: replace lightbox loading text with spinner ( #7393 )
2019-04-17 10:24:03 -07:00
Penar Musaraj
7cd621778d
FEATURE: Native app banner improvements
...
This commit adds some improvements to native app banners for iOS and Android
- iOS and Android now have separate settings for native app banners
- app banners will now only show for users on TL1 and up
- app ids are now in a hidden site setting to allow sites to switch to their own app, if desired
- iOS only: the site URL is passed to the app arguments
2019-04-17 12:25:13 -04:00
Robin Ward
14f9d40e48
FEATURE: Clarify Reviewable User Actions
...
"Approve" is now "Approve User" and "Delete" is a dropdown with a choice
that allows you to block.
2019-04-17 11:44:17 -04:00
Roman Rizzi
12a5c69abd
FEATURE: Allow users to tone down digest emails ( #7353 )
...
* FEATURE: Allow user to tone down email digest insteand of only unsubscribing
* Reordered options and select the next slowest frequency by default
2019-04-17 12:14:40 -03:00
Kris
a58091e352
Mobile alert padding too broad
2019-04-17 09:37:42 -04:00
Tarek Khalil
02a9429c38
REFACTOR: Quick refactor of the webhook event emitter job ( #7385 )
...
* REFACTOR: Quick refactor of the webhook event emitter job
2019-04-17 10:03:23 +01:00
Dannii Willis
16bfc29164
Move the trend icons on the admin dashboard inside the span ( #7367 )
...
so that it will have the tooltip as well
2019-04-17 18:11:01 +10:00
Maja Komel
5c795bc480
FIX: prevent anonymous users from changing their email/username/name ( #7311 )
2019-04-17 18:05:02 +10:00
Robin Ward
ba6d4b2a8d
FIX: Better handling for toggling must_approve_users
...
If you turn it on now, default all users to approved since they were
previously. Also support approving a user that doesn't have a reviewable
record (it will be created first.)
This also includes a refactor to move class method calls to
`DiscourseEvent` into an initializer. Otherwise the load order of
classes makes a difference in the test environment and some settings
might be triggered and others not, randomly.
2019-04-16 15:56:35 -04:00
Gerhard Schlager
7e8579b8aa
UX: Add translations for lightbox
2019-04-16 17:03:01 +02:00
Joffrey JAFFEUX
5ec19987b4
FIX: attempts to fix a regression making touchs on emojis less reliable ( #7383 )
2019-04-16 12:31:33 +02:00
Guo Xiang Tan
784940bea0
Fix the build.
2019-04-16 15:47:16 +08:00
Guo Xiang Tan
1056dd16d3
FIX: Publish web hooks when topic archetype is converted.
2019-04-16 15:18:39 +08:00
Guo Xiang Tan
347663e852
UX: Switch ellipsis direction when expanding web hook event details.
2019-04-16 14:28:23 +08:00
Guo Xiang Tan
8cb1890245
FIX: Missing topic edited web hook when publishing a topic.
2019-04-16 14:28:23 +08:00
Guo Xiang Tan
d6e45864ce
Fix failing spec.
2019-04-16 09:59:35 +08:00
Guo Xiang Tan
ce4c8e957b
PERF: Avoid looking up the same group multiple times during bulk invite.
...
Also cache the guardian check because it does a query to check if the
user is an owner of the group.
2019-04-16 09:42:25 +08:00
Guo Xiang Tan
25514550f0
FIX: Bulk invite should skip invite and add existing users to groups.
2019-04-16 09:42:25 +08:00
Guo Xiang Tan
6e6cdfaf80
FIX: Bulk invite should not add users to automatic groups.
...
* Also checks that the user creating the bulk invite has permission.
2019-04-16 09:42:25 +08:00
Penar Musaraj
74c4ef6b50
Fix draft position in iOS webview
2019-04-15 19:10:18 -04:00
Dan Ungureanu
e23c87c442
FIX: Prevent exception in rescue block.
...
> Job exception: undefined method `id' for nil:NilClass
> clean_up_inactive_users.rb:25:in `rescue in block in execute'
2019-04-16 01:27:39 +03:00
Robin Ward
3ceff0a92a
FEATURE: Send the user a notification when their post is approved
2019-04-15 16:20:16 -04:00
Penar Musaraj
de10bd7fb4
UI: Footer nav fixes
...
- moves footer nav to the header on iPads
- disables scrolling events for iPads
- removes footer nav entirely on Chrome PWAs
- toggles DiscourseHub iOS app status bar styling (dark/light) when opening/closing lightboxes and modals
2019-04-15 15:25:40 -04:00
Robin Ward
fca3044b10
UX: When editing a reviewable, show created_by
2019-04-15 15:11:34 -04:00
Robin Ward
d859e1594e
UX: Add a description for scores
2019-04-15 14:21:25 -04:00
Kris
4b74525446
FIX: Group requests page missing wrapper
2019-04-15 14:16:02 -04:00
Penar Musaraj
14eb8eea01
FIX: Prevent input zooming in iOS
...
Since enabling pinch-to-zoom in iOS (eae22548de
2019-04-15 13:05:43 -04:00
Penar Musaraj
a37181ab30
Move footer nav z-index below header menus
2019-04-15 12:03:42 -04:00
David Taylor
428536788c
FIX: Do not error when importing a theme with empty files
2019-04-15 15:46:47 +01:00
Penar Musaraj
6bbdf5b56e
DEV: add "pre_notification_alert" event
...
Allows plugins to modify payload before sending a notification alert
2019-04-15 10:17:15 -04:00
Penar Musaraj
24fd710f04
Revert "FIX: strip spoilers in notification excerpts"
...
This reverts commit 55942224ed
2019-04-15 10:15:17 -04:00
Arpit Jalan
594674703c
FIX: properly log webhook errors in UI on rescue ( #7376 )
2019-04-15 12:19:48 +05:30
David Taylor
fd0de64e0d
UX: Render wizard previews for high-DPI displays ( #7371 )
...
* UX: Render wizard previews for high-DPI displays
Sets up a canvas element of twice the required dimensions, scales all coordinates by 2x, then shrinks the display in css.
* Use window.devicePixelRatio to determine scale factor
2019-04-15 16:16:05 +10:00
Tim Lange
00ee68f799
FIX: Fixed category reordering using arrow icons ( #7374 )
2019-04-15 10:56:21 +10:00
Vinoth Kannan
8e40c35eb8
FIX: 'have_uploads' scope should include all uploads without multisite 'upload_path' prefix
2019-04-15 01:54:55 +05:30
Arpit Jalan
95ada3f190
FIX: save registration IP address for invited users
2019-04-13 13:04:25 +05:30
Kris
b71f19d394
UX: Responsive reviewables down to tablet width
2019-04-12 22:26:24 -04:00
Robin Ward
ef1af53e05
FIX: If creating an active user via the API, create reviewables
2019-04-12 15:25:02 -04:00
Robin Ward
f7ebfb1acc
FIX: Only consider pending queued posts for cleaning up uploads
2019-04-12 14:39:32 -04:00
Robin Ward
534d75310f
FIX: Linting
2019-04-12 14:34:14 -04:00
Robin Ward
a5d9afe397
FEATURE: Include a user's pending posts in the topic view
...
Also includes a refactor to TopicView's serializer which was not
building our attributes using serializers properly.
2019-04-12 14:25:12 -04:00
Penar Musaraj
51630b5187
Footer nav tweaks
2019-04-12 12:29:54 -04:00
Penar Musaraj
55942224ed
FIX: strip spoilers in notification excerpts
2019-04-12 12:00:49 -04:00
Joe
7b5913344e
UX: tone down user card email color
2019-04-12 04:55:01 -07:00
David Taylor
268d4d4c82
FEATURE: Multiple SCSS file support for themes ( #7351 )
...
Theme developers can include any number of scss files within the /scss/ directory of a theme. These can then be imported from the main common/desktop/mobile scss.
2019-04-12 11:36:08 +01:00
Dan Ungureanu
0e9a0a31f5
FIX: Show email for staged users in user cards. ( #7354 )
2019-04-12 12:50:43 +03:00
Sam Saffron
2fea29a355
Simplify animation used to denote draft is saved
...
The original implementation felt a bit too short, went with
a much simpler animation which sticks around for 5 seconds.
5 seconds seems to be the standard and the same timing gmail use
2019-04-12 10:28:29 +10:00
Sam Saffron
9bd3afda5d
FIX: display conextual count on favicon if selected
...
This also corrects the test suite and moves the two notification counts
so they are closer together.
2019-04-12 10:04:23 +10:00
James Haggerty
dcec256b9d
Make 1gb warning a little less than 1gb ( #7368 )
...
When you have '1gb' RAM, this might be a little less than 1,000,000.
Let's not warn unless it's well under 1gb.
2019-04-11 16:44:29 -07:00
David Taylor
24ef4f7b2b
Remove support for disable_jump_reply user setting ( #7359 )
2019-04-12 09:03:06 +10:00
David Taylor
dc703adad7
FEATURE: Add user preference for title counter mode ( #7364 )
2019-04-12 09:02:18 +10:00
Robin Ward
c0c236f36e
FIX: Better to put a ReviewableUser back into pending than silently fail
2019-04-11 16:36:47 -04:00
Robin Ward
6f7b6a3333
FIX: Disagree and Restore should not revert edits
2019-04-11 16:21:18 -04:00
Penar Musaraj
60db57acc0
Make Prettier happy
2019-04-11 14:15:47 -04:00
Penar Musaraj
f060c9b3ff
UI: improvements to footer nav for app and PWAs
...
Adds support for iPad and Chrome PWAs
Better scroll direction logic when reaching bottom of the page
2019-04-11 14:11:26 -04:00
Robin Ward
d21dd521d2
FIX: Don't try to create a reviewable user twice
2019-04-11 12:30:54 -04:00
Robin Ward
331a809738
FEATURE: Display the reason for many reviewable items
...
Queued Posts and Users will now display a reason why they are in the
review queue.
2019-04-11 12:04:45 -04:00
Arpit Jalan
7143572e0c
FIX: correctly retrieve 'login required' setting value on wizard ( #7355 )
...
* FIX: correctly retrieve 'login required' setting value on wizard
FEATURE: extract 'invite only' setting in a separate checkbox control
* Update invite_only checkbox locale on wizard.
Co-Authored-By: techAPJ <arpit@techapj.com>
2019-04-11 20:25:08 +05:30
Tim Lange
9a428acce4
UX: Switched composer draft saving to animations ( #7356 )
2019-04-11 10:03:36 -04:00
Joffrey JAFFEUX
7226240df3
UX: full revamp of local-dates form ( #7357 )
2019-04-11 11:14:34 +02:00
Penar Musaraj
54daa92c2d
Fix progress wrapper margin on Safari/iOS
2019-04-11 00:42:26 -04:00
Guo Xiang Tan
d705dd8bb8
Update annotations.
2019-04-11 12:37:24 +08:00
Penar Musaraj
723feea832
Bump textarea font size on mobile
...
As of eae2254
2019-04-11 00:03:29 -04:00
Kris
9291ffaac0
email-in alignment fix
2019-04-10 23:49:26 -04:00
Kris
abd34882d5
UX: Better organization of category settings
2019-04-10 23:00:31 -04:00
Sam Saffron
baa7a9836c
FEATURE: remove "COMPRESS_BROTLI" optional behavior
...
The compress brotli functionality is no longer optional, this has worked
well for years. The name of the ENV var is also confusing cause it does
not have a `DISCOURSE_` prefix which caused issues with the web upgrader
Brotli support is now unconditionally on
2019-04-11 12:36:18 +10:00
Dan Ungureanu
7a7c6af21e
FIX: Fallback to last post when the in-view post cannot be detected.
...
In certain situations the detection method fails. For example, it fails
for a topic containing: a long post (~1600px height), gap, small action
(focus on this), hidden reply.
2019-04-11 01:14:59 +03:00
Dan Ungureanu
47c50d9a95
DEV: Add test for post notices. ( #7352 )
2019-04-10 22:06:27 +03:00
Kris
689c7f5410
Minor reviewable alignment fixes
2019-04-10 14:22:46 -04:00
Kris
1b6f18396b
UX: Simplify merged reviewable table
2019-04-10 13:22:28 -04:00
Tim Lange
fe9c271d44
FIX: Fixed deleted posts layout ( #7348 )
2019-04-10 19:00:39 +02:00
Robin Ward
cab83596ec
FIX: Sites with SSO that required approval were not creating reviewables
2019-04-10 12:53:50 -04:00
Penar Musaraj
eae22548de
Footer navigation for iOS PWAs and DiscourseHub app ( #7347 )
2019-04-10 12:23:18 -04:00
Régis Hanol
ab79060468
FIX: don't send activation reminder to staged users
2019-04-10 17:29:08 +02:00
Robin Ward
5d99346740
FIX: Always allow us to reject users, even if they are deleted
2019-04-10 11:00:39 -04:00
Bianca Nenciu
3d545d66df
FEATURE: Send user activation reminders. ( #7280 )
2019-04-10 16:53:52 +02:00
Vinoth Kannan
b0600e52b6
FIX: use 'freeze' method again to fix 'cant modify frozen string' error
...
8d5c900142
2019-04-10 18:30:59 +05:30
Roman Rizzi
536b90e0ef
FEATURE: Support searching custom staff actions ( #7346 )
2019-04-10 09:53:17 -03:00
Vinoth Kannan
8d5c900142
DEV: add unique missing uploads index in post custom fields
...
https://review.discourse.org/t/feature-send-missing-post-uploads-stat-to-prometheus/2609/6?u=vinothkannans
2019-04-10 18:09:35 +05:30
Tarek Khalil
442fb2facb
FEATURE: Remove ignore feature SiteSetting and enable ignore by default ( #7349 )
2019-04-10 12:54:59 +02:00
Roman Rizzi
82e051077d
Show link to the original topic when it was deleted ( #7319 )
...
* Moved i18n keys to core. We show a links that points to the original topic when it was deleted
* Use link-to since it's more idiomatic
2019-04-10 11:25:45 +02:00
Bianca Nenciu
b5008586c5
DEV: Remove HTML parser from Tautologistics. ( #7344 )
2019-04-10 11:21:22 +02:00
Vinoth Kannan
d0fe42e2ef
FIX: should look through posts for image markdown
...
Downloaded onebox images only included in the cooked HTML content. So we have to check 'post.cooked' instead of 'raw'. bfdd0fe64c
2019-04-10 13:52:35 +05:30
Arpit Jalan
9c1d1777db
Bump onebox version
...
- adds support for oneboxing google drive files
- add styling for google drive onebox favicon
2019-04-10 13:37:24 +05:30
Sam Saffron
88f8c9f43e
FIX: when banner is removed update all clients
...
Previously removing a banner raised a null "banner" in the message bus
channel.
Then Ember.Object.create would fail cause it always expects an object in
constructor.
2019-04-10 15:59:29 +10:00
Kris
df85d4593e
UX: Unify admin intro styles for badges/customize, improve mobile
2019-04-09 20:32:24 -04:00
Robin Ward
9ebfdaa356
UX: Unify reviewable scores + history
2019-04-09 16:43:08 -04:00
Kris
8e9d0ceb67
UX: Mobile - fix editor button space, divider, extra upload icon
2019-04-09 13:15:31 -04:00
Tarek Khalil
307499e48b
FIX: Keep highlighted text for quoted replies by ignored users ( #7345 )
2019-04-09 17:33:12 +02:00
Robin Ward
9bcd7aacc8
Remove deprecation, the admin controller can approve just fine
2019-04-09 11:19:19 -04:00
Robin Ward
692e09d813
FIX: Only show "Approve" button for the admin user if reviewable
2019-04-09 11:14:52 -04:00
Vinoth Kannan
73663c2fdb
FIX: should find records by sha1 only in Upload model
2019-04-09 18:48:49 +05:30
Robin Ward
4552d86605
FIX: Broken tests
2019-04-09 08:33:10 -04:00
Sam Saffron
ec1c3559da
PERF: correct clean up inactive so it does not clog scheduler
...
also add a hard limit of 1000 users per job run so we do not clog the
scheduler
destroyer.destroy has a transaction and this can have some serious complications
with the open record set find_each has going
2019-04-09 22:25:05 +10:00
Guo Xiang Tan
6d0e8821f8
FIX: Optimize query and avoid bloating memory in Jobs::MigrateUploadScheme.
2019-04-09 15:45:30 +08:00
Joffrey JAFFEUX
df7f37f10a
FIX: web_crawlers had been mistakenly removed ( #7342 )
2019-04-09 09:26:22 +02:00
Joffrey JAFFEUX
a89c90ed5d
FIX: removes link to old dashboard ( #7341 )
2019-04-09 09:24:41 +02:00
Vinoth Kannan
f0f659286f
UX: move up profile picture field next to the username
2019-04-09 11:46:03 +05:30
Guo Xiang Tan
c82a929025
PERF: Add index_for_rebake_old to posts.
...
The index becomes smaller over time and is much faster.
Follow up to 4791d992dc
2019-04-09 13:59:46 +08:00
Guo Xiang Tan
28d117898f
Update annotations.
2019-04-09 13:27:32 +08:00
Sam Saffron
f6db30a5da
FEATURE: mark last notification unread when removing timings
...
This calls a bit more attention to the deferred topic by amending the "read"
state of the last notification on the topic.
2019-04-09 12:42:21 +10:00
Guo Xiang Tan
f0bb492d24
Fix regression due to 914ada1c74.
2019-04-09 09:47:11 +08:00
Vinoth Kannan
f5ac01253a
FIX: use new changed method name and remove whitespaces
2019-04-09 02:25:26 +05:30
Robin Ward
bc949cf684
FIX: Display the username instead of {{username}}
2019-04-08 16:46:05 -04:00
Robin Ward
32a0346069
UX: Don't show the username of the first user in the conversation
2019-04-08 16:39:53 -04:00
Vinoth Kannan
914ada1c74
DEV: convert scheduled job EnsurePostUploadsExistence into a rake task
2019-04-09 02:07:35 +05:30
Robin Ward
cc53f902c6
FIX: Missing translation key for Reviewable -> Deleted
2019-04-08 16:12:41 -04:00
Robin Ward
0fc798c2ef
UX: Show the score status
...
If a review review score has been Approved/Rejected/Ignored then show it
2019-04-08 12:08:18 -04:00
Tarek Khalil
5957991340
FIX: Remove quoted post text and block realtime replies from ignored users ( #7336 )
2019-04-08 17:44:42 +02:00
Tarek Khalil
02394e9170
FIX: assign decoratorHelper ( #7338 )
2019-04-08 16:17:09 +01:00
Joffrey JAFFEUX
9d2e2867cc
s/fa-icon/d-icon ( #7337 )
2019-04-08 15:51:38 +02:00
Tarek Khalil
0d2a1fce51
REFACTOR: Pass down currentUser to post-cooked widget ( #7333 )
...
* REFACTOR: Pass down `currentUser` to `post-cooked` widget
2019-04-08 14:50:53 +01:00
Vinoth Kannan
2ae87a27fa
make rubocop happy
2019-04-08 17:03:26 +05:30
Guo Xiang Tan
f0f3deb32b
PERF: Simplify query of UserStat#update_topic_reply_count.
...
For a user with alot of posts, we get a 25% speed up.
2019-04-08 17:48:19 +08:00
David Taylor
f524f8f811
Remove Yahoo login support from core and deprecate OpenID2.0 ( #7310 )
...
- Plugin developers using OpenID2.0 should migrate to OAuth2 or OIDC. OpenID2.0 APIs will be removed in v2.4.0
- For sites requiring Yahoo login, it can be implemented using the OpenID Connect plugin: https://meta.discourse.org/t/103632
For more information, see https://meta.discourse.org/t/113249
2019-04-08 10:38:25 +01:00
Guo Xiang Tan
108c231d1c
FIX: Clean up topic_search_data of trashed topics.
...
This keeps the index and table smaller.
2019-04-08 16:53:39 +08:00
Guo Xiang Tan
c4997ce85f
FIX: Don't try and reindex posts that have been trashed.
2019-04-08 16:38:43 +08:00
Vinoth Kannan
ca57e18f42
UX: display signup cta even if 'must_approve_users' setting enabled.
2019-04-08 12:27:56 +05:30
Guo Xiang Tan
33fa249fa5
SECURITY: Remove XSS in composer preview when applying image scale buttons.
2019-04-08 11:22:14 +08:00
Guo Xiang Tan
6525613b89
PERF: Use joins for Post.for_mailing_list instead of NOT IN.
...
Joining on the topics table and then filtering the topics against a large set of
ids is so much slower than doing a join on a sub query.
2019-04-06 07:58:55 +08:00
Kris
84eb9bc1c9
UX: Only highlight close icon on hover, not lock
2019-04-05 17:43:14 -04:00
Kris
a1c2181232
UX: Better close button positioning in alerts, some cleanup
2019-04-05 16:21:16 -04:00
Robin Ward
a6f283da30
UX: Show tags on flags too
2019-04-05 14:22:45 -04:00
Régis Hanol
06e3b25d04
FIX: 'currentUser' is a property of the 'widget'
2019-04-05 18:43:04 +02:00
Robin Ward
b005a84530
FIX: decoratorHelper.widget is not always present
2019-04-05 12:07:24 -04:00
Kris
acce7330a3
Typo fix
2019-04-05 11:23:22 -04:00
Kris
43a905279f
FIX: Layout was off in single-page user-preferences
2019-04-05 10:59:52 -04:00
Robin Ward
cbc311e4ed
UX: Update the reviewable count before the message bus
...
In certain edge cases, the message bus won't send the message to the
user about the updated review count and it can go out of sync.
This patch synchronizes the review count every time:
1. The user visits the "Needs Review" page
2. Every time the user performs an action
2019-04-05 10:35:38 -04:00
Tarek Khalil
19a1d35f66
fix linting ( #7329 )
2019-04-05 15:28:41 +01:00
Tarek Khalil
131eba0366
FIX: Hide post replies content for ignored users ( #7320 )
2019-04-05 16:13:36 +02:00
Maja Komel
ca33d091b3
FIX: don't trigger notifications when changing category/tags of unlisted topics ( #7323 )
2019-04-05 15:06:38 +02:00
Guo Xiang Tan
a7a5f90e20
Annotate models.
2019-04-05 17:13:12 +08:00
Joffrey JAFFEUX
0bd480c600
UX: displays exact date on title attribute of topic timer info ( #7326 )
2019-04-05 09:44:10 +02:00
Saurabh Patel
9b288613ae
DEV: remove span from inside <tr> and move meta info to a td ( #7324 )
2019-04-05 09:32:11 +02:00
Angus McLeod
6f1652bb53
add header cloak after all panels are added ( #7325 )
2019-04-04 22:54:05 -07:00
Sam Saffron
81a1bafe54
PERF: Speed up home page unread+new query
...
restructure query so it avoids ORs
It appears postgres is picking suboptimal indexes if too many ORs exist
despite how trivial the condition is.
This bypasses conditional in the query and evals them upfront.
On meta for my user this made a 10x perf difference.
This boils down to either having `OR u.admin` or not having `OR u.admin` in
the query.
2019-04-05 15:25:19 +11:00
Sam Saffron
5b837f620b
correct unread resetting to handle nulls
...
Note, to avoid race conditions we are setting last_unread to 10 minutes ago
if there is nothing unread.
This is safer in case of in progress transactions
we don't want to lose unread for any window of time.
2019-04-05 13:42:41 +11:00
Sam Saffron
5f896ae8f7
PERF: Keep track of when a users first unread is
...
This optimisation avoids large scans joining the topics table with the
topic_users table.
Previously when a user carried a lot of read state we would have to join
the entire read state with the topics table. This operation would slow down
home page and every topic page. The more read state you accumulated the
larger the impact.
The optimisation helps people who clean up unread, however if you carry
unread from years ago it will only have minimal impact.
2019-04-05 12:44:45 +11:00
Robin Ward
c9ddc6ce30
FIX: Make sure the site setting works and fix build
2019-04-04 17:44:10 -04:00
Robin Ward
aa4a38b08a
FIX: computed is not used
2019-04-04 17:38:27 -04:00
Robin Ward
8af7237092
FIX: Only perform logic on create commits
2019-04-04 17:01:47 -04:00
Vinoth Kannan
2c7a50860f
DEV: disable missing post uploads check by default.
2019-04-05 02:29:10 +05:30
Neil Lalonde
83996fc8ea
FEATURE: ability to restrict some tags to a category while allowing all others
...
A new checkbox has been added to the Tags tab of the category settings modal
which is used when some tags and/or tag groups are restricted to the category,
and all other unrestricted tags should also be allowed.
Default is the same as the previous behaviour: only allow the specified set of
tags and tag groups in the category.
2019-04-04 16:40:15 -04:00
Kris
9faebfcfe0
UX: Adjust layout, allow additional responsiveness
2019-04-04 16:20:25 -04:00
Robin Ward
df48c657fd
FIX: Reviewable counts were not updating properly
...
Sometimes sidekiq is so fast that it starts jobs before transactions
have comitted. This patch moves the message bus stuff until after things
have comitted.
2019-04-04 16:07:34 -04:00
Robin Ward
2055804e95
FIX: The option to delete replies was missing from the new review queue
2019-04-04 15:51:36 -04:00
Robin Ward
dd5b8bd85e
FIX: Show replies to the post, not the topic
...
This makes more sense when reviewing. How many people replied to this
objectionable thing?
2019-04-04 15:13:59 -04:00
Robin Ward
9c8cc73c39
UX: Show user fields when reviewing a user
2019-04-04 14:45:40 -04:00
Vinoth Kannan
a385f6c48a
REFACTOR: create custom field even when missing post uploads not found
2019-04-04 21:49:44 +05:30
Vinoth Kannan
44e87372da
FEATURE: Add scheduled job to ensure s3 uploads existence
2019-04-04 20:37:44 +05:30
Robin Ward
a5182b0d6c
FIX: Rewrite old /admin/flags links to use the review queue
...
Such links might be in present in old PMs. For example, a notification of
outstanding flags.
New PMs should receive the correct link but this prevents 404s in the
other case.
2019-04-04 10:15:23 -04:00
Saurabh Patel
90fc2d15c4
FEATURE: change layout when default page is category to tabular for _… ( #7270 )
2019-04-04 15:57:18 +02:00
Arpit Jalan
f87b35e6f4
FIX: do not raise exception if the file is missing
2019-04-04 15:36:51 +05:30
Bianca Nenciu
63fcd445f4
FIX: Use unfiltered URL when viewing all badges.
2019-04-04 12:35:03 +03:00
Maja Komel
b0053f3a1c
FEATURE: bump onebox version, add styling for new reddit image onebox
2019-04-04 11:24:30 +02:00
Guo Xiang Tan
6815f777f9
DEV: Remove unused method.
2019-04-04 14:19:39 +08:00
Robin Ward
588f61f717
FIX: Linting
2019-04-03 18:08:07 -04:00
Robin Ward
a4ff593506
UX: Slightly improved reviewable user display, plus link to admin if possible
2019-04-03 17:07:48 -04:00
Vinoth Kannan
3b581de3b8
remove unrelated code
...
already added in a separate job
2019-04-04 02:26:28 +05:30
Vinoth Kannan
b3fb0a7039
FEATURE: ensure consistency of post uploads in cooked content
2019-04-04 02:23:28 +05:30
Kris
14952a9cbc
UX: Reduce specificity of reviewable item styles
2019-04-03 16:49:57 -04:00
Robin Ward
111a502231
FIX: Deleting Users should work nicely with Reviewable Users
...
"Rejecting" a user in the queue is equivalent to deleting them, which
would then making it impossible to review rejected users. Now we store
information about the user in the payload so if they are deleted things
still display in the Rejected view.
Secondly, if a user is destroyed outside of the review queue, it will
now automatically "Reject" that queue item.
2019-04-03 16:42:39 -04:00
Kris
88a46981a8
UX: Remove extra border on old mobile post notices
2019-04-03 16:10:54 -04:00
Robin Ward
828cdf3fea
FIX: Protected method called, I'll fire myself now
2019-04-03 16:10:36 -04:00
Robin Ward
82bddcbe51
FIX: Don't create two reviewable scores for a user
2019-04-03 16:03:32 -04:00
Robin Ward
c1ea63bdc1
FIX: Reviewables should not be created for users until they are active
...
Conversely, if a user is deactivated the reviewable should automatically
be rejected.
Before this fix, if a user was not active they'd still show in the
review queue but without an "Approve" button which was confusing.
2019-04-03 15:25:00 -04:00
Joffrey JAFFEUX
974007a3cc
FIX: reverts href removal from user/group cards links ( #7318 )
2019-04-03 19:16:48 +02:00
Robin Ward
1bce97a596
FIX: Allow queued posts from deleted users to be rejected
2019-04-03 11:40:46 -04:00
Bianca Nenciu
bb2005d466
FIX: Add more links to bandge cards.
2019-04-03 18:37:11 +03:00
Robin Ward
62956003c3
FEATURE: Allow users to customize bonuses for reviewable types
...
A new settings section in the review queue allows admins to specify that
certain types of flags should be weighted higher than others.
2019-04-03 11:18:34 -04:00
Saurabh Patel
da2f659635
UX: Improve posts layout for crawler ( #7286 )
2019-04-03 11:58:00 +02:00
Bianca Nenciu
1e1adb1afa
FIX: Links in badge summary were not clickable. ( #7303 )
2019-04-03 11:35:27 +02:00
Maja Komel
d32aaf374e
UX: add awaiting-approval class to login modal
...
when local logins are disabled and account is awaiting approval
2019-04-03 11:30:43 +02:00
Arpit Jalan
7b194743d7
FIX: clean up user export csv upload records in scheduled job ( #7309 )
2019-04-03 13:31:19 +05:30
Guo Xiang Tan
d1fa2b71cf
FIX: Letters between words incorrectly highlighted within post.
2019-04-03 15:57:51 +08:00
Sam Saffron
b2dc65f953
FIX: on rebakes should not recreate quoted_posts records
...
Previously every rebake would remove and recreate records in this table
This caused created_at and updated_at to keep changing
Yes, I know the SQL is somewhat complex, but this makes quote extraction
more efficient cause we do everything in 2 round trips.
This also removes some concurrency protection we should no longer need
2019-04-03 16:17:15 +11:00
Guo Xiang Tan
52c4711e80
DEV: Fix method that was incorrectly made private.
2019-04-03 12:37:50 +08:00
Guo Xiang Tan
4037a2fd0b
FIX: Restrict scope of old scheme upload migration.
...
Some sites have external URLs that don't even match `%/uploads/%' and
some sites surprise me with URLs that contains the default path when it
is a site in a multisite cluster. We can't do anything about those.
2019-04-03 11:56:41 +08:00
Guo Xiang Tan
d151425353
PERF: Delete search data of posts from trashed topics periodically. ( #7302 )
...
This keeps both the index and table smaller.
2019-04-03 10:10:41 +08:00
Guo Xiang Tan
feb731bffd
FIX: Regenerate optimized images instead of migrating from old scheme.
...
`OptimizedImage.migrate_to_new_scheme` was optimizing optimized images
which we don't need to do. Regnerating the optimized image is way easier.
2019-04-03 09:45:02 +08:00
Kris
c3047a903d
UX: Reviewable spacing adjustments
2019-04-02 17:22:22 -04:00
Kris
14cbbc5e13
UX: Reviewables fixes
2019-04-02 16:25:53 -04:00
Penar Musaraj
44fe2eec03
Better fix for Safari user card position
...
Better than a2c6683e3b
2019-04-02 15:36:47 -04:00
Kris
ba727b2875
UX: Restructure queued posts to match flags, fix text
2019-04-02 14:54:55 -04:00
Kris
2ab6eb58c5
UX: Reviewable layout improvements
2019-04-02 13:51:03 -04:00
Penar Musaraj
15e27d9e2c
Prettier fix
2019-04-02 11:56:21 -04:00
Joffrey JAFFEUX
40e1ba9d9a
FIX: ensures click on emoji in picker doesnt propagate ( #7308 )
2019-04-02 17:40:13 +02:00
Joffrey JAFFEUX
d8dd130477
UX: gives aria-label to topics count in category-row ( #7307 )
2019-04-02 17:38:21 +02:00
Joffrey JAFFEUX
e77b1cf7ff
UX: ensures only <li> are used as top level in breadcrumb ( #7306 )
2019-04-02 17:37:53 +02:00
venarius
c185109380
FIX: Restricted site text better error
2019-04-02 11:16:27 -04:00
Penar Musaraj
a2c6683e3b
FIX: inconsistent user card position in Safari
...
User cards triggered in header were incorrectly positioned in Safari desktop.
Using `position()` instead of `offset()` is more consistent, since header is a fixed element in this scenario.
2019-04-02 10:32:50 -04:00
Robin Ward
af04318aff
FIX: Allow us to serialize reviewables with deleted topics
2019-04-02 09:36:49 -04:00
Joffrey JAFFEUX
02d8931425
UX: more compact local-dates preview ( #7305 )
2019-04-02 14:39:20 +02:00
Arpit Jalan
d68d29f37a
FIX: only staff can banner topics
2019-04-02 12:46:55 +05:30
Guo Xiang Tan
d85240335b
Annotate models.
2019-04-02 13:19:14 +08:00
Tim Lange
a9a35d2c19
FIX: Uncategorized pm not allowing edit ( #7276 )
2019-04-02 12:54:53 +08:00
Guo Xiang Tan
4175de5071
UX: Wrap title on search log term page with a proper div.
...
Search log filter selector was not floating right as it should.
2019-04-02 11:55:57 +08:00
Guo Xiang Tan
1a9452f24d
UX: Pass period params when looking at search logs for a given term.
2019-04-02 11:51:41 +08:00
Kris
cdce9c97bb
minor margin fix
2019-04-01 23:50:47 -04:00
Penar Musaraj
1c0f885a5b
FIX: double render error with delegated authentication
...
Makes sure delegated authentication is checked before other login redirects
Updates specs to cover login_required = true cases
2019-04-01 22:13:53 -04:00
Kris
254de64df7
UX: Consistent profile image positioning on desktop and mobile
2019-04-01 22:04:11 -04:00
Guo Xiang Tan
d8704c11ca
PERF: Better use of index when queueing a topci for search reindex.
...
Also move `Search::INDEX_VERSION` to `SearchIndexer` which is where the
version is actually being used.
2019-04-02 09:53:37 +08:00
Kris
9603c906ec
Moving staff counters back to the top of profiles
2019-04-01 21:04:37 -04:00
Guo Xiang Tan
aa2311a7b0
FIX: Don't reindex posts belonging to a deleted topic for search.
...
Posts belonging to a deleted topic can't be index for search so we need
to avoid loading those post ids.
2019-04-02 07:36:53 +08:00
Guo Xiang Tan
3fc5dbb045
FIX: Don't attempt to reindex posts that have an empty raw.
...
If the post ids keep loading, we might end up in a situations where
we're always loading the same post ids over and over again without
indexing anything new.
Follow up to daeda80ada
2019-04-02 07:13:33 +08:00
Robin Ward
d5a61ab167
FIX: Don't log a second pending action
...
If two people flagged the same post you'd get a "Pending" history event
logged which looked bad.
2019-04-01 17:07:47 -04:00
Robin Ward
76669bb5a6
FIX: Don't refer to pending review items as flags
...
They could be queued posts or users, and the notice should reflect that
properly.
2019-04-01 14:46:56 -04:00
Robin Ward
6470c85fda
UX: Link directly to the post, not to the topic
2019-04-01 14:29:14 -04:00
Penar Musaraj
fdf4145d4b
FEATURE: Delegated authentication via user api keys ( #7272 )
2019-04-01 13:18:53 -04:00
David Taylor
b375dcb14a
DEV: Introduce parallel rspec testing
...
Adds the parallel_tests gem, and redis/postgres configuration for running rspec tests in parallel. To use:
```
rake parallel:rake[db:create]
rake parallel:rake[db:migrate]
rake parallel:spec
```
This brings the test suite from 12m20s to 3m11s on my macOS machine
2019-04-01 11:06:47 -04:00
Joffrey JAFFEUX
13a6a04cad
FIX: ensures popover is hidden when changing route ( #7300 )
2019-04-01 16:23:57 +02:00
Joffrey JAFFEUX
4b1b135ede
FIX: handles boolean with popupMenuOption ( #7299 )
...
Handle the case of https://github.com/discourse/DiscoTOC doing this kind of setup:
```
return {
action: "insertDtoc",
icon: "align-left",
label: themePrefix("insert_table_of_contents"),
condition: !composerController.get("model.canCategorize")
};
```
In this case there's no function to call, it's already set.
2019-04-01 16:08:14 +02:00
Régis Hanol
a6596662dc
FIX: don't enqueue TruncateUserFlagStats job when not needed
2019-04-01 15:53:55 +02:00
Joffrey JAFFEUX
6e0e36f790
fix spec ( #7298 )
2019-04-01 14:35:09 +02:00
Joffrey JAFFEUX
e986e96227
DEV: removes old dashboard ( #7295 )
2019-04-01 12:39:49 +02:00
Guo Xiang Tan
3cba10b9ca
DEV: Don't warn when trying to reindex a post with a deleted topic.
2019-04-01 17:04:32 +08:00
Joe
541a15e357
UX: user-card adjustments for users with hidden profiles ( #7293 )
...
* adds styles for profile hidden message
* Disable profile links for hidden profiles and add message to indicate the profile is hidden
2019-04-01 10:50:48 +02:00
Guo Xiang Tan
8794d940d3
Revert update_columns -> update! when rebaking/post-processing post.
...
`update!` goes through validation which means old posts that doesn't
adhere to the existing validations will raise an error.
2019-04-01 16:29:00 +08:00
Guo Xiang Tan
2a69ab4a4c
FIX: Keep alt and title in lightbox when indexing for search.
...
Follow up to cfd507822f
2019-04-01 16:20:33 +08:00
Maja Komel
88128f1ced
UX: show which groups are missing permissions for parent category ( #7252 )
2019-04-01 15:34:52 +11:00
Guo Xiang Tan
cfd507822f
PERF: Improve quality of PostSearchData#raw_data. ( #7275 )
...
This commit fixes the follow quality issue with `PostSearchData#raw_data`:
1. URLs are being tokenized and links with similar href and characters
are being duplicated in the raw data.
`Post#cooked`:
```
<p><a href=\"https://meta.discourse.org/some.png \" class=\"onebox\" target=\"_blank\" rel=\"nofollow noopener\">https://meta.discourse.org/some.png </a></p>
```
`PostSearchData#raw_data` Before:
```
This is a test topic 0 Uncategorized https://meta.discourse.org/some.png discourse org/some png https://meta.discourse.org/some.png discourse org/some png
```
`PostSearchData#raw_data` After:
```
This is a test topic 0 Uncategorized https://meta.discourse.org/some.png meta discourse org
```
2. Ligthbox being included in search pollutes the
`PostSearchData#raw_data` unncessarily.
From 28 March 2018 to 28 March 2019, searches for the term `image` on
`meta.discourse.org` had a click through rate of 2.1%. Non-lightboxed images are not included in indexing for search yet we were indexing content within a lightbox. Also, search for terms like `image` was affected we were using `Pasted image` as the filename for
uploads that were pasted.
`Post#cooked`
```
<p>Let me see how I can fix this image<br>\n<div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"https://meta.discourse.org/some.png \" title=\"some.png\" rel=\"nofollow noopener\"><img src=\"https://meta.discourse.org/some.png \" width=\"275\" height=\"299\"><div class=\"meta\">\n<svg class=\"fa d-icon d-icon-far-image svg-icon\" aria-hidden=\"true\"><use xlink:href=\"#far-image\"></use></svg><span class=\"filename\">some.png</span><span class=\"informations\">1750×2000</span><svg class=\"fa d-icon d-icon-discourse-expand svg-icon\" aria-hidden=\"true\"><use xlink:href=\"#discourse-expand\"></use></svg>\n</div></a></div></p>
```
`PostSearchData#raw_data` Before:
```
This is a test topic 0 Uncategorized Let me see how I can fix this image some.png png https://meta.discourse.org/some.png discourse org/some png some.png png 1750×2000
```
`PostSearchData#raw_data` After:
```
This is a test topic 0 Uncategorized Let me see how I can fix this image
```
In terms of indexing performance, we now have to parse the given HTML
through nokogiri twice. However performance is not a huge worry here since a string length of 194170 takes only 30ms
to scrub plus the indexing takes place in a background job.
2019-04-01 10:14:29 +08:00
Guo Xiang Tan
7ac76fe935
DEV: Remove warning.
...
Library has already been loaded in application.rb.
2019-04-01 10:11:08 +08:00
Guo Xiang Tan
daeda80ada
FIX: Don't index posts with empty Post#raw for search. ( #7263 )
...
* DEV: Remove unnecessary join in `Jobs::ReindexSearch`.
* FIX: Don't index posts with empty `Post#raw` for search.
2019-04-01 10:06:27 +08:00
Dan Ungureanu
d59abff2d8
UX: Always use relative age for post notices.
2019-03-31 18:07:05 +03:00
Joe
8b8d528b88
Hide mobile cards when user scrolls ( #7291 )
2019-03-31 11:16:52 +02:00
Joe
9510f3d737
card buttons should truncate if there isn't enough space ( #7290 )
2019-03-31 11:16:40 +02:00
Robin Ward
c0780434f8
FIX: Better display if the topic is deleted
2019-03-29 16:59:00 -04:00
Robin Ward
a55e7ebe8f
UX: Better display for deleted users in the review queue
2019-03-29 16:52:58 -04:00
Robin Ward
86349abfea
FIX: Apply min_score_default_visibility to reviewable topics list
2019-03-29 15:42:49 -04:00
Kris
4e6d4531e8
UX: Improve ignore button alignment on user profiles
2019-03-29 15:34:48 -04:00
Robin Ward
67454c71c9
FIX: Missing translations for agree/disagree details
2019-03-29 14:14:59 -04:00
Robin Ward
370355d754
FIX: Allow users with posts to be rejected
2019-03-29 13:53:46 -04:00
Kris
814aee343b
UX: Minor profile page restructure
2019-03-29 12:52:42 -04:00
Tim Lange
2c4b3c21a9
UX: Unified emoji escape regex
2019-03-29 12:17:11 -04:00
Bianca Nenciu
31053f30de
FEATURE: Let users delete their own topics. ( #7267 )
2019-03-29 17:10:05 +01:00
Maja Komel
4a3daacb1b
FIX: reset embedding settings when no embeddable host, log host changes ( #7264 )
2019-03-29 17:05:51 +01:00
Maja Komel
9b00ca30ed
FIX: check if user is already allowed before adding to topic allowed users ( #7242 )
2019-03-29 17:03:33 +01:00
Tarek Khalil
d26d1b387e
FEATURE: Add ignore duration selection for user notifications preferences page ( #7269 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-29 13:33:08 +00:00
Tarek Khalil
b1cb95fc23
FEATURE: Introduce ignore duration selection ( #7266 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-29 10:14:53 +00:00
Joffrey JAFFEUX
961fb2c70e
DEV: moves each report in its own file ( #7277 )
2019-03-29 10:54:56 +01:00
Guo Xiang Tan
a6d93f6317
FIX: Avoid error on ajax.abort() when client has not opened the request.
2019-03-29 15:38:38 +08:00
Guo Xiang Tan
8cfd887f33
Make eslint happy.
2019-03-29 12:59:40 +08:00
Kris
2064223fbd
FIX: Safari needs a max-width to prevent modal overflow
2019-03-29 00:38:44 -04:00
Guo Xiang Tan
1b3165d217
Make rubocop happy.
2019-03-29 12:15:39 +08:00
Guo Xiang Tan
4fa8fe575b
UX: Use a step size of 1.
...
Follow up to 634a213e6d
2019-03-29 12:14:11 +08:00
Guo Xiang Tan
634a213e6d
FIX: Admin chart y axis labels being rounded up/down when value is small.
2019-03-29 12:03:41 +08:00
Guo Xiang Tan
e2ad374e5b
UX: USe bar chart for admin search logs details page.
...
A bar chart is better when comparing the values across the X axis.
2019-03-29 11:54:49 +08:00
Guo Xiang Tan
f458cba4cb
FIX: Admin search logs should filter by date instead of timestamp.
...
The client side filters by date so it is confusion when the data changes as each second passes.
2019-03-29 11:50:25 +08:00
Guo Xiang Tan
d8faf5f79e
FIX: SearcLog.term_details generating incorrect data because of case.
...
Also match on equality rather than "LIKE ?" which is quite strange.
2019-03-29 11:31:01 +08:00
Guo Xiang Tan
947495e70d
Follow up to 8c2fa99f78.
...
`/search_logs/term?term` is alittle weird looking but unless we add
proper slug support to term, we're going to have to live with this
first.
2019-03-29 10:39:44 +08:00
Guo Xiang Tan
c42df7ddd7
UX: Use the same default period for search logs index and term.
...
If the period is different, clicking through to view a term is confusing
because a different period will show a different set of stats.
2019-03-29 09:59:28 +08:00
Guo Xiang Tan
8c2fa99f78
FIX: Remove :term from admin/search_logs/term/:term route.
...
Search log terms is a string that can contain characters like `/` which
messes with the route.
2019-03-29 09:48:20 +08:00
Guo Xiang Tan
c836d67cac
UX: Collapse advanced search on mobile when searching.
...
On smaller mobile devices, the height of the advanced search filters takes up
the whole real estate that it requires the user to scroll down
significantly in order to view the results.
2019-03-29 08:59:02 +08:00
Kris
1a403337c9
UX: Prevent mobile nav from collapsing while content loads
2019-03-28 19:23:23 -04:00
Kris
d9eed924f5
minor box-shadow adjustment
2019-03-28 15:13:53 -04:00
Kris
2b5e16fbec
Minor icon spacing fix for input labels
2019-03-28 15:10:31 -04:00
Robin Ward
3660b85614
FIX: Regressions in JS test suite
2019-03-28 14:15:52 -04:00
Robin Ward
8c98c18c2b
FIX: Remove old flagging scss, fix more linting
2019-03-28 13:48:35 -04:00
Robin Ward
7ec74afc43
FIX: Lint on JS
2019-03-28 13:36:30 -04:00
Robin Ward
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
Gerhard Schlager
d43f4206c7
FEATURE: Add Armenian language
2019-03-28 14:24:14 +01:00
Guo Xiang Tan
d0a1922ad9
FIX: Upload.migrate_to_new_scheme undefined error when external image fails to download.
2019-03-28 16:00:13 +08:00
Tim Lange
1b0267b077
FIX: Switching composer action shouldn't trigger abandon popup ( #7261 )
2019-03-27 21:55:09 +01:00
Saurabh Patel
4a47ec791f
* FEATURE: change layout of escaped_fragment_ topic page to table one like live discourse ( #7250 )
2019-03-27 21:32:56 +01:00
David Taylor
95d5819218
FIX: Re-download hotlinked optimized images ( #7249 )
...
* FIX: Download local images, even if download remote is disabled
2019-03-27 21:31:12 +01:00
Tim Lange
12181599db
FIX: Staff action records now also accepts action_name as filter ( #7256 )
2019-03-27 21:29:15 +01:00
David Taylor
0d3531c2f1
FEATURE: Allow auth providers to define specific icons
...
Previously we relied on the provider name matching the name of the icon. Now icon names are explicitly set. Plugin providers which do not define an icon will get the default "sign-in-alt" icon
2019-03-27 13:25:04 +00:00
Bianca Nenciu
a9798f0c47
FEATURE: Add page for all group membership requests. ( #6909 )
2019-03-27 13:30:59 +02:00
Tarek Khalil
ef2362a30f
FEATURE: Introducing new UI for changing User's notification levels ( #7248 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-27 09:41:50 +00:00
Joffrey JAFFEUX
675d950eab
FIX: corrects link to moderators_activity report ( #7265 )
2019-03-27 10:14:42 +01:00
Kris
f177567cee
Clean up style when both oAuth2 and account approval are enabled
2019-03-26 20:47:06 -04:00
Joe
095ee6ac96
UX: prevent images and lightboxes from extending outside blockquotes ( #7262 )
2019-03-27 01:51:21 +08:00
Gerhard Schlager
4f04ae5692
FIX: Failed to show details about some bounced emails
...
Bounces sent to reply_by_email_address could not be found.
2019-03-26 18:00:27 +01:00
Gerhard Schlager
de011b53b5
UX: Hide link to incoming email when there is no bounce key
...
For example, webhooks mark email log entries as bounced without there ever being an incoming email.
2019-03-26 18:00:27 +01:00
Joe
02f2ce8b05
target panel children instead of targeting the panel ( #7257 )
2019-03-26 23:54:37 +08:00
Joffrey JAFFEUX
b2cacc5b0e
FIX: check can_create_tags on mini-tag-chooser as tag-chooser ( #7260 )
2019-03-26 16:45:38 +01:00
Joffrey JAFFEUX
4874cf742b
FIX: better styling with popover ( #7259 )
2019-03-26 16:34:27 +01:00
Joffrey JAFFEUX
8fb63b2706
FEATURE: unified popover implementation ( #7244 )
2019-03-26 15:43:27 +01:00
Kris
4a1096f14a
IE11 profile fix
2019-03-26 10:13:09 -04:00
Maja Komel
3aa32c3170
FIX: send only one post request when changing topic notification level ( #7254 )
2019-03-26 12:04:33 +01:00
Guo Xiang Tan
e0cb2a434a
Fix regression introduced in dae0bb4c67.
...
Add tests so it doesn't bite me again.
2019-03-26 17:52:37 +08:00
Guo Xiang Tan
dae0bb4c67
FIX: Post blurb incorrect when search contains a phrase match.
...
If the blurb generated is not around the search term, we will not be
able to highlight it on the client side.
2019-03-26 17:01:52 +08:00
Guo Xiang Tan
161a3c3870
DEV: Don't optimize image when migrating to new scheme.
...
The image has already been uploaded, the migrate to new scheme job's is
just to correct the scheme and not the content of the upload.
2019-03-26 15:12:10 +08:00
Sam Saffron
5a8451bf89
PERF: no need to select entire group just to find name
...
Note, this is a very good candidate for some cache longer term to cut
the query out
2019-03-26 17:59:05 +11:00
Sam Saffron
3cfedc6c71
PERF: no need to select the full theme just to get color scheme
2019-03-26 17:53:18 +11:00
Guo Xiang Tan
b58c965aad
FIX: Destroy optimized image if attempting to migrate to new scheme fails.
2019-03-26 14:37:34 +08:00
Guo Xiang Tan
0ac6a58b09
FIX: Skip validation when saving in Upload#migrate_to_new_scheme.
2019-03-26 14:28:39 +08:00
Kris
b1d707b3bb
FIX: More explicit grid layout
2019-03-25 16:41:38 -04:00
Kris
fc81358714
prettier
2019-03-25 14:48:14 -04:00
Penar Musaraj
47a0e4b906
UX: improve mobile search
...
Improves usability of header search icon while user is already in full page search in mobile.
Currently, hitting search icon a second time empties input and does not scroll up to show search form.
This commit scrolls up to show form and sets focus on input.
2019-03-25 14:42:54 -04:00
Kris
df279251b7
REFACTOR: More consistent user/group page layouts
2019-03-25 14:40:22 -04:00
Gerhard Schlager
60e6070c27
UX: Show spinner during text replacement
2019-03-25 16:47:55 +01:00
Penar Musaraj
8d098df289
UX: Inherit badge icon color
...
Fixes issue with icon color differing from text color in select-kit box category style
2019-03-25 09:29:38 -04:00
Joe
ec2123809f
FEATURE: user and group cards on mobile ( #7246 )
2019-03-25 13:37:17 +01:00
Bianca Nenciu
f072da1bfe
FEATURE: Add every month / 6 months options to email digest. ( #7247 )
2019-03-25 12:45:01 +02:00
Tim Lange
dcd56cf593
FIX: Fixed changing composer mode escaping title ( #7191 )
2019-03-25 13:14:26 +05:30
Guo Xiang Tan
ac661e856a
FEATURE: Allow categories to be prioritized/deprioritized in search. ( #7209 )
2019-03-25 10:59:55 +08:00
Guo Xiang Tan
ce75e30bf5
UX: Indent category badges to indicate sub-categories.
2019-03-25 10:36:29 +08:00
Vinoth Kannan
b8bd031648
FIX: Always include custom fields in CategorySerializer
...
even if it is empty
2019-03-25 07:59:56 +05:30
Sam Saffron
40ac895ef7
SECURITY: properly validate return URL for SSO
...
Previously carefully crafted URLs could redirect off site
2019-03-25 09:02:42 +11:00
Neil Lalonde
399e937a38
FIX: prevent sending multiple summary emails due to Sidekiq delays
2019-03-22 12:34:34 -04:00
Penar Musaraj
51e08feb7e
DEV: Refactor icons used in lightbox HTML
...
Uses <svg> elements instead of hacky CSS pseudoelements
Adds a migration to mark posts with lightboxes as needing a rebake
2019-03-22 11:52:06 -04:00
Tim Lange
da187f0967
FIX: Clear unsaved groups when switching user ( #7236 )
2019-03-22 12:46:36 +01:00
David Taylor
a9d5ffbe3d
FIX: Prevent critical emails bypassing disable, and improve email test logic
...
- The test_email job is removed, because it was always being run synchronously (not in sidekiq)
- 34b29f6272ffabf6c2797921
2019-03-22 17:28:43 +08:00
tshenry
48d0465f72
FEATURE: Improve avatar education link ( #7240 )
...
* Make profile_path more direct to setting
* Add id to profile picture setting for easy linking
2019-03-22 02:20:48 -07:00
Guo Xiang Tan
839a54b97b
FIX: Destroy OptimizedImage record even if Upload record is invalid.
2019-03-22 16:47:06 +08:00
Sam Saffron
68fe6b8d53
FIX: suppress autocomplete on group filter
2019-03-22 17:02:04 +11:00
Guo Xiang Tan
7aab7e9062
Revert "UX: Don't reload page after saving settings when editing category."
...
This reverts commit dd142eec03
2019-03-22 13:10:30 +08:00
Osama Sayegh
67b96ad2ff
FIX: discourse client should know about Logster (simpler approach) ( #7237 )
...
* Revert "FIX: discourse client should know about Logster (#7232 )"
This reverts commit bfcbc4d2d6
2019-03-22 08:48:57 +11:00
David Taylor
3f9e7eb326
FIX: Respect the disable_emails=non-staff site setting correctly
...
This reverts commit c279792130https://meta.discourse.org/t/112231/5
2019-03-21 21:44:14 +00:00
Régis Hanol
e1e46f0dff
FIX: topic with no tags
2019-03-21 19:40:10 +01:00
Neil Lalonde
1812a38f0a
FIX: upload watched words should use UTF-8
2019-03-21 13:46:16 -04:00
Maja Komel
1f1d3909e5
UX: add more tag classes to topic view ( #7228 )
...
adds tag classes where there is already category-* class
2019-03-21 17:49:50 +01:00
Kris
252e17ea1b
UX: add padding to hidden content link
2019-03-21 11:50:41 -04:00
Vinoth Kannan
1e3cb7575d
DEV: Update webhook event attributes even when an error raised
2019-03-21 20:45:21 +05:30
Maja Komel
34730a0b16
UX: show if webhook is disabled ( #7217 )
...
+ show in staff logs when webhook is created/updated/destroyed
2019-03-21 16:13:09 +01:00
Osama Sayegh
bfcbc4d2d6
FIX: discourse client should know about Logster ( #7232 )
2019-03-21 16:54:55 +03:00
Tarek Khalil
605530a77f
FEATURE: Include muted users count within the ignored users report ( #7230 )
2019-03-21 14:31:45 +01:00
Vinoth Kannan
4c6bfb9b39
DEV: Don't destroy webhook in case of error
2019-03-21 18:34:54 +05:30
Tarek Khalil
a31a35b334
FEATURE: Ignored user notification behaviour should be as a muted user ( #7227 )
2019-03-21 12:15:34 +01:00
Guo Xiang Tan
100ad15e18
Make prettier happy.
2019-03-21 17:25:05 +08:00
Tim Lange
d16a0db4e1
UX: Enabled sorting for more columns in admin user list ( #7208 )
2019-03-21 17:16:58 +08:00
Bianca Nenciu
fdd2e7f2e7
FIX: Do not update last seen notification ID when forced to enable 2FA." ( #7222 )
2019-03-21 09:27:22 +01:00
Tim Lange
f7b156ffbd
UX: Better emoji escaping for topic title ( #7218 )
...
* FIX: Fixed failing discourse-prometheus-alert-receiver plugin specs
2019-03-21 09:11:33 +01:00
Gerhard Schlager
41c7423985
UX: Use a less technical term ("replace") for reseeding ( #7223 )
2019-03-21 16:22:07 +11:00
Kris
896204bef7
FIX: Don't override .is-hidden on mobile
2019-03-20 20:40:43 -04:00
Kris
c7c409549b
margin fix
2019-03-20 16:04:47 -04:00
Tarek Khalil
1dd0fa0c4e
REFACTOR: Move redundant ignored user check into guardian ( #7219 )
...
* REFACTOR: Move redundant ignored user check into guardian
2019-03-20 19:55:46 +00:00
Penar Musaraj
3c7eb74f51
DEV: no delaying topic scroll in tests
2019-03-20 15:24:06 -04:00
Joffrey JAFFEUX
45ef2ec8cd
DEV: do not wait for closed composer event on test ( #7221 )
2019-03-20 20:13:15 +01:00
Kris
88a3b89990
UX: Improve user profile header layout on mobile
2019-03-20 14:56:34 -04:00
Tarek Khalil
5852e86226
FEATURE: Only allow TL2 Users to ignore other users ( #7212 )
2019-03-20 15:02:33 +01:00
Rishabh
ad6ad3f679
DEV: Remove SiteSetting.s3_force_path_style ( #7210 )
...
- s3_force_path_style was added as a Minio specific url scheme but it has never been well supported in our code base.
- Our new migrate_to_s3 rake task does not work reliably with path style urls too
- Minio has also added support for virtual style requests i.e the same scheme as AWS S3/DO Spaces so we can rely on that instead of using path style requests.
- Add migration to drop s3_force_path_style from the site_settings table
2019-03-20 14:58:20 +01:00
Maja Komel
f3d0d8fe7d
Upgrade to Ember 3.7.0
2019-03-20 14:43:25 +01:00
Dan Ungureanu
f2c6a160e5
DEV: Fix build.
...
Follow-up to eed1c9e0e3
2019-03-20 12:45:00 +02:00
Tarek Khalil
3b59ff0d02
[FEATURE] Disallow ignoring self, admins or moderators users ( #7202 )
2019-03-20 11:18:46 +01:00
Tarek Khalil
fed2dd9148
FEATURE: Add scheduled job to purge expired ignored users ( #7211 )
2019-03-20 11:01:43 +01:00
Dan Ungureanu
eed1c9e0e3
FIX: Do not show post notices for bots.
2019-03-20 11:58:02 +02:00
Joe
6f1badc7c9
REFACTOR: user and group card CSS / template refactor ( #6812 )
...
* Check if user is a member of a group or if the group has members
this is used in the template to conditionally show the relevant markup
* Check if user is suspended or if they have a bio
this is used in the template to conditionally show the relevant markup
* Simplify group-card template
* Simplify user-card template
* Refactor user and group cards CSS
* Check if user is new or if user is staff
* Style fixes
- round avatar margin
- use a more standard margin for buttons
- adds lighter font color for new users
- makes some suspension text bold (used to be <b> tags in template)
- ensures images in group bio are responsive
* user card template fixes
- adds quotes to link href attributes
- wraps some strings in tags for more consistent styling
* group card fixes
- adds quotes to link href attributes
- fixes membership button login action
- wraps some strings with tags for consistent styling
* closure action fixes
* closure action fix
* uses core variables instead of new colors and removes unused styles
* Uses better property names
2019-03-20 10:45:49 +01:00
Guo Xiang Tan
8d1709f6b9
FIX: Disable buttons when loading more results on full page search.
...
Follow up to d50deac676
2019-03-20 17:20:34 +08:00
tshenry
cc8082138f
Fix typos
2019-03-20 00:06:12 -07:00
Guo Xiang Tan
03c6b22c62
PERF: Reduce number of queries and size of payload when searching.
...
1. Remove `cooked` becaused only the blurb is used on the client side to
display search results.
2. Remove `ignored` because the result is not used in anyway when
searching for pots.
2019-03-20 14:40:39 +08:00
Sam Saffron
d46ce0cb21
DEV: speed up ember acceptance tests
...
## Before
```
Acceptance: Composer::Image resizing buttons: 7985ms
Acceptance: Composer::Edit the first post: 3854ms
Acceptance: Composer::Composer with dirty edit can toggle to another edit: 3707ms
Acceptance: Composer::Composer can toggle between edit and reply: 3704ms
Acceptance: Composer::Tests the Composer controls: 3685ms
Acceptance: Composer::Composer draft with dirty reply can toggle to edit: 3670ms
Acceptance: Composer::Composer can toggle layouts (open, fullscreen and draft): 3278ms
Acceptance: Composer::Switching composer whisper state: 3266ms
Acceptance: Composer::Create a topic with server side errors: 3253ms
Acceptance: Composer::Composer with dirty reply can toggle to edit: 3189ms
Acceptance: Composer::Create a Topic: 3168ms
Acceptance: Composer::Create an enqueued Topic: 2767ms
Acceptance: Composer::Posting on a different topic: 2394ms
Acceptance: Composer::Composer can switch between edits: 2318ms
Acceptance: Composer::Create an enqueued Reply: 2317ms
Acceptance: Composer::Create a Reply: 2292ms
Acceptance: Composer::Checks for existing draft: 1696ms
Acceptance: Composer::Composer can toggle between reply and createTopic: 1415ms
Acceptance: Composer::Composer can toggle whispers: 1296ms
Acceptance: Composer::Loading draft also replaces the recipients: 594ms
```
## After
```
Acceptance: Composer::Composer can toggle layouts (open, fullscreen and draft): 2305ms
Acceptance: Composer::Switching composer whisper state: 2205ms
Acceptance: Composer::Composer draft with dirty reply can toggle to edit: 2185ms
Acceptance: Composer::Composer can toggle between edit and reply: 1719ms
Acceptance: Composer::Composer with dirty edit can toggle to another edit: 1682ms
Acceptance: Composer::Composer with dirty reply can toggle to edit: 1657ms
Acceptance: Composer::Composer can toggle between reply and createTopic: 1412ms
Acceptance: Composer::Posting on a different topic: 1341ms
Acceptance: Composer::Edit the first post: 1327ms
Acceptance: Composer::Create an enqueued Reply: 1306ms
Acceptance: Composer::Composer can toggle whispers: 1265ms
Acceptance: Composer::Composer can switch between edits: 1260ms
Acceptance: Composer::Create a Reply: 1259ms
Acceptance: Composer::Create a topic with server side errors: 1183ms
Acceptance: Composer::Checks for existing draft: 1172ms
Acceptance: Composer::Create a Topic: 1130ms
Acceptance: Composer::Image resizing buttons: 921ms
Acceptance: Composer::Create an enqueued Topic: 731ms
Acceptance: Composer::Tests the Composer controls: 654ms
Acceptance: Composer::Loading draft also replaces the recipients: 540ms
```
That is not a typo... image resizing button went from 8 seconds to 1 second
2019-03-20 16:44:00 +11:00
Guo Xiang Tan
d50deac676
FIX: Search spinners hides all results when loading more.
...
Regression from bc81f64a64
2019-03-20 13:34:56 +08:00
Bianca Nenciu
50e9a66e89
FIX: Improve UX for second factor enforcement. ( #7207 )
2019-03-20 15:40:25 +11:00
Kris
c72a60896c
FIX: New account modal too narrow in Safari
2019-03-19 15:13:04 -04:00
Kris
955c8cb330
FIX: Login modal too narrow in Safari
2019-03-19 15:07:35 -04:00
Joe
ac4470cd56
UX: Hide mobile header notification badges if title is visible
2019-03-20 01:43:23 +08:00
Joe
533fb0019a
fully hide header buttons if topic is visible ( #7203 )
2019-03-19 15:31:45 +01:00
Vinoth Kannan
0861ca7764
FIX: Don't push browser state if navigated from root url to home page url and vice versa
2019-03-19 19:22:06 +05:30
Dan Ungureanu
bdcb0e1efd
UX: Set color to gray for old post notices.
2019-03-19 15:47:47 +02:00
Leo McArdle
b084750953
FIX: don't redirect incorrectly after full screen login ( #7170 )
...
Fixes two issues:
1. Redirecting to an external origin's path after login did not work
2. User would be erroneously redirected to the external origin after logout
https://meta.discourse.org/t/109755
2019-03-19 12:39:13 +00:00
Régis Hanol
6fb49e74a1
Revert "UX: Better emoji escaping for topic title ( #7176 )" ( #7201 )
...
This reverts commit 0d9bc0aaa6
2019-03-19 12:02:47 +01:00
Régis Hanol
31e06dbcd2
FIX: SES webhook wasn't parsing the message
2019-03-19 11:40:19 +01:00
Joe
6d7c0c8f13
REFACTOR: scroll-based mobile header switch
...
This refactor addresses the following issues:
1- Moves all relevant logic to the discourse-topic component (matches desktop)
2- Fixes the flicker issue discussed here
3- Fixes a rare occurring issue where tags wrap to a third line if a topic has long category names and lots of tags
4- Fixes header icon jitter on iOS
5- Fixes an issue where sliding out user / hamburger menus on Android leaves the user in a mid-state with half a title and the header panel visible - swiping will now open the menus but have no effect on the header.
6- adds min-width to the small-logo to act as placeholder so that the title doesn't shift if the logo takes a while to load.
Other than that, everything should look and act the same.
2019-03-19 18:39:38 +08:00
Guo Xiang Tan
d808f36fc4
FIX: Reindex post for search when post is moved to a different topic.
...
* This is causing certain posts to appear in searches incorrectly as `PostSearchData#raw_data` contains the outdated title, category name and tag names.
2019-03-19 17:19:14 +08:00
Maja Komel
714a0d87df
UX: order categories based on latest activity for all page styles ( #7196 )
...
follow up on 32db3ac2
2019-03-19 09:35:32 +01:00
Tim Lange
0d9bc0aaa6
UX: Better emoji escaping for topic title ( #7176 )
2019-03-19 09:33:10 +01:00
Guo Xiang Tan
dd142eec03
UX: Don't reload page after saving settings when editing category.
2019-03-19 16:08:32 +08:00
Guo Xiang Tan
bc81f64a64
UX: Show spinner when searching on full page search.
2019-03-19 15:23:27 +08:00
Sam Saffron
f8be43644b
DEV: allow nonce expiry time to be extended cleanly from a plugin
...
Previously one would have to redefine a constant
2019-03-19 17:33:38 +11:00
Guo Xiang Tan
4020c87680
DEV: Refactor tests for Jobs::CleanUpInactiveUsers.
...
* Remove use of 0 in favor of `TrustLevel.levels[:newuser]`.
* Consolidate two tests into a single one.
* Test that disabling the feature works.
* Avoid loading full ActiveRecord object in test when we only need to
know the existence of the record.
2019-03-19 09:57:21 +08:00
Gerhard Schlager
8a99d59422
FIX: seed data classes couldn't always be found
2019-03-18 23:13:47 +01:00
Gerhard Schlager
3fd04df781
FEATURE: Locale support for seeded categories and topics ( #7110 )
2019-03-18 21:09:13 +01:00
Joffrey JAFFEUX
d91b47064e
FIX: windows has no country flags ( #7199 )
2019-03-18 19:28:49 +01:00
Maja Komel
5d20d02ffc
UX: add tag classes to topics in topics list view ( #7198 )
2019-03-18 13:58:29 -04:00
David Taylor
e2d6edd5ff
DEV: Correct email disabled banner tests
...
Followup to acc121fd27
2019-03-18 17:06:29 +00:00
Dan Ungureanu
976ea160e9
FEATURE: Post notices become old after 14 days. ( #7197 )
2019-03-18 18:20:49 +02:00
Gerhard Schlager
c0a7b06777
Make eslint happy
2019-03-18 16:48:09 +01:00
David Taylor
acc121fd27
FIX: Show 'emails disabled' to staff users when disabled for non-staff ( #7187 )
2019-03-18 16:26:18 +01:00
Bianca Nenciu
2347661a74
FEATURE: Clean up inactive users. ( #7172 )
2019-03-18 16:25:15 +01:00
Maja Komel
7e9afdace3
FEATURE: custom colors for default letter avatars ( #7167 )
2019-03-18 16:24:21 +01:00
Tim Lange
22c75e1c04
FIX: Fixed edit category description redirecting without saving ( #7192 )
2019-03-18 16:14:17 +01:00
Tim Lange
298f18cf70
UX: Enabled pinch to zoom for lightbox ( #7161 )
...
* UX: Enabled pinch to zoom for lightbox
* FIX: Prettier for lightbox.js
* FIX: Only change content of meta tag
2019-03-18 10:57:24 -04:00
venarius
3dfa22b55a
FIX: Prettified code
2019-03-18 10:54:20 -04:00
venarius
4af0a2f00b
FIX: Made reorder more convenient by clamping the entered number
2019-03-18 10:54:20 -04:00
venarius
ad363f45f0
FIX: Fixed reorder categories by number not working correctly
2019-03-18 10:54:20 -04:00
Penar Musaraj
2506acae80
FIX: Respect permalinks starting with "/category" ( #7171 )
2019-03-18 10:24:46 -04:00
David Taylor
4e8c174ee5
FEATURE: Display notification count in title for logged in users ( #7184 )
...
This replaces the 'contextual' counters for logged in users. We will still use the old method for anon users
2019-03-18 12:59:47 +00:00
Arpit Jalan
0c01cb2cf3
UX: add instructions to update email when sso_overrides_email is enabled
2019-03-18 16:52:40 +05:30
Guo Xiang Tan
5e410dc5e0
FEATURE: Ability to exclude category from search results. ( #7194 )
...
This commit also adds `Category#search_priority` which sets the ground
work to enable prioritizing of posts for certain categories when searching.
2019-03-18 15:25:45 +08:00
Joffrey JAFFEUX
0a8f950281
FIX: bumps emoji cache version ( #7195 )
...
Might not be necessary, but might avoid weird results with all the recents emoji changes.
2019-03-18 08:22:36 +01:00
Joffrey JAFFEUX
de6a7e32bd
FIX: brings back [+ New Topic] btn from share-popup post action ( #7182 )
2019-03-18 07:30:10 +01:00
Sam Saffron
c47b0a8bee
Revert "UX: Added tooltips to topic admin menu ( #7146 )"
...
This reverts commit d1c4981f65
2019-03-18 11:50:18 +11:00
Vinoth Kannan
4477938ea7
DEV: Option to preload category custom fields for site serializer
2019-03-16 17:18:57 +05:30
Joffrey JAFFEUX
bc488c8dc0
FIX: prevents overflow on emoji picker on mobile ( #7189 )
2019-03-16 10:59:02 +01:00
Kris
b12ef793b7
minor button alignment fix
2019-03-15 19:25:51 -04:00
Kris
95e8c935c5
UX: Update brand color, some login adjustments
2019-03-15 17:20:52 -04:00
Rafael dos Santos Silva
8ce20090f7
FEATURE: Allow users to fetch a customized manifest on PWA install
...
This will allow users installing a Discourse PWA to use their active
theme colors on the generated app. Thanks for @mgiuca for the tip.
Also makes the share_target config explicit to silence Chrome warnings
2019-03-15 17:10:05 -03:00
Joffrey JAFFEUX
e76b598e0f
FIX: ensures add/remove btn is shown if you can only invite ( #7185 )
2019-03-15 20:20:42 +01:00
Bianca Nenciu
5114ef958a
FIX: Do not trigger post alerts for empty posts. ( #7138 )
2019-03-15 17:58:43 +01:00
Joffrey JAFFEUX
aa4b84925a
FEATURE: updates emoji to latest 12.0 version ( #7095 )
...
* improved emoji support
- always optimize images as part of the task
- use the unicode standard ordering/naming for sections
* UX: more height for when there are recently used
2019-03-15 16:12:07 +01:00
Penar Musaraj
9334d2f4f7
FEATURE: add more granular user option levels for email notifications ( #7143 )
...
Migrates email user options to a new data structure, where `email_always`, `email_direct` and `email_private_messages` are replace by
* `email_messages_level`, with options: `always`, `only_when_away` and `never` (defaults to `always`)
* `email_level`, with options: `always`, `only_when_away` and `never` (defaults to `only_when_away`)
2019-03-15 10:55:11 -04:00
Régis Hanol
a6a52d1523
FIX: images:compress rake task
...
Optimized a few unoptimized PNGs.
2019-03-15 15:23:57 +01:00
Tarek Khalil
f8480ed911
FEATURE: Exposing a way to add a generic report filter ( #6816 )
...
* FEATURE: Exposing a way to add a generic report filter
## Why do we need this change?
Part of the work discussed [here](https://meta.discourse.org/t/gain-understanding-of-file-uploads-usage/104994 ), and implemented a first spike [here](https://github.com/discourse/discourse/pull/6809 ), I am trying to expose a single generic filter selector per report.
## How does this work?
We basically expose a simple, single generic filter that is computed and displayed based on backend values passed into the report.
This would be a simple contract between the frontend and the backend.
**Backend changes:** we simply need to return a list of dropdown / select options, and enable the report's newly introduced `custom_filtering` property.
For example, for our [Top Uploads](https://github.com/discourse/discourse/pull/6809/files#diff-3f97cbb8726f3310e0b0c386dbe89e22R1423 ) report, it can look like this on the backend:
```ruby
report.custom_filtering = true
report.custom_filter_options = [{ id: "any", name: "Any" }, { id: "jpg", name: "JPEG" } ]
```
In our javascript report HTTP call, it will look like:
```js
{
"custom_filtering": true,
"custom_filter_options": [
{
"id": "any",
"name": "Any"
},
{
"id": "jpg",
"name": "JPG"
}
]
}
```
**Frontend changes:** We introduced a generic `filter` param and a `combo-box` which hooks up into the existing framework for fetching a report.
This works alright, with the limitation of being a single custom filter per report. If we wanted to add, for an instance a `filesize filter`, this will not work for us. _I went through with this approach because it is hard to predict and build abstractions for requirements or problems we don't have yet, or might not have._
## How does it look like?
## More on the bigger picture
The major concern here I have is the solution I introduced might serve the `think small` version of the reporting work, but I don't think it serves the `think big`, I will try to shed some light into why.
Within the current design, It is hard to maintain QueryParams for dynamically generated params (based on the idea of introducing more than one custom filter per report).
To allow ourselves to have more than one generic filter, we will need to:
a. Use the Route's model to retrieve the report's payload (we are now dependent on changes of the QueryParams via computed properties)
b. After retrieving the payload, we can use the `setupController` to define our dynamic QueryParams based on the custom filters definitions we received from the backend
c. Load a custom filter specific Ember component based on the definitions we received from the backend
2019-03-15 12:15:38 +00:00
Bianca Nenciu
d352baa1a2
FEATURE: Enforce two-factor authentication. ( #6348 )
2019-03-15 13:09:37 +02:00
Joffrey JAFFEUX
e711d3cb3a
FIX: prevents quote shortcut key to show in composer before quote ( #7177 )
2019-03-15 12:01:38 +01:00
Guo Xiang Tan
6327f36bfd
PERF: Avoid loading ActiveRecord objects when checking for second factor.
...
* Eliminate DB query for sites without local logins and sites that has
SSO enabled.
2019-03-15 15:09:44 +08:00
Guo Xiang Tan
c5808a8a25
PERF: N+1 queries admin users pages.
2019-03-15 15:09:44 +08:00
Penar Musaraj
d6d4a5ba4a
FEATURE: support custom icons in themes ( #7155 )
...
* First take
* Add support for sprites in themes
Automatically register any custom icons added via themes or plugins
* Fix theme sprite caching
* Simplify test
* Update lib/svg_sprite/svg_sprite.rb
Co-Authored-By: pmusaraj <pmusaraj@gmail.com>
* Fix /svg-sprite/search request
2019-03-15 17:16:15 +11:00
Maja Komel
32db3ac228
UX: order categories based on recent activity when using categories_and_latest_topics layout ( #7166 )
2019-03-15 17:14:49 +11:00
Tim Lange
37c613dde2
FIX: Outsourced erb part from emoji.js.es6 ( #7168 )
2019-03-15 15:44:49 +11:00
Vinoth Kannan
bec3956f7f
FIX: Topic filters persist when navigating to home page ( #7175 )
...
* FIX: Topic filters persist when navigating to home page
* remove the line which no longer needed
2019-03-15 09:45:17 +05:30
Tarek Khalil
bd6d31c9ec
FEATURE: Add IgnoredUsersSummary daily job ( #7144 )
...
* FEATURE: Add `IgnoredUsersSummary` daily job
## Why?
This is part of the [Ability to ignore a user feature](https://meta.discourse.org/t/ability-to-ignore-a-user/110254/8 ).
We want to:
1. Send an automatic group PM that goes out to moderators
2. When {x} users have Ignored the same user, threshold defined by a site setting, default of 5
3. Only send this message every X days which is defined by another site setting
2019-03-14 22:51:43 +00:00
Rafael dos Santos Silva
fb8bcd7469
FEATURE: Enable experimental Badging API ( #7173 )
2019-03-14 18:16:16 -03:00
Arpit Jalan
d6d71de855
FIX: allow banner topic posts to be moved to regular topic (and vice versa)
2019-03-14 23:41:23 +05:30
Robin Ward
1b65469b64
FIX: Backwards compatibility for SiteSetting.queue_jobs
...
Some plugin specs use this. Let's deprecate it instead.
2019-03-14 11:39:10 -04:00
Robin Ward
fa5a158683
REFACTOR: Move queue_jobs out of SiteSetting
...
It is not a setting, and only relevant in specs. The new API is:
```
Jobs.run_later! # jobs will be thrown on the queue
Jobs.run_immediately! # jobs will run right away, avoid the queue
```
2019-03-14 10:47:38 -04:00
Gerhard Schlager
f3c76ad482
FIX: Failed to detect existing category permalink
2019-03-14 13:42:05 +01:00
Gerhard Schlager
c34a6ba674
REFACTOR: Rename site settings to make them less confusing
2019-03-14 13:40:14 +01:00
Tarek Khalil
6f6dea87f3
FIX: optimise querying Post's serializer ignored attribute ( #7169 )
2019-03-14 12:10:53 +00:00
Guo Xiang Tan
b9ab393d70
Fix favicon not updating on the client side when changed.
...
Regression from 1c6a2262b3
2019-03-14 15:37:43 +08:00
Guo Xiang Tan
40b03e717b
FIX: Upload#migrate_to_new_scheme should not migrate system uploads.
2019-03-14 12:45:03 +08:00
Guo Xiang Tan
d2a7f29595
Revert "REFACTOR: remove unnecessary parentheses attempt 2 (follow-up on 154f503d)"
...
This reverts commit 7db2dc717e
2019-03-14 08:15:40 +08:00
Guo Xiang Tan
1c6a2262b3
FIX: StaticController#favicon reads from disk when using local store. ( #7160 )
...
Since uploads site settings are now backed by an actual upload, we don't
have to reach over the network just to fetch the favicon. Instead, we
can just read the upload directly from disk.
2019-03-14 04:17:36 +08:00
Neil Lalonde
7db2dc717e
REFACTOR: remove unnecessary parentheses attempt 2 (follow-up on 154f503d)
2019-03-13 15:33:46 -04:00
Dan Ungureanu
81bf4df1a5
DEV: Fix lint.
2019-03-13 21:32:28 +02:00
Dan Ungureanu
18ff790e79
FIX: Use prioritize_username_in_ux in post notices.
2019-03-13 21:17:41 +02:00
Roman Rizzi
77931b70c3
Revert "DEV: Upgrade to Ember 3.7.0 ( #6977 )" ( #7165 )
...
This reverts commit 3eebf8be73
2019-03-13 15:49:47 -03:00
Kris
4178578e09
UX: Adhere to Facebook & Twitter brand guidelines for share icon colors
2019-03-13 13:42:11 -04:00
Maja Komel
65f3ed0689
UX: make name optional for confirmation user field ( #7149 )
2019-03-13 18:40:43 +01:00
Maja Komel
12c37ada2e
UX: focus on search box when emoji picker is opened ( #7098 )
2019-03-13 17:48:40 +01:00
David Taylor
420c6f8102
FEATURE: Skip sending emails to domains on the .invalid TLD ( #7162 )
...
This is a reserved TLD which we use when importing users without an email address. https://tools.ietf.org/html/rfc2606
2019-03-13 16:17:59 +00:00
Dan Ungureanu
91bd0becaa
DEV: Allow topics to register default topic order criteria. ( #7158 )
2019-03-13 16:44:08 +01:00
Vinoth Kannan
c773f82ba1
DEV: Added qunit test functions and did minor refactoring
...
135191d1d1
2019-03-13 18:38:27 +05:30
Joffrey JAFFEUX
d32557ea32
Revert "FIX: Better emoji escaping for topic title"
...
This reverts commit 35426b5ad6
2019-03-13 13:02:56 +01:00
Maja Komel
3eebf8be73
DEV: Upgrade to Ember 3.7.0 ( #6977 )
...
* Upgrade to Ember 3.7.0
* use ember source 3.7.0.2
* fix mobile header
* fix navigation
2019-03-13 12:16:06 +01:00
Vinoth Kannan
1b454c73ae
FIX: 'topic' can have null value
2019-03-13 16:34:47 +05:30
Tim Lange
35426b5ad6
FIX: Better emoji escaping for topic title
...
This commit also puts emojiVersion in its own erb file.
2019-03-13 11:17:59 +01:00
Vinoth Kannan
135191d1d1
DEV: Option to add extra topic status icons in its widget and component
...
and did some refactoring
2019-03-13 15:17:26 +05:30
Guo Xiang Tan
b0c8fdd7da
FIX: Properly support defaults for upload site settings.
2019-03-13 16:36:57 +08:00
Tim Lange
d1c4981f65
UX: Added tooltips to topic admin menu ( #7146 )
...
* UX: Added tooltips to topic admin menu
* FIX: Prettyfied code
* FIX: Fixed typo
* Update config/locales/client.en.yml
Co-Authored-By: venarius <tim.lange@online.de>
2019-03-13 17:11:36 +11:00
Joffrey JAFFEUX
edc6d87862
FIX: invite-panels regressions on private topics ( #7157 )
2019-03-13 16:34:23 +11:00
Dan Ungureanu
476d0050ab
FIX: Disable notices for posts by anonymous.
2019-03-13 00:20:19 +02:00
Dan Ungureanu
7310ee3ef1
FEATURE: Add more control over post notices. ( #7148 )
2019-03-13 08:06:28 +11:00
Neil Lalonde
e9ba4c74f7
Revert "REFACTOR: remove unnecessary parentheses"
...
Specs fail
2019-03-12 15:00:58 -04:00
Bianca Nenciu
c6ed86220e
FIX: Notify on tag change. ( #7119 )
2019-03-12 18:09:34 +01:00
Saurabh Patel
a901527057
DEV: remove user_profile events added for akismet ( #7044 )
2019-03-12 17:51:09 +01:00
Régis Hanol
154f503d2e
REFACTOR: remove unnecessary parentheses
2019-03-12 17:13:21 +01:00
Tarek Khalil
28384ba62c
FEATURE: Add Top Ignored Users report ( #7153 )
...
* FEATURE: Add `Top Ignored Users` report
## Why?
This is part of the [Ability to ignore a user feature](https://meta.discourse.org/t/ability-to-ignore-a-user/110254/8 ), and also part of [this PR](https://github.com/discourse/discourse/pull/7144 ).
We want to send a System Message daily when a specific count threshold for an ignored is reached. To make this system message informative, we want to link to a report for the Top Ignored Users too.
2019-03-12 16:01:58 +00:00
Tarek Khalil
4a00772c19
FIX: invite approval StaffActionLogger bug ( #7151 )
...
* FIX: invite approval `StaffActionLogger` bug
2019-03-12 13:32:25 +00:00
Tarek Khalil
db08b59eb2
UX: Change ignore button color ( #7150 )
2019-03-12 11:10:18 +00:00
Joffrey JAFFEUX
90965e1c18
FIX: error with two inputs having the same id ( #7147 )
2019-03-12 09:46:58 +01:00
Bianca Nenciu
e6c2faf186
FIX: Disable 'Create Topic' button if tag is staff-only. ( #6984 )
...
* FIX: Disable 'Create Topic' button if tag is staff-only.
* FIX: Staff-only tags should always return 404.
2019-03-12 19:23:36 +11:00
Bianca Nenciu
191e31dccf
FEATURE: Log user approvals. ( #7121 )
2019-03-12 19:16:56 +11:00
Guo Xiang Tan
34b29f62db
DEV: Remove the use of stubs and mocks in Jobs::UserEmail tests.
...
We can only be sure that an email is sent when we get a mailer in
`ActionMailer::Deliveries`. A couple of tests were actually incorrect
because it didn't flow through our email sender where there are more
conditions in determining whether an email is sent or not.
2019-03-12 09:39:16 +08:00
Dan Ungureanu
32bae48fd3
DEV: Use User#human? User#bot? ( #7140 )
2019-03-12 07:58:14 +08:00
venarius
95dc52e15e
FIX: Changed warning css class
2019-03-11 12:56:15 -04:00
venarius
dc4541a95c
FIX: Text content search warning if more than 50 results
2019-03-11 12:56:15 -04:00
Robin Ward
da7406e567
Update app/assets/javascripts/discourse/controllers/full-page-search.js.es6
...
Co-Authored-By: venarius <tim.lange@online.de>
2019-03-11 11:33:24 -04:00
venarius
5f00624814
FIX: Fixed vanishing select boxes on full search as new content loads
2019-03-11 11:33:24 -04:00
Joffrey JAFFEUX
7ae1afa7d9
FIX: ensures tag-groups are used to allow category edit on topics ( #7141 )
2019-03-11 15:02:27 +01:00
Tarek Khalil
d6eb892b04
FEATURE: Account for ignored_users when merging two users ( #7142 )
...
* FEATURE: Account for `ignored_users` when merging two users
## Why?
This is part of the [Ability to ignore a user feature](https://meta.discourse.org/t/ability-to-ignore-a-user/110254/8 ).
When we merge two users, we need to account for merging their list of `ignored_users` too.
2019-03-11 13:53:59 +00:00
Dan Ungureanu
ceec11a153
FIX: Make post notices invisible to poster.
2019-03-11 12:07:19 +02:00
Dan Ungureanu
b28b418363
FIX: Various improvements to post notices.
...
- Notices are visible only by poster and trust level 2+ users.
- Notices are not generated for non-human or staged users.
- Notices are deleted when post is deleted.
2019-03-11 11:19:58 +02:00
Guo Xiang Tan
88355884c9
Exclude post_notice_* from web hook post payload.
2019-03-11 11:04:17 +08:00
Neil Lalonde
cbc8236288
UX: add a paragraph description on the tags tab of the category settings
2019-03-08 16:46:32 -05:00
Kris
c29ff3d2d5
UX: style adjustments for post notice feature
2019-03-08 16:02:51 -05:00
Robin Ward
57ee779b1e
FIX: Job exception: undefined method `email' for nil:NilClass
...
It seems that due to jobs being asynchronous and wrapping code in a
DistributedMutex that by the time we run the
`UserAvatar#update_gravatar!` job that the user/user email might be
destroyed.
This patch checks before a call to `user.email_hash` to make sure
the user and primary email exist to prevent the exception. If not
present, the job exits as there's nothing to do because we are
probably running after the user was destroyed for some reason.
2019-03-08 13:39:56 -05:00
Kris
e3e681ebf7
UX: better handling of width and overflow for login/signup
2019-03-08 11:14:52 -05:00
Osama Sayegh
5e58cedfbd
FIX: retranspile theme JS when settings YAML changes ( #7131 )
2019-03-08 17:49:06 +03:00
David Taylor
0a4562253e
DEV: Add 'starting' event to sidekiq log when interval logging enabled
2019-03-08 10:56:36 +00:00
David Taylor
e2510d79cc
DEV: Improve thread-safety of sidekiq logging
2019-03-08 10:31:49 +00:00
Dan Ungureanu
ac8425ad30
FIX: Date format and styling for post notices
...
Follow-up to 35942f7
2019-03-08 12:25:03 +02:00
Régis Hanol
ad12b2a23d
FIX: only call 'unlink' for tempfiles
2019-03-08 11:22:20 +01:00
Régis Hanol
7ff994b6ea
UX: post-notice max width on desktop
2019-03-08 10:52:47 +01:00
Régis Hanol
2434e48d4d
UX: Fix post notice on mobile
2019-03-08 10:50:33 +01:00
David Taylor
9db05a895a
DEV: Add job_id to sidkiq log
...
This makes it easier to correlate 'pending' logs from the same job
2019-03-08 09:16:13 +00:00
Dan Ungureanu
2312caccdc
FEATURE: Skip small actions when counting replies in PMs. ( #7108 )
2019-03-08 10:49:34 +02:00
Dan Ungureanu
35942f7c7c
FEATURE: Special call-out for new / returning posters. ( #7115 )
2019-03-08 10:48:35 +02:00
Simon Cossar
65464969cd
Change searchTearm to searchTerm ( #7130 )
2019-03-08 09:24:14 +01:00
Joffrey JAFFEUX
3acf8a95f3
UX: various tweaks to search-menu ( #7114 )
2019-03-08 09:23:44 +01:00
Joffrey JAFFEUX
c90267db52
FIX: do not display add/remove participants if you can’t actually do it ( #7125 )
2019-03-08 09:23:26 +01:00
Kris
cd94ac9453
FIX: remove padding from onebox site icon in composer preview
2019-03-07 22:32:27 -05:00
Kris
6e26358380
REFACTOR: streamline like button styles, clarify for themeing, enable tab focus
2019-03-07 21:09:57 -05:00
Gerhard Schlager
f6ef4f8c3f
FEATURE: Add missing S3 regions
2019-03-07 22:42:20 +01:00
Kris
ccff1d2dbb
prettier
2019-03-07 13:30:39 -05:00
Kris
837452794b
Target active nav pill with single style
2019-03-07 13:21:42 -05:00
Joffrey JAFFEUX
a2fdd4089c
FIX: nav-pills not highlighted on user preferences page ( #7126 )
2019-03-07 13:40:12 +01:00
David Taylor
fc7938f7e0
REFACTOR: Migrate GoogleOAuth2Authenticator to use ManagedAuthenticator ( #7120 )
...
https://meta.discourse.org/t/future-social-authentication-improvements/94691/3
2019-03-07 11:31:04 +00:00
Arpit Jalan
2c8e1d3578
FEATURE: remove all expired invitations by default
2019-03-07 15:28:39 +05:30
Arpit Jalan
caef0a56d1
FEATURE: create a new message via URL without specifying user or group
2019-03-07 11:30:24 +05:30
Kris
9d3c7d7b25
prettier
2019-03-06 19:52:34 -05:00
Kris
e233a69db0
Customize nav pill fix
2019-03-06 19:42:44 -05:00
Kris
7d2cc33013
prettier
2019-03-06 17:37:59 -05:00
Kris
a917a93990
fix active class, remove style
2019-03-06 17:29:19 -05:00
Kris
536952f194
adding back active nav pill
2019-03-06 17:14:02 -05:00
Bianca Nenciu
733deba585
FIX: Loading draft also replaces the recipients ( #7122 )
2019-03-07 08:14:55 +11:00
Kris
078c02cd24
UX: More consistent structure for active nav-pill
2019-03-06 16:10:22 -05:00
Gerhard Schlager
1121514799
UX: Localize date format in "new user of the month" message
2019-03-06 21:58:25 +01:00
Vinoth Kannan
5ba2ef4274
UX: Display error message if no time frame selected in topic status update
2019-03-07 02:17:29 +05:30
Vinoth Kannan
167d85c21f
FIX: post & topic destroyed hooks not triggering with tag filter
2019-03-06 22:52:54 +05:30
Kris
2db3652338
UX: Fix redeemed invite table layout
2019-03-06 11:05:45 -05:00
Gerhard Schlager
4000978452
FIX: Failed to save email template with pluralized subject
2019-03-06 16:51:04 +01:00
Kris
5cf63e43c6
FEATURE: Add about-after-description plugin outlet
2019-03-06 10:26:34 -05:00
David Taylor
df474bceee
DEV: Further sidekiq logging stability improvements
...
- Open the log file in "append" mode. This avoids issues if the file does not exist (and matches standard rails log behavior)
- Correctly parse the interval logging environment variable
2019-03-06 12:50:15 +00:00
Tarek Khalil
0a9a11094d
FEATURE: Save ignored usernames in user preferences ( #7117 )
...
* FEATURE: Save ignored usernames in user preferences
2019-03-06 11:21:58 +00:00
Joffrey JAFFEUX
974e756369
FIX: bugs in safari where select-kit is not expanding on iOS ( #7118 )
2019-03-06 11:29:45 +01:00
David Taylor
fe62de68dd
DEV: Correct sidekiq logging to avoid thread leak
2019-03-06 10:11:31 +00:00
Tarek Khalil
b58eea1fcb
FEATURE: Hide ignored user's Original Post content ( #7113 )
...
* FEATURE: Hide ignored user's Original Post content
2019-03-06 09:20:45 +00:00
Arpit Jalan
05ebb52ec4
FEATURE: defer flags when deleting child replies ( #7111 )
2019-03-06 14:32:25 +05:30
Sam
8d7c10f7f2
FIX: allow moderators to create categories setting broken
...
Mods require visibility to everyone group cause category dialogs need to
know about this.
If the site setting `allow moderators to create categories` will not function
without this
Note there is no security expansion of rights here, the group is technically
empty anyway and it always looks exactly the same on all discourse instances
2019-03-06 17:44:18 +11:00
Kris
86f9ace0ea
UX: Previous positioning was better for the image resizer
2019-03-05 22:10:12 -05:00
Kris
b5804c410e
UX: Add slash to mobile category page totals
2019-03-05 20:16:12 -05:00
Kris
2ea77073ae
prettier
2019-03-05 15:12:10 -05:00
Kris
84892429ed
UX: Improve layout of invite table
2019-03-05 14:50:27 -05:00
Jeff Wong
b0d93a38e8
FEATURE: Add plugin html hook to insert html before any other scripts
2019-03-05 10:41:16 -08:00
David Taylor
8b30ed5b7a
DEV: Serialize the job parameters in sidekiq logs
...
Otherwise this can lead to some very large data structures when processing the logs later
2019-03-05 17:44:49 +00:00
Gerhard Schlager
671cec4bd2
DEV: Use Discourse.getURL for creating URL
...
follow-up to ccb48bef75
2019-03-05 17:52:18 +01:00
Tarek Khalil
190b19f3c2
FEATURE: Add ignored user list to the User's preference page ( #7107 )
...
* FEATURE: Add ignored user list to the User's preference page
## Why?
Part of: https://meta.discourse.org/t/ability-to-ignore-a-user/110254
We want to add list of Ignored users under or along with the muted users preferences section.
This way Users can find and update their list of ignored users.
## UI
## Open questions
Two of many options to represent a list of ignored users is that we can:
1. We can represent the ignored user list as a table with the ability to `un-ignore` but NOT to add new ignored users.
2. We can keep it functioning as the `muted user list` where you can `un-ignore` or `ignore` users.
2019-03-05 14:47:51 +00:00
Tarek Khalil
f19d36cbba
REFACTOR: Change watch wording to unignore ( #7112 )
...
* REFACTOR: Change `watch` wording to `unignore`
2019-03-05 14:40:31 +00:00
Gerhard Schlager
ccb48bef75
UX: Make Uncategorized category less confusing
...
* Adds warnings to the "Edit Category" dialog
* Doesn't hide the "Security" tab on the "Edit Category" dialog anymore. Instead, it shows an explanation why permissions can't be changed.
* Makes the category name translatable
* Hides the category name from the edit dialog (it can be customized by overriding the translation)
* Creates a translation override if the category has been renamed in the past
2019-03-05 14:42:41 +01:00
Gerhard Schlager
68e4aba369
UX: Don't concatenate title on "Edit Category" dialog
2019-03-05 14:42:41 +01:00
David Taylor
35275c137b
PERF: Remove final N+1 from theme admin page
...
The rails bug previously mentioned only causes an issue when using `pluck`, so this controller is not affected.
Followup to a8ffc02d06
2019-03-05 12:10:53 +00:00
David Taylor
8963f1af30
FEATURE: Optional detailed performance logging for Sidekiq jobs ( #7091 )
...
By default, this does nothing. Two environment variables are available:
- `DISCOURSE_LOG_SIDEKIQ`
Set to `"1"` to enable logging. This will log all completed jobs to `log/rails/sidekiq.log`, along with various db/redis/network statistics. This is useful to track down poorly performing jobs.
- `DISCOURSE_LOG_SIDEKIQ_INTERVAL`
(seconds) Check running jobs periodically, and log their current duration. They will appear in the logs with `status:pending`. This is useful to track down jobs which take a long time, then crash sidekiq before completing.
2019-03-05 11:19:11 +00:00
Kris
73e4204d20
UX: Image preview resizer style
2019-03-04 21:59:58 -05:00
Tarek Khalil
079b0f4bff
FIX: Remove ignore user feature from user-card-contents component ( #7104 )
...
Based on our discussions, we want to have the `Ignore button will ONLY be on the User’s profile page`.
2019-03-04 15:21:45 +00:00
Arpit Jalan
ad5f5b931d
DEV: deprecate blank files for static modal pages
2019-03-04 15:05:33 +05:30
Joffrey JAFFEUX
2e881adb6e
FIX: select-kit perf and positioning improvements ( #7093 )
2019-03-04 10:30:22 +01:00
Joffrey JAFFEUX
dc4001370c
FEATURE: displays groups in menu search ( #7090 )
2019-03-04 10:30:09 +01:00
Joffrey JAFFEUX
075b264338
DEV: replaces DOMNodeInserted by the better MutationObserver ( #6884 )
2019-03-04 10:28:59 +01:00
Arpit Jalan
824d9402a4
FIX: pending counts were not shown on invites tab
2019-03-04 14:14:13 +05:30
Maja Komel
fea5d4f3ec
FIX: any subcategory permissions are valid if everyone has access to parent category ( #7097 )
2019-03-04 14:49:26 +11:00
Joffrey JAFFEUX
bb39a6f7d7
REFACTOR: topic-list-header-column ( #7099 )
2019-03-04 14:45:52 +11:00
Arpit Jalan
01e2180548
FIX: /signup and /password-reset direct links were broken
2019-03-04 09:02:22 +05:30
Jeff Atwood
9585e2dff2
change separator from | to • for editor image sizing
2019-03-03 17:55:21 -08:00
Gerhard Schlager
14f9e55977
FIX: Error when filtering site settings
...
Happened only when none of the logo settings had an image assigned.
2019-03-03 20:43:22 +01:00
Dan Ungureanu
fd9671f7fe
DEV: Minor code improvements.
2019-03-02 19:07:54 +02:00
Sam
03a70ef69c
FIX: allow underscore and dash in username search
...
_ and - are technically punctuations, but we allow them in usernames so
accept them in search
2019-03-01 15:23:45 +11:00
Sam
cdf34657f6
FEATURE: focus on composer TEXTAREA when iPad has a physical keyboard
...
This disables a bunch of hacks that bypassed "focus" on iOS (cause focus
events that involve a virtual keyboard on iOS cause browser havoc unless
a physical keyboard is attached)
Also will focus on title on new topic
2019-03-01 11:31:52 +11:00
Dan Ungureanu
6bc8382555
FEATURE: Use smooth scrolling for J/K keyboard shortcuts. ( #7084 )
2019-03-01 09:31:40 +11:00
Vinoth Kannan
be436066ff
FIX: Prevent default event and stop bubbling up when card popup is closed in mobile
2019-03-01 01:42:17 +05:30
Penar Musaraj
64a3d63ddc
DEV: Rename some icons with deprecated names
2019-02-28 13:03:14 -05:00
Maja Komel
612a0be085
FIX: don't add bottom padding for avatars in composer preview
2019-02-28 18:03:38 +01:00
David Taylor
e67474daf4
UX: Don't link to theme source unless it's http(s)
2019-02-28 17:01:59 +00:00
Joffrey JAFFEUX
1cd64f68f1
FIX: staff/admin shouldn’t be able to create uncategorized topics ( #7077 )
2019-02-28 15:51:13 +01:00
David Taylor
3517103398
UX: Correct locale key for theme compatibility error
2019-02-28 14:40:33 +00:00
Arpit Jalan
c02956e29c
FIX: when posts are moved to a message then small action post should not be publicly visible ( #7085 )
...
This fix is inspired from what we do in discourse-assigned plugin.
https://github.com/discourse/discourse-assign/blob/master/lib/topic_assigner.rb#L184
https://github.com/discourse/discourse-assign/blob/master/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6#L125-L133
2019-02-28 19:49:26 +05:30
Maja Komel
bb5119b88f
FIX: only profile owner can see links to watched/tracked/muted topics ( #7083 )
2019-02-28 14:58:49 +01:00
Joffrey JAFFEUX
883a18547e
FIX: shows invite panel on mobile from topic footer buttons ( #7080 )
2019-02-28 14:56:22 +01:00
David Taylor
6296554ed1
DEV: Add additional hook for theme-creator
2019-02-28 10:48:30 +00:00
Vinoth Kannan
0cc636f648
UX: Don't add padding bottom for emojis in composer preview
2019-02-28 15:53:21 +05:30
Maja Komel
97c0fd0909
FIX: styling for resizable image wrapper in editor preview
2019-02-28 10:24:43 +01:00
Sam
06abecdb41
FEATURE: on iPad bluetooth keyboard use ALT-ENTER for post submit
...
Command and Control can not be properly detected via JavaScript so lean on
Alt that can be detected.
2019-02-28 16:41:31 +11:00
Sam
0b86a99c39
FEATURE: allow iPad users to specify they have a physical keyboard
...
Sadly there is no clean way of detecting a keyboard is connected to an iPad
If the keyboard is connected we want to disable all the touch related hacks
on iOS
This allows iPad users to specify they have a keyboard connected. Setting
is per device.
2019-02-28 15:59:44 +11:00
Kris
cafbb3aea7
UX: Use official Facebook logo
2019-02-27 09:52:06 -05:00
Tarek Khalil
986cc8a0fb
FEATURE: Introduce Ignore user ( #7072 )
2019-02-27 14:49:07 +01:00
Joffrey JAFFEUX
5c476f639c
REFACTOR: user-invited-show ( #7078 )
2019-02-27 12:59:57 +01:00
Joffrey JAFFEUX
8ff3fc20a6
REFACTOR: tags-show ( #7079 )
2019-02-27 12:59:39 +01:00
Maja Komel
7d2ea2d4dd
FEATURE: image resizing discoverability ( #6804 )
2019-02-27 11:46:16 +01:00
Dan Ungureanu
f68a7a16a4
FIX: Use field name to name files in theme export. ( #7009 )
2019-02-27 10:45:22 +01:00
Maja Komel
6f427589b2
FIX: make it possible to use backup code everywhere where 2FA required ( #7010 )
2019-02-27 10:37:33 +01:00
Erick Guan
e1d1073273
FIX: use * when apply italics in the editor instead of _ ( #7063 )
2019-02-27 10:36:14 +01:00
Régis Hanol
326d892f5e
Aadd 'secondary_emails' field in users export
...
FIX: escape_comma wasn't working in CSV exports
FIX: group_names field wasn't properly serialized
2019-02-27 10:12:20 +01:00
Kris
ef9b249cd2
UX: More consistent table header styles, removing duplicate styles
2019-02-26 21:40:17 -05:00
Kris
1d4e9b08ad
UX: Don't override unset flair color
2019-02-26 12:49:54 -05:00
Vinoth Kannan
59c66fd226
REFACTOR: Improve the readability of code ( #7076 )
2019-02-26 23:03:49 +05:30
Joffrey JAFFEUX
fbedaea5ed
FIX: prevents double network calls and other quirks on admin emails ( #7074 )
2019-02-26 17:53:52 +01:00
Davide Porrovecchio
75aaae5d5c
FEATURE: Allow wildcard in allowed_user_api_auth_redirects setting ( #6779 )
2019-02-26 17:03:20 +01:00
Joffrey JAFFEUX
8c706b0ff7
fix tests ( #7073 )
2019-02-26 16:49:29 +01:00
Joffrey JAFFEUX
2a8da03951
FIX: prevents autocomplete from going over search input ( #7075 )
2019-02-26 15:48:02 +01:00
David Taylor
a8ffc02d06
PERF: Reduce N+1s on theme admin page
2019-02-26 14:22:02 +00:00
Joffrey JAFFEUX
d04c4bf8e7
UX: puts back share-panel as floating pane on post actions ( #7066 )
2019-02-26 14:15:25 +01:00
Arpit Jalan
6ea9f5c9c5
FIX: do not update tag name on /tags/intersection
2019-02-26 16:43:39 +05:30
Joffrey JAFFEUX
1cee8a86f6
fix prettier ( #7071 )
2019-02-26 11:24:02 +01:00
Joffrey JAFFEUX
7ccb0b882f
FIX: ensures topic’s category allows topics tags ( #7060 )
2019-02-26 11:21:55 +01:00
Joffrey JAFFEUX
a206c7f5d5
FIX: attempts to fix an error with EXTEND_PROTOTYPES ( #7067 )
2019-02-26 11:04:05 +01:00
Joffrey JAFFEUX
71360436ff
FIX: users list show was loading multiple times with different params ( #7058 )
...
A first load was happening in route, which was setting properties on controller. These properties were observed on the controller and were triggering a reload of the AdminUser model.
Not only was it doing loading two times it was also sometimes resulting on the controller model refresh end to happen after route has been changed, resulting in a wrong model.
2019-02-26 10:43:24 +01:00
Vinoth Kannan
ed0120171c
FIX: Hide 'show associated accounts' button if moderators can't see emails
...
And minor prettier code alignments
2019-02-26 13:49:27 +05:30
Simon Cossar
c742d42031
FIX: rtl topic progress wrapper position ( #7070 )
...
* Set left/right topic-progress-wrapper CSS from text-direction
* Remove unnecessary CSS rule
2019-02-25 20:56:52 -05:00
Kris
d6875a77fb
UX: Apply new-user color to full name and username
2019-02-25 17:09:41 -05:00
Kris
34d0cc6ad5
UX: Better alignment of similar topics in composer
2019-02-25 17:04:11 -05:00
Osama Sayegh
d5efe2d7ee
UX: make composer resize work on touch devices ( #7068 )
...
* UX: make composer resize work on touch devices
This also replaces a vendor dependency with a small built-in resize mechanism.
* Make blue bar's larger padding specific to touch devices
2019-02-26 08:04:14 +11:00
Robin Ward
90c09d17b6
FIX: Heisentest - don't memoize on a class variable
...
Repeated usage of the same class will have the same memoized results
even if the data has changed.
2019-02-25 14:49:01 -05:00
Gerhard Schlager
dc961fecb9
FIX: Outgoing emails were not disabled after restoring backup
2019-02-25 16:07:24 +01:00
Joffrey JAFFEUX
5952a6c0ad
DEV: uses find() helper instead of this.$() in js tests ( #7062 )
2019-02-25 16:04:55 +01:00
Joffrey JAFFEUX
c0dd171cf1
REFACTOR: bread-crumbs ( #7064 )
2019-02-25 14:51:14 +01:00
Joffrey JAFFEUX
6930706830
REFACTOR: new message route ( #7061 )
2019-02-25 14:01:00 +01:00
Arpit Jalan
91e771ece6
FIX: send test email doesn't show a status
2019-02-25 17:42:58 +05:30
Joffrey JAFFEUX
900e187627
DEV: removing blank files ( #7057 )
2019-02-25 09:52:44 +01:00
Joffrey JAFFEUX
919839fd97
FIX: allows {{d-button}} to set a form attribute ( #7056 )
...
This attribute is used when a submit button is out of a form. It makes it explicit which form this button is submitting.
It's currently used in our login modal form.
2019-02-25 09:49:49 +01:00
Kris
2d031a1beb
UX: Improve moderator icon alignment
2019-02-22 21:29:39 -05:00
Joffrey JAFFEUX
87f4ee13ef
UX: puts more emphasis on the shared url on share panel ( #7055 )
2019-02-22 23:22:11 +01:00
David Taylor
260398d706
FIX: Live refresh parent themes when editing child themes
2019-02-22 21:13:07 +00:00
Jeff Wong
8be7878656
FEATURE: add ability to clear previously set mobile_view with mobile_view=auto
2019-02-22 10:44:49 -08:00
Joffrey JAFFEUX
8aca26cce3
FIX: allows right-click on post-date sharing link ( #7054 )
2019-02-22 15:18:05 +01:00
Vinoth Kannan
d1bad881ea
FEATURE: Allow moderators to change topic timestamps ( #7053 )
2019-02-22 14:33:52 +05:30
Kris
87b5003453
UX: Increase width of hamburger menu to 320px
2019-02-21 21:52:21 -05:00
Kris
f44ef82b53
UX: Better wrapping of group header elements
2019-02-21 21:42:39 -05:00
Sam
667d3a3fd6
PERF: include content-length header for CDN
...
Attempt to force NGINX to include content length when doing X-SendFile
This does not seem to be required when bypassing NGINX.
Without this header some CDNs may have issues caching
2019-02-22 11:21:07 +11:00
Sam
31d41f532e
PERF: do not include suggested topics when loading new posts
...
When a new post is triggered via message bus post stream will attempt to load
it, previously the `/topic/TOPIC_ID/posts.json` would unconditionally include
suggested topics, this caused excessive load on the server.
New pattern defaults to exclude suggested and related topics from this API
unless people explicitly ask for suggested.
2019-02-22 10:37:18 +11:00
Penar Musaraj
74ed72e825
DEV: Remove d-checkbox component
...
Replaces the last occurrence of `d-checkbox` with a regular input element.
Includes a minor refactor of admin site text search.
2019-02-21 09:54:54 -05:00
Guo Xiang Tan
1dee71d760
UX: Disabled lightbox expand button when loading image meta.
2019-02-21 22:30:57 +08:00
Gerhard Schlager
f8e498f6ad
DEV: Fix random build error
2019-02-21 14:53:29 +01:00
Joffrey JAFFEUX
090acb5b11
FIX: s/isMessage/isPM ( #7048 )
...
Regression due to refactoring
2019-02-21 13:53:50 +01:00
Joffrey JAFFEUX
8d779db270
FIX: allows invite modal from topic-map post-actions ( #7047 )
2019-02-21 13:48:03 +01:00
Guo Xiang Tan
46e62c0d22
UX: Default user facing routes to /g instead of /groups. ( #7042 )
2019-02-21 13:44:25 +08:00
Sam
07b856700d
REFACTOR: remove disallowEmails option from user-selector
...
Negative option was leading to a fair amount of confusion, going forward
if we want to allow selection of emails from user selector it must be
supplied with `allowEmails=true`
This corrects a regression in 1f4ace4f
2019-02-21 16:37:26 +11:00
Sam
79841cf7dd
FEATURE: add missing autocomplete suppressions
...
Following 1f4ace4f
2019-02-21 16:37:26 +11:00
Guo Xiang Tan
d3cd314a98
Make eslint happy.
2019-02-21 10:26:56 +08:00
Guo Xiang Tan
58b0e945bd
UX: Lightbox support for image uploader. ( #7034 )
2019-02-21 10:13:37 +08:00
Régis Hanol
e3a23116d2
FIX: don't update gravatar if the user has no email
2019-02-20 22:34:43 +01:00
Penar Musaraj
cc1f9e7be6
Fix share button in post menu
2019-02-20 16:27:59 -05:00
Joffrey JAFFEUX
353eeef72a
fix prettier offense ( #7041 )
2019-02-20 22:22:38 +01:00
Penar Musaraj
cafe637407
UX: List popular themes and components in admin panel ( #6997 )
...
Reorganizes theme create/upload flows into one install flow
Adds quick list of popular themes/components with one-click installation
2019-02-20 14:58:31 -05:00
Penar Musaraj
4955ab1689
DEV: add replaceTagRenderer to pluginApi
2019-02-20 14:52:56 -05:00
Joffrey JAFFEUX
18296b4211
FIX: more reliable native sharing ( #7039 )
2019-02-20 20:43:48 +01:00
Joffrey JAFFEUX
9618300d69
s/share/nativeShare ( #7038 )
2019-02-20 20:03:30 +01:00
Joffrey JAFFEUX
994a09e5e8
FIX: stricter window.navigator.share check ( #7037 )
2019-02-20 19:40:51 +01:00
Joffrey JAFFEUX
2e0342dba7
UX: more spacing between social links ( #7036 )
2019-02-20 19:37:08 +01:00
Joffrey JAFFEUX
28c24631b8
FIX: ensures panel's shareUrl is not erased by topic's shareUrl ( #7035 )
2019-02-20 19:33:54 +01:00
Gerhard Schlager
66901f67f6
UX: Moderator post wasn't completely translatable
2019-02-20 16:37:47 +01:00
Joffrey JAFFEUX
04a63cfaaa
[WIP] FEATURE: merge share and invite actions together ( #7021 )
...
This commit also:
- removes [+ New Topic] behaviour from share, this feature has been duplicated in composer actions, months ago
- introduces our new experimental spacing standard for css: eg: `s(2)`
- introduces a new panel UI for modals
2019-02-20 15:42:44 +01:00
Gerhard Schlager
6a8007e5fb
FEATURE: Improve handling of backup storage errors
2019-02-20 15:16:49 +01:00
Sam
33269c4172
FEATURE: do no search for groups unless a term is specified
...
Do not allow `/u/search/users.json` to list any group matches unless a
specific `term` is specified in the API call.
Adding groups should always be done when an actual search term exists,
blank search is only supported for users within a topic
2019-02-20 17:28:22 +11:00
Guo Xiang Tan
31ffa5f64e
UX: Allow users to see filename in image-uploader component. ( #7022 )
...
https://meta.discourse.org/t/downsides-of-the-new-logo-ui-in-site-settings/102247/23?u=tgxworld
2019-02-20 13:55:55 +08:00
Sam
1f4ace4f56
FEATURE: autocomplete usernames early in topic based on participation
...
Following this change when a user hits `@` and is replying to a topic they
will see usernames of people who were last seen and participated in the topic
This is somewhat experimental, we may tweak this, or make it optional.
Also, a regression in a423a938
2019-02-20 13:34:43 +11:00
Sam
918a0ea3a4
FIX: use autocomplete="discourse" to disable Chrome address autofill
...
https://stackoverflow.com/a/47822599/17174
Chrome 63 and up start ignoring `autofill="off"`
Per: https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164
> The tricky part here is that somewhere along the journey of the web autocomplete=off become a default for many form fields, without any real thought being given as to whether or not that was good for users. This doesn't mean there aren't very valid cases where you don't want the browser autofilling data (e.g. on CRM systems), but by and large, we see those as the minority cases. And as a result, we started ignoring autocomplete=off for Chrome Autofill data
So to work around this decision we now explicitly say: autocomplete="discourse"
when we don't want Chrome to randomly fill in addressed (aka. always)
2019-02-20 10:15:59 +11:00
Jeff Wong
246997dbd9
FIX: an <a> with a target of _blank wants a new window
2019-02-19 14:44:30 -08:00
David Taylor
49e7073438
FIX: Hide advanced theme fields behind a flag, pending UI improvement
2019-02-19 22:25:00 +00:00
David Taylor
d08939ab05
FIX: Should be possible to save an empty theme_field in the editor
...
Removing the theme_field JS object when the value was empty caused the server to maintain the previous value, making it impossible to delete the content of a field.
2019-02-19 21:49:31 +00:00
Gerhard Schlager
5d75bd4831
FIX: Don't try to rename group when username is taken
...
FIX: Always rename groups with the default locale instead of using the user's locale
2019-02-19 22:31:03 +01:00
David Taylor
dbcf05d62c
DEV: Code style improvements following review
...
Followup to 05ee1d1aba
2019-02-19 20:02:29 +00:00
David Taylor
7878e5007a
FIX: Refactor to prevent themes affecting core stylesheets ( #7029 )
...
If a theme setting contained invalid SCSS, it would cause an error 500 on the site, with no way to recover. This commit stops loading theme settings in the core stylesheets, and instead only loads the color scheme variables. This change also makes `common/foundation/variables.scss` available to themes without an explicit import.
2019-02-19 15:55:59 +00:00
Joffrey JAFFEUX
9ade04b709
FIX: removes legacy browsers-refresh button ( #7028 )
2019-02-19 16:38:21 +01:00
Gerhard Schlager
84c56e16f9
REFACTOR: Use keyword argument for fallback_to_english flag
2019-02-19 15:28:47 +01:00
David Taylor
05ee1d1aba
FEATURE: Added settings/translations support to theme editor UI ( #7026 )
...
- These advanced fields are hidden behind an 'advanced' button, so will not affect normal use
- The editor has been refactored into a component, and styling cleaned up so menu items do not overlap on small screens
- Styling has been added to indicate which fields are in use for a theme
- Icons have been added to identify which fields have errors
2019-02-19 12:56:01 +00:00
Joffrey JAFFEUX
0616837a5d
UX: moves wizard's "Finish" button to the left of back and next ( #7027 )
...
This was done to avoid clicking finish when clicking fast on next.
2019-02-19 13:32:01 +01:00
Joffrey JAFFEUX
8a4cd15e46
REFACTOR: topic model ( #7020 )
2019-02-19 10:13:46 +01:00
Joffrey JAFFEUX
15fd875855
REFACTOR: color-scheme-color model ( #7019 )
2019-02-19 09:31:26 +01:00
Joffrey JAFFEUX
cba0dd33ee
REFACTOR: admin-customize-color ( #7018 )
2019-02-19 09:31:11 +01:00
Joffrey JAFFEUX
2c6bf184bc
REFACTOR: admin-badge-preview ( #7017 )
2019-02-19 09:30:52 +01:00
Joffrey JAFFEUX
3bf61fca66
REFACTOR: admin-user-field-item ( #7016 )
2019-02-19 09:30:38 +01:00
Joffrey JAFFEUX
ee692414ce
REFACTORING: admin-edit-badge-groupings ( #7015 )
2019-02-19 09:30:24 +01:00
Vinoth Kannan
27e7f2bee0
DEV: call 'enqueue_hooks' method only if active webhooks exist
2019-02-19 12:43:08 +05:30
Vinoth Kannan
f2c3415548
FIX: Should not generate payload until active webhooks are exist
2019-02-19 12:23:42 +05:30
Kris
4f5aebc338
UX: reduce subcategory badge spacing
2019-02-18 19:04:36 -05:00
Arpit Jalan
50f833def0
fix the build
...
JsPrettier on Sublime was failing because: https://github.com/jonlabelle/SublimeJsPrettier/issues/157#issuecomment-458175837
2019-02-18 11:52:11 +05:30
Arpit Jalan
dc2776bcdd
FIX: do not show "move to new PM" option to moderators
2019-02-18 11:35:00 +05:30
Jeff Atwood
052eaed16a
lighten embed blockquote style for consistency
2019-02-17 21:00:46 -08:00
Jeff Atwood
dfba36fdca
remove bgcolor from embed quotes for consistency
2019-02-17 20:57:27 -08:00
Guo Xiang Tan
7da7a30e02
PERF: Restore exists? in favor of blank?.
...
Regression from dcd7b92532
2019-02-18 10:04:21 +08:00
David Taylor
f04471e422
REFACTOR: Proxy letter avatars in rails instead of nginx
...
Co-authored-by: Sam Saffron <sam.saffron@gmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
This gives more control over the request. In particular we can easily
lookup DNS dynamically, instead of only upon NGINX startup.
Previously, NGINX was looking up IP for the letter avatar service and
caching the CDN IP address, this caused issues if CDN changed IP, in
which letter avatars would be broken till a container restarted.
NGINX config has been updated to add caching. This change will require
a container rebuild.
The proxy will now function in development environments, so the patch
for `letter_avatar_proxy` has been removed.
2019-02-18 08:46:56 +11:00
Gerhard Schlager
b0862bd15d
FIX: Push notifications could fail with UnauthorizedRegistration
...
The webpush gem by default sets the expiration date of the JWT token to exactly 24 hours in the future. That's not really needed because the token isn't reused. And it might cause UnauthorizedRegistration if the server's clock isn't 100% correct, because the maximum allowed value is 24 hours.
2019-02-15 21:12:09 +01:00
Gerhard Schlager
17f1a76570
FIX: Delete push subscription on MismatchSenderId error
...
This should prevent repeated MismatchSenderId warnings when the VAPID keys have changed.
2019-02-15 21:12:09 +01:00
peterlamber
159dd69fcb
UX: make adding permissions more visible and intuitive to click. ( #6999 )
2019-02-15 12:01:10 -05:00
Arpit Jalan
99c6db21e6
FEATURE: allow blocking emojis ( #7011 )
...
https://meta.discourse.org/t/blocking-emojis-wont-work/105853
2019-02-15 20:55:48 +05:30
Dan Ungureanu
a423a9383f
FIX: Stop autocomplete for invalid usernames. ( #7005 )
2019-02-15 11:29:26 +11:00
Sam
f8b70f4ca3
FIX: unable to create new categories
...
Previous attempt at 70adb940
2019-02-15 10:24:29 +11:00
Kris
3d11064a33
UX: Reduce font size on about pages
2019-02-14 11:01:17 -05:00
Bianca Nenciu
70adb94008
SECURITY: Do not leak private group names. ( #7008 )
2019-02-14 15:35:58 +01:00
Régis Hanol
fc14847c14
PERF: only require aws-sdk-sns gem when it's being used
2019-02-14 11:08:21 +01:00
Sam
ebd4140492
FIX: logspam due to 404s on CSS files
...
We had a missing formats: string on our render partial that caused logs to
spam when CSS files got 404s.
Due to magic discourse_public_exceptions.rb was actually returning the
correct 404 cause it switched format when rendering the error.
2019-02-14 17:58:16 +11:00
Maja Komel
39522659a6
FIX: validate parent category/subcategories permissions
...
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details
This ensures users with access to child category can always at least see parent
2019-02-14 16:38:52 +11:00
Penar Musaraj
090e9c8432
FIX: make composer full screen shortcut work when inputs have focus ( #6907 )
...
- Uses a Mousetrap plugin for global shortcuts
- Implemented for search `ctrl+alt+f` and composer fullscreen `shift+f11` shortcuts
2019-02-14 00:19:27 -05:00
Saurabh Patel
ed6f4dfc40
FEATURE: trigger user profile create and update event ( #6958 )
...
Adds `user_profile_created` DiscourseEvent on profile creation and `user_profile_updated` on profile update
2019-02-14 15:45:12 +11:00
Arpit Jalan
b651605d6e
FIX: tags added while editing a pending approval topic do not show up ( #6959 )
2019-02-14 15:42:40 +11:00
Kris
37666c3d18
UX: Signup form labels were too constrained, minor cleanup
2019-02-13 21:07:34 -05:00
Vinoth Kannan
484bd82278
FIX: Add onceoff job to remove double quotes from s3 etags
2019-02-14 05:19:41 +05:30
Régis Hanol
0476169692
make prettier happy
2019-02-13 22:16:38 +01:00
Régis Hanol
94fe0af900
FIX: upload emojis sequentially to prevent rate limit
2019-02-13 22:07:37 +01:00
Régis Hanol
4d674acc25
FEATURE: AWS SNS bounce notifications webhooks
2019-02-13 21:26:40 +01:00
Joffrey JAFFEUX
560cc4e73e
FIX: sets categoryId but do not scope when replying as new topic ( #7002 )
2019-02-13 15:19:58 +01:00
Joffrey JAFFEUX
fe4254b8f3
FIX: reverse consolidated pageviews stacked chart order ( #7001 )
2019-02-13 12:24:18 +01:00
Sam
641b079c78
FIX: add support for missing verbs in user api key
...
Previously "write" scope was missing put and delete verbs which should be
allowed.
Also closes : #6982
2019-02-13 15:49:43 +11:00
Jeff Wong
1328a127ee
FIX: translate bootbox confirmation dialog ( #6981 )
2019-02-13 14:04:56 +11:00
Jeff Wong
467cfc9e08
FIX: remove extra periods ( #6998 )
...
Periods are belong in the translation files not in our templates, if we have them in the templates sentences can not be localized properly.
2019-02-13 12:54:34 +11:00
Joffrey JAFFEUX
47fe34d794
FEATURE: makes create-account userfields using dropdowns accessible ( #6991 )
2019-02-13 12:52:55 +11:00
Kris
3da35081e5
UX: Embedded post collapse button hover color fix
2019-02-12 17:21:33 -05:00
Robin Ward
c23411cc69
FIX: Heisentest - suspicious logins report was not ordered by date
...
The specs needed an order even though none was supplied.
2019-02-12 13:17:29 -05:00
David Taylor
86fe423f5e
FIX: Clear the cache after destroying theme_fields
2019-02-12 16:39:40 +00:00
David Taylor
91f0468f4e
FIX: Allow unbaked theme fields to be destroyed
...
The after_commit hook was attempting to re-bake theme_fields after they were destroyed, which caused an exception to be thrown
2019-02-12 16:14:43 +00:00
David Taylor
59640ef373
DEV: Add additional hooks for theme-creator plugin
2019-02-12 14:17:34 +00:00
Régis Hanol
b8b1759de9
UX: show envelope when tag is only used in PM
...
UX: use regular envelope instead of solid envelope
REFACTOR: %s/enveloppe/envelope/g
2019-02-12 11:34:25 +01:00
Dan Ungureanu
90ce448675
PERF: Cache build_not_found_page
2019-02-12 21:20:33 +11:00
Jeff Wong
d997b01a24
FIX: Scale down swipe in detection to 20px from edge of the screen
...
...and slightly increase velocity required for menu actions
2019-02-11 21:22:50 -08:00
Jeff Wong
c3cbff55be
FIX: only respond to menu open swipes on Andorid
2019-02-11 20:56:25 -08:00
Vinoth Kannan
e0c16d3a8a
minor refactoring to improve code readability
2019-02-11 17:24:02 +05:30
Arpit Jalan
dcd7b92532
FIX: some posters were not getting added to topic_allowed_users when moving posts to a new PM
...
If a user posted twice in a topic then subsequent posters were not getting added as topic_allowed_users.
2019-02-11 17:05:21 +05:30
Vinoth Kannan
2c12336c6b
FIX: Display post updated date in non-JS view for crawler
2019-02-11 16:48:22 +05:30
Penar Musaraj
c50db76f5d
FIX: do not treat TIFF, BMP, WEBP as images
...
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.
You can still upload these files they will simply not be displayed in IMG tags.
2019-02-11 16:28:43 +11:00
Robin Ward
c719658f9f
human? helper method on a user
...
This is cleaner than hard coding `id > 0` in ruby code.
2019-02-08 13:34:54 -05:00
David Taylor
60fa4fe692
DEV: Make interface route/controller more resilient to missing values
2019-02-08 16:54:15 +00:00
Kris
0d1fa54957
compensate for border overhang in category list alignment
2019-02-08 11:49:06 -05:00
Robin Ward
72b5ab0454
Don't wrap exceptions in test mode unless specifically requested.
...
This helps debugging reports with invalid SQL, which would otherwise
return no results instead of a useful error message while running
tests.
2019-02-08 11:26:26 -05:00
Kris
7c55de6e6f
UX: Alignment fix for names with emoji
2019-02-08 11:07:04 -05:00
David Taylor
747fea8458
DEV: Remove unused import
2019-02-08 16:05:39 +00:00
David Taylor
95eb4c67f2
FIX: Allow reverting theme/text settings from cookie back to default
2019-02-08 15:39:44 +00:00
Penar Musaraj
62043e6904
UX: Hide branch/private repo options in admin theme import modal
2019-02-08 10:17:29 -05:00
Régis Hanol
7aecd3c2f5
Update app/services/user_silencer.rb
...
Co-Authored-By: eviltrout <robin.ward@gmail.com>
2019-02-08 08:50:50 -05:00
Robin Ward
bc3efab816
FIX: When disagreeing with a flag that silenced a user, unsilence them
...
Previously it would unhide their post but leave them silenced.
This fix also cleans up some of the helper classes to make it easier
to pass extra data to the silencing code (for example, a link to the
post that caused the user to be silenced.)
This patch also refactors the auto_silence specs to avoid using
stubs.
2019-02-08 08:50:50 -05:00
Joffrey JAFFEUX
44d9bc12c9
FEATURE: color-palettes component ( #6992 )
2019-02-08 14:01:14 +01:00
David Taylor
babd80dfd1
FIX: Allow subexpressions in raw handlebars helpers
...
Helpers registered via `registerUnbound` did not receive parameters if they were subexpressions.
For example: `{{helper1 key=(helper2 value)}}`
2019-02-08 12:58:10 +00:00
David Taylor
95b5c5898e
FIX: Prevent duplicate params for raw template theme handlebars helpers
2019-02-08 12:54:00 +00:00
Joffrey JAFFEUX
e3324737ee
FIX: position invite footer button before archive ( #6990 )
2019-02-08 12:21:51 +01:00
Gerhard Schlager
e9ec5238fc
DEV: Remove ignored columns
2019-02-08 12:12:38 +01:00
Joffrey JAFFEUX
8a152566e3
FIX: improves positioning of footer buttons on mobile ( #6989 )
2019-02-08 12:09:56 +01:00
Joffrey JAFFEUX
e54612c914
fix tests ( #6987 )
2019-02-08 11:38:15 +01:00
Kris
f849169619
UX: Modifications to admin/customize layout
2019-02-07 22:27:35 -05:00
Gerhard Schlager
cbedb6a1ac
FEATURE: Hidden site setting to always include topic excerpt
2019-02-07 22:45:21 +01:00
Penar Musaraj
2a007bafa2
FEAT: Allow image resize by width or height
...
`|150x` resizes to 150px wide + auto-height. `x150` resizes to 150px tall and auto-width.
Resize value can be from 1 to 999 (incl. for percentages).
2019-02-07 15:04:39 -05:00
Joffrey JAFFEUX
c0ccf21970
FIX: hides topic-footer-mobile-dropdown when no content ( #6985 )
2019-02-07 18:37:20 +01:00
Joffrey JAFFEUX
6c195640b9
FEATURE: adds an API to register topic footer buttons
2019-02-07 14:43:33 +01:00
Joffrey JAFFEUX
92c52c0724
FEATURE: displays report description when hovering activity metrics ( #6983 )
2019-02-07 13:33:05 +01:00
Kris
1cacfddda4
Prevent usercard badge section from overflowing
2019-02-06 22:39:10 -05:00
Kris
984f1d96b0
Add max-width so long badges don't force short badges to truncate
2019-02-06 20:51:54 -05:00
Kris
94f8c4ecac
UX: Truncate (don't wrap) badges in user cards if the text is long
2019-02-06 20:18:12 -05:00
Dan Ungureanu
fc4c015bee
FEATURE: Shortcut 'g s' goes to first suggested topic
2019-02-07 08:43:07 +11:00
Kris
56a9f777cb
UX: Turn off autocomplete on composer title
2019-02-06 14:37:29 -05:00
Arpit Jalan
ab2c2ea605
FIX: validate Invite email against EmailValidator.email_regex ( #6975 )
2019-02-06 22:38:06 +05:30
Robin Ward
ca03b2ff30
Move SCSS variables for topic post width
...
This allows them to be re-used by other components, for example the
upcoming review queue.
2019-02-06 11:37:59 -05:00
Régis Hanol
057d1dc077
UX: disable browser's autocomplete in search menu
2019-02-06 17:06:23 +01:00
David Taylor
f3cfce4a93
FEATURE: Calculate sprite-sheet based on currently active themes ( #6973 )
...
Previously there was only one sprite sheet, which always included icons from all themes even if they were disabled
2019-02-06 15:51:23 +00:00
Arpit Jalan
381793243e
FIX: include error message if the "accept invite" process fails
2019-02-06 19:20:25 +05:30
Kris
1a72242746
line-height adjustment
2019-02-05 21:44:06 -05:00
Kris
a52b2c9625
UX: Moving the create theme buttons, adding buttons to theme index
2019-02-05 21:40:17 -05:00
Vinoth Kannan
e7821a63e7
FIX: Users should able check the emails for self
2019-02-05 23:31:19 +05:30
Gerhard Schlager
ba724d7f25
FIX: S3 endpoint broke bucket creation in non-default region
2019-02-05 18:17:02 +01:00
David Taylor
a3b47c1dd1
FEATURE: Allow string theme settings to display with multiple lines
...
To use, add `textarea: true` to the theme settings.yml. For example:
```
my_setting:
default: "some string"
textarea: true
```
2019-02-05 14:14:53 +00:00
David Taylor
7b7bc3db39
FIX: Rescue and display import errors when updating theme via git
2019-02-05 13:49:16 +00:00
Dan Ungureanu
31ffcf989c
UX: Use translatedLabel for aria-label in buttons.
2019-02-05 13:11:07 +02:00
Dan Ungureanu
2c222e16fe
FEATURE: Returning falsy value from upload handler stops upload. ( #6969 )
2019-02-05 10:54:11 +01:00
Kris
b6e3ef4a90
Minor icon color fix
2019-02-04 22:14:18 -05:00
Kris
58d5fc3632
UX: Minor button icon color fixes
2019-02-04 12:46:12 -05:00
Jeff Wong
9de906ddab
FIX: Register pan events for touch only
...
* touch events - only register touch, not pointer events
* immediately request redraw frame, do not wait for after render to fire.
2019-02-04 08:27:40 -08:00
Bianca Nenciu
e0e91fad87
FIX: Fix delete button for Tag Groups. ( #6965 )
2019-02-04 12:46:39 +01:00
Kris
2a2be093ca
UX: checkboxes were too close to other inputs
2019-02-01 21:07:57 -05:00
Robin Ward
e75b240390
FIX: Some brittle tests with hardcoded ids
...
If we're going to use hardcoded ids, we should make sure the records are
not saved, or that the ID will not come up during normal use.
2019-02-01 11:44:37 -05:00
Kris
37c28cf0b7
UX: Header icon color fix
2019-02-01 09:51:12 -05:00
David Taylor
eb617dea4b
DEV: Run prettier on report.js.es6
...
The prettier version I was running was different to the CI pipeline
2019-02-01 13:22:31 +00:00
David Taylor
5c9426be48
SECURITY: Escape HTML in dashboard report tables
2019-02-01 13:10:59 +00:00
David Taylor
925606f8b1
FIX: Login button icons should be white
2019-02-01 11:01:59 +00:00
Vinoth Kannan
b4f713ca52
FEATURE: Use amazon s3 inventory to manage upload stats ( #6867 )
2019-02-01 10:10:48 +05:30
Kris
bbaa3e9166
Header icon focus color fix
2019-01-31 19:31:09 -05:00
Kris
95e16ab0a6
UX: Badge checkmarks should be round
2019-01-31 15:27:46 -05:00
Kris
6141290399
FIX: Mobile button colors
2019-01-31 15:13:54 -05:00
Gerhard Schlager
ec7f418a22
REFACTOR: Simplify finding the opengraph image
...
* removes deprecation warnings for "logo url"
* adds the "large icon" as fallback before the "apple touch icon"
2019-01-31 20:46:15 +01:00
Penar Musaraj
3500acf2f6
FIX: refresh admin/customize/themes route after import
...
Fixes an issue where the imported color schemes of a theme were not available immediately in the UI.
2019-01-31 14:29:09 -05:00
Kris
0dfcbdeb54
ok/cancel button fix
2019-01-31 14:20:27 -05:00
Kris
3d394a6144
prettier
2019-01-31 14:06:32 -05:00
Kris
3eb000a968
UX: Overflow hidden was causing some icons to be cropped
2019-01-31 14:03:11 -05:00
Kris
94f16ba931
UX: Make button icons use lighter color instead of opacity
2019-01-31 13:59:49 -05:00
David Taylor
43f3bf71ba
FIX: Imported themes should set their color scheme automatically
2019-01-31 17:45:11 +00:00
Régis Hanol
1021a42b22
FIX: new mailgun webhooks
2019-01-31 17:52:33 +01:00
Arpit Jalan
4786b7ff81
FEATURE: when only option is "existing topic", autofocus input field
2019-01-31 11:23:04 +05:30
Arpit Jalan
f83533e1cb
FIX: use absolute url for /images/example.png links
...
FEATURE: fallback to logo_url as last resort for opengraph image url
2019-01-31 10:20:15 +05:30
Jeff Wong
4763d6c9d7
FEATURE: add the show user action to the user-card-after-username plugin outlet
2019-01-30 14:56:14 -08:00
Robin Ward
bb8808985a
REFACTOR: Remove a couple more self uses
2019-01-30 14:41:49 -05:00
Robin Ward
dca5486b78
REFACTOR: Prefer this over self
2019-01-30 14:29:45 -05:00
Penar Musaraj
c02e81fe01
FIX: regression with composer warnings
...
Fixes composer warnings when: a) mentioning groups ("By mentioning @group, you are about to notify x people...") and b) mentioning users in a PM ("You mentioned @user but they won`t be notified...")
2019-01-30 11:37:16 -05:00
David Taylor
d8bd3c32ca
DEV: Allow theme CLI to specify which theme to synchronize ( #6963 )
...
Currently the theme is matched by name, which can be fragile when there are many themes with the same name. This functionality will be used by the next version of theme CLI.
2019-01-30 14:17:04 +00:00
Gerhard Schlager
1e98929501
FIX: Email domain whitelist prevented user anonymizing
...
FIX: Secondary email addresses were not deleted during anonymizing
2019-01-30 15:14:36 +01:00
Vinoth Kannan
096974d178
FIX: user_id attribute not found in posters array
2019-01-30 15:28:03 +05:30
Guo Xiang Tan
60c1cd9f81
FIX: Return 400 when username params is invalid.
2019-01-30 16:06:55 +08:00
Guo Xiang Tan
0e5c7f5da7
DEV: Update annotations.
2019-01-30 09:34:51 +08:00
Guo Xiang Tan
ac004297fa
PERF: Add index on user_id to single_sign_on_records.
2019-01-30 09:34:19 +08:00
Jeff Wong
fc5b2de85d
FEATURE: add topic list before status plugin outlet for mobile
2019-01-29 17:15:31 -08:00
Robin Ward
6f656f6e7d
FIX: Better error handling if a file cannot be sent
...
If for some reason `Discourse.store.path_for` returns `nil`, the
forum would throw an error rather than returning 404.
Why would it be `nil`? One cause could be changing the type of
file store and having the `url` field no longer be relative.
2019-01-29 16:47:25 -05:00
Joffrey JAFFEUX
0d0303e7ea
FIX: more resilient lookup in plugin-api ( #6961 )
...
Ember3 is more picky about having a container being destroyed and it's easier to cause exceptions, especially in tests.
This fix has been initially created for an exception occuring in tests when running discourse-code-review and discourse-polls tests at the same time. `getCurrentUser` method body was failing as the container was destroyed.
Original stacktrace:
```
"Error: Assertion Failed: expected container not to be destroyed
at new EmberError (ember:2929:31)
at assert (ember:1793:23)
at Container.lookup (ember:17736:64)
at PluginApi.getCurrentUser (discourse/lib/plugin-api:56:31)
at allowUser (javascripts/discourse/initializers/init-code-review:38:29)
at eval (javascripts/discourse/initializers/init-code-review:78:11)
at eval (select-kit/mixins/plugin-api:86:19)
at Array.forEach (<anonymous>)
at eval (select-kit/mixins/plugin-api:85:44)
at Array.forEach (<anonymous>)"
```
2019-01-29 16:54:04 +01:00
Sam Saffron
32f9fd1e51
FIX: add autocomplete=off to composer textarea
...
Somehow a plugin or some new Chrome bug is causing its heuristic to detect
our textarea for the composer as a target for address autocomplete
This is likely a chrome bug but this change is very safe regardless.
2019-01-29 15:05:29 +02:00
Kris
f7deb52c90
FIX: Class name for external-link on customize page
2019-01-28 17:15:36 -05:00
Vinoth Kannan
62a0f88e97
FIX: More link in topic page search shouldn't navigate to full page result
2019-01-29 02:26:55 +05:30
Vinoth Kannan
3d52f690b3
UX: Add post action text in non-JS topic view
2019-01-28 22:51:06 +05:30
David Taylor
fb5c94246c
DEV: Remove underscore from learn_more key in theme export
...
Follow up from 033cd4f3
2019-01-28 16:00:33 +00:00
David Taylor
0d0ca4f070
DEV: Automatically remove placeholder 'URL' metadata values from themes
2019-01-28 11:55:58 +00:00
David Taylor
77d26b9df6
FIX: Support application/gzip theme imports, and improve error message
2019-01-28 11:51:14 +00:00
David Taylor
033cd4f31d
DEV: Include "_learn_more" key in theme about.json
...
This does not serve any technical purpose. It is there to provide a signpost for any user/developer that wants to know what to do with a theme archive.
2019-01-28 11:34:11 +00:00
David Taylor
aca0b32fda
FEATURE: Allow overriding text size from a different device ( #6955 )
...
This brings the feature in line with the theme selection system
2019-01-28 11:19:50 +00:00
Vinoth Kannan
7e4edcfae8
FIX: Convert lightbox html into proper image markdown
2019-01-27 01:21:56 +05:30
Neil Lalonde
cd3a167c63
FIX: javascript error when opening rename tag modal
2019-01-25 17:34:05 -05:00
Kris
94e2b77c5f
Fix theme component name's color when theme is selected
2019-01-25 17:25:12 -05:00
Penar Musaraj
84a3da4b18
FIX: match drafts using key when deleting
...
Using "sequence" when removing drafts was buggy, it would remove more than one draft from the stream sometimes.
2019-01-25 13:55:40 -05:00
Joffrey JAFFEUX
0e1862013a
FIX: prevents race condition where the same report is loaded multiple times ( #6953 )
2019-01-25 19:29:45 +01:00
David Taylor
2e48c43546
FIX: Fix safe mode regression
...
Follow up from a48731e
2019-01-25 17:00:30 +00:00
Robin Ward
78ddc82952
FIX: Respect min_flags_staff_visibility for new flags too
...
There was a situation where if:
* There were new flags to review that met the visibility threshold
AND
* There were old flags that *didn't* meet the threshold
THEN
a pending flags notification would be sent out. This fixes that case.
Staff should not be notified of flags if they do not meet the threshold
and are old.
2019-01-25 11:27:43 -05:00
Joffrey JAFFEUX
7caa28cf45
FIX: ensures ordering set in tags-show queryString works at first load ( #6951 )
2019-01-25 16:48:20 +01:00
David Taylor
d338e54f59
FEATURE: Allow setting font size per-device using a cookie ( #6947 )
2019-01-25 15:06:06 +00:00
Vinoth Kannan
65caf04ddc
clean up unused code
...
Unused PM topic list column 'Users' is removed
2019-01-25 20:13:54 +05:30
David Taylor
a48731e359
FEATURE: Support additional metadata in theme about.json ( #6944 )
...
New `about.json` fields (all optional):
- `authors`: An arbitrary string describing the theme authors
- `theme_version`: An arbitrary string describing the theme version
- `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
- `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
A localized description for a theme can be provided in the language files under the `theme_metadata.description` key
The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
2019-01-25 14:19:01 +00:00
Vinoth Kannan
2d6aa2aea2
FEATURE: Add recipient avatars in PM topic list even if they not yet replied
2019-01-25 19:41:49 +05:30
Joffrey JAFFEUX
f461a9971f
FIX: makes staff_logins show only admins ( #6948 )
2019-01-25 11:28:52 +01:00
Blake Erickson
de47b35b2d
FIX: user_id handling on remove user from group
...
Under some conditions it was possible to pass in a user_id as an
integer, but we would try and parse it as a comma delimited string
resulting in an error. This has been fixed so that we are no longer
mapping the user_id param to user_ids.
2019-01-24 17:40:48 -07:00
Kris
868528f862
Slight shadow adjustment to hide overflow
2019-01-24 14:49:39 -05:00
Robin Ward
96b2585a91
REFACTOR: Remove unncessary stubs from pending flags reminder
...
They seem to be calculated fine by the application, and stubbing
makes the tests more brittle and prone to regression.
2019-01-24 13:45:58 -05:00
Robin Ward
a518950e52
FIX: Use context sensitive "create topic" via keyboard if possible
2019-01-24 13:20:33 -05:00
Kris
8e795d82f9
UX: Bump up notification panel width to accommodate larger text
2019-01-24 12:48:48 -05:00
Penar Musaraj
755b47b4bc
UX: change topic reminder notification icon
2019-01-24 10:07:24 -05:00
Joffrey JAFFEUX
e5765fe1f5
FIX: ensures correct scroll position of textarea after autocomplete ( #6942 )
2019-01-24 15:19:19 +01:00
Joffrey JAFFEUX
49193ca3bf
FIX: includes staff in staff_logins report ( #6945 )
2019-01-24 14:46:56 +01:00
Vinoth Kannan
c88fd49591
DEV: refactor user preferences path method
2019-01-24 18:39:13 +05:30
Vinoth Kannan
b9bf751b88
FIX: link to the user preferences page is incorrect in user admin page
2019-01-24 18:31:00 +05:30
Joe
dda918f862
UX: removes width constraint in user-card badge section
2019-01-24 20:53:14 +08:00
Angus McLeod
b1297a5f5a
FIX: replaces inline button message with d-button
2019-01-24 13:19:52 +01:00
Joffrey JAFFEUX
1f8ff85ff9
FIX: displays user-card when clicking on avatar of post small action ( #6941 )
2019-01-24 10:46:06 +01:00
Joe
22f43abb0e
UX: protection for very wide category-logo images on narrow screens
2019-01-24 17:16:18 +08:00
Kris
12df8c5c82
General style cleanup, removing unused styles
2019-01-23 21:37:39 -05:00
Kris
7d92fa3a5e
Mobile SCSS cleanup and removing unused styles
2019-01-23 14:36:53 -05:00
Daniel
48c9234545
FIX: Lazy Loading: copy only present srcset
...
When showing a lazy-loaded image, copy the `srcset` property only when
it is actually set. `copyImg.srcset = copyImg.srcset` is not actually a
noop but creates an empty `srcset`, changing content security rules on
the image.
2019-01-23 14:04:43 -05:00
Joe
a9734eef81
UX: removes margins from categories in suggested topics message
2019-01-24 02:12:16 +08:00
Joffrey JAFFEUX
bd31423137
DEV: refactoring admin-logs-screened-ip-addresses ( #6932 )
2019-01-23 17:40:37 +01:00
Joffrey JAFFEUX
0aa049791e
DEV: refactoring admin-backups-index ( #6933 )
2019-01-23 17:40:24 +01:00
Joffrey JAFFEUX
60974932c4
DEV: refactoring api-keys ( #6931 )
2019-01-23 17:40:05 +01:00
Kris
9a594fed01
Removing unused bootstrap.scss file
2019-01-23 11:22:23 -05:00
Kris
5feeac221e
Groups on user profile missing margin
2019-01-23 10:10:17 -05:00
Joffrey JAFFEUX
096a81158a
FIX: siteNavigationElement was reversed ( #6934 )
2019-01-23 15:47:39 +01:00
David Taylor
afd449089f
FEATURE: Import and export themes in a .tar.gz format ( #6916 )
2019-01-23 14:40:21 +00:00
Joffrey JAFFEUX
d0129b85f4
FIX: stop propagating keyboard event when replying to topic/post ( #6930 )
2019-01-23 14:38:20 +01:00
Joe
d720215183
UX: admin badge page improvements
2019-01-23 11:29:51 +01:00
David Taylor
2e59a37687
FEATURE: List unused theme components ( #6924 )
2019-01-23 09:20:13 +00:00
Joe
b21266ed6f
FIX: corrects selector for move-to modal styles
2019-01-23 16:18:38 +08:00
Vinoth Kannan
70b56c8332
FIX: 'anon' css class is missing for anonymous users
2019-01-23 10:13:36 +05:30
Penar Musaraj
9886934ef5
DEV: fix some deprecated SVG icon refs
2019-01-22 14:42:00 -05:00
Kris
62adc2eb98
User admin page button height fix
2019-01-22 14:00:38 -05:00
Kris
66f6382090
FIX: Icon missing due to typo
2019-01-22 13:01:21 -05:00
Kris
f0fd875918
UX: Improving aligment within topic timer modal
2019-01-22 12:33:46 -05:00
Robin Ward
a834245683
FIX: Keep tags when switching to shared draft
2019-01-22 11:26:52 -05:00
Robin Ward
f32de88dfc
FIX: Don't notify of pending flags if min_flags_staff_visibility not met
2019-01-22 11:01:18 -05:00
Joffrey JAFFEUX
fc710de3ab
DEV: refactoring admin user index ( #6927 )
2019-01-22 16:44:55 +01:00
Joffrey JAFFEUX
31a700daf8
DEV: refactoring emoji-uploader ( #6926 )
2019-01-22 16:44:40 +01:00
Joffrey JAFFEUX
bce9c37f15
DEV: refactoring permalink-form ( #6925 )
2019-01-22 15:09:21 +01:00
Joffrey JAFFEUX
ea8373351b
DEV: refactoring ip-lookup ( #6923 )
2019-01-22 15:09:04 +01:00
Joffrey JAFFEUX
80d42b4ea2
icons deprecations fixes ( #6920 )
2019-01-22 12:02:02 +01:00
Joffrey JAFFEUX
ea0e188c8f
FIX: improves stacked-chart layout on ie11 ( #6922 )
2019-01-22 11:47:54 +01:00
Joffrey JAFFEUX
9148f7675b
FIX: better handling of resizing in stacked charts ( #6921 )
2019-01-22 11:20:50 +01:00
Joffrey JAFFEUX
7161304842
minor cosmetic improvements to charts ( #6919 )
2019-01-22 10:22:41 +01:00
Joffrey JAFFEUX
b1b27d9f7b
FEATURE: add total on stacked-chart tooltip ( #6917 )
2019-01-22 09:57:34 +01:00
Jeff Wong
3359b3baca
FEATURE: Do not autoclose topics due to user flagging that are authored by staff
2019-01-21 15:50:53 -08:00
Kris
fe6d571021
FIX: Alignment for small-actions, gap, removing unneeded clearfix
2019-01-21 17:57:47 -05:00
Kris
4ddc28f194
FIX: Whitespace breaks activity column in Firefox
2019-01-21 16:26:34 -05:00
Gerhard Schlager
d82628987a
FIX: Badges appeared in wrong badge group
...
Some badges always appeared in the "Other" group (the default group) and some badges were always moved back into the original group during seeding.
Now badges are either in the correct, seeded group or stay in a custom group if the admin moved the badge into a custom group.
2019-01-21 21:09:33 +01:00
Kris
8546f0020e
UX: Invert pikaday png for dark themes
2019-01-21 13:47:46 -05:00
Penar Musaraj
ba5e17a7a9
FIX: IE11 layout glitches
...
IE11 requires a unit on the third parameter (flex-basis) of the flex property
2019-01-21 13:40:55 -05:00
Kris
ec71091216
FIX: Don't override user flair styles in topic map
2019-01-21 12:37:49 -05:00
Penar Musaraj
916219f48e
Remove "Users" heading in wizard homepage preview
2019-01-21 11:31:00 -05:00
Joffrey JAFFEUX
3e1e9fce7e
FIX: better legend labels for stacked-charts ( #6914 )
2019-01-21 17:10:10 +01:00
Joffrey JAFFEUX
a9edcb2e10
fixes few icons deprecations warnings ( #6915 )
2019-01-21 16:56:05 +01:00
Joffrey JAFFEUX
b95165b838
FEATURE: adds a new chart report to track pageviews ( #6913 )
2019-01-21 15:17:04 +01:00
Joffrey JAFFEUX
52f2e0d6b9
SECURITY: fix possible XSS with badges ( #6912 )
2019-01-21 13:08:26 +01:00
Guo Xiang Tan
2d354ec9b0
FIX: ForumsController doesn't need to inherit from ApplicationController.
...
Application controller has a whole bunch of before/after actions which
we have no need for.
2019-01-21 14:37:04 +08:00
Joffrey JAFFEUX
502b1316d0
DEV: s/this._super()/this._super(...arguments) ( #6908 )
2019-01-19 10:05:51 +01:00
Kris
61fff098ed
minor email/whisper icon alignment fix
2019-01-18 20:59:52 -05:00
Kris
3b7ac3f6eb
UX: We don't have bulk select on mobile, so we should hide the button
2019-01-18 20:26:58 -05:00
Kris
df0303c912
UX: Improve button alignment, fix invite header
2019-01-18 20:08:52 -05:00
Kris
e6e4a073a5
alignment fix due to font-size bump
2019-01-18 16:24:27 -05:00
Kris
4f897dde50
UX: Improve alignment of new post badge on mobile
2019-01-18 16:17:24 -05:00
Kris
247ab4a830
Align notification in unread education message
2019-01-18 15:40:07 -05:00
David Taylor
59028035df
FIX: Update about/license URLs when updating theme from remote source
2019-01-18 17:46:57 +00:00
Joffrey JAFFEUX
95f9a369a5
FIX: ensures visits reports are correcttly differencing mobile/all ( #6905 )
2019-01-18 17:24:18 +01:00
Joffrey JAFFEUX
7908a522a0
FIX: postLabel was not working for totals ( #6904 )
2019-01-18 17:06:43 +01:00
David Taylor
b1b8c37e62
FIX: Correctly import theme assets with spaces in filename
...
This issue is caused by the filename restrictions in `OptimizedImage#ensure_safe_paths!`. Difficult to add a test for this because image optimization is bypassed in test mode.
2019-01-18 15:20:11 +00:00
Maja Komel
45f66826ee
PERF: delete potentially large associated tables before user_destroyer.destroy transaction
2019-01-18 16:10:03 +01:00
Penar Musaraj
f8f281cdad
UI: update "latest" canvas layout in wizard
2019-01-18 09:56:39 -05:00
Gerhard Schlager
457e6c7b37
FIX: Mods weren't able to see emails in admin user list
2019-01-18 15:37:30 +01:00
David Taylor
f40c97c367
Remove support for theme_var and theme_color_var fields
...
These are remnants of the old 'customization' system, and have been superseded by theme settings
2019-01-18 12:04:23 +00:00
Gerhard Schlager
197e3fd722
FIX: Keep original subject in emails to staged users
...
Renaming a topic shouldn't be visibile to staged users when the topic was created via email.
2019-01-18 11:07:54 +01:00
Joffrey JAFFEUX
b20ad9d684
FIX: since Ember 3 interceptClick was not working on buffered links ( #6898 )
2019-01-18 11:01:19 +01:00
Guo Xiang Tan
95e3841974
FIX: Remove old reference and use MiniScheduler::Stat.
2019-01-18 16:36:11 +08:00
Guo Xiang Tan
f89a32e759
FIX: Text logo does not show up on non ember pages.
2019-01-18 15:11:42 +08:00
Bianca Nenciu
cf6223226d
DEV: Do the draft conflict check async. ( #6895 )
2019-01-18 15:51:56 +11:00
Penar Musaraj
2274d6d7ac
FIX: refresh "/categories" on logo click ( #6891 )
...
* FIX: refresh discovery categories on logo click
* Fix prettier offence
2019-01-18 12:08:42 +08:00
Kris
9f52306861
Keep avatar image at native size for normal font-size, remove unneeded clearfix
2019-01-17 21:54:22 -05:00
Kris
8c5c4200ec
prettier
2019-01-17 21:13:52 -05:00
Kris
5307e9337f
HACK: Reduce icon jitter while scrolling with composer open in iOS
2019-01-17 21:04:05 -05:00
Kris
d5d994e24a
UX: Improving user stream alignment and spacing
2019-01-17 17:29:27 -05:00
Kris
43bb16de27
Prevent header icons from overflowing with long title present
2019-01-17 16:11:40 -05:00
Kris
7401901939
UX: Badge alignment adjustments
2019-01-17 15:46:55 -05:00
Vinoth Kannan
2818afb267
FIX: Do not hide posts automatically when flagged by staff user
2019-01-18 01:33:55 +05:30
Kris
3c987132cb
Prevent placeholder text from being cut-off
2019-01-17 14:39:28 -05:00
Penar Musaraj
3501533a2b
DEV: unpin Prettier version, apply to YAML files
...
We had Prettier pinned because of https://github.com/prettier/prettier/issues/5529 . Since that bug is fixed, unpinning.
Prettier now supports YAML, so this applies Prettier to all .yml except for translations, which should not be edited directly anyway.
2019-01-17 13:05:39 -05:00
Kris
b664674d2b
make smaller text size bigger
2019-01-17 12:11:31 -05:00
Vinoth Kannan
b9215ddaea
FIX: Navigate to full page search when enter key used in topic
2019-01-17 22:34:23 +05:30
Kris
b9355f316a
Minor size/alignment fixes for font size increase
2019-01-17 11:42:03 -05:00
Kris
675bf94133
UX: Bump up base font size 1px, add smaller text size option
2019-01-17 10:30:34 -05:00
David Taylor
24b59afe2a
FIX: Wrap theme javascript inside IIFE to prevent using global namespace
2019-01-17 14:44:10 +00:00
David Taylor
5bfa661a87
FIX: Theme settings are referenced in JS by settings, not themeSetting
2019-01-17 12:24:21 +00:00
David Taylor
880311dd4d
FEATURE: Support for localized themes ( #6848 )
...
- Themes can supply translation files in a format like `/locales/{locale}.yml`. These files should be valid YAML, with a single top level key equal to the locale being defined. For now these can only be defined using the `discourse_theme` CLI, importing a `.tar.gz`, or from a GIT repository.
- Fallback is handled on a global level (if the locale is not defined in the theme), as well as on individual keys (if some keys are missing from the selected interface language).
- Administrators can override individual keys on a per-theme basis in the /admin/customize/themes user interface.
- Theme developers should access defined translations using the new theme prefix variables:
JavaScript: `I18n.t(themePrefix("my_translation_key"))`
Handlebars: `{{theme-i18n "my_translation_key"}}` or `{{i18n (theme-prefix "my_translation_key")}}`
- To design for backwards compatibility, theme developers can check for the presence of the `themePrefix` variable in JavaScript
- As part of this, the old `{{themeSetting.setting_name}}` syntax is deprecated in favour of `{{theme-setting "setting_name"}}`
2019-01-17 11:46:11 +00:00
Joffrey JAFFEUX
740d047365
FIX: regression lead to a 404 when trying to filter user posts ( #6893 )
2019-01-17 11:31:23 +01:00
Guo Xiang Tan
aa2cc4ab31
FIX: Liked notification consolidation has to account for user like frequency setting.
2019-01-17 14:33:23 +08:00
Sam
384135845b
FEATURE: introduce ultra_low priority queue
...
This commit introduces an ultra low priority queue for post rebakes. This
way rebakes can never interfere with regular sidekiq processing for cases
where we perform a large scale rebake.
Additionally it allows Post.rebake_old to be run with rate_limiter: false
to avoid triggering the limiter when rebaking. This is handy for cases
where you want to just force the full rebake and not wait for it to trickle
2019-01-17 14:53:19 +11:00
Bianca Nenciu
7d84648d11
FEATURE: Remove full quotes only from new posts. ( #6862 )
2019-01-17 13:24:32 +11:00
Kris
e7d2a0d42f
UX: Larger/Largest font-sizes should be 1px larger on mobile
2019-01-16 20:59:31 -05:00
Sam
d5ecf8e8c2
FIX: properly clean out post and user actions on destroy user
...
This corrects 2 issues:
First is a regression with d7c08e21
2019-01-17 12:40:30 +11:00
Sam
d7c08e217a
PERF: delete user and post actions vs destroy on user destroy
...
Users can have 100s of thousands of post and user actions, we do not want
to destroy each individually cause the tracking is enormous and the amount
of queries we would need is enormous.
This gives up on the `after_commit` hook on `post_actions` which ships a message
to clients to synchronize a post, so some phantom post_actions may remain
in the UX in the rare occasion we delete a user. The phantoms will be gone
on reload.
2019-01-17 11:19:37 +11:00
Jeff Atwood
1d4d4b81e6
remove stray chars
2019-01-16 15:05:43 -08:00
Régis Hanol
58008dd2fe
FIX: sort topics/posts/links in descending order in user summaries
...
This should only change the order on freshly imported instances with no likes.
This makes the user summary show the latest topics/posts/links instead of the firsts until the users get some likes.
2019-01-16 23:58:46 +01:00
Jeff Atwood
f0999f27a7
UX: soften the "problems" alert on dashboard
2019-01-16 14:58:19 -08:00
Sam
6079a3e4d0
FEATURE: allow calling user destroyer without a transaction
...
This additional option allows us to destroy a user in "pieces" in cases
where database is very big and stuff tends to time out
2019-01-17 07:56:17 +11:00
Robin Ward
16a7102dad
FIX: Ember.warn needs an id
...
This way errors can be customized/silenced in the console.
2019-01-16 14:53:13 -05:00
David Taylor
98f26bcaf5
Revert "FIX: makes click-interceptor working with touchstart ( #6890 )"
...
This reverts commit fd2dd8d67d
2019-01-16 17:47:40 +00:00
Joffrey JAFFEUX
fd2dd8d67d
FIX: makes click-interceptor working with touchstart ( #6890 )
...
Probable regression due to the removal of Modernizr.
2019-01-16 17:56:43 +01:00
Penar Musaraj
18055f5e37
DEV: show remote theme repository URL
2019-01-16 11:09:16 -05:00
Joffrey JAFFEUX
1ac4dc5b73
FIX: makes whisper state more resilient ( #6889 )
...
This commit also moves some logic from model to controller.
2019-01-16 15:23:06 +01:00
David Taylor
b46b6e72d1
FIX: Only add the trust level name for numeric trust levels
...
Previously the TrustLevelAndStaffSetting would display 'new user' for staff/admin
2019-01-16 12:04:12 +00:00
Angus McLeod
79eb1b8e16
FIX: Add watching_first_post to NOTIFIABLE_TYPES ( #6887 )
2019-01-16 11:49:15 +00:00
Angus McLeod
54f95bb335
rm period ( #6886 )
2019-01-16 10:58:43 +01:00
Joffrey JAFFEUX
486df57a23
FIX: tweaking topic footer dropdowns ( #6882 )
...
- no description on mobile for notifications
- better reason text positioning
2019-01-16 10:27:27 +01:00
Guo Xiang Tan
f06b773d25
FIX: Don't show liked consolidated notification when frequency is never.
2019-01-16 17:08:59 +08:00
Guo Xiang Tan
e7b49c42c4
FIX: Allow liked notifications consolidation to be disabled.
2019-01-16 16:17:04 +08:00
Guo Xiang Tan
f8db93df5f
FIX: Consolidated like notifications links to wrong user on user page.
2019-01-16 15:55:18 +08:00
Guo Xiang Tan
27e2b6575b
FIX: Liked notifications should not be consolidated across multiple users.
2019-01-16 15:01:13 +08:00
Penar Musaraj
71a69c1976
Revert "FIX: refresh topic list on logo click"
...
This reverts commit 037776881b
2019-01-15 22:54:53 -05:00
Arpit Jalan
1591c42a06
FIX: profile picture not showing up on user admin page
2019-01-16 09:21:11 +05:30
Guo Xiang Tan
40533bc570
REFACTOR: filterBy in UserStream.
...
Follow up to ebe65577ed
2019-01-16 10:53:44 +08:00
Guo Xiang Tan
ebe65577ed
FEATURE: Consolidate likes notifications. ( #6879 )
2019-01-16 10:40:16 +08:00
Penar Musaraj
037776881b
FIX: refresh topic list on logo click
...
Fixes a regression where, when homepage is set to "categories", clicking on logo would no longer reload topic list.
2019-01-15 17:01:09 -05:00
David Taylor
b69e57e2f3
FIX: Prevent layout changes while images are lazy-loading
...
This commit moves the temporary image to be adjacent to the original image in the DOM. Previously the temporary image was appended to the parent element. Normally this makes no difference because the temporary element has position:absolute. However, if the `:last-child` selector is being used on the parent, it can cause layout changes during loading.
2019-01-15 17:35:55 +00:00
Gerhard Schlager
70cdb42173
FIX: Tooltip for unlisted topics wasn't shown in topic list
...
The locale key had to be renamed, because this key is also used as CSS class.
The "invisible" CSS class makes the icon invisible. "unlisted" doesn't have that effect.
2019-01-15 16:13:06 +01:00
Arpit Jalan
c4422fdc13
UX: sort admins and moderators by last seen date on /about page
...
UX: only show active admins and moderators on /about page
2019-01-15 17:26:11 +05:30
Vinoth Kannan
59e5af466b
FIX: call method only if it exists
...
discourse-objects creating empty Discourse object in window. It fails the _registerPluginCode method call since it is not exist.
2019-01-15 15:55:32 +05:30
Robin Ward
f75915efa4
FIX: expandAllPinned was not resetting after visiting a category
...
This resulted in a bug where if you saw a pinned topic in a category,
then went back to latest, the same topic would show an excerpt even
though it shouldn't on the latest view.
See:
https://meta.discourse.org/t/pinned-post-excerpt-no-longer-appears-after-refreshing-the-page/106222
2019-01-14 13:02:25 -05:00
Arpit Jalan
0cb2b7d603
FIX: add meta details for user summary page
2019-01-14 19:49:14 +05:30
David Taylor
1ebd3dbbd0
FEATURE: Allow the base font size to be changed on a per-user basis ( #6859 )
2019-01-14 13:21:46 +00:00
Arpit Jalan
59e3eecfa6
FEATURE: allow staff to select existing message via ID or URL
2019-01-14 15:29:05 +05:30
Arpit Jalan
a121d40771
FIX: do not show PM topics when moving posts to an existing public topic ( #6876 )
2019-01-14 15:00:45 +05:30
Arpit Jalan
08d21cc758
FIX: do not show full name on summary page unless the setting is enabled
2019-01-14 07:00:44 +05:30
Arpit Jalan
93eb0a0690
UX: better help text for private invite-only instance
2019-01-12 18:40:00 +05:30
David Taylor
49593d1a00
FIX: Fix registration dialog popup for 'full screen' social logins
...
Regression following the ember3 upgrade. In addition to fixing, this commit consolidates our social registration logic into one place, and adds tests for the behaviour.
2019-01-12 12:08:13 +00:00
Joffrey JAFFEUX
dcdcaebd0f
FIX: checkEmail was calling itself ( #6878 )
2019-01-12 11:12:17 +01:00
Kris
8176d26dbd
UX: Reducing usage of btn-small, simplifying styles
2019-01-11 19:41:09 -05:00
Kris
e4c593f1e7
removing some dupe styles, adding button class
2019-01-11 15:41:51 -05:00
Robin Ward
95f263995d
FIX: Previous annotations were broken
2019-01-11 14:30:19 -05:00
Arpit Jalan
5e0f9eadb8
FIX: show user avatar on User summary page ( #6872 )
2019-01-11 23:39:06 +05:30
Kris
83f0afbec9
Usercards sometimes not wrapping correctly in Safari
2019-01-11 12:50:16 -05:00
Robin Ward
a3839495e0
Update annotations
2019-01-11 12:19:43 -05:00
Joffrey JAFFEUX
1a3655b787
DEV: s/Em/Ember ( #6874 )
2019-01-11 17:54:23 +01:00
Robin Ward
dbe42068a2
REFACTOR: Move option to return emails into the serializer
...
This makes more sense than having the guardian take an accessor.
The logic belongs in the Serializer, where the JSON is calculated.
Also removed some of the DRYness in the spec. It's fewer lines
and made it easier to test the option on the serializer.
2019-01-11 11:17:23 -05:00
Guo Xiang Tan
0fa92699e2
UX: Don't save automatically when resetting site settings in admin page.
2019-01-11 16:39:21 +08:00
Guo Xiang Tan
2956c52e57
FIX: Show title as home logo if title has been set and logo is blank.
...
https://meta.discourse.org/t/default-text-logo-not-working/103936
2019-01-11 15:46:58 +08:00
Saurabh Patel
99856478d6
FIX: use discourse route_for function to check url route
...
it takes care if there is a relative url root
2019-01-11 14:58:45 +08:00
Kris
29ff184508
d60b9df fix, was too broad
2019-01-10 21:50:00 -05:00
Kris
d60b9dfba4
UX: Close button shouldn't get :visited color
2019-01-10 21:47:38 -05:00
Joffrey JAFFEUX
9f39ac8366
FIX: ember3 regression, uses model as bufferedProperty for badges ( #6875 )
2019-01-11 00:46:03 +01:00
Penar Musaraj
49e3a83062
FIX: minor regression when acting on queued post
2019-01-10 15:32:33 -05:00
Vinoth Kannan
0744e84604
UX: always scope the composer categories dropdown to current category
2019-01-11 01:07:23 +05:30
Vinoth Kannan
a8ff4a8a78
UX: search all categories even if category-chooser is scoped to particular category
2019-01-10 21:19:53 +05:30
Gerhard Schlager
978cc0cfca
FIX: Remove expired subscription for push notifications
...
All other errors get logged, but do not stop the system from sending further push notifications.
2019-01-10 15:41:04 +01:00
Joffrey JAFFEUX
1fdbf0fc9b
FIX: uses compiler version to force rebaking of themes ( #6870 )
...
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 12:36:13 +01:00
Joffrey JAFFEUX
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 ( #6808 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 11:06:01 +01:00
Guo Xiang Tan
c2bca9cabe
Make rubocop happy.
2019-01-10 10:52:15 +08:00
Guo Xiang Tan
d10694150e
Revert "FIX: Partial reply key search in email sent logs."
...
This reverts commit e9b2018bc8
2019-01-10 10:05:56 +08:00
Angus McLeod
798e98a7cc
remove safari check from isAppleDevice ( #6869 )
2019-01-10 13:02:55 +11:00
Maja Komel
51b13ec86f
FIX: show lock glyph to a user without permissions to see quote ( #6854 )
2019-01-10 09:48:05 +08:00
Guo Xiang Tan
cb0f6d653b
DEV: Minor fixes to b63b399799.
2019-01-10 09:38:22 +08:00
Saurabh Patel
b63b399799
DEV: remove uploaded_meta_id column from category ( #6725 )
...
* DEV: remove uploaded_meta_id column from category
* remove uploaded_meta part
2019-01-10 09:37:21 +08:00
Saurabh Patel
a52baf4b28
FEAT: use category logo image as meta image ( #6865 )
2019-01-10 09:33:13 +08:00
Guo Xiang Tan
e9b2018bc8
FIX: Partial reply key search in email sent logs.
...
Follow up to c85b9c6ed3
2019-01-10 09:25:14 +08:00
Michael Brown
c85b9c6ed3
FIX: searching email logs by reply key ( #6868 )
...
* you can't use LIKE or ILIKE on a UUID
2019-01-10 07:51:58 +08:00
Robin Ward
312e282b6a
FIX: Apply classes when lazily loading images
...
If an image had extra classes (for example oneboxes), then while loading
the copy of the image would lose those classes and look differently
until the image had loaded fully.
This fix copies the classes while loading.
2019-01-09 12:56:25 -05:00
Jeff Wong
439eff4709
revert null checking around interceptClick
2019-01-09 09:44:30 -08:00
David Taylor
2d3e50ae7c
FIX: Match default <code> padding to highlightjs padding
...
Without this, the height of posts changes once highlightjs is lazy-loaded, potentially causing scrolling issues
2019-01-09 17:36:51 +00:00
Robin Ward
8b3ddcf646
FIX: Add topic status to flagged topics list
...
Previously at a glance it was impossible to tell if a topic was closed
before digging deeper.
2019-01-09 10:59:35 -05:00
Vinoth Kannan
1f12a377fa
minor refactoring of card-contents-base mixin
2019-01-09 19:32:30 +05:30
Vinoth Kannan
b7c501bf52
FIX: full page search results are unclickable
...
data-ember-action can have empty value in favor of data-ember-action-ID attribute
2019-01-09 10:59:37 +05:30
Zach Whitehead
2748822576
FEATURE: Remove option for Google Plus sharing ( #6864 )
...
* Remove option for Google Plus sharing
* remove google+ share translations
2019-01-09 10:17:50 +08:00
Joffrey JAFFEUX
25269a37aa
FIX: do not show #uncategorized in category drop if setting is disabled ( #6856 )
2019-01-09 09:44:24 +08:00
Rafael dos Santos Silva
f73fe36772
FEATURE: PWA compatibility checks in the Dashboard ( #6850 )
2019-01-09 08:46:11 +08:00
Jeff Wong
09cbd08c64
FIX: ensure ember transitions do not get hijacked by discourse intercept-click
...
explicit null checks as a blank string evaluates to false
2019-01-08 15:38:13 -08:00
Jeff Wong
d75262046d
Revert "FIX: ensure ember transitions do not get hijacked by discourse intercept-click"
...
This reverts commit a2cb2f2366
2019-01-08 15:37:10 -08:00
Jeff Wong
a2cb2f2366
FIX: ensure ember transitions do not get hijacked by discourse intercept-click
...
explicit null checks as a blank string evaluates to false
2019-01-08 15:09:50 -08:00
Sam
7e4a43afc6
PERF: run ImageMagick conversions with nice 10
...
This lowers the priority of all image resizes so they do not clog CPU on
machines running low on resources
2019-01-09 09:21:58 +11:00
Sam
e08a3f719c
FEATURE: push post rebake regular task to low priority queue
...
This allows us to run regular rebakes without starving the normal queue.
It additionally adds the ability to specify queue with `Jobs.enqueue` so
we can specifically queue a job with lower priority using the `queue` arg.
2019-01-09 08:57:20 +11:00
Kris
cfb8e157a2
Fixing tag alignment
2019-01-08 16:25:11 -05:00
Kris
4a01fee41b
UX: use default H2 and H3 sizes on user profiles for better hierarchy
2019-01-08 13:07:29 -05:00
David Taylor
fe20cb4b56
FIX: Enforce a fixed height on generic oneboxed videos
...
This prevents 'jumping' as the video loads. This change will require posts to be rebaked before it takes effect.
2019-01-08 16:22:03 +00:00
Joe
a2d1babac6
UX: tag container should wrap if there's a large number of tags
2019-01-08 23:33:47 +08:00
Vinoth Kannan
8f602be2fe
FEATURE: keep the topic in closed status until the community flags are handled
2019-01-08 16:13:10 +05:30
Sam
f947e3c6cc
FIX: always serve new avatar for previous version
...
Previously we killed caching on old avatars cause we kept serving blank
this meant we would front many more avatar requests after a version change
This change ensures all old avatars do not cause a flood of requests on the
server
2019-01-08 19:51:33 +11:00
Joe
3457395f75
UX: moves topic-list excerpts out of category / tag div
2019-01-08 14:55:15 +08:00
Arpit Jalan
4ebf170fe4
DEV: no need for conditional redirect in invites
2019-01-08 11:34:26 +05:30
Arpit Jalan
9919f16041
FIX: use absolute URL for twitter:image tag
2019-01-08 11:19:04 +05:30
Guo Xiang Tan
ef72a9a1fe
UX: Default search log index to yearly.
2019-01-08 13:40:38 +08:00
Maja Komel
6c8069c65a
FIX: properly escape embed url
2019-01-07 18:11:43 +01:00
Arpit Jalan
e0bc82657b
FIX: better accept invite flow when user is invited via a link
2019-01-07 14:22:08 +05:30
Joe
effb3262a1
UX: no need for margin if participants is first-child
2019-01-06 00:11:53 +08:00
Joe
3a9fea4409
align and truncate header tags and participants
2019-01-05 23:09:44 +08:00
Vinoth Kannan
046e4ab413
FIX: Improve topic small header alignment in mobile
...
Force topic-header-extra height to 20px
2019-01-05 14:06:06 +05:30
Vinoth Kannan
3589f3e023
UX: Display user and group cards over the small PM header
2019-01-05 04:58:56 +05:30
Vinoth Kannan
aba18a42a7
UX: Improve PM small header alignment with recipient avatars
2019-01-05 03:51:15 +05:30
Robin Ward
5eaf3cb104
Adjusts the minimum_flag_threshold for TL3/TL4 actions
...
Before this patch, a high trust level user could flag something
and have an action be taken, as well as skipping the flag queue.
Now, if a TL3/TL4 cause an action, the flag will skip the minimum
visibility check and allow staff to review it.
2019-01-04 13:16:44 -05:00
Régis Hanol
5ac1e3d4cd
FIX: emojis are hard 🤷
2019-01-04 17:21:16 +01:00
Penar Musaraj
f400830575
DEV: Remove old _firefoxPastingHack
2019-01-04 11:14:35 -05:00
Gerhard Schlager
858a456aaf
FEATURE: Use email_site_title in From of digest emails
2019-01-04 17:06:19 +01:00
Gerhard Schlager
c0a8bb9a91
FEATURE: Include "via <site_name>" in email From header
2019-01-04 17:06:19 +01:00
Régis Hanol
95e5f8380d
FEATURE: Allow plugins to add custom emoji translations
...
FIX: buildTranslationTree was erroring when translations overlapped (ie. ":-)" and ":-))")
FIX: emoji translations wasn't working properly when translations overlapped
2019-01-04 15:27:46 +01:00
Régis Hanol
88e861e895
FIX: prevent error when badge has already been awarded
2019-01-04 15:17:54 +01:00
David Taylor
5bf16d7d10
FEATURE: Topic timer for bumping a topic in the future
2019-01-04 13:08:04 +00:00
Sam
9c91e68351
PERF: remove image optimization throttling from Sidekiq
...
Previously we only allowed one image optimization per machine, this meant there
was cross talk between avatar resizing and Sidekiq. This could lead to large
amounts of starvation when optimized image version changed which in turn could
block the Sidekiq queue.
This increases amount of allowed load on machines but this is preferable to
having crosstalk between avatar resizing and Sidekiq.
2019-01-04 18:44:44 +11:00
Vinoth Kannan
75dbb98cca
FEATURE: Add S3 etag value to uploads table ( #6795 )
2019-01-04 14:16:22 +08:00
Joe
3a04e04ccb
UX: excerpts don't wrap on IE11 ( #6847 )
2019-01-04 15:11:42 +11:00
Sam
8b7a2d1cb7
FEATURE: add setting to bypass sending redis CLIENT commands
...
Some cloud providers (Google Memorystore) do not support any CLIENT commands
By setting :id to nil in the redis config hash we can avoid these commands.
This adds a special global setting GCE users can enable:
`DISCOURSE_REDIS_SKIP_CLIENT_COMMANDS = true`
2019-01-04 15:08:33 +11:00
Kris
a2f1d47506
Slightly better alignment of PM participants in header
2019-01-03 22:47:56 -05:00
cfitz
19d7545318
FEATURE: Make auth_redirect param options on user_api_keys
...
This is a possible solution for https://meta.discourse.org/t/user-api-keys-specification/48536/19
This allows for user-api-key requests to not require a redirect url.
Instead, the encypted payload will just be displayed after creation ( which can be copied
pasted into an env for a CLI, for example )
Also: Show instructions when creating user-api-key w/out redirect
This adds a view to show instructions when requesting a user-api-key
without a redirect. It adds a erb template and json format.
Also adds a i18n user_api_key.instructions for server.en.yml
2019-01-04 14:46:18 +11:00
Sam
d0f38dbb07
FIX: image rendered temporarily in wrong position while loading
...
Previously non lightboxed images would render in the wrong spot while loading.
We assumed the image we were rendering while loading was at 0,0 position.
This is not the case on non-lightboxed images cause they have no surrounding
DIV.
2019-01-04 11:50:44 +11:00
Sam
70269c7c97
FEATURE: tighter limits on per cluster post rebakes
...
We have the periodical job that regularly will rebake old posts. This is
used to trickle in update to cooked markdown. The problem is that each rebake
can issue multiple background jobs (post process and pull hotlinked images)
Previously we had no per-cluster limit so cluster running 100s of sites could
flood the sidekiq queue with rebake related jobs.
New system introduces a hard limit of 300 rebakes per 15 minutes across a
cluster to ensure the sidekiq job is not dominated by this.
We also reduced `rebake_old_posts_count` to 80, which is a safer default.
2019-01-04 09:24:46 +11:00
Vinoth Kannan
385829d7be
FEATURE: Display error message when category restriction is applied for tags
2019-01-04 00:29:13 +05:30
Arpit Jalan
d1597683f3
Revert "FIX: trim trailing slash from topic links"
...
This reverts commit 993f847a2c
2019-01-03 17:29:22 +05:30
Arpit Jalan
993f847a2c
FIX: trim trailing slash from topic links
2019-01-03 12:38:36 +05:30
Sam
570877da3c
FEATURE: store thumbnail algorithm version in optimized image table
...
Previously we had no idea what algorithm generated thumbnails, this starts tracking the version.
We also bumped up the version to force all optimized images to be generated. This is important cause we recently introduced pngquant which results in much smaller images.
2019-01-03 17:07:30 +11:00
Arpit Jalan
bea7a8a4d1
FIX: show accurate error message based on invite token validity
2019-01-03 07:46:05 +05:30
Penar Musaraj
a953b71797
FEATURE: allow custom HighlightJS languages
...
Adds pluginApi function that allows themes and plugins to register languages for HighlightJS.
2019-01-02 19:07:36 -05:00
Kris
4af7471ead
Better contrast ratio match between dark and light themes
2019-01-02 17:54:22 -05:00
Jeff Wong
49fbedc445
FIX: make full height menu and cloak respect custom headers ( #6845 )
2019-01-02 14:18:14 -08:00
Sam
0c11caf796
UX: remove gray background from lighbox
...
This avoids a 3 way transition when loading images
- grey
- ultra low res
- full image
Instead we go
- ultra low res
- full image
2019-01-03 08:16:33 +11:00
Jeff Wong
e8a75628fd
Revert "FIX: make full height menu and cloak respect custom headers"
...
This reverts commit a61d9deba1
2019-01-02 11:51:03 -08:00
Gerhard Schlager
dc477d1228
FIX: "Toggle topic bump" wasn't visible for TL4 users
2019-01-02 20:16:55 +01:00
Jeff Wong
a61d9deba1
FIX: make full height menu and cloak respect custom headers
2019-01-02 11:05:44 -08:00
Gerhard Schlager
c30996129f
FEATURE: Allow TL4 users to reset bump date
2019-01-02 16:57:05 +01:00
Gerhard Schlager
e8053d6e7d
FIX: Polls didn't work in imported posts
...
Imports skip validation of posts, but polls are only created during the validation phase.
2019-01-02 15:26:57 +01:00
Vinoth Kannan
0884cd218d
UX: Add group name next to PM recipient avatar
...
Also changed group icon color and did minor refactoring
2019-01-02 15:26:42 +05:30
Sam
766e67ce57
FEATURE: introduce lossy color optimization on resized pngs
...
This feature ensures optimized images run via pngquant, this results extreme amounts of savings for resized images. Effectively the only impact is that the color palette on small resized images is reduced to 256.
To ensure safety we only apply this optimisation to images smaller than 500k.
This commit also makes a bunch of image specs less fragile.
2019-01-02 17:20:02 +11:00
Sam
14911d50a1
DEV: improve comment explaining need for favicon proxy
2019-01-02 13:15:20 +11:00
David Taylor
27ed60bad0
FIX: Quote selection in IE11
2018-12-31 13:54:05 +00:00
Arpit Jalan
70fdc10365
FEATURE: move posts to new/existing PM ( #6802 )
2018-12-31 17:17:22 +05:30
Saurabh Patel
0fca3205b5
FIX: show error msg on grant badge if message available from backend ( #6801 )
2018-12-31 10:46:39 +01:00
Arpit Jalan
1381dc603d
UX: show generic message when reloading 'activation email resent' page
2018-12-31 13:12:37 +05:30
Joe
6fb421312e
UX: aligns categories and tags in topic lists
...
History:
https://meta.discourse.org/t/minor-visual-weirdness-on-topic-listing-category-and-tags/105268
2018-12-31 14:38:33 +08:00
Joe
55d745f03b
UX: header needs a bit of padding on narrow screens
...
A bit of history
https://meta.discourse.org/t/header-on-responsive-window/105204
2018-12-31 14:33:02 +08:00
Vinoth Kannan
021f11b68e
FEATURE: Display avatars of PM recepients in small topic header when scrolling down
2018-12-30 20:10:40 +05:30
Joffrey JAFFEUX
e7cf642b1f
FIX: reports issues with ie11 ( #6828 )
2018-12-28 21:32:07 +01:00
Joffrey JAFFEUX
9a8db2748a
FIX: composer css fixes for ie11 ( #6827 )
2018-12-28 20:52:21 +01:00
Joffrey JAFFEUX
f1269fa807
FEATURE: Add Top Uploads report ( #6825 )
...
Co-Authored-By: I am very Pro-Grammer. <khalilovcmded@users.noreply.github.com>
2018-12-28 20:48:54 +01:00
Joffrey JAFFEUX
608abd4c08
FIX: uses flex: 1 0 0; instead of flex: 1; for better browser compat ( #6826 )
2018-12-28 20:21:32 +01:00
Joffrey JAFFEUX
7b15b87cf5
FIX: better left/right positioning in select-kit components ( #6824 )
2018-12-28 19:46:31 +01:00
Joffrey JAFFEUX
0f09cb50e9
FIX: less fancy pages computation for browser compatibility ( #6823 )
2018-12-28 19:07:29 +01:00
Penar Musaraj
4f6ca66df5
FIX: routeToTag mini-fix for IE11
...
skip "a.host" for IE11 since IE11 does not support URL interface
2018-12-28 11:49:51 -05:00
Penar Musaraj
fdfb7ed764
FIX: Limit previous IE SVG click event fix
...
Fixes issues with clicking SVG icons in Safari, IE11, Edge
2018-12-28 10:18:53 -05:00
Joe
74f0bd08c0
UX: removes unnecessary margin in header tag wrapper
...
This margin is not needed and doesn't exist in the mobile view.
It causes a bit of a problem in desktop topics with no categories and more prominently in PMs in the desktop view.
There's a small TODO here where the rest of the extra-info-wrapper styles should all be moved to header sylesheets.
2018-12-28 21:31:41 +08:00
Joffrey JAFFEUX
942114b34c
FIX: optimize collapse/expand select-kit codepath ( #6818 )
2018-12-27 23:38:01 +01:00
Joffrey JAFFEUX
1d62d3df6f
FIX: remove storage_stats from the list of reports, too specific ( #6817 )
2018-12-27 22:21:08 +01:00
Joffrey JAFFEUX
695894d458
FIX: delete dataset doesn’t work on safari
2018-12-27 06:49:49 +02:00
Vinoth Kannan
2b006c0429
FEATURE: Invalidate broken images cache on Rebuild HTML action
2018-12-26 23:22:07 +05:30
Vinoth Kannan
2076f371b3
FIX: Hashtags should work for non-english characters
2018-12-26 22:12:40 +05:30
Régis Hanol
5381096bfd
PERF: new 'migrate_to_s3' rake task
2018-12-26 17:34:49 +01:00
Sam Saffron
303a535dba
PERF: automatic upload size calculation not persisted
...
Previously if upload had missing width and height we would calculate
on first use BUT we (me) forgot to save this to the database
This was particularly bad on home page cause category images (when old)
miss dimensions.
2018-12-26 17:19:29 +02:00
Joffrey JAFFEUX
f637286db5
UX: improves flags-status report ( #6773 )
...
- link to post
- cover more post action types
2018-12-26 10:29:33 +01:00
Joffrey JAFFEUX
0402f0f357
UX: new site setting to define activity metrics displayed on dashboard
2018-12-26 10:29:07 +01:00
Sam Saffron
69aa8f18c2
FEATURE: allow for custom excerpt BBCODE
...
This allows fidelity in controlling excerpt (text that shows up when you pin a topic or link to it externally):
```
I am some text
[excerpt]
This is some **custom** markdown that should be the excerpt
[/excerpt]
More text
```
Previous solution relied on DIVs, unfortunately DIVs do not play well,
by design with mixing markdown unless you have a preceding newline eg:
```
<div class='hello'>
this will be treated properly as markdown
</div>
```
This extra newline is not desirable.
I am also considering adding
```
[div class=excerpt]
[/div]
```
This would offer lots of flexibility to themes and plugins that do not want the extra annoying newline.
2018-12-25 17:02:28 +02:00
Kyle Zhao
61dcd7c52c
FIX: validate YAML before save to avoid race condition
2018-12-25 15:08:17 +02:00
Arpit Jalan
1e2b81991f
fix the build
2018-12-25 10:27:51 +05:30
Jeff Atwood
a74e49c87c
use proper typographical × instead of x
2018-12-24 20:33:17 -08:00
Vinoth Kannan
a16bb32865
FIX: Do not raise error if most liked user is deleted
2018-12-25 01:04:55 +05:30
Régis Hanol
2988d281fc
DEV: group all collapsed notifications
2018-12-24 12:44:50 +01:00
Vinoth Kannan
b3df4bee9c
FIX: Hide group membership request button for existing members
2018-12-24 13:49:05 +05:30
Saurabh Patel
f4d8a330c3
Merge pull request #6761 from mrfinch/saurabh/show-popup
...
FIX:show popup before bulk invite
2018-12-21 21:36:17 +01:00
Gerhard Schlager
126be6c478
FIX: Resetting bump date shouldn't fail when first post is hidden
2018-12-21 17:43:52 +01:00
Robin Ward
0e710dc573
Improvements to Lazy Loading
...
- Now applied to all images over 150x150px
- Stores the width and height in the WeakMap rather than using
percentages for accuracy
- When oneboxed images are hidden, they are given a subtle border for better
visibility.
- Don't apply when in the composer. Causes flickering.
2018-12-21 11:31:27 -05:00
David Taylor
7feabd9e49
PERF: Eradicate N+1 queries from the theme admin page
2018-12-21 11:03:58 +02:00
Vinoth Kannan
2909e7fbdf
FIX: Subfolder path is missing in category permalinks after slug update
2018-12-21 09:29:54 +05:30
Robin Ward
a2ae67509d
Don't use getAttribute if we don't need to
2018-12-20 16:41:04 -05:00
Kris
816acc6984
Improving color contrast of $danger-low for dark themes
2018-12-20 14:46:13 -05:00
Penar Musaraj
f4d37d05c3
Merge branch 'master' of github.com:discourse/discourse
2018-12-20 11:15:26 -05:00
Penar Musaraj
28283c2396
FIX: Workaround for Edge issue with clicks on SVGs
...
- Related Edge issue at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10583086/
2018-12-20 11:13:55 -05:00
Vinoth Kannan
e7e4074856
FIX: raises an error if q param is empty in search page
2018-12-20 21:43:14 +05:30
Sam Saffron
400eea4d13
UX: show lazy loaded images while they are downloading
...
Also shows fuzzy image right away prior to it being downloaded
2018-12-20 22:04:30 +08:00
Joe
d7466156ae
UX: adds missing wizard icons
...
With our recent move to SVG icons, the font file does not work in the wizard. I've opted for path2D, which accepts an SVG path
Path2D is not supported by IE11 but the chances of admins running the wizard on IE11 are practically none.
https://caniuse.com/#feat=path2d
2018-12-20 14:55:40 +02:00
Rishabh
3d2c72dd33
UX: Switch placeholder to an SSH url if importing a private theme
2018-12-20 17:01:50 +05:30
Bianca Nenciu
a06d310855
DEV: Refactor location string builders. ( #6794 )
2018-12-20 10:23:05 +01:00
Vinoth Kannan
dc292d4598
FIX: Use one-way binding to prevent unnecessary updates in site.periods
2018-12-20 03:39:05 +05:30
Arpit Jalan
bb67ca9d21
FIX: use correct post object when logging exception
2018-12-19 22:17:37 +05:30
Arpit Jalan
1ea0cbece8
FIX: skip adding sso diagnostics if sso object is nil
2018-12-19 20:55:35 +05:30
Joffrey JAFFEUX
e655e1863f
UX: Adding reports dashboard tab, new layout, report descriptions ( #6790 )
...
Co-Authored-By: Kris <shout@k-ris.com>
2018-12-19 14:44:43 +01:00
Penar Musaraj
f5c4ab0573
Add category link renderer to plugin API ( #6787 )
...
* Add category link renderer to plugin API
- lets themes/plugins override the category link display
- planning to use this in a "category icons" theme component
* small code review fix
* Code review refactor
2018-12-19 10:26:09 +01:00
Bianca Nenciu
7050ce4638
FIX: Bypass draft check when switching to shared draft. ( #6782 )
2018-12-19 10:25:33 +01:00
Maja Komel
0ce5f05b2a
FIX: hide emails on admin user list for moderators ( #6781 )
2018-12-19 10:24:57 +01:00
Maja Komel
2fcbbead45
FIX: move sso provider into its own class so it doesn't interfere with sso client ( #6767 )
2018-12-19 10:22:10 +01:00
Bianca Nenciu
2eefe6d5d6
FIX: Use CDN for logos and icons. ( #6698 )
2018-12-19 10:20:48 +01:00
Kris
41e06efb94
Adding padding to mobile that was removed in 3710b016
2018-12-18 22:20:02 -05:00
Kris
3710b01660
Header was 16px too narrow due to border-box and padding
2018-12-18 20:38:43 -05:00
Kris
5b9c1bcf59
User page button style fix
2018-12-18 20:36:42 -05:00
Neil Lalonde
6774b64aef
FEATURE: add /conduct as an alias for /guidelines
2018-12-18 16:40:24 -05:00
Vinoth Kannan
9c6f77f9da
DEV: Remove the unique_searches column from select query
2018-12-19 02:45:48 +05:30
Robin Ward
6080e3a2c0
FIX: Broken spec
2018-12-18 14:55:09 -05:00
Robin Ward
662cfc416b
FEATURE: Show a blurry preview when lazy loading images
...
This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.
We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.
2018-12-19 01:57:30 +08:00
Robin Ward
e593d68beb
Use an options hash instead of boolean parameters
2018-12-19 01:57:30 +08:00
Rishabh
c279792130
FIX: Allow sending test e-mails to any email address when disable_email is set to non-staff ( #6792 )
2018-12-18 16:12:05 +01:00
Gerhard Schlager
32784ad11a
FIX: Disable multipart backup uploads to S3
...
Multipart upload from within the browser result in corrupt files on S3.
2018-12-18 16:01:15 +01:00
Gerhard Schlager
081aa6ad2b
UX: Use new FA5 icons on Backups tab
2018-12-18 16:01:14 +01:00
Vinoth Kannan
a313b01148
DEV: raise error if search term length is less than required
2018-12-18 20:06:59 +05:30
Vinoth Kannan
341a6bd78a
REFACTOR: Calculate CTR in SearchLog model and hide unique column ( #6791 )
2018-12-18 19:13:46 +05:30
Maja Komel
98d09c90ac
Current user serializer groups ( ef7f84b follow-up)
2018-12-18 09:05:45 +01:00
Kris
2a518c88d0
Prevent bullet badge from shrinking/growing as flex item
2018-12-17 21:05:32 -05:00
Kris
7d7b6baab9
Topic-list category width restriction no longer needed
2018-12-17 21:01:04 -05:00
Vinoth Kannan
ece44a44f8
UX: Change default date range of dashboard trending search report to a month
2018-12-18 03:00:30 +05:30
Bianca Nenciu
f0027961c7
FIX: Properly reset controller of admin-user-index. ( #6760 )
2018-12-17 15:28:29 +01:00
Bianca Nenciu
1023003eba
FIX: Strip remote url before import. ( #6762 )
2018-12-17 15:27:49 +01:00
Joffrey JAFFEUX
22cea9ce90
FIX: adusts select-kit position even if not expanded ( #6785 )
2018-12-17 12:29:51 +01:00
Joffrey JAFFEUX
6ee3900791
FIX: ensures nothing is triggering rendering loop in after render ( #6784 )
2018-12-17 12:15:03 +01:00
Gerhard Schlager
1a8ca68ea3
FEATURE: Improve backup stats on admin dashboard
...
* Dashboard doesn't timeout anymore when Amazon S3 is used for backups
* Storage stats are now a proper report with the same caching rules
* Changing the backup_location, s3_backup_bucket or creating and deleting backups removes the report from the cache
* It shows the number of backups and the backup location
* It shows the used space for the correct backup location instead of always showing used space on local storage
* It shows the date of the last backup as relative date
2018-12-17 11:35:11 +01:00
Maja Komel
040ddec63d
Fix avatar flair styles
2018-12-17 10:44:34 +01:00
Guo Xiang Tan
c0aae16f6b
FIX: Clear anon cache when disabling readonly mode.
...
`SiteSerializer#is_readonly` is cached for an anonymous user so we have
to clear the cache when disabling readonly mode. Otherwise, the site may
appear to be in readonly mode for an extended period of time.
2018-12-17 17:27:44 +08:00
Saurabh Patel
ed1a309fe4
FIX: use new key for delete topic to make it lowercased as all other buttons label around it ( #6778 )
2018-12-17 10:55:19 +08:00
Joffrey JAFFEUX
d803dfc14a
FIX: makes more resilient select-kit positioning ( #6776 )
2018-12-15 16:23:23 +01:00
Kris
6213e020e6
Improving usercard badge alignment
2018-12-14 22:16:18 -05:00
Guo Xiang Tan
e9ea0102a5
FIX: Consistency about our response for invalid user id in Admin::UsersController.
2018-12-15 08:01:35 +08:00
Neil Lalonde
ef0e84e3d9
FIX: clear the site_contact_username setting if the user's staff privileges are revoked
2018-12-14 16:52:44 -05:00
David Taylor
1960236822
FIX: Suspicious login detection ( #6772 )
2018-12-14 16:30:34 +00:00
David Taylor
9f3e2a9e34
FIX: Only serialize group membership domains for administrators ( #6771 )
2018-12-14 15:47:00 +00:00
Penar Musaraj
a19f69590a
DEV: add "topic-list-before-relative-date" plugin outlet
2018-12-14 10:39:22 -05:00
Kris
2f70bd83a3
Increase contrast of pinned excerpt for dark themes
2018-12-14 10:04:44 -05:00
Joffrey JAFFEUX
03014b0d05
FEATURE: adds security tab to dashboard ( #6768 )
...
This commit also includes the new staff_logins report
2018-12-14 13:47:59 +01:00
Maja Komel
9f89aadd33
FIX: delete all posts in batches without hijack ( #6747 )
2018-12-14 11:04:18 +01:00
Guo Xiang Tan
05104600ea
FIX: Incorrect translation key on admin search logs.
2018-12-14 17:12:33 +08:00
Kris
6553744e50
Fixing topic status alignment in search
2018-12-13 21:49:43 -05:00
Kris
6cbcd58603
Lighten lazyload placeholder background
2018-12-13 15:38:33 -05:00
Joffrey JAFFEUX
afdd244486
UX: removes superfluous posters column header ( #6765 )
2018-12-13 21:29:00 +01:00
Kris
60189e8c92
Mobile alignment fixes
2018-12-13 15:26:52 -05:00
Joffrey JAFFEUX
bcf4a17751
FIX: apply original margin-bottom to fix position placeholder ( #6764 )
2018-12-13 18:21:12 +01:00
Joffrey JAFFEUX
5cb99d08ed
FIX: define actions on connector class early ( #6763 )
...
This would prevent failure with connectors templates defining actions as closures. In this case action existence is checked at compile time and not runtime.
2018-12-13 15:43:30 +01:00
Joe
8ef2085585
UX: increase selector specificity so that "inline" lightboxes in quotes don't get backgrounds
...
When a quote is not expanded and it contains lightboxes, those lightboxes are not displayed and instead we show a link that looks like this `[image_title]`
These still have the lightbox CSS class and so they still get the backgrounds we add to lightboxes while they load. Increasing the selector specificity prevents that from happening.
2018-12-13 15:17:08 +08:00
Sam
7ee9a6a7ec
SECURITY: do not delete avatars uploads when deleting accounts
...
We rely on the clean up uploads job to do this safely
2018-12-13 16:26:07 +11:00
Sam
f74ef71130
DEV: add transaction and active check to invalidate job
...
Follows up on 3b76f19668
2018-12-13 14:59:56 +11:00
Sam
94b8ba4f8f
FIX: remove slow platform detection from server side
...
Historically due to https://meta.discourse.org/t/why-is-discourse-so-slow-on-android/8823
we decreased page sizes of both home page and topic page on android by half.
This was done on the server side and as a side effect and caused page sizes on android
to mismatch between Android and non Android.
Unfortunately about a year ago googlebot started pretending it is Android,
this cause Google to start indexing pages as what android would see. So
it saw double the amount of pages in the index as what exists on desktop.
This in turn caused double the amount of indexing work and a large amount
of broken links on long topics.
This fix removes all special behavior which is no longer needed due to
other performance work in Discourse including raw handlebars on home page
and virtual dom on topic pages.
I tested we do not need this on Blu Advance 5.0 it has 1.3 GHZ mediatec mt6580
This phone retails for around $50 USD.
If we decide long term that we want any hacks like this we will shift them
to the client side. It can just hold data in memory without rendering.
2018-12-13 13:57:05 +11:00
Kyle Zhao
92df7b212c
rename visible to visibleSiteSettings
2018-12-13 13:00:13 +11:00
Kyle Zhao
c9279a118e
FIX: always show filtered site settings
2018-12-13 13:00:13 +11:00
Neil Lalonde
3b76f19668
FIX: invalidating inactive admin emails should mark them as not active
2018-12-12 17:07:49 -05:00
Neil Lalonde
a1db15fead
FEATURE: require admins to re-validate their email addresses if they haven't been seen for a number of days, configurable with the invalidate_inactive_admin_email_after_days site setting. Social logins are also revoked. Default is 365 days.
2018-12-12 15:32:38 -05:00
Maja Komel
dbbadb5c35
FEATURE: add short_site_description setting to be included in title tag on homepage
2018-12-12 11:46:58 +01:00
Joffrey JAFFEUX
793f1274d1
FIX: makes charts more resilient to resizing ( #6758 )
2018-12-12 11:11:56 +01:00
Joffrey JAFFEUX
3a799ed922
FEATURE: Check if draft exists before starting a new one ( #6755 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: zogstrip <regis@hanol.fr>
2018-12-12 10:21:51 +01:00
Sam
0ca61242b8
FEATURE: polyfill intersection observer for IE11 / iOS Safari
...
This feature is used for defer loading of images and in future for post cloaking
This gives us a polyfill so we can safely use the feature in problem browsers
The polyfill supports "polling" but it does not appear we need it yet.
If we discover anything odd here, consider setting poll interval per:
https://github.com/w3c/IntersectionObserver/tree/master/polyfill
```
var io = new IntersectionObserver(callback);
io.POLL_INTERVAL = 100; // Time in milliseconds.
```
Keeping the mutation observer cause we often mutate the DOM
2018-12-12 15:36:08 +11:00
Kris
6d353a1e47
Alignment & spacing fix for quote controls
2018-12-11 21:17:31 -05:00
Guo Xiang Tan
86926f4aee
DEV: Let create! handle the check for persistence.
...
This is unlikely to fail but we want to know when it does.
2018-12-12 08:36:13 +08:00
Robin Ward
6797a710aa
FEATURE: Lazily Load Images as they scroll into the viewport.
...
This feature uses the Intersection Observer API
https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API
It should be compatible with all modern browsers. Non-Edge IE is *NOT*
supported, so in that particular browser images are loaded by default.
2018-12-12 10:12:49 +11:00
Jeff Wong
5358f25fc6
FIX: Support RTL languages in header menu
2018-12-11 10:33:56 -08:00
Jeff Wong
d2569f8e77
make linter happy
2018-12-11 09:41:40 -08:00
David Taylor
0f734e2ae2
FIX: Return authenticated=true when reconnecting
...
This prevents a registration popup on the client
2018-12-11 17:40:02 +00:00
Jeff Wong
71d8807fec
Full height swipe-able menus ( #6566 )
...
* Feature: Full height swipe enabled menus
support pan events on iphone
2018-12-11 09:15:20 -08:00
Gerhard Schlager
688755baf2
DEV: Improve specs and handle invalid email token
...
Follow-up to 7977b09025
2018-12-11 18:04:10 +01:00
Kris
8c227715ae
$primary-high contrast reduction for dark themes
2018-12-11 10:08:00 -05:00
Kris
4cc0a3503b
Adding space between badges for medium-sized viewports
2018-12-11 09:45:49 -05:00
David Taylor
c7c56af397
FEATURE: Allow connecting associated accounts when two-factor is enabled ( #6754 )
...
Previously the 'reconnect' process was a bit magic - IF you were already logged into discourse, and followed the auth flow, your account would be reconnected and you would be 'logged in again'.
Now, we explicitly check for a reconnect=true parameter when the flow is started, store it in the session, and then only follow the reconnect logic if that variable is present. Setting this parameter also skips the 'logged in again' step, which means reconnect now works with 2fa enabled.
2018-12-11 13:19:00 +00:00
Maja Komel
2ee2e5c981
UX: fix cropped image thumbnails
2018-12-11 12:23:39 +01:00
David Taylor
3fedb2ad20
DEV: Style and performance improvements
...
Follow-up from 9db8291
2018-12-11 09:58:20 +00:00
Sam
671469bcc7
FIX: URLs containing two # would fail to work
...
Some URLs in browsers are non compliant and contain twos `#` this commit adds
special handling for this edge case by auto encoding any fragments containing `#`
2018-12-11 18:03:13 +11:00
Sam Saffron
bb4ef644bf
UX: reduce show dismiss.. at top of unread/new to 15
...
Previously we would require 30 unread or new topic to show the button at the top.
2018-12-11 14:11:54 +11:00
Gerhard Schlager
7977b09025
FEATURE: Activate users invited via email when invite is redeemed
...
Do not send an activation email to users invited via email. They
already confirmed their email address by clicking the invite link.
Users invited via link will need to confirm their email address before
they can login.
2018-12-11 00:09:53 +01:00
Kris
73d2fc194d
UX: More consistent category lock and topic-status styles
2018-12-10 16:06:26 -05:00
David Taylor
071bd15463
FIX: Redirect to default homepage when visiting /login
...
Previously this was hard-coded to redirect to `/latest`
2018-12-10 15:39:05 +00:00
Maja Komel
ef7f84b59b
Add groups to current user serializer ( #6748 )
2018-12-10 16:23:29 +01:00
David Taylor
9db829134c
FIX: Use database to persist metadata during social registration ( #6750 )
...
Previously was using the cookie_store, which is limited to 4kb. This caused issues for providers sending large volumes of metadata about a user.
2018-12-10 15:10:06 +00:00
Joffrey JAFFEUX
e06a8980fb
FIX: category-drop initial state was incorrect ( #6743 )
2018-12-10 14:05:00 +01:00
Penar Musaraj
7f361a546e
UX: Add styling for updated twitter status icons in onebox
...
Minor adjustments needed by onebox version 1.8.69
2018-12-09 21:58:02 -05:00
Kris
c84b837d50
category badge alignment fix
2018-12-08 22:33:11 -05:00
Gerhard Schlager
0f41770547
Make Danger happy by running prettier
2018-12-08 02:59:09 +01:00
Kris
050c02228e
UX: Globally dim categories slightly
2018-12-07 20:01:38 -05:00
Penar Musaraj
67450ba402
UX: when composer is minimized, let user open composer in regular size instead of full screen
2018-12-07 17:45:13 -05:00
Jeff Wong
ccd80a8b14
update png assets for push notification images
2018-12-07 14:00:39 -08:00
Kris
b26d0f20cc
Fixing slight misalignment of login/signup buttons
2018-12-07 13:56:54 -05:00
Kris
d16a4b895f
only dim categories, not all topic stats per 547eaa6
2018-12-07 13:35:57 -05:00
Kris
98c18f8349
button and alignment fixes for mobile user page
2018-12-07 12:34:37 -05:00
Kris
547eaa6060
UX: Dim visited post info along with title
2018-12-07 11:09:56 -05:00
Rafael dos Santos Silva
efec2db859
FEATURE: Web Share Target Support
...
This adds a **very basic** support for share to Discourse.
Currently, this is only supported in Android + Chrome 71+.
After installing a Discourse site to the Home Screen, you will be
able to share from anywhere in the OS to the Discourse site.
Discourse will use the title and text from the share event.
2018-12-07 13:48:09 -02:00
David Taylor
160d29b18a
REFACTOR: Migrate TwitterAuthenticator to use ManagedAuthenticator ( #6739 )
...
No changes to functionality. TwitterAuthenticator goes from 136 lines to 24, and all twitter-specific logic elsewhere has been deleted 🎉
2018-12-07 15:39:06 +00:00
Saurabh Patel
9e3143445b
DEV:add uploaded_meta option in category for category meta image ( #6724 )
2018-12-07 16:24:07 +01:00
David Taylor
f7ce607e5d
FIX: Return 422 instead of 500 for invalid SSO signature ( #6738 )
2018-12-07 15:01:44 +00:00
David Taylor
5e09398c5b
FIX: Do not serialize user fields unless they are specified for display ( #6736 )
2018-12-07 10:57:28 +00:00
Sam
8e307e633e
FIX: posts would not auto rebake unless gravatar download was enabled
2018-12-07 17:03:22 +11:00
Kris
031c252cd3
Slight alignment follow-up to db32d29
2018-12-06 20:01:38 -05:00
Kris
db32d29eaa
UX: Refactoring topic statuses for consistent icon sizes & colors
2018-12-06 19:22:04 -05:00
Penar Musaraj
06d1b19ca2
FIX: Refactor lightbox mobile icon
...
- Fixes a performance issue on a site with lots of images in posts
- turns out that "filter: invert(100%)" performs very poorly on Safari/iPhone
- also disables transition on the element on mobile
2018-12-06 15:32:26 -05:00
Kris
b54b4d05c5
UX: improve code highlighting diffs for dark themes
2018-12-06 10:54:30 -05:00
Gerhard Schlager
4300ac0f4a
UX: Show smaller Emojis within some HTML elements
2018-12-06 15:13:16 +01:00
Xiao Guan
7ec124fc89
FEATURE: Improved deprecation warnings ( #6722 )
...
* FEATURE: Discourse.deprecate can report version
* Ember counterpart for deprecation
2018-12-06 11:38:01 +00:00
Maja Komel
1d649e147b
FEATURE: show avatar flair on group, badges and directory pages ( #6732 )
2018-12-06 12:18:52 +01:00
Gerhard Schlager
43cfdb1cb9
FIX: Wizard tries harder to find existing Welcome Topic
...
The wizard searches for:
* a topic that with the "is_welcome_topic" custom field
* a topic with the correct slug for the current default locale
* a topic with the correct slug for the English locale
* the oldest globally pinned topic
It gives up if it didn't find any of the above.
2018-12-06 10:27:22 +01:00
Guo Xiang Tan
27c793a192
FIX: `UserNotificationsHelper#logo_url' to work with S3 based uploads.
...
https://meta.discourse.org/t/digest-logo-not-working/103255
2018-12-06 09:39:08 +08:00
Guo Xiang Tan
dcf9c6da59
DEV: Don't publish post messages to non-human users.
2018-12-06 08:24:13 +08:00
Kris
a88f931d6f
UX: Moving categories under topic title in topic list, removing category column ( #6731 )
...
* Starting to remove category column from topic list
* stacked nav alignment adjustment
* Revert "stacked nav alignment adjustment"
This reverts commit 98800c7058
2018-12-05 16:12:26 -08:00
Bianca Nenciu
a8e8473ea5
DEV: Apply code review.
2018-12-05 21:58:55 +01:00
Bianca Nenciu
79d987e483
FEATURE: Show autocomplete when enable_inline_emoji_translation is true.
2018-12-05 21:58:55 +01:00
Bianca Nenciu
e9bbdef156
FEATURE: Add support for inline emoji translation.
2018-12-05 21:58:55 +01:00
Bianca Nenciu
0c88052641
UX: Wrap pre element.
2018-12-05 21:56:18 +01:00
Bianca Nenciu
b585f7f336
DEV: Apply code review.
2018-12-05 21:56:18 +01:00
Bianca Nenciu
56890efd7a
FEATURE: Add 'Advanced Test' for admin panel.
2018-12-05 21:56:18 +01:00
Bianca Nenciu
1a4f592749
FIX: Always allow admins upload selectable avatars.
2018-12-05 21:55:23 +01:00
Régis Hanol
aea2d8bbeb
FIX: properly secure poll message bus
...
Co-authored-by: Sam <sam.saffron@gmail.com>
2018-12-05 21:27:49 +01:00
David Taylor
8aff99761a
FIX: Ignore query parameters when displaying counter on internal links
...
This matches the server-side behaviour, so that the links display counters correctly
2018-12-05 18:29:54 +00:00
David Taylor
a1d9aeda8b
REFACTOR: split TopicLink#extract_from into multiple methods
...
Also rename some confusing variables
2018-12-05 18:54:30 +01:00
David Taylor
37249c9a32
FIX: Do not reset link counts when post is rebaked
...
This was an indentation mistake introduced in 44eba0b
2018-12-05 18:54:30 +01:00
Guo Xiang Tan
978f0db109
SECURITY: Require groups to be given when inviting to a restricted category. ( #6715 )
2018-12-05 16:43:07 +01:00
Vinoth Kannan
57ba4b7cb2
DEV: remove unnecessary safe nav operators ( #6730 )
2018-12-05 20:07:18 +05:30
Kyle Zhao
97e6e3b133
DEV: duplicate and unreachable code after return
2018-12-05 09:17:20 -05:00
Vinoth Kannan
fb78414229
Add missing safe navigation operator
2018-12-05 16:23:43 +05:30
Vinoth Kannan
d33d031742
FEATURE: Filter topic and post web hook events by tags ( #6726 )
...
* FEATURE: Filter topic and post web hook events by tags
* Add a spec test with unmatched tags
2018-12-05 14:44:06 +05:30
Sam
82e45f5485
FIX: method extraction caused push notifications to include incorrect post
...
Previously the push notification code path was not tested for notification
collapsing. This happens if you get multiple replies to a topic you are
watching.
2018-12-05 16:40:10 +11:00
Vinoth Kannan
ec26a59eac
FIX: variable name typo in subcategory image
2018-12-05 10:41:06 +05:30
Kris
e0aac75607
Restrict width of category heading to prevent mobile overflow
2018-12-04 19:01:27 -05:00
Kris
28ddaf80d2
Adding max-width to category logos
2018-12-04 13:01:27 -05:00
Régis Hanol
3c9c95ac83
Update Rubocop to 0.60
2018-12-04 10:48:16 +01:00
Joe
72bd388ff7
UX: truncate long topic tiles to prevent badges and date from wrapping
2018-12-04 15:27:23 +08:00
Sam
aa97f6fdba
FEATURE: disable notifications for small actions that are whispers
...
Previously we would notify on small actions if they were whispers
this inconsistently lead to all sorts of problems including
- collapsed "N replies" after assign
- empty push notifications
New behavior adds an api to explicitly send push notifications as well
if needed: create_notification_alert
2018-12-04 17:54:42 +11:00
Sam
5c17e46274
FEATURE: allow advanced specification of excerpts for posts
...
Previously users could control excerpt with `<span class='excerpt'>`
in Markdown, this is somewhat limited for plugins that need to define this
across a section. This adds support for DIV as well
2018-12-04 15:13:34 +11:00
David Taylor
9248ad1905
DEV: Enable Style/SingleLineMethods and Style/Semicolon in Rubocop ( #6717 )
2018-12-04 11:48:13 +08:00
Penar Musaraj
56948896ff
UX: replace FA5 compress/expand icons
...
Adds a new SVG sprite file that contains non-FontAwesome 5 icons to our subset.
Adds the FontAwesome 4.7.0 icons for expand / collapse.
2018-12-03 22:29:20 -05:00
Penar Musaraj
923692d45a
FIX: tooltip regression in admin dashboard
...
- adds registerHoverTooltip in tooltip qunit test
2018-12-03 11:15:31 -05:00
Penar Musaraj
f8e6a37858
FIX: raise exception when getting dimensions of missing image
...
- follow-up on 0eacd45ab1
2018-12-03 10:19:49 -05:00
Maja Komel
142361d6da
FIX: don't steal focus when text in editor is replaced ( #6712 )
2018-12-03 09:49:17 +01:00
Guo Xiang Tan
125bb46052
Remove unused constant in the codebase.
2018-12-03 11:04:47 +08:00
Sam
cc04c86859
UX: do not restrict width of category image, only height
...
This was a recent visual regression which caused a fair amount of pain.
Previously we only restricted height
2018-12-03 09:35:16 +11:00
Sam
236c755d62
FIX: do not store key tracking last seen time indefinitely
...
UserStat has some special logic to keep adding time read if repeat calls
are made in intervals less than 100 seconds. This is called regularly
when we update read timings on a topic.
We only need to cache this key in redis for 100 seconds, however previously
we would keep it forever, 1 key per user. This has potential of bloating
a very large amount of keys for no longer active users in redis.
2018-12-03 08:35:26 +11:00
Kris
26e9b628b8
post-infos alignment fix
2018-11-30 21:31:36 -05:00
Kris
a113777003
Extra margin isn't needed on mobile
2018-11-30 19:49:26 -05:00
Penar Musaraj
bbd33de05b
FIX: lightbox expand icon on mobile
2018-11-30 14:35:45 -05:00
Kyle Zhao
488fba3c5f
FEATURE: allow plugins and themes to extend the default CSP ( #6704 )
...
* FEATURE: allow plugins and themes to extend the default CSP
For plugins:
```
extend_content_security_policy(
script_src: ['https://domain.com/script.js ', 'https://your-cdn.com/ '],
style_src: ['https://domain.com/style.css ']
)
```
For themes and components:
```
extend_content_security_policy:
type: list
default: "script_src:https://domain.com/ |style_src:https://domain.com "
```
* clear CSP base url before each test
we have a test that stubs `Rails.env.development?` to true
* Only allow extending directives that core includes, for now
2018-11-30 09:51:45 -05:00
Penar Musaraj
7dec963f2e
FIX: add vkontakte icon alias
2018-11-30 08:50:38 -05:00
David Taylor
208005f9c9
REFACTOR: Migrate FacebookAuthenticator to use ManagedAuthenticator
...
Changes to functionality
- Removed syncing of user metadata including gender, location etc.
These are no longer available to standard Facebook applications.
- Removed the remote 'revoke' functionality. No other providers have
it, and it does not appear to be standard practice in other apps.
- The 'facebook_no_email' event is no longer logged. The system can
cope fine with a missing email address.
Data is migrated to the new user_associated_accounts table.
facebook_user_infos can be dropped once we are confident the data has
been migrated successfully.
2018-11-30 11:18:11 +00:00
David Taylor
534e1b1b18
DEV: Introduce Auth::ManagedAuthenticator
...
A generic implementation of Auth::Authenticator which stores data in the
new UserAssociatedAccount model. This should help significantly reduce the duplicated
logic across different auth providers.
2018-11-30 11:18:11 +00:00
Arpit Jalan
059e36a6ff
FIX: log name changes only when the name is actually updated
2018-11-30 15:30:46 +05:30
Guo Xiang Tan
eecd1a7d8c
FIX: Jobs::CleanUpUploads fails when value of upload data_type is an empty string.
2018-11-30 10:46:39 +08:00
Penar Musaraj
0eacd45ab1
FIX: refactor ImageSizer.resize
...
reverts 140d9c2
2018-11-29 15:28:45 -05:00
Penar Musaraj
140d9c2910
FIX: call ImageSizer only if width/height are available
2018-11-29 15:03:02 -05:00
Arpit Jalan
40f10855c6
FIX: defer flags (only) when handling a flag and deleting replies ( #6702 )
2018-11-29 22:44:18 +05:30
Maja Komel
4a8f21d387
FIX: prevent minimum_required_tags on category being set to null ( #6703 )
...
* FIX: prevent minimum_required_tags on category being set to null
* add migration for NOT_NULL constraint for minimum_required_tags
* add specs
2018-11-29 18:10:14 +01:00
Penar Musaraj
5b6c1b1670
SCSS refactoring
...
followup on c388cac
2018-11-29 12:02:11 -05:00
Joffrey JAFFEUX
4f24d7dec8
FIX: more resilient whisper state between composer states ( #6687 )
2018-11-29 16:16:34 +01:00
Joffrey JAFFEUX
8da8f5d0f7
FIX: call onSelect plugin callbacks for noop rows ( #6682 )
2018-11-29 15:56:19 +01:00
Joffrey JAFFEUX
4c7dfed32e
FIX: error with tags enabled and no tags created ( #6701 )
2018-11-29 10:39:09 +01:00
Guo Xiang Tan
ffdacba219
Remove extra apple-touch-icon link in head.
...
The sizes attribute does not make a difference because both
image provided is of the same size.
2018-11-29 15:24:52 +08:00
Vinoth Kannan
5db50d6cdc
UX: Use aspect ratio to calculate width and height precisely
...
Followup on 1da265d
2018-11-29 09:32:03 +05:30
Penar Musaraj
c388cacb81
UX: Style group flair in /groups same as in topic avatars
2018-11-28 16:02:49 -05:00
Penar Musaraj
6568832235
FIX: map discord/patreon FA5 icons for login buttons correctly
2018-11-28 14:36:36 -05:00
Kris
6027e7ba3d
FIX: Restrict logo width for small screens
2018-11-28 13:27:56 -05:00
Saurabh Patel
55945ec7c8
FIX: throw error when link in reason for grant badge is an external link ( #6690 )
2018-11-28 18:01:41 +01:00
Gerhard Schlager
e7b76b319a
FEATURE: Setting for short title used by Android on homescreen
2018-11-28 14:59:30 +01:00
Saurabh Patel
49c3cf9c75
UX: Topic stats were hard to translate
2018-11-28 14:25:22 +01:00
Arpit Jalan
851ef14096
Revert "FIX: do not agree flags by default when deleting posts"
...
This reverts commit cb6fc8057b
2018-11-28 10:21:11 +05:30
Arpit Jalan
654d7996ae
FIX: title was repeating on about page
2018-11-28 08:06:14 +05:30
Sam
912a7105d2
DEV: polyfill Object.values and use where needed
...
We now have polyfills for `values` IE and `entries` IE
This commit uses values where appropriate to eliminate an extra lookup
This simplifies the code a bit.
Followup to: 7f089f07a7
2018-11-28 10:07:05 +11:00
Sam
3cb88bc566
DEV: Run file through prettier
...
We only alert on .js.es6 this is a js file so it is bypassed
2018-11-28 10:03:54 +11:00
Arpit Jalan
bdb1268528
FIX: static page title should be consistent on client side and server side
2018-11-27 22:03:52 +05:30
Joffrey JAFFEUX
7f089f07a7
FIX: better fix for #ca84c06 ( #6684 )
2018-11-27 16:12:07 +01:00
David Taylor
f993aca363
FIX: Fix editing built-in badges after removing _.include
...
We want to send the unprotected fields to the server. Corrects 4c8cfe0f
2018-11-27 15:01:02 +00:00
Joffrey JAFFEUX
ca84c06c59
FIX: revert to using _.each ( #6683 )
...
Should be replaced with Object.keys variation when reproducible
2018-11-27 15:55:56 +01:00
Kris
964fd983b7
z-index fix for tooltips within posts
2018-11-27 09:49:34 -05:00
Maja Komel
a2bff038e8
FIX: set overridden param for customize site text query only when checkbox value changes
2018-11-27 14:29:48 +01:00
Maja Komel
a0fca2b6ed
FIX: popular posts font weight in summary email
2018-11-27 12:58:28 +01:00
Gerhard Schlager
886ef7251d
REFACTOR: Simplify extraction of mentions
2018-11-27 12:46:02 +01:00
Guo Xiang Tan
c92c56d986
FIX: Randomly failing QUnit test.
...
The `post` variable can be an actual post object or a `new Placeholder("post-placeholder")` which does not define the function `get`.
* QUNIT_SEED=11414431645131211212599424733847938795
2018-11-27 16:00:46 +08:00
Guo Xiang Tan
a1e77aa2ed
FEATURE: Reimplement SiteSetting.max_oneboxes_per_post. ( #6668 )
...
Previously, the site setting was only effective on the client side of
things. Once the site setting was been reached, all oneboxes are not
rendered. This commit changes it such that the site setting is respected
both on the client and server side. The first N oneboxes are rendered and
once the limit has been reached, subsequent oneboxes will not be
rendered.
2018-11-27 16:00:31 +08:00
Arpit Jalan
6cb49cd42c
Merge pull request #6671 from techAPJ/destroy-posts-flags
...
FIX: do not agree flags by default when deleting posts
2018-11-27 11:27:23 +05:30
Arpit Jalan
cb6fc8057b
FIX: do not agree flags by default when deleting posts
2018-11-27 10:57:20 +05:30
Dan Ungureanu
38e29d8c94
DEV: Fix coding style.
2018-11-27 13:05:27 +11:00
Dan Ungureanu
d657ce844b
DEV: Call onClose for closing modals.
2018-11-27 13:05:27 +11:00
Dan Ungureanu
0005bded6c
DEV: Added composer-action-after plugin outlet.
2018-11-27 13:05:27 +11:00
Dan Ungureanu
1f9f00a629
DEV: Add data-topic-id to more elements containing titles.
2018-11-27 13:05:27 +11:00
Dan Ungureanu
8837fe47d7
DEV: Add app event triggered when composer's reply is reloaded.
2018-11-27 13:05:27 +11:00
Dan Ungureanu
b65e5d263e
DEV: Add a plugin outlet for top-side notices.
2018-11-27 13:05:27 +11:00
Vinoth Kannan
1da265db11
UX: category images have no sizes ( #6662 )
2018-11-27 08:40:06 +08:00
Penar Musaraj
03deda2147
Upgrade to FontAwesome 5 (take two) ( #6673 )
...
* Add missing icons to set
* Revert FA5 revert
This reverts commit 42572ff
2018-11-26 16:49:57 -05:00
Joffrey JAFFEUX
818761c3a4
FIX: uses appropriate z-index for tooltips ( #6674 )
2018-11-26 22:47:12 +01:00
Gerhard Schlager
5640166b27
FIX: Notify only invited users about mentions in PMs
2018-11-26 22:42:56 +01:00
Kris
593cd831e1
Wrap long lists of admin tabs on large screens
2018-11-26 14:51:45 -05:00
Robin Ward
8bca2647ea
FIX: Upwards scrolling occasionally broken
...
This fixes a bug in Chrome where upwards scrolling would occasionally
not work properly.
2018-11-26 13:37:12 -05:00
Penar Musaraj
2e4706b787
FIX: bug and typo in admin user badges
2018-11-26 10:24:46 -05:00
Joffrey JAFFEUX
3453707784
FEATURE: allows html tooltips ( #6665 )
2018-11-26 11:15:23 +01:00
Joffrey JAFFEUX
e47b478b83
DEV: removes _.toArray from codebase ( #6654 )
2018-11-26 11:15:05 +01:00
Guo Xiang Tan
0972516abe
FIX: Incorrect "rel" used for apple icons in <head>.
...
Nothing on the web I can find suggests that this should have been `rel=icon`.
See https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html
2018-11-26 10:40:09 +08:00
Guo Xiang Tan
d4aaa968bb
Fix linting.
2018-11-26 09:38:22 +08:00
Guo Xiang Tan
57e2f4990d
PERF: Move processing of inline onebox out of V8 context. ( #6658 )
2018-11-26 09:21:38 +08:00
Penar Musaraj
93d4281706
FIX: alignment issue in PM inbox when bulk selecting
2018-11-25 15:24:26 -05:00
Arpit Jalan
b5bf182ad5
FIX: validate topic deletion when acting on a flag
2018-11-25 23:24:03 +05:30
Bianca Nenciu
172b3bf4d3
FIX: Fix broken theme field URLs. ( #6622 )
2018-11-23 16:11:05 +01:00
Joe
336436dfb4
UX: better handling of logo size
2018-11-23 22:04:42 +08:00
Joe
e2214b50f3
UX: add height attribute to logo on error pages
...
This matches what we do in the home-logo widget. The height is set as an attribute and we use CSS to get a scaled width that preserves the aspect ratio of the image.
2018-11-23 15:04:34 +08:00
Guo Xiang Tan
a1888b301b
DEV: Don't require login for QUit test path.
2018-11-23 13:50:19 +08:00
Joe
98354bd34c
fix the build
2018-11-23 11:27:59 +08:00
Joe
c4fca36255
FIX: don't trigger header:hide-topic at the bottom on desktops
...
On mobile we trigger `header:hide-topic` at the very bottom of topics to switch the header contents back from small logo + topic info to large logo + user panels.
Given that the `topic-progress` component is sometimes loaded on desktop - E.g composer is open or on narrow desktop screens - we need a guard to prevent this logic from firing on desktops.
2018-11-23 10:14:13 +08:00
Joffrey JAFFEUX
f4432648fd
FIX: categories/delete_categories can be undefined ( #6657 )
2018-11-23 00:57:18 +01:00
David Taylor
f645cb9c14
FEATURE: Use translated name for 'your email has been authenticated by' ( #6649 )
2018-11-22 19:12:04 +00:00
Joffrey JAFFEUX
7e20a0b917
DEV: removes _.indexOf from codebase ( #6652 )
2018-11-22 17:38:58 +01:00
David Taylor
0083eec686
FEATURE: Allow logo URLs to be overridden easily using reopenWidget()
2018-11-22 16:29:12 +00:00
Joffrey JAFFEUX
56478166e5
FIX: broken badge groupings modal UI ( #6653 )
2018-11-22 17:09:45 +01:00
Joffrey JAFFEUX
2843944315
FIX: better alignment of badge selector and edit btn ( #6651 )
...
Input located at /admin/badges/new
2018-11-22 16:21:15 +01:00
Joffrey JAFFEUX
e77cc44f07
FIX: better alignment of groups header filters ( #6650 )
...
This is located at the top of the /groups page.
2018-11-22 16:18:02 +01:00
Kyle Zhao
80398d0b8f
Extract inline JS on embedded comments ( #6645 )
...
* use the meta refresh tag instead
* extract inline JS in embedded comment
2018-11-22 10:02:58 -05:00
David Taylor
1fd0787dd7
UX: Ensure unstyled .btn-social elements have a contrasting background
...
For example, in plugins where the background color is not explicitly set
2018-11-22 15:00:32 +00:00
Gerhard Schlager
2ef16e9f4e
FIX: Failed to delete post belonging to non-existent topic
2018-11-22 15:08:37 +01:00
Arpit Jalan
60941f214c
FIX: remove unneeded keys from failed response
2018-11-22 14:59:50 +05:30
Guo Xiang Tan
3f636b2d19
FIX: Check whether group is mentionable by user when cooking post.
2018-11-22 16:16:33 +08:00
Vinoth Kannan
036790d13c
FIX: Assign default value for category.findByIds method
2018-11-22 12:51:04 +05:30
Guo Xiang Tan
6111b285d9
DEV: Remove comment that links to a private topic.
...
Not going to be useful for other developers.
2018-11-22 14:55:02 +08:00
Guo Xiang Tan
c5a70eca6e
PERF: Move mention lookups out of the V8 context. ( #6640 )
...
We were looking up each mention one by one without any form of caching and that results
in a problem somewhat similar to an N+1. When we have to do alot of DB
lookups, it also increased the time spent in the V8 context which may
eventually lead to a timeout. The change here makes it such that mention lookups only does a single
DB query per post that happens outside of the V8 context.
2018-11-22 14:28:48 +08:00
Guo Xiang Tan
ba280f9cf3
FIX: Give up migrating url site setting if endpoint doesn't return data.
2018-11-22 12:16:52 +08:00
Guo Xiang Tan
a8603e04ab
FIX: Give up migration of URL site settings if there is an SSL error.
2018-11-22 12:14:27 +08:00
Kyle Zhao
8e32aa1483
FEATURE: show post approvals in Moderation History ( #6643 )
2018-11-22 10:22:23 +08:00
Joe
ee6c0170ce
FEATURE: Scroll-based logo on mobile ( #6632 )
2018-11-21 21:21:49 -05:00
Saurabh Patel
d984323e23
FEATURE: Show change name of user in staff logs ( #6647 )
...
https://meta.discourse.org/t/admins-changing-users-name-not-username-should-be-logged/99511
2018-11-22 10:13:02 +08:00
Kris
0381e99b71
UX: improving theme upload modal alignment, markup
2018-11-21 16:50:49 -05:00
Joffrey JAFFEUX
58c795ef30
DEV: adds test for image-short-url ( #6642 )
2018-11-22 07:48:52 +11:00
Arpit Jalan
61eff22b29
FIX: raise Discourse::NotFound unless the user is present
2018-11-21 10:57:42 +05:30
Arpit Jalan
10cc698df3
FIX: respond with proper error message if user not found
2018-11-21 10:47:37 +05:30
Arpit Jalan
539f1c6252
FIX: raise Discourse::NotFound unless the topic is present
2018-11-21 09:48:38 +05:30
Guo Xiang Tan
f4020d9134
UX: Contain site setting uploads within the div.
2018-11-21 10:09:53 +08:00
Sam
0a86ef69bb
FIX: browser infinite recursion when editing post
...
This was a result of:
c4ed353faehttp://api.jquery.com/map/
So you need to convert it to an array prior to mapping
2018-11-21 12:51:14 +11:00
Sam
20268385a5
FIX: never attempt to log invalid post numbers
...
Previously in some cases we would queue logging of invalid post numbers
The impact would be we would miss logging an incoming link and would leak
an error.
2018-11-21 11:58:47 +11:00
Guo Xiang Tan
df72674f24
Warn when migrate url site settings job encounters an error.
2018-11-21 07:55:50 +08:00
Kris
17bc21abff
trashing an empty wrapper
2018-11-20 15:42:18 -05:00
Kris
17f3080d01
UX: More consistent category setting layout
2018-11-20 15:16:17 -05:00
Arpit Jalan
5951e111ad
FIX: handle nil topic value when removing allowed users
2018-11-20 22:55:39 +05:30
Arpit Jalan
22a7f1e7f2
FIX: handle nil user value on password reset
2018-11-20 21:49:47 +05:30
Joffrey JAFFEUX
9672c92045
DEV: removes _.each from codebase ( #6629 )
2018-11-20 14:46:58 +01:00
Guo Xiang Tan
81b3bdaabd
FIX: Remove site settings override for deprecated url site settings.
2018-11-20 11:42:39 +08:00
Kris
d1e50b3f8e
Remove condensed suggested topics, hide secondary table head
2018-11-19 11:26:21 -05:00
Joffrey JAFFEUX
86dafc1f25
DEV: removes _.reduce from codebase ( #6628 )
2018-11-19 13:04:57 +01:00
Joffrey JAFFEUX
0a8227d19c
DEV: removes _.some from codebase ( #6627 )
2018-11-19 12:32:51 +01:00
Joffrey JAFFEUX
e860c8b844
FIX: adds support for missing reports from old dashboard ( #6624 )
2018-11-19 12:20:05 +01:00
Joffrey JAFFEUX
4c8cfe0f29
DEV: removes _.include from codebase ( #6620 )
2018-11-19 12:08:54 +01:00
Joffrey JAFFEUX
b1727537b2
DEV: removes _.find from codebase
2018-11-19 11:46:26 +01:00
Joffrey JAFFEUX
30e0d744db
DEV: removes _.delay from codebase ( #6619 )
2018-11-19 10:47:00 +01:00
Joffrey JAFFEUX
c4ed353fae
DEV: removes _.map from codebase ( #6616 )
2018-11-19 10:46:46 +01:00
Joffrey JAFFEUX
907cf3ee2f
DEV: replaces setTimeout by Ember.run.later ( #6618 )
2018-11-19 10:46:38 +01:00
Bianca Nenciu
f2c227432c
FIX: Do not show nested user cards. ( #6621 )
2018-11-19 10:01:22 +01:00
Joe
2ac952d7dd
UX: leave room for floated radio input on mobile
2018-11-19 15:10:52 +08:00
Guo Xiang Tan
fe131c5ea2
Fix missing avatars on topic list page.
...
Introduced in b50fab2d72
2018-11-19 14:55:41 +08:00
Joe
94c724fb89
UX: fixes display issues in split to existing topic modal
2018-11-19 13:12:42 +08:00
Guo Xiang Tan
9fd704735e
Rescue from SocketError in migrate url onceoff job.
2018-11-19 13:07:34 +08:00
Guo Xiang Tan
b50fab2d72
PERF: Fix N+1 for non-staff users when tagging is enabled.
2018-11-19 12:53:58 +08:00
Sam
6aea185ab4
FEATURE: plugin outlets on about page
...
Added about-after-admins and about-after-moderators
2018-11-19 10:12:44 +11:00
Robin Ward
e37c4a4525
FIX: Don't show the Quote popup if posting is disabled
2018-11-16 11:00:22 -05:00
Guo Xiang Tan
9e86b425bc
FIX: Job to clean up old URL settings when new setting has been set.
...
Related to 44391ee8ab
2018-11-16 09:33:31 +08:00
Kris
9157fdd69c
UX: Better related messages condensed layout
2018-11-15 20:21:22 -05:00
Sam
f2afb69f72
Revert "UX: maintain aspect ratio of cropped image thumbnails"
...
This reverts commit e7fa4c5dd1
2018-11-16 11:38:04 +11:00
Kyle Zhao
7cb6082f91
FIX: S3 CDN for markdown it bundle
2018-11-15 16:55:20 -05:00
Kris
817135fbbf
Show related messages before suggested
2018-11-15 16:32:35 -05:00
Joffrey JAFFEUX
078705bcc0
minor refactoring ( #6615 )
2018-11-15 21:41:05 +01:00
Joffrey JAFFEUX
dcc6527dff
FIX: s/save/finish for wizard exit early button ( #6614 )
2018-11-15 21:26:26 +01:00
Joffrey JAFFEUX
1730e0bc73
UX: shows a save changes for intermediate steps ( #6612 )
2018-11-15 20:44:19 +01:00
Vinoth Kannan
d5df746cc3
UX: Improve category reordering functionality
2018-11-16 00:52:10 +05:30
Kyle Zhao
5f754b43f1
extract inline onpopstate handler on 404 page ( #6613 )
2018-11-15 13:35:38 -05:00
Kris
f0760908e3
Missing space between class names
2018-11-15 12:17:37 -05:00
Kris
5a542327e7
IE11 Fix: Select-kit items shouldn't have flex-grow
2018-11-15 10:09:49 -05:00
Joffrey JAFFEUX
9911a41f4c
FIX: improves category/tag drops header shortcuts ( #6610 )
...
- wont appear when filtering
- can now be selected with keyboard
- fix bugs on click with safari/firefox
2018-11-15 15:21:40 +01:00
Vinoth Kannan
fdccfcfa59
FIX: Only use blockquote which is immediate child of aside
2018-11-15 18:07:16 +05:30
Joe
e7fa4c5dd1
UX: maintain aspect ratio of cropped image thumbnails
2018-11-15 20:24:56 +08:00
Guo Xiang Tan
901611cb4e
Fix migrate upload url site settings to rescue from invalid URLs.
2018-11-15 15:16:14 +08:00
Sam
6556a87629
FIX: only check for conflict on edit drafts
...
In some unknown cases non edit drafts are being checked for conflict
2018-11-15 13:14:07 +11:00
Guo Xiang Tan
ee60ecc71f
UX: Switch to neutral background color for image uploader in site settings.
2018-11-15 08:24:50 +08:00
Joffrey JAFFEUX
761003c8bd
FIX: makes sure an hex is always at 6 chars ( #6608 )
...
eg: #aaa should be converted to #aaaaaa
2018-11-15 00:52:47 +01:00
Régis Hanol
1c678c8c54
This should not have been removed
2018-11-14 23:23:02 +01:00
Régis Hanol
0f5aeab003
DEV: enable no-alert & no-console eslint rules
2018-11-14 23:17:56 +01:00
Kris
6a990d4f95
Removing overly-specific style
2018-11-14 16:37:46 -05:00
Leo McArdle
7bc121a065
allow CSP reports to be sent when header isn't set by Discourse ( #6594 )
2018-11-14 16:23:29 -05:00
Régis Hanol
4bac77800a
DEV: remove 'console.log' (cc @eviltrout)
2018-11-14 21:45:41 +01:00
Maja Komel
c701036034
FIX: reset bump date resets bumped_at to the last regular post in topic ( #6605 )
2018-11-14 18:56:22 +01:00
Régis Hanol
20899654aa
Make code prettier 💅
2018-11-14 17:57:22 +01:00
Régis Hanol
c78dcde973
FIX: only send originalText when we need to
2018-11-14 17:47:59 +01:00
Kris
1e15c16f77
UX: Condense layout when suggested and related messages are available
2018-11-14 11:01:50 -05:00
Robin Ward
ea075fa4f7
FIX: Don't hide information from the card that is visible in the topic
...
It doesn't make sense to show less information on the card than already
visible.
2018-11-14 09:56:31 -05:00
Guo Xiang Tan
5b320e6652
DEV: Don't warn about using deprecated site settings in clean up uploads job.
2018-11-14 20:58:06 +08:00
Guo Xiang Tan
df111259fe
More URL site settings into a onceoff job.
...
* Doing it in a post migration was a bad idea
because the migration will fail if the site
is down while trying to download uploads
which points to the instance. This mainly
affects self-hosters using `discourse_docker`
where `./launcher rebuild` will take the
existing container down.
2018-11-14 20:29:20 +08:00
Bianca Nenciu
fce0a0ccc8
FEATURE: Compute distance between logins to generate login alerts. ( #6562 )
2018-11-14 13:26:47 +01:00
Penar Musaraj
f6fb079129
Disable wizard invites step when local_logins are turned off
2018-11-14 13:05:32 +01:00
Bianca Nenciu
34e4d82f1a
FEATURE: Report edit conflicts when saving draft. ( #6585 )
2018-11-14 12:56:25 +01:00
Vinoth Kannan
d078808144
UX: Use header top to calculate docking position
2018-11-14 16:31:39 +05:30
Guo Xiang Tan
2220345a8b
Fix the build.
2018-11-14 17:32:32 +08:00
Guo Xiang Tan
72370b9c36
Add deprecation warnings for url based site settings.
2018-11-14 16:09:26 +08:00
Guo Xiang Tan
44391ee8ab
FEATURE: Upload Site Settings. ( #6573 )
2018-11-14 15:03:02 +08:00
David Taylor
17bc82765b
FEATURE: Log password changes in UserHistory ( #6600 )
2018-11-14 08:32:42 +08:00
Kyle Zhao
38a9bc740d
FIX: change title when primary group changes ( #6602 )
2018-11-14 08:28:41 +08:00
Robin Ward
fc9aafaa6a
New outlet above the main container
2018-11-13 14:34:20 -05:00
Robin Ward
467be59d75
FEATURE: Allow expanded posts to return user custom fields
2018-11-13 12:44:54 -05:00
Kris
1570b01184
IE11 select-kit fix
2018-11-13 11:21:19 -05:00
Kris
c09a407f65
composer alignment fixes
2018-11-13 11:12:58 -05:00
Kris
af6569c396
Mobile group page flair alignment
2018-11-13 10:29:16 -05:00
Joffrey JAFFEUX
7fa21ce199
UX: minor tweaks to theme components selection UI ( #6596 )
2018-11-13 14:57:50 +01:00
Joffrey JAFFEUX
c1e82e7442
FIX: category row title ( #6597 )
2018-11-13 13:35:45 +01:00
Joe
ac7b058849
UX: take custom markup into account when docking header
2018-11-13 14:47:12 +08:00
Sam
80ceb57c76
DEV: add API endpoint to destroy_timings only of last post
...
Previously API only allowed you to nuke all timings from a topic,
new API is less punishing and allows you just to remove 1 post.
2018-11-13 16:07:48 +11:00
Joe
7707e42441
DEV: moves print-specific styles from internal style tag to external print sheet ( #6581 )
...
* DEV: removes internal styles from print view
* DEV: adds styles to print sheet
2018-11-13 14:45:55 +11:00
Guo Xiang Tan
7b44339529
FIX: Prevent uploads used in site settings from being deleted.
2018-11-13 09:15:16 +08:00
Kris
27ce8cf851
UX: Improving group directory layout for small screens
2018-11-12 18:13:42 -05:00
Kyle Zhao
d25ae13f0f
FIX: stricter window.opener checks ( #6578 )
2018-11-13 09:56:31 +11:00
Robin Ward
0cb33d2b52
UX: Rename Most Disagreed Flaggers report to "User Flagging Ratio"
2018-11-12 16:23:37 -05:00
Vinoth Kannan
dda1824270
Use hijack in inline onebox controller
2018-11-13 02:39:20 +05:30
Vinoth Kannan
44d95ad5ab
FIX: Cache url data for failed inline oneboxes
2018-11-13 01:44:20 +05:30
Kris
486d7f2e5d
Select-kit dropdown fix
2018-11-12 12:21:54 -05:00
David Taylor
ba00fcc371
FIX: Translation improvements for unused tags ( d89ffbe)
2018-11-12 16:36:56 +00:00
David Taylor
d89ffbeffd
FEATURE: Add button to delete unused tags ( #6587 )
...
This is particularly useful if you have uploaded a CSV file, and wish
to bulk-delete all of the tags that you uploaded.
2018-11-12 16:24:34 +00:00
Bianca Nenciu
5af9a69a3b
FIX: Do not check for suspicious login when impersonating. ( #6534 )
...
* FIX: Do not check for suspicious login when impersonating.
* DEV: Add 'impersonate' parameter to log_on_user.
2018-11-12 15:34:12 +01:00
Maja Komel
012da86a07
FIX user directory time period count ( #6586 )
2018-11-12 15:30:05 +01:00
Joffrey JAFFEUX
599ab4e966
UX: inform users old dashboard is going to b removed ( #6592 )
2018-11-12 15:20:00 +01:00
Joffrey JAFFEUX
9c616e0679
FIX: handles not found reports in bulk loading ( #6582 )
2018-11-12 13:47:24 +01:00
Gerhard Schlager
7c4d4331bc
FEATURE: Better handling of quotation marks in site text search
...
It also matches 3 dots with the ellipsis symbol.
2018-11-12 13:26:41 +01:00
Guo Xiang Tan
c7377e2f2d
UX: Trash icon displaying when there is no upload take 2.
2018-11-12 16:19:17 +08:00
Guo Xiang Tan
d50f4fdd7a
Oops.
2018-11-12 16:07:33 +08:00
Guo Xiang Tan
10c6211cdf
UX: Trash icon displaying when there is no upload.
2018-11-12 16:06:32 +08:00
Sam
d1684a1652
PERF: avoid left joins and distinct on posts_for query
...
Previously this was extremely expensive due to the `distict` and
`left join` clauses, this eliminates it and makes query much faster
2018-11-12 13:26:41 +11:00
Sam
e17a13ce19
FEATURE: additional "related messages" section
...
This splits out previous message correspondence from suggeted and instead
has a dedicated section called "related messages"
2018-11-12 13:04:42 +11:00
David Taylor
c3c9299c44
FIX: Improve performance for Group.posts_for ( #6588 )
2018-11-12 08:44:20 +08:00
Kris
cee1f5b2c1
Remove unneeded color assignment from user profile
2018-11-09 18:42:19 -05:00
Kris
00ad6e8e37
signup width fix
2018-11-09 12:10:38 -05:00
Joffrey JAFFEUX
f8838ac9cd
FIX: fix/removes broken elements of old dashboard
2018-11-09 17:18:19 +01:00
David Taylor
9ddd40df13
FIX: Fix vertical scrolling in modals
...
Partially reverts 57af43b
2018-11-09 14:35:29 +00:00
Arpit Jalan
1151c093ad
bump onebox version
...
- Better Google Photos oneboxing
2018-11-09 15:44:06 +05:30
Sam
64d9be726f
the protection I placed was in the wrong path moved to /session/sso
...
correct previous commit
2018-11-09 17:18:01 +11:00
Sam
3ae4fcd1f7
Improve redirect avoidance for /sso paths
...
e6b3310577
2018-11-09 17:03:58 +11:00
Sam
e6b3310577
FIX: never redirect back to /sso it will cause a loop
...
If for any reason our return url is set to `/sso` bypass using it
for login redirect
2018-11-09 14:27:36 +11:00
Sam
15991677d4
FIX: ensure we never cache login redirects by mistake
2018-11-09 11:14:35 +11:00
Gerhard Schlager
24e5be3f0c
FIX: Relative links in translations should work with subfolder
2018-11-08 23:31:05 +00:00
Robin Ward
242a5fc5ef
Add DiscourseEvents for when users as unsuspended/unsilenced
2018-11-08 16:33:38 -05:00
Kris
667af9debd
height fix
2018-11-08 16:06:41 -05:00
Kris
57af43b142
UX: Make long sign-up forms scrollable in modal
2018-11-08 15:25:10 -05:00
Kris
1a96556f38
stacked nav archive alignment adjustment
2018-11-08 12:49:29 -05:00
Kris
b39d949a8e
fix d-editor height for user profile input
2018-11-08 11:28:58 -05:00
Sam
42572ff138
Revert font awesome 5 changes
...
We are still pushing ahead on this 100% just need a bit longer to prepare
all plugins
2018-11-08 16:12:18 +11:00
Penar Musaraj
09dc922b3b
Fix several FontAwesome 5 issues
...
add missing icons, update SvgSprite methods (to fix ruby 2.4 issues), update whisper icon in composer, fix alignment issues
2018-11-07 22:20:53 -05:00
David Taylor
37fb8fc0e7
FIX: Do not display broken image on crawler/print view ( #6575 )
2018-11-07 22:28:45 +00:00
Penar Musaraj
9a34c6153e
Fix small issues with FA5 icons
2018-11-07 16:39:04 -05:00
Penar Musaraj
a5871b6dd1
Rename conflicting SCSS mixin
2018-11-07 14:18:55 -05:00
Penar Musaraj
005e1ecb9b
FEATURE: Update Font Awesome to v5.4.1 and SVGs ( #6557 )
...
* First take on subsetting svg icons
* FontAwesome 5 svg subset WIP
* Include icons from plugins/badges into svg sprite subset
* add svg icon support to themes
* Add spec for SvgSprite
* Misc. SVG icon fixes
* Use FA5 svgs in local-dates plugin
* CSS adjustments, fix SVG icons in group flair
* Use SVG icons in poll plugin
* Add SVG icons to /wizard
2018-11-07 13:05:43 -05:00
Gerhard Schlager
6b60646330
FIX: Relative links in templates should work with subfolders
2018-11-07 11:35:04 +01:00
Sam
0a442e319c
FIX: correct svg handling for images
...
We regressed and optimized images no longer worked with svg
The following adds the correct logic to simply copy file for svgs
and bypasses resizing for svg avatars
2018-11-07 15:29:26 +11:00
Guo Xiang Tan
7534042427
DEV: Update annotations.
2018-11-07 11:11:19 +08:00
Bianca Nenciu
2070edf889
FIX: Clarify User.group_locked_trust_level.
...
* Rename User.group_locked_trust_level to User.group_granted_trust_level.
* Remove the column from users table.
2018-11-07 10:27:44 +08:00
Matthew Campbell
a2044c4528
UX: Make the edits indicator a real link for accessibility ( #6570 )
...
This link didn't have an `href` attribute, so it wasn't in the tab
order. This commit fixes that, while adding a call to `preventDefault`
in the event handler to avoid any regression in event handling.
2018-11-07 10:11:52 +11:00
Kris
ef368ec2ff
Minor spacing adjustments for new search results
2018-11-06 10:01:24 -05:00
Joffrey JAFFEUX
75b1865d15
UX: adds new categories layouts to the wizard ( #6569 )
2018-11-06 15:52:13 +01:00
Joffrey JAFFEUX
fdad24e2e4
FIX: edit category tags select-kit inputs width were wrong ( #6568 )
2018-11-06 11:30:12 +01:00
Jeff Atwood
afbdf9c2d2
Merge pull request #6558 from pmusaraj/disallow-flagging-deleted-post
...
FIX: disable flagging hidden posts
2018-11-05 11:05:32 -08:00
Kris
d7e38d2be8
Adding IE11 Grid support for admin dashboard
2018-11-05 12:52:02 -05:00
Maja Komel
ae9eddb002
FIX: don't allow adding a value containing vertical bar char to the secret list
2018-11-05 12:14:56 +01:00
Joffrey JAFFEUX
cc9869a61b
FIX: topic-map spec with VDOM and i18n plural ( #6564 )
...
It appears that in vdom nodes, pluralized i18n strings are not compiled into a string before widget is compiled and result in an error as VDOM is expecting a string and not an object.
2018-11-05 12:02:18 +01:00
Joffrey JAFFEUX
4d74688b50
UX: uses presentation role for accessibility in topic map ( #6561 )
...
Co-Authored-By: mwcampbell <mwc+github@mwcampbell.us>
2018-11-05 09:45:32 +01:00
Penar Musaraj
94f628fb4c
FIX: disable flagging hidden posts
2018-11-02 13:54:45 -04:00
Robin Ward
931c3d165b
Revert "FIX: We shouldn't include topics when mobile view is enabled"
...
This reverts commit 2feadcdafb
2018-11-02 10:29:44 -04:00
Joffrey JAFFEUX
4417faa7e5
Revert "FIX: uses more semantically correct spans in post map ( #6555 )"
...
This reverts commit 5cd055fd30
2018-11-02 15:07:22 +01:00
Joffrey JAFFEUX
8067f8a32c
FIX: disables dates filtering on most_disagreed_flags report ( #6556 )
2018-11-02 14:42:52 +01:00
Joffrey JAFFEUX
5cd055fd30
FIX: uses more semantically correct spans in post map ( #6555 )
2018-11-02 13:09:58 +01:00
Joffrey JAFFEUX
4e0f033fae
FEATURE: adds ignored flags to most_disagreed_flags report ( #6554 )
2018-11-02 11:08:00 +01:00
Sam
d84256a876
FEATURE: add Noindex to robots.txt for disallowed routes
...
This strips pages out of indexes that should not exist see:
https://meta.discourse.org/t/pages-listed-in-the-robots-txt-are-crawled-and-indexed-by-google/100309/11?u=sam
2018-11-02 16:39:47 +11:00
Joe
4234058358
UX: don't show crawler navigation in print view ( #6551 )
...
* UX: adds CSS classes to crawler navigation links
* UX: hide crawler navigation in print view
2018-11-02 09:18:07 +11:00
Robin Ward
c4ca5ed50b
FIX: Translation error
2018-11-01 17:44:55 -04:00
Kyle Zhao
f9b36820ef
FIX: only extract script tags with certain types ( #6553 )
...
`script` tags with custom types (e.g. `text/template`) are not executed
by the browser, and should not be extracted into an external theme
JavaScript
2018-11-01 16:01:46 -04:00
Robin Ward
2feadcdafb
FIX: We shouldn't include topics when mobile view is enabled
...
This setting was set to be the opposite of what we want
2018-11-01 14:47:06 -04:00
Robin Ward
ec91450aae
FEATURE: Track how many user flags are agreed/disagreed/ignored
...
Display the percentage when reviewing flags.
2018-11-01 09:59:50 -04:00
Sam
ceafcbc898
FEATURE: show added date when looking at group members
2018-11-01 15:33:28 +11:00
Sam
aa044623bd
FIX: do not create superflous sessions when logged on
...
In some SSO implementations we may want to issue SSO pipelines for
already logged on users
In these cases do not re-log-in a user if they are clearly logged on
2018-11-01 12:54:01 +11:00
Vinoth Kannan
0084b0c26e
Merge pull request #6548 from vinothkannans/category-drop-search
...
UX: Include subcategories in search result of all categories drop down
2018-10-31 23:44:54 +05:30
Vinoth Kannan
28cf4d535e
UX: Include subcategories in search result of all categories drop down
2018-10-31 23:03:24 +05:30
Bianca Nenciu
fa0e421af3
FIX: Do not leak information about post revisions. ( #6536 )
2018-10-31 14:47:00 +00:00
David Taylor
ff6676094f
FIX: Correct bookmark button class
2018-10-31 11:22:24 +00:00
Régis Hanol
0bf52d422c
FEATURE: new 'simultaneous_uploads' site setting
2018-10-31 10:58:09 +01:00
Kris
f97cf10676
Removing edit button from mobile category list
2018-10-30 22:57:06 -04:00
Sam
23423ba112
correct spec and error reporting
...
previous commit misused warn_exception which caused a spec to fail
2018-10-31 13:38:05 +11:00
Blake Erickson
589e3fcaa0
FIX: return 400 for missing required params ( #6546 )
...
If a required param is missing return a 400 and show a message
displaying which param was missing. Added this to the application
controller so that we don't have to add this logic to every controller
action.
2018-10-31 13:02:48 +11:00
Sam
32b1f34910
PERF: avoid DNS lookups when getting IP info
...
Also cleans up interface in DiscourseIpInfo
grew cache to 2000 entries
2018-10-31 12:38:57 +11:00
Bianca Nenciu
e0ccd36dbe
FEATURE: Suspicious logins report. ( #6544 )
2018-10-30 22:51:58 +00:00
Bianca Nenciu
e1e392f15b
DEV: Use DiscourseIpInfo for all IP queries. ( #6482 )
...
* DEV: Use DiscourseIpInfo for all IP queries.
* UX: Use latitude and longitude for more precision.
2018-10-30 22:08:57 +00:00
Bianca Nenciu
4b7ab97a01
FIX: Add 'log in via link' to email templates. ( #6545 )
2018-10-30 19:15:05 +00:00
Joffrey JAFFEUX
11ee07093c
FEATURE: revamps search-menu layout ( #6543 )
2018-10-30 10:44:49 -04:00
Gerhard Schlager
733b8af47b
FIX: Uploads didn't work for subfolder anymore
2018-10-30 12:53:57 +01:00
Gerhard Schlager
5b14f713a0
Use class instead of inline style
2018-10-30 11:25:51 +01:00
Joffrey JAFFEUX
af465effef
FIX: prevents y-axis labels to show useless/wrong values
2018-10-30 09:58:03 +01:00
Vinoth Kannan
92bf3c667e
FIX: Flash authentication data not rendered in latest iOS safari browser
2018-10-30 04:00:36 +05:30
Sam
f8305f53c7
FEATURE: special offline support restricted to Android only
...
The special offline page with fetch interception in service worker
is only strongly required on Android ad a pre-req for PWAs
This is now strongly restricted only to Android while iOS PWA support
gets better
Long term if we build offline support we can unlock it more globally
2018-10-29 16:29:19 +11:00
Jeff Atwood
760e09907b
add a tad more width for user pref forms
2018-10-27 20:20:01 -07:00
Jeff Atwood
817cf8b229
remove extraneous two factor auth info popup
2018-10-27 14:10:26 -07:00
Jeff Atwood
58b53f7841
update copy for "was this you?" login dialog
2018-10-27 13:57:30 -07:00
David Taylor
375bba3c31
FIX: Add String.includes polyfill for IE11
2018-10-26 23:10:03 +01:00
Kris
cd9a41be55
IE11 fix for create account modal alignment
2018-10-26 17:04:28 -04:00
Kris
0bf413be3e
IE11 fix for category dropdown search icon position
2018-10-26 13:28:05 -04:00
Kris
1f88f69a7f
IE11 Fix for tracking dropdown
2018-10-26 12:55:26 -04:00
Rafael dos Santos Silva
84f858fc23
FIX: Remove orientation from the webmanifest
...
We don't really care about orientation, so let the user OS handle it.
2018-10-26 13:48:14 -03:00
Rafael dos Santos Silva
2450f178ca
FEATURE: Allow admins to control PWA display mode per user agent
2018-10-26 13:47:22 -03:00
Kris
fb15e04e48
Fixing broken badge grant layout
2018-10-26 11:06:31 -04:00
Kris
7c2618e914
Adding classes to login for external auth and user fields ( #6535 )
2018-10-26 10:33:06 -04:00
Joffrey JAFFEUX
b2585524a9
FEATURE: adds a most disagreed flaggers report
2018-10-26 15:59:04 +02:00
David Taylor
e955a1f24b
DEV: Skip ESLint on polyfill
2018-10-26 13:54:03 +01:00
David Taylor
af84949f25
FIX: Add polyfill so that Array.includes works in IE11
2018-10-26 13:45:29 +01:00
Joffrey JAFFEUX
398f98c568
FIX: ensures reports links are correct on subfolder installs
2018-10-26 12:32:02 +02:00
Penar Musaraj
3c92202654
Set individual future-date-input components as clearable, fixes admin Safari bug ( #6522 )
2018-10-26 11:34:55 +11:00
Penar Musaraj
ed9c21e42c
FEATURE: hide muted categories from /categories list ( #6531 )
2018-10-26 11:34:39 +11:00
Régis Hanol
d17c8df926
Only check for suspicious login for staff members
2018-10-26 00:29:28 +02:00
Kyle Zhao
a6eca28ec6
CSP - extract all other inline JavaScripts ( #6528 )
...
* wizard page inline js
* print topic inline js
* drop JS for preventing double submission
this is the default behavior with Rails' UJS `disable_with` helper
* omniauth complete redirect JS
* account activate inline js
2018-10-25 09:52:01 -04:00
Bianca Nenciu
effbef7d0b
UX: Use user locale for locations. ( #6527 )
...
* UX: Use user locale for locations.
* DEV: Added MaxMindDB test data and fixed test.
2018-10-25 10:54:01 +00:00
Joffrey JAFFEUX
8e274f7296
UX: bumps the user-api-key version to 3 ( #6526 )
...
* UX: bumps the user-api-key version to 3
* fix spec
2018-10-25 09:46:34 +00:00
Bianca Nenciu
2a77550f8c
FIX: Do not track right clicks. ( #6530 )
2018-10-25 09:46:04 +00:00
Bianca Nenciu
6a3767cde7
FEATURE: Warn users via email about suspicious logins. ( #6520 )
...
* FEATURE: Warn users via email about suspicious logins.
* DEV: Move suspicious login check to a job.
2018-10-25 09:45:31 +00:00
Sam Saffron
abaa3f0650
FEATURE: add server:before-head-close-crawler outlet for plugins
...
This outlet allows plugins to inject html prior to closing head tag
2018-10-25 16:31:05 +11:00
Kris
1d7720ef99
UX: Adding Google-compliant logo
2018-10-24 22:11:19 -04:00
Jeff Atwood
c62a8ee335
switch topic jump glyphs to better signify move to top/bottom
2018-10-24 18:41:41 -07:00
Jeff Wong
0ead513fb0
PERF: remove total unread notifications from message bus ( #6529 )
2018-10-25 12:14:34 +11:00
Kris
36e2f863ee
UX: Increase size of topic title tap target on mobile
2018-10-24 20:43:38 -04:00
Kris
c219a5fb1e
Add btn-default class to all default buttons ( #6521 )
2018-10-24 16:09:36 -04:00
Kris
0140844eb0
Remove whitespace in template so we can use :empty psuedo
2018-10-24 16:00:22 -04:00
Matthew Campbell
05438d99a8
FIX: Ensure the like button always has a title, for accessibility ( #6525 )
...
The like button previously didn't have a title for anonymous users,
because the `canToggleLike` flag wasn't set, but the `liked` flag wasn't
set either. This made the button inaccessible to blind users.
2018-10-24 13:58:42 +00:00
Sam
5fd94d3211
PERF: limit unread count to 99 in blue circle
...
This revises: e605542c4e
2018-10-24 12:10:27 +11:00
Sam
e605542c4e
PERF: limit unread count to 99 in the blue circle
...
This safeguard is in place to avoid very expensive queries on the server
side
2018-10-24 11:53:28 +11:00
Kris
0b4edfc7d6
UX: improve spacing on composer controls
2018-10-23 16:37:36 -04:00
Kris
a82dfbd2dc
Mobile timeline fix
2018-10-23 07:59:00 -04:00
Kris
541b6a8446
UX: Allow vertical timeline to fit on narrower screens
2018-10-22 22:16:59 -04:00
Sam
de6b585368
minor, bypass gravatar update if user does not match
...
this protects against a race condition that can happen when a user record
is destroyed reasonably quickly
2018-10-23 12:20:41 +11:00
Daniel Hollas
cee51672c9
FIX: Strip accents from search query
...
4481836
2018-10-23 12:10:33 +11:00
Joffrey JAFFEUX
7d2e582b28
FIX: validates import theme form ( #6513 )
2018-10-23 12:09:06 +11:00
Sam
b74dd7d379
FIX: stop logging every 404 error when searching for gravatars
2018-10-23 11:43:14 +11:00
Kyle Zhao
2cc195f3d9
prettier linting fix
2018-10-22 14:18:26 -04:00
Bianca Nenciu
37fa7775f1
FIX: Fix order of recently connected devices. ( #6517 )
2018-10-22 17:30:23 +00:00
Kyle Zhao
e9a971a2b6
FEATURE: [Experimental] Content Security Policy ( #6514 )
...
do not register new MIME type, parse raw body instead
2018-10-22 13:22:23 -04:00
Jeff Wong
ec2613699f
Change box category view to use flexbox
2018-10-22 10:15:31 -07:00
Régis Hanol
b9261588f9
make the code prettier
2018-10-22 19:07:41 +02:00
Régis Hanol
3e232412e3
UX: show error when hitting the rate limit on password reset
2018-10-22 19:00:30 +02:00
David Taylor
3377f26eba
FIX: Clean tag before searching for matches
2018-10-22 11:09:06 +01:00
David Taylor
37b7afa522
FIX: Sanitize tags before creation
2018-10-22 10:53:42 +01:00
Kyle Zhao
dca830cb73
Revert "FEATURE: [Experimental] Content Security Policy ( #6504 )"
...
This reverts commit fb8231077a
2018-10-19 11:53:29 -04:00
Kris
b35c8fb336
Add offset to topic footer admin menu, to avoid header overlap
2018-10-19 11:30:11 -04:00
David Taylor
0dd717e641
Revert "FIX: Sanitize tags before creation"
...
This reverts commit 18ae8de9e5
2018-10-19 15:49:05 +01:00
David Taylor
18ae8de9e5
FIX: Sanitize tags before creation
2018-10-19 15:43:31 +01:00
Kyle Zhao
fb8231077a
FEATURE: [Experimental] Content Security Policy ( #6504 )
2018-10-19 10:39:22 -04:00
Bianca Nenciu
b69652278f
FEATURE: Add Wiki Editor badge. ( #6511 )
2018-10-19 15:30:27 +02:00
David Taylor
7166d7de9a
FIX: Prevent duplicate tags in tag-choosers ( #6512 )
...
* FIX: Prevent duplicate tags in tag-choosers
This reverts 5685b455685b45
2018-10-19 13:44:43 +01:00
Joffrey JAFFEUX
5f86564da1
FEATURE: adds latest to user-api-key session scope
2018-10-19 09:54:06 +02:00
Sam
9bfc939692
cleanup so gravatar download failures are consistent
...
previously we would ignore socket error, but this would mean that
there could be conditions where we would keep trying to download
gravatars forever (in an hourly job)
2018-10-19 12:51:55 +11:00
Angus McLeod
85ef8e5a9f
auto is not a valid value for min/max height ( #6509 )
2018-10-18 21:33:45 -04:00
Bianca Nenciu
22ada32d4d
FIX: Strip @ when searching for users and groups. ( #6506 )
2018-10-19 11:56:10 +11:00
Robin Ward
f0af61da41
FIX: User AvatarLookup for looking up avatar details ( #6508 )
...
This allows plugins with their own avatar logic to work in the user
summary sections.
2018-10-18 15:49:34 -04:00
Blake Erickson
93485facaf
FIX: lowercase username for add/rem group members
...
This fix searches for users based on the downcased username so that if
you pass in usernames to add/remove from a group and you don't have the
casing just right it will still find the correct users.
I updated the tests to add a username that has a mix of upper and
lowercase letters to verify this functionality.
2018-10-18 13:17:24 -06:00
Régis Hanol
3973823a33
FIX: always update 'last_gravatar_download_attempt' when updating gravatar
2018-10-18 11:02:54 +02:00
Kyle Zhao
0f1afad6da
FIX: extracted theme JavaScripts for multisite ( #6502 )
...
* FIX: extracted theme javascripts for multisite
* onceoff to rebake all theme fields
2018-10-18 17:05:34 +11:00
Guo Xiang Tan
22408f93c9
FIX: Wrap custom fields database statements in a transaction.
...
Kind of strange that we don't do it because a database statement
may fail and leave us in a weird state.
2018-10-18 12:23:04 +08:00
Guo Xiang Tan
44eba0bb60
FIX: Don't rescue PG::UniqueViolation within a transaction.
...
Also acquire a transaction per link instead of failing when
any of the links can't be processed.
This prevents ActiveRecord from rolling back the transaction
and the next SQL statement sent to PG will fail. This is
however hard to test as it only happens when there are
two competing process trying to process this method at the
same time.
2018-10-18 10:54:30 +08:00
Guto Foletto
0abc932056
add styles so permalinks admin could fit mobile screen ( #6496 )
2018-10-17 17:37:14 +02:00
Bianca Nenciu
f60b10d090
UX: Warn users if the post that's currently edited has changed. ( #6498 )
2018-10-17 15:35:32 +02:00
David Taylor
065bf0762c
FEATURE: New plugin outlets for user card customization
2018-10-17 14:15:48 +01:00
David Taylor
c6f364224e
FEATURE: Allow plugins to whitelist user custom fields for public display ( #6499 )
...
This works exactly the same as `whitelist_staff_user_custom_fields`, but is not limited to staff
2018-10-17 10:33:27 +01:00
Arpit Jalan
42c405a820
FIX: use topic summary for meta description if topic excerpt is blank
2018-10-17 14:13:30 +05:30
Joe
1b5ba899a1
UX: header items wrap on small screens for anon
2018-10-17 14:19:20 +08:00
Joe
5815a33a9a
FIX: closing an empty fullscreen composer with toggler prevents scrolling
2018-10-17 13:52:47 +08:00
Kris
b23ebf10c2
Minor post alignment fixes
2018-10-16 12:39:55 -04:00
Vinoth Kannan
e3c6dd26c4
FIX: Do not set null value to remove cookie
2018-10-16 06:48:54 +05:30
Sam
19d7543004
FIX: clear color scheme cache when clearing theme cache
2018-10-16 12:00:46 +11:00
Vinoth Kannan
08c404e138
FIX: Do not set null value to remove cookie
2018-10-16 06:12:32 +05:30
Sam
8d06731484
FIX: reduce amount of work onceoff does
...
In the past onceoff was forcing inline download of gravatars,
this can be so expensive that it will never finish
This fix ensures it only marks avatars stale which will be picked
up by regular schedules
2018-10-16 10:29:16 +11:00
Kyle Zhao
99d1ded3b3
rename route /javascripts to /theme-javascripts ( #6495 )
2018-10-15 11:32:52 -04:00
Maja Komel
c104256991
FIX: SSO provider secrets - check wildcard domains last, toggle secrets visibility
2018-10-15 16:18:29 +02:00
Joffrey JAFFEUX
f6eff38c0e
FEATURE: adds list#(unread|new) to user api key routes ( #6494 )
2018-10-15 15:48:35 +02:00
David Taylor
7ac08f936e
FEATURE: Upload tags from CSV ( #6484 )
2018-10-15 09:12:54 +01:00
Sam
4c8fe13500
FIX: remove code that restricted "header" theme field from admin
...
There was some old code that restricted a percentage of a themes code from
admin, only when admin was refreshed, this leads to lots of confusion
Conditional is now removed
2018-10-15 17:29:10 +11:00
Maja Komel
27e732a58d
FEATURE: allow multiple secrets for Discourse SSO provider
...
This splits off the logic between SSO keys used incoming vs outgoing, it allows to far better restrict who is allowed to log in using a site.
This allows for better auditing of the SSO provider feature
2018-10-15 16:03:53 +11:00
Kyle Zhao
6acdea37c4
DEV: extract inline js when baking theme fields ( #6447 )
...
* extract inline js when baking theme fields
* destroy javascript cache when destroying theme fields
This work is needed to support CSP work
2018-10-15 15:55:23 +11:00
Guo Xiang Tan
aa60936115
DEV: Add order to avoid randomly failing test.
2018-10-15 11:42:45 +08:00
Joe
2acb885c72
FEATURE: fullscreen composer mode on desktop
...
Adds keyboard shortcut and icon that allows expanding composer to full screen.
2018-10-15 13:59:49 +11:00
Maja Komel
57b52cd1de
FIX: keep emoji syntax for custom emojis in quotes ( #6488 )
2018-10-15 10:57:15 +08:00
Guo Xiang Tan
84d4c81a26
FEATURE: Support backup uploads/downloads directly to/from S3.
...
This reverts commit 3c59106bac
2018-10-15 09:43:31 +08:00
Joe
6a59187ae8
UX: images should be responsive in embedded comments
2018-10-14 23:38:07 +08:00
Robin Ward
2178f7768f
FIX: Don't show empty user stats in the card when profile is hidden
2018-10-12 12:33:27 -04:00
Sam
a1c912b630
Return 400 instead of 404 for bad token
2018-10-12 10:51:41 +11:00
Bianca Nenciu
048cdfbcfa
FIX: Do not allow revoking the token of current session. ( #6472 )
...
* FIX: Do not allow revoking the token of current session.
* DEV: Add getter of current auth_token from Guardian.
2018-10-12 10:40:48 +11:00
Bianca Nenciu
e68ecf1f1d
UX: Add link to Groups in admin dashboard. ( #6480 )
...
* UX: Add link to Groups in admin dashboard.
* UX: Site settings have immediate effect.
2018-10-12 10:34:47 +11:00
Vinoth Kannan
39b7e32848
DEV: Require sso and sig query string params for sso_login
2018-10-12 05:03:30 +05:30
Blake Erickson
13b3cead06
FEATURE: Allow bulk removing users from a group
...
This change maintains backwards compatibility to allow you to remove a
single user from a group but allows you to specify a comma separated list
of users for bulk removal from a group.
Also it extracts out common functionality for fetching users from params
used in bulk adding users so it can also be used for removing users.
2018-10-11 15:30:54 -06:00
Neil Lalonde
12f132736b
FIX: error looking at users in admin when tl3_promotion_min_duration is set to a very high value
2018-10-11 15:11:48 -04:00
Robin Ward
c2add85e75
FIX: Typo, should be authentication
...
cc @xrav3nz
2018-10-11 14:58:46 -04:00
Bianca Nenciu
ded5ff90aa
FIX: Groups list does not refresh when query changes. ( #6481 )
2018-10-11 21:20:17 +08:00
David Taylor
1b0fbc4d30
FIX: Allow theme edit route name to be overridden
...
This is required for the theme-creator plugin, this change won't have
any effect on regular Discourse installations
2018-10-11 13:20:04 +01:00
Vinoth Kannan
6a444eee56
Merge pull request #6476 from vinothkannans/tl4-flag
...
FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user
2018-10-11 17:13:26 +05:30
Vinoth Kannan
227a49bb32
FEATURE: automatically hide non-TL4 posts when flagged by a TL4 user
2018-10-11 17:11:46 +05:30
Bianca Nenciu
f1a52138d6
UX: Move Recently Used Devices to the bottom. ( #6483 )
2018-10-11 19:22:30 +08:00
Jeff Wong
b5b382dcd6
Feature: add boxes with subcategories option for desktop categories page ( #6471 )
...
* Feature: add boxes with subcategories option for desktop categories page
* only add subclass div when subclasses exist
2018-10-11 15:59:37 +08:00
Bianca Nenciu
6275e745a7
FIX: Fix open quote links in new window. ( #6477 )
2018-10-11 15:51:14 +08:00
Régis Hanol
09961fb425
FIX: properly escape name of custom emoji
2018-10-11 09:35:23 +02:00
Guo Xiang Tan
3c59106bac
Revert "FEATURE: Support backup uploads/downloads directly to/from S3."
...
This reverts commit c29a4dddc1
2018-10-11 11:08:23 +08:00
Gerhard Schlager
c29a4dddc1
FEATURE: Support backup uploads/downloads directly to/from S3.
2018-10-11 10:38:43 +08:00
Kyle Zhao
ffc241eb25
FIX: multiple loadScript to the same url may resolve prematurely ( #6474 )
...
This is how `loadScript(url)` currently deals with multiple concurrent requests
1. Check existing `<script>` tags, and mark existing scripts (other than the
input `url`) as loaded
2. Find "true" `url` of the requested resource (CDN, subfolder path, etc)
3. Check if we have loaded the resource with that "true" `url`, and resolve
immediately if we have
4. Otherwise insert a `<script>` tag with the "true" `url` to load it
For example, in a subfolder install:
- Input `url` = `/javascripts/script.js`
- "True" `url` = `/subfolder/javascript/script.js`
And the _very_ subtle bug here is that we should use also use the true `url`
for step (1), because:
- Since the input and true `url` are different, we mistakenly mark the true
`url` as loaded in step one
- After finding the true `url`, and setting `loaded[trueUrl] = true` in (1), we
resolve the promise prematurely, when the resource could still be loading
2018-10-11 08:55:36 +08:00
Robin Ward
a566ed42ae
FEATURE: Option to disable user presence and profile
...
This allows users who are privacy conscious to disable the presence
features of the forum as well as their public profile.
2018-10-10 17:34:33 -04:00
Kris
34e8d17ad0
Fixing left alignment of post controls
2018-10-10 12:11:47 -04:00
David Taylor
98211f945f
FIX: 'none' tag page would not load
2018-10-10 16:00:33 +01:00
Kris
94b115f7d9
increase contrast for $danger-medium on dark themes
2018-10-10 09:51:50 -04:00
Arpit Jalan
c84415b1f2
FEATURE: support category slug when creating new topic via URL
2018-10-10 17:06:02 +05:30
Guo Xiang Tan
ae6a5419e0
DEV: Report the backtrace as well.
2018-10-10 17:43:42 +08:00
Penar Musaraj
0ea8c1943f
Let plugins decorate banner topic, fixes local dates in banners ( #6452 )
2018-10-10 17:27:23 +08:00
Kris
1f14fb5e1e
Don't override category badge icon color in similar topic JIT
2018-10-09 15:38:49 -04:00
Bianca Nenciu
1d26a473e7
FEATURE: Show "Recently used devices" in user preferences ( #6335 )
...
* FEATURE: Added MaxMindDb to resolve IP information.
* FEATURE: Added browser detection based on user agent.
* FEATURE: Added recently used devices in user preferences.
* DEV: Added acceptance test for recently used devices.
* UX: Do not show 'Show more' button if there aren't more tokens.
* DEV: Fix unit tests.
* DEV: Make changes after code review.
* Add more detailed unit tests.
* Improve logging messages.
* Minor coding style fixes.
* DEV: Use DropdownSelectBoxComponent and run Prettier.
* DEV: Fix unit tests.
2018-10-09 22:21:41 +08:00
Erin Kosewic
51aba32651
FEATURE: add branch option to remote theme import
...
* FEATURE: add branch option to remote theme import
* FIX: Add missing variable in params
* FIX: Add missing param for import_theme method
* SPEC: Add test methods for branch support in git import
* FIX: Add missing space to scss style
* Do not assume default branch as master
* Change branch field placeholder
* FIX: add missing div start tag
2018-10-09 17:01:08 +11:00
Kyle Zhao
acba7d2a5d
Extract discourse_javascript.html.erb to a scrip include
...
* extract omniauth auth complete inline JS
* extract Ember error logging inline JS
* transpile `authentication-complete`
This is CSP related work
2018-10-09 16:50:45 +11:00
Kyle Zhao
8b2a379e4e
DEV: transpile certain ES6 files without producing a module ( #6460 )
...
`.js.no-module.es6` files will be transpiled without producing a module.
import/export statements are deliberately not supported, so one would still need to use
`const module = require('moduleName').default.`
2018-10-09 09:18:23 +08:00
Jeff Wong
e55f220b33
add category style boxes with featured topics option
2018-10-08 16:19:54 -07:00
Kris
c889c0daee
Only prevent checkbox/radio from flex-grow
2018-10-08 13:10:51 -04:00
Gerhard Schlager
97ad9e9d9b
UX: Prompt for custom invite message was hard to translate
2018-10-08 18:01:21 +02:00
Gerhard Schlager
eb3ed7f6fd
Add missing annotations
2018-10-08 18:01:21 +02:00
Kris
ec33b46d31
IE11 doesn't support nested calc
2018-10-08 11:55:54 -04:00
Joffrey JAFFEUX
da8916aecd
FIX: adds a title attribute on value list input ( #6463 )
2018-10-08 12:08:36 +02:00
Joffrey JAFFEUX
22187508e3
FEATURE: adds header text/background color to site ( #6462 )
2018-10-08 11:52:57 +02:00
Guo Xiang Tan
3c0ec317ac
DEV: Fix wizard qunit tests not running.
2018-10-08 14:45:56 +08:00
Guo Xiang Tan
43512e9865
Merge pull request #6457 from pmusaraj/yarn-manage-test-vendor-dependencies
...
DEV: Use Yarn managed test vendor dependencies
2018-10-08 09:26:26 +08:00
Sam
550e108a8c
FEATURE: only export settings that changed via rake task
2018-10-08 11:54:52 +11:00
Kris
41ceb6ca88
topic body and small action widths inconsistent
2018-10-05 18:37:23 -04:00
David Taylor
cbb8f6f0fe
UX: Use 'trash' icon instead of 'times' for deleting small actions
2018-10-05 22:31:56 +01:00
Kris
0a1ac88f2c
last visit line needs more contrast
2018-10-05 15:28:10 -04:00
Kris
fa21b39875
FIX: topic admin menu was clipped on short posts due to overflow hidden
2018-10-05 10:51:27 -04:00
Penar Musaraj
be56f18cdd
Replace deprecated dropdown-button with DropdownSelectBoxComponent ( #6451 )
2018-10-05 09:48:17 -04:00
David Taylor
75488257c5
FIX: Redirect users to top when latest is the homepage
2018-10-05 12:14:57 +01:00
David Taylor
9bf522f227
FEATURE: Mixed case tagging ( #6454 )
...
- By default, behaviour is not changed: tags are made lowercase upon creation and edit.
- If force_lowercase_tags is disabled, then mixed case tags are allowed.
- Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres.
- A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria.
- A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`.
- URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.
2018-10-05 10:23:52 +01:00
Vinoth Kannan
8430ea927e
FIX: Generate webhook payloads before destroy events ( #6325 )
2018-10-05 16:53:59 +08:00
Sam
5b630f3188
FIX: stop logging every time invalid params are sent
...
Previously we were logging warning for invalid encoded params, this can
cause a log flood
2018-10-05 14:33:19 +10:00
Kris
948c556cc6
decrease contrast on danger-low color
2018-10-04 17:30:10 -04:00
Kris
98b9913033
UX: Disable button hover effects on touch devices
2018-10-04 17:15:37 -04:00
Kris
ab1e5732d7
UX: Category colorpicker restyle
2018-10-04 15:47:46 -04:00
Vinoth Kannan
3faa022c6f
Merge pull request #6453 from vinothkannans/sso_provider_redirect
...
FIX: redirect users to SSO client URL after social login
2018-10-05 00:34:34 +05:30
Vinoth Kannan
ca74246651
FIX: redirect users to SSO client URL after social login
2018-10-05 00:01:08 +05:30
Penar Musaraj
4ae9cb28e4
remove probes.js, highlight.pack.js
2018-10-04 13:50:54 -04:00
Kris
2e28116243
Period-chooser should have visible overflow
2018-10-04 12:28:48 -04:00
Kris
09caf95e7d
create account inputs too wide on iOS
2018-10-04 12:02:28 -04:00
Kris
8e0fe32f37
Minor login layout fixes
2018-10-04 11:54:51 -04:00
Bianca Nenciu
e0e0a91e7d
FIX: Retry sending email in case of temporary issue. ( #6375 )
2018-10-04 22:56:24 +08:00
David Taylor
3c2608d41c
FIX: Correctly censor strings starting or ending with non-word characters ( #6445 )
2018-10-04 15:15:10 +01:00
Bianca Nenciu
6ad13e5ae9
FIX: Avoid redirection when not leaving forum. ( #6419 )
...
* FIX: Avoid redirection when not leaving forum.
* DEV: Updated click-track's tests.
2018-10-04 22:06:31 +08:00
Kris
ff47609141
UX: Improve custom field layout on signup
2018-10-03 22:26:05 -04:00
Vinoth Kannan
a651d39b8a
FIX: Display errors in single theme pages ( #6449 )
...
Currently the errors are not well handled. So it breaks the whole UI of admin themes list page.
2018-10-04 02:33:06 +05:30
Penar Musaraj
b5bdd42838
Progress bar CSS refactoring ( #6444 )
...
* Less magic in calculating topic progress bar
* more minor adjustments to topic progress CSS
* Bounce back button again
* Fix prettier warning
2018-10-03 13:21:57 -04:00
Kris
46563082a9
FIX: Move overflow from cooked to parent element to allow for slight overflow of blur/italic/shadow
2018-10-03 10:18:36 -04:00
Penar Musaraj
dc8a16b43b
Use Yarn to manage dependencies, cleanup unused bootstrap libs ( #6436 )
2018-10-03 10:15:43 -04:00
Vinoth Kannan
23b4ab9bf9
DEV: Do not use concatenation in translations
2018-10-03 11:59:21 +05:30
Vinoth Kannan
2912170e9e
Update placeholder github url in correct format
2018-10-03 11:14:36 +05:30
Maja Komel
73443d889c
FIX: keep files in order when adding multiple uploads ( #6306 )
...
* FIX: keep files in order when adding multiple uploads
* use filename in the placeholder when uploading files
* add tests
* add consecutive nr to the placeholder when multiple uploads with the same filename
2018-10-03 11:12:36 +10:00
Kris
07be8e5447
caret icon is redundant on hamburger menu button
2018-10-02 15:06:50 -04:00
Neil Lalonde
dc1e7bb645
UX: when admin is deleted, make it clear in staff action logs when records belong to a deleted user and show their username in the details
2018-10-02 13:46:54 -04:00
Penar Musaraj
98aaad6675
Improve "hit area" for topic progress bar on mobile ( #6442 )
...
* Improve "hit area" for topic progress bar on mobile
* Only target admin wrench on mobile
2018-10-02 12:26:16 -04:00
Kris
7228c4964c
Flag reason "something else" fix
2018-10-02 12:05:21 -04:00
Penar Musaraj
34516c72bd
FIX: Recover public actions (likes) when recovering a post ( #6412 )
2018-10-02 11:25:08 -04:00
Kris
324b57c207
Prevent flexbox from shrinking inputs
2018-10-02 10:42:49 -04:00
Gerhard Schlager
7fe17e93e2
UX: Label of checkbox site setting needs a span for nested HTML
2018-10-02 16:25:05 +02:00
Gerhard Schlager
3a6ab02563
FEATURE: Notify admins when scheduling of backup fails
2018-10-02 15:48:16 +02:00
Jeff Atwood
40d0fc9259
UX: slightly taller progress bar for mobile
2018-10-02 03:21:08 -07:00
Joffrey JAFFEUX
a515ba8612
FIX: corrects typo and adds a spec for likes report ( #6439 )
...
* FIX: corrects typo and adds a spec for likes report
* save!
2018-10-02 02:27:43 -07:00
Joffrey JAFFEUX
f34d9202b4
UX: makes reports fade in when loading is done ( #6440 )
2018-10-02 09:20:04 +02:00
Kyle Zhao
7591da1e64
FIX: s3BaseUrl with small s
2018-10-02 13:06:33 +08:00
Bianca Nenciu
719a433c03
FIX: Sync client & server rules regarding tag names. ( #6400 )
2018-10-01 21:45:44 -07:00
Kyle Zhao
d9bea66365
UX: confirmation before changing group membership in admin ( #6426 )
2018-10-01 21:34:08 -07:00
Kyle Zhao
ab448ca8f3
extract client side Discourse setup inline JS ( #6409 )
2018-10-01 21:29:04 -07:00
Sam
580c923ff3
UX: remove flex basis from first item
...
We do not want to take up 100% width for name/username on first line
2018-10-02 13:16:51 +10:00
Sam
120c220c18
UX: correct ordering of username / fullname in UX
2018-10-02 12:56:50 +10:00
Penar Musaraj
533315a607
Fix progress bar position when theme has header elements outside #main ( #6425 )
2018-10-02 10:45:23 +10:00
Kris
42066e407d
UX: updating style of mobile navigation dropdown
2018-10-01 14:49:00 -04:00
Kris
eeffac3186
label needs a span to contain nested HTML in description
2018-10-01 13:42:35 -04:00
Kris
1897155479
prettier
2018-10-01 11:59:21 -04:00
Kris
eca671b972
Prevent category dropdowns from cropping text, simplify styles
2018-10-01 11:53:18 -04:00
Maja Komel
1add11d8c9
FIX: don't send multiple requests when changing category notification ( #6435 )
2018-10-01 23:41:23 +08:00
Kris
fc4a6ca724
Prevent adming setting input from being too small in Safari
2018-10-01 10:39:55 -04:00
Prssanna Desai
8bb0bca808
UX: Improve spacing & alignment for Category edit modal ( #6432 )
2018-10-01 10:21:40 -04:00
Prssanna Desai
f1bc1780a6
FIX: hide Delete Category button while creating a new category
2018-10-01 14:31:05 +02:00
Guo Xiang Tan
d8fa7fbbab
Fix onceoff job in cfa7173da3 not running.
2018-10-01 17:14:04 +08:00
Guo Xiang Tan
cfa7173da3
FIX: Onceoff job to fix missing user profile backgrounds.
2018-10-01 16:26:40 +08:00
Kyle Zhao
d0f660806d
FIX: close data-preloaded div tag
2018-10-01 15:24:27 +08:00
Kyle Zhao
373d6e3fe6
always loadScript with a script tag ( #6411 )
...
to avoid Content Security Policy unsafe-line violations
2018-10-01 10:06:01 +08:00
Robin Ward
02da022c70
PERF: Quit out of the email job quickly if disabled ( #6423 )
...
This prevents sidekiq from doing a bunch of queries when email is
disabled.
Critical emails are a special case and will be sent.
2018-10-01 01:15:45 +08:00
Kyle Zhao
819f090d6a
move large blobs out of <head> ( #6428 )
...
it unnecessarily bloats the section and increases the payload
dramatically for open graph tags.
2018-09-28 17:28:33 +08:00
Gerhard Schlager
b0a383561e
FEATURE: Add Lithuanian locale
2018-09-27 05:26:38 +02:00
David Taylor
19c9a6699a
FIX: Validate auto_close_hours category setting
...
This prevents server errors when the value is set too high
2018-09-26 16:04:49 +01:00
Kyle Zhao
e2462ada68
FIX: make theme import's public key field readonly ( #6424 )
...
`disabled` attribute prevents the user from clicking or selecting in the
control whereas `readonly` does not.
2018-09-24 09:12:49 +08:00
David Taylor
84f5448a92
FEATURE: Display trust level descriptions in site settings ( #6421 )
2018-09-21 15:10:38 +01:00
Joe
b44bcdefd9
UX: improves topic-title flexbox alignment
2018-09-21 12:41:35 +08:00
Kyle Zhao
e402394375
FEATURE: auto grant an available title when removing old title
...
* FEATURE: auto grant an available title when removing old title
2018-09-21 12:06:08 +10:00
Sam
e622adfb89
correct warning
2018-09-21 12:05:08 +10:00
Sam
ae674dcb4e
Merge branch 'theme-select-mobile' of https://github.com/jjaffeux/discourse
2018-09-21 12:04:07 +10:00
Kyle Zhao
4bb980b9f7
FEATURE: do not allow moderators to export user list ( #6418 )
2018-09-21 09:07:13 +08:00
Kris
5f042a2c8d
Prevent move to new topic tag input from becoming too wide on click
2018-09-20 16:12:08 -04:00
Arpit Jalan
3e17ef0507
Merge pull request #6414 from techAPJ/user-field-unique-key
...
FEATURE: add external details to user fields
2018-09-20 22:29:39 +05:30
Kris
e43a05fa10
Timeline back button too tall
2018-09-20 10:28:26 -04:00
Joffrey JAFFEUX
87a97cbf4b
Merge branch 'master' into theme-select-mobile
2018-09-20 10:31:41 +02:00
Sam
df45e82377
SECURITY: only allow picking of avatars created by self ( #6417 )
...
* SECURITY: only allow picking of avatars created by self
Also adds origin tracking to all uploads including de-duplicated uploads
2018-09-19 22:33:10 -07:00
Guo Xiang Tan
195bd02fce
FIX: Avoid race condition when enqueuing job.
2018-09-20 11:24:01 +08:00
Arpit Jalan
72be638728
FEATURE: add external details to user fields
2018-09-20 08:10:51 +05:30
Kris
dfbc93aa2e
Prevent post date from overflowing with long usernames
2018-09-19 18:53:48 -04:00
Gerhard Schlager
681262ddce
FIX: Backup logs were usually missing the first few lines
...
And because of debouncing, the log wasn't always reset at the beginning of a backup or restore.
2018-09-19 20:27:35 +02:00
Gerhard Schlager
18d5d51d98
UX: Remove double scrollbars from backup logs
...
* Removes the wrapping, because the log is easier to read without it.
* Fixes the automatic scrolling to the bottom, which didn't work anymore
2018-09-19 20:27:34 +02:00
Joe
8d6ccde402
UX: removes bottom margins from inputs in admin controls
2018-09-20 00:32:41 +08:00
Joe
2144009520
UX: ensure ac-wrap input height matches other inputs
2018-09-20 00:02:45 +08:00
Joe
0010e7ddd2
UX: better padding for multi-select items
2018-09-19 23:56:26 +08:00
Joe
026bab116a
UX: label alignment for Firefox / IE
2018-09-19 23:48:48 +08:00
Guo Xiang Tan
d41f74578a
Fix JS build.
2018-09-19 23:12:34 +08:00
Guo Xiang Tan
767f27929d
Rename Jobs::RecoverPostUploads to rerun the job take 2.
2018-09-19 22:40:32 +08:00
Joe
b64436ba09
UX: select-kit filter input size fix
2018-09-19 22:05:56 +08:00
Guo Xiang Tan
6dbe1d832d
Rename Jobs::RecoverPostUploads to rerun the job.
...
Running a migration to destroy the onceoff job doesn't work
because an instance running the old code may execute the job.
2018-09-19 21:59:44 +08:00
Joe
0ac64b6d50
UX: radio / checkbox inputs margin fix
2018-09-19 21:22:40 +08:00
Joe
8fb50a7e8b
UX: last-seen input alignment fix
2018-09-19 21:20:04 +08:00
Joe
9e9fdac023
UX: multi-select items alignment fixes
2018-09-19 21:14:27 +08:00
Joe
acd18ff9d8
Fixes typo
2018-09-19 21:08:03 +08:00
Joe
e844fa5370
UX: general cleanup of inputs, buttons and select elements - part 1
2018-09-19 20:37:04 +08:00
Guo Xiang Tan
667e68ec58
Prefer create over create! when not checking for response.
2018-09-19 18:22:54 +08:00
Sam
e0e6dae6a7
minor cleanup to previous commit from code review
2018-09-19 16:07:29 +10:00
Sam
5302709343
FIX: in redis readonly raise an exception from DistributedMutex
...
If we detect redis is in readonly we can not correctly get a mutex
raise an exception to notify caller
When getting optimized images avoid the distributed mutex unless
for some reason it is the first call and we need to generate a thumb
In redis readonly no thumbnails will be generated
2018-09-19 15:50:58 +10:00
Guo Xiang Tan
4a92c5b2d6
UploadRecovery should recover attachments too.
2018-09-19 10:44:36 +08:00
Vinoth Kannan
4383afb769
Merge pull request #6413 from vinothkannans/log-entity-export
...
FEATURE: Log entity export in staff logs
2018-09-19 03:18:28 +05:30
Vinoth Kannan
9281b72308
FEATURE: Log entity export in staff logs
2018-09-19 03:16:45 +05:30
Jeff Atwood
f43b5bb3c1
considerably simplify copy for change owner
2018-09-18 14:15:08 -07:00
Kris
e95d6a12c5
prettier
2018-09-18 13:39:58 -04:00
Kris
8bfb016386
remove trailing spaces
2018-09-18 13:25:50 -04:00
Kris
d20a174a6b
UX: Lighter style for category and tag dropdown nav
2018-09-18 13:11:00 -04:00
Kris
4cf3ef53bc
Prevent spinner in tag dropdown from being squished
2018-09-18 11:27:01 -04:00
Joffrey JAFFEUX
a713c0d366
FIX: ensures onSelect/onDeselect are called
...
This commit also add a FIX and a test for toolbar-popup-menu-options which had a behavior slightly specific.
2018-09-18 11:31:23 +02:00
Sam
7d6b348d0b
SECURITY: correct XSS on long topic titles
2018-09-18 08:54:44 +10:00
Sam
0e9841b995
SECURITY: remove admin memory diagnostics routes
2018-09-18 08:35:09 +10:00
Joffrey JAFFEUX
2ff2c49908
Revert "FIX: ensures onSelect/onDeselect are called"
...
This reverts commit 52eed73294
2018-09-17 22:14:41 +02:00
Kris
7f420b61cb
Removing unneeded theme intro text
2018-09-17 12:00:20 -04:00
Neil Lalonde
6f1b8ad16d
FIX: tag groups page should only be visible to staff
...
No security concern here because nothing private was visible,
and no actions could be taken by non-staff users.
2018-09-17 11:41:18 -04:00
Régis Hanol
4481836de2
FEATURE: new 'search_ignore_accents' site setting
2018-09-17 10:42:30 +02:00
Joffrey JAFFEUX
52eed73294
FIX: ensures onSelect/onDeselect are called
2018-09-17 10:36:14 +02:00
Kyle Zhao
7a0232249a
extract inline JS that's used to store preloaded data ( #6370 )
2018-09-17 16:31:46 +08:00
Joffrey JAFFEUX
01913b9dc0
FIX: improves themes/components UI on mobile
2018-09-17 10:05:18 +02:00
Kyle Zhao
7b19ed06c1
reworked specs of existing group behavior
2018-09-17 17:46:43 +10:00
Kyle Zhao
6659417807
FEATURE: match user title when primary group changes
...
When primary group changes and the user's title is the previous primary
group's title, change the title to the new primary group's title
2018-09-17 15:08:39 +10:00
Sam
33541c4096
FEATURE: unconditionally omit no-follow for staff
...
Previously TL2 and below staff would have links
no-followed which was never intended
2018-09-17 12:02:20 +10:00
Sam
b63630d70b
use Mixin postfix when importing tags mixin
2018-09-17 10:46:57 +10:00
pmusaraj
0a2efd8ff1
Add async search to tags dropdown, always show selected tag
2018-09-17 10:40:47 +10:00
Joffrey JAFFEUX
e51c676135
refactors trending search report to use SearchLog
2018-09-17 10:19:40 +10:00
Bianca Nenciu
8f39cf6bfc
FIX: Permit unpinning an unlisted topic.
2018-09-17 10:03:06 +10:00
Kyle Zhao
f666d72606
extract inline JS for google tag manager
2018-09-17 09:56:00 +10:00
Kyle Zhao
38c70bfda2
extract inline JS for google analytics
2018-09-17 09:56:00 +10:00
OsamaSayegh
5625461c05
clear error if you can contact theme repo again
2018-09-17 09:49:53 +10:00
OsamaSayegh
c9a5438a88
use woman_artist emoji
2018-09-17 09:49:53 +10:00
OsamaSayegh
c7d81e2682
FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard
2018-09-17 09:49:53 +10:00
OsamaSayegh
ca28548762
feedback (see commit description for details)
...
* fill blank space when no theme is selected
* animate row's height in themes/components list when selecting, and hide children list
* show warning when you move to a different page and have unsaved changes
* refactor `adminCustomizeThemes.show` controller
* allow collapsing/expanding children lists
* fix a bug when adding components to a theme (changed the way it works slightly)
* a bunch of other minor things
2018-09-17 09:49:53 +10:00
OsamaSayegh
a4f057a589
UX: improvements to admin theme UI
2018-09-17 09:49:53 +10:00
Kris
2ef16d0719
button missing no-text class
2018-09-14 20:52:25 -04:00
Jeff Atwood
7e5000b472
change close to delete glyph on associated accounts
2018-09-14 12:01:49 -07:00
Kris
acddbe22c6
FIX: Poll modal date selector width
2018-09-14 13:38:58 -04:00
Sam
419b14e58b
FIX: correctly keep stylesheet cache entries
...
The intent from day one was to keep MAX_TO_KEEP stylesheets per target
however the DELETE statement did not perform target filtering
This meant we often deleted the wrong stylesheets from the cache
2018-09-14 12:54:11 +10:00
Guo Xiang Tan
6a2589353b
Merge pull request #6394 from tgxworld/recover_broken_uploads
...
FIX: Onceoff job to recover missing post uploads.
2018-09-13 18:16:56 -07:00
Guo Xiang Tan
aa1af9fc22
FIX: Onceoff job to recover missing post uploads.
...
This fixes the regression due to 1f636c445b
2018-09-14 09:04:01 +08:00
Régis Hanol
30619c244c
FIX: don't index urls to local files
2018-09-13 18:53:53 +02:00
Joffrey JAFFEUX
a6502ce879
FIX: ensures errors in report initialization fail nicely ( #6392 )
2018-09-13 17:36:55 +02:00
Joffrey JAFFEUX
18fcd483f2
FIX: ensures we have a color for reports ( #6396 )
2018-09-13 17:36:39 +02:00
Joffrey JAFFEUX
7bf8b0d305
FIX: treats users_(by_type|tl) as other reports ( #6391 )
2018-09-13 17:35:54 +02:00
Guo Xiang Tan
2ae7d3a118
Merge pull request #6388 from pmusaraj/drafts-second-user-test
...
Add test to ensure a user cannot see drafts stream of another user
2018-09-13 06:53:44 -07:00
pmusaraj
5bdf476de7
raise error early in drafts controller
2018-09-13 08:40:57 -04:00
Arpit Jalan
d288462abf
Merge pull request #6393 from techAPJ/bad-json
...
FIX: ignore and log bad json values for custom fields
2018-09-13 15:54:01 +05:30
Arpit Jalan
e364547ff7
FIX: ignore and log bad json values for custom fields
2018-09-13 14:26:30 +05:30
Guo Xiang Tan
529e4018f0
DEV: Avoid using send and make the method public instead.
2018-09-13 16:34:32 +08:00
Sam
daa02431df
FIX: remove div used to measure textarea position
...
Also corrects the positioning of autocomplete (when typing @ or emoji)
Previously there were edge conditions where autocomplete would be hundreds
of pixels away due to a bug measuring.
This correct an issue where Firefox ends up having an enormous blank space
at the bottom of topics after editing.
2018-09-13 14:53:32 +10:00
pmusaraj
aa614e393c
return 403 when trying drafts of another user
2018-09-12 13:08:02 -04:00
Joffrey JAFFEUX
38668818a5
FIX: allows forcing unsafe string in select-kit ( #6386 )
...
forceEscape will be defaulted to true before next release.
2018-09-12 12:19:04 +02:00
Guo Xiang Tan
3884e99e88
Add extra protection in Upload#get_from_url.
...
In case the extension goes missing from the URL.
2018-09-12 00:12:14 -07:00
Guo Xiang Tan
b3469bea2d
FIX: Uploads not being linked correctly to posts.
...
Regression due to 1f636c445b
2018-09-11 23:50:23 -07:00
Sam
d1984a0b4d
FIX: display a correct error when attempting to agree on a deferred flag
...
Previously we would raise a 500 error if a moderator tried to agree on a
flag another moderator deferred.
This can happen cause the UX for flags does not live refresh as flags
are handled
2018-09-12 13:16:59 +10:00
Guo Xiang Tan
71185c13b5
Merge pull request #6377 from tgxworld/remove_tif_tiff
...
Drop `tif`, `tiff`, `webp` and `bmp` from supported images.
2018-09-12 09:32:32 +08:00
Guo Xiang Tan
e1b16e445e
Rename FileHelper.is_image? -> FileHelper.is_supported_image?.
2018-09-12 09:22:28 +08:00
Osama Sayegh
16bd3f2cf2
FIX: use current user color scheme when filling theme-color attribute ( #6384 )
...
* FIX: use current user color scheme when filling `meta` attribute `theme-color`
* update manifest.webmanifest colors
2018-09-12 11:04:58 +10:00
Guo Xiang Tan
a033327b93
Manage qunit via yarn.
2018-09-11 15:07:28 +08:00
Sam
e64402cb3b
SECURITY: correct edge case when SSO provides unvalidated emails
2018-09-11 08:24:02 +10:00
Blake Erickson
1d41f3c3fb
Merge pull request #6380 from discourse/rake-destroy-sub-category
...
FIX: Allow `rake destroy:topics` to delete topics in sub-categories
2018-09-10 10:26:04 -06:00
Kris
2b7e50cab8
Prevent fade-out from overlapping button in admin nav
2018-09-10 11:25:41 -04:00
David Taylor
84fc7abb73
FIX: Allow rake destroy:topics to delete topics in sub-categories
2018-09-10 12:52:14 +01:00
Joffrey JAFFEUX
d4080c020f
FIX: sets trends to 7 days instead of 3 ( #6379 )
2018-09-10 10:40:19 +02:00
Guo Xiang Tan
04d26c65e2
Refactor Upload.get_from_url to check length of sha1.
2018-09-10 10:10:39 +08:00
Joffrey JAFFEUX
2ad882113e
FIX: corrects top-referred and trending-search dates ( #6372 )
2018-09-07 16:49:44 +02:00
Neil Lalonde
9e77fd8fc3
FIX: wrong category links on subfolder install in rss feed for a category topic list
2018-09-07 10:03:30 -04:00
Guo Xiang Tan
d788555994
DEV: Manage pretender with yarn.
2018-09-07 16:01:49 +08:00
Guo Xiang Tan
039afe0d2c
Apply prettier.
2018-09-07 15:19:34 +08:00
Sam
879067d000
FIX: check admin theme cookie against user selectable
...
previously admin got a free pass and could set theme via cookie to anything
including themes that are not selectable
this refactor ensures that only "preview" gets a free pass, all the rest
goes through the same pipeline
2018-09-07 10:47:28 +10:00
Gerhard Schlager
797cbf8653
FIX: Remove user fields when anonymizing user
2018-09-07 00:02:56 +02:00
Joffrey JAFFEUX
6c1e70d554
FIX: do no reset tags selection on category selection ( #6369 )
...
We will instead implement a server side solution to this in the future.
2018-09-06 10:35:07 +02:00
Sam
56b6a4779d
FIX: make route to tag more robust
...
There are some edge cases where code would fail here, so adding protection
2018-09-06 17:24:32 +10:00
Guo Xiang Tan
1f636c445b
PERF: Add fast path to find uploads before resorting to LIKE query.
...
For a normal upload url
Before
```
Warming up --------------------------------------
264.000 i/100ms
Calculating -------------------------------------
2.754k (± 8.4%) i/s - 13.728k in 5.022066s
```
After
```
Warming up --------------------------------------
341.000 i/100ms
Calculating -------------------------------------
3.435k (±11.6%) i/s - 17.050k in 5.045676s
```
2018-09-06 14:44:24 +08:00
Guo Xiang Tan
d4b05d7bc5
Always link post to uploads in post process.
...
The operation is cheap anyway so no point skipping.
2018-09-06 14:08:03 +08:00
Guo Xiang Tan
b6a139b581
Fix broken spec.
2018-09-06 12:41:43 +08:00
Guo Xiang Tan
434035f167
FIX: Link post to uploads in PostCreator.
...
* This ensures that uploads are linked to their post on creation
instead of a background job which may be delayed if Sidekiq
is facing difficulties.
2018-09-06 11:18:11 +08:00
Sam
5bdc00c3be
FIX: do not automatically route all actions to hovered posts
...
This feature (hitting d when a post is hovered with mouse deletes) causes a lot of confusion and is very risky.
2018-09-06 10:34:58 +10:00
Kris
8cff3c9bbc
UX: Prevent long names from overflowing post
2018-09-05 17:48:31 -04:00
Joffrey JAFFEUX
e59622f2ba
FIX: deactivate chart trends for now ( #6364 )
2018-09-05 23:33:29 +02:00
Kris
1c65969bb4
post read-state icon alignment
2018-09-05 13:19:36 -04:00
Joffrey JAFFEUX
17087eff2a
FIX: Reset tags on category change ( #6363 )
2018-09-05 17:18:52 +02:00
Gerhard Schlager
3134dd4763
FIX: Wizard didn't change locale when Enter key was used in drop-down
2018-09-05 15:14:09 +02:00
Gerhard Schlager
2801376df5
FIX: Wizard didn't load translations correctly
...
* Translations from the js.* namespace were not found, because the i18n-patches were not loaded.
* The extra-locales didn't use a hash in the URL.
2018-09-05 15:14:09 +02:00
Gerhard Schlager
2c5d9269a0
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 11:44:28 +02:00
Sam
d9c0dc8687
correct prev commit
...
s3. did not exists it is s3-
2018-09-05 16:11:44 +10:00
Sam
83e1315e42
FIX: correct urls in uploads table to point at dualstack
...
Last week we added support for dual stack urls but did not remap the
the old records in the uploads and optimized images table
This caused a few minor edge cases worst was that if you rebaked old
images S3 CDN was not repopulated.
2018-09-05 15:58:04 +10:00
Gerhard Schlager
9d35240620
Revert "FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled"
...
This reverts commit c788737eed
2018-09-05 01:53:22 +02:00
Gerhard Schlager
c788737eed
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 00:47:39 +02:00
Vinoth Kannan
8a952a2cc2
Make prettier happy
2018-09-05 02:00:13 +05:30
Kris
5cf1a9a23a
UX: primary & danger buttons should lighten on hover in dark themes
2018-09-04 16:18:10 -04:00
Vinoth Kannan
d8b543bb67
FIX: redirect to original URL after social signup
2018-09-05 01:44:23 +05:30
David Taylor
4382fb5fac
DEV: Allow plugins to whitelist specific user custom_fields for editing ( #6358 )
2018-09-04 20:45:36 +10:00
Sam
e4498d2a8a
FIX: keep db and job correctly in multisite logs
...
This ensures we report job and db correctly, previously we were
only reporting this on default
2018-09-04 16:05:44 +10:00
Sam
ad70502ab8
FIX: ignore invalid usernames in incoming link tracker
...
If an incoming link username has NULL in it simply ignore it
2018-09-04 12:28:32 +10:00
Guo Xiang Tan
8dc1463ab3
Enable Lint/ShadowingOuterLocalVariable for Rubocop.
2018-09-04 10:16:42 +08:00
Sam
2f5c21e28c
FIX: return a 400 error instead of 500 for null injections
...
Many security scanners like to inject NULL in inputs causing application
to exception out and return a 500
We now handle this exception and render a 400 status back
2018-09-04 12:11:52 +10:00
Sam
3748d3e281
UX: hide associate accounts if second factor is enabled
...
Once second factor is enabled all login via associated accounts is banned
showing this section just leads to confusion
2018-09-04 10:42:39 +10:00
Sam
155eb02c7e
UX: remove auth token log from user page
...
This feature is not quite ready so we are deferring on it for a few more weeks
2018-09-04 10:28:33 +10:00
Vinoth Kannan
fe6c3b7d2e
Make prettier happy
2018-09-04 00:31:41 +05:30
Vinoth Kannan
24a14af15a
FIX: Respect invalidate_oneboxes option for inline oneboxes
2018-09-03 22:33:43 +05:30
Gerhard Schlager
f33433bf9e
Validation of params should restrict to max int ( #6331 )
...
* FIX: Validation of params should restrict to max int
* FIX: Send status 400 when "page" param isn't between 1 and max int
2018-09-03 14:45:32 +10:00
Guo Xiang Tan
59c9051a2e
REFACTOR: Rescue error at the specific spot that is raising the error.
2018-09-03 11:04:58 +08:00
Guo Xiang Tan
7256b3bf68
REFACTOR: Use UserAuthTokenLogSerializer instead of conditionals.
2018-09-03 10:44:22 +08:00
Jeff Atwood
c3a898795a
Merge pull request #6351 from gschlager/btn_primary
...
UX: Primary button didn't have hover effect anymore
2018-09-02 14:26:40 -07:00
Bianca Nenciu
f5e0356fb2
correct miscellaneous issues with user login history
2018-09-02 17:24:54 +10:00
Osama Sayegh
8e70b82baa
FIX: maintain theme preview when refreshing ( #6356 )
2018-09-02 17:23:46 +10:00
Rishabh Nambiar
4194d1f875
UX: Add padding between fa-chevron-up/down and heading for groups page
2018-09-01 10:14:54 +05:30
Gerhard Schlager
16974df1e9
FIX: Resetting site setting didn't remove "overriden" state
2018-09-01 02:09:23 +02:00
Neil Lalonde
f0b551b684
UX: avatar on collapsed user profile was the wrong size
2018-08-31 10:38:58 -04:00
Bianca Nenciu
39414068ff
FIX: User agent browser detection ( #6352 )
2018-08-31 14:49:38 +02:00
Gerhard Schlager
ddfd02ad36
FIX: Deleting backup failed after uploading backup
2018-08-31 13:50:32 +02:00
Gerhard Schlager
91b3f200f4
UX: Primary button didn't have hover effect anymore
2018-08-31 12:14:41 +02:00
Gerhard Schlager
5310b4841d
UX: Show Rollback and Backup buttons on same line
2018-08-31 12:01:59 +02:00
Guo Xiang Tan
5a214a687c
FIX: Exclude UserAuthToken and UserAuthTokenLog in user webhook.
2018-08-31 17:25:56 +08:00
Régis Hanol
6ada825a4d
fix linting
2018-08-31 10:49:44 +02:00
Bianca Nenciu
931cffcebe
FEATURE: Let users see their user auth tokens. ( #6313 )
2018-08-31 10:18:06 +02:00
Sam
b3aab1770f
FIX: set old last modified date for invalid avatars
...
In some cases Akami was holding tight to these invalid avatars,
to avoid this happening we explain the avatar image is ancient
then when a new upload is added it automatically is older than
this.
2018-08-31 17:07:31 +10:00
Sam
e1975e293f
FIX: when uploads are destroyed clear up avatar refs in user table
...
This also auto corrects twice daily when we ensure consistency
2018-08-31 14:46:42 +10:00
Arpit Jalan
6b9aeeea73
bump onebox version
2018-08-31 08:40:36 +05:30
Sam
9b7cab589a
FIX: revert diacritic stripping
...
See more details in test case and at: https://meta.discourse.org/t/discourse-should-ignore-if-a-character-is-accented-when-doing-a-search/90198/16?u=sam
2018-08-31 11:46:55 +10:00
Joshua Rosenfeld
f3afc0cf76
Add raw date to title attribute on old flags page ( #6349 )
2018-08-31 11:01:10 +10:00
Blake Erickson
ae532f8548
FIX: return 422 for an invalid group name on category create
2018-08-30 14:28:55 -06:00
Joffrey JAFFEUX
bb93179609
FEATURE: charts will now use tertiary color ( #6342 )
2018-08-30 14:56:11 +02:00
David Taylor
103509b9dd
SECURITY: Prevent users from modifying custom fields
2018-08-30 12:59:36 +01:00
Guo Xiang Tan
0f812aa768
Make prettier happy.
2018-08-30 15:56:30 +08:00
Guo Xiang Tan
4f81d4cc8e
Minor fixes to Jobs::BulkInvite.
2018-08-30 15:35:16 +08:00
Vinoth Kannan
092fb0c170
Merge pull request #6333 from vinothkannans/rich-text-pasting
...
FIX: Use tight list format for GDocs html to markdown
2018-08-30 12:14:50 +05:30
David Taylor
f0abb4d09a
FIX: Allow user actions to be saved even if the post has nil user
...
This issue made it impossible to delete users if they had flagged a post with nil user
2018-08-30 01:03:32 +01:00
Sam
e6970151a6
FEATURE: allow specifying locale via SSO
...
Use:
locale
locale_force_update
To force user locale on users where SiteSetting.allow_user_locale is enabled
Note: If an invalid locale is specified no action will occur
2018-08-30 09:58:03 +10:00
Jeff Atwood
22110d3106
minor copyedit on pm a/r button
2018-08-29 16:51:38 -07:00
Bianca Nenciu
72ffabf619
UX: Improve email testing admin tool. ( #6308 )
2018-08-29 23:14:16 +02:00
Bianca Nenciu
c1a5a7504e
FIX: Reset email preferences controller. ( #6316 )
2018-08-29 23:10:56 +02:00
Vinoth Kannan
4c99acea1b
FIX: Use tight list format for GDocs html to markdown
2018-08-29 16:21:31 +00:00
Kris
8ff83d174e
FIX: Changing tag name class to data attribute ( #6326 )
2018-08-29 10:49:19 -04:00
Kris
78089e3577
Removing unneeded background color
2018-08-29 08:58:28 -04:00
Gerhard Schlager
b2cf725700
FIX: Don't try to send invite email when invite was deleted
2018-08-29 12:43:12 +02:00
Joffrey JAFFEUX
1281fb964e
FIX: prevents remove user btn to overflow parent ( #6329 )
2018-08-29 10:11:44 +02:00
Vinoth Kannan
26f17150e1
Merge pull request #6327 from vinothkannans/rich-text-pasting
...
FIX: Keep emojis and remove clicks count on html to markdown
2018-08-29 13:38:55 +05:30
Joffrey JAFFEUX
ad34bdca09
UI: minor tweaks to new message participants list ( #6328 )
...
* Icon for button
* Display name when editing on mobile
* Always display name on mobile when less/or 4 participants involved
2018-08-29 10:07:49 +02:00
Vinoth Kannan
fb35b0b3c3
FIX: Keep emojis and remove clicks count
2018-08-29 07:26:25 +00:00
Sam
44cf3cf975
FIX: queue heartbeats in readonly modes
...
If sidekiq is paused or Discourse is in readonly continue to queue
heartbeats
If we do not do that then a master process can end up reaping sidekiq
workers and causing various badness
This also impacts restore which can do weird stuff TM in cases like this
2018-08-29 12:36:59 +10:00
Neil Lalonde
7516f5159e
FIX: /rules route showed error page
2018-08-28 20:40:37 -04:00
Kris
feeaac81df
FIX: Mobile admin menu iOS rendering bug
2018-08-28 16:39:20 -04:00
Kris
3a4a6cb41a
alignment fix
2018-08-28 16:27:34 -04:00
Kris
7deb86ad8b
A more subtle mobile lightbox hint
2018-08-28 15:25:54 -04:00
Sam
740308675b
FEATURE: erode bounce score every time an email is sent
...
Introduces a hidden setting (default is 0.1) that erodes bounce score
every time we send an email. This means that erratic failures are less
painful cause system auto corrects
2018-08-28 17:02:12 +10:00
Kyle Zhao
e25a6e085e
FIX: drop title updates through RSS feeds
...
can create an update loop
2018-08-28 16:25:04 +10:00
Sam
9ab1fb7dfc
FEATURE: correctly store width and height on uploads
...
Previously we used width and height for thumbnails, new code ensures
1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions
Also
- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
Neil Lalonde
ebe7835316
FIX: links in rss feeds are sometimes wrong on subfolder installs
2018-08-27 18:05:15 -04:00
Vinoth Kannan
26e05933cd
FIX: Use proper markdown syntax for image urls
2018-08-28 00:29:26 +05:30
Joffrey JAFFEUX
b12cf08c57
minor css tweak
2018-08-27 16:38:57 +02:00
Joffrey JAFFEUX
4fdc27bab5
UI: improves participants list in messages ( #6320 )
2018-08-27 15:41:34 +02:00
Joffrey JAFFEUX
c8ffe0fda3
FIX: term should be handled as text ( #6321 )
2018-08-27 11:58:46 +02:00
Guo Xiang Tan
cf3b7ccae2
Merge pull request #6295 from nbianca/fix_mobile_images
...
UX: Show only the expand icon in lightboxes on mobile.
2018-08-27 13:07:55 +08:00
Guo Xiang Tan
53a6c31107
Merge pull request #6310 from nbianca/ux_ip_lookup
...
UX: Improve copying from IP lookup component.
2018-08-27 13:04:35 +08:00
Guo Xiang Tan
3584af4e51
Merge pull request #6314 from nbianca/groups_directory
...
UX: Do not show the groups directory if disabled.
2018-08-27 13:00:39 +08:00
Joe
fb0b54f7f8
UX: Styles for user-cards should the same with badges on / off
2018-08-27 11:16:48 +08:00
Joe
1f4af5ab36
UX: Super short tags shouldn't display on same line as title
2018-08-27 10:35:15 +08:00
Sam
4205c528d0
FEATURE: hide enable_personal_email_messages and min_trust_to_send_email_messages
...
These site settings are very hard to explain and only applicable for very
specific Discourse setups.
If an admin "enables staged users" which is used in support scenarios then
all staff can send "messages" directly to an "email".
The setting allows you to extend this to TL4 or any trust level.
Actual use case would be a support type setup with restricted staff. It is
quite rare so hiding this for now and re-evaluate keeping the setting in
2019
2018-08-27 11:38:22 +10:00
Raul Tambre
2271918be2
FEATURE: Use S3 dualstack endpoints
...
Allows S3 without a CDN to serve images from dualstack domains that also support ipv6
2018-08-27 11:22:46 +10:00
Bianca Nenciu
5ccf581e1e
UX: Improve copying from IP lookup component.
...
- Removed trailing whitespaces caused by textarea.
- Clicking the Copy button will show "copied" for 2 seconds.
2018-08-26 22:20:24 +02:00
Bianca Nenciu
5be41faa8c
UX: Do not show the groups directory if disabled.
...
Staff could still the groups directory before.
2018-08-26 00:21:16 +02:00
Kris
64c4171937
add no-text to PM bulk select button
2018-08-25 00:07:35 -04:00
Jeff Wong
c3ba822489
remove debug
2018-08-24 16:46:55 -07:00
Jeff Wong
3743e90316
FIX: second factor input for username password is disabled when hidden.
2018-08-24 16:15:34 -07:00
Kris
faf09bb8c8
Replacing default brown category color
2018-08-24 14:18:14 -04:00
Joffrey JAFFEUX
2dbd75d4d2
minor css tweaks on reports
2018-08-24 17:16:01 +02:00
Neil Lalonde
9bf4333491
FIX: redirect to wrong URL after account creation on subfolder install
2018-08-24 10:34:44 -04:00
Joffrey JAFFEUX
82dcc5cbfa
FEATURE: makes reports loadable in bulk ( #6309 )
2018-08-24 15:28:01 +02:00
James Kiesel
a4001c1ea0
FEATURE: Pop revise modal on post edited notification ( #6287 )
...
* Add revision number to notification url
* Pop modal on route change
* Add semicolon
* Ensure modal pops even when navigating within a topic
* Ensure modal pops when visiting from other page
* Fix eslint errors
* Fix prettier errors
* Add callback for notification item click
* Remove stray revisionUrl function
* Rename to afterRouteComplete
2018-08-24 09:13:07 -04:00
Guo Xiang Tan
932195d828
DEV: Update test case for TopicEmbed.
2018-08-24 09:42:12 +08:00
Guo Xiang Tan
1ba24496ab
Merge pull request #6261 from xrav3nz/fix/topic-embed-import-updates
...
FIX: update TopicEmbed's title and user correctly
2018-08-24 09:32:03 +08:00
Osama Sayegh
e0cc29d658
FEATURE: themes and components split
...
* FEATURE: themes and components split
* two seperate methods to switch theme type
* use strict equality operator
2018-08-24 11:30:00 +10:00
Sam
ac11f8df52
correct regression searching with diacritics
2018-08-24 10:00:51 +10:00
Sam
29315b73c2
FIX: improve last_modified date returned for avatars
...
instead of hard coding a date:
1. For optimized images use the upload date when on s3
2. For not-found use 10 minutes ago to match the expiry
2018-08-24 09:36:11 +10:00
Régis Hanol
c26de01399
Use NFKD normalization instead of NFD
2018-08-24 00:52:53 +02:00
Régis Hanol
bc7b530b0a
FIX: remove diacritics instead of transliterating
2018-08-24 00:38:44 +02:00
Régis Hanol
f4ae53d52b
Return immediately when there's no html to scrub
2018-08-23 18:00:07 +02:00
Régis Hanol
2fcf2b899e
FIX: remove diacritics when tokenizing html for search
2018-08-23 17:13:52 +02:00
Gerhard Schlager
409ee66839
Add optional "ignore_case" parameter to posts:remap rake task
2018-08-23 14:49:17 +02:00
Arpit Jalan
7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
...
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
Arpit Jalan
1a7cd6648b
UX: show full name on /latest page
2018-08-23 14:41:06 +05:30
Joffrey JAFFEUX
07e11a223c
FIX: prefills username for new message on first post ( #6305 )
2018-08-23 11:09:35 +02:00
Gerhard Schlager
3d176d9984
Add missing copy
2018-08-23 09:44:15 +02:00
Guo Xiang Tan
72ed6ae951
Raise an error if update fails.
2018-08-23 15:40:21 +08:00
Guo Xiang Tan
bd66fbef7f
FIX: Post time query filter not set correctly when loaded from params.
...
https://meta.discourse.org/t/before-and-after-are-not-implemented-right-in-search/92515
2018-08-23 14:06:28 +08:00
Osama Sayegh
2711f173dc
FIX: don't allow inviting more than max_allowed_message_recipients
...
* FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows
* add specs for guardian
* user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit)
Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences
* groups take only 1 slot in PM
* just return if topic is a PM
2018-08-23 14:36:49 +10:00
James Kiesel
b2ce33be26
FIX: tag intersection not populating ( #6296 )
...
* Fix for tag intersection not populating
* Fix prettier
* Add acceptance test for tags intersection
2018-08-23 14:22:47 +10:00
Guo Xiang Tan
36a7028f19
FEATURE: Clean up PostReplyKey records.
...
* Default retention of 90 days.
2018-08-23 10:40:02 +08:00
Bianca Nenciu
4436024563
UX: Show only the expand icon in lightboxes on mobile.
2018-08-22 19:21:42 +02:00
Joffrey JAFFEUX
a48059fd8f
FIX: uses localized string for 429 in reports ( #6302 )
...
NGINX was retuning an html page instead of single string for some users. Seems safer to not risk showing anything from server anyways.
2018-08-22 18:13:29 +02:00
Joffrey JAFFEUX
c08dea386b
FIX: better handling of no prev30Days ( #6301 )
2018-08-22 18:00:11 +02:00
Régis Hanol
f01169d6ff
FIX: don't send email when the post was deleted
2018-08-22 13:13:58 +02:00
Joffrey JAFFEUX
774e6bc795
FIX: handle rate limiting from nginx ( #6300 )
2018-08-22 13:10:57 +02:00
Joffrey JAFFEUX
87d443f070
FIX: counters were showing future instead of past ( #6299 )
2018-08-22 12:37:05 +02:00
Joffrey JAFFEUX
599cebf8ad
FIX: better message if request for report is rate limited ( #6298 )
2018-08-22 11:25:12 +02:00
Bianca Nenciu
758fae7f9f
UX: Keyboard shortcuts will automatically select hovered post
2018-08-22 15:47:17 +10:00
James Kiesel
cdea969c6a
FEATURE: Make initial admins TL1
...
* Match register controller TL to rake admin:create
* Don't promote if trust_level > 1
2018-08-22 15:45:24 +10:00
Sam
5a6d1ee257
FIX: defer actions in a static method
...
This avoids capturing a huge closure and passing to defer
2018-08-22 14:36:56 +10:00
Sam
5d96809abd
FIX: improve support for subfolder S3 CDN
2018-08-22 12:31:13 +10:00
Gerhard Schlager
bed34b52b5
UX: Blue "Resend Activation Email" button in wizzard
2018-08-21 22:18:08 +02:00
Régis Hanol
a00d368d0f
remove empty line
2018-08-21 19:46:04 +02:00
Régis Hanol
61447a8046
UX: don't show the whisper toggle when replying to a whisper
2018-08-21 19:35:40 +02:00
Gerhard Schlager
17dc8f2490
UX: Wizard resends activation email when user exists
2018-08-21 19:13:41 +02:00
Régis Hanol
3e436e2daf
FIX: doesn't translate group permission keys
2018-08-21 12:56:56 +02:00
Kyle Zhao
baf413d527
FIX: update TopicEmbed's title and user correctly
2018-08-21 18:31:01 +08:00
Guo Xiang Tan
8bdf14834b
PERF: Restrict number of skipped email log for Jobs::UserEmail.
2018-08-21 11:14:43 +08:00
Guo Xiang Tan
7c69fa8cfd
PERF: Memoize SkippedEmailLog.reason_types.
2018-08-21 10:25:06 +08:00
Guo Xiang Tan
2c70d3f443
Take 2 on ba6f11c521.
2018-08-21 10:06:36 +08:00
Sam
2d96160192
FEATURE: improve API error reporting for invalid records
2018-08-21 11:54:34 +10:00
Kris
45cd141ed6
Need to clear subcategories
2018-08-20 21:07:07 -04:00
Gerhard Schlager
96d1ea03e7
Sorting is hard. This should really fix user profiles.
2018-08-20 18:56:21 +02:00
Gerhard Schlager
209ed105f9
FIX: User profiles didn't work when API keys exist
2018-08-20 18:21:40 +02:00
Bianca Nenciu
dc5fddbfe6
FIX: Do not show an empty modal when an IP address is allowed or blocked. ( #6265 )
2018-08-20 17:37:30 +02:00
Bianca Nenciu
860c1c3dcd
FEATURE: Automatically expire keys if not used for a configurable amount of time. ( #6264 )
2018-08-20 17:36:14 +02:00
Misaka 0x4e21
1d913d3204
UX: Allow admin to copy IP address details of a user. ( #6270 )
2018-08-20 17:29:20 +02:00
Gerhard Schlager
5ed582551a
FIX: SpamRulesEnforcer should use default locale
2018-08-20 15:08:12 +02:00
Gerhard Schlager
cc851af750
FIX: HTML lang attribute expects hyphen instead of underscore
2018-08-20 13:55:58 +02:00
Gerhard Schlager
14af90df5b
UX: Stop putting usernames in edit reason when changing post owner
2018-08-20 12:28:04 +02:00
Guo Xiang Tan
b4f92a05b3
FIX: Load more on groups page does not account for params.
...
https://meta.discourse.org/t/cant-scroll-through-list-of-users-groups-if-more-than-one-page/92259
2018-08-20 17:08:50 +08:00
Guo Xiang Tan
658b55c406
FIX: Search does not retrigger when context has changed. Take 2.
...
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-20 15:46:02 +08:00
Sam
ce4b12ae59
FIX: if we have not target available do not redirect
2018-08-20 13:10:59 +10:00
Guo Xiang Tan
9c3ba98ef1
FIX: User can't save gravatar as profile picture after refresh.
...
https://meta.discourse.org/t/gravatar-issue-cant-save-changes/95076
2018-08-20 10:29:50 +08:00
Sam
8b5e42ea16
FIX: always test and coerce to image on upload
...
In the past the filename of the origin was used as the source
for the extension of the file when optimizing on upload.
We now use the actual calculated extension based on upload data.
2018-08-20 12:18:59 +10:00
Bianca Nenciu
975a72ab7a
FEATURE: Make links indexable. ( #6285 )
2018-08-20 10:39:19 +10:00
Kris
a15a43605e
Simplifying category page markup
2018-08-17 23:07:07 -04:00
David Taylor
e7e8f4ef4c
Add plugin API for handling uploads with specific file extensions
2018-08-17 16:08:47 +01:00
Joffrey JAFFEUX
37d4f27c44
FIX: quality/bugfix dashboard/reports pass ( #6283 )
2018-08-17 16:19:25 +02:00
Guo Xiang Tan
16c0ebe8a8
Fix the build.
2018-08-17 16:53:07 +08:00
Bianca Nenciu
b69f72853f
UX: Show static page title. ( #6273 )
2018-08-17 10:47:11 +02:00
Sam
9628c3cf97
FEATURE: automatically correct extension for bad uploads
...
This fixes with post thumbnails on the fly
2018-08-17 14:00:27 +10:00
Régis Hanol
93201d8dbe
FIX: don't trigger 'flag_reviewed' when no flags were reviewed
2018-08-16 18:11:29 +02:00
Joffrey JAFFEUX
3fbf7b164d
FEATURE: emoji 11.0 "recently added" update ( #6275 )
...
Adds support for emojis in the http://www.unicode.org/emoji/charts-11.0/emoji-released.html list
2018-08-16 11:59:45 +02:00
Sam
baa72d18f8
FIX: simplify so we ban all auth paths
...
previously plugins that have auth paths were not disallowed and robots
tend to call them
2018-08-16 19:16:47 +10:00
Sam
f62073a22a
correct regression uploading images
2018-08-16 18:49:08 +10:00
Sam
796164b58c
FIX: automatically correct bad avatars on access
...
Also start relying on upload extension for optimized images
2018-08-16 16:32:56 +10:00
Kris
8e240af3ea
FIX: z-index fix for tag input on mobile
2018-08-16 01:17:15 -04:00
Kris
8c46ecf7f3
UX: Improving tag topic list navigation consistency
2018-08-16 00:02:26 -04:00
Sam
1f17b84b63
FEATURE: more context for error reporting on jobs fails
2018-08-16 12:38:49 +10:00
Rafael dos Santos Silva
c8b5e6baae
FEATURE: Use display: browser in webmanifest for iOS devices
...
Since iOS doesn't have a back button and can have issues on log in.
See https://twitter.com/firt/status/1021477243909033984
2018-08-15 23:36:08 -03:00
Kris
7b412727bb
Fixing HTML structure of tag filtered topic list
2018-08-15 19:45:37 -04:00
Sam
243fc9d0f9
FIX: refreshing auto groups when min_username_length is long
2018-08-15 16:59:56 +10:00
Sam
33b5cc6bbd
FIX: Add gif to list of allowed decoders
2018-08-15 13:56:57 +10:00
Sam
cf788582cc
DEV: split optimize image failure warnings in logs
2018-08-15 13:27:24 +10:00
Misaka 0x4e21
d4fd19d49a
UX: Replace Google search with Discourse search on not found page
...
* UX: Replace Google search with Discourse search on not found page.
* FIX: Update application_controller_spec.rb.
2018-08-15 11:53:04 +10:00
Régis Hanol
12bab65167
FIX: going from /categories to /latest on mobile might break infinite scrolling
2018-08-15 01:22:03 +02:00
Gerhard Schlager
c358421ca5
FIX: Bulk updating category failed when topic title was too short
2018-08-14 16:37:52 +02:00
Joffrey JAFFEUX
7290765a62
FIX: uses touchstart/mousedown for selected tags ( #6268 )
...
It seems to be way more reliable on firefox and safari in the case of hot replaced content not using ember.
2018-08-14 16:16:13 +02:00
Régis Hanol
de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
Sam
ad5f502332
FIX: add a basic validator for topic params
...
This cuts down on log noise when people try out sql injection
2018-08-14 17:01:04 +10:00
Kyle Zhao
983dba37ce
FIX: use BasicUserSerializer for user_badge.granted_by ( #6266 )
...
BasicUserSerializer contains enough information for the badges page,
while UserSerializer issues ~100 SQL queries on the fly when serializing
the field without preloading.
2018-08-14 08:11:14 +10:00
Neil Lalonde
71b65be6f6
SECURITY: prevent use of X-Forwarded-Host to perform XSS
2018-08-13 16:45:22 -04:00
Joe
075d80862f
UX: topic-timer modal style fixes
2018-08-13 14:04:20 +08:00
tshenry
03010571f5
Remove unnecessary code ( #6262 )
...
"border-bottom: none;" gets overridden a few lines below by "border-bottom: 1px solid $primary-low;" making it unnecessary.
2018-08-13 15:43:03 +10:00
Misaka 0x4e21
e26437f334
FEATURE: Do encodeURI on share links
...
Some Discourse-supported sharing platforms such as Twitter are unable to determine the end of a unicode URL. If you post a URL "https://example.org/t/测试/1 " on Twitter, it will be a link of href="https://example.org/t/ "
If the URL contains any unicode character (usually in the slug part) , it must be urlencoded with encodeURI(url) before being passed to source.generateUrl(link, title), or it will be a malformed URL in the sharing tweet.
2018-08-13 15:35:56 +10:00
Joe
7e68062a46
Topic meta-data flexbox fixes ( #6263 )
...
Topic meta-data flexbox fixes
2018-08-13 13:29:46 +08:00
Sam
83fd308963
FEATURE: group error message regarding image optimization failures
2018-08-13 14:48:25 +10:00
Guo Xiang Tan
ba022234c6
Add onceoff job to fix incorrect upload extensions.
2018-08-13 10:44:08 +08:00
Peter Borsa
a6820d8767
Add Hungarian locale ( #6260 )
2018-08-13 01:02:35 +02:00
Gerhard Schlager
6d813c2b52
FIX: Importers failed to import avatars
2018-08-12 22:02:17 +02:00
Gerhard Schlager
448e95b97d
UX: Show anchor icon instead of text when topic bump is disabled
2018-08-11 21:51:13 +02:00
Kris
a960a57c72
Improving category reorder modal layout
2018-08-10 22:09:46 -04:00
Kris
e53983b53b
Alignment fix
2018-08-10 14:00:06 -04:00
Gerhard Schlager
b73950692b
FIX: Parsing non-existent feed should not fail
2018-08-10 18:37:14 +02:00
Osama Sayegh
865cb3feb9
FIX: allow selecting site's default theme from preference
2018-08-10 14:12:02 +03:00
Sam
6f6b4ff988
regression: don't return from a block
...
also clean up some warnings (shadowed var, unused var)
2018-08-10 14:53:55 +10:00
Kris
0451dba27a
Table margin adjustment
2018-08-09 21:24:26 -04:00
Simon Cossar
093c3510e6
Rework moderators activity query ( #6230 )
...
* Order rows in query
* Don't increment revisions when moderator revises their own post
2018-08-10 10:51:31 +10:00
Gerhard Schlager
b9072e8292
FEATURE: Add "Reset Bump Date" action to topic admin wrench ( #6246 )
2018-08-10 10:51:03 +10:00
Misaka 0x4e21
6db623ef6b
UX: Improve category filtering and include subcategories
...
* category_filtering
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
* category_filtering with subcategory topics
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
4. report_posts
5. report_topics
6. report_topics_with_no_response
* category_filtering tests (without subcategory topics)
1. report_posts
2. report_topics_with_no_response
* subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb`
1. `in_category_and_subcategories` in `topic_spec.rb`
2. topics, posts, flags and topics_with_no_response in `report_spec.rb`
2018-08-10 10:50:05 +10:00
Gerhard Schlager
ef4b9f98c1
FEATURE: Allow admins to reply without topic bump
2018-08-10 10:48:30 +10:00
Kris
6ec92d5845
prettier
2018-08-09 20:45:47 -04:00
Kris
2e1049a75a
Minor dashboard style adjustments
2018-08-09 20:43:18 -04:00
Simon Cossar
3cd4dc0f5f
Allow users with group_locked_trust_level to be promoted to tl3 ( #6249 )
2018-08-10 10:42:23 +10:00
Joffrey JAFFEUX
6a2ca60b48
FIX: ember click event not reliably working on fx ( #6256 )
2018-08-09 22:41:35 +02:00
Kris
04658bb2f1
UX: prevent text from wrapping below notification icons
2018-08-09 12:04:34 -04:00
Neil Lalonde
2c4d7225d8
FIX: permalink redirects with subfolder
2018-08-09 11:05:27 -04:00
Neil Lalonde
701c5ae781
UX: admin permalink form can fit on one line
2018-08-09 11:05:27 -04:00
Joffrey JAFFEUX
da1d520d4c
FIX: simplifies mini tag chooser events handling ( #6252 )
2018-08-09 14:23:28 +02:00
Joffrey JAFFEUX
bfcf8ed61b
FIX: prevents focus of input on mobile ( #6251 )
2018-08-09 14:23:09 +02:00
Joffrey JAFFEUX
523acfcea4
FIX: checks on parent visibility instead of filter itself ( #6250 )
2018-08-09 10:45:53 +02:00
Sam
7aef604f7d
regression, if there is not excerpt skip
2018-08-09 15:07:18 +10:00
Sam
ed4c0f256e
FIX: check permalinks for deleted topics
...
- allow to specify 410 vs 404 in Discourse::NotFound exception
- remove unused `permalink_redirect_or_not_found` which
- handle JS side links to topics via Discourse-Xhr-Redirect mechanism
2018-08-09 15:05:12 +10:00
Neil Lalonde
f7b4a2b3ba
FIX: ensure URLs include subfolder in admin emails UI
2018-08-08 16:48:03 -04:00
Kris
b53d3457c8
updating color scheme attribution
2018-08-08 16:01:21 -04:00
Kris
cc96af07d1
Full-width markdown table on mobile
2018-08-08 15:51:11 -04:00
Neil Lalonde
35bef72d4e
FIX: subfolder redirects to wrong URL if the subfolder appears in the slug
2018-08-08 13:41:29 -04:00
Guo Xiang Tan
94622b451a
FIX: Search does not retrigger when context has changed.
...
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-08 17:55:37 +08:00
David Taylor
d3a9596d08
Remove unused import
2018-08-08 10:46:43 +01:00
David Taylor
d4d5088324
FIX: Don't require device capabilities when calculating login methods
2018-08-08 10:37:25 +01:00
David Taylor
575d9e0b1a
FIX: Include parameters in function call
2018-08-08 10:09:22 +01:00
Guo Xiang Tan
ba6f11c521
PERF: Only log the first skipped email when user exceeds daily limit.
...
https://meta.discourse.org/t/cleaning-up-e-mail-logs/39132
2018-08-08 16:25:00 +08:00
Osama Sayegh
0d45826d22
fix theme previewing ( #6245 )
2018-08-08 10:58:45 +03:00
Osama Sayegh
0b7ed8ffaf
FEATURE: backend support for user-selectable components
...
* FEATURE: backend support for user-selectable components
* fix problems with previewing default theme
* rename preview_key => preview_theme_id
* omit default theme from child themes dropdown and try a different fix
* cache & freeze stylesheets arrays
2018-08-08 14:46:34 +10:00
Sam
3f6ad65aec
FEATURE: include excerpt in HTML view for pinned topics
2018-08-08 11:15:49 +10:00
Neil Lalonde
4e6e4a83df
FIX: subfolder digest emails have incorrect URLs
2018-08-07 16:38:17 -04:00
Kris
17d8fea796
Markdown tables should have vertical margin
2018-08-07 16:15:28 -04:00
Kris
48ecad53f2
additional hamburger alignment fix
2018-08-07 09:47:01 -04:00
Joffrey JAFFEUX
67ec81babf
FIX: fixes last backup/last_update dates ( #6242 )
2018-08-07 08:19:52 -04:00
David Taylor
aa9a9a5a72
FIX: Include auth_providers for anonymous users when login_required
2018-08-07 09:24:16 +01:00
Guo Xiang Tan
d5a7b818ba
FIX: Move Jobs::CreateAvatarThumbnails to low priority queue.
2018-08-07 16:05:54 +08:00
Guo Xiang Tan
2b57239389
FIX: Upload's content is the only source of truth for the file type.
2018-08-07 13:15:00 +08:00
Sam
6797395bd0
FIX: staff should be allowed to agree and keep post
2018-08-07 10:05:43 +10:00
Joffrey JAFFEUX
8477501e83
FIX: imrpoves alert-error styles in counters reports ( #6240 )
2018-08-06 16:59:45 -04:00
Joffrey JAFFEUX
7f2f3b8b22
FIX: improves reports resilience ( #6239 )
...
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
2018-08-06 16:57:40 -04:00
Joffrey JAFFEUX
c301111461
FIX: display select kit body if no choices ( #6237 )
2018-08-06 11:22:48 -04:00
Kris
74269ad585
FIX: hamburger menu category alignment
2018-08-06 11:11:29 -04:00
Leo McArdle
9b04921616
FIX: don't require auth providers to set full_screen_login_setting
2018-08-06 10:24:39 +01:00
David Taylor
812add18bd
REFACTOR: Serve auth provider information in the site serializer.
...
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
Guo Xiang Tan
4e11811321
FIX: UserAvatar#update_gravatar! does not update User#uploaded_avatar.
...
https://meta.discourse.org/t/missing-user-profile-pictures/93844/4
2018-08-06 13:29:44 +08:00
Osama Sayegh
18b396ad56
FEATURE: add link to see new commits when updates are available for themes ( #6233 )
...
* FEATURE: add link to see new commits when updates are available for themes
* shorten regexp
2018-08-06 15:29:15 +10:00
Joe
cc77a285ee
UX: improves edit reason contrast in dark themes
2018-08-06 10:53:46 +08:00
Régis Hanol
0cd9e2acb9
fix build
2018-08-04 01:56:26 +02:00
Régis Hanol
bf4d98e89d
FIX: always store topic links using the upload url
2018-08-04 01:29:32 +02:00
Kris
84d822959a
Reducing some specificity, color fix
2018-08-03 17:44:22 -04:00
Joffrey JAFFEUX
066010db7d
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
Kris
072f5ce825
Increase ruby character size
2018-08-03 13:37:08 -04:00
Régis Hanol
535732bdc1
FIX: ensure the 'email_revoked' PM template is customizable
2018-08-03 17:10:20 +02:00
Sam
280c318c49
FEATURE: allow ruby tags in Markdown
2018-08-03 11:47:36 +10:00
Osama Sayegh
880462a41c
FEATURE: display out of date themes on admin dashboard
...
* FEATURE: disaply out of date themes on admin dashboard
* Update copy
2018-08-03 09:53:48 +10:00
Neil Lalonde
864e279aaf
FIX: wrong links to subcategories in top categories section of user summary
2018-08-02 17:38:42 -04:00
Joffrey JAFFEUX
1ca999fdb5
FIX: formats topic report only if we have one ( #6231 )
2018-08-02 08:01:17 -04:00
Sam
0b3d51a8bc
FEATURE: whitelist lang attribute
2018-08-02 16:53:08 +10:00
Kris
9499693baa
Layout works better with auto columns
2018-08-01 22:37:21 -04:00
Joffrey JAFFEUX
60f62f6f36
FIX: improves report-show mobile UI ( #6229 )
2018-08-01 19:54:27 -04:00
Joffrey JAFFEUX
859c98743f
FIX: removes ellipsis from activity-metrics report cells
2018-08-01 19:08:53 -04:00
Joffrey JAFFEUX
8cbe3cbe26
this file shouldn’t have been comitted
2018-08-01 19:01:47 -04:00
Joffrey JAFFEUX
9073e11943
FIX: improves number/percent support in reports
2018-08-01 18:40:59 -04:00
Penar Musaraj
4a872823e7
Improvements to user drafts ( #6226 )
...
* drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels
* use JSON when testing Draft.stream
2018-08-02 07:41:27 +10:00
Kris
8147130412
Group icon misalignment
2018-08-01 17:30:17 -04:00
Kris
d678ef2653
group icon needs margin
2018-08-01 17:05:35 -04:00
Kris
04255d1dce
removing unneeded styles
2018-08-01 16:38:47 -04:00
Kris
f0bea4ae55
Improve PM participant list
2018-08-01 16:20:14 -04:00
Robin Ward
4eef41ea1b
FIX: Error with debouncing mentions
2018-08-01 15:57:24 -04:00
Gerhard Schlager
2ec1aec2be
FIX: Clicking admin wrench in topic footer didn't hide post select box
2018-08-01 21:29:35 +02:00
Dan Ungureanu
1a0ffc5ace
FEATURE: Added method to get multiple values at once from PluginStore. ( #6225 )
2018-08-01 18:42:40 +02:00
Gerhard Schlager
f4ca105498
FIX: Moving posts to existing topic didn't update topic metadata
2018-08-01 18:05:43 +02:00
Robin Ward
d7b463a03d
FIX: Remove unused import
2018-08-01 11:54:47 -04:00
Robin Ward
7c950321d1
FIX: Allow non-english usernames in autocomplete
...
Also add support for username formatters
2018-08-01 11:53:20 -04:00
Neil Lalonde
b829452c75
Merge pull request #6209 from discourse/mini_scheduler
...
REFACTOR: extract scheduler to the mini_scheduler gem
2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX
0b9437cee7
FIX: more resilient/consistent dashboard caching ( #6223 )
2018-08-01 09:45:50 -04:00
Joffrey JAFFEUX
7c7dfa4e5e
FIX: wraps any query with the slow query guard ( #6222 )
2018-08-01 07:39:57 -04:00
Vinoth Kannan
8178444382
Make prettier happy
2018-08-01 15:13:54 +05:30
Vinoth Kannan
8556288397
DEV: Export Tag class to modify methods in plugin
2018-08-01 15:10:15 +05:30
Gerhard Schlager
a115aae45f
Use rchardet instead of charlock_holmes gem
2018-08-01 10:41:20 +02:00
Gerhard Schlager
5d421fb946
FIX: Try respecting charset in HTTP header of RSS feed
2018-08-01 10:41:20 +02:00
Gerhard Schlager
ff942ed2f3
FIX: Try detecting encoding of RSS feed
2018-08-01 10:41:20 +02:00
Penar Musaraj
1f45215537
FEATURE: Drafts view in user profile
...
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
Guo Xiang Tan
70ea153dce
Fix lint.
2018-08-01 12:23:36 +08:00
Guo Xiang Tan
53adbf70f3
FIX: Nav item missing for plugins that don't include a custom filter.
2018-08-01 11:50:14 +08:00
Joffrey JAFFEUX
5febe71baa
FIX: prevents crash if flagger doesn’t exist ( #6219 )
2018-07-31 23:48:54 -04:00
Joffrey JAFFEUX
849f0d00f6
FEATURE: adds revision_count to moderators_activity ( #6218 )
...
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-31 23:40:45 -04:00
Guo Xiang Tan
919e8db686
FIX: Check for group name availability should skip reserved usernames.
2018-08-01 11:09:33 +08:00
Kris
129268ddc6
Highlighted titles too wide on mobile
2018-07-31 21:24:43 -04:00
Joffrey JAFFEUX
2b2a506a7b
FIX: makes dashboard more resilient to errors ( #6217 )
...
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX
0715aa18da
UI: uses tiny avatars for reports ( #6215 )
2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX
37252c1a5e
UI: improves dashboard table reports
...
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
Neil Lalonde
4ad7ce70ce
REFACTOR: extract scheduler to the mini_scheduler gem
2018-07-31 17:12:55 -04:00
Robin Ward
4b166cccc1
FIX: Linting error
2018-07-31 14:19:45 -04:00
Robin Ward
b6bb8df622
FIX: We loosened username restrictions some time ago
...
Additionally, remove `Discourse.User` constant
2018-07-31 13:53:31 -04:00
Vinoth Kannan
ece3cb73df
Rename humburger_menu_categories_count site setting to header_dropdown_category_count
2018-07-31 09:12:30 +05:30
Neil Lalonde
fd29ecb91a
UX: include a flag reason in the post-deleted-by-staff-because-of-flags message
2018-07-30 16:45:46 -04:00
Neil Lalonde
c12a9279f6
post deleted notification regression because controller was agreeing with all flags too early
2018-07-30 16:45:46 -04:00
Vinoth Kannan
c1e62808ed
FIX: Top site categories are displayed in random order
2018-07-31 01:01:03 +05:30
Kris
7368dd8e7d
Prevent activity-metrics stats from wrapping
2018-07-30 14:40:26 -04:00
Joffrey JAFFEUX
c6fd506a15
fix eslint
2018-07-30 13:10:20 -04:00
Joffrey JAFFEUX
2c90a2e5c2
FIX: prevents mini-tag-chooser to catch unwanted focus
2018-07-30 13:03:40 -04:00
Joffrey JAFFEUX
a327393651
fix 1.14.0 prettier offenses
2018-07-30 11:56:48 -04:00
Joffrey JAFFEUX
536f88b95b
Revert "DEV: prettier 1.14.0"
...
This reverts commit 1f899bec21
2018-07-30 11:52:05 -04:00
Joffrey JAFFEUX
1f899bec21
DEV: prettier 1.14.0
2018-07-30 11:09:08 -04:00
Vinoth Kannan
c54b5824d4
REFACTOR: Prioritize unread categories in hamburger menu
2018-07-30 20:20:10 +05:30
David Taylor
6566b2f11a
FEATURE: Allow revoke and connect for Instagram logins
2018-07-30 14:38:53 +01:00
Joffrey JAFFEUX
d494feaa32
FIX: should not be needed as we have itemprop='url'
2018-07-30 09:31:27 -04:00
Arpit Jalan
dfcb2a0d42
FEATURE: include published_time in metadata
2018-07-30 17:09:56 +05:30
Vinoth Kannan
50df2d7241
FIX: Should not include regular categories in top_category_ids array
2018-07-30 16:06:36 +05:30
Maja Komel
04baddf731
DEV: migrate tests to async/await
2018-07-30 12:21:05 +02:00
Vinoth Kannan
176d8ca78d
FIX: Hide muted categories from hamburger menu top categories block
2018-07-30 15:39:37 +05:30
Vinoth Kannan
249b16e8e3
FIX: Hide muted categories from hamburger menu top categories block
2018-07-30 15:37:41 +05:30
Guo Xiang Tan
581cf62bcf
UX: Allow emojis to be displayed in nav-item.
2018-07-30 18:02:34 +08:00
Guo Xiang Tan
ef78268c01
Give ExtraNavItem more control over when it can be displayed.
2018-07-30 17:30:13 +08:00
Arpit Jalan
ba64ebbf10
FIX: preserve whitespace between uploads when the process is complete
2018-07-30 14:49:33 +05:30
Vinoth Kannan
78d91b1daf
UX: Changes in top categories of hamburger menu ( #6200 )
2018-07-30 14:13:00 +05:30
Guo Xiang Tan
acde8d4323
Fix the build.
2018-07-30 15:07:03 +08:00
Guo Xiang Tan
96a0448c52
FIX: Add onceoff job to fix incorrect extension for gravatar uploads.
2018-07-30 14:44:02 +08:00
Guo Xiang Tan
87537b679c
Drop reply_key, skipped and skipped_reason from email_logs.
2018-07-30 11:39:28 +08:00
Guo Xiang Tan
b94633e844
FIX: FileHelper should prioritize response content-type.
...
Request to a URL with `.png` extension may return a jpg
instead causing us to attach the wrong extension to an
upload.
2018-07-30 10:54:36 +08:00
Arpit Jalan
fc3b904e1f
remove "track external right clicks" feature
2018-07-29 15:01:33 +05:30
Joe
3dbaaf0d74
UX: gives wizard language selector more room to expand
2018-07-28 11:51:53 +08:00
Kris
7a1a1eb4c0
improve header scaling with font size
2018-07-27 16:49:28 -04:00
Joffrey JAFFEUX
a8f1b07686
FIX: prevents exception when loading old dashboard ( #6196 )
2018-07-27 16:29:30 -04:00
Kris
3159c46613
Making dataless sections stand out less
2018-07-27 14:55:51 -04:00
Kris
60b2c3207e
larger mobile topic list badges
2018-07-27 13:10:13 -04:00
David Taylor
5f1fd0019b
FEATURE: Allow revoke and connect for GitHub logins
2018-07-27 17:18:53 +01:00
David Taylor
6296f63804
FEATURE: Revoke and connect for Yahoo logins
2018-07-27 16:20:47 +01:00
Vinoth Kannan
a9c959e3e2
Make prettier happy
2018-07-27 20:39:44 +05:30
Vinoth Kannan
bc501038cb
FIX: Remove null value from categories list
2018-07-27 20:00:39 +05:30
Joe
85291e53f1
UX: more categories link alignment
2018-07-27 22:17:29 +08:00
David Taylor
9c72c00206
FEATURE: Revoke and reconnect for Twitter logins
2018-07-27 12:28:51 +01:00
Vinoth Kannan
5b4e13bfcc
Make prettier happy
2018-07-27 13:20:21 +05:30
Vinoth Kannan
c0f7d95bb8
Include subcategories in hamburger menu top categories
2018-07-27 13:05:18 +05:30
Vinoth Kannan
dac29b5ebc
UX: Display only top categories in hamburger menu ( #6146 )
2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX
b7d1864d0a
FIX: simplify filters on admin-report component ( #6193 )
2018-07-27 01:22:00 -04:00
Guo Xiang Tan
6f9a91cbd5
Merge pull request #6175 from vinothkannans/post_approval_webhook
...
FEATURE: Webhook for post approval events
2018-07-27 10:50:49 +08:00
Guo Xiang Tan
ccf76d45f2
FIX: Missing variable outside of begin block.
2018-07-27 08:19:11 +08:00
Joffrey JAFFEUX
262beed1cf
FIX: fixes regression with category filtering ( #6190 )
2018-07-26 19:08:06 -04:00
Joffrey JAFFEUX
59684adc43
FIX: shows disk usage even if no backups taken ( #6189 )
2018-07-26 18:38:55 -04:00
Neil Lalonde
1708ff1808
UX: add a route /rules as an alias for /faq and /guidelines
2018-07-26 15:38:08 -04:00
Joffrey JAFFEUX
56ae826efb
UI: improves no data notice in reports ( #6187 )
2018-07-26 15:26:53 -04:00
Joffrey JAFFEUX
330cf78c83
FIX: don’t break browser history on dashboard visit ( #6186 )
2018-07-26 14:59:28 -04:00
Kris
8d67b20d37
z-index fix
2018-07-26 12:11:40 -04:00
David Taylor
88241f57a3
FEATURE: allow auth plugins to have a site setting for full screen login
2018-07-26 11:11:16 +01:00
David Taylor
63e15aa41a
Add missing semicolon
2018-07-26 10:30:10 +01:00
Maja Komel
e8d82f48bc
add maxlength attribute for 2FA input fields
2018-07-26 10:31:20 +02:00
Vinoth Kannan
af5b88f8e2
Rename approval web hook event type to queued post
2018-07-26 10:29:38 +05:30
Kris
67b6539d98
rounder topic-list badges in iOS
2018-07-25 23:58:23 -04:00
Kris
998b7fb87a
Rounder topic-list badges on mobile
2018-07-25 22:30:30 -04:00
Guo Xiang Tan
f8b367cc9c
Fix the build.
2018-07-26 10:17:51 +08:00
Kris
c5e7c60a37
Fixing profile avatar flair poisition on mobile
2018-07-25 22:00:56 -04:00
Kyle Zhao
1ed3a89ac9
UX: clear topic timer text when manually closing/opening ( #6123 )
...
* UX: clear topic timer text when manually closing/opening
* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
Guo Xiang Tan
30242972d3
Add spec for 4bf3bf6786.
2018-07-26 09:16:14 +08:00
Nick Shearer
def2c977ce
allow auth plugins to have a site setting for if they should be full screen vs popup window
2018-07-25 19:20:11 -05:00
Régis Hanol
f94aeaf6cf
SECURITY: force IM decoder based on file extension - part 3
2018-07-25 23:55:06 +02:00
Régis Hanol
800c57c6ab
SECURITY: force IM decoder based on file extension - part 2
2018-07-25 23:08:02 +02:00
Régis Hanol
4bf3bf6786
SECURITY: force IM decoder based on file extension
2018-07-25 22:00:04 +02:00
Kris
0e84024958
Updating style of theme options in wizard ( #6177 )
2018-07-25 15:32:14 -04:00
Kris
3fd2571abc
Fix typo in color scheme
2018-07-25 15:12:01 -04:00
Joffrey JAFFEUX
ad95c24307
FEATURE: displays a notice if report has no data ( #6178 )
2018-07-25 14:28:41 -04:00
Vinoth Kannan
5059dad8f0
FEATURE: Webhook for post approval events
2018-07-25 23:43:19 +05:30
Joffrey JAFFEUX
6ee1ea96ef
fixes tests ( #6176 )
2018-07-25 14:02:21 -04:00
Joffrey JAFFEUX
01d1f850e9
FEATURE: uses category-chooser for report filtering ( #6174 )
2018-07-25 13:16:35 -04:00
Joffrey JAFFEUX
fa6b7f6b8c
DEV: adds Object.entries and Object.assign polyfills ( #6173 )
2018-07-25 11:45:29 -04:00
David Taylor
0d0d78841b
FIX: Remove plugin.enabled? checks at initialization time ( #6166 )
...
Checking `plugin.enabled?` while initializing plugins causes issues in two ways:
- An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times.
- In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster.
Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods.
I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality:
- `post_custom_fields_whitelist`
- `whitelist_staff_user_custom_field`
- `add_permitted_post_create_param`
2018-07-25 16:44:09 +01:00
Joffrey JAFFEUX
796639a797
FIX: makes disk_space computation more resilient ( #6172 )
2018-07-25 11:04:01 -04:00
David Taylor
fa399ce1c5
FEATURE: Add revoke and reconnect functionality for google logins
2018-07-25 16:03:14 +01:00
Joffrey JAFFEUX
578c8e861b
FIX: refreshes disk_space on backup create/destroy ( #6169 )
2018-07-25 08:26:30 -04:00
Régis Hanol
637850d867
REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal
2018-07-25 12:38:15 +02:00
Gerhard Schlager
9989c8179d
FIX: Translation for default (light) color scheme was missing
2018-07-25 11:28:14 +02:00
Dan Ungureanu
44a5c29d42
Clear old text and URL when showing up the "Insert Hyperink" modal. ( #6138 )
2018-07-25 17:12:49 +10:00
Dan Ungureanu
f540020d1d
Add different trigger for the emoji popup of French users. ( #6140 )
2018-07-25 16:39:06 +10:00
Gerhard Schlager
1ac643d71c
FIX: Email template for "Queued Posts Reminder" was not found
2018-07-24 17:26:52 +02:00
Régis Hanol
8ca25f5aed
UX: open the change avatar modal when clicking the profile picture
2018-07-24 15:13:21 +02:00
Joffrey JAFFEUX
7a3c541077
UX: Preview multiple color schemes in wizard ( #6151 )
...
It was a dropdown to provide choices of color schemes,
and only one scheme could be shown.
With this commit, multiple color scheme previews can be displayed on
one page at the same time, making admins choose color schemes more
easily.
Theme preview windows are shrinked.
Imported default color schemes.
Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>
2018-07-24 09:00:20 -04:00
Gerhard Schlager
c3b6811651
PERF: Split loading of posts to speed up user renames
2018-07-24 11:57:04 +02:00
Guo Xiang Tan
fa19d3a53c
Merge pull request #6108 from discourse/transaction-sidekiq-fix
...
Fix notifications for topics moved between categories
2018-07-24 17:44:03 +08:00
David Taylor
20a21b1240
Move into MiniSQLMultisiteConnection, and add test for rollback
2018-07-24 09:41:55 +01:00
Guo Xiang Tan
98f84d1a4e
Update annotations.
2018-07-24 15:49:55 +08:00
Guo Xiang Tan
7a2bf8e368
Fix invalid query syntax when CategoryCustomField#value is blank.
2018-07-24 14:48:27 +08:00
Guo Xiang Tan
663d78414b
Merge pull request #6104 from tgxworld/split_up_reply_key_from_email_logs
...
PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.
2018-07-24 14:33:48 +08:00
Guo Xiang Tan
fad9c2b971
PERF: Move EmailLog#reply_key into new post_reply_keys table.
2018-07-24 13:51:53 +08:00
Guo Xiang Tan
5760873580
Fix linting.
2018-07-24 13:43:52 +08:00
Guo Xiang Tan
ae8b0a517f
PERF: Split skipped email logs into a seperate table.
2018-07-24 13:14:37 +08:00
Guo Xiang Tan
9b84e78fdf
Update annotations.
2018-07-24 11:14:19 +08:00
Sam
95720e3873
lint files
2018-07-24 10:57:16 +10:00
Kyle Zhao
c9d4288214
UX: auto fix order when reordering categories ( #6149 )
...
* set correct position number when moving up/down
* UX: drop 'fix order' and auto re-order subcategory
- auto "fix position" on save
- place subcategories after parent category and maintain the relative
positions on save
2018-07-24 10:25:40 +10:00
Neil Lalonde
f4b5eccad3
FIX: categories page crawler view had incorrect URLs
2018-07-23 14:54:41 -04:00
Joffrey JAFFEUX
568276fe40
FEATURE: allows tag editing on mobile ( #6148 )
2018-07-23 14:25:21 -04:00
Joffrey JAFFEUX
73d736c8c3
FIX: popup-menu instantly closing ( #6147 )
2018-07-23 14:19:36 -04:00
Joffrey JAFFEUX
78419f677d
FIX: multiple select-kit fixes on mobile
2018-07-23 12:19:40 -04:00
David Taylor
eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 ( #6099 )
...
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX
32062864d3
FIX: removes system from user to user report ( #6144 )
2018-07-23 10:33:12 -04:00
Régis Hanol
9b2d6053da
UX: don't show the avatar section when overriden by SSO
2018-07-23 12:03:43 +02:00
David Taylor
d7b5a374c2
Fix indentation
2018-07-23 10:42:15 +01:00
Vinoth Kannan
84ab825e41
FEATURE: Webhook for user destroyed event ( #6124 )
2018-07-23 13:19:49 +05:30
Sam
caa669cf29
FIX: if exclude_category_ids is specified pass it through
...
This allows us to optionally show all topics on latest even if stuff is
suppressed via a plugin
2018-07-23 17:23:00 +10:00
Dan Ungureanu
ba73d91e3b
FIX: Display tag related actions only if tagging is enabled. ( #6136 )
...
The affected buttons are "Replace Tags" and "Append Tags".
2018-07-23 12:35:08 +10:00
Vinoth Kannan
f8e9190617
FEATURE: Retry web hook when it is failed
2018-07-23 10:12:04 +08:00
Neil Lalonde
8e5e7c6b43
add links to Top Categories on user summary page
2018-07-22 22:00:41 -04:00
Kris
31a597797c
Raising z-index of bulk select button
2018-07-22 21:40:50 -04:00
Sam
35bc72ef30
lint file
2018-07-23 10:58:24 +10:00
Dan Ungureanu
b14cd2f179
FEATURE: Make the login error message more informative if cookies are disabled
2018-07-23 10:50:41 +10:00
Blake Erickson
37b726982d
Fix silence and unsilenced response bodies
...
Both response bodies had a typo that included suspended_at, so I renamed
it to silenced_at.
2018-07-22 16:08:36 -06:00
Joffrey JAFFEUX
06323f9c89
FIX: takes old dashboard out of caching job
2018-07-21 12:42:03 -04:00
Joffrey JAFFEUX
0972dd2552
FIX: takes dashboard-next out of caching job
2018-07-21 11:13:15 -04:00
Joffrey JAFFEUX
9ed4071713
fixes dashboard next spec ( #6132 )
2018-07-21 10:29:58 -04:00
Guo Xiang Tan
5c1bd38d84
Merge pull request #6131 from jjaffeux/lazy-load-reports
...
FIX: lazy load more reports in dashboard
2018-07-21 17:24:17 +08:00
Maja Komel
368d4e8eae
FIX: notify staff about whispers in watched categories ( #6128 )
2018-07-21 11:20:21 +02:00
Simon Cossar
d705f859db
Exclude System user from post_edits report ( #6130 )
2018-07-21 11:17:25 +02:00
Guo Xiang Tan
9afc4cf8c1
Revert "add links to Top Categories on user summary page"
...
This reverts commit 1e37395517
2018-07-21 15:50:09 +08:00
Joffrey JAFFEUX
1d5096eb46
FIX: lazy load more reports in dashboard
2018-07-20 23:35:53 -04:00
Kris
c6fe6a8820
Improving mutli-post select styling
2018-07-20 16:37:43 -04:00
Joffrey JAFFEUX
5e521f8ce6
Revert "FIX: various select-kit corrections on mobile"
...
This reverts commit 78a2324c89
2018-07-20 15:28:12 -04:00
Neil Lalonde
1e37395517
add links to Top Categories on user summary page
2018-07-20 15:27:03 -04:00
Joffrey JAFFEUX
78a2324c89
FIX: various select-kit corrections on mobile
2018-07-20 14:46:25 -04:00
Joffrey JAFFEUX
3fdc4f2df1
FIX: do not automatically infere date type ( #6127 )
2018-07-20 09:35:14 -04:00
Joffrey JAFFEUX
9d919406c4
FIX: improves trending-search and top-referred on mobile
2018-07-20 09:15:25 -04:00
Joffrey JAFFEUX
3741dd6b59
removes report logging ( #6125 )
2018-07-20 08:16:29 -04:00
Arpit Jalan
7d9c97d661
FEATURE: land on specified category page when creating topic via URL
2018-07-20 15:55:05 +05:30
Guo Xiang Tan
7cf6c2825e
Merge pull request #6106 from OsamaSayegh/watch-when-splitting
...
FIX: topic owner should watch the new topic when moving posts to a new topic
2018-07-20 15:18:59 +08:00
OsamaSayegh
69450750d1
shorter method name and better specs
2018-07-20 10:13:27 +03:00
Joffrey JAFFEUX
d75d1f0b51
FIX: improves moderation tab on mobile ( #6122 )
2018-07-19 23:59:52 -04:00
Joffrey JAFFEUX
4698cccbcf
FIX: improves moderation tab reports alignments
2018-07-19 22:01:48 -04:00
Joffrey JAFFEUX
711df31a9d
FIX: makes top dash titles clickable ( #6120 )
2018-07-19 19:30:26 -04:00
Joffrey JAFFEUX
64f0cf425b
FIX: removes uncessary reports loading ( #6119 )
2018-07-19 19:30:13 -04:00
Joffrey JAFFEUX
2bf971c09f
FIX: makes reports take full width ( #6118 )
2018-07-19 19:29:58 -04:00
Joffrey JAFFEUX
a0793387cf
FEATURE: differentiates pms in moderators activity report ( #6117 )
...
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 19:29:42 -04:00
Régis Hanol
f83a687551
UX: skip the modal and refresh the app when selecting an avatar
2018-07-20 00:37:57 +02:00
Neil Lalonde
dbcf4e2474
FIX: exceptions raised when editing replies were not displaying their error messages
2018-07-19 18:14:08 -04:00
Joffrey JAFFEUX
8893ca6238
FIX: smaller sort buttons
2018-07-19 16:00:45 -04:00
Joffrey JAFFEUX
1a78e12f4e
FEATURE: part 2 of dashboard improvements
...
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
Joffrey JAFFEUX
a2281fbb19
FEATURE: allows to jump to a date in a topic
2018-07-19 16:00:13 +02:00
Guo Xiang Tan
a0a520db26
Fix lint.
2018-07-19 17:55:40 +08:00
Simon Cossar
4bee7fb458
When the dir is set on a list, add padding to both sides ( #6097 )
2018-07-19 17:32:36 +08:00
OsamaSayegh
fa02df9985
FIX: don't suggest groups when inviting to a topic ( #6105 )
2018-07-19 17:02:34 +08:00
Guo Xiang Tan
4765507585
Remove code that is no longer required.
2018-07-19 16:56:53 +08:00
Sam
a755ff7b35
FIX: not checking for 0 correctly
...
0.blank? == false
2018-07-19 07:45:26 +10:00
Maja Komel
fa38891a98
FEATURE: show modal when user without permissions tries to delete their own topic ( #6086 )
2018-07-18 23:31:37 +02:00
David Taylor
5b4b632358
Correct typo
2018-07-18 22:27:55 +01:00
Maja Komel
af1d1db3da
UX: use future date input instead of date picker on feature topic modal ( #6096 )
2018-07-18 23:27:12 +02:00
Maja Komel
a9ebad3f6c
FIX: do not add a moderator post when post is flagged via direct message ( #6100 )
2018-07-18 23:18:14 +02:00
Régis Hanol
c1249d9e1d
make linter happy
2018-07-18 23:07:17 +02:00
David Taylor
32db976156
FIX: Stop race condition when topic notification jobs are scheduled during a database transaction
...
This was not picked up by tests because scheduled jobs are run immediately
and in the current thread (and therefore the current database transaction).
This particular case sometimes occurs inside multiple nested transactions,
so simply moving the offending line outside of the transaction is not enough.
Implemented TransactionHelper, which allows us to use `TransactionHelper.after_commit`
to define code to be run after the current transaction has been committed.
2018-07-18 22:04:43 +01:00
Régis Hanol
af98ab9337
UX: use the pointer cursor when hovering over a selectable avatar
2018-07-18 22:54:35 +02:00
Régis Hanol
facef06d60
UX: reload the page when changing avatar
2018-07-18 22:50:50 +02:00
Neil Lalonde
afc94ac9e4
FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity
2018-07-18 16:39:16 -04:00
OsamaSayegh
547b571d84
FIX: topic owner should watch the new topic when moving posts to a new topic
2018-07-18 15:23:32 +03:00
Régis Hanol
f55ac892e4
make code prettier 🎀
2018-07-18 13:09:16 +02:00
Régis Hanol
6d6e026e3c
FEATURE: selectable avatars
2018-07-18 12:57:43 +02:00
Sam
a24b9981c6
UX: adjust positioning of auto complete vertical
...
On iPad portrait autocomplete would render off screen
2018-07-18 16:41:31 +10:00
Guo Xiang Tan
487ef9773f
Better logging when optimizing image fails.
2018-07-18 14:11:23 +08:00
Guo Xiang Tan
b068a8a771
Fix the build.
2018-07-18 14:03:27 +08:00
Guo Xiang Tan
be71f9ff82
REFACTOR: Don't load entire AR object just to get a column.
2018-07-18 13:53:57 +08:00
Arpit Jalan
7da22e395b
FIX: do not show links with 0 click on topic map
2018-07-18 10:50:01 +05:30
OsamaSayegh
281538ae61
FIX: theme JS should only run when needed global objects exist ( #6098 )
2018-07-18 15:13:47 +10:00
Guo Xiang Tan
3874d40910
Prepare to drop EmailLog#topic_id.
2018-07-18 10:22:24 +08:00
Sam
a66d812b92
pick a better icon for auto bump
2018-07-18 11:15:01 +10:00
Sam
5adf5b527d
FEATURE: support filter_auto_bump_topics event
...
Use this event to filter the list of auto bumped topics.
EG:
on(:filter_auto_bump_topics) do |_category, filters|
filters.push(->(r) { r.where(<<~SQL)
NOT EXISTS(
SELECT 1 FROM topic_custom_fields
WHERE topic_id = topics.id
AND name = 'accepted_answer_post_id'
)
SQL
})
end
2018-07-18 10:56:09 +10:00
Sam
02628883d2
FEATURE: adjust autobump system
...
- We spread out bumping through the day, if you are bumping
4 topics then a topic will be bumped every 6 hours
- We add a small, bumping action at the bottom of the post to
denote a topic got bumped
2018-07-18 10:17:33 +10:00
Robin Ward
bec53426c4
Remove pointless method
2018-07-17 12:34:20 -04:00
Philipp Rudloff
79b08b2679
Set result.target for update (matching _saveNew) ( #6094 )
...
* Set result.target for update (matching _saveNew)
* Add tests for update result including a target property
2018-07-17 11:56:32 -04:00
Guo Xiang Tan
3553375dd2
PERF: Store EmailLog#reply_key as uuid data type.
2018-07-17 17:05:42 +08:00
Guo Xiang Tan
1d74ccaaf8
Add compatibility for ImageMagick7.
2018-07-17 15:50:58 +08:00
Arpit Jalan
7c7509e1bd
FEATURE: update TwitterApi for prettifying like/retweet count
2018-07-17 12:59:40 +05:30
Sam
9f1e8d4f58
FIX: inaccurate tracking of current topic
...
Under some cases we would trigger the "you are replying on a different
topic" when in fact, your were not
2018-07-17 17:24:23 +10:00
Guo Xiang Tan
fe230f29cd
Update annotations.
2018-07-17 13:11:45 +08:00
Evg
b6fba9ecc6
Add plug-in (in search results) ( #6090 )
...
* Add to plugin
Add the ability to use the plugin...
* Edit name
2018-07-17 14:44:39 +10:00
Sam
818bc10107
FIX: count subcategories in breadcrumbs
2018-07-17 12:06:48 +10:00
Sam
292e8a3756
FIX: category list should set category on topic
2018-07-17 10:38:42 +10:00
Sam
91266cdabb
correct auto bump topic logic
2018-07-17 09:33:33 +10:00
Kris
331296e851
Fix for JK highlighting, typo
2018-07-16 14:52:00 -04:00
Kris
35e8d489de
Fixing JK highlighting for Edge
2018-07-16 14:51:05 -04:00
Kris
bd51cd52cd
Hide edit category tabs with display: none;
2018-07-16 12:37:06 -04:00
Gerhard Schlager
d3e04daa95
Add Swahili language
2018-07-16 18:11:38 +02:00
Guo Xiang Tan
c0c263405a
PERF: Store EmailLog#bounce_key as uuid data type. ( #6093 )
...
PERF: Store `EmailLog#bounce_key` as `uuid` data type.
2018-07-16 20:05:54 +08:00
Vinoth Kannan
f3868fd646
FIX: Create empty user_avatar row if not exist
2018-07-16 14:06:49 +05:30
Sam
ac0053f491
FEATURE: navigate to first post and auto bump category settings
...
### navigate_to_first_post_after_read setting for categories
When enabled on categories logged on users will return to OP after
reading the entire category. (useful for documentation categories)
### num_auto_bump_daily
Set a number of topics that will automatically bump daily on a category.
- Every 15 minutes we will check if any category has this setting
- Categories with the setting are shuffled
- We exclude pinned, closed, category description and archived topics
- Maximum of 1 topic for the list of categories is bumped till limit reached per category
- We always try to bump oldest first
- Limit is elastic using a RateLimiter that ensures that we only bump N per day
Also some minor organisation on category settings
Froze strings on category.rb
2018-07-16 18:10:35 +10:00
Sam
259d16a781
we already have another .invisible no need to have 2
2018-07-16 18:10:35 +10:00
Guo Xiang Tan
6761f8ecbf
PERF: Add missing index on user_id for user_second_factors table.
2018-07-16 14:21:07 +08:00
Guo Xiang Tan
214dac05de
Update annotations.
2018-07-16 14:19:07 +08:00
Rishabh
a6c589d882
FEATURE: Add custom S3 Endpoint and DigitalOcean Spaces/Minio support for Backups ( #6045 )
...
- Add custom S3 Endpoints and DigitalOcean Spaces support
- Add Minio support using 'force_path_style' option and fix uploads to custom endpoint
2018-07-16 14:44:55 +10:00
Leo McArdle
21ebb1cd54
FEATURE: Secondary emails support.
2018-07-16 11:09:49 +08:00
Guo Xiang Tan
50e59fb9bd
Fix the build.
2018-07-16 10:12:19 +08:00
Jay Pfaffman
0ed2834c2d
FEATURE: Add users:disable_2factor rake task
...
https://meta.discourse.org/t/admin-locked-out-of-2fa/92156/2?u=pfaffman
2018-07-16 09:56:55 +08:00
Jeff Wong
f3b17b92b7
Fix: delay panning until we can determine direction
2018-07-14 15:57:58 -07:00
Kris
e6d4a09b55
Image was too wide on invite acceptance form
2018-07-13 16:13:13 -04:00
Kris
1ad358fa0a
improving screened email and url section of admin on mobile
2018-07-13 15:25:04 -04:00
Neil Lalonde
7331b0ac07
prettier is offended
2018-07-13 14:57:55 -04:00
Neil Lalonde
8ceed642cb
FIX: wrong url for default logos in header on subfolder installs
2018-07-13 14:21:15 -04:00
Vinoth Kannan
06deffc9da
FIX: returns provider_not_enabled error even if enabled
2018-07-13 22:49:30 +05:30
Guo Xiang Tan
b459a589ab
FIX: jumpToPost no working on megatopics.
2018-07-13 16:16:39 +08:00
Guo Xiang Tan
9647a0a4bc
Remove unnecessary complex method.
2018-07-13 15:34:28 +08:00
Guo Xiang Tan
711371e8c8
FIX: Select+below will ask server for post ids on megatopics.
2018-07-13 15:10:39 +08:00
Kris
c2cfb6ebae
mobile admin cleanup
2018-07-13 01:43:40 -04:00
Guo Xiang Tan
409a30ce1c
FIX: Selecting & moving posts not working on megatopics.
2018-07-13 11:16:43 +08:00
Guo Xiang Tan
18e281606a
UX: Clicking admin menu does not hide select posts box.
2018-07-13 10:56:14 +08:00
Kyle Zhao
2901691e87
FEATURE: per-category approval settings ( #5778 )
...
- disallow moving topics to a category that requires topic approval
2018-07-13 12:51:08 +10:00
Arpit Jalan
db67c87916
fix purge unactivated users subquery
2018-07-13 07:58:58 +05:30
Kris
01fe42d5e2
prettier fix
2018-07-12 16:41:44 -04:00
Kris
b79fedd540
Streamlining some breakpoint mixins
2018-07-12 16:39:16 -04:00
Maja Komel
a611db666b
Merge pull request #6088 from majakomel/edit-category-fix
...
FIX: hidden tooltip was preventing clicks on category settings input field
2018-07-12 21:42:11 +02:00
Maja Komel
967736caf2
FIX: hidden tooltip was preventing clicks on category settings input field
2018-07-12 18:30:32 +02:00
Sam
6bc0f97668
FEATURE: add data-username on user-info blocks
...
This makes it easier to target in CSS
2018-07-12 18:16:05 +10:00
Sam
1f0bbca87e
FIX: on initial load category subcategories were not mapped correctly
2018-07-12 17:59:56 +10:00
Arpit Jalan
ea0498ae93
make prettier happy
2018-07-12 12:42:11 +05:30
Sam
67bc972d74
UX: make sure autocomplete does not render off screen
2018-07-12 17:07:25 +10:00
Arpit Jalan
bd760e98af
FIX: display error message when upload fails in wizard
2018-07-12 12:08:09 +05:30
Sam
87a5cb982c
correct action typo
2018-07-12 16:24:28 +10:00
Guo Xiang Tan
7c8cd9cfdd
Fix the build.
2018-07-12 14:11:42 +08:00
Sam
29eb9dda59
DEV: add deprecation for currentThemeKey
...
This ensures that theme components will not explode when attempting to access this
2018-07-12 15:36:38 +10:00
Kris
a201103127
removing some old styles
2018-07-12 00:53:24 -04:00
Guo Xiang Tan
258e9e35ca
PERF: Make mega topics work without a stream.
...
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld .
2018-07-12 12:46:12 +08:00
Misaka 0x4e21
de4d4747c4
UX: Focus on new topic link that appears on the page via keyboard. ( #6081 )
...
- Add an <a> tag to handle keypress events on new topic indicator.
2018-07-12 14:36:19 +10:00
OsamaSayegh
decf1f27cf
FEATURE: Groundwork for user-selectable theme components
...
* Phase 0 for user-selectable theme components
- Drops `key` column from the `themes` table
- Drops `theme_key` column from the `user_options` table
- Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column.
- Removes the `default_theme_key` site setting and adds `default_theme_id` instead.
- Replaces `theme_key` cookie with a new one called `theme_ids`
- no longer need Theme.settings_for_client
2018-07-12 14:18:21 +10:00
OsamaSayegh
f13a7226db
FIX: display tables in posts history diff ( #6032 )
2018-07-12 14:13:52 +10:00
Joffrey JAFFEUX
1ed4f0ee8a
FIX: datepicker will now default to monday as first day
...
This will be regardless of the user locale. Many users use english forums even if not from the US and would end up having sunday as the first day of the week in the calendar. This commit follows the international standard.
2018-07-11 23:49:52 +02:00
Sam
574d447254
FIX: don't attempt to bump draft sequence if no editor
...
Rare case on old installs
2018-07-11 17:06:49 +10:00
Sam
0c59346478
PERF: reduce querying when creating notifications
...
also style avoid shadowing of vars
2018-07-11 12:38:11 +10:00
Maja Komel
0942e2c795
allow adding tags as a custom subject format for emails ( #5846 )
...
allow adding tags as a custom subject format for emails
2018-07-11 12:24:07 +10:00
Guo Xiang Tan
a17f5052a3
FIX: ignored_columns was called twice.
2018-07-11 09:52:37 +08:00
Kris
6a530b8949
Prevent long strings from overflowing bulk buttons
2018-07-10 17:05:27 -04:00
Neil Lalonde
1021bc5640
FIX: invisible images and incorrect css on password reset and accept invite pages
2018-07-10 11:18:12 -04:00
Neil Lalonde
3b7acbd086
FIX: broken image on password reset page on subfolder installs
2018-07-10 11:10:06 -04:00
Guo Xiang Tan
8f4cb1a742
UX: Timeline lookup on mega topics should use date of current post.
2018-07-10 16:43:20 +08:00
OsamaSayegh
f2cc05c6c6
FIX: ignore self-quotes from the same post when saving ( #6082 )
2018-07-10 16:17:28 +08:00
Maja Komel
ba7a8db0e8
UX: show custom footer on user activity and preferences pages ( #6080 )
2018-07-10 16:14:26 +08:00
Joe
59950b0f95
UX: category description display issue
...
html tags like `<strong>` are displayed on separate lines inside a flexbox with `flex-wrap`
2018-07-10 13:51:46 +08:00
Guo Xiang Tan
5374a0e720
Fix the build.
2018-07-10 09:48:57 +08:00
Jordan Seanor
10bc69a62f
FEATURE: Event on topic merge ( #6057 )
2018-07-10 09:28:57 +08:00
Canapin
6cc860be09
Update user.scss ( #6079 )
...
Prevent user custom fields new lines going under the user avatar on the profile page when the user has no bio.
2018-07-10 08:03:18 +08:00
Guo Xiang Tan
4172e1dd52
FIX: Rename User#usernames that clashes with Group#name. ( #6069 )
2018-07-09 16:54:57 +08:00
Guo Xiang Tan
96aca6d7e6
Remove legacy vote post action code. ( #6009 )
2018-07-09 16:54:18 +08:00
Sam
d9a9682f72
FIX: also count sub categories in hamburger when needed
...
previously there were cases where we suppress subcategories yet don't count them
this leads to confusion
2018-07-09 16:52:55 +10:00
Sam
330e848d4a
FIX: if s3 set via global setting bypass config check in UI
2018-07-09 15:38:06 +10:00
David Taylor
9a813210b9
SECURITY: Do not allow authentication with disabled plugin-supplied a… ( #6071 )
...
Do not allow authentication with disabled plugin-supplied auth providers
2018-07-09 14:25:58 +10:00
michael@discoursehosting.com
81188060d6
Add S3 region eu-west-3 (Paris)
2018-07-09 14:18:35 +10:00
Joe
d36c260dd0
UX: adds flexbox to topic user name fields on mobile
2018-07-09 11:45:00 +08:00
Guo Xiang Tan
6d0732f7b4
Disable service worker on Apple devices for now.
...
The service worker is not used for any features
on Apple devices and we've received multiple reports
of service workers causing problems.
2018-07-09 11:34:16 +08:00
Guo Xiang Tan
0ab42e9185
Revert "DEV: Add param that allows service worker to be removed."
...
This reverts commit cb12f462a2
2018-07-09 11:29:09 +08:00
Guo Xiang Tan
cb12f462a2
DEV: Add param that allows service worker to be removed.
2018-07-09 11:24:06 +08:00
Joffrey JAFFEUX
9f558d7e74
FIX: mixed texts when mixing rtl/ltr text in topic tile on categories page
2018-07-08 08:37:12 +02:00
Joe
4852e5df34
FIX: mobile /admin/users style fixes
2018-07-07 12:28:04 +08:00
Andrew Schleifer
dba22bbde2
rollback changes
...
This reverts:
* 1baba84c438e "fix s3 subfolders harder"
* ea5e57938edf "fix test for absolute_base_url change"
2018-07-06 17:16:40 -05:00
Andrew Schleifer
52e9f49ec1
fix s3 subfolders harder
...
specifically, include the folder in absolute_base_url
2018-07-06 16:28:40 -05:00
Maja Komel
18f5f646b1
FEATURE: allow selecting a tag when moving posts to a new topic ( #6072 )
2018-07-06 18:21:32 +02:00
Maja Komel
7cba4cbcc6
FEATURE: allow selecting a tag when moving posts to a new topic ( #6074 )
2018-07-06 18:21:00 +02:00
Guo Xiang Tan
875008522d
FIX: Discourse.S3BaseUrl did not account for subfolder bucket names.
2018-07-06 15:53:57 +08:00
Guo Xiang Tan
73e30ff4c2
Revert "Rename s3 vars, change condition when displaying s3 uploads"
...
The new variables do not reflect that they represent S3 settings.
This reverts commit 24dfa1b657
2018-07-06 15:53:57 +08:00
Guo Xiang Tan
7163bf9323
FIX: Upload.get_from_url not respective subfolder in s3 bucket names.
2018-07-06 11:37:11 +08:00
Neil Lalonde
eabc8f7fbd
Merge pull request #6023 from misaka4e21/only-staff-can-create-tag
...
FEATURE: Support disabling tag creation for non-staff users.
2018-07-05 11:12:44 -04:00
Patrick Gansterer
28dd7fb562
FEATURE: Create hidden posts for received spam emails ( #6010 )
...
* Add possibility to add hidden posts with PostCreator
* FEATURE: Create hidden posts for received spam emails
Spamchecker usually have 3 results: HAM, SPAM and PROBABLY_SPAM
SPAM gets usually directly rejected and needs no further handling.
HAM is good message and usually gets passed unmodified.
PROBABLY_SPAM gets an additional header to allow further processing.
This change addes processing capabilities for such headers and marks
new posts created as hidden when received via email.
2018-07-05 11:07:46 +02:00
Joe
dc04892a2d
FIX: mobile /admin/users page adjustments
2018-07-05 16:18:51 +08:00
Guo Xiang Tan
af5cd7e548
Unregister old service workers when Discourse.ServiceWorkerURL changes.
2018-07-05 14:57:32 +08:00
Joe
b5d29f7d88
FIX: responsive admin adjustments
2018-07-05 14:32:27 +08:00
Sam
7b26f5086b
PERF: we have no use for topic percent rank
...
Prepare to remove this column
2018-07-05 15:10:19 +10:00
Christoph Holtermann
68bfe0260a
Fix typo ( #6043 )
...
typo: state instead of status
2018-07-05 09:26:48 +08:00
Sam
b54ba4c952
FIX: mentions broken after adding an <abbr> tag
...
A previous shortcut used was not allowing for <abbr and other tags starting with a
If <abbr> appeared anywhere in the text all mentions would fail to link
2018-07-05 09:27:11 +10:00
Joffrey JAFFEUX
4273e30b9a
fix prettier offense
2018-07-04 17:41:07 +02:00
Joe
d8e51095c9
FIX: mobile topic-timer adjustments
2018-07-04 19:23:09 +08:00
Maja Komel
b02b44c966
prettier formatting
2018-07-04 11:03:48 +02:00
Maja Komel
cb89797e9a
FEATURE: shows remaining backup codes in user preferences
2018-07-04 10:45:42 +02:00
Arpit Jalan
b9835cc392
FIX: do not use scheduler for uploading csv file for invite
...
Since the bulk invite process already happens in a dedicated Sidekiq job
2018-07-04 13:28:11 +05:30
Vinoth Kannan
9cc7df13a4
FIX: Unable to add new webhook if the webhooks list is empty
2018-07-04 09:48:11 +05:30
Sam
e72fd7ae4e
FIX: move crawler blocking into anon cache
...
This refinement of previous fix moves the crawler blocking into
anonymous cache
This ensures we never poison the cache incorrectly when blocking crawlers
2018-07-04 11:14:43 +10:00
Sam
7f98ed69cd
FIX: move crawler blocking to app controller
...
We need access to site settings in multisite, we do not have access
yet if we attempt to get them in request tracker middleware
2018-07-04 10:30:50 +10:00
Leo McArdle
c3129444ea
FIX: allow multiple secondary emails
2018-07-03 18:21:35 +08:00
Joe
888a827b93
FIX: removes inline styles applied to "all categories" in category dropdown
...
"all categories" in the category dropdown gets category-like inline styles when category mode is set to "box"
2018-07-03 12:02:50 +08:00
Joe
2bfe700bd6
FEATURE: responsive admin pages
2018-07-03 11:14:53 +08:00
Jeff Wong
2b240e74b5
fix typo
2018-07-02 15:35:24 -07:00
Jeff Wong
42b11fc2c5
Fix: Add pan direction data, do not activate pan when event is not vertical
2018-07-02 15:26:01 -07:00
Joffrey JAFFEUX
b4cb31d999
FIX: disabled topic timeline panning on desktop
2018-07-02 14:52:02 +02:00
Joffrey JAFFEUX
c754ece8f5
FEATURE: drops with-email-link and replaces it by with-email-button
2018-07-02 14:35:50 +02:00
Misaka 0x4e21
cb86c5ae1e
FIX: Fix badge count of other users. ( #6016 )
...
Don't count the current user in "Others with this badge".
2018-07-02 15:34:09 +08:00
Guo Xiang Tan
969e79d7c6
PERF: Do not calculate gaps for TopicViewPostsSerializer.
...
The client doesn't use the gaps results when loading new posts.
2018-07-02 14:01:50 +08:00
Maja Komel
3ddfc12307
unify user preferences views
2018-07-02 15:38:36 +10:00
Guo Xiang Tan
f7322c05ad
FIX: Avoid destroy_all in Jobs::CleanUpUploads.
...
`destroy_all` loads all the relation into memory as once.
See https://github.com/rails/rails/issues/22510
2018-07-02 12:44:36 +08:00
Joe
f3a1b3829a
FIX: composer popup close link overlaps with text
2018-06-30 13:02:10 +08:00
Joffrey JAFFEUX
405998b3fe
FIX: ensures correct icon is displayed on mobile upload shortcut button
2018-06-30 02:26:55 +02:00
Jeff Wong
f4d77037d0
prettierjs formatting
2018-06-29 10:02:52 -07:00
Jeff Wong
d79b54de6c
make linter happy
2018-06-29 09:53:07 -07:00
Jeff Wong
8bdb62ca01
FEATURE: add swipe detection for dismissing mobile topic scroller
2018-06-29 09:44:18 -07:00
Joffrey JAFFEUX
1772b56cda
FIX: minor micro data fixes
2018-06-29 13:41:04 +02:00
Arpit Jalan
7550e9ff95
FIX: purge unactivated users with a message from non-human users
2018-06-29 13:03:04 +05:30
Joe
15bb8954de
FIX: low contrast issues for dark themes in edit history modal
2018-06-29 14:42:26 +08:00
OsamaSayegh
f4369fa99e
FIX: use logo_url settign when present for mobile layout instead of site name
2018-06-29 15:07:10 +10:00
Guo Xiang Tan
d1c3eb6bfa
FIX: Recovering a post does not insert it back into the stream correctly.
2018-06-29 11:41:44 +08:00
hellekin
25cfc98b67
Fix 'asscoiated' typo
...
I know that **Naming is CRITICAL** and that **Refactoring only NOT welcome**.
But since I spotted this (consistent) typo and the change does not affect any
functionality -- I checked the presence of "asscoiated" in the code base, I
guess the first rule trumps the second one.
It also gave me a false pretext to bypass my reluctance to use Google forms and
sign de CLA. Typos hurt the eye.
2018-06-29 11:10:05 +10:00
Sam
6a54da0902
FIX: raise invalid params for bad callback
...
Corrects it so we raise a 400 instead of logged 500 error
2018-06-29 10:43:33 +10:00
Sam
e0bc6590fd
minor cleanup
2018-06-29 10:30:22 +10:00
Sam
982df3c17b
FIX: return status 400 for invalid member params
...
previously error returned was a 500 which is not ideal
and is logged
2018-06-29 10:15:17 +10:00
Robin Ward
5350429870
FIX: Don't replace the wiki button if the user can't edit
2018-06-28 14:48:28 -04:00
Robin Ward
5d1d7e0e7d
PERF: Scanning the id for this is signficantly slower in production
2018-06-28 11:04:40 -04:00
Robin Ward
fd7bb8e656
FIX: Scope the cn to the subfolder
2018-06-28 11:03:36 -04:00
Arpit Jalan
2c971c41f6
FIX: post deletions rate limit per day was not working
2018-06-28 19:21:27 +05:30
Arpit Jalan
a6d50d1ff7
FEATURE: new settings to control posts deletions rate limit
2018-06-28 17:03:37 +05:30
Arpit Jalan
c352f8eb15
FEATURE: rate limit post deletions to 50 per day
2018-06-28 16:38:58 +05:30
Maja Komel
4ca09599af
Add prettier preferences-second-factor-backup.js.es6
2018-06-28 18:32:20 +10:00
Sam
db14e10943
SECURITY: category badges should HTML escape names
2018-06-28 18:15:07 +10:00
Maja Komel
ec3e6a81a4
FEATURE: Second factor backup
2018-06-28 10:12:32 +02:00
Arpit Jalan
c738f92234
Merge pull request #6046 from jjaffeux/tooltip-xss-1
...
SECURITY: prevents XSS when showing tooltip
2018-06-27 18:10:55 +05:30
Joffrey JAFFEUX
b5b847f6d6
SECURITY: prevents XSS when showing tooltip
2018-06-27 14:35:47 +02:00
Guo Xiang Tan
cfa7898c2d
Rename TopicView#last_read_post_id to TopicView#filtered_post_id.
2018-06-27 12:33:57 +08:00
Guo Xiang Tan
cb69888758
PERF: Don't pluck all the columns just to retrieve a single value.
2018-06-27 11:41:35 +08:00
misaka4e21
47cb46671a
FEATURE: Support disabling tag creation for non-staff users.
2018-06-27 07:15:02 +08:00
Arpit Jalan
6bcdc3ba4b
FEATURE: allow author to delete posts irrespective of post_edit_time_limit
2018-06-26 21:43:06 +05:30
OsamaSayegh
d81f8ea378
fix prettier
2018-06-26 15:31:43 +03:00
OsamaSayegh
bfe0178270
FIX: use the correct notification levels titles for PMs
2018-06-26 14:01:52 +02:00
Arpit Jalan
7efdccdbc5
FIX: allow staff to remove tags from queued topics
2018-06-26 17:08:40 +05:30
OsamaSayegh
a603660ba5
FIX: scroll to top when accessing admin dashboard
2018-06-26 12:19:58 +02:00
Joffrey JAFFEUX
eb9b99e519
FIX: makes select-kit match searches with accents (filter and content)
2018-06-26 12:19:14 +02:00
Guo Xiang Tan
49ffc1eb61
Revert "PERF: Send down gaps as the relevant posts load instead of front loading."
...
This reverts commit 4c3352528e
2018-06-26 12:54:14 +08:00
Guo Xiang Tan
4c3352528e
PERF: Send down gaps as the relevant posts load instead of front loading.
2018-06-26 12:49:06 +08:00
Guo Xiang Tan
0b6a2e9d1f
Remove force summary mode for megatopics for now.
...
The logic is too hairy and we can't reliably determine
when to force summary mode. Work is underway to improve
perf for megatopics so this will not be required
eventually.
2018-06-26 12:49:06 +08:00
Maja Komel
24dfa1b657
Rename s3 vars, change condition when displaying s3 uploads
2018-06-25 17:16:01 +02:00
Kris
a0b799810b
post-info glyph margin fix
2018-06-25 10:50:16 -04:00
Joffrey JAFFEUX
803968147c
FIX: ListItem can’t have itemprop=url and itemprop=item together
2018-06-25 14:12:55 +02:00
Joffrey JAFFEUX
666386d4b7
FIX: allows more chars than a-z in select-kit
2018-06-25 12:52:20 +02:00
Guo Xiang Tan
d08b596e47
Remove unused function in post-stream.js.es6.
2018-06-25 17:23:34 +08:00
Ernesto Serrano
c5e24da5dd
Update poll_mailbox.rb
2018-06-25 16:18:07 +10:00
David Lee
4644d777bd
FEATURE: add website field to SSO
2018-06-25 16:09:39 +10:00
Leo McArdle
329c94a354
add user-preferences-emails-pref-email-settings outlet
2018-06-25 16:02:03 +10:00
Sam
85d97caa56
lint file
2018-06-25 15:35:45 +10:00
OsamaSayegh
d58ff44b04
Simplify to only support topics list for now
2018-06-25 15:02:22 +10:00
OsamaSayegh
b4a13a1afa
UX: keyboard shortcuts (j/k) should work with /categories
2018-06-25 15:02:22 +10:00
Christoph Holtermann
bed26ea0b3
fix indentation
2018-06-25 15:01:39 +10:00
Christoph Holtermann
a0af15d525
no redeclaring state
2018-06-25 15:01:39 +10:00
Christoph Holtermann
e874afaf31
read embed state info from data attribute
2018-06-25 15:01:39 +10:00
Christoph Holtermann
6eb0b310fe
add data attributes to reflect embed status
2018-06-25 15:01:39 +10:00
Christoph Holtermann
5914a3db20
Update embed.html.erb
...
Small fix
2018-06-25 15:01:39 +10:00
Christoph Holtermann
2244f19ff9
Update embed.html.erb
...
Add state descriptor to message being sent to parent window
2018-06-25 15:01:39 +10:00
Joffrey JAFFEUX
c722fc5164
FIX: makes sure category and tag drop headers have a title
2018-06-24 22:23:31 +02:00
Jeff Wong
41f76a74f8
FEATURE: send message when a user reaches tl1
2018-06-22 13:20:00 -07:00
Guo Xiang Tan
6597cc4cd0
Fix the build.
2018-06-22 13:42:43 +08:00
Guo Xiang Tan
cb622ead43
Make prettier happy.
2018-06-22 11:37:43 +08:00
Guo Xiang Tan
f69356e628
FIX: Users can't "show all posts" in forced summary topics.
2018-06-22 11:32:45 +08:00
Guo Xiang Tan
bad6a5142c
PERF: Don't include entire post stream when we're loading more posts.
2018-06-22 10:49:03 +08:00
Guo Xiang Tan
657c8a013a
UX: Don't display an empty participants section.
2018-06-22 10:16:43 +08:00
Guo Xiang Tan
4c6a0a4046
UX: Don't display participants count if it is zero.
...
This can happen for megatopics where we don't send
down the payload for participants count.
2018-06-22 08:32:20 +08:00
Joffrey JAFFEUX
fed86225c8
FEATURE: differentiate total and total for period on admin table report
2018-06-21 22:46:53 +02:00
Jeff Wong
bc52bdfa12
Feature: unconditionally consider TL0 users as "first day" users
2018-06-21 10:53:08 -07:00
Joffrey JAFFEUX
a41057aa6e
FEATURE: display report total value when showing report
2018-06-21 18:17:22 +02:00
Kris
5d0d56e474
removing unneeded line-height
2018-06-21 10:37:30 -04:00
Guo Xiang Tan
68388dfd25
Fix the build.
2018-06-21 15:57:59 +08:00
Guo Xiang Tan
71908cd634
Make prettier happy.
2018-06-21 15:37:24 +08:00
Guo Xiang Tan
9a7a079f4d
Force summary mode when user enters at the top of megalodoon topics.
2018-06-21 15:18:52 +08:00
Guo Xiang Tan
f7d22bad90
FEATURE: Forced summary mode for megalodon topics.
...
This is mainly done for performance reasons and megalodon
topics are usually a byproduct of imports where site setting
limits are not respected.
2018-06-21 14:00:20 +08:00
Guo Xiang Tan
ac80360bea
PERF: Help postgres make use of index in Post.summary.
2018-06-21 13:29:16 +08:00
Guo Xiang Tan
6ddd214476
FIX: Post#summary returning posts from other topics.
2018-06-21 12:00:54 +08:00
Guo Xiang Tan
c5cc582549
FIX: Participants may not be in topic maps's attributes.
2018-06-21 10:23:55 +08:00
Joffrey JAFFEUX
50d11fd582
FIX: improves durability display check
2018-06-20 23:15:11 +02:00
Joffrey JAFFEUX
95d99de7b4
FIX: hides durability section in dashboard if backups are disabled
2018-06-20 22:26:37 +02:00
Robin Ward
45a2c94fb3
FIX: Margin on post-info should be present in mobile and desktop
2018-06-20 15:39:36 -04:00
Robin Ward
5290138e84
Support for a decorator within the user name
2018-06-20 15:26:37 -04:00
Robin Ward
02cb944fee
FIX: Linting error
2018-06-20 13:44:03 -04:00
Robin Ward
e7fbcf4ba4
UX: Refactor topic metadata's many floats into flexbox ( #6018 )
2018-06-20 13:06:20 -04:00
Joffrey JAFFEUX
2f7960bd2a
DEV: updates prettier and displays linters/prettifiers version in CI
2018-06-20 18:34:49 +02:00
Joffrey JAFFEUX
8126b603e4
fix prettier
2018-06-20 18:26:43 +02:00
Robin Ward
fbc194c330
Don't use !important for wiki color. Allow themes to override it.
2018-06-20 10:47:27 -04:00
Robin Ward
bb11375590
FIX: Don't add undefined as a class name
2018-06-20 10:37:24 -04:00
Guo Xiang Tan
0365806b93
FIX: Properly display error when post action fails to create.
2018-06-20 21:20:23 +08:00
Joffrey JAFFEUX
fa43969fe2
FIX: crashes with date conversion in reports
2018-06-20 14:42:15 +02:00
Guo Xiang Tan
9c925a66ff
PERF: Don't display days ago on timeline for megatopics.
...
Analysis using `pg_stat_statements` showed this query
to be eating up a significant portion of CPU.
2018-06-20 16:25:54 +08:00
Sam
35e0ccfc84
make linter happy
2018-06-20 18:03:27 +10:00
Sam
cb824a6b33
DEV: remove all calls to SqlBuilder use DB.build instead
...
This is part of the migration to mini_sql, SqlBuilder.new is being
deprecated and replaced with DB.build
2018-06-20 17:53:49 +10:00
Joe
5fc4e9e324
FIX: nav-pill dropdown overlaps category-selector when both are open
2018-06-20 13:09:14 +08:00
Jeff Wong
ca4d08f9d9
Make linter happy
2018-06-19 18:07:41 -07:00
Jeff Wong
406c6d679a
FIX: correct display for unlocking on tl0
2018-06-19 17:47:03 -07:00
riking
7f37ee9152
SearchLog: fix specs
2018-06-20 10:44:11 +10:00
riking
38a8e52ca4
FIX: Add time retention limit to search logs
...
3 years is a very conservative limit that allows for a very wide buffer
for year-over-year analysis. The max is set to 5 years because that is
the policy listed for logging in hosted Discourse.
2018-06-20 10:44:11 +10:00
riking
1de0ef137e
FIX: SearchLog: Do not store IP of logged in users
2018-06-20 10:44:11 +10:00
Sam
cbaf521fc1
correct regression and add integrity spec for onceoffs
2018-06-20 09:09:31 +10:00
Kris
b637b57e4f
FIX: Alignment of user dropdown menu icons
2018-06-19 15:38:06 -04:00
Kris
82cb163ef3
formatting fix
2018-06-19 13:07:16 -04:00
Kris
0d81633da9
Replacing onebox loading gif with css spinner
2018-06-19 12:59:00 -04:00
Jeff Wong
2ff226e509
FIX: consider staged users mature (no spam checks) after 1 day
2018-06-19 09:41:10 -07:00
Sam
5f64fd0a21
DEV: remove exec_sql and replace with mini_sql
...
Introduce new patterns for direct sql that are safe and fast.
MiniSql is not prone to memory bloat that can happen with direct PG usage.
It also has an extremely fast materializer and very a convenient API
- DB.exec(sql, *params) => runs sql returns row count
- DB.query(sql, *params) => runs sql returns usable objects (not a hash)
- DB.query_hash(sql, *params) => runs sql returns an array of hashes
- DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array
- DB.build(sql) => returns a sql builder
See more at: https://github.com/discourse/mini_sql
2018-06-19 16:13:36 +10:00
Jeff Wong
68e4e6a575
FIX: staged users are still tl0 but do not trigger spam if 1 week old.
2018-06-18 17:20:04 -07:00
Neil Lalonde
3725fd8345
Merge pull request #6002 from featheredtoast/trust-previously-staged-users
...
FIX: don't punish a user for being previously staged for spam flags.
2018-06-18 15:14:31 -04:00
Jeff Wong
7a1cefce78
Fix: let user fields respond when their labels are clicked
2018-06-18 11:15:22 -07:00
Joffrey JAFFEUX
913d97e780
fix prettier
2018-06-18 20:10:48 +02:00
Kris
ceb9226518
Giving post admin menu variable width in case of long translations
2018-06-18 13:02:50 -04:00
Joffrey JAFFEUX
3fc82bf200
FIX: adds a title to composer actions header
2018-06-18 19:01:37 +02:00
Joffrey JAFFEUX
f2dbe66367
FEATURE: adds a /admin/reports route to list all reports
2018-06-18 12:31:56 +02:00
Joffrey JAFFEUX
4b604b1e68
FIX: displays correct upload icon when only images are allowed
2018-06-18 11:16:34 +02:00
Arpit Jalan
f1d1207725
FIX: improve context when user deletes self
2018-06-18 11:36:22 +05:30
Joe
e8e8d540d3
FIX: desktop pin-topic modal not wide enough for date-picker
2018-06-16 15:19:08 +08:00
Arpit Jalan
a30165ab8d
FIX: show time on activity column instead of random number
2018-06-16 07:12:43 +05:30
Jeff Wong
9e55767f6a
FIX: don't punish a user for being previously staged for spam flags.
2018-06-15 12:25:25 -07:00
Rafael dos Santos Silva
51cb38783e
FIX: start_url was wrong in non-subfolder
2018-06-15 14:29:33 -03:00
Joffrey JAFFEUX
60ff0e9b8c
missing prettified files
2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX
03a7d532cf
DEV: introduces prettier for es6 files
2018-06-15 17:03:24 +02:00
Arpit Jalan
c7ee70941e
FEATURE: show category page options on wizard 'homepage' step
2018-06-15 19:11:41 +05:30
Joe
4645cf6b28
FIX: remove unwanted space in user notification items
2018-06-15 15:44:51 +08:00
Kris
a8660b8be9
formatting build fix
2018-06-15 00:09:09 -04:00
OsamaSayegh
06777aa47d
FIX: use the correct notification levels descriptions for PMs
2018-06-15 14:04:14 +10:00
Kris
872656fe52
Give admin list more horizontal space
2018-06-14 23:50:46 -04:00
Robin Ward
4a4406de8c
FIX: Properly avoid n+1 query on flagged posts
...
This code was in here previously but some columns were included that
were not used.
2018-06-14 09:46:52 -04:00
Joffrey JAFFEUX
c82887a0f0
Revert "tests prettier trigger"
...
This reverts commit f74d86639f
2018-06-14 15:46:03 +02:00
Joffrey JAFFEUX
f74d86639f
tests prettier trigger
2018-06-14 15:15:25 +02:00
Jeff Wong
160898acf3
Feature: add jump to post modal on mobile
2018-06-13 22:01:35 -07:00
Rafael dos Santos Silva
8fc08aad09
FEATURE: Update the webmanifest
...
- Remove share target because the spec is changing
- Allow any orientation again because natural is too restrictive
- Use correct file and mime types for the manifest
2018-06-14 00:13:28 -03:00
Arpit Jalan
94ae89f61f
FIX: properly retrieve user custom fields
2018-06-14 07:33:25 +05:30
Joffrey JAFFEUX
276526e30e
FIX: improves micro data support
2018-06-13 23:20:48 +02:00
Régis Hanol
ff06ce4cce
fix the build
2018-06-13 23:05:23 +02:00
Régis Hanol
051d1a3c36
PERF: faster Screened IP Address roll up
2018-06-13 22:47:23 +02:00
Robin Ward
fd54c92a52
FEATURE: New site setting, whitelisted_link_domains
...
If provided, users who normally couldn't post links (say, due to a
low trust level), can post links to those specific hosts.
2018-06-13 16:11:22 -04:00
Neil Lalonde
debbb5be16
FIX: staff see the wrong message when changing another user's email address
2018-06-13 15:18:48 -04:00
Robin Ward
ae728702a6
Revert "Revert "Preload custom user fields when viewing flag queue""
...
This reverts commit 1bb12ee1b6
2018-06-13 11:44:13 -04:00
Arpit Jalan
4107a02ae8
Merge pull request #5991 from jjaffeux/plugin-sharing-api
...
FEATURE: adds plugin sharing api
2018-06-13 17:24:03 +05:30
Joffrey JAFFEUX
eddcb07f03
FEATURE: adds plugin sharing api
2018-06-13 13:25:51 +02:00
Régis Hanol
f93ba5694e
UX: show quote button at end of selection on Opera
2018-06-13 11:07:19 +02:00
Joffrey JAFFEUX
4e0c06a0b1
FIX: focusing input displayed after clicking on a link more reliable
2018-06-13 10:31:46 +02:00
Maja Komel
6c9190357c
fix get from url for external uploads without CDN
2018-06-13 16:21:28 +10:00
Jeff Wong
0c2f590c64
Feature - allow user and group specific cards styling ( #5989 )
2018-06-13 14:08:03 +08:00
Sam
12fd0b827e
PERF: release results in a couple of cases
2018-06-13 15:11:43 +10:00
Jeff Wong
3d1ff8e0ad
FIX: correct group membership on cards for admins
2018-06-12 14:57:26 -07:00
Joshua Rosenfeld
1bb12ee1b6
Revert "Preload custom user fields when viewing flag queue"
...
This reverts commit 5bd1c5cc95
2018-06-12 16:46:31 -04:00
Robin Ward
5bd1c5cc95
Preload custom user fields when viewing flag queue
2018-06-12 16:17:22 -04:00
Régis Hanol
d8063d09d5
FIX: Add members button wasn't working on mobile for non-admin group owners
2018-06-12 15:05:22 +02:00
Joffrey JAFFEUX
3381a0a42a
UX: reworks dashboard problems section to be in line with new style
2018-06-12 12:47:03 +02:00
Sam Saffron
030e322a39
FEATURE: block top level /my/ routes
2018-06-12 19:47:45 +10:00
Arpit Jalan
59a8471308
FIX: do not show SSO external_email to moderators
2018-06-12 14:20:44 +05:30
Vinoth Kannan
72196ee951
Move the dashboard-problems block outside the condition
2018-06-12 12:01:41 +05:30
Guo Xiang Tan
c06824e9c2
FIX: Clients get stucked in readonly mode if messageBus fails.
2018-06-12 12:02:37 +08:00
kleinfreund
4ce1d230c7
Prefer throwing a new Error object instead of just a string expression
2018-06-12 12:56:22 +10:00
Angus McLeod
0997eb6486
Add theme stylesheet(s) to the crawler layout
2018-06-12 12:47:48 +10:00
riking
94f70c7b5c
FIX: TopicViewItem: do not store IP of logged in users
2018-06-12 12:43:56 +10:00
riking
4b2e2ea8ef
Change TopicViewItem to allow null IP address
2018-06-12 12:43:56 +10:00
Shoshana Berleant
f48338df54
add plugin outlet create-account-after-password
2018-06-12 12:42:37 +10:00
Jeff Wong
4599cc8435
FIX: PM participants listed inline
2018-06-11 18:14:25 -07:00
Jeff Wong
44ee26721a
FIX: add check for missing assets file in development
2018-06-11 11:18:34 -07:00
Gerhard Schlager
150ae21489
FEATURE: Log user merge in staff logs
2018-06-11 18:43:56 +02:00
Joffrey JAFFEUX
73731463a3
UX: makes sure close modal icon is aligned with title
2018-06-11 13:38:57 +02:00
Vinoth Kannan
a6303073a0
Strip images from cooked for topic excerpt
2018-06-11 14:43:53 +05:30
Joe
2ec53a9628
FIX: adjust 2FA input width in mobile login form
2018-06-10 21:33:41 +08:00
Joe
5eb0066be9
FIX: adjust max-width of social login buttons for non-English locals
2018-06-09 14:14:59 +08:00
Gerhard Schlager
a26889ada2
FIX: Don't delete profile views during user anonymization
...
There's no need for that and it can take a lot of time.
2018-06-08 15:50:07 +02:00
Gerhard Schlager
4ba910ac54
Update username only after successful user anonymization
2018-06-08 15:50:07 +02:00
Gerhard Schlager
2564a8285d
REFACTOR: Run some parts of user anonymizing in background job
2018-06-08 15:50:07 +02:00
Gerhard Schlager
cf038cf72a
FEATURE: Remove more PII during user anonymizing
...
Removes
* invite if the user was invited
* email tokens
* incoming emails
* email log entries
* raw emails from posts
2018-06-08 15:50:07 +02:00
Joffrey JAFFEUX
174d392e5a
DEV: adds prettier ( #5956 )
...
Run `prettier --write "app/assets/stylesheets/**/*.scss" "plugins/**/*.scss"` after making sure you installed it with `yarn`
It's recommended to configure your editor to run prettier on file save.
2018-06-08 11:49:31 +02:00
Arpit Jalan
8bd4c11f53
FIX: do not show email disabled notice to staff when they can receive emails
2018-06-08 11:22:26 +05:30
Jeff Wong
b7d92061e2
FEATURE: add an option to create undismissable modals
2018-06-07 20:49:33 -07:00
Angus McLeod
f10b663eb4
BUGFIX: string in server_plugin_outlet needs to be mutable
2018-06-07 18:27:34 +02:00
Arpit Jalan
f9ab3848ed
FEATURE: support disabling emails for non-staff users
2018-06-07 18:31:08 +05:30
Joffrey JAFFEUX
d556975cdc
FIX: do not use number helper for charts Y value
2018-06-07 14:56:49 +02:00
Joffrey JAFFEUX
74ced977be
FIX: incorrect backup and update times on dashboard
2018-06-07 11:18:17 +02:00
Joffrey JAFFEUX
1071aa21ab
FIX: slightly safer rounding
2018-06-07 10:59:17 +02:00
Joffrey JAFFEUX
ab089cd68b
FIX: makes format number round the value before using parseInt
2018-06-07 10:44:21 +02:00
Joe
c3ac32d991
FIX: user-fields layout in desktop create account form
2018-06-07 14:03:54 +08:00
Guo Xiang Tan
ad5082d969
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
Sam
89ad2b5900
DEV: Rails 5.2 upgrade and global gem upgrade
...
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated
Performance testing shows that performance has not regressed
if anything it is marginally faster now.
2018-06-07 14:21:33 +10:00
Joe
56dbbfbd2a
FIX: user-fields layout in mobile create account form
2018-06-06 21:02:35 +08:00
Vinoth Kannan
d8e641cd98
FIX: avatar_url includes upload_path twice when local storage used
2018-06-06 18:27:30 +05:30
Guo Xiang Tan
a83ab01264
REFACTOR: Remove extra param for group mentionable and messableable route.
2018-06-06 09:42:09 +08:00
Arpit Jalan
ccbaa719ee
Merge pull request #5923 from techAPJ/group-messageable
...
FIX: do not verify group visibility when checking for mentionable/messageable
2018-06-06 06:45:22 +05:30
Neil Lalonde
9ba9ff187c
Add plugin outlet to admin plugins index
2018-06-05 17:47:30 -04:00
Arpit Jalan
f8d82f135f
FIX: do not verify group visibility when checking for mentionable/messageable
2018-06-05 16:59:21 +05:30
Guo Xiang Tan
d600e71b3d
FIX: Clean up stale UserExport records daily.
...
* Add tests for `UserExport.remove_old_exports`
2018-06-05 09:43:40 +08:00
Rafael dos Santos Silva
74c33a5316
Merge pull request #5915 from jjaffeux/sharing-macos-chrome
...
FIX: sharing popup not showing on macos/chrome
2018-06-04 20:38:10 -03:00
Joffrey JAFFEUX
40b3efacaa
FIX: sharing popup not showing on macos/chrome
...
Despite `navigator.share` being defined the call was failing with this error:
```
sharing DOMException: Internal error: could not connect to Web Share interface.
```
2018-06-05 01:18:57 +02:00
Robin Ward
fab59c66f0
FIX: Protection against dangling category group records
2018-06-04 15:43:26 -04:00
Régis Hanol
6024fb84cc
make rubocop happy
2018-06-04 19:06:52 +02:00
Régis Hanol
ab8cdd6b5b
Upload.url can't be NULL
2018-06-04 18:43:00 +02:00
Régis Hanol
085eaaf18d
FIX: always delete invalid upload records
2018-06-04 18:40:57 +02:00
Arpit Jalan
46fc57222f
FEATURE: improve handling of site setting secrets
2018-06-04 21:31:34 +05:30
Arpit Jalan
36f9af4fa4
minor optimizations for post rejected logs
2018-06-02 09:44:55 +05:30
Robin Ward
597ffd7e3f
FIX: Keyboard shortcuts didn't work on subfolders
2018-06-01 14:38:09 -04:00
Arpit Jalan
89eca87f16
FEATURE: add staff action log for post rejections
2018-06-01 21:48:27 +05:30
Kris
41999b9949
Limiting history modal height and width
2018-06-01 11:59:29 -04:00
Gerhard Schlager
b970b072f6
FIX: User merge should not fail when primary email address is missing
...
The merge process might move all email addresses of the source user to the target user. Destroying the source user failed in that case.
2018-06-01 16:23:21 +02:00
Joe
560a950da9
FIX: alignment for instructions on change email and 2FA fields
2018-06-01 09:51:46 +08:00
Guo Xiang Tan
9ef61e0af5
PERF: Prefer exists? instead of loading AR object.
2018-06-01 09:44:14 +08:00
Kris
ba7aff62db
safety so pre blocks can't break modal width
2018-05-31 18:19:27 -04:00
Kris
6c15effca2
envelope missing on invite page, long pre lines making modals wide
2018-05-31 18:11:24 -04:00
Guo Xiang Tan
95f9b72351
FIX: Update activation email route was returning a generic json error.
2018-05-31 14:19:43 +08:00
Kris
3e9f1d5cf6
Few small modal fixes
2018-05-30 23:24:43 -04:00
Kris
57cef06192
incoming email modal width too narrow
2018-05-30 15:28:29 -04:00
Joffrey JAFFEUX
8128cbd7db
UX: adds subtitle support for modals
2018-05-30 17:14:00 +02:00
Joffrey JAFFEUX
43b1768987
UX: ceil dahsboard values
2018-05-30 16:32:43 +02:00
Arpit Jalan
704cca3de2
FIX: add proper search context for personal messages
2018-05-30 14:47:46 +05:30
Guo Xiang Tan
21e9315416
FIX: Use user account email instead of auth email when totp is enabled.
...
https://meta.discourse.org/t/github-2fa-flow-broken/88674
2018-05-30 12:15:12 +08:00
Gerhard Schlager
864ada835b
FEATURE: Add Bulgarian language
2018-05-29 21:07:17 +02:00
Kris
7483805f0c
Increasing min-width of modals for larger screens
2018-05-29 13:13:35 -04:00
Neil Lalonde
e26a14dc29
FIX: error when flagging to notify moderators because message title is too long
2018-05-29 12:21:47 -04:00
Joffrey JAFFEUX
ee8cda691d
FIX: simplifies and corrects new collection header tag/drop behaviour
2018-05-29 17:34:34 +02:00
Gerhard Schlager
ce687f334b
UX: The "enable 2FA" string was hard to translate
2018-05-29 16:25:43 +02:00
Joffrey JAFFEUX
a8079ab679
FIX: show none/all on cat/tag drop only when needed
2018-05-29 16:08:31 +02:00
Joffrey JAFFEUX
597095f56f
UX: adds visual feedback when hovering info
2018-05-29 13:31:57 +02:00
Joffrey JAFFEUX
87edde3113
UX: improves dashboard UI for RTL locales
2018-05-29 10:22:31 +02:00
Arpit Jalan
277e216d25
FIX: link to pm tags when searching in personal messages
2018-05-29 12:32:20 +05:30
Sam
df815d6c0e
DEV: prefer using ordering in relation over default scope
2018-05-29 09:34:12 +10:00
Joffrey JAFFEUX
16d0ab5654
Revert "UX: localizes titles in dashboard table reports"
...
This reverts commit 409c0ddf85
2018-05-28 20:35:22 +02:00
Joffrey JAFFEUX
409c0ddf85
UX: localizes titles in dashboard table reports
2018-05-28 20:03:05 +02:00
Joffrey JAFFEUX
4b9c713581
FIX: avoids hidding mobile keyboard on each keystroke
2018-05-28 16:18:25 +02:00
Joffrey JAFFEUX
a585c19f2e
FIX: prevents collection header from going under rows
2018-05-28 15:47:07 +02:00
Arpit Jalan
8d9c77e113
optimize group invitation code
2018-05-28 17:59:14 +05:30
Joffrey JAFFEUX
478ccb6698
UX: lower no-change trend emphasis in charts
2018-05-28 13:55:25 +02:00
Arpit Jalan
c8bc942333
FIX: do not add invited user to automatic groups
2018-05-28 17:17:48 +05:30
Gerhard Schlager
ed2ae3cb0a
FIX: Load post revisions in correct order
2018-05-28 11:25:24 +02:00
Joffrey JAFFEUX
82e5727287
UX: -2/+2% change in stats should be no-change in dashboard
2018-05-28 10:55:42 +02:00
Guo Xiang Tan
754458e6a2
PERF: Minor but we can just pass a hash to where.
...
```
Warming up --------------------------------------
4 x .where 1.040k i/100ms
1 x .where 1.677k i/100ms
Calculating -------------------------------------
4 x .where 10.321k (± 5.2%) i/s - 52.000k in
5.053803s
1 x .where 17.117k (± 3.8%) i/s - 85.527k in
5.004107s
Comparison:
1 x .where: 17117.1 i/s
4 x .where: 10321.3 i/s - 1.66x slower
```
2018-05-28 16:41:38 +08:00
Arpit Jalan
54338cfdcb
FEATURE: add support for group_name parameter in /new-message route
2018-05-28 13:26:41 +05:30
Guo Xiang Tan
a081771950
Merge pull request #5872 from OsamaSayegh/users-controller-specs-to-request
...
REFACTOR: users contollers specs => request specs
2018-05-28 13:32:37 +08:00
Guo Xiang Tan
0b55416742
UX: Don't display all groups option if group directory is disabled.a
...
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
2018-05-28 11:32:55 +08:00
Sam
5a32a70d6c
FIX: ColorScheme color missing was returning "nil"
2018-05-28 11:46:00 +10:00
Kris
4bd24e78fc
padding fix, small phone fix
2018-05-26 01:12:33 -04:00
OsamaSayegh
449399bef3
return 403 forbidden when local logins disabled
2018-05-26 05:18:19 +03:00
Régis Hanol
5b2e7c8d10
fix the build
2018-05-26 03:11:10 +02:00
Régis Hanol
338d39265a
FIX: don't publish notifications_state when user has been deleted
2018-05-26 02:27:54 +02:00
Régis Hanol
d23229df85
Let's use the same method
2018-05-26 02:16:53 +02:00
Régis Hanol
f988fa31aa
FIX: ensure 'notifications_state' is up to date after creating a notification
2018-05-26 02:09:48 +02:00
Kris
cc0a5f4526
login fixes, auth message and alignment
2018-05-25 19:15:39 -04:00
Kris
6fc292fef5
reducing some specificty
2018-05-25 17:33:45 -04:00
Robin Ward
587a9c82f5
FIX: Use the username formatter when updating cooked usernames
2018-05-25 17:29:06 -04:00
Kris
3b2af4b91f
Adjustments and fixes to updated login design
2018-05-25 16:44:44 -04:00
Robin Ward
4195c7c9ea
FEATURE: Ability to clear a user's penalty history
...
You can do this manually if you want to allow them to reach TL3 without
their penalty history counting against them.
2018-05-25 12:54:22 -04:00
Robin Ward
c658fb6e31
Move some display logic out of model, upgrade old code patterns
2018-05-25 12:54:22 -04:00
Neil Lalonde
fdce116838
UX: mobile watched words UI in admin needs a way to see all word lists
2018-05-25 11:13:38 -04:00
Robin Ward
3c8369def6
The isSilenced and isSuspended aliases were useless
...
We already had `silenced` and `suspended` on the model with the same
effect!
2018-05-25 10:29:26 -04:00
Joe
4a2931f43d
FEATURE: New login / create account form layout
2018-05-25 20:16:38 +08:00
Joe
1948a9912c
FEATURE: Horizontal login / create accout layout
2018-05-25 20:15:34 +08:00
Joe
7f6f61cff2
FIX: Move tips into instructions div
2018-05-25 20:13:06 +08:00
Joe
1a9aeca93b
FIX: Move tips into instructions div
2018-05-25 20:12:08 +08:00
Joe
9e546e9ddc
FIX: Move tips into instructions div
2018-05-25 20:11:22 +08:00
Joffrey JAFFEUX
a8901efafe
FIX: flags report is now a lower is better kind of report
2018-05-25 12:59:39 +02:00
Joffrey JAFFEUX
acc5e42066
removes logging
2018-05-25 12:12:28 +02:00
Joffrey JAFFEUX
e67ac93e6c
UX: makes table report trend icons as charts
...
This commit will also reverse icon orientation if higher_is_better = false
2018-05-25 12:09:30 +02:00
Gerhard Schlager
20b94bc714
FIX: Extraction of quoted posts failed in some cases
...
* It stored only oneboxed "quotes" when [quote] and links to topics or posts were mixed.
* Revising a post didn't add or remove records from the quoted_posts table.
2018-05-25 12:00:17 +02:00
riking
501bc0e9af
FIX: UserProfileView: Do not log IP of logged-in users
2018-05-25 15:54:14 +10:00
Guo Xiang Tan
9d307a9977
FIX: Destroy notifications and sync notifications count in transaction.
...
* Seeing errors where the user is destroyed right when the call to
reload is made.
2018-05-25 12:01:36 +08:00
Guo Xiang Tan
755b511b5c
PERF: Destroy collapsed notifications in 1 query instead of 3.
2018-05-25 12:01:36 +08:00
Guo Xiang Tan
569f63b8a2
Merge pull request #5825 from featheredtoast/extend-service-worker-cache
...
FIX: update cache times for service workers
2018-05-25 09:28:17 +08:00
Joffrey JAFFEUX
1be76d066c
FIX: forces boolean when content is only "true" && "false"
2018-05-24 23:41:39 +02:00
Robin Ward
a31a458a67
Trivially fix some odd whitespace, indentation
2018-05-24 12:29:55 -04:00
Régis Hanol
bb8f0087f4
Add a warning when PostAlerter isn't running in sidekiq
2018-05-24 17:52:59 +02:00
Régis Hanol
71f66cd679
FIX: ensure PostAlerter is always run in sidekiq
2018-05-24 17:27:43 +02:00
Kris
c5dbfe1886
liked icon should use d-icon
2018-05-24 11:08:13 -04:00
Arpit Jalan
cafd1241b9
FIX: make report data export more resilient to inconsistent date format
...
The DAU/MAU report export was failing because of date being a string
and not a valid Date value
2018-05-24 17:14:08 +05:30
Guo Xiang Tan
3bfd9698c7
PERF: Avoid running the same query twice in TopicViewSerializer#details.
2018-05-24 16:46:13 +08:00
Joe
5ec896d163
FIX: align categories with menu panel links
2018-05-24 16:15:57 +08:00
Guo Xiang Tan
0e284e54f3
Merge pull request #5832 from featheredtoast/safari-no-serviceworkers
...
Fix: Safari failing to download backups from email links
2018-05-24 15:44:51 +08:00
Guo Xiang Tan
43f7cb05c9
FIX: Broken ping event for web hooks due to missing payload.
2018-05-24 15:16:52 +08:00
Guo Xiang Tan
b3860c82da
FIX: Don't enqueue web hooks inside a deferred queue.
...
* The deferred queue is meant for short lived jobs
and does not guarantee execution. We need to ensure
that web hooks are always run.
2018-05-24 15:03:17 +08:00
Guo Xiang Tan
8a1aab4e8a
PERF: Select distinct active web hooks at the db level.
2018-05-24 14:56:40 +08:00
Sam
4fef9e95d2
should not be a const
2018-05-24 15:42:00 +10:00
Sam
53b97b28f0
FIX: in rare conditions post timing would miss the user
2018-05-24 15:38:33 +10:00
Sam
70179290f3
clean up callbacks during acceptance tests
2018-05-24 15:28:54 +10:00
Sam
4194886b62
correct failing test
2018-05-24 13:02:20 +10:00
