Commit Graph

1015 Commits

Author SHA1 Message Date
Guo Xiang Tan
41a2f2cfda 💣 comments that are not required. 2016-10-17 22:46:47 +08:00
Guo Xiang Tan
30902d00d7 Merge pull request #4495 from cpradio/empty-search-fields
FIX: Improve removing advanced filters
2016-10-17 22:45:29 +08:00
cpradio
ddacda0388 Update based on review comments
Found a few javascript errors when visiting the search page with ?expanded=true and no query.
2016-10-17 00:02:58 -04:00
cpradio
1e7c69044c FIX: Improve removing advanced filters
Prior:
Entering `test after:5` and then removing the 5 via the search text field would result in the UI not updating

After:
UI updates after half a second

Removing it from the UI, removes it from the search field immediately.

Change the regex to detect filter words. This now matches what happens in search.rb, which gives a lot more flexibility (such as iterating over multiple `in:` terms)

Return [] when searchTerm is empty

Move .trim() to this.set('searchTerm', searchTerm) so it doesn't run twice (which was very obvious when watching the search term field)

More refactoring to make this a bit less complex

Update code based on review comments

FEATURE: Add common `in:` options
2016-10-14 19:04:10 -04:00
Guo Xiang Tan
6b40f2c42c Add option to apply surround across multilines. 2016-10-14 14:03:00 +08:00
Guo Xiang Tan
ce8b850b11 Merge pull request #4496 from cpradio/search-ui-changes
FIX: Shrink tag input and use date type for Post Time
2016-10-14 10:33:10 +08:00
cpradio
9fd4cf3278 FIX: Shrink tag input and use date type for Post Time 2016-10-13 12:48:36 -04:00
Guo Xiang Tan
94002f5903 FIX: Post search time was updating incorrectly.
* A search term of `after` will result in `after: after:after`.
2016-10-13 21:26:01 +08:00
Guo Xiang Tan
2eb48ee1ce FIX: Search terms are appearing in filters. 2016-10-13 20:42:37 +08:00
Guo Xiang Tan
4c2c21ee2b Opps this should be null. 2016-10-13 15:58:31 +08:00
Guo Xiang Tan
b16b2a6fbb FIX: Reset advanced search options when search term is cleared. 2016-10-13 15:54:32 +08:00
Guo Xiang Tan
06cbabb4da FIX: Don't search for tags if tagging is disabled. 2016-10-13 15:09:44 +08:00
Guo Xiang Tan
ae0db10e2d Fix full page search tests. 2016-10-13 15:03:58 +08:00
Guo Xiang Tan
b4a899b144 Make eslint happy. 2016-10-13 14:47:18 +08:00
Guo Xiang Tan
ef1918662c PERF: Don't render advanced search options when not expanded.
* Debounce options update as well.
2016-10-13 14:46:13 +08:00
Guo Xiang Tan
4f87f1886b Make eslint happy. 2016-10-13 12:10:01 +08:00
Guo Xiang Tan
91a296839f Remove unnecessary computed property. 2016-10-13 12:08:00 +08:00
cpradio
ca4130f30d FIX: Use @username instead of user:username 2016-10-11 17:41:04 -04:00
Sam
f6ac914376 Merge pull request #4467 from cpradio/advanced-search-ui
FEATURE: Advanced Search UI
2016-10-11 10:02:35 +11:00
cpradio
a7507dad63 Add Acceptance Tests (which found an error)
Tests for populating category and tags

Added acceptance tests for populating the Username and Category through the Advanced Search UI (will work on the other fields later)

Give the combo-box elements ids
Add acceptance tests for the rest of the advanced search UI (except for Tags, tags are evil)
2016-10-08 09:09:37 -04:00
Neil Lalonde
a061c025f1 FIX: in create/edit category modal, don't prompt to choose a parent category when allow_uncategorized_topics is false 2016-10-05 12:06:37 -04:00
Sam
601a96333a FIX: last visited line not rendering correctly
- stop changing cached models
2016-10-05 15:37:47 +11:00
cpradio
4b71fd253b Advanced Search UI
Properly support Categories so it updates the search box correctly

Use category id, as it is more consistent with search results than using the slugs, especially for parent/subcategory

Added Status

Improve AutoComplete so it can receive updates
Added the ability for AutoComplete to receive updates to badge-selector and group-selector

Respect null, which is set via web-hooks

Support both # and category: for category detection.

Only update the searchedTerms if they differ from its current value (this helps the Category Selector receive updates)

Opt in receive updates (#3)

* Make the selectors opt-in for receiving updates

* Opt-in to receive updates

* Fix category detection for search-advanced-options

Fix eslint error

Update user-selector so it can receive updates live too
Make the canReceiveUpdates check validate against 'true'

Converted to use template literals

Refactor the regex involved with this feature
Split apart the init to make it a bit more manageable/testable

Switch the category selector to category-chooser, so it is a dropdown of categories instead of auto-complete

Reduce RegEx to make this happier with unicode languages and reduce some of the complexity
2016-10-04 11:18:01 -04:00
Régis Hanol
08c4de388e make eslint happy 2016-10-04 12:14:24 +02:00
Rafael dos Santos Silva
5476dee52d FIX: Last visit must keep working when changing categories 2016-09-29 17:40:28 -03:00
Guo Xiang Tan
119225e496 Make eslint happy. 2016-09-27 15:12:47 +08:00
Rafael dos Santos Silva
16aad189fb UX: Add text to new messages line 2016-09-27 14:52:03 +08:00
Robin Ward
f90e1ce847 FIX: Don't double escape the category title 2016-09-22 21:13:08 -04:00
Robin Ward
3d621767cc FIX: Wizard didn't work with subfolders 2016-09-22 14:39:36 -04:00
Robin Ward
29cf47cfb2 Track steps the user has completed, nag them to finish it. 2016-09-22 09:52:19 -04:00
Robin Ward
9f12b571ef Wizard: Server Side Validation + Finished Step 2016-09-22 09:52:19 -04:00
Robin Ward
be1d74d207 Split out common functions into discourse-common module 2016-09-22 09:52:19 -04:00
Guo Xiang Tan
7dea31adce FIX: Form CDN URL client side instead. 2016-09-22 11:57:18 +08:00
Neil Lalonde
b381d84dd9 FIX: tag search should not be case sensitive 2016-09-09 16:55:26 -04:00
Erick Guan
9ce61b4586 FEATURE: Webhooks. 2016-09-05 18:44:00 +08:00
Sam
653f94975c FIX: don't fail if targetUsernames is not set 2016-08-29 12:39:25 +10:00
Neil Lalonde
39de27a4b2 FIX: top period chooser layout on mobile 2016-08-26 12:39:09 -04:00
Régis Hanol
7d600d9fee FIX: show topic entrance when clicking the # of replies in /categories 2016-08-24 22:25:10 +02:00
Guo Xiang Tan
90571f0364 FIX: Format selection as multiline code only when selection spans multiple lines. 2016-08-23 15:00:16 +08:00
Guo Xiang Tan
e9927ce5b1 Make eslint happy. 2016-08-23 09:56:24 +08:00
Guo Xiang Tan
f32d8e2882 FIX: Code fences shortcut did not insert newlines before and after backticks. 2016-08-23 09:51:01 +08:00
Régis Hanol
4d6028ea2d UX: new 'category_page_style' site setting 2016-08-22 23:01:43 +02:00
Sam
c51fec7fda FIX: improve last visited detection
- clear line detection cache on category change
- don't show last visited unless latest / descending
- improve perf of last visited detection algorithm
2016-08-21 17:06:00 +10:00
Sam
9b1e81cd6d Only display in discovery, correct double highlighting 2016-08-19 12:43:48 +10:00
Sam
11f9a463ac FEATURE: highlight last visited topic in topic list 2016-08-19 11:58:39 +10:00
Gerhard Schlager
1042f1a923
UX: Allow translation of composer icons 2016-08-15 18:57:05 +02:00
cpradio
46fa70d948 FIX: Permit Timeline Topic Status to receive dispatch events to handle keyboard shortcuts when the topic footer is not loaded 2016-08-11 08:30:37 -04:00
safaalfulaij
291c32aa69 Fix Plural Strings 2016-08-10 20:24:28 +03:00
Claas Augner
ac87a86975
FIX: Disable pasting hack for Firefox 50+ 2016-08-10 01:24:15 +02:00
cpradio
754e3b2287 Convert boolean to opts object 2016-08-08 15:15:27 -04:00