Commit Graph

1451 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 7a4ddc2bb1 FIX: makes state of select-box more resilient to model changes 2017-09-13 18:44:40 +02:00
Robin Ward e5db126a8e FIX: Small fixes to enable better testing of components 2017-09-13 10:33:36 -04:00
Joffrey JAFFEUX 64c154d9df FIX: prevents click on select-box to close timeline-container on mobile 2017-09-13 10:00:10 +02:00
Joffrey JAFFEUX c06c88b479 cleaner title attribute for select-box 2017-09-12 01:36:58 +02:00
Joffrey JAFFEUX 18114c7bdb Revert "FIX: pinned-button sometimes not shown when unpinned is null"
This reverts commit 01f0b56331.
2017-09-12 01:03:16 +02:00
Joffrey JAFFEUX b875d17e1f fix linter error 2017-09-11 23:51:42 +02:00
Joffrey JAFFEUX 2c284874b4 FIX: icon showing as null 2017-09-11 22:47:47 +02:00
Joffrey JAFFEUX 01f0b56331 FIX: pinned-button sometimes not shown when unpinned is null 2017-09-11 20:04:07 +02:00
Joffrey JAFFEUX e924920bec uses select-box for pinned-button
This commit also moves more logic in dropdown-select-box instead of
duplicating it for notifications-options and pinned-options
2017-09-11 19:14:22 +02:00
Régis Hanol f1639bf4f5 make eslint happy 2017-09-11 16:49:09 +02:00
Régis Hanol 5a51953c8e UX: '.visited' wasn't applied in categories view and suggested topics 2017-09-11 16:42:51 +02:00
Joffrey JAFFEUX 7f9220a2cd minor select-box fixes
- select row when using tab
- makes sure tab order is correct
- highlight first row when filtering
2017-09-11 00:38:32 +02:00
Joffrey JAFFEUX 4b558638c8 FEATURE: improves keyboard handling of select-box
- arrow keys
- escape key
2017-09-10 19:12:03 +02:00
Joffrey JAFFEUX a11eec47bb FIX: display localised title when using notifications-button 2017-09-10 11:38:52 +02:00
Joffrey JAFFEUX bba26e48a0 FIX: positioning issues with notifications-button 2017-09-10 11:36:57 +02:00
Joffrey JAFFEUX 1f8695b16a fix broken build 2017-09-09 20:58:37 +02:00
Joffrey JAFFEUX 950b9e9eaf FIX: keeps as much as possible the same api for select-box components 2017-09-09 20:29:07 +02:00
Robin Ward e6d3bbfa1d FIX: Categories admin menu was missing 2017-09-09 09:21:43 -04:00
Joffrey JAFFEUX 8c3f7d9bbc FIX: select-box width was incorrect on mobile 2017-09-09 02:41:31 +02:00
Joffrey JAFFEUX 5b9819f4ed minor fixes to select-box 2017-09-09 00:49:33 +02:00
Joffrey JAFFEUX cf6fb7622e Replaces all notification-options like dropdowns with select-box 2017-09-08 20:47:39 +02:00
Robin Ward f13776e550 UX: Move .visited to entire row, not just the link to a topic 2017-09-08 13:54:41 -04:00
Joffrey JAFFEUX 661ae38a03 FIX: makes sure we only autocomplete valid emoji tones 2017-09-08 09:42:13 +02:00
Joffrey JAFFEUX 5054065e81 FIX: broken spec 2017-09-07 19:18:27 +02:00
Robin Ward 0ba789de17 Allow for customization of header dropdown icons 2017-09-07 11:18:59 -04:00
Joffrey JAFFEUX 0374dc1a0e FIX: keys were incorrectly set to category 2017-09-07 16:56:38 +02:00
Joffrey JAFFEUX 633d2fde45 removes select-box minWidth property
Using css offers more flexibility
2017-09-07 16:56:16 +02:00
Joffrey JAFFEUX ca58a8228c minor css fixes on select-box 2017-09-07 16:56:00 +02:00
Joffrey JAFFEUX d04aa5c7af FIX: component height computation was wrong 2017-09-07 16:55:36 +02:00
Joffrey JAFFEUX ccf5005feb FEATURE: uses select-box for topic-notifications-button component
- Introduces ComponentConnector to use a component inside a widget
- Use css to set size of components instead of properties
- Smarted positionning
- Style tweaks
2017-09-06 16:58:00 +02:00
Robin Ward 51ffbf1c1f FIX: Remove duplicate event typo 2017-09-04 15:39:58 -04:00
Robin Ward be1cce503c FIX: Don't bind events in defaultState 2017-09-04 11:48:36 -04:00
Robin Ward 75b2aa2edd Better support for inline modals 2017-08-30 17:52:49 -04:00
Robin Ward a48abc6556 Tweaks for better modal distinction between fixed/inline 2017-08-30 17:38:49 -04:00
Robin Ward 6361618188 fixed-modal is a better name 2017-08-30 15:52:29 -04:00
Robin Ward 3d95bac3fb Migrate away from #discourse-modal to .d-modal 2017-08-30 15:29:51 -04:00
Robin Ward 8fcd5af5b1 UX: Use a template for the d-modal component 2017-08-30 15:20:49 -04:00
Joffrey JAFFEUX 746c5927e1 Replaces remaining {{category-chooser}} by {{category-select-box}}
To achieve replacement, this commit also adds support for:
- clearSelectionLabel which will allows to unselect any chosen category
- select-box inside a modal
- fixes minor css positioning issues

Note: {{category-chooser}} will be removed in the next weeks.
2017-08-30 17:04:17 +02:00
Guo Xiang Tan 0a53c589c4 Fix linting. 2017-08-30 15:36:45 +08:00
Joffrey JAFFEUX dcc5f93344 FIX: disable highlighting when no value set on select-box 2017-08-29 14:32:23 +02:00
Joffrey JAFFEUX f101fec19c FIX: improves uncategorized support for category-select-box 2017-08-29 12:48:26 +02:00
Joffrey JAFFEUX 861dbe3b51 select-box refactoring
- more flexibility (allows custom title)
- less re-render
- more robustness
2017-08-29 12:25:54 +02:00
Bianca Nenciu bb3a5910d7 Support for sending PMs to email addresses (#4988)
* Added support for sending PMs to email addresses.

* Made changes after review.

* Added settings validator.

* Fixed tests.
2017-08-28 12:07:30 -04:00
Joffrey JAFFEUX b83c0747d9 FIX: select-box improvments
- more tests for category-select-box
- allows to clear selection
- fix positioning on safari
- focus on click
- do not display uncategorized if not allowed in settings
- fix component state impacting other specs
- better texts
- higher category-select-box on mobile
2017-08-28 14:34:04 +02:00
Robin Ward a77ede05e2 FIX: Don't re-render if you find composer messages after destroying 2017-08-26 00:41:24 -04:00
Joffrey JAFFEUX 5d12db1fb5 FIX: html not showing in select-box header 2017-08-26 02:44:36 +02:00
Joffrey JAFFEUX 918f5045b4 FEATURE: display subcategories when filtering on parent name 2017-08-26 02:01:34 +02:00
Joffrey JAFFEUX 2efb39289c FIX: select-box fragile specs 2017-08-26 01:24:17 +02:00
Joffrey JAFFEUX 296ea6c7b1 FIX: castInteger on initial value 2017-08-25 22:41:35 +02:00
Joffrey JAFFEUX 14f06c2740 select-box minor fixes 2017-08-25 19:56:57 +02:00