490e1cfbbb
DEV: Use tag renderer in tags filter dropdown ( #11378 )
...
A small change that would allow components to extend the tag
display in the filter dropdown, like they can in other contexts.
Was requested in the tag icons component, see
https://meta.discourse.org/t/tag-icons-component/109757/60?u=pmusaraj
The PR also standardises tag styling in select-kit dropdowns.
2020-12-07 12:10:21 -05:00
da74b3e14b
FEATURE: Add after-topic-list-body plugin-outlet ( #11410 )
2020-12-07 13:33:24 +02:00
4aeb3ef8e0
FIX: Trigger an event when a post is bookmarked. ( #11407 )
...
When we renamed BookmarkWithReminder to Bookmark in ca539fd
2020-12-04 15:09:20 -03:00
4d9686c494
FEATURE: Reviewed by filter. ( #11405 )
...
New reviewable filter to only display reviewables handled by a specific user.
2020-12-04 14:09:05 -03:00
1960fc5333
FIX: Stop using duplicate composer button ID ( #11404 )
...
"quote" is used by the button added in `composer-editor`.
https://github.com/discourse/discourse/blob/bbe5d8d5cf1220165842985c0e2cd4c454d501cd/app/assets/javascripts/discourse/app/components/composer-editor.js#L875-L882
2020-12-04 00:05:43 +01:00
acbc47ef36
FIX: Load .js files from plugins in qunit testing env ( #11304 )
2020-12-03 10:25:42 -06:00
9c5ee4923b
FEATURE: silently close topic ( #11392 )
...
New TopicTimer to silently close topic. It will be used by discourse-solved plugin
Meta: https://meta.discourse.org/t/allow-auto-close-for-solved-to-do-so-silently/169300
2020-12-03 10:43:19 +11:00
bbe5d8d5cf
DEV: Sort imports alphabetically ( #11382 )
2020-12-01 15:31:26 -03:00
d1d87b6fa3
FIX: show/hide ignored users preferences ( #11386 )
...
* FIX: show/hide ignored users preferences
based on the current user trust level and the appropriate site setting.
* Allow us to await the `updateCurrentUser` call
Co-authored-by: Robin Ward <robin.ward@gmail.com >
2020-12-01 18:20:43 +01:00
1c2358ba16
DEV: Tidy up imports. ( #11364 )
...
Only allow one import definition per file and add a new eslint rule to enforce it.
2020-11-27 11:30:16 -03:00
2e5e4dbf19
DEV: Make it easier to customize link attributes in quick access menu ( #11365 )
...
This allows themes to customize link attributes:
```
api.reopenWidget("quick-access-item", {
_linkAttributes(href) {
const attributes = this._super(...arguments);
// do stuff
return attributes;
}
}
```
2020-11-27 12:26:47 +01:00
eeae657ca5
FIX: No tags should be set if tag chooser is hidden ( #11362 )
...
If a user could not set tags because they had a trust level lower than
min_trust_level_to_tag_topics site setting, the "Create Topic" button
from a tag page would still show up and be enabled. Clicking it caused
the composer model to silently have the tags set.
2020-11-27 13:03:37 +02:00
dab2f2fdf4
REFACTOR: We can't use Ember.HTMLBars.compile in Ember CLI
...
Instead we use the inline `hbs` helper. Note in the non-Ember CLI
version this will not actually inline compile, but it will still work
for all our tests.
2020-11-26 09:27:20 -05:00
059e9cb1d2
REFACTOR: Remove .erb from emoji-picker
...
We can't use erb in ember-cli, and it seems the emoji groups rarely
change anyway. This commit migrates the ERB to pre-rendered javascript
that is updated via the `rake javascript:update_constants` task.
2020-11-25 11:23:02 -05:00
abb89475a3
FIX: issues with frowning/grinning ( #11235 )
...
- frowning was using slighty_frowning
- slightly_frowning was using frowning
- grinning_face_with_smiling_eyes was not defined
- fronwing_face_with_open_mouth was not defined
2020-11-25 09:09:35 +01:00
5028aaf446
FIX: Add secure media url to SERVER_SIDE_ONLY list ( #11348 )
2020-11-25 15:31:31 +11:00
2348a7972e
FIX: When quoting an attachment, keep the |attachment in markdown ( #11347 )
2020-11-25 15:31:14 +11:00
436d68d54f
UX: Don't show selected posts interface twice on mobile ( #11328 )
...
Note to reproduce you need a topic with over 3 posts.
2020-11-25 10:50:05 +11:00
a6613d15f4
Adds discourse-gifs to suggested components ( #11339 )
2020-11-24 14:58:45 -03:00
0e0c70019b
FIX: Suggested Topics was being set inside a computed property
...
This is bad because changing the `suggested_topics` proeprty could cause
a `set` on `suggested_topics`.
2020-11-24 11:08:11 -05:00
67979b2b21
Remove "Alternative Logos" from popular themes list ( #11337 )
...
Core has had support for dark theme logos for a while now.
2020-11-24 10:13:16 -05:00
2742595b00
FIX: Checkbox value should not leak between themes ( #11327 )
...
This commit includes a hack to ensure didInsertElement is called only
once.
2020-11-24 12:10:28 +02:00
4b538e7cb9
DEV: Skip missing icon warnings in production ( #11334 )
...
The list of SVG icons is unavailable in production, and the previous
refactor here was causing incorrect and noisy console warnings.
This also parses the `svgIconList` string in a dev environment, icons
should now match more accurately.
2020-11-23 21:41:54 -05:00
3394d994e9
FIX: Tests were using jQuery selectors
...
For the most part `querySelectorAll` will work with jQuery selectors,
but the big exception is `:eq(0)` and similar. Those needed to be
replaced.
2020-11-23 11:36:07 -05:00
60bc38e6a8
FIX: Gracefully handle force pushes for remote themes ( #11325 )
...
Force pushing a commit to a theme repository used to break the updater,
because the system was not able to count the commits behind the old and
new version. This operation failed because a force push deleted the old
commits.
The user was prompted with a simple "500 server error" message.
2020-11-23 15:29:22 +02:00
139c5dc356
FIX: use tag model instead of tagId property. ( #11298 )
...
In a recent commit https://github.com/discourse-org/discourse-teams-sidebar/commit/866fa008d4ae4ff913d8c7cd448c5dc1c556b5fb support for tagId property is removed.
And added a test case. Follow-up for 2d5bb516a6
2020-11-23 16:40:15 +05:30
4638c6fc8d
FEATURE: Add 'all subcategories' option in category-selector ( #11099 )
2020-11-23 10:55:32 +02:00
855026eea1
UX: PM title glyph alignment and consistency improvement ( #11314 )
...
* UX: PM title glyph alignment should match public topic-status style
* minor fixes
2020-11-23 12:16:41 +11:00
66ecefba52
FIX: Upload events happened outside of the runloop
...
This could cause test failures when checking for the result of the
events if Ember hasn't applied them yet.
2020-11-20 15:35:00 -05:00
8aa912c885
FIX: iconList is an array in production ( #11308 )
...
This should be investigated further, but hopefully the comment will prevent anyone else to fall in this trap.
2020-11-20 20:00:51 +01:00
1ea6bbab34
FIX: We shouldn't debounce this in testing
...
Eventually we should add a helper to prevent all debouncing in test, but
for now this will really speed up Ember-CLI tests.
2020-11-20 12:39:49 -05:00
d6f2a63efe
FIX: Tests were performing data[] queries but without quotes
...
This works in jQuery but not querySelectorAll
2020-11-20 12:39:07 -05:00
8a90a5610f
DEV: allows to check if an icon is in the set ( #11303 )
2020-11-20 17:34:55 +01:00
7539c2ed7f
UX: Revamp category security tab ( #11273 )
2020-11-20 10:44:34 -05:00
dbcf722ab9
DEV: Modulize component tests ( #11300 )
...
It's like the new tests, but still old underneath!
2020-11-20 15:54:09 +01:00
c244214fe5
UX: update "Rebuild-HTML" icon ( #11296 )
2020-11-19 19:39:18 -08:00
1157ff8116
FIX: There are two elements with a suspend-reason class
...
We only want to fill in the text one. (This is an Ember CLI fix)
2020-11-19 14:16:35 -05:00
5202380a04
DEV: Move browser-update.js.erb out of vendored scripts ( #11234 )
...
This script has been adopted and modified.
2020-11-19 18:48:24 +02:00
625cf5a8ae
FIX: Modal methods should be wired up in setupTests not in module
2020-11-18 15:42:49 -05:00
8e8dca9246
FIX: Selected Tag Group permission shouldn’t change during save ( #11274 )
...
`setPermissionsGroups` would initialize an empty permissions object whenever new groups were added to the Tag Group. This meant that if you selected the `visible` permission and then added groups to the Tag Group, the `visible` permission would be obliterated and the Tag Group would be treated as though it was `private`.
2020-11-18 11:22:19 -05:00
75e92e1bd7
REFACTOR: The Favcount library needs global variables
...
This moves the library into our lib folder, and refactored it to more
modern Javascript. I've kept the MIT license at the top of the file.
Doing this allows us to import it as a library in Ember CLI and ditch
yet another global variable.
2020-11-17 15:04:17 -05:00
410214e5a9
FIX: In newer embers, it's triggerKeyEvent not keyEvent
2020-11-17 14:46:23 -05:00
504aaad838
DEV: New plugin-outlet under preferences interface nav ( #11266 )
2020-11-17 12:36:17 -06:00
c62f082754
UX: Only link the icon for site setting history ( #11265 )
...
Linking the whole site setting name makes it tricky to copy/paste the name, which is common when asking/answering support queries.
2020-11-17 15:59:55 +00:00
3fc5671e40
REFACTOR: Allow us to import keyEvent
...
This change should be quite safe as it only adds extra support for
imports rather than global variables.
2020-11-17 09:43:08 -05:00
2fde06ba08
UX: handle large email addresses on email skipped and bounced tabs ( #11259 )
2020-11-17 18:01:40 +05:30
473f7bfe7b
FIX: do not allow a tag to be synonym of its own ( #11246 )
...
https://meta.discourse.org/t/adding-synonym-to-the-same-tag-gets-stuck/169801/
2020-11-17 06:52:31 +05:30
a9b20fa827
DEV: Allow overiding calculation of top offset for card contents base ( #11254 )
2020-11-17 12:05:59 +11:00
475b4892e3
DEV: Remove 'diff local changes' when updating remote themes ( #11247 )
...
Since 65e123498b
2020-11-16 19:28:12 +00:00
bc8423a1bf
FEATURE: Add auto update field to themes ( #11102 )
...
Themes marked for auto update will be automatically updated when
Discourse is updated. This is triggered by discourse_docker or
docker_manager running Rake task 'themes:update'.
2020-11-16 14:44:09 +02:00
Penar Musaraj
Bianca Nenciu
Roman Rizzi
Gerhard Schlager
Mark VanLandingham
Krzysztof Kotlarek
Régis Hanol
Robin Ward
Joffrey JAFFEUX
Martin Brennan
Rafael dos Santos Silva
Dan Ungureanu
Vinoth Kannan
Kris
Jarek Radosz
Arpit Jalan
jbrw
David Taylor