Commit Graph

628 Commits

Author SHA1 Message Date
Jeff Atwood
bbbca820d8 FIX: edit history user setting was appearing 2014-09-04 13:47:05 -07:00
Jeff Atwood
fad0394a40 more renaming of trust level settings 2014-09-04 13:32:00 -07:00
Robin Ward
229566fc32 Remove deprecated Ember.Set 2014-09-04 15:01:12 -04:00
Robin Ward
b04a52676e FIX: Don't show wrong flag choices after undo 2014-09-02 17:37:54 -04:00
Robin Ward
abd84cd2a1 FIX: Redirect to Top was showing "latest" content because it was in the
preload store.
2014-09-02 12:29:22 -04:00
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Robin Ward
6dcde9ccc3 FIX: Navigating to None was not working 2014-08-29 15:51:28 -04:00
Robin Ward
926e45d030 SECURITY: User action route was returning too much data 2014-08-29 13:46:50 -04:00
Robin Ward
16c9f073b5 FIX: Back button breaks translation of incoming stuff 2014-08-29 12:53:06 -04:00
Robin Ward
69cb5bc425 FIX: Centralize Top rendering, remove old code paths. Fix some bugs. 2014-08-28 14:34:31 -04:00
Robin Ward
30b102aa98 FIX: Show uncategorized with badge/description in the category chooser 2014-08-28 12:42:31 -04:00
Robin Ward
fc71662a13 FIX: Don't show topics as unread when hitting back 2014-08-27 18:01:02 -04:00
Neil Lalonde
940c0d5dbb FIX: topicCountStats was depending on the wrong properties 2014-08-27 15:58:32 -04:00
Robin Ward
f05d2ed7cf PERF: Do far fewer checks and use a lot less memory when loading more 2014-08-27 15:31:06 -04:00
Robin Ward
b1c0a3d01c FIX: Retain back button scroll position even if we don't load more. 2014-08-27 13:33:52 -04:00
Jeff Atwood
553e0290a6 mods can use shield glyph as well, don't need two 2014-08-25 23:49:39 -07:00
Sam
c412d74369 HACK: suppress "1 reply" when directly below for quotes posts 2014-08-26 12:00:16 +10:00
riking
99c11e2184 Sort the badges on the user profile page
Also clean up UserBadgesController so it isn't doing two things in one
method
2014-08-25 12:40:51 -07:00
Jeff Atwood
bd66c67398 whoops, used font awesome 3.2 styles :( 2014-08-24 22:20:59 -07:00
Jeff Atwood
01853fb9d3 replace trophy with shield to indicate admin 2014-08-24 22:05:11 -07:00
Robin Ward
c1aa2458f8 UX: Add drop down for top lists, big refactor of repeated code. 2014-08-21 16:08:47 -04:00
Robin Ward
506dca6d4e FIX: Moving posts was not updating reply_count and
`reply_to_post_number` so reply linkage was broken.
2014-08-20 14:15:23 -04:00
Sam
2d16255185 FIX: make filter bindable 2014-08-19 16:50:30 +10:00
Robin Ward
f1486c7728 FIX: Inconsistency between unread counter and unread filter 2014-08-18 16:15:26 -04:00
Robin Ward
db4abe76db CLEANUP: Remove dead resetRead code path 2014-08-18 14:35:33 -04:00
Robin Ward
05193deb4d Merge pull request #2659 from riking/wrong-progress-pos
Hopefully fix once and for all the 172/160 problem
2014-08-18 11:30:09 -04:00
Neil Lalonde
6c10cc3788 FIX: top_menu with category links like category/Meta are not case sensitive 2014-08-18 11:07:49 -04:00
Robin Ward
f7b0c31418 Post history heatmap should use site settings for thresholds 2014-08-15 12:22:06 -04:00
Robin Ward
eb5a3da10d UX: Include tooltip text when hovering over posts column 2014-08-15 11:49:30 -04:00
Robin Ward
8f51878d73 FIX: Remove seen flag status from viewed topics 2014-08-15 10:46:58 -04:00
riking
8539c08d35 Fix assignment of post number to progress position 2014-08-14 17:31:34 -07:00
Robin Ward
c2c256cdd9 FIX: Bug with cached topics not being marked as read in your topics
list.
2014-08-14 18:31:02 -04:00
Robin Ward
6f3db0e386 UX: Squash activity columns together. Show a cold map on the difference
between the last post and original post dates. Fix some missing classes
in the mobile templates and topic map.
2014-08-14 16:06:27 -04:00
Robin Ward
4dfe5fd1ca FIX: Edit category should use the id always in case two categories have
the same slug.
2014-08-14 10:56:47 -04:00
Robin Ward
914bbd2a7b FIX: Only show like heat map when there are 10 posts 2014-08-12 17:35:44 -04:00
Robin Ward
f1572a43e1 UX: Remove drag and drop reordering of categories. It was not working
perfectly and you can re-order using the modal number.
2014-08-12 17:14:02 -04:00
Robin Ward
de73e9fb56 UX: Remove likes column, use heat map on posts count 2014-08-12 14:03:52 -04:00
Régis Hanol
e64d3b8a42 FIX: disagree flag should unhide hidden post 2014-08-11 10:48:00 +02:00
Robin Ward
dc260110fa FIX: If editing a reply, the quote button should target the post it was
a reply to, not the post you're editing.
2014-08-08 16:41:58 -04:00
Robin Ward
7b317c1ad7 FIX: When navigating to a topic via a link that's not found, the
formatting was broken.
2014-08-07 15:56:09 -04:00
Sam
df30cb43ec FIX: reverse insert order when grabbing new topics 2014-08-06 13:24:55 +10:00
Sam
70b5dfc4fa FIX: don't maintain list ordering when grabbing topics, trust server 2014-08-06 10:23:07 +10:00
Robin Ward
4366ae43d6 FIX: Clicking on "view latest topics" in a forum with few topics was
broken.
2014-08-05 16:26:28 -04:00
Robin Ward
06c681b0de Merge pull request #2617 from techAPJ/patch-2
FEATURE: dynamically load more invites
2014-08-05 12:54:06 -04:00
Arpit Jalan
4cd8abc905 FEATURE: dynamically load invites 2014-08-05 22:20:23 +05:30
Sam
4536f772c1 FIX: more reliable topic list counts
- unread was not incrementing when you read last post on topic
- new notifications were being inserted even if they existed in list
- terminology was all mixed up "1 new posts", split to 3 messages
- latest behaves as expected, updating count of new and updated topics
2014-08-05 13:27:34 +10:00
Sam
1958b0205e FIX: sloppy topic draft handling
Will open in categories page and category drill down
2014-08-05 11:33:15 +10:00
Sam
ef5b18779e FEATURE: merge new and old unread counts on categories page
UI: restyle UI to match counts
2014-08-05 10:44:01 +10:00
Robin Ward
27273ac848 Merge pull request #2615 from riking/stream-len-prop
FIX: Topic progress bar was not updating after expanding gaps
2014-08-01 16:28:45 -04:00
riking
4a75065b62 FIX: Topic progress bar was not updating after expanding gaps 2014-08-01 13:23:53 -07:00