Robin Ward
71d37953d5
REFACTOR: Import QUnit and related helpers rather than globals
...
We used many global functions to handle tests when they should be
imported like other libraries in our application. This also gets us
closer to the way Ember CLI prefers our tests to be laid out.
2020-10-07 11:50:49 -04:00
Robin Ward
39ad9a4734
REFACTOR: Support importing of Pretender
...
We shouldn't be using global variables for libraries.
2020-10-05 14:33:55 -04:00
Robin Ward
e363b113a8
FIX: Build was broken because uglify can't accept let or const
...
For now we can live with `var`.
2020-10-02 12:04:33 -04:00
Robin Ward
23f24bfb51
REFACTOR: Move javascript tests inside discourse app
...
This is where they should be as far as ember is concerned. Note this is
a huge commit and we should be really careful everything continues to
work properly.
2020-10-02 11:29:36 -04:00
Joffrey JAFFEUX
530d9ab071
DEV: enforces eslint’s curly rule to the codebase ( #10720 )
...
eslint --fix is capable of fix it automatically for you, ensure prettier is run after eslint as eslint --fix could leave the code in an invalid prettier state.
2020-09-22 16:28:28 +02:00
Joffrey JAFFEUX
52672b9eab
DEV: apply new coding standards ( #10592 )
2020-09-04 13:42:47 +02:00
Robin Ward
2b2434b82d
Start Discourse in an initializer ( #9930 )
...
* DEV: To be pedantic, there is more than EMBER in there now
* DEV: Use less globals. Have `Discourse` start in an initializer
* DEV: Remove another global
2020-05-29 14:37:02 -04:00
Sam Saffron
9841569bba
Revert "DEV: Fix a deprecated ember import ( #9903 )"
...
This reverts commit 75f46ca632 .
This unfortunately breaks
`RAILS_ENV=production bin/rake assets:precompile`
I don't think discourse-loader.js is transpiled
2020-05-28 10:06:05 +10:00
Jarek Radosz
75f46ca632
DEV: Fix a deprecated ember import ( #9903 )
...
See the following for `Ember.testing` and `@ember/debug isTesting`:
* 8cf29959f7/packages/ember/index.js (L372-L376)
* 8cf29959f7/packages/%40ember/debug/lib/testing.ts
2020-05-27 22:47:46 +02:00
Michael Brown
d9a02d1336
Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse ""
...
This reverts commit 20780a1eee .
* SECURITY: re-adds accidentally reverted commit:
03d26cd6 : ensure embed_url contains valid http(s) uri
* when the merge commit e62a85cf was reverted, git chose the 2660c2e2 parent to land on
instead of the 03d26cd6 parent (which contains security fixes)
2020-05-23 00:56:13 -04:00
Jeff Atwood
20780a1eee
Revert "Merge branch 'master' of https://github.com/discourse/discourse "
...
This reverts commit e62a85cf6f , reversing
changes made to 2660c2e21d .
2020-05-22 20:25:56 -07:00
Robin Ward
6c9c8dfefd
FIX: guidFor is not part of Ember.Object
2020-05-20 11:31:11 -04:00
Robin Ward
aa2d040526
DEV: Update ESLint to remove I18n global
...
Also fixes missed imports in core.
2020-05-14 10:18:12 -04:00
Robin Ward
eab560fe2a
DEV: import I18n instead of global usage ( #9768 )
...
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
2020-05-13 16:23:41 -04:00
Robin Ward
01929e3505
DEV: Move preload-store to discourse/lib/preload-store
...
It's only used inside Discourse so it needn't be its own module
2020-05-06 15:28:06 -04:00
Robin Ward
eda2d184d6
Backwards compatibility for raw-templates lib
2020-05-06 09:14:19 -04:00
Robin Ward
056327c0c9
DEV: Move discourse.js to app/app.js ( #9545 )
...
This is another thing to get our application in line with what Ember CLI
expects.
2020-04-27 13:28:10 -04:00
Blake Erickson
5b98161f2f
DEV: ember-cli refactor for TextField and TextArea imports ( #9480 )
...
In order to be able to use ember-cli we need to fix the import
statements for `TextField` and `TextArea` in the code base.
The only change I don't fully understand is the one in
`discourse-loader.js`, but adding the components to that file make it
all work.
2020-04-23 12:36:05 -06:00
Robin Ward
96d026a329
DEV: Remove EventTarget. Future versions of Ember don't export this.
...
It was removed altogether from ApplicationRoute, which only triggered
an `activate` event which never seems to be used.
We can replace it with Evented which is still present.
2020-04-20 16:45:01 -04:00
Zdravko Curic
d0d5f0c912
DEV: Add Ember.PromiseProxyMixin to ember modules ( #9312 )
2020-03-30 11:37:14 -04:00
Jarek Radosz
48ba65f406
DEV: Clean up Ember imports ( #8979 )
...
Includes:
* Import `computed` helpers
* Import `@ember/application`
* Import `isBlank` from `@ember/utils`
* Import `A` from `@ember/array`
* Import `EmberArray` from `@ember/array`
* Import `ArrayProxy` from `@ember/array/proxy`
* Import `warn` from `@ember/debug`
* Import `EmberObject` from `@ember/object`
* Import `Application` from `@ember/application`
* Import `EmberRouter` from `@ember/routing/router`
* Import `isPresent` from `@ember/utils`
* Import `computed` from `@ember/object`
* Import `guidFor` from `@ember/object`
* Import `isArray` from `@ember/array`
* Import `TextField` from `@ember/component`
* Import `TextArea` from `@ember/component`
* Import `Promise` from `rsvp`
* Import `Evented` from `@ember/object/evented`
* Replace deprecated `ember-addons/ember-computed-decorators` imports
2020-03-06 23:49:28 +01:00
Jarek Radosz
c607870f08
DEV: Add more @ember imports ( #9012 )
2020-02-21 14:27:04 +01:00
Joffrey JAFFEUX
25ebfd5998
DEV: allows to import isPresent ( #8993 )
2020-02-18 23:41:15 +01:00
Mark VanLandingham
499b57a9ed
DEV: Ember linting - disallow Ember.* variable usage ( #8782 )
2020-02-05 10:14:42 -06:00
Jarek Radosz
4ab696dd2f
DEV: Add the @action decorator ( #8836 )
...
This also enables`@action` use in plugin connectors.
Setting `actions` earlier allows `setupComponents` to use them, for example, when setting up event listeners.
2020-02-04 11:42:25 +01:00
Mark VanLandingham
94e8fd68bf
FIX: Remove uneeded from discourse loader ( #8390 )
2019-11-21 11:46:27 -06:00
Mark VanLandingham
5ba63f8a98
FIX: Aliases for require functioning ( #8387 )
2019-11-21 11:39:50 -06:00
Robin Ward
947416004f
FIX: EventTarget error
2019-11-20 15:51:42 -05:00
Robin Ward
d7ae052efe
DEV: Don't allow Promise unless imported from "rsvp"
...
We want to make sure we are using the correct promise implementation so
let's lint out the browser version.
2019-11-20 15:24:59 -05:00
Daniel Waterworth
d541183906
DEV: Make it possible to deprecate plugin outlet properties
2019-11-20 13:56:26 +00:00
Robin Ward
f518065654
FIX: computed is part of @ember/object not @ember/object/computed
2019-11-13 11:58:09 -05:00
romanrizzi
c9bd463e9d
DEV: Let is not supported, use var instead
2019-11-12 14:58:16 -03:00
Mark VanLandingham
213ebc3b32
DEV: Deprecation warning for aliased module usage ( #8341 )
2019-11-12 10:20:14 -06:00
Robin Ward
34665d3f96
FIX: In case @ember/object hasn't been loaded yet
2019-11-11 15:56:58 -05:00
Robin Ward
e39d89ecd9
REFACTOR: Remove InputValidation which was simply an Ember.Object
2019-11-11 15:48:56 -05:00
Mark VanLandingham
20266325fc
combined import definitions in discourse-loader
2019-11-11 10:37:21 -05:00
Mark VanLandingham
1bbb9b30fc
DEV: Import isNone for @ember/utils
2019-11-11 10:37:21 -05:00
Mark VanLandingham
e51efce356
DEV: Remove all instances of Ember.computed ( #8324 )
2019-11-08 12:28:11 -06:00
Mark VanLandingham
47e3e56905
FIX: Alias modules that are required AND imported ( #8315 )
2019-11-08 09:48:02 -06:00
Mark VanLandingham
6275c05c0d
DEV: Move computed to discourseComputed ( #8312 )
2019-11-07 15:38:28 -06:00
Mark VanLandingham
9ffdbf912f
DEV: Import ember ENV instead of Ember.testing ( #8305 )
2019-11-07 11:20:35 -06:00
Mark VanLandingham
edc135d9c5
DEV: Import set, setProperties, helper, and string functions ( #8297 )
2019-11-05 12:43:49 -06:00
Mark VanLandingham
014f19b6ea
DEV: Import Promise from rsvp ( #8296 )
2019-11-05 10:37:32 -06:00
Mark VanLandingham
fa56ba89a5
Import getProperties from @ember/object
2019-11-04 14:24:30 -05:00
Robin Ward
640a05c4ee
REFACTOR: Remove Ember.get
2019-11-01 13:50:15 -04:00
Robin Ward
90f934a660
REFACTOR: Use a module for Ember.isEmpty
2019-11-01 13:50:15 -04:00
Mark VanLandingham
11f50eee3b
DEV: Remove pretty_text import hack & still work server-side ( #8266 )
...
* FIX: move attachment_css_class constant out of upload-short-url for discourse-markdown-it
* Use setTimeout instead of ember later
* WIP. Not sure if this worked.
* oneboxer cache in separate file
* Reset onebox cache still
* set functions for oneboxers cache
2019-10-31 11:54:46 -05:00
Mark VanLandingham
02a886ce13
DEV: Import Ember.on from @ember/object/evented ( #8268 )
...
* DEV: Import `Ember.on` from @ember/object/evented
* Dont import "on" outsie of the js or admin app
* Fixed error when resolving merge conflicts
2019-10-30 17:05:27 -05:00
Mark VanLandingham
2ae21e9c35
DEV: Import every instance of Ember.computed function ( #8267 )
...
* DEV: Import every instance of Ember.computed function
* export default for Ember.computed
2019-10-30 15:28:29 -05:00
Mark VanLandingham
ba4b557114
DEV: Remove Ember.Mixin to import @ember/object/mixin ( #8269 )
2019-10-30 15:03:08 -04:00