Commit Graph

116 Commits

Author SHA1 Message Date
Jarek Radosz ae1a391377 FIX: Quoting posts (#9378)
Fixes to the quote feature. Most important changes listed below:

* FIX: Correctly attribute quotes when using Reply button
* FIX: Correctly attribute quotes when using replyAsNewTopic
* FIX: Allow quoting a quote
* FIX: Correctly mark quotes as "full"
* FIX: Don't try to create a quote if it's empty
* DEV: Remove an obsolete method `loadQuote`
  It isn't used in core anymore, the only use in core has been removed over 4 years ago in 3251bcb. It's not used in any plugins in all-the-plugins and all references to it on GitHub are from outdated forks (https://github.com/search?q=%22Post.loadQuote%22&type=Code)
2020-04-08 16:28:23 +02:00
Sam Saffron 20d8b49add DEV: remove targetUsernames deprecation
Stable already has this rename, no need to carry the deprecation anymore.
2020-04-03 14:35:30 +11:00
Sam Saffron a098464af3 FIX: ninja edit for replies not working
There is an edge case, in some cases when pulling a post from the store
there is no topic, this ensures it is loaded correctly.
2020-04-01 16:40:55 +11:00
Sam Saffron b8d2261db9 FIX: correctly load drafts based of id
Previously we relied on race conditions to correctly open a draft, so this
broke.

New code is deliberate.

Also corrects missing observers on composer action
2020-04-01 14:23:26 +11:00
Sam Saffron a34711c23a FIX: do not save draft while it is loading
When editing a post we were incorrectly saving a draft prior to user typing

This caused a bloat in the amount of drafts saved per user and inconsistency
around behavior of "escape" button.

It also lead to lots of warnings about draft conflicts when copying stuff
between posts.

The code is improved to use promises more appropriately, however further
changes are needed to clean up internals so methods consistently return
promises.

Too many methods in the controller sometimes return a promise and sometimes
an object. Long term the methods will become async and all of this will be
corrected.
2020-03-31 11:49:10 +11:00
Robin Ward 032205e202 Rename many .js.es6 files to .js 2020-03-12 13:29:55 -04:00
Robin Ward 091af27a31 FIX: Reply as new topic should select the correct category 2015-03-12 14:41:58 -04:00
Régis Hanol 5ceb84421e UX: remove live character countdowns from the composer 2015-03-09 17:46:36 +01:00
Sam de107a60c2 UX: navigate to staged posts faster right away
stop with the blue unread circle on new posts
2015-03-06 14:17:01 +11:00
Sam 531511fe35 correct staging code so it works as expected even if preview is simply disabled 2015-03-04 17:08:29 +11:00
Sam c5897972fd FIX: do not stage posts on mobile, we have no cooked 2015-03-04 15:13:20 +11:00
Robin Ward a519fd5bcf FIX: Highlighting was not being applied after some rendering.
Also includes a bunch of ES6 stuff.
2015-02-12 15:37:02 -05:00
Régis Hanol 0a252d7785 FIX: quote whote post should insert at cursor position 2015-02-02 19:08:28 +01:00
Robin Ward d7b7ec9e0a FIX: Wiki editing was broken due to extra topic update 2015-01-30 18:02:11 -05:00
Robin Ward d43944b3ed Extensibility for tracking changes to a topic 2015-01-28 13:37:06 -05:00
Arpit Jalan 62c1291548 FIX: user name and title were not showing on post creation 2015-01-22 02:28:04 +05:30
Robin Ward 5667478b4d A common, extensible interface for sending topic columns across the wire
This allows plugins to specify topic columns to serialize and save in
the database via the composer when creating topics and editing their
first posts.
2015-01-06 14:53:12 -05:00
Robin Ward 7182767349 Refactor topic title/category saving to support easier changing of
attributes via plugins.
2015-01-02 14:25:41 -05:00
Sam 23163422e6 correct positioning when emoji is added 2014-12-08 14:22:54 +11:00
Sam 357a12f78e FEATURE: work-in-progress emoji selector toolbar item 2014-12-05 17:19:17 +11:00
Régis Hanol 1210486623 FIX: editing the 1st post of a private message wasn't working 2014-12-02 16:04:45 +01:00
Régis Hanol 5754e8dd0f FEATURE: auto-close topics based on last post 2014-10-10 18:21:44 +02:00
Robin Ward 11b52d1334 More deprecations to allow us to work on future versions of Ember 2014-10-07 16:04:19 -04:00
Régis Hanol 948e0740c9 FEATURE: add glyphs in the composer 'save' button 2014-09-08 19:02:53 +02:00
Robin Ward 334e21a03a Revert "Revert "FEATURE: Can create warnings for users via PM""
This reverts commit 1c7559380c.
2014-09-08 11:11:56 -04:00
Robin Ward 1c7559380c Revert "FEATURE: Can create warnings for users via PM"
This reverts commit b0bfc1f93f.
2014-09-08 10:38:59 -04:00
Robin Ward b0bfc1f93f FEATURE: Can create warnings for users via PM 2014-09-08 10:27:06 -04:00
Robin Ward dc260110fa FIX: If editing a reply, the quote button should target the post it was
a reply to, not the post you're editing.
2014-08-08 16:41:58 -04:00
Neil Lalonde 443caaa8f7 FIX: don't let admins skip post validations, unless it's faq, tos, or privacy 2014-08-01 14:53:35 -04:00
Neil Lalonde e1be478ef4 FIX: admins bypass some post validations. This allows them to edit legal docs even if those docs are longer than max post length, for example. 2014-07-28 16:40:14 -04:00
Sam 806ddb4ccb FEATURE: Quote reply at cursor 2014-06-18 15:17:55 +10:00
Robin Ward 6f8888d405 XSS: Topic links needed sanitization 2014-06-14 12:53:48 -04:00
Robin Ward 651def63e5 Return the current user's custom fields 2014-06-05 16:16:45 -04:00
Neil Lalonde a3c148407c Mobile: don't show edit reason and in reply to details in composer 2014-06-05 12:09:08 -04:00
Régis Hanol 7655066967 BUGFIX: progress bar was hidden when the composer was open 2014-06-04 13:03:14 +02:00
Sam fb3e06bd64 BUGFIX: progress was 0 of 100 while a post is in transit
BUGFIX: highest_post_number could be incorrect
BUGFIX: incorrect rendering of in-situ post (when its a reply)
2014-06-02 12:56:54 +10:00
Sam 7653262a07 BUGFIX: flashing incorrect avatar while posting
BUGFIX: incorrect trophy for admins while posting
2014-06-02 12:56:54 +10:00
Neil Lalonde 512771932a Show a warning to admins if the site has fewer than 5 topics. 2014-05-23 12:25:16 -04:00
Sam fad868c78f Bump hashes on various files
Upgrade jquery


I made this commit cause my JS debugging CDN support added a header and
wanted we bump cache everywhere
2014-05-15 15:52:09 +10:00
Vikhyat Korrapati dea978d7fc Fix missing avatar while a post is being created. 2014-04-01 19:26:54 +05:30
Wojciech Zawistowski 297c25ca1f Synced editor scrolling PoC. 2014-03-31 20:57:45 +02:00
Neil Lalonde bfc8c65212 Remove wrench icon and auto-close options from composer. The same options are available after the topic has been created. 2014-03-25 14:07:05 -04:00
riking 86774fa5c1 Simplify return statements 2014-03-18 18:23:15 -07:00
Robin Ward b0f3061113 It doesn't make sense to redirect when not logged in on a non-GET
request. We should report a failure then. They likely logged out or
in another tab or timed out.
2014-03-05 12:12:53 -05:00
Vikhyat Korrapati 74ab14de19 Add poll plugin. 2014-02-13 07:39:01 +05:30
Neil Lalonde 2a33a35566 Staff can create uncategorized topics even if allow_uncategorized_topics is false 2014-01-15 15:58:29 -05:00
Robin Ward a502266c42 Enable JSHINT's unused option. It caught a bunch of suspicious stuff which is fixed in this commit. 2013-12-30 13:30:22 -05:00
Neil Lalonde 1cc72d564f Add specs for topic create with auto_close_time. Just ignore auto_close_time from users who are not authorized to use it instead of raising an error. 2013-11-28 11:06:04 -05:00
Neil Lalonde a9ab98ef9e Auto-close time can be entered in 3 ways, so a topic can close at any time 2013-11-27 09:52:35 -05:00
Régis Hanol 6e3de67977 fix edit reason when editing a reply 2013-11-18 19:51:30 +01:00