Mark VanLandingham
6275c05c0d
DEV: Move computed to discourseComputed ( #8312 )
2019-11-07 15:38:28 -06:00
Mark VanLandingham
2ae21e9c35
DEV: Import every instance of Ember.computed function ( #8267 )
...
* DEV: Import every instance of Ember.computed function
* export default for Ember.computed
2019-10-30 15:28:29 -05:00
Robin Ward
8d34f4bbd9
Revert "Revert Ember.run refactors"
...
This reverts commit fcb1ca52f9 .
2019-10-30 09:48:24 -04:00
Robin Ward
fcb1ca52f9
Revert Ember.run refactors
...
This reverts commit 5ca60fcb6b .
2019-10-29 17:10:47 -04:00
Robin Ward
e5525d03b8
FIX: Yet more linting fixes
2019-10-29 16:14:46 -04:00
Robin Ward
5ca60fcb6b
REFACTOR: Use imports for Ember.run
2019-10-29 15:31:56 -04:00
Robin Ward
a8a76198b1
REFACTOR: Remove Ember.Component global variable
...
Use imports instead.
2019-10-23 12:30:52 -04:00
Penar Musaraj
d45866eb5c
UX: Fix topic progress placement in iOS app
...
Fixes placement issues introduced in #45a55a3
Fixes topic progress placement when composer is collapsed with a draft
2019-10-06 16:10:08 -04:00
Penar Musaraj
45a55a3abf
FIX: Correct position of topic progress in iOS when composer is visible
...
This fix is needed due to what feels like an iOS Safari bug. The CSS rule `margin-bottom: env(safe-area-inset-bottom);` should not apply to the topic progress element when the composer is visible, because the element is not near the bottom of the viewport.
2019-10-02 20:54:11 -04:00
Penar Musaraj
5cf299733a
UX: Fix topic progress placement
...
Keeps element 1em away from the right edge of screen
Takes DiscourseHub app nav position into account on iPad
Uses outerHeight to calculate element height including padding/borders
2019-10-01 13:14:36 -04:00
Joffrey JAFFEUX
b3eb67976d
DEV: Upgrades to Ember 3.10 ( #7871 )
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-07-16 12:45:15 +02:00
Joffrey JAFFEUX
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 ( #7592 )
2019-05-27 10:15:39 +02:00
Joe
6d7c0c8f13
REFACTOR: scroll-based mobile header switch
...
This refactor addresses the following issues:
1- Moves all relevant logic to the discourse-topic component (matches desktop)
2- Fixes the flicker issue discussed here
3- Fixes a rare occurring issue where tags wrap to a third line if a topic has long category names and lots of tags
4- Fixes header icon jitter on iOS
5- Fixes an issue where sliding out user / hamburger menus on Android leaves the user in a mid-state with half a title and the header panel visible - swiping will now open the menus but have no effect on the header.
6- adds min-width to the small-logo to act as placeholder so that the title doesn't shift if the logo takes a while to load.
Other than that, everything should look and act the same.
2019-03-19 18:39:38 +08:00
Simon Cossar
c742d42031
FIX: rtl topic progress wrapper position ( #7070 )
...
* Set left/right topic-progress-wrapper CSS from text-direction
* Remove unnecessary CSS rule
2019-02-25 20:56:52 -05:00
Joffrey JAFFEUX
502b1316d0
DEV: s/this._super()/this._super(...arguments) ( #6908 )
2019-01-19 10:05:51 +01:00
Joe
98354bd34c
fix the build
2018-11-23 11:27:59 +08:00
Joe
c4fca36255
FIX: don't trigger header:hide-topic at the bottom on desktops
...
On mobile we trigger `header:hide-topic` at the very bottom of topics to switch the header contents back from small logo + topic info to large logo + user panels.
Given that the `topic-progress` component is sometimes loaded on desktop - E.g composer is open or on narrow desktop screens - we need a guard to prevent this logic from firing on desktops.
2018-11-23 10:14:13 +08:00
Joe
ee6c0170ce
FEATURE: Scroll-based logo on mobile ( #6632 )
2018-11-21 21:21:49 -05:00
Penar Musaraj
98aaad6675
Improve "hit area" for topic progress bar on mobile ( #6442 )
...
* Improve "hit area" for topic progress bar on mobile
* Only target admin wrench on mobile
2018-10-02 12:26:16 -04:00
Penar Musaraj
533315a607
Fix progress bar position when theme has header elements outside #main ( #6425 )
2018-10-02 10:45:23 +10:00
Joffrey JAFFEUX
03a7d532cf
DEV: introduces prettier for es6 files
2018-06-15 17:03:24 +02:00
Régis Hanol
76474f3156
UX: ensure topic progress indicator isn't floating in very short topics
2018-04-20 17:26:50 +02:00
Kris
7ff78cc013
docked topic progress indicator too wide
2018-04-11 23:52:32 -04:00
Régis Hanol
d19bbfc7f8
UX: ensure the topic progress indicator is never overlapping with post controls
2018-04-09 19:44:35 +02:00
Robin Ward
6385c7fcb3
UX: Don't let topic progress widget dangle when preview is disabled
2018-03-08 16:34:19 -05:00
Robin Ward
566cf31c66
UX: Always show topic progress on mobile
2017-06-30 16:19:19 -04:00
Robin Ward
5fda2b84e1
FIX: If the progress bar is docked, set the progress to 100%
2017-06-22 14:43:15 -04:00
Robin Ward
394efb3290
FIX: Docking of progress component on iOS was a bit off
2017-06-19 15:53:51 -04:00
Robin Ward
63c32b6b21
FIX: Don't animate the progress bar unless scrolling
2017-06-05 15:38:40 -04:00
Robin Ward
f0f5fbf132
FIX: Never show the last read marker within 1 post of the last
2016-12-20 13:22:22 -05:00
Robin Ward
4dcb29acbf
UX: Show Back button above mobile progress widget
2016-12-19 14:06:19 -05:00
Robin Ward
e03d5e2140
Reapply Ember 2.10 for good this time!
...
This reverts commit ddd299f4aa .
2016-12-19 11:19:10 -05:00
Robin Ward
ddd299f4aa
Revert "Revert "Revert Ember 2.10+ for a short while""
...
This reverts commit 76bbc481cb .
2016-12-16 10:29:30 -05:00
Robin Ward
76bbc481cb
Revert "Revert Ember 2.10+ for a short while"
...
This reverts commit 21682fd60b .
2016-12-16 09:52:29 -05:00
Robin Ward
21682fd60b
Revert Ember 2.10+ for a short while
2016-12-15 16:43:38 -05:00
Robin Ward
28699e66d8
Revert "REVERT: Ember 2.10 -- it's not building properly"
...
This reverts commit 600541c623 .
2016-12-15 10:28:15 -05:00
Robin Ward
600541c623
REVERT: Ember 2.10 -- it's not building properly
2016-12-12 16:19:05 -05:00
Robin Ward
765e5e9186
Upgrade to Ember 2.9
2016-12-12 14:44:29 -05:00
Robin Ward
4820ebd76c
FIX: Don't modify properties in didInsertElement
2016-12-01 14:08:51 -05:00
Sam
1bf0b2a5f4
FEATURE: show timeline component when expanding post progress
...
- Show fullscreen timeline with title of topic in mobile
- Go to post # kb shortcut now unconditionally uses a modal
- Always show wrench on topics (was missing if progress bar was showing)
- Be smarter about rendering timeline even if composer is open (provided there is room)
2016-10-19 14:29:58 +11:00
Robin Ward
424bb143db
FIX: Jump to post on iOS was broken - replace with prompt
2016-07-26 15:08:04 -04:00
Robin Ward
bdd15d5452
FIX: Don't remove all events, only the ones we created
2016-06-14 13:40:56 -04:00
Robin Ward
fd57865046
UX: Mobile topic progress was docking in the wrong place
2016-06-02 12:40:17 -04:00
Robin Ward
810b213ca0
FIX: Some last read position fixes
2016-06-01 17:27:19 -04:00
Robin Ward
e24fe0246a
Have the topic progress and timeline use the same appEvent
2016-06-01 15:53:13 -04:00
Robin Ward
a8fba38486
UX: Topic progress was docked in the wrong place.
2016-06-01 15:53:12 -04:00
Robin Ward
a832d88375
UX: Hide the timeline when the composer is open
2016-06-01 14:42:00 -04:00
Robin Ward
70df75c381
UX: Show the progress widget when the composer is expanded
2016-05-31 16:55:56 -04:00
Robin Ward
321a11fe41
FIX: Docking of old widget regressed
2016-05-31 11:13:04 -04:00
Robin Ward
9609680ba9
FIX: Progress wasn't updating after becoming visible
2016-05-31 10:51:58 -04:00