Commit Graph

64 Commits

Author SHA1 Message Date
Robin Ward
02f6db4e59 FIX: Back button shenanigans when redirecting from index routes
This is a problem that has long plagued Discourse. The root issue here
is that we have to implement our own link click handler, because
Discourse allows users to create HTML blobs of content with links, and
when those links are clicked they must be handled by the Ember router.

This always involved a certain amount of use of private Ember APIs which
of course evolved over time.

The API has more or less stabilized in the last two years, however we
have hacks in our URLs to handle a dynamic root path, depending on how
forums have set up their filters and in what order.

This patch adds a special case for the root path so we needn't update
the URL ourselves otherwise, which preserves the back button on index
routes. The update call would otherwise insert an extra history event if
a route redirected on transition, breaking the back button.
2019-06-21 14:42:01 -04:00
Joffrey JAFFEUX
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 (#7592) 2019-05-27 10:15:39 +02:00
Joe
ec2123809f FEATURE: user and group cards on mobile (#7246) 2019-03-25 13:37:17 +01:00
Osama Sayegh
67b96ad2ff FIX: discourse client should know about Logster (simpler approach) (#7237)
* Revert "FIX: discourse client should know about Logster (#7232)"

This reverts commit bfcbc4d2d6.

* FIX: discourse client should know about Logster (simpler approach)
2019-03-22 08:48:57 +11:00
Joffrey JAFFEUX
1a3655b787
DEV: s/Em/Ember (#6874) 2019-01-11 17:54:23 +01:00
Penar Musaraj
4f6ca66df5 FIX: routeToTag mini-fix for IE11
skip "a.host" for IE11 since IE11 does not support URL interface
2018-12-28 11:49:51 -05:00
Bianca Nenciu
6ad13e5ae9 FIX: Avoid redirection when not leaving forum. (#6419)
* FIX: Avoid redirection when not leaving forum.

* DEV: Updated click-track's tests.
2018-10-04 22:06:31 +08:00
Sam
56b6a4779d FIX: make route to tag more robust
There are some edge cases where code would fail here, so adding protection
2018-09-06 17:24:32 +10:00
James Kiesel
a4001c1ea0 FEATURE: Pop revise modal on post edited notification (#6287)
* Add revision number to notification url

* Pop modal on route change

* Add semicolon

* Ensure modal pops even when navigating within a topic

* Ensure modal pops when visiting from other page

* Fix eslint errors

* Fix prettier errors

* Add callback for notification item click

* Remove stray revisionUrl function

* Rename to afterRouteComplete
2018-08-24 09:13:07 -04:00
Joffrey JAFFEUX
03a7d532cf
DEV: introduces prettier for es6 files 2018-06-15 17:03:24 +02:00
Régis Hanol
f56a746d71 Add baseUri to site model 2018-03-24 02:43:19 +01:00
Arpit Jalan
585fc26f8e FIX: allow discourse app to link directly to upgrade page 2018-02-15 18:20:25 +05:30
Robin Ward
ae15faeb34 FIX: Allow links from one relative uri to another 2018-02-12 18:27:08 -05:00
Neil Lalonde
e7d8f5f9c8 FIX: support /my routes with subfolders 2017-10-31 16:02:32 -04:00
Robin Ward
31f7640335 FIX: Allow discourse app to link directly to wizard 2017-07-10 14:31:58 -04:00
Robin Ward
35ff5d6796 FIX: Naving to root URL was broken 2017-07-04 12:44:53 -04:00
Robin Ward
8ae445766f Upgrade Ember to 2.13 2017-06-15 10:12:07 -04:00
Robin Ward
8e2e962b1a FIX: Replace /my/ URLs before fixing the prefix 2017-06-08 16:21:54 -04:00
Robin Ward
09cb61b533 FIX: Jumping to a post that doesn't exist should jump to closest 2017-05-03 13:24:30 -04:00
Robin Ward
b381372184 Use Ember.js for the /u/account-created path so we can add controls 2017-05-03 11:18:01 -04:00
Robin Ward
397e850fba FIX: Allow replaceState to run on iOS.
Removes a test for unsupported versions.
2017-04-07 11:30:24 -04:00
Robin Ward
62be121328 FIX: On long browsers, you could get a double title 2017-03-31 13:00:52 -04:00
Robin Ward
45a257815a Convert front end paths from /users/ to /u/ 2017-03-30 10:23:24 -04:00
Robin Ward
6b976433c9 Support for both /users/ and /u/ paths 2017-03-30 10:23:24 -04:00
Robin Ward
86f11955cf FIX: Clicking on the title was doubling up the title 2017-03-28 17:05:07 -04:00
Robin Ward
d161422002 UX: Be more optimistic about showing topic titles while entering topics 2017-03-23 13:53:49 -04:00
Robin Ward
b2b7f4d905 FIX: Query parameters were not being cleared when changing filtering. 2017-02-27 15:49:14 -05:00
Robin Ward
0c71e37aab Merge pull request #4660 from ryantm/serversideonly
add more SERVER_SIDE_ONLY routes; use pathname in matching
2017-01-17 13:55:40 -05:00
Ryan Mulligan
f641655f1b add more SERVER_SIDE_ONLY routes; use pathname in matching 2017-01-17 09:51:39 -08:00
Robin Ward
11641fb3cd Whitelist the alternative raw url 2017-01-17 11:11:27 -05:00
Robin Ward
70fb2431a1 Migrate this.container to getOwner(this) 2016-11-07 15:21:31 -05:00
Robin Ward
3bb4e22692 FIX: cleanDOM couldn't be called from url 2016-10-26 13:27:47 -04:00
Robin Ward
f0937dc5d3 FIX: Route to .rss or .json as a server side URL 2016-09-28 10:36:56 -04:00
Robin Ward
8871c9852c FIX: Allow us to link to server side responses 2016-09-28 05:04:23 -04:00
Robin Ward
a26e0df0c7 FIX: Bug when linking to anchors 2016-09-20 11:13:40 -04:00
Régis Hanol
96b6d342cc FIX: /categories page issues
FIX: endless spinner when /categories is set to homepage and you click the home logo
FIX: latest column should respect topic state for the current user (new, unread, etc.)
FIX: post count should have heat colors applied based on like ratios
FIX: Add "More" button at the bottom of the latest column
UX: The topic count number in the categories panel should be slightly larger
2016-08-18 19:41:21 +02:00
Robin Ward
078f6c3fb5 FIX: Consistency with HTML anchors 2016-07-20 15:13:56 -04:00
Robin Ward
e09a304122 FIX: Jumping within a topic should respect anchors 2016-07-20 14:39:26 -04:00
Robin Ward
e7e6840803 FIX: I shouldn't commit while tired :) 2016-07-20 10:42:35 -04:00
Robin Ward
ad7e2f15c7 Support linking to anchored headings in the first post 2016-07-19 17:05:45 -04:00
Robin Ward
a546395397 REFACTOR: Migrate markdown functionality in ES6 2016-07-11 12:57:05 -04:00
Robin Ward
5fc47e6942
FIX: Much less jankiness on the scroller 2016-05-31 10:52:00 -04:00
Robin Ward
f854eebc5f
FIX: Entering a topic at the bottom would cause scroll jumps 2016-05-31 10:51:59 -04:00
Robin Ward
2bd59d7ca1
FIX: Some odd jumping behavior for the timeline 2016-05-31 10:51:44 -04:00
Robin Ward
559fa36c18
FEATURE: Topic timeline widget 2016-05-31 10:51:39 -04:00
Robin Ward
751e354ca6
Refactor topic-progress into a component 2016-05-31 10:51:39 -04:00
Robin Ward
e831203897
FIX: Widgets should support links to foreign hosts 2016-05-11 12:02:10 -04:00
Robin Ward
4875fe1c3e
FIX: Logo links to a different domain were broken 2016-05-10 10:42:16 -04:00
Robin Ward
1a3b63e07d
createWithMixins is deprecated. 2016-04-29 16:50:52 -04:00
Robin Ward
95854a94c9
FIX: When viewing a summary, if a post jumps to the bottom cancel it. 2016-04-13 15:58:54 -04:00