Commit Graph

721 Commits

Author SHA1 Message Date
Kane York
05010b6b33 Add HTTP error codes to ajax-error 2015-06-30 11:39:17 -07:00
Gerhard Schlager
d08693edce FEATURE: Make abbreviated numbers (k, M) localizable
- Make the decimal separator and thousands delimiter localizable
- Add translations for all languages, otherwise this will look very ugly
2015-06-26 00:51:12 +02:00
Robin Ward
6422d5efbd Use the same component for similar topics as search results. 2015-06-24 15:08:22 -04:00
Sam
afa11b214e UX: smoother j/k handling 2015-06-23 17:00:57 +10:00
Sam
a714334180 Merge pull request #3559 from gschlager/keyboard
FEATURE: Close search window when Ctrl+F is pressed
2015-06-23 15:53:32 +10:00
Robin Ward
7ed309666b Refactor search results to be components instead of views for reuse 2015-06-22 15:08:51 -04:00
Régis Hanol
b25a16ee3e FEATURE: 2 new reports: time to first response, topics with no response
FIX: relativeAgeMediumSpan was off by 1
REFACTOR: extracted decimalAdjust & round functions from the poll plugin
2015-06-22 19:46:51 +02:00
Gerhard Schlager
3e2653d198 FEATURE: Close search window when Ctrl+F is pressed.
FIX: All search related keyboard shortcuts enabled the "search context", but only Ctrl+F inside of topics should enable it.
2015-06-19 23:04:00 +02:00
Robin Ward
e4085a64ce FIX: Use proper upper/lower case when previewing mentions 2015-06-15 10:58:03 -04:00
Régis Hanol
2d03163be0 FEATURE: add support for emojis in title 2015-06-15 15:27:22 +02:00
Robin Ward
ef1d27fffc PERF: Debounce mention lookup, enforce minimum username 2015-06-11 15:12:16 -04:00
Sam Saffron
c58b495e15 SECURITY: Query @usernames in bulk
Otherwise you could add many requests at once while composing.
2015-06-11 13:03:49 -04:00
Jeff Atwood
ae52f4e776 Revert "Don't limit @mention autocomplete to latin characters"
This reverts commit effe83d7a9.
2015-06-10 12:53:57 -07:00
Noam Yorav-Raphael
effe83d7a9 Don't limit @mention autocomplete to latin characters
The userSearch() function, used for @mention autocomplete, returned an empty
list if the query string included non-latin characters or spaces. This removes
this restriction, so you can search users by any characters in their display
name, including spaces.
2015-06-10 11:50:52 +03:00
Régis Hanol
a09d893c0c FIX: missing emoji autocomplete 2015-06-05 20:24:49 +02:00
Régis Hanol
9d4c53c882 FIX: custom emoji autocomplete 2015-06-02 17:48:19 +02:00
Robin Ward
b2a7411620 FIX: decorateCooked was not being applied to embedded posts 2015-06-01 11:58:50 -04:00
Sam Saffron
7942b28780 FIX: Emoji aliases not autocompleted 2015-06-01 12:33:42 +10:00
Régis Hanol
5145fabfbf Merge pull request #3506 from cpradio/fix-reply-to-topic-shortcut
FIX: Reply to Topic shortcut no longer needs the Reply Topic Button to be available
2015-05-28 12:04:28 +02:00
cpradio
bb5d27429f FIX: Reply to Topic shortcut no longer needs the Reply Topic Button to be available 2015-05-27 22:23:21 -04:00
Régis Hanol
e101396ea1 FEATURE: add support for device pixel ratio = 3 2015-05-28 01:48:07 +02:00
Neil Lalonde
364437da28 FIX: subfolder support for page refresh when assets have changed 2015-05-26 13:13:09 -04:00
Régis Hanol
85d4d3223c FIX: crop avatars on the server instead of the client
FIX: support for dots in S3 bucket names
2015-05-26 15:54:25 +02:00
Paul Kaplan
bbe200e3cf Fix missing bracket in name selector in url anchor jumping 2015-05-26 07:49:45 -05:00
Robin Ward
78abf85087 FIX: IE9 issues with latest discourse 2015-05-25 12:32:42 -04:00
Sam
ada7b4a4e8 FIX: guard against concurrent loading of deferred assets 2015-05-22 15:07:04 +10:00
Régis Hanol
c91634c09a FIX: support for async uploads of emojis 2015-05-20 16:45:48 +02:00
Régis Hanol
566b267981 FIX: cropAvatar 2015-05-20 16:45:48 +02:00
Régis Hanol
8d967d9065 FEATURE: move all uploads to a single endpoint + defer upload creation in a background thread 2015-05-20 16:45:48 +02:00
Robin Ward
1f95ef31cc Remove deprecations in TopicProgressController 2015-05-19 12:10:18 -04:00
Robin Ward
4e0d7683ab Better error messages on admin for granting moderation
Also fixes up Ember deprecations.
2015-05-19 10:56:32 -04:00
Sam
8002c46c21 FEATURE: g b to take you to your bookmarks 2015-05-19 15:34:16 +10:00
Robin Ward
32606f82f6 FIX: replaceWith on leaf routes changed behavior in latest ember 2015-05-14 13:44:57 -04:00
riking
28f32aff66 FEATURE: Multiple notifications at once (1/topic) 2015-05-13 18:23:42 -07:00
Robin Ward
d90063fc59 FIX: Error with ace editor and new ember.
Fix upgrades ace editor, which was a huge headache due to AMD.
2015-05-13 16:25:33 -04:00
Régis Hanol
d7b3f9bfe2 FIX: properly handle errors when creating a topic 2015-05-12 22:02:06 +02:00
Robin Ward
fa69d4cec5 FIX: Missing colspan on raw topic list 2015-05-11 11:20:46 -04:00
Robin Ward
c6d99bd141 Fixes routing in tests 2015-05-11 11:18:38 -04:00
Robin Ward
aee12fd6ef Ember Deprecations for Topics 2015-05-11 11:18:37 -04:00
Sam
4f53b85ee2 add aria-label to composer buttons 2015-05-07 12:03:20 +10:00
Sam
66423e62dc FIX: don't strip / mangle full quotes 2015-05-05 10:06:48 +10:00
Sam
4dfc1907ac Simplify desktop notifications, only include if mention/reply/pm/link
Include post excerpt in the notification
2015-05-04 13:49:32 +10:00
Sam
1c7fa956dc Improve Notification probing 2015-05-04 11:14:03 +10:00
Sam
5623827433 careful checking for a global that is not there 2015-05-04 11:08:52 +10:00
riking
6ea2051c4e FIX: Don't ask for notification permission until first one 2015-05-02 12:53:30 -07:00
Robin Ward
15ea0c4789 Merge pull request #3304 from riking/desktop-notifications
Desktop notifications!
2015-04-28 16:24:02 -04:00
Régis Hanol
5783e908ea FIX: Erratic behaviour when clicking an attachment link - Take 2 2015-04-28 20:05:41 +02:00
Régis Hanol
ad3d2269b2 FIX: erratic behaviour when clicking an attachment link 2015-04-27 22:18:52 +02:00
riking
21b915f209 Suggested changes 2015-04-23 18:39:48 -07:00
Régis Hanol
a737090442 - FEATURE: revamped poll plugin
- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer
2015-04-23 19:33:29 +02:00
riking
3681674ec4 FIX: Don't cache-bust onebox requests 2015-04-21 23:11:25 -07:00
riking
a616d9ed1c Fix jshint 2 2015-04-21 21:23:05 -07:00
riking
f5630b9791 Fix JSHint errors 2015-04-21 21:10:07 -07:00
riking
f4b0f1dbef a few fixups 2015-04-21 20:23:30 -07:00
riking
8bbead315d Add idle checking, use localStorage for seen notifications 2015-04-21 20:23:30 -07:00
riking
da9913359c Convert to file in lib/, rough active tracking 2015-04-21 20:23:29 -07:00
Robin Ward
2f7b241087 FIX: Keyboard shortcuts broke in the composer 2015-04-17 14:01:45 -04:00
Robin Ward
2459f52c71 Merge pull request #3375 from techAPJ/patch-2
FEATURE: invite existing users to private topic
2015-04-16 11:13:42 -04:00
Robin Ward
b2f34da477 FIX: A couple of other deprecations to keep discourse-tagging happy 2015-04-15 22:36:16 -04:00
Arpit Jalan
d491d4f997 FEATURE: invite existing users to private topic 2015-04-16 00:52:54 +05:30
Robin Ward
0c233e4e25 Interface is wired up for Approving/Rejecting posts 2015-04-15 14:54:37 -04:00
Robin Ward
7f501a0c41 When a post returns enqueued don't insert it in the stream and notify
- Includes removal of a lot of modal boilerplate
2015-04-15 14:54:37 -04:00
Robin Ward
76f7786d0d Support saving posts via Store 2015-04-15 14:54:36 -04:00
Robin Ward
22ffcba8e6 Convert Discourse.Post to ES6 and use Store model
- Includes acceptance tests for composer (post, edit)
- Supports acceptance testing of bootbox
2015-04-15 14:54:36 -04:00
Ben Hadley-Evans
c3b461f58d Add blank alt attribute to avatars.
This was giving an ugly border to avatars in the user card as the full size version loaded in Firefox.
2015-04-14 14:39:40 +01:00
Robin Ward
afe0781c50 FIX: Topic bulk actions refresh was broken 2015-04-10 12:43:14 -04:00
Ben Hadley-Evans
895e0261ed Fix italics/bold WYSIWYG bug with nothing highlighted.
This bug was reported here: https://meta.discourse.org/t/ctrl-b-selects-asterisks/27215 - It was something I broke whilst writing PR3288.

The fix checks if it is a multiline selection, if it is not (which includes blank selections) it will leave the asterisks unhighlighted.

Also fix a bug where asterisks would not be stripped if there was whitespace at the beginning of a line in a multiline selection.

Also fix styling issues I missed last time so that it matches the rest of the document. Specifically, 4 character tabs and spaces after "if"s.
2015-04-07 17:51:39 +01:00
Régis Hanol
bdbcd21687 FIX: hide custom avatar when image upload is disabled 2015-04-07 11:54:35 +02:00
Robin Ward
da9e2792eb FIX: Bugs with autocomplete
It wasn't tearing itself down properly. It was swallowing events.
2015-04-06 14:04:42 -04:00
Sam
6f63f4fe17 correct anon search 2015-04-04 07:55:32 +11:00
Arpit Jalan
abdd63af0b Remove SHIFT-ENTER support in editor 2015-04-03 19:43:16 +05:30
Sam
214034f34a regression search route was getting in the way 2015-04-02 17:03:32 +11:00
Régis Hanol
0f4a4651a9 FIX: youtube preview video title link doesn't work 2015-04-01 18:23:27 +02:00
Régis Hanol
8760f7d817 FEATURE: don't show the 'download' link to anon when they can't even download the original image 2015-03-30 10:57:26 +02:00
Robin Ward
a30895e69d Merge pull request #3288 from savef/fix-bold-and-italic-buttons
Improve the italic and bold buttons on multiline selections.
2015-03-26 10:46:45 -04:00
Sam
e5c3266c30 Merge pull request #3295 from RaceProUK/master
Swapped order of checks
2015-03-25 16:55:54 +11:00
Sam
eaab5c64f0 window scroll event wreaks havoc, get rid of it. 2015-03-25 16:37:30 +11:00
Sam
692433f0cf try to make it a bit smoother 2015-03-25 15:23:26 +11:00
Sam
eec87b5513 workaround more missing click events 2015-03-25 14:11:17 +11:00
Sam
64cf14e19e increase timeout, so scroll event does not hit 2015-03-25 13:40:22 +11:00
Sam
707f4f9a58 more nasty iPad Safari and iPhone Safari hacks 2015-03-25 12:17:39 +11:00
RaceProUK
47d60ad86a Swapped order of checks 2015-03-24 22:36:54 +00:00
RaceProUK
33e37950f9 Added 'M' to the number formatter 2015-03-24 22:03:57 +00:00
Sam
1bdce815e2 FIX: workaround for Safari on iOS causing crazy composer positioning
see: http://stackoverflow.com/questions/29001977/safari-in-ios8-is-scrolling-screen-when-fixed-elements-get-focus
2015-03-24 17:43:05 +11:00
Régis Hanol
6930c8919e FIX: duplicate emojis in emoji-toolbar 2015-03-23 21:35:53 +01:00
Ben Hadley-Evans
229e1850ab Improve the italic and bold buttons on multiline selections.
This misuses the system that Pagedown has set up somewhat, but it has to in order to affect the content inside the selection. The end behaviour seems to me to be non-buggy and much more obvious to an end user.

Essentially, instead of performing the operation to surround characters on one line, it splits the selection into lines the loops the operation. But usually a single "chunk" is returned with some replacement text and markdown to insert before and after the text. Because we're replacing text inside the selections the before and after are left blank and the selection contains all the changed markdown.
2015-03-20 16:53:44 +00:00
Robin Ward
051a2a3d14 FEATURE: Can search the user directory by name 2015-03-19 18:07:48 -04:00
Régis Hanol
11bf7da63c FIX: profile picture wasn't properly updating 2015-03-19 19:57:07 +01:00
Régis Hanol
10ef30ab3c FIX: better handling of the 'read guidelines' badge 2015-03-16 19:25:28 +01:00
Régis Hanol
4ff1e19712 FIX: emoji aliases were not recognised 2015-03-16 18:28:11 +01:00
Erick Guan
ae62c1361e extends share links
- change `iconClass` to `faIcon`
- add `htmlIcon` to allow custom HTML
- add reddit, linkedin, tumblr
2015-03-16 16:44:50 +08:00
Régis Hanol
424a3b042a FEATURE: unified UI for pinning/banner topics
REFACTOR: ES6ified all the modals
2015-03-14 01:18:05 +01:00
Robin Ward
77f9d1e223 Use pretender's passthrough for dynamically loaded scripts 2015-03-13 12:14:22 -04:00
Sam
f359cdeddc remove hacky protocol code, not needed 2015-03-13 20:50:38 +11:00
Sam
4301ce6613 another try at a fix 2015-03-13 20:05:24 +11:00
Sam
a09d471514 Correct CDN url creation for "//" rooted CDNs 2015-03-13 19:31:33 +11:00
Sam
08abb85682 oops 2015-03-13 18:50:34 +11:00
Sam
f6d56fef9e correct behavior 2015-03-13 18:33:47 +11:00
Sam
20ab1f97e4 REGRESSION: not caching async scripts, remove cache buster 2015-03-13 16:55:27 +11:00
Sam
a82530012a FEATURE: Allow selection of highlight js languages
PERF: stop loading highlight js on load

To get latest highlight js run bin/rake highlightjs:update
2015-03-13 16:18:59 +11:00
Robin Ward
893c1aa067 FIX: Quoting an avatar when default_avatars was set was broken. 2015-03-12 15:51:28 -04:00
Robin Ward
3ecb58980f FIX: Allow loadScript to use script tags if the JS library require it. 2015-03-12 13:09:17 -04:00
Robin Ward
69851bc6cf Deprecates global use of Discourse.MessageBus
We can use DI for this, which makes it easier for plugins to subscribe
to the message bus.
2015-03-12 12:27:30 -04:00
Robin Ward
7c9fb5d3fc Refactored SiteMap/Header to support more dynamic flag counts
Also fixes deprecation in `plugin-outlet`
2015-03-11 16:12:53 -04:00
Robin Ward
f50280a889 Split out bulk operations modal and Discourse.Route.showModal
This makes it easier to share bulk topic operations, for example
from a plugin's custom topic list.
2015-03-10 15:40:56 -04:00
Robin Ward
de4e4f2b98 Replace $LAB with path aware loadScript that uses jQuery 2015-03-09 14:39:39 -04:00
Robin Ward
fb726cfa0c Replace Discourse.script global with a module 2015-03-09 14:39:39 -04:00
Sam
f5af4768eb FEATURE: add clean support for running Discourse in a subfolder
To setup set DISCOURSE_RELATIVE_URL_ROOT to the folder you wish
2015-03-09 13:14:29 +11:00
Sam
3e5420da35 correct comments 2015-03-05 15:09:31 +11:00
Sam
5ba5a9f3d6 UX: fix jerky UI when creating new posts
- do not scroll screen if post is already on screen
- do not hide/show suggested topics each time you post
- be less aggressive about setting scrollTop in LockOn
2015-03-05 15:01:17 +11:00
Robin Ward
9974a26c47 FEATURE: Can specify a list of default_avatars urls.
These new avatars will be used by new users until they upload their own
avatars. If left blank, letter avatars are used.
2015-03-03 16:19:29 -05:00
Robin Ward
3d3b70f4bb Remove duplicated NotificationType globals 2015-02-27 10:33:39 -05:00
Kenny Meyer
a89e3d0d14 Fix CORS issue when avatar url is on S3 2015-02-26 18:34:37 -03:00
Régis Hanol
20c9a312c7 FIX: clicks counter on attachments wasn't always working 2015-02-22 20:47:18 +01:00
Arpit Jalan
53b443c8e5 FIX: link insertion dialog should not modify the inserted links 2015-02-20 22:12:23 +05:30
Sam
b041b3f67f FIX: bookmark topic was not working intuitively
- explicitly call out "clear bookmarks"
- correct keyboard shortcuts
- properly remove bookmarks when toggeling
2015-02-19 10:58:57 +11:00
Robin Ward
762e60c0a6 FIX: Back button was wonky at times 2015-02-17 16:21:30 -05:00
Robin Ward
a519fd5bcf FIX: Highlighting was not being applied after some rendering.
Also includes a bunch of ES6 stuff.
2015-02-12 15:37:02 -05:00
Robin Ward
96697c7957 Let's remove the Singleton usage of SiteSettings from Sharing 2015-02-12 13:51:19 -05:00
Robin Ward
1eecd7418e FIX: Return sharing sources in the same order as the site setting 2015-02-12 13:03:32 -05:00
Régis Hanol
db53e022cc FEATURE: prevent upload of more than 10 files at a time 2015-02-11 19:34:48 +01:00
Robin Ward
cf3582bedb FIX: JSHint wasn't validating ES6 files, this fixes a bunch of errors. 2015-02-10 17:21:16 -05:00
Régis Hanol
b809e02c6c FIX: clicking an attachment link works only once 2015-02-09 17:49:59 +01:00
Arpit Jalan
a092944582 FIX: URL encoding was not working for %23 in links 2015-02-03 22:06:49 +05:30
Sam
85d9b2d227 regression, missing local storage would cause script to break 2015-02-03 13:17:03 +11:00
Sam
5ddec2e76d revert lodash upgrade, it is causing severe breakages elsewhere 2015-02-03 11:51:34 +11:00
Régis Hanol
03f7a12b52 UX: use 🌟 icon for recently used emoji tab 2015-02-02 22:28:58 +01:00
Régis Hanol
69f95df297 FEATURE: recently used emoji tab
⬆️ update lodash to V.3.0.1
2015-02-02 21:54:15 +01:00
Sam
1b1ea8e718 FEATURE: 'b' as a keyboard shortcut for bookmarking a topic 2015-01-30 15:11:24 +11:00
Régis Hanol
22adb682d8 revert - FIX: use CDN for user card/profile background and user avatars 2015-01-29 20:42:05 +01:00
Régis Hanol
14dc22f288 FIX: use CDN for user card/profile background and user avatars 2015-01-29 20:15:17 +01:00
Régis Hanol
cd2c9edb46 FIX: 🐛 upload on IE9 wasn't working :'(
- FIX: make sure we set a default name to a pasted image only on Chrome (the only browser that supports it)
- FIX: use ".json" extension to uploads endpoints since IE9 doesn't pass the correct header
- FIX: pass the CSRF token in a query parameter since IE9 doesn't pass it in the headers
- FIX: display error messages comming from the server when there is one over the default error message
- FIX: HACK around IE9 security issue when clicking a file input via JavaScript (use a label and set `visibility:hidden` on the input)
- FIX: hide the "cancel" upload on IE9 since it's not supported
- FIX: return "text/plain" content-type when uploading a file for IE9 in order to prevent it from displaying the save dialog
- FIX: check the maximum file size on the server 💥
- update jQuery File Upload Plugin to v. 5.42.2
- update JQuery IFram Transport Plugin to v. 1.8.5
- update jQuery UI Widget to v. 1.11.1
2015-01-28 19:43:20 +01:00
Régis Hanol
e6f849f873 FIX: make sure pasting an image in the composer is considered as an image instead of an attachment 2015-01-23 19:17:33 +01:00
Robin Ward
649dfd8d23 Revert "Convert html.js to ES6 module format"
This reverts commit 60523d8e02.
2015-01-20 16:13:42 -05:00
Robin Ward
60523d8e02 Convert html.js to ES6 module format 2015-01-20 16:07:29 -05:00
Robin Ward
350554e198 UX: Change category badge style to use stripes 2015-01-20 14:56:06 -05:00
Jeff Atwood
992ad7991b UX: change private category to lock glyph 2015-01-15 14:07:21 -08:00
Régis Hanol
b4e5937850 FIX: 🐛 ensure emoji are case insensitive 2015-01-15 19:00:55 +01:00
Robin Ward
28f702a5b6 Refactor app events to more efficiently handle post highlighting 2015-01-14 15:50:19 -05:00
Robin Ward
78d5d22776 FIX: Posts weren't highlighting when jumping using the progress widget 2015-01-14 15:50:19 -05:00
Robin Ward
8b87d8ac2d Refactor sharing dialog for extensibility 2015-01-13 17:26:05 -05:00
Régis Hanol
c681b353f2 FEATURE: bookmark topic button 2015-01-12 12:10:15 +01:00
Régis Hanol
66882155f0 FIX: emoji toolbar wasn't showing up after a page reload 2015-01-07 10:46:43 +01:00
Sam
da3da6feee each ... in ... support for ember compat handlebars 2015-01-07 18:18:26 +11:00
Sam
efc717c14a FEATURE: remove star concept from Discourse 2015-01-07 13:43:27 +11:00
Sam
29acbfb611 improve probing diag tool, add a clear button 2015-01-05 12:00:55 +11:00
Robin Ward
9523b26af2 Move emoji autocomplete into its own file, remove ceremony around
decorating the `ComposerView` for it since it's part of core now.
2015-01-02 11:57:48 -05:00
Robin Ward
7b9768aa7f FIX: jsHint fail 2014-12-30 13:18:25 -05:00
Robin Ward
2681717a87 FIX: Keep topic list items on screen when using keyboard. 2014-12-30 12:50:58 -05:00
Robin Ward
47d821cd31 FIX: We should only intercept enter as a keypress when a selector
matches it.
2014-12-30 12:05:52 -05:00
Régis Hanol
7bcecb54fd FEATURE: remember last emoji group used 2014-12-29 23:04:37 +01:00
Régis Hanol
432413d3da FEATURE: 🍬 cool transition when expanding lightbox 2014-12-29 18:00:18 +01:00
Régis Hanol
a115b4b7f0 FIX: hide emoji toolbar button when emoji are disabled 2014-12-29 17:29:04 +01:00
Arpit Jalan
bb152a5b3f FEATURE: download user posts archive 2014-12-24 15:13:48 +05:30
Régis Hanol
45dbdb6896 FEATURE: custom emojis 2014-12-23 01:12:26 +01:00
Robin Ward
2d3a9b334d FIX: LazyYT was not being applied when a post was edited 2014-12-18 12:28:14 -05:00
Robin Ward
8b51176f2e FIX: Category badges were missing stripes in some places 2014-12-18 11:03:17 -05:00
Robin Ward
a8acbc37a2 Refactor selector components for extensibility 2014-12-18 10:36:58 -05:00
Robin Ward
3e408f9caa Fix more deprecated helpers 2014-12-17 09:31:41 -05:00
Robin Ward
bdc075b266 Minimize use of stream calls 2014-12-17 09:31:41 -05:00
Sam
51c4cb3de1 fix helper 2014-12-17 09:31:41 -05:00
Sam
f8f1611035 compatibility fixes 2014-12-17 09:31:41 -05:00
Sam
a0787103c1 fix raw helper so its handlebars 2.0 compliant 2014-12-17 09:31:41 -05:00
Robin Ward
02f3a2d115 Fix more deprecations for 1.9.0 2014-12-17 09:31:41 -05:00
Robin Ward
748c13f4a7 Fixes broken test 2014-12-15 13:13:39 -05:00
Robin Ward
a2c97b9e6b FIX: If a user uses the keyboard to navigate, don't bubble up the event. 2014-12-15 12:54:05 -05:00
Sam
555b783864 Add shortcuts support for emoji toolbar
(CTRL E to open, ESC to close)
2014-12-08 13:32:26 +11:00
Sam
357a12f78e FEATURE: work-in-progress emoji selector toolbar item 2014-12-05 17:19:17 +11:00
Robin Ward
5ec77d4be4 FIX: If a category can't be found, don't include it in the list 2014-12-04 13:04:58 -05:00
Régis Hanol
0947191060 UX: improved our footer handling
- new "show-footer" mixins
- converted most of the routes to ES6
- FIX: handling of "indexStream" in user pages

There will now be a footer on all the following pages
- /exception
- /about
- /latest
- /new
- /unread
- /starred
- /top
- /categories
- /c/:category
- /c/:category/l/latest
- /c/:category/l/new
- /c/:category/l/unread
- /c/:category/l/top
- /t/:topic/:id
- /groups/:name/members
- /user/activity
- /user/activity/topics
- /user/activity/posts
- /user/activity/replies
- /user/activity/likes-given
- /user/activity/likes-received
- /user/activity/bookmarks
- /user/activity/starred
- /user/badges
- /user/notifications
- /user/flagged-posts
- /user/deleted-posts
- /user/private-messages
- /user/private-messages/mine
- /user/private-messages/unread
- /user/invited
- /user/:username/preferences
- /faq (static pages)
- /badges
- /badges/:id/:badge
2014-11-19 20:37:43 +01:00
Régis Hanol
672cd92638 FIX: damn timezones 2014-11-17 22:53:41 +01:00
Régis Hanol
216a5a87cb FIX: do not display EPOCH 2014-11-17 16:32:14 +01:00
Marcin Rataj
9dccd975d9 UX: whitelist OpenStreetMap iframes 2014-11-17 14:30:25 +01:00
cpradio
c2bbbb38f0 FIX: Do not recall prior DRAFT in a given category when using the Create Topic keyboard shortcut 2014-11-14 18:12:42 -05:00
cpradio
a4aeaeae30 Fixed typo 2014-11-12 09:41:53 -05:00
cpradio
61cc8ead44 FEATURE: Added Pin/Unpin Keyboard Shortcut 2014-11-12 09:36:24 -05:00
Robin Ward
a6b1be81b1 Upgrade to Ember 1.7.1 + group patch 2014-11-10 14:49:02 -05:00
Robin Ward
e1d26736b2 FIX: Missing tab delegation 2014-11-10 12:04:16 -05:00
Robin Ward
8199c3b440 Don't add the g flag 2014-11-07 12:09:45 -05:00
Robin Ward
0044a99000 Don't raise an error for global regexps; warn the plugin author instead. 2014-11-07 12:04:44 -05:00
Robin Ward
564e7a988c Merge pull request #2848 from riking/whitelist-api
Improve Markdown.whiteListTag, code dialect
2014-11-07 11:33:37 -05:00
Robin Ward
d6ff1630a8 Merge pull request #2898 from kellec/remove_focus_link_href
Remove href attribute from tab link to prevent duplicate event on enter.
2014-11-07 11:01:06 -05:00
Robin Ward
a0e92ef57a FIX: PageTracker was not sending the proper page title through at all
times.
2014-11-05 15:15:58 -05:00
Régis Hanol
bdb78ce76a FEATURE: consider SVG as an image when authorized 2014-11-03 19:54:10 +01:00
Sam
9d43e0ae0c FIX: regression, ESC is not captured correctly 2014-11-01 18:31:16 +11:00
Sam
75ffb0a425 Merge pull request #2912 from cpradio/pr-make-create-topic-global
FIX: Make shortcut 'c' global for creating a topic
2014-10-30 17:23:12 +11:00
Sam
eab12cc6b8 PERF: move excerpt to raw, expose i18n to handlebars 2014-10-29 16:08:35 +11:00
Sam
5729e7df6f PERF: use raw rendering for topic list
rename my handlebars helper to "raw",
create ember compat handlebars to handle rendering
patch ember rails to use the correct precompiler
2014-10-29 15:24:51 +11:00
cpradio
00816269fc Call open directly to avoid deprecation warning 2014-10-24 17:08:10 -04:00
cpradio
e013694734 FIX: Make shortcut 'c' global for creating a topic
https://meta.discourse.org/t/keyboard-shortcut-c-create-a-new-topic-does-not-work-globally/18975
2014-10-24 11:23:03 -04:00
Kelle Connolly
0d461f16a7 Remove href attribute from tab link to prevent duplicate event on enter.
Because Discourse doesn't preventDefault on links with an href of "#"
this tab-able link was firing a click event when enter was pressed. This
had the unfortunate side effect of breaking the history, making routing
and navigation unreliable.
2014-10-22 17:29:57 +11:00
Sam
e20e6b4524 PERF: stop using jQuery to sanitize strings 2014-10-22 15:48:18 +11:00
Sam
bf7ee92d56 Move search help to a more intuative spot 2014-10-18 18:00:54 +11:00
Sam
742c5e29c9 FEATURE: advanced search help 2014-10-18 14:27:33 +11:00
Sam
c2c4e03e0f FIX: when opening links in new window link only worked once 2014-10-15 14:50:20 +11:00
Robin Ward
d2ac5a9ac6 Rename /category/xyz paths to /c/xyz -- @SamSaffron did most of the
work even though I'm merging the patch!
2014-10-16 12:15:31 -04:00
Sam
b4c29a9f3b FIX: regression in autocomplete 2014-10-14 18:22:44 +11:00
Sam
737be5e151 Merge pull request #2871 from mamhoff/autocomplete-again
Fix buggy autocomplete behaviour for non-US keyboards
2014-10-16 17:35:48 +11:00
Martin Meyerhoff
f3337ab551 reduce number of times caretPosition() is called 2014-10-15 08:50:47 +02:00
Régis Hanol
31e9cafe0e FEATURE: use original filename when clicking the download link in the lightbox 2014-10-15 19:20:04 +02:00
Robin Ward
216f718607 Support /group/xyz paths as well as /groups/xyz 2014-10-14 15:11:22 -04:00
Jeff Atwood
1f8e1f8f17 Remove old IE support from WMD, part III 2014-10-12 01:01:40 -07:00
Jeff Atwood
43bcde2060 Remove old IE support froM WMD, part II
native methods that IE8 didn't support but IE9 does
2014-10-12 00:46:08 -07:00
Jeff Atwood
28b9176bbc oh JavaScript, you so crazy 2014-10-12 00:33:13 -07:00
Jeff Atwood
aa29fc3b4a remove old IE support from WMD, part I: uaSniffed 2014-10-12 00:22:14 -07:00
Jeff Atwood
08bdf26e70 Revert "remove old IE support crap from WMD Editor"
This reverts commit 7bbf7d02e3.
2014-10-12 00:14:22 -07:00
Jeff Atwood
7bbf7d02e3 remove old IE support crap from WMD Editor
we barely support IE9 this does not matter at all
2014-10-12 00:05:18 -07:00
Martin Meyerhoff
97b60e6422 Fix buggy autocomplete behaviour for non-US keyboards
This change moves the code for actually entering data from the keydown handler to the
keypress handler, which can reliably catch the character entered (rather than
the key pressed).

This is my second attempt at
https://meta.discourse.org/t/typing-shows-on-non-us-keyboard-layouts/20449
without doing dangerous refactoring.

This does not fix the issue reported in
https://meta.discourse.org/t/overly-aggresive-emoji-autocomplete/20691/7
as that is a different bug.
2014-10-11 17:55:48 +02:00
Régis Hanol
5754e8dd0f FEATURE: auto-close topics based on last post 2014-10-10 18:21:44 +02:00
Robin Ward
d3b268cd2c FIX: Broken build 2014-10-09 19:42:50 -04:00
Robin Ward
285c66b899 FIX: Say the file uploaded is too large, not "image" as you can upload
other kinds of files.
2014-10-09 16:03:04 -04:00
Robin Ward
1cda92c753 Minor documentation change to PageTracker 2014-10-09 15:07:10 -04:00
Robin Ward
5fc150e057 A mucher saner API for updating the title of routes, even when nested.
Properly sends the title of the page to google analytics
2014-10-09 14:55:29 -04:00
Sam
7ef2f48660 FIX: not showing any search results when scoped on user 2014-10-08 13:03:18 +11:00
Sam
168c690427 FIX: handle paste events for auto completed fields 2014-10-08 11:59:46 +11:00
Robin Ward
e20c82436d FIX: Clicking "Latest" while ordering by a column should reset the
order.
2014-10-07 15:19:17 -04:00
Robin Ward
52298faaa0 Revert "Revert "Add striped category badges under title""
This reverts commit 85b6b2550e.
2014-10-06 16:29:13 -04:00
Robin Ward
85b6b2550e Revert "Add striped category badges under title"
This reverts commit 331e63e3af.
2014-10-06 16:13:51 -04:00
Robin Ward
331e63e3af Add striped category badges under title 2014-10-06 15:58:57 -04:00
Kane York
b79c835c07 Fix data-* behavior (failure to understand own docs) 2014-10-05 15:11:26 -07:00
riking
0532468499 Fix JSHint 2014-10-05 14:58:48 -07:00
riking
1436f75a9f FEATURE: Allow explicit rel="nofollow" on links 2014-10-05 14:58:48 -07:00
riking
0586b3dd25 Clean up validateAttribute() function
Remove code duplication
2014-10-05 14:58:47 -07:00
riking
32cc31319f FIX: Use lang- prefixes for HLJS; add nohighlight for ...
text; use a proper whiteListTag() call.

Old posts are not affected - no global rebake is necessary.
2014-10-05 14:58:47 -07:00
riking
22a4ceceee Auto-anchor attribute regexes, document _validTags 2014-10-05 12:17:56 -07:00
Sam
f5912a5500 amend previous fix 2014-10-03 16:35:35 +10:00
Sam
8c214c35e4 FIX: clicking on heading could insert a broken heading 2014-10-03 16:35:02 +10:00
Robin Ward
ad5e4f98d9 Revert "Merge pull request #2833 from mamhoff/new-bugfix-autocomplete"
This reverts commit 2450d284c5, reversing
changes made to 489078bfcf.
2014-10-02 16:00:50 -04:00
Martin Meyerhoff
3fd8fc97a2 BUGFIX: Handle text input in keypress handler for I18n
While the `keydown` handler is the only way of reliably catching special keys,
for textual input `keypress` is preferable, as it can handle thing like parens
without having to hardcode a keyboard.

I moved that code and in the process converted some magic numbers to constants
- mostly so I can read stuff better.
2014-10-01 15:50:09 +02:00
Robin Ward
d1d3e5dd8c Remove broken debouncePromise and clean up some deprecations 2014-09-23 16:16:44 -04:00
Sam
e8bbc147ad Merge pull request #2815 from cpradio/tab-to-first-link-on-post-when-using-keyboard
FIX: j/k place tab focus accordingly so tab will go to the first linked ...
2014-09-23 07:38:49 +10:00
cpradio
caac05dbba FIX: j/k place tab focus accordingly so tab will go to the first linked item in the selected post/row
Allow tabbing to continue from the selected post/topic when using the j/k keyboard shortcuts
https://meta.discourse.org/t/when-a-post-is-selected-tab-should-take-you-to-the-first-link/16212
2014-09-22 15:07:50 -04:00
Sam
cfa0d66548 Merge pull request #2807 from techAPJ/patch-2
UX: show category when moving post to exisiting topic
2014-09-22 11:59:02 +10:00
Sam
aa39a3b4b0 Merge pull request #2810 from cpradio/opera-composer-keyboard-shortucts
FIX: Opera Composer Keyboard Shortcuts
2014-09-22 11:50:14 +10:00
cpradio
9e3060a6f7 FIX: Opera Improvements (v12)
Fix issues with Opera 12 and its ability to utilize Discourse Composer window
https://meta.discourse.org/t/support-for-opera/20218
2014-09-19 22:47:27 -04:00
Arpit Jalan
ae8f7748f8 UX: show category when moving post to exisiting topic 2014-09-19 21:00:35 +05:30
Sam
14936ed9c9 Merge pull request #2795 from lidlanca/fix-link-release
Fix: Cancel link click if triggered as part of text selection
2014-09-19 13:35:13 +10:00
Sam
bf51fbf030 Merge pull request #2806 from Elberet/fix-escape-single-quotes
FIX: double-escaped single quotes in URLs
2014-09-19 13:32:43 +10:00
Sam Saffron
5132f217c4 FIX: link to sub category not working in search 2014-09-19 12:55:30 +10:00
Jens Maier
543bc53598 FIX: double-escaped single quotes in URLs 2014-09-18 22:07:42 +02:00
Sam
0855fe5438 Merge pull request #2798 from lidlanca/patch-3
Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more"
2014-09-17 00:25:12 +10:00
cpradio
eaf0cf0519 FIX: Using k on Firefox to navigate up the topic list
Using k wouldn't always bring the topic in focus as you moved up the topic list
https://meta.discourse.org/t/topic-list-keyboard-shortcut-previous-k-does-not-scroll-properly-leaving-selected-item-hidden-firefox/20050
2014-09-15 21:10:24 -04:00
lidlanca
e277287b2e Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more"
Using Next keyboard shortcut (J) rapidly while reaching last item in the topic list and
causing a "load more". The handler might get into a state where it can not detect any selected item due to the delay from Em.run.next
and will result in position reset.

+added boundary check of last item on next, early in the handler to avoid unnecessary computations 


https://meta.discourse.org/t/keyboard-shortcut-next-previous-continues-key-down-reset-to-first-item-in-list-on-load-more/20042
2014-09-13 23:59:20 -04:00
lidlanca
13cedce0cf Fix: Cancel link click if triggered as part of text selection
Prevent a click if the user select content in a topic and release the mouse over a link.

https://meta.discourse.org/t/selecting-a-link-results-in-it-being-opened/14846
2014-09-13 04:05:03 -04:00
Robin Ward
a09ff29dd9 UX: Only intercept Cmd-F/Ctrl-F for search on a topic when not all posts
are available in the DOM.
2014-09-09 16:05:17 -04:00
Robin Ward
8b33e659a1 FIX: Only use cached topic lists on popState 2014-09-09 12:57:51 -04:00
Régis Hanol
eb34ecfc0c FEATURE: new 'prevent anons from download files' site setting 2014-09-09 18:41:13 +02:00
Robin Ward
8ac955247c Convert category helpers to ES6. 2014-09-04 11:32:30 -04:00
Sam
0ade9bafff FIX: highlight in yellow, not blue
FEATURE: highlight in title
2014-09-04 15:01:13 +10:00
Sam
b8c36bd2da FIX: broken search for admins when selecting topics 2014-09-04 12:21:57 +10:00
Robin Ward
065101afac Merge pull request #2734 from cpradio/readd-dismiss-bindings
FIX: Readd the dismiss keybindings
2014-09-02 10:42:53 -04:00
Sam
202656a679 Merge pull request #2725 from cpradio/german-keyboard-support
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
Sam
69e418facf FEATURE: wider search with more context 2014-09-01 17:04:57 +10:00
cpradio
42c052d21b FIX: Readd the dismiss keybindings
https://meta.discourse.org/t/new-updated-bar-and-dismiss-new-button-unreachable-by-keyboard/18946/10?u=cpradio
2014-08-31 21:56:38 -04:00
cpradio
6234284243 FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings 2014-08-31 21:42:03 -04:00
Sam
5c244c6f8f FIX: autocomplete username failing to pop up
Janky autocomplete behavior due to debounce not being accounted for
correctly when dealing with promises

This also fixes a promise leak
2014-09-01 01:48:17 +10:00
cpradio
37639308c0 FIX: Firefox j/k post navigation is inconsistent
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
2014-08-30 08:59:08 -04:00
cpradio
3f5d530553 Change SHIFT+J and SHIFT+K to move up/down sections instead of posts. 2014-08-30 07:31:38 -04:00
cpradio
89eb03aff0 FIX: Support J/K bindings on German Keyboards
J/K are not supported on German keyboards, shift+j and shift+k have been added to remedy this.
https://meta.discourse.org/t/keyboard-shortcuts-for-next-previous-section-do-not-work-with-german-keyboard-layout/18902
2014-08-29 22:18:03 -04:00
cpradio
d2dea54c88 Merge remote-tracking branch 'cpradio/keyboard-binding-incoming-updated-topics'
Conflicts:
	config/locales/client.en.yml
2014-08-29 19:53:54 -04:00
cpradio
68e807f791 UX: Add keyboard binding for reply as new topic 2014-08-29 19:14:42 -04:00
Neil Lalonde
1291e94c78 Merge pull request #2715 from cpradio/master
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
2014-08-29 17:04:52 -04:00
cpradio
8033972536 UX: Add keyboard bidning for incoming/updated topics
Fixed the selector used to gain access to the clickable div
2014-08-29 10:01:36 -04:00
cpradio
5ca96e741d UX: Add keyboard bidning for incoming/updated topics 2014-08-29 09:44:26 -04:00
cpradio
1acb2a13f1 Added a:first 2014-08-28 16:06:48 -04:00
cpradio
4fd73a2b2f Set focus on site-map and user menu
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 16:04:54 -04:00
Robin Ward
8a6c4234fc FIX: Re-enable searching for topic by id when using the split topic
interface.
2014-08-28 15:42:29 -04:00
Arpit Jalan
3a76f9e79f FIX: allow localization in timestamp 2014-08-27 20:57:06 +05:30
Arpit Jalan
0453da6fa5 FIX: use short date format for timestamp 2014-08-27 12:56:52 +05:30
cpradio
1678a91a60 Add shortcuts for Profile Menu and Hamburger Menu
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-26 20:30:20 -04:00
Sam
f331855482 FIX: username autocomplete more reliable, cancel old reqs 2014-08-26 11:32:50 +10:00
Robin Ward
0fba445bc1 FIX: Broken build 2014-08-25 13:35:40 -04:00
Robin Ward
f10f9585ae Better Support for whitelisting caja tags 2014-08-25 13:11:20 -04:00
Sam
9ecbfad5fa only hijack search on topic page 2014-08-22 08:53:00 +10:00
Robin Ward
65297533fa FIX: Allow links to name attributes 2014-08-19 16:51:53 -04:00
Robin Ward
b175abbfb5 FIX: Admin group search was failing 2014-08-18 14:08:21 -04:00
riking
8539c08d35 Fix assignment of post number to progress position 2014-08-14 17:31:34 -07:00
Robin Ward
dd8e5583d7 ES6: Transition helper 2014-08-12 16:33:53 -04:00
Robin Ward
3930d933ca Revert "CLEANUP: This file no longer seems to be used"
This reverts commit 5c2893c8f9.
2014-08-12 16:23:44 -04:00
Robin Ward
5c2893c8f9 CLEANUP: This file no longer seems to be used 2014-08-12 16:22:06 -04:00
Robin Ward
3b76fd82fd ES6: user-search lib and autocomplete. Cancels many promises rather than
leaving them as pending forever.
2014-08-08 13:10:13 -04:00
Robin Ward
271374a8c6 Remove some Ember.Deferred usage. It's deprecated. 2014-08-07 17:22:00 -04:00
Sam
e227b68f8d FEATURE: make # more useful for keyboard users 2014-07-30 12:16:11 +10:00
Sam
871f2113e4 BUGFIX: don't move selection when nothing is selected 2014-07-30 11:22:41 +10:00
Sam
367d699247 FIX: enter on invite to PM was broken 2014-07-30 08:46:59 +10:00
Régis Hanol
b196de0821 TRIVIAL: use class instead of id for the 'topic-list' 2014-07-29 23:38:36 +02:00
Robin Ward
16dfedef8f ES6: Remove dynamically generated static routes. They were causing lots
of confusion and bugs.
2014-07-29 14:24:16 -04:00
Sam
32cea9d8cc Feature: Show keyboard shortcuts link on desktop hamburger
(only shows up for desktop, hides "mobile view")

If you really need mobile view add ?mobile_view=1 to end of URL (also fixed)
2014-07-28 11:48:56 +10:00
Neil Lalonde
5a33e6f00c Move FAQ, Terms of Service, and Privacy Policy into topics in the Staff category. First post of those topics will be rendered on their respective pages. Site settings and content are not used for these documents anymore. Translations of the default text is moved into the standard YML files. 2014-07-25 14:41:20 -04:00
Sam
1297243759 FIX: stop tracking broken links 2014-07-25 15:34:31 +10:00
Sam
fbbd4999b6 FIX: remove invalid hack, correct whitelist to use value returned from callback 2014-07-25 12:16:00 +10:00
Robin Ward
b88a8d2416 FIX: Clicking navigation pills a second time should refresh the list
you're looking at.
2014-07-24 14:59:53 -04:00
Robin Ward
fa25700400 FIX: Direct links to hash URLS were broken. Regression? 2014-07-24 12:52:43 -04:00
Robin Ward
59c3ca7e7b PLUGIN: New API for decorating a post with jQuery 2014-07-21 11:38:38 -04:00
Robin Ward
da717c55d7 FEATURE: Like button should act like a toggle and stay there once you've
clicked it.
2014-07-18 17:01:27 -04:00
Régis Hanol
c7330ed73f BUGFIX: errors when post-processing 'data images' 2014-07-18 17:54:18 +02:00
Sam
b522f6116f FIX: strip out some more undo/redo stuff 2014-07-18 10:32:55 +10:00
Sam
da26aae41e FIX: somehow button is not set 2014-07-18 10:31:02 +10:00
Sam
de7e6a9545 Feature: allow mods to cut pinned topic excerpts 2014-07-17 21:32:37 +10:00
Sam
91cd4f2d66 SECURITY: improve escaping protection 2014-07-17 16:11:10 +10:00