Commit Graph

33 Commits

Author SHA1 Message Date
cpradio
caac05dbba FIX: j/k place tab focus accordingly so tab will go to the first linked item in the selected post/row
Allow tabbing to continue from the selected post/topic when using the j/k keyboard shortcuts
https://meta.discourse.org/t/when-a-post-is-selected-tab-should-take-you-to-the-first-link/16212
2014-09-22 15:07:50 -04:00
Sam
0855fe5438 Merge pull request #2798 from lidlanca/patch-3
Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more"
2014-09-17 00:25:12 +10:00
cpradio
eaf0cf0519 FIX: Using k on Firefox to navigate up the topic list
Using k wouldn't always bring the topic in focus as you moved up the topic list
https://meta.discourse.org/t/topic-list-keyboard-shortcut-previous-k-does-not-scroll-properly-leaving-selected-item-hidden-firefox/20050
2014-09-15 21:10:24 -04:00
lidlanca
e277287b2e Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more"
Using Next keyboard shortcut (J) rapidly while reaching last item in the topic list and
causing a "load more". The handler might get into a state where it can not detect any selected item due to the delay from Em.run.next
and will result in position reset.

+added boundary check of last item on next, early in the handler to avoid unnecessary computations 


https://meta.discourse.org/t/keyboard-shortcut-next-previous-continues-key-down-reset-to-first-item-in-list-on-load-more/20042
2014-09-13 23:59:20 -04:00
Robin Ward
a09ff29dd9 UX: Only intercept Cmd-F/Ctrl-F for search on a topic when not all posts
are available in the DOM.
2014-09-09 16:05:17 -04:00
Robin Ward
065101afac Merge pull request #2734 from cpradio/readd-dismiss-bindings
FIX: Readd the dismiss keybindings
2014-09-02 10:42:53 -04:00
Sam
202656a679 Merge pull request #2725 from cpradio/german-keyboard-support
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
cpradio
42c052d21b FIX: Readd the dismiss keybindings
https://meta.discourse.org/t/new-updated-bar-and-dismiss-new-button-unreachable-by-keyboard/18946/10?u=cpradio
2014-08-31 21:56:38 -04:00
cpradio
6234284243 FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings 2014-08-31 21:42:03 -04:00
cpradio
37639308c0 FIX: Firefox j/k post navigation is inconsistent
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
2014-08-30 08:59:08 -04:00
cpradio
3f5d530553 Change SHIFT+J and SHIFT+K to move up/down sections instead of posts. 2014-08-30 07:31:38 -04:00
cpradio
89eb03aff0 FIX: Support J/K bindings on German Keyboards
J/K are not supported on German keyboards, shift+j and shift+k have been added to remedy this.
https://meta.discourse.org/t/keyboard-shortcuts-for-next-previous-section-do-not-work-with-german-keyboard-layout/18902
2014-08-29 22:18:03 -04:00
cpradio
d2dea54c88 Merge remote-tracking branch 'cpradio/keyboard-binding-incoming-updated-topics'
Conflicts:
	config/locales/client.en.yml
2014-08-29 19:53:54 -04:00
cpradio
68e807f791 UX: Add keyboard binding for reply as new topic 2014-08-29 19:14:42 -04:00
cpradio
8033972536 UX: Add keyboard bidning for incoming/updated topics
Fixed the selector used to gain access to the clickable div
2014-08-29 10:01:36 -04:00
cpradio
5ca96e741d UX: Add keyboard bidning for incoming/updated topics 2014-08-29 09:44:26 -04:00
cpradio
1acb2a13f1 Added a:first 2014-08-28 16:06:48 -04:00
cpradio
4fd73a2b2f Set focus on site-map and user menu
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 16:04:54 -04:00
cpradio
1678a91a60 Add shortcuts for Profile Menu and Hamburger Menu
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-26 20:30:20 -04:00
Sam
9ecbfad5fa only hijack search on topic page 2014-08-22 08:53:00 +10:00
Sam
e227b68f8d FEATURE: make # more useful for keyboard users 2014-07-30 12:16:11 +10:00
Sam
871f2113e4 BUGFIX: don't move selection when nothing is selected 2014-07-30 11:22:41 +10:00
Régis Hanol
b196de0821 TRIVIAL: use class instead of id for the 'topic-list' 2014-07-29 23:38:36 +02:00
Robin Ward
da717c55d7 FEATURE: Like button should act like a toggle and stay there once you've
clicked it.
2014-07-18 17:01:27 -04:00
Sam
8e31fe4835 FIX: select context when search triggered via CTRL-F 2014-07-08 12:40:51 +10:00
Robin Ward
f62b05c985 FIX: Apply category class when inside a topic of that category 2014-07-01 16:06:48 -04:00
Robin Ward
cf165320e2 Keyboard shortcuts for new progress expansion 2014-06-13 14:03:12 -04:00
Robin Ward
d37195796f FEATURE: New expandable progress bar with jump buttons and jump to
arbitrary post.
2014-06-12 16:52:33 -04:00
Robin Ward
176120cbc1 REFACTOR: Keyboard Shortcuts should send their actions directly to
posts, not by activating clicks on buttons.
2014-06-11 14:31:03 -04:00
Sam
cbb2cc3911 BUGFIX: fix ~ and ` navigation
Was completely broken.
2014-06-10 16:10:19 +10:00
Sam
66b6d6c4dd BUGFIX: limit hijacking of search for places that have infinite lists of stuff. 2014-06-05 10:23:42 +10:00
Sam
0625465e4a FEATURE: CTRL+F is useless, use our search instead 2014-06-02 11:21:00 +10:00
Robin Ward
1af2ff6201 ES6: More components moved over. 2014-05-30 12:28:05 -04:00