Commit Graph

648 Commits

Author SHA1 Message Date
Robin Ward
c16b8364ab FIX: Support ember app routing to topics with only slugs 2014-09-17 11:18:59 -04:00
Neil Lalonde
9b5f506339 FIX: in activity stream, move category badge to be under topic title. Long titles could cause it to be cut off. Category badge replaces the text that was there. 2014-09-11 17:26:09 -04:00
Robin Ward
af6936cf72 Refactor some deprecations for newer versions of Ember. Also set up
injection for some globals so we can migrate away from them.
2014-09-11 16:16:21 -04:00
Robin Ward
57e3865d18 FIX: Scroll position when using the back button 2014-09-11 13:06:01 -04:00
Régis Hanol
e56fcf0c43 FEATURE: add 'rebake post' in post wrench menu 2014-09-11 16:04:40 +02:00
Sam
306d31b92e fix test 2014-09-11 11:15:49 +10:00
Sam
5cb7c8ee11 FEATURE: suppress admin glyph for admins
If you want to a shield you must grant moderation to the admin.
2014-09-11 10:54:25 +10:00
Sam
70eb7b8fdf FEATURE: All on user page is now only should posts + topics 2014-09-11 10:45:59 +10:00
Régis Hanol
18f8038015 FEATURE: add new 'convert to staff message' in post wrench menu 2014-09-10 23:08:33 +02:00
Robin Ward
5dea3720a4 FIX: Only use cached list when we have less than 1 page worth of topics.
We only need it then to maintain the scroll position.
2014-09-10 15:17:51 -04:00
Sam
b9c8ae588a minor refactor 2014-09-10 16:33:39 +10:00
riking
5994b630b7 Final dirty diff cleanup 2014-09-09 16:29:08 -07:00
riking
69bc552054 FEATURE: Actually show more notifications
The "Show more notifications..." link in the notifications dropdown now
links to /my/notifications, which is a historical view of all
notifications you have recieved.

Notification history is loaded in blocks of 60 at a time.

Admins can see others' notification history. (This was requested for
'debugging purposes', though that's what impersonation is for, IMO.)
2014-09-09 16:29:08 -07:00
Robin Ward
8b33e659a1 FIX: Only use cached topic lists on popState 2014-09-09 12:57:51 -04:00
Robin Ward
a96ba8ed78 Revert "FIX: unread/new counts out of sync with tabs"
This reverts commit c093187d34.
2014-09-09 12:57:51 -04:00
Sam
c093187d34 FIX: unread/new counts out of sync with tabs
We were serving cached lists of topics to non popstate reqs
2014-09-09 16:56:20 +10:00
Régis Hanol
948e0740c9 FEATURE: add glyphs in the composer 'save' button 2014-09-08 19:02:53 +02:00
Robin Ward
334e21a03a Revert "Revert "FEATURE: Can create warnings for users via PM""
This reverts commit 1c7559380c.
2014-09-08 11:11:56 -04:00
Robin Ward
1c7559380c Revert "FEATURE: Can create warnings for users via PM"
This reverts commit b0bfc1f93f.
2014-09-08 10:38:59 -04:00
Robin Ward
b0bfc1f93f FEATURE: Can create warnings for users via PM 2014-09-08 10:27:06 -04:00
Jeff Atwood
bbbca820d8 FIX: edit history user setting was appearing 2014-09-04 13:47:05 -07:00
Jeff Atwood
fad0394a40 more renaming of trust level settings 2014-09-04 13:32:00 -07:00
Robin Ward
229566fc32 Remove deprecated Ember.Set 2014-09-04 15:01:12 -04:00
Robin Ward
b04a52676e FIX: Don't show wrong flag choices after undo 2014-09-02 17:37:54 -04:00
Robin Ward
abd84cd2a1 FIX: Redirect to Top was showing "latest" content because it was in the
preload store.
2014-09-02 12:29:22 -04:00
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Robin Ward
6dcde9ccc3 FIX: Navigating to None was not working 2014-08-29 15:51:28 -04:00
Robin Ward
926e45d030 SECURITY: User action route was returning too much data 2014-08-29 13:46:50 -04:00
Robin Ward
16c9f073b5 FIX: Back button breaks translation of incoming stuff 2014-08-29 12:53:06 -04:00
Robin Ward
69cb5bc425 FIX: Centralize Top rendering, remove old code paths. Fix some bugs. 2014-08-28 14:34:31 -04:00
Robin Ward
30b102aa98 FIX: Show uncategorized with badge/description in the category chooser 2014-08-28 12:42:31 -04:00
Robin Ward
fc71662a13 FIX: Don't show topics as unread when hitting back 2014-08-27 18:01:02 -04:00
Neil Lalonde
940c0d5dbb FIX: topicCountStats was depending on the wrong properties 2014-08-27 15:58:32 -04:00
Robin Ward
f05d2ed7cf PERF: Do far fewer checks and use a lot less memory when loading more 2014-08-27 15:31:06 -04:00
Robin Ward
b1c0a3d01c FIX: Retain back button scroll position even if we don't load more. 2014-08-27 13:33:52 -04:00
Jeff Atwood
553e0290a6 mods can use shield glyph as well, don't need two 2014-08-25 23:49:39 -07:00
Sam
c412d74369 HACK: suppress "1 reply" when directly below for quotes posts 2014-08-26 12:00:16 +10:00
riking
99c11e2184 Sort the badges on the user profile page
Also clean up UserBadgesController so it isn't doing two things in one
method
2014-08-25 12:40:51 -07:00
Jeff Atwood
bd66c67398 whoops, used font awesome 3.2 styles :( 2014-08-24 22:20:59 -07:00
Jeff Atwood
01853fb9d3 replace trophy with shield to indicate admin 2014-08-24 22:05:11 -07:00
Robin Ward
c1aa2458f8 UX: Add drop down for top lists, big refactor of repeated code. 2014-08-21 16:08:47 -04:00
Robin Ward
506dca6d4e FIX: Moving posts was not updating reply_count and
`reply_to_post_number` so reply linkage was broken.
2014-08-20 14:15:23 -04:00
Sam
2d16255185 FIX: make filter bindable 2014-08-19 16:50:30 +10:00
Robin Ward
f1486c7728 FIX: Inconsistency between unread counter and unread filter 2014-08-18 16:15:26 -04:00
Robin Ward
db4abe76db CLEANUP: Remove dead resetRead code path 2014-08-18 14:35:33 -04:00
Robin Ward
05193deb4d Merge pull request #2659 from riking/wrong-progress-pos
Hopefully fix once and for all the 172/160 problem
2014-08-18 11:30:09 -04:00
Neil Lalonde
6c10cc3788 FIX: top_menu with category links like category/Meta are not case sensitive 2014-08-18 11:07:49 -04:00
Robin Ward
f7b0c31418 Post history heatmap should use site settings for thresholds 2014-08-15 12:22:06 -04:00
Robin Ward
eb5a3da10d UX: Include tooltip text when hovering over posts column 2014-08-15 11:49:30 -04:00
Robin Ward
8f51878d73 FIX: Remove seen flag status from viewed topics 2014-08-15 10:46:58 -04:00