Jarek Radosz
21e8a33177
DEV: Clean up QUnit tests ( #13328 )
...
* DEV: Use `query` helper instead of `queryAll()[0]`
* DEV: Replace `queryAll().length` w/ `exists()`/`count()`
* DEV: Use `exists()` instead of `count() > 0`, `count() === 0`
* DEV: Use `count()`/`exists()` instead of `find().length`
2021-06-08 17:54:12 +02:00
Robin Ward
f113648107
DEV: Migrate more tests to our Ember CLI format. ( #11899 )
...
This should be fully backwards compatible.
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
2021-02-01 09:01:47 -05:00
Joffrey JAFFEUX
c6a1042950
DEV: prettier 2.2.1 ( #11862 )
2021-01-27 12:39:20 +01:00
Roman Rizzi
6d30e01d1c
A11Y: Structure user menu as tabs. ( #11789 )
...
* A11Y: Structure user menu as tabs.
Although the user menu content has the appearance of tabs and relies on the functionality of tabs to make sense in terms of content and focus order, it is not marked up correctly as tabs and tab panels. See [WAI-ARIA Authoring Practices 1.1](https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel ) and the [example](https://www.w3.org/TR/wai-aria-practices-1.1/examples/tabs/tabs-2/tabs.html ) for details.
* Make plugin api backwards compatible
2021-01-22 19:05:14 -03:00
Roman Rizzi
48f06e56f2
A11Y: Improve the quick access menu accessibility. ( #11757 )
...
- The icon for the “view all” controls in the panels have no accessible alternative.
- Because the “Log Out” and "Do Not Disturb" elements in the preferences tab are an <a> element without an href attribute, it is not keyboard focusable and therefore not keyboard focusable. Use a button element instead.
2021-01-20 14:50:36 -03:00
Roman Rizzi
bbe5d8d5cf
DEV: Sort imports alphabetically ( #11382 )
2020-12-01 15:31:26 -03:00
Jarek Radosz
dbcf722ab9
DEV: Modulize component tests ( #11300 )
...
It's like the new tests, but still old underneath!
2020-11-20 15:54:09 +01:00
Robin Ward
435a9913a4
REFACTOR: Replace global find with queryAll
...
In newer Embers jQuery is removed. There is a `find` but it only returns
one element and not a jQuery selector. This patch migrates our code to a
new helper `queryAll` which allows us to remove the global.
2020-10-29 14:45:51 -04:00
Robin Ward
e634513568
Move click and fillIn to imports
...
Previously they were global functions.
2020-10-27 08:55:56 -04:00
Robin Ward
1e4c0d1857
Remove more global variables from tests.
...
* Use `sinon` instead of `sandbox` and require an import.
* You need to import `currentURL` to use it.
2020-10-26 13:32:11 -04:00
Robin Ward
23f24bfb51
REFACTOR: Move javascript tests inside discourse app
...
This is where they should be as far as ember is concerned. Note this is
a huge commit and we should be really careful everything continues to
work properly.
2020-10-02 11:29:36 -04:00
