osr-plastic/osr-discourse-src
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
12,675 Commits 130 Branches 462 Tags 739 MiB
e3b4d12e46
Commit Graph

336 Commits

Author SHA1 Message Date
Sam
75ffb0a425 Merge pull request #2912 from cpradio/pr-make-create-topic-global 
FIX: Make shortcut 'c' global for creating a topic
 2014-10-30 17:23:12 +11:00
Sam
eab12cc6b8 PERF: move excerpt to raw, expose i18n to handlebars 2014-10-29 16:08:35 +11:00
Sam
5729e7df6f PERF: use raw rendering for topic list 
rename my handlebars helper to "raw",
create ember compat handlebars to handle rendering
patch ember rails to use the correct precompiler
 2014-10-29 15:24:51 +11:00
cpradio
00816269fc Call open directly to avoid deprecation warning 2014-10-24 17:08:10 -04:00
cpradio
e013694734 FIX: Make shortcut 'c' global for creating a topic 
https://meta.discourse.org/t/keyboard-shortcut-c-create-a-new-topic-does-not-work-globally/18975
 2014-10-24 11:23:03 -04:00
Kelle Connolly
0d461f16a7 Remove href attribute from tab link to prevent duplicate event on enter. 
Because Discourse doesn't preventDefault on links with an href of "#"
this tab-able link was firing a click event when enter was pressed. This
had the unfortunate side effect of breaking the history, making routing
and navigation unreliable.
 2014-10-22 17:29:57 +11:00
Sam
e20e6b4524 PERF: stop using jQuery to sanitize strings 2014-10-22 15:48:18 +11:00
Sam
bf7ee92d56 Move search help to a more intuative spot 2014-10-18 18:00:54 +11:00
Sam
742c5e29c9 FEATURE: advanced search help 2014-10-18 14:27:33 +11:00
Sam
c2c4e03e0f FIX: when opening links in new window link only worked once 2014-10-15 14:50:20 +11:00
Robin Ward
d2ac5a9ac6 Rename /category/xyz paths to /c/xyz -- @SamSaffron did most of the 
work even though I'm merging the patch!
 2014-10-16 12:15:31 -04:00
Sam
b4c29a9f3b FIX: regression in autocomplete 2014-10-14 18:22:44 +11:00
Sam
737be5e151 Merge pull request #2871 from mamhoff/autocomplete-again 
Fix buggy autocomplete behaviour for non-US keyboards
 2014-10-16 17:35:48 +11:00
Martin Meyerhoff
f3337ab551 reduce number of times caretPosition() is called 2014-10-15 08:50:47 +02:00
Régis Hanol
31e9cafe0e FEATURE: use original filename when clicking the download link in the lightbox 2014-10-15 19:20:04 +02:00
Robin Ward
216f718607 Support /group/xyz paths as well as /groups/xyz 2014-10-14 15:11:22 -04:00
Jeff Atwood
1f8e1f8f17 Remove old IE support from WMD, part III 2014-10-12 01:01:40 -07:00
Jeff Atwood
43bcde2060 Remove old IE support froM WMD, part II 
native methods that IE8 didn't support but IE9 does
 2014-10-12 00:46:08 -07:00
Jeff Atwood
28b9176bbc oh JavaScript, you so crazy 2014-10-12 00:33:13 -07:00
Jeff Atwood
aa29fc3b4a remove old IE support from WMD, part I: uaSniffed 2014-10-12 00:22:14 -07:00
Jeff Atwood
08bdf26e70 Revert "remove old IE support crap from WMD Editor" 
This reverts commit 7bbf7d02e3.
 2014-10-12 00:14:22 -07:00
Jeff Atwood
7bbf7d02e3 remove old IE support crap from WMD Editor 
we barely support IE9 this does not matter at all
 2014-10-12 00:05:18 -07:00
Martin Meyerhoff
97b60e6422 Fix buggy autocomplete behaviour for non-US keyboards 
This change moves the code for actually entering data from the keydown handler to the
keypress handler, which can reliably catch the character entered (rather than
the key pressed).

This is my second attempt at
https://meta.discourse.org/t/typing-shows-on-non-us-keyboard-layouts/20449
without doing dangerous refactoring.

This does not fix the issue reported in
https://meta.discourse.org/t/overly-aggresive-emoji-autocomplete/20691/7
as that is a different bug.
 2014-10-11 17:55:48 +02:00
Régis Hanol
5754e8dd0f FEATURE: auto-close topics based on last post 2014-10-10 18:21:44 +02:00
Robin Ward
d3b268cd2c FIX: Broken build 2014-10-09 19:42:50 -04:00
Robin Ward
285c66b899 FIX: Say the file uploaded is too large, not "image" as you can upload 
other kinds of files.
 2014-10-09 16:03:04 -04:00
Robin Ward
1cda92c753 Minor documentation change to PageTracker 2014-10-09 15:07:10 -04:00
Robin Ward
5fc150e057 A mucher saner API for updating the title of routes, even when nested. 
Properly sends the title of the page to google analytics
 2014-10-09 14:55:29 -04:00
Sam
7ef2f48660 FIX: not showing any search results when scoped on user 2014-10-08 13:03:18 +11:00
Sam
168c690427 FIX: handle paste events for auto completed fields 2014-10-08 11:59:46 +11:00
Robin Ward
e20c82436d FIX: Clicking "Latest" while ordering by a column should reset the 
order.
 2014-10-07 15:19:17 -04:00
Robin Ward
52298faaa0 Revert "Revert "Add striped category badges under title"" 
This reverts commit 85b6b2550e.
 2014-10-06 16:29:13 -04:00
Robin Ward
85b6b2550e Revert "Add striped category badges under title" 
This reverts commit 331e63e3af.
 2014-10-06 16:13:51 -04:00
Robin Ward
331e63e3af Add striped category badges under title 2014-10-06 15:58:57 -04:00
Kane York
b79c835c07 Fix data-* behavior (failure to understand own docs) 2014-10-05 15:11:26 -07:00
riking
0532468499 Fix JSHint 2014-10-05 14:58:48 -07:00
riking
1436f75a9f FEATURE: Allow explicit rel="nofollow" on links 2014-10-05 14:58:48 -07:00
riking
0586b3dd25 Clean up validateAttribute() function 
Remove code duplication
 2014-10-05 14:58:47 -07:00
riking
32cc31319f FIX: Use lang- prefixes for HLJS; add nohighlight for ... 
text; use a proper whiteListTag() call.

Old posts are not affected - no global rebake is necessary.
 2014-10-05 14:58:47 -07:00
riking
22a4ceceee Auto-anchor attribute regexes, document _validTags 2014-10-05 12:17:56 -07:00
Sam
f5912a5500 amend previous fix 2014-10-03 16:35:35 +10:00
Sam
8c214c35e4 FIX: clicking on heading could insert a broken heading 2014-10-03 16:35:02 +10:00
Robin Ward
ad5e4f98d9 Revert "Merge pull request #2833 from mamhoff/new-bugfix-autocomplete" 
This reverts commit 2450d284c5, reversing
changes made to 489078bfcf.
 2014-10-02 16:00:50 -04:00
Martin Meyerhoff
3fd8fc97a2 BUGFIX: Handle text input in keypress handler for I18n 
While the `keydown` handler is the only way of reliably catching special keys,
for textual input `keypress` is preferable, as it can handle thing like parens
without having to hardcode a keyboard.

I moved that code and in the process converted some magic numbers to constants
- mostly so I can read stuff better.
 2014-10-01 15:50:09 +02:00
Robin Ward
d1d3e5dd8c Remove broken debouncePromise and clean up some deprecations 2014-09-23 16:16:44 -04:00
Sam
e8bbc147ad Merge pull request #2815 from cpradio/tab-to-first-link-on-post-when-using-keyboard 
FIX: j/k place tab focus accordingly so tab will go to the first linked ...
 2014-09-23 07:38:49 +10:00
cpradio
caac05dbba FIX: j/k place tab focus accordingly so tab will go to the first linked item in the selected post/row 
Allow tabbing to continue from the selected post/topic when using the j/k keyboard shortcuts
https://meta.discourse.org/t/when-a-post-is-selected-tab-should-take-you-to-the-first-link/16212
 2014-09-22 15:07:50 -04:00
Sam
cfa0d66548 Merge pull request #2807 from techAPJ/patch-2 
UX: show category when moving post to exisiting topic
 2014-09-22 11:59:02 +10:00
Sam
aa39a3b4b0 Merge pull request #2810 from cpradio/opera-composer-keyboard-shortucts 
FIX: Opera Composer Keyboard Shortcuts
 2014-09-22 11:50:14 +10:00
cpradio
9e3060a6f7 FIX: Opera Improvements (v12) 
Fix issues with Opera 12 and its ability to utilize Discourse Composer window
https://meta.discourse.org/t/support-for-opera/20218
 2014-09-19 22:47:27 -04:00
Arpit Jalan
ae8f7748f8 UX: show category when moving post to exisiting topic 2014-09-19 21:00:35 +05:30
Sam
14936ed9c9 Merge pull request #2795 from lidlanca/fix-link-release 
Fix: Cancel link click if triggered as part of text selection
 2014-09-19 13:35:13 +10:00
Sam
bf51fbf030 Merge pull request #2806 from Elberet/fix-escape-single-quotes 
FIX: double-escaped single quotes in URLs
 2014-09-19 13:32:43 +10:00
Sam Saffron
5132f217c4 FIX: link to sub category not working in search 2014-09-19 12:55:30 +10:00
Jens Maier
543bc53598 FIX: double-escaped single quotes in URLs 2014-09-18 22:07:42 +02:00
Sam
0855fe5438 Merge pull request #2798 from lidlanca/patch-3 
Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more"
 2014-09-17 00:25:12 +10:00
cpradio
eaf0cf0519 FIX: Using k on Firefox to navigate up the topic list 
Using k wouldn't always bring the topic in focus as you moved up the topic list
https://meta.discourse.org/t/topic-list-keyboard-shortcut-previous-k-does-not-scroll-properly-leaving-selected-item-hidden-firefox/20050
 2014-09-15 21:10:24 -04:00
lidlanca
e277287b2e Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more" 
Using Next keyboard shortcut (J) rapidly while reaching last item in the topic list and
causing a "load more". The handler might get into a state where it can not detect any selected item due to the delay from Em.run.next
and will result in position reset.

+added boundary check of last item on next, early in the handler to avoid unnecessary computations 


https://meta.discourse.org/t/keyboard-shortcut-next-previous-continues-key-down-reset-to-first-item-in-list-on-load-more/20042
 2014-09-13 23:59:20 -04:00
lidlanca
13cedce0cf Fix: Cancel link click if triggered as part of text selection 
Prevent a click if the user select content in a topic and release the mouse over a link.

https://meta.discourse.org/t/selecting-a-link-results-in-it-being-opened/14846
 2014-09-13 04:05:03 -04:00
Robin Ward
a09ff29dd9 UX: Only intercept Cmd-F/Ctrl-F for search on a topic when not all posts 
are available in the DOM.
 2014-09-09 16:05:17 -04:00
Robin Ward
8b33e659a1 FIX: Only use cached topic lists on popState 2014-09-09 12:57:51 -04:00
Régis Hanol
eb34ecfc0c FEATURE: new 'prevent anons from download files' site setting 2014-09-09 18:41:13 +02:00
Robin Ward
8ac955247c Convert category helpers to ES6. 2014-09-04 11:32:30 -04:00
Sam
0ade9bafff FIX: highlight in yellow, not blue 
FEATURE: highlight in title
 2014-09-04 15:01:13 +10:00
Sam
b8c36bd2da FIX: broken search for admins when selecting topics 2014-09-04 12:21:57 +10:00
Robin Ward
065101afac Merge pull request #2734 from cpradio/readd-dismiss-bindings 
FIX: Readd the dismiss keybindings
 2014-09-02 10:42:53 -04:00
Sam
202656a679 Merge pull request #2725 from cpradio/german-keyboard-support 
FIX: Support J/K bindings on German Keyboards
 2014-09-02 08:02:10 +10:00
Sam
69e418facf FEATURE: wider search with more context 2014-09-01 17:04:57 +10:00
cpradio
42c052d21b FIX: Readd the dismiss keybindings 
https://meta.discourse.org/t/new-updated-bar-and-dismiss-new-button-unreachable-by-keyboard/18946/10?u=cpradio
 2014-08-31 21:56:38 -04:00
cpradio
6234284243 FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings 2014-08-31 21:42:03 -04:00
Sam
5c244c6f8f FIX: autocomplete username failing to pop up 
Janky autocomplete behavior due to debounce not being accounted for
correctly when dealing with promises

This also fixes a promise leak
 2014-09-01 01:48:17 +10:00
cpradio
37639308c0 FIX: Firefox j/k post navigation is inconsistent 
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
 2014-08-30 08:59:08 -04:00
cpradio
3f5d530553 Change SHIFT+J and SHIFT+K to move up/down sections instead of posts. 2014-08-30 07:31:38 -04:00
cpradio
89eb03aff0 FIX: Support J/K bindings on German Keyboards 
J/K are not supported on German keyboards, shift+j and shift+k have been added to remedy this.
https://meta.discourse.org/t/keyboard-shortcuts-for-next-previous-section-do-not-work-with-german-keyboard-layout/18902
 2014-08-29 22:18:03 -04:00
cpradio
d2dea54c88 Merge remote-tracking branch 'cpradio/keyboard-binding-incoming-updated-topics' 
Conflicts:
	config/locales/client.en.yml
 2014-08-29 19:53:54 -04:00
cpradio
68e807f791 UX: Add keyboard binding for reply as new topic 2014-08-29 19:14:42 -04:00
Neil Lalonde
1291e94c78 Merge pull request #2715 from cpradio/master 
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
 2014-08-29 17:04:52 -04:00
cpradio
8033972536 UX: Add keyboard bidning for incoming/updated topics 
Fixed the selector used to gain access to the clickable div
 2014-08-29 10:01:36 -04:00
cpradio
5ca96e741d UX: Add keyboard bidning for incoming/updated topics 2014-08-29 09:44:26 -04:00
cpradio
1acb2a13f1 Added a:first 2014-08-28 16:06:48 -04:00
cpradio
4fd73a2b2f Set focus on site-map and user menu 
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
 2014-08-28 16:04:54 -04:00
Robin Ward
8a6c4234fc FIX: Re-enable searching for topic by id when using the split topic 
interface.
 2014-08-28 15:42:29 -04:00
Arpit Jalan
3a76f9e79f FIX: allow localization in timestamp 2014-08-27 20:57:06 +05:30
Arpit Jalan
0453da6fa5 FIX: use short date format for timestamp 2014-08-27 12:56:52 +05:30
cpradio
1678a91a60 Add shortcuts for Profile Menu and Hamburger Menu 
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
 2014-08-26 20:30:20 -04:00
Sam
f331855482 FIX: username autocomplete more reliable, cancel old reqs 2014-08-26 11:32:50 +10:00
Robin Ward
0fba445bc1 FIX: Broken build 2014-08-25 13:35:40 -04:00
Robin Ward
f10f9585ae Better Support for whitelisting caja tags 2014-08-25 13:11:20 -04:00
Sam
9ecbfad5fa only hijack search on topic page 2014-08-22 08:53:00 +10:00
Robin Ward
65297533fa FIX: Allow links to name attributes 2014-08-19 16:51:53 -04:00
Robin Ward
b175abbfb5 FIX: Admin group search was failing 2014-08-18 14:08:21 -04:00
riking
8539c08d35 Fix assignment of post number to progress position 2014-08-14 17:31:34 -07:00
Robin Ward
dd8e5583d7 ES6: Transition helper 2014-08-12 16:33:53 -04:00
Robin Ward
3930d933ca Revert "CLEANUP: This file no longer seems to be used" 
This reverts commit 5c2893c8f9.
 2014-08-12 16:23:44 -04:00
Robin Ward
5c2893c8f9 CLEANUP: This file no longer seems to be used 2014-08-12 16:22:06 -04:00
Robin Ward
3b76fd82fd ES6: user-search lib and autocomplete. Cancels many promises rather than 
leaving them as pending forever.
 2014-08-08 13:10:13 -04:00
Robin Ward
271374a8c6 Remove some Ember.Deferred usage. It's deprecated. 2014-08-07 17:22:00 -04:00
Sam
e227b68f8d FEATURE: make # more useful for keyboard users 2014-07-30 12:16:11 +10:00
Sam
871f2113e4 BUGFIX: don't move selection when nothing is selected 2014-07-30 11:22:41 +10:00
Sam
367d699247 FIX: enter on invite to PM was broken 2014-07-30 08:46:59 +10:00