6308 Commits

Author	SHA1	Message	Date
Gerhard Schlager	eeedc3901e	FIX: Replying to deleted post via email should create new reply to topic	2018-09-03 23:06:40 +02:00
Vinoth Kannan	24a14af15a	FIX: Respect invalidate_oneboxes option for inline oneboxes	2018-09-03 22:33:43 +05:30
Gerhard Schlager	f33433bf9e	Validation of params should restrict to max int (#6331) ... * FIX: Validation of params should restrict to max int * FIX: Send status 400 when "page" param isn't between 1 and max int	2018-09-03 14:45:32 +10:00
Guo Xiang Tan	747c9bb47f	Merge pull request #6317 from nbianca/ignore_blacklisted_domains ... FIX: Ignore OneBox blacklisted domains.	2018-09-03 11:10:52 +08:00
Guo Xiang Tan	45f092a49d	Extract badge_posts view management logic into a service object. ... * Avoid defininig a global constant and method. Fixes https://github.com/discourse/discourse/pull/6318	2018-09-03 09:51:35 +08:00
Maja Komel	182d9a4666	FIX: escape regex chars when searching site texts	2018-09-02 17:25:57 +10:00
Osama Sayegh	60eff9421a	FIX: precompile desktop_theme and mobile_theme stylesheets ... required for environments that pre stage docker images and keep old image running during the deploy	2018-08-31 21:23:55 +10:00
Sam	9b7cab589a	FIX: revert diacritic stripping ... See more details in test case and at: https://meta.discourse.org/t/discourse-should-ignore-if-a-character-is-accented-when-doing-a-search/90198/16?u=sam	2018-08-31 11:46:55 +10:00
Vinoth Kannan	297e8aaf2e	FIX: Escape regex pattern variable before using it	2018-08-31 03:02:24 +05:30
Neil Lalonde	4b6381367e	add support for Excon connection options in hub requests	2018-08-30 15:57:11 -04:00
Neil Lalonde	415201e1b4	Version bump to v2.1.0.beta6	2018-08-30 10:53:20 -04:00
Joffrey JAFFEUX	2dfb097dd9	DEV: plugin generator support for spec/test/controller/routes (#6344)	2018-08-30 16:38:25 +02:00
Joffrey JAFFEUX	90e67b671b	DEV: support for settings/locales in plugin generator (#6341)	2018-08-30 14:12:06 +02:00
Osama Sayegh	9efbf2c49f	FIX: changing component settings should trigger refresh for parent theme CSS (#6340)	2018-08-30 20:53:03 +10:00
Joffrey JAFFEUX	d40d241e72	DEV: adds --help --no-help options to plugin generator (#6338) ... help will add helpful comments in the various generated files	2018-08-30 12:16:37 +02:00
Joffrey JAFFEUX	acc96abe1a	DEV: plugin generator will now ask for github username (#6337)	2018-08-30 12:03:30 +02:00
Guo Xiang Tan	492b6dc306	DEV: yarn exec doesn't do what I think it does.	2018-08-30 15:55:36 +08:00
Sam	e6970151a6	FEATURE: allow specifying locale via SSO ... Use: locale locale_force_update To force user locale on users where SiteSetting.allow_user_locale is enabled Note: If an invalid locale is specified no action will occur	2018-08-30 09:58:03 +10:00
Joffrey JAFFEUX	06f18b0e9f	typo	2018-08-29 13:51:16 +02:00
Joffrey JAFFEUX	ef36fdfb64	DEV: rails generator to create plugin skeleton (#6332) ... rails g plugin --help rails g plugin DiscourseRacoon --author joffrey	2018-08-29 13:32:41 +02:00
Dax74	5f51ef27e7	Added sitemap plugin in the official list	2018-08-29 10:58:26 +02:00
Guo Xiang Tan	720726ea68	Use yarn exec when running eslint and prettier.	2018-08-29 11:03:42 +08:00
Sam	44cf3cf975	FIX: queue heartbeats in readonly modes ... If sidekiq is paused or Discourse is in readonly continue to queue heartbeats If we do not do that then a master process can end up reaping sidekiq workers and causing various badness This also impacts restore which can do weird stuff TM in cases like this	2018-08-29 12:36:59 +10:00
Sam	9ab1fb7dfc	FEATURE: correctly store width and height on uploads ... Previously we used width and height for thumbnails, new code ensures 1. We auto correct width and height 2. We added extra columns for thumbnail_width and height, this is determined by actual upload and no longer passed in as a side effect 3. Optimized Image now stores filesize which can be used for analysis, decisions Also - fixes Android image manifest as a side effect - fixes issue where a thumbnail generated that is smaller than the upload is no longer used	2018-08-28 12:59:22 +10:00
Neil Lalonde	ebe7835316	FIX: links in rss feeds are sometimes wrong on subfolder installs	2018-08-27 18:05:15 -04:00
Bianca Nenciu	b6963b8ffb	FIX: Ignore OneBox blacklisted domains.	2018-08-27 20:40:55 +02:00
Sam	4205c528d0	FEATURE: hide enable_personal_email_messages and min_trust_to_send_email_messages ... These site settings are very hard to explain and only applicable for very specific Discourse setups. If an admin "enables staged users" which is used in support scenarios then all staff can send "messages" directly to an "email". The setting allows you to extend this to TL4 or any trust level. Actual use case would be a support type setup with restricted staff. It is quite rare so hiding this for now and re-evaluate keeping the setting in 2019	2018-08-27 11:38:22 +10:00
Maja Komel	020eba4623	FIX: find tags with non-latin names (#6312)	2018-08-27 11:05:28 +10:00
Sam	47e6b8b318	discourse etiquette is an official plugin	2018-08-27 10:03:49 +10:00
Sam	ac11f8df52	correct regression searching with diacritics	2018-08-24 10:00:51 +10:00
Gerhard Schlager	6588a45880	Make Rubocop happy	2018-08-23 15:09:20 +02:00
Gerhard Schlager	409ee66839	Add optional "ignore_case" parameter to posts:remap rake task	2018-08-23 14:49:17 +02:00
Arpit Jalan	7a91df3248	Merge pull request #6290 from techAPJ/latest-full-name ... UX: show full name on /latest page	2018-08-23 17:34:54 +05:30
Arpit Jalan	1a7cd6648b	UX: show full name on /latest page	2018-08-23 14:41:06 +05:30
Guo Xiang Tan	dd810b8b05	Merge pull request #6304 from tgxworld/create_functions_in_different_schema ... FIX: Create `BaseDropper` functions in a different schema.	2018-08-23 15:01:41 +08:00
Sam	6ee352510a	Correctly handle exception	2018-08-23 16:27:00 +10:00
Sam	cbd9045c6b	FIX: avoid race condition creating posts ... in some cases the distributed mutex was not protecting us and transactions would fail	2018-08-23 15:11:06 +10:00
Guo Xiang Tan	212ee15804	FIX: Create BaseDropper functions in a different schema. ... https://meta.discourse.org/t/error-when-restore-db-backup/93145/25?u=tgxworld	2018-08-23 12:52:21 +08:00
Osama Sayegh	2711f173dc	FIX: don't allow inviting more than max_allowed_message_recipients ... * FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows * add specs for guardian * user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit) Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences * groups take only 1 slot in PM * just return if topic is a PM	2018-08-23 14:36:49 +10:00
Guo Xiang Tan	36a7028f19	FEATURE: Clean up PostReplyKey records. ... * Default retention of 90 days.	2018-08-23 10:40:02 +08:00
Régis Hanol	f01169d6ff	FIX: don't send email when the post was deleted	2018-08-22 13:13:58 +02:00
Sam	d3b4f24ced	DEV: correct watcher for controller specs	2018-08-22 14:35:57 +10:00
Sam	272de95175	FIX: client duplicate registration should be cleaned up ... If for any reason we are unable to correct client id on a user api key invalidate old keys for client/user	2018-08-22 12:56:49 +10:00
Sam	5d96809abd	FIX: improve support for subfolder S3 CDN	2018-08-22 12:31:13 +10:00
Sam	f5142861e5	Revert "Revert "FIX: upload URLs from S3 on subfolder installs"" ... This reverts commit 26c96e97e5. We have no choice but to run this code	2018-08-22 11:31:33 +10:00
Sam	26c96e97e5	Revert "FIX: upload URLs from S3 on subfolder installs" ... This reverts commit 357df2ff4f.	2018-08-22 10:51:40 +10:00
Robin Ward	410b0f591f	FIX: Flagged Post custom fields were not respecting type	2018-08-21 15:33:15 -04:00
Neil Lalonde	357df2ff4f	FIX: upload URLs from S3 on subfolder installs	2018-08-21 14:58:55 -04:00
Régis Hanol	d1607a387a	FIX: only allow printable characters in uploads filename	2018-08-21 18:11:01 +02:00
Neil Lalonde	e94b5b4d78	Version bump to v2.1.0.beta5	2018-08-21 11:54:23 -04:00
Guo Xiang Tan	0f07494b12	Merge pull request #6259 from pfaffman/patch-2 ... FIX: disable_2fa fix method selection	2018-08-21 17:29:42 +08:00
Guo Xiang Tan	791ddb8630	PERF: Memoize EmailReceiver#sent_to_mailinglist_mirror?.	2018-08-21 15:44:47 +08:00
Guo Xiang Tan	7dcc69aef4	DEV: Refactor test to not call private method.	2018-08-21 14:29:58 +08:00
Sam	57d04200a1	Add Rails 6 note here	2018-08-21 11:09:10 +10:00
Sam	ca5a6f0a9d	FIX: handle concurrently creating post reply keys ... In some very rare conditions this would be called concurrently and fail	2018-08-21 10:59:18 +10:00
Sam	8fa5dd4a1f	FEATURE: discourse-checklist is now an official plugin	2018-08-21 10:44:40 +10:00
Bianca Nenciu	860c1c3dcd	FEATURE: Automatically expire keys if not used for a configurable amount of time. (#6264)	2018-08-20 17:36:14 +02:00
Neil Lalonde	ac40fede66	Revert "FIX: subfolder support for S3 CDN"	2018-08-20 10:30:44 -04:00
Neil Lalonde	0b8f6d3637	FIX: subfolder support for S3 CDN	2018-08-20 10:22:03 -04:00
Sam	f5fe58384f	correct regression around file renaming	2018-08-20 16:08:05 +10:00
Sam	d7b1919ead	correct specs	2018-08-20 12:46:14 +10:00
Sam	8b5e42ea16	FIX: always test and coerce to image on upload ... In the past the filename of the origin was used as the source for the extension of the file when optimizing on upload. We now use the actual calculated extension based on upload data.	2018-08-20 12:18:59 +10:00
Robin Ward	a83f662492	FIX: Allow silenced users to like / bookmark, just not flag.	2018-08-17 11:06:18 -04:00
Guo Xiang Tan	16c0ebe8a8	Fix the build.	2018-08-17 16:53:07 +08:00
Guo Xiang Tan	a26ef7738f	FIX: FileHelper#download should return nil if max size is exceeded.	2018-08-17 16:19:59 +08:00
Guo Xiang Tan	be89f593f9	DEV: Include caller in error message for Discourse#execute_command.	2018-08-17 16:17:07 +08:00
Guo Xiang Tan	fae8757cd4	FIX: Guardian#post_can_act? shouldn't raise an error if user of post has been deleted.	2018-08-17 15:11:30 +08:00
Sam	70155f0923	DEV: decrease log level of compile failures ... We do not need to report his in logs, our failure mode is fine here.	2018-08-17 17:10:02 +10:00
Guo Xiang Tan	a9e502936f	FIX: Converting PNG to JPEG does not set the correct extension.	2018-08-17 13:09:48 +08:00
Gerhard Schlager	802ad0dc61	Add rake task for updating static pages	2018-08-16 19:51:20 +02:00
Régis Hanol	98898ff4b3	FIX: raise an exception when 'downsize'git st fails	2018-08-16 19:20:07 +02:00
Joffrey JAFFEUX	3fbf7b164d	FEATURE: emoji 11.0 "recently added" update (#6275) ... Adds support for emojis in the http://www.unicode.org/emoji/charts-11.0/emoji-released.html list	2018-08-16 11:59:45 +02:00
Gerhard Schlager	937ab3f213	FIX: Validation of min_posts and max_posts didn't work	2018-08-16 10:36:53 +02:00
Arpit Jalan	8e3b685aa4	make rubocop happy	2018-08-16 14:03:46 +05:30
Arpit Jalan	df55e5bac4	optimize categories:create_definition task	2018-08-16 14:00:07 +05:30
Arpit Jalan	78e14abb32	new rake task to bulk tag all topics in a category	2018-08-16 13:56:57 +05:30
Arpit Jalan	777055f960	new rake task to create category definition	2018-08-16 13:50:52 +05:30
Sam	796164b58c	FIX: automatically correct bad avatars on access ... Also start relying on upload extension for optimized images	2018-08-16 16:32:56 +10:00
Guo Xiang Tan	33f4aa2835	Fix migrate_to_s3 rake task, File#close! is not a valid method.	2018-08-16 13:26:58 +08:00
Neil Lalonde	ac3b0f0164	REFACTOR: move remap out of script into a class	2018-08-15 12:37:52 -04:00
David Taylor	7b089f7af4	FIX: Don't throw exception if welcome topic cannot be found	2018-08-15 15:50:55 +01:00
Sam	38c10a3dc2	correct the validator	2018-08-15 14:56:24 +10:00
Sam	91e0a77a60	FEATURE: silenced users should not be allowed to edit posts	2018-08-15 14:29:36 +10:00
Sam	06f82a7d72	correct exception handling, always do to_i in array	2018-08-15 11:31:42 +10:00
Sam	bc47148d35	add validation to exclude_category_ids	2018-08-15 09:53:28 +10:00
Régis Hanol	12bab65167	FIX: going from /categories to /latest on mobile might break infinite scrolling	2018-08-15 01:22:03 +02:00
Gerhard Schlager	ba0e322fd0	FIX: Validation of topic params broke discourse-assign	2018-08-14 18:45:46 +02:00
Robin Ward	87fa26b6c8	FIX: Silenced users shouldn't be able to act on posts	2018-08-14 11:43:39 -04:00
Gerhard Schlager	2927294cc6	FIX: Bulk deleting topics should ignore already deleted topics	2018-08-14 16:37:52 +02:00
Régis Hanol	de92913bf4	FIX: store the topic links using the cooked upload url	2018-08-14 12:23:32 +02:00
Sam	ad5f502332	FIX: add a basic validator for topic params ... This cuts down on log noise when people try out sql injection	2018-08-14 17:01:04 +10:00
Sam	6cae47aa53	collect extra environment correctly	2018-08-13 16:33:28 +10:00
Sam	168ffd8384	FEATURE: group warnings about IP level rate limiting	2018-08-13 14:38:20 +10:00
Guo Xiang Tan	d10c9d7d75	FIX: Missing extensions for non-image uploads due to 2b57239389.	2018-08-13 10:58:55 +08:00
Jay Pfaffman	71a1d75d7e	FIX: disable_2fa fix method selection ... The previous code resulted in NameError: undefined local variable or method `totp' for main:Object I now understand what @tgxworld meant about we should only disable totp when I submitted this before. This is the kind of Ruby stuff that I still don't understand well,(perhaps this isn't the most Ruby way to do this?) but this does what I think is supposed to happen. And it worked just now.	2018-08-10 14:45:40 -07:00
Osama Sayegh	865cb3feb9	FIX: allow selecting site's default theme from preference	2018-08-10 14:12:02 +03:00
Sam	ea8394b080	typo in error message	2018-08-10 11:34:01 +10:00
Sam	1fc2597626	better error handling for upload extension fixer	2018-08-10 11:28:22 +10:00
Gerhard Schlager	b9072e8292	FEATURE: Add "Reset Bump Date" action to topic admin wrench (#6246)	2018-08-10 10:51:03 +10:00
Gerhard Schlager	ef4b9f98c1	FEATURE: Allow admins to reply without topic bump	2018-08-10 10:48:30 +10:00
Neil Lalonde	d77dccc636	FIX: user-deleted posts with deferred flags can be destroyed	2018-08-09 14:54:31 -04:00
Gerhard Schlager	6ddf7fcd1f	Fix warnings about already initialized constants	2018-08-09 17:29:02 +02:00
Robin Ward	5895507153	FEATURE: Ability for plugins to whitelist custom fields for flags ... You can now call `whitelist_flag_post_custom_field` from your plugins and those custom fields will be available on the flagged posts area of the admin section.	2018-08-09 10:49:14 -04:00
Sam	ed4c0f256e	FIX: check permalinks for deleted topics ... - allow to specify 410 vs 404 in Discourse::NotFound exception - remove unused `permalink_redirect_or_not_found` which - handle JS side links to topics via Discourse-Xhr-Redirect mechanism	2018-08-09 15:05:12 +10:00
Guo Xiang Tan	1ea23b1eae	FIX: Wrong order for S3Helper#copy_file.	2018-08-08 15:58:54 +08:00
Guo Xiang Tan	0879610ffd	Add missing require in uploads:fix_incorrect_extensions.	2018-08-08 15:39:37 +08:00
Sam	a35f2984e9	FIX: support Arrays with Marshal dump in distributed cache ... Theme cache uses arrays here	2018-08-08 16:44:56 +10:00
Guo Xiang Tan	17047806b9	Add a rake task to fix uploads with wrong extension.	2018-08-08 13:15:17 +08:00
Osama Sayegh	0b7ed8ffaf	FEATURE: backend support for user-selectable components ... * FEATURE: backend support for user-selectable components * fix problems with previewing default theme * rename preview_key => preview_theme_id * omit default theme from child themes dropdown and try a different fix * cache & freeze stylesheets arrays	2018-08-08 14:46:34 +10:00
Guo Xiang Tan	aafff740d2	Add FileStore::S3Store#copy_file.	2018-08-08 11:30:34 +08:00
Neil Lalonde	4e6e4a83df	FIX: subfolder digest emails have incorrect URLs	2018-08-07 16:38:17 -04:00
Neil Lalonde	1fcb5c1b6d	Version bump to v2.1.0.beta4	2018-08-07 12:32:57 -04:00
Guo Xiang Tan	2b57239389	FIX: Upload's content is the only source of truth for the file type.	2018-08-07 13:15:00 +08:00
Sam	4b000f5d12	FIX: do not use lib for requires ... this breaks loading the app from arbitrary dirs	2018-08-07 11:04:29 +10:00
Arpit Jalan	ffc8c52bf5	FIX: store welcome topic id in custom field	2018-08-06 23:46:03 +05:30
David Taylor	812add18bd	REFACTOR: Serve auth provider information in the site serializer. ... At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.	2018-08-06 09:25:48 +01:00
Régis Hanol	0cd9e2acb9	fix build	2018-08-04 01:56:26 +02:00
Joffrey JAFFEUX	066010db7d	FEATURE: introduces list/compact_list components	2018-08-03 16:41:37 -04:00
Régis Hanol	ac2513b0f2	FEATURE: automatic PM when a user's email is revoked	2018-08-03 16:39:22 +02:00
Jeff Atwood	c81bad3232	Merge pull request #6232 from OsamaSayegh/message-email-short-reply ... UX: better rejection message when reply via email is too short	2018-08-02 14:25:04 -07:00
OsamaSayegh	a157dfd418	UX: better rejection message when reply via email is too short	2018-08-02 22:43:53 +03:00
Régis Hanol	14bbd5d167	FIX: use the right URL when downloading the file from S3	2018-08-02 10:04:41 +02:00
Penar Musaraj	4a872823e7	Improvements to user drafts (#6226) ... * drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels * use JSON when testing Draft.stream	2018-08-02 07:41:27 +10:00
Régis Hanol	0f1137dafa	FIX: 'migrate_from_s3' rake task wasn't handling short urls	2018-08-01 22:58:46 +02:00
Jeff Wong	059862ed46	Mark discord auth plugin official	2018-08-01 09:33:14 -07:00
Neil Lalonde	b829452c75	Merge pull request #6209 from discourse/mini_scheduler ... REFACTOR: extract scheduler to the mini_scheduler gem	2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX	0b9437cee7	FIX: more resilient/consistent dashboard caching (#6223)	2018-08-01 09:45:50 -04:00
Gerhard Schlager	a115aae45f	Use rchardet instead of charlock_holmes gem	2018-08-01 10:41:20 +02:00
Gerhard Schlager	ff942ed2f3	FIX: Try detecting encoding of RSS feed	2018-08-01 10:41:20 +02:00
Penar Musaraj	1f45215537	FEATURE: Drafts view in user profile ... * add drafts.json endpoint, user profile tab with drafts stream * improve drafts stream display in user profile * truncate excerpts in drafts list, better handling for resume draft action * improve draft stream SQL query, add rspec tests * if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username) * cleanup * linting fixes * apply prettier styling to modified files * add client tests for drafts, includes a fixture for drafts.json * improvements to code following review * refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix * added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed * prettier, eslint fixes * use "username_lower" from users table, added error handling for rejected promises * adds guardian spec for can_see_drafts, adds improvements following code review * move DraftsController spec to its own file * fix failing drafts qunit test, use getOwner instead of deprecated this.container * limit test fixture for draft.json testing to new_topic request only	2018-08-01 16:34:54 +10:00
Vinoth Kannan	6aee22b88f	FIX: Onebox images are not downloaded locally without css class	2018-08-01 02:51:02 +05:30
Neil Lalonde	4ad7ce70ce	REFACTOR: extract scheduler to the mini_scheduler gem	2018-07-31 17:12:55 -04:00
Arpit Jalan	afe3b00c0f	FIX: use hidden setting for max export file size	2018-07-31 11:25:28 +05:30
Sam	f0c203a5cf	clean up previous commit	2018-07-31 14:50:02 +10:00
Jay Pfaffman	b55d9e63a0	Rake mail test debugging (#6171) ... * FEATURE: rake emails:test add debugging * Oops! Remove safety code * more language tweaks	2018-07-31 14:45:59 +10:00
Neil Lalonde	fd29ecb91a	UX: include a flag reason in the post-deleted-by-staff-because-of-flags message	2018-07-30 16:45:46 -04:00
Régis Hanol	8f1db615db	FIX: don't break restore if function does not exist	2018-07-30 22:11:38 +02:00
Arpit Jalan	17b851cf08	FEATURE: show last updated date for wiki topics	2018-07-30 20:27:49 +05:30
David Taylor	6566b2f11a	FEATURE: Allow revoke and connect for Instagram logins	2018-07-30 14:38:53 +01:00
Arpit Jalan	dfcb2a0d42	FEATURE: include published_time in metadata	2018-07-30 17:09:56 +05:30
David Taylor	8d1acbd4c2	DEV: Include specific authenticator name in warning message	2018-07-30 11:33:48 +01:00
Guo Xiang Tan	b94633e844	FIX: FileHelper should prioritize response content-type. ... Request to a URL with `.png` extension may return a jpg instead causing us to attach the wrong extension to an upload.	2018-07-30 10:54:36 +08:00
David Taylor	5f1fd0019b	FEATURE: Allow revoke and connect for GitHub logins	2018-07-27 17:18:53 +01:00
David Taylor	6296f63804	FEATURE: Revoke and connect for Yahoo logins	2018-07-27 16:20:47 +01:00
David Taylor	9c72c00206	FEATURE: Revoke and reconnect for Twitter logins	2018-07-27 12:28:51 +01:00
Arpit Jalan	c74dd2fa08	FIX: welcome topic should not be a private message	2018-07-27 15:15:13 +05:30
Guo Xiang Tan	6740631fdb	TEMPFIX: Fix broken restores.	2018-07-27 12:48:16 +08:00
Neil Lalonde	135c803f49	FIX: don't send PM if flagged post is deleted but flags were deferred or cleared	2018-07-26 15:12:31 -04:00
Neil Lalonde	a74024b1c9	Version bump to v2.1.0.beta3	2018-07-26 14:16:06 -04:00
David Taylor	467c529920	FIX: Remove return statement from inside block	2018-07-26 15:52:39 +01:00
David Taylor	88241f57a3	FEATURE: allow auth plugins to have a site setting for full screen login	2018-07-26 11:11:16 +01:00
Nick Shearer	def2c977ce	allow auth plugins to have a site setting for if they should be full screen vs popup window	2018-07-25 19:20:11 -05:00
Régis Hanol	f94aeaf6cf	SECURITY: force IM decoder based on file extension - part 3	2018-07-25 23:55:06 +02:00
Régis Hanol	800c57c6ab	SECURITY: force IM decoder based on file extension - part 2	2018-07-25 23:08:02 +02:00
Régis Hanol	4bf3bf6786	SECURITY: force IM decoder based on file extension	2018-07-25 22:00:04 +02:00
David Taylor	0d0d78841b	FIX: Remove plugin.enabled? checks at initialization time (#6166) ... Checking `plugin.enabled?` while initializing plugins causes issues in two ways: - An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times. - In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster. Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods. I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality: - `post_custom_fields_whitelist` - `whitelist_staff_user_custom_field` - `add_permitted_post_create_param`	2018-07-25 16:44:09 +01:00
Joffrey JAFFEUX	796639a797	FIX: makes disk_space computation more resilient (#6172)	2018-07-25 11:04:01 -04:00
David Taylor	fa399ce1c5	FEATURE: Add revoke and reconnect functionality for google logins	2018-07-25 16:03:14 +01:00
Joffrey JAFFEUX	578c8e861b	FIX: refreshes disk_space on backup create/destroy (#6169)	2018-07-25 08:26:30 -04:00
David Taylor	776fd0de66	FIX: Filter open-id logins by identifier	2018-07-25 11:47:09 +01:00
Gerhard Schlager	84d14fd8a0	FIX: Don't rely on setting data type read from database	2018-07-25 11:40:59 +02:00
Neil Lalonde	417bcf7d2e	add checks for staff and system user before sending flags_agreed_and_post_deleted message	2018-07-24 19:25:11 -04:00
Neil Lalonde	fe39cdc90a	FEATURE: when a post is deleted because a moderator agreed with flags, send a message to the post author	2018-07-24 17:17:56 -04:00
Robin Ward	7058205f70	FIX: Broken specs	2018-07-24 12:00:34 -04:00
Robin Ward	236243f38a	SECURITY: Consider 0.0.0.0 a private IP	2018-07-24 11:16:27 -04:00
Joffrey JAFFEUX	7a3c541077	UX: Preview multiple color schemes in wizard (#6151) ... It was a dropdown to provide choices of color schemes, and only one scheme could be shown. With this commit, multiple color scheme previews can be displayed on one page at the same time, making admins choose color schemes more easily. Theme preview windows are shrinked. Imported default color schemes. Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>	2018-07-24 09:00:20 -04:00
Guo Xiang Tan	fa19d3a53c	Merge pull request #6108 from discourse/transaction-sidekiq-fix ... Fix notifications for topics moved between categories	2018-07-24 17:44:03 +08:00
David Taylor	20a21b1240	Move into MiniSQLMultisiteConnection, and add test for rollback	2018-07-24 09:41:55 +01:00
Guo Xiang Tan	fad9c2b971	PERF: Move EmailLog#reply_key into new post_reply_keys table.	2018-07-24 13:51:53 +08:00
Guo Xiang Tan	ae8b0a517f	PERF: Split skipped email logs into a seperate table.	2018-07-24 13:14:37 +08:00
Gerhard Schlager	e42038eae2	Rake task called method with wrong arguments	2018-07-24 00:10:09 +02:00
David Taylor	eda1462b3b	FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099) ... Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.	2018-07-23 16:51:57 +01:00
Guo Xiang Tan	b165cfdfbe	FIX: Raise a better error in SiteSettings::TypeSupervisor.	2018-07-19 16:41:00 +08:00
Arpit Jalan	14a0879658	FIX: allow Twitter videos to go fullscreen	2018-07-19 10:22:36 +05:30
David Taylor	2dc3a50dac	FIX: Do not update last seen time for suspended users	2018-07-18 16:04:57 +01:00
Régis Hanol	6d6e026e3c	FEATURE: selectable avatars	2018-07-18 12:57:43 +02:00
Sam	379384ae1e	FIX: never block /srv/status which is used for health checks ... This route is also very cheap so blocking it is not required It is still rate limited and so on elsewhere	2018-07-18 12:37:01 +10:00
Guo Xiang Tan	3874d40910	Prepare to drop EmailLog#topic_id.	2018-07-18 10:22:24 +08:00
Guo Xiang Tan	1d74ccaaf8	Add compatibility for ImageMagick7.	2018-07-17 15:50:58 +08:00
Arpit Jalan	a7ec949e02	make RuboCop happy	2018-07-17 13:15:44 +05:30
Arpit Jalan	7c7509e1bd	FEATURE: update TwitterApi for prettifying like/retweet count	2018-07-17 12:59:40 +05:30
Neil Lalonde	7b3ef4d13f	FIX: use email color settings consistently in notification emails	2018-07-16 12:30:42 -04:00
Rishabh	a6c589d882	FEATURE: Add custom S3 Endpoint and DigitalOcean Spaces/Minio support for Backups (#6045) ... - Add custom S3 Endpoints and DigitalOcean Spaces support - Add Minio support using 'force_path_style' option and fix uploads to custom endpoint	2018-07-16 14:44:55 +10:00
Jay Pfaffman	0ed2834c2d	FEATURE: Add users:disable_2factor rake task ... https://meta.discourse.org/t/admin-locked-out-of-2fa/92156/2?u=pfaffman	2018-07-16 09:56:55 +08:00
Arpit Jalan	b1082924b9	FIX: do not validate topic deletions	2018-07-13 22:53:36 +05:30
Guo Xiang Tan	711371e8c8	FIX: Select+below will ask server for post ids on megatopics.	2018-07-13 15:10:39 +08:00
Guo Xiang Tan	c722b07057	FIX: /t/:topic_id/last route did not return any posts.	2018-07-13 14:26:10 +08:00
Kyle Zhao	2901691e87	FEATURE: per-category approval settings (#5778) ... - disallow moving topics to a category that requires topic approval	2018-07-13 12:51:08 +10:00
David Taylor	81f9500f5c	FIX: Change megatopic threshold to 10,000 posts	2018-07-12 22:00:53 +01:00
Guo Xiang Tan	258e9e35ca	PERF: Make mega topics work without a stream. ... There are tradeoffs that we took here. For the complete story see https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld.	2018-07-12 12:46:12 +08:00
OsamaSayegh	decf1f27cf	FEATURE: Groundwork for user-selectable theme components ... * Phase 0 for user-selectable theme components - Drops `key` column from the `themes` table - Drops `theme_key` column from the `user_options` table - Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column. - Removes the `default_theme_key` site setting and adds `default_theme_id` instead. - Replaces `theme_key` cookie with a new one called `theme_ids` - no longer need Theme.settings_for_client	2018-07-12 14:18:21 +10:00
Arpit Jalan	536cef86f4	PERF: do not carry post ids in memory when rebaking all posts	2018-07-11 14:34:33 +05:30
Maja Komel	0942e2c795	allow adding tags as a custom subject format for emails (#5846) ... allow adding tags as a custom subject format for emails	2018-07-11 12:24:07 +10:00
Neil Lalonde	f69b7deb80	FIX: wizard emoji images on subfolder installs	2018-07-10 11:02:22 -04:00
Guo Xiang Tan	b4e1388f9b	PERF: Drop support for gaps in mega topics. ... Based on our current implementation, there isn't a practical way to determine the gaps of large topics cheaply. We tried to load the gaps in chunks but felt that the code becomes too complicated. Note that megatopics are quite rare in the wild.	2018-07-10 16:27:02 +08:00
Guo Xiang Tan	21f333654c	REFACTOR: Reduce dependency on the post stream in TopicView. ... This will allow us to drop the post stream from the payload for mega-topics. On smaller topics, the extra query is fast because of an existing index.	2018-07-10 15:53:00 +08:00
Guo Xiang Tan	4163f9e61e	DEV: Better clean up for PostgreSQL failover test.	2018-07-10 09:53:25 +08:00
Guo Xiang Tan	96aca6d7e6	Remove legacy vote post action code. (#6009)	2018-07-09 16:54:18 +08:00
Guo Xiang Tan	72a3457379	Bump discourse_image_optim which uses a global timeout. ... Our previous solution has the timeout set at the worker level which means the total timeout would be X timeout secs * N number of workers.	2018-07-09 10:30:18 +08:00
Andrew Schleifer	dba22bbde2	rollback changes ... This reverts: * 1baba84c438e "fix s3 subfolders harder" * ea5e57938edf "fix test for absolute_base_url change"	2018-07-06 17:16:40 -05:00
Andrew Schleifer	52e9f49ec1	fix s3 subfolders harder ... specifically, include the folder in absolute_base_url	2018-07-06 16:28:40 -05:00
Guo Xiang Tan	59a2767de8	Ensure that we restore the site setting in posts:rebake rake task.	2018-07-06 16:22:54 +08:00
Neil Lalonde	eabc8f7fbd	Merge pull request #6023 from misaka4e21/only-staff-can-create-tag ... FEATURE: Support disabling tag creation for non-staff users.	2018-07-05 11:12:44 -04:00
Neil Lalonde	92000bc8a0	FEATURE: add a rake task to recalculate user stats post_count and topic_count	2018-07-05 10:38:46 -04:00
Patrick Gansterer	28dd7fb562	FEATURE: Create hidden posts for received spam emails (#6010) ... * Add possibility to add hidden posts with PostCreator * FEATURE: Create hidden posts for received spam emails Spamchecker usually have 3 results: HAM, SPAM and PROBABLY_SPAM SPAM gets usually directly rejected and needs no further handling. HAM is good message and usually gets passed unmodified. PROBABLY_SPAM gets an additional header to allow further processing. This change addes processing capabilities for such headers and marks new posts created as hidden when received via email.	2018-07-05 11:07:46 +02:00
Sam	7b26f5086b	PERF: we have no use for topic percent rank ... Prepare to remove this column	2018-07-05 15:10:19 +10:00
Régis Hanol	272646c1df	FIX: only show the sequential replies warning for regular posts	2018-07-04 22:51:19 +02:00
Régis Hanol	8a53941fe0	FIX: less aggressive gmail eliding	2018-07-04 20:04:46 +02:00
Régis Hanol	448e2fe1a2	FIX: properly delete files in the download cache	2018-07-04 18:18:39 +02:00
Neil Lalonde	f134701c7b	FIX: user topic and post counts can become negative when staff deletes posts in personal messages	2018-07-04 09:31:16 -04:00
Arpit Jalan	7590128d38	fix typo	2018-07-04 12:01:15 +05:30
Guo Xiang Tan	0af159546a	FIX: BackupRestore::Backuper#remove_tar_leftovers not cleaning up files. ... Wildcard is sanitized when passed to `system()`.	2018-07-04 13:58:39 +08:00
Sam	e72fd7ae4e	FIX: move crawler blocking into anon cache ... This refinement of previous fix moves the crawler blocking into anonymous cache This ensures we never poison the cache incorrectly when blocking crawlers	2018-07-04 11:14:43 +10:00
Sam	7f98ed69cd	FIX: move crawler blocking to app controller ... We need access to site settings in multisite, we do not have access yet if we attempt to get them in request tracker middleware	2018-07-04 10:30:50 +10:00
Sam	d1b21aa73b	add timings to asset precompile	2018-07-04 09:42:38 +10:00
Sam	b6e9c734f2	replace error with message ... So Discourse continues to work on Ruby trunk	2018-07-04 09:42:38 +10:00
Neil Lalonde	e8a6323bea	remove crawler blocking until multisite support	2018-07-03 17:54:45 -04:00
Kasia Bułat	b71cf6d422	FEATURE: Add search not operator for tags.	2018-07-03 15:57:34 +08:00
Joshua Rosenfeld	212f518cd1	Add invite tokens to official plugins list	2018-06-30 17:24:45 -04:00
Guo Xiang Tan	252e5574cc	FIX: Prevent ambigous column errors when joining TopicView queries.	2018-06-29 10:33:08 +08:00
Sam	db14e10943	SECURITY: category badges should HTML escape names	2018-06-28 18:15:07 +10:00
Maja Komel	ec3e6a81a4	FEATURE: Second factor backup	2018-06-28 10:12:32 +02:00
Gerhard Schlager	23acddc9fa	Add descriptions for rake tasks	2018-06-27 20:24:46 +02:00
Guo Xiang Tan	eb427f7cf4	PERF: Update TopicView#participant_count to use Topic#posts_count. ... Use the counter cache instead of hitting the DB and plucking every single id.	2018-06-27 17:18:47 +08:00
Guo Xiang Tan	cfa7898c2d	Rename TopicView#last_read_post_id to TopicView#filtered_post_id.	2018-06-27 12:33:57 +08:00
Guo Xiang Tan	cb69888758	PERF: Don't pluck all the columns just to retrieve a single value.	2018-06-27 11:41:35 +08:00
misaka4e21	47cb46671a	FEATURE: Support disabling tag creation for non-staff users.	2018-06-27 07:15:02 +08:00
Arpit Jalan	6bcdc3ba4b	FEATURE: allow author to delete posts irrespective of post_edit_time_limit	2018-06-26 21:43:06 +05:30
Guo Xiang Tan	49ffc1eb61	Revert "PERF: Send down gaps as the relevant posts load instead of front loading." ... This reverts commit 4c3352528e.	2018-06-26 12:54:14 +08:00
Guo Xiang Tan	4c3352528e	PERF: Send down gaps as the relevant posts load instead of front loading.	2018-06-26 12:49:06 +08:00
Guo Xiang Tan	0b6a2e9d1f	Remove force summary mode for megatopics for now. ... The logic is too hairy and we can't reliably determine when to force summary mode. Work is underway to improve perf for megatopics so this will not be required eventually.	2018-06-26 12:49:06 +08:00
Guo Xiang Tan	5100a62fc0	FIX: Megatopics forced into summary mode when loading posts.	2018-06-25 22:11:56 +08:00
David Lee	4644d777bd	FEATURE: add website field to SSO	2018-06-25 16:09:39 +10:00
Jeff Wong	41f76a74f8	FEATURE: send message when a user reaches tl1	2018-06-22 13:20:00 -07:00
Robin Ward	6901e0e043	FIX: Rails.logger isn't always available when loading plugin locales	2018-06-22 10:20:20 -04:00
Guo Xiang Tan	50f14c6e61	Prefer update! -> update!.	2018-06-22 15:13:04 +08:00
Guo Xiang Tan	f69356e628	FIX: Users can't "show all posts" in forced summary topics.	2018-06-22 11:32:45 +08:00
Neil Lalonde	544254f7a8	Version bump to v2.1.0.beta2	2018-06-21 10:41:52 -04:00
Guo Xiang Tan	97d8cd820e	No need to expire readonly mode key immediately.	2018-06-21 17:52:42 +08:00
Guo Xiang Tan	9a7a079f4d	Force summary mode when user enters at the top of megalodoon topics.	2018-06-21 15:18:52 +08:00
Guo Xiang Tan	f7d22bad90	FEATURE: Forced summary mode for megalodon topics. ... This is mainly done for performance reasons and megalodon topics are usually a byproduct of imports where site setting limits are not respected.	2018-06-21 14:00:20 +08:00
Guo Xiang Tan	5cef4e281b	PERF: Memoize TopicView#gaps results.	2018-06-21 12:37:24 +08:00
Sam	2d59d06916	PERF: mega_topics get no post counts per user	2018-06-21 11:09:45 +10:00
Sam	f66efc601d	FIX: cubot android devices were detected as crawlers	2018-06-21 10:56:46 +10:00
Joffrey JAFFEUX	2f7960bd2a	DEV: updates prettier and displays linters/prettifiers version in CI	2018-06-20 18:34:49 +02:00
Joffrey JAFFEUX	8126b603e4	fix prettier	2018-06-20 18:26:43 +02:00
Joffrey JAFFEUX	c5c1b45d19	higher loglevel for prettier	2018-06-20 16:51:48 +02:00
Guo Xiang Tan	0365806b93	FIX: Properly display error when post action fails to create.	2018-06-20 21:20:23 +08:00
Guo Xiang Tan	ff5fc3cb08	Use a fixed limit for mega topic posts count.	2018-06-20 16:58:52 +08:00
Guo Xiang Tan	9c925a66ff	PERF: Don't display days ago on timeline for megatopics. ... Analysis using `pg_stat_statements` showed this query to be eating up a significant portion of CPU.	2018-06-20 16:25:54 +08:00
Sam	cbdab71179	PERF: stop counting participants on very large topics ... This query gets very expensive and can be bypassed on large topics	2018-06-20 18:11:39 +10:00
Sam	2f0e73f2d6	DEV: fast pluck to use type_map in mini_sql	2018-06-20 17:53:49 +10:00
Sam	44091f20c6	DEV: allow for method deprecation using Discourse.deprecate ... New method deprecator will ensure one log message an hour happens for all deprecated method calls per call site Also removes unused monkey patches to ActiveRecord::Base	2018-06-20 17:53:49 +10:00
Sam	cb824a6b33	DEV: remove all calls to SqlBuilder use DB.build instead ... This is part of the migration to mini_sql, SqlBuilder.new is being deprecated and replaced with DB.build	2018-06-20 17:53:49 +10:00
Guo Xiang Tan	806f0ca19d	FIX: URL with params for svg images should not be light boxed.	2018-06-20 10:47:14 +08:00
Arpit Jalan	aedc61a3b4	FEATURE: allow large icon to be uploaded in wizard	2018-06-19 21:08:02 +05:30
Joffrey JAFFEUX	24c27b5321	FEATURE: adds a add_report method accessible in plugin.rb	2018-06-19 15:00:11 +02:00
Guo Xiang Tan	7eff64773c	Revert "FIX: Don't clear active connections in defer queue." ... This reverts commit c9feadf9ec.	2018-06-19 17:58:21 +08:00
Guo Xiang Tan	df24c51c6f	Revert "FIX: Don't try to dequeue an empty queue." ... This reverts commit 1af7d4a894.	2018-06-19 15:49:45 +08:00
Guo Xiang Tan	41c1e1b302	FIX: Discourse.keep_readonly_mode does not work for multisite.	2018-06-19 15:44:08 +08:00
Guo Xiang Tan	1af7d4a894	FIX: Don't try to dequeue an empty queue.	2018-06-19 15:25:44 +08:00
Sam	b8e5989201	correct rake db:create, which needs a defer DB object	2018-06-19 16:43:50 +10:00
Sam	5f64fd0a21	DEV: remove exec_sql and replace with mini_sql ... Introduce new patterns for direct sql that are safe and fast. MiniSql is not prone to memory bloat that can happen with direct PG usage. It also has an extremely fast materializer and very a convenient API - DB.exec(sql, *params) => runs sql returns row count - DB.query(sql, *params) => runs sql returns usable objects (not a hash) - DB.query_hash(sql, *params) => runs sql returns an array of hashes - DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array - DB.build(sql) => returns a sql builder See more at: https://github.com/discourse/mini_sql	2018-06-19 16:13:36 +10:00
Sam	cc3fc87dd7	DEV: handle termination cleanly in autospec	2018-06-19 16:13:36 +10:00
Guo Xiang Tan	c9feadf9ec	FIX: Don't clear active connections in defer queue.	2018-06-19 12:45:16 +08:00
Guo Xiang Tan	34e4c8f573	FIX: Discourse.keep_readonly_mode spins a new thread each time it is called.	2018-06-19 10:24:08 +08:00
Guo Xiang Tan	6e97242bb9	Monkey patch in 7830a950ef	2018-06-19 09:45:48 +08:00
Jeff Wong	68e4e6a575	FIX: staged users are still tl0 but do not trigger spam if 1 week old.	2018-06-18 17:20:04 -07:00
Guo Xiang Tan	630b4570ef	Add specs for RateLimiter::LimitExceeded#description.	2018-06-19 07:48:03 +08:00
Neil Lalonde	3725fd8345	Merge pull request #6002 from featheredtoast/trust-previously-staged-users ... FIX: don't punish a user for being previously staged for spam flags.	2018-06-18 15:14:31 -04:00
Neil Lalonde	320cd9a19e	UX: rate limiter message will say to wait "a few seconds" instead of 0 to 3 seconds	2018-06-18 14:14:47 -04:00
Joffrey JAFFEUX	913d97e780	fix prettier	2018-06-18 20:10:48 +02:00
Joffrey JAFFEUX	6f2c5ea1f2	increases loglevel to debug CI only failure	2018-06-18 19:25:54 +02:00
Blake Erickson	9963078dd1	Add to offical plugins list	2018-06-18 10:20:49 -06:00
Robin Ward	e5c156b226	Add characters-required to official plugins list	2018-06-18 10:30:46 -04:00
Guo Xiang Tan	c18b86d9b2	UX: Don't add light box for SVG images.	2018-06-18 17:11:06 +08:00
Jeff Wong	9e55767f6a	FIX: don't punish a user for being previously staged for spam flags.	2018-06-15 12:25:25 -07:00
Joffrey JAFFEUX	03a7d532cf	DEV: introduces prettier for es6 files	2018-06-15 17:03:24 +02:00
Arpit Jalan	c7ee70941e	FEATURE: show category page options on wizard 'homepage' step	2018-06-15 19:11:41 +05:30
OsamaSayegh	2427c0a17c	FIX: theme CSS should recompile when theme uploads change	2018-06-15 13:12:09 +10:00
Guo Xiang Tan	c34100d1e7	Remove unused variable.	2018-06-15 07:45:51 +08:00
Sam Saffron	6123f61f5f	seconds is not needed here	2018-06-14 20:53:24 +10:00
Sam	87fabdc2f3	FIX: correct pool reaper ... This removes a freedom patch and replaces with a custom reaper thread it also captures an issue where reaper would fail when connections where empty	2018-06-14 18:22:02 +10:00
Sam	71aa20bd30	FIX: pool drainer to use Rails 5.2 implementation ... old implementation did not reap abandoned connections	2018-06-14 15:54:48 +10:00
Sam	66982c7800	FIX: stop using Rails connection reaper in multisite ... The Rails 5.2 connection reaper appears to be leaking threads this is a quick fix to stop it, though we need to make sure we never leak connection pools as well.	2018-06-14 12:49:30 +10:00
Robin Ward	fd54c92a52	FEATURE: New site setting, whitelisted_link_domains ... If provided, users who normally couldn't post links (say, due to a low trust level), can post links to those specific hosts.	2018-06-13 16:11:22 -04:00
Robin Ward	ae728702a6	Revert "Revert "Preload custom user fields when viewing flag queue"" ... This reverts commit 1bb12ee1b6.	2018-06-13 11:44:13 -04:00
Guo Xiang Tan	139d0813b4	Re-enable fast_pluck freedom patch.	2018-06-13 09:25:23 +08:00
Joshua Rosenfeld	1bb12ee1b6	Revert "Preload custom user fields when viewing flag queue" ... This reverts commit 5bd1c5cc95.	2018-06-12 16:46:31 -04:00
Robin Ward	5bd1c5cc95	Preload custom user fields when viewing flag queue	2018-06-12 16:17:22 -04:00
Robin Ward	e0096b0d1c	Safety in case translations are missing root keys	2018-06-12 10:09:57 -04:00
Guo Xiang Tan	7c173265d5	FIX: Don't clear connections on the same process.	2018-06-12 13:06:25 +08:00
Guo Xiang Tan	646ed87aba	Clear all connections once master recovers.	2018-06-12 12:13:59 +08:00
Guo Xiang Tan	fd75e54793	Disconnect the pool during failover and fallback.	2018-06-12 11:09:19 +08:00
Guo Xiang Tan	a7be68500d	Better error reporting in PostgreSQL fallover thread.	2018-06-12 09:39:11 +08:00
Jeff Atwood	0dee603ffc	Merge pull request #5985 from featheredtoast/pm-participants-two-lines ... FIX: PM participants listed inline	2018-06-11 18:33:15 -07:00
Guo Xiang Tan	805fd17b23	ActiveRecord in Rails 5.2 discards connection pools after fork.	2018-06-12 09:30:52 +08:00
Jeff Wong	4599cc8435	FIX: PM participants listed inline	2018-06-11 18:14:25 -07:00
Michael Brown	8d92c73aad	Merge pull request #5952 from Supermathie/remap_enhance ... DbHelper.remap/find: add option to anchor at left/right of the column value	2018-06-11 15:15:17 -04:00
Guo Xiang Tan	bfa0f71e2b	FIX: Discouse.keep_readonly_mode incorrect extends expiry.	2018-06-12 00:21:29 +08:00
Guo Xiang Tan	2adae2a0b6	FIX: Be more aggressive in checking master when trying to fallback.	2018-06-12 00:09:15 +08:00
Régis Hanol	4d75535f9e	Revert "Revert "Revert "Add discourse-group-tracker to official plugin list.""" ... This reverts commit d1dc8e4226.	2018-06-11 15:52:20 +02:00
Régis Hanol	d1dc8e4226	Revert "Revert "Add discourse-group-tracker to official plugin list."" ... This reverts commit 1a00aaa825.	2018-06-11 14:30:16 +02:00
Guo Xiang Tan	c0b0c66a9e	FIX: PostgreSQL fallback thread doesn't run server starts in readonly.	2018-06-11 15:23:58 +08:00
Guo Xiang Tan	d06af14c26	FIX: Notify all processes to fallback when PostgreSQL recovers.	2018-06-11 15:10:28 +08:00
Guo Xiang Tan	d192924876	FIX: Can't boot Discourse app with read-only PG connection take 2.	2018-06-11 13:25:51 +08:00
OsamaSayegh	93b1386fb2	REFACTOR: admin site settings controller specs to requests (#5966)	2018-06-11 12:48:09 +08:00
Guo Xiang Tan	5656e8f366	FIX: Can't boot Discourse with a read-only PG connection.	2018-06-11 12:29:23 +08:00
Guo Xiang Tan	b91a3c12a5	Revert "Smoke test should wait up to 5 minutes before it fails" ... This reverts commit 34d4712133.	2018-06-11 08:47:57 +08:00
Guo Xiang Tan	e82d45b009	FIX: Ensure we have proper timeout for MiniRacer.	2018-06-11 08:41:04 +08:00
Neil Lalonde	4b2e42757d	fix indent	2018-06-08 13:56:20 -04:00
Neil Lalonde	b8cf0788c6	FIX: broken mailto href's in emails	2018-06-08 13:11:58 -04:00
Joffrey JAFFEUX	d96c775833	enforces prettier	2018-06-08 17:38:29 +02:00
Gerhard Schlager	4ba910ac54	Update username only after successful user anonymization	2018-06-08 15:50:07 +02:00
Joffrey JAFFEUX	22c186a792	disables prettier enforcing for now	2018-06-08 15:44:00 +02:00
Joffrey JAFFEUX	eedf7ffc4f	force install with sudo	2018-06-08 13:25:33 +02:00
Joffrey JAFFEUX	bc7f16a406	forces install of prettier using npm	2018-06-08 13:22:36 +02:00
Joffrey JAFFEUX	3869a9d027	forces global install of prettier	2018-06-08 12:40:05 +02:00
Joffrey JAFFEUX	ddade9c145	better log of yarn setup	2018-06-08 12:12:17 +02:00
Joffrey JAFFEUX	bb920e9bb1	DEV: makes sure yarn is ran before docker:test	2018-06-08 12:04:53 +02:00
Joffrey JAFFEUX	174d392e5a	DEV: adds prettier (#5956) ... Run `prettier --write "app/assets/stylesheets/**/*.scss" "plugins/**/*.scss"` after making sure you installed it with `yarn` It's recommended to configure your editor to run prettier on file save.	2018-06-08 11:49:31 +02:00
Guo Xiang Tan	29c1f01494	Fix broken pool drainer after the upgrade. ... See 6cd5cc375a/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb (L467) We think there is a leak at the moment because a discarded pool belonging to the parent process shouldn't be present in the forked process.	2018-06-08 13:19:07 +08:00
Sam	42847252a4	remove conditional code	2018-06-08 13:38:25 +10:00
Guo Xiang Tan	1a00aaa825	Revert "Add discourse-group-tracker to official plugin list." ... This reverts commit e262cb07d4.	2018-06-08 10:51:16 +08:00
Guo Xiang Tan	e262cb07d4	Add discourse-group-tracker to official plugin list.	2018-06-08 09:55:26 +08:00
Michael Brown	eba50f4591	DbHelper.remap: add options to anchor at left and right of the column value	2018-06-07 13:16:03 -04:00
Michael Brown	beef0d9dd2	fix my lint errors	2018-06-07 11:10:54 -04:00
Michael Brown	7e5f5a0b6b	DbHelper.find: column.table? strike that, reverse it	2018-06-07 10:59:34 -04:00
Michael Brown	8d57c712c3	Add DbHelper.find(needle) ... * searches the entire database for a text string (such as an old CDN name)	2018-06-07 10:51:16 -04:00
Arpit Jalan	f9ab3848ed	FEATURE: support disabling emails for non-staff users	2018-06-07 18:31:08 +05:30
Sam	1834417e2f	downgrade rails properly	2018-06-07 20:38:22 +10:00
Sam	322b66bcee	attempt to shuffle order of operation for test	2018-06-07 18:16:45 +10:00
Guo Xiang Tan	3533bdb83f	Remove line that is no longer required.	2018-06-07 15:56:16 +08:00
Guo Xiang Tan	1d5c176ea5	DEV: docker:test rake task should install plugins first before migrating.	2018-06-07 15:20:06 +08:00
Guo Xiang Tan	ad5082d969	Make rubocop happy again.	2018-06-07 13:28:18 +08:00
Sam	54c0aa788c	FIX: db:create was failing due to site settings	2018-06-07 14:51:14 +10:00
Sam	f331d2603d	DEV: improve design of site setting default provider ... This refactors it so "Defaults provider" is only responsible for "defaults" Locale handling and management of locale settings is moved back into SiteSettingExtension This eliminates complex state management using DistributedCache and makes it way easier to test SiteSettingExtension	2018-06-07 14:33:41 +10:00
Sam	89ad2b5900	DEV: Rails 5.2 upgrade and global gem upgrade ... This updates tests to use latest rails 5 practice and updates ALL dependencies that could be updated Performance testing shows that performance has not regressed if anything it is marginally faster now.	2018-06-07 14:21:33 +10:00
Guo Xiang Tan	cb9596e196	Remove invalid hosted-site plugin.	2018-06-07 08:49:19 +08:00
Guo Xiang Tan	aa5805e8b0	Revert "Initialize the v8 context after forking." ... This reverts commit 41c4e32e64.	2018-06-06 14:33:20 +08:00
Régis Hanol	dc61eaad37	FEATURE: new 'min ratio to crop' site setting	2018-06-05 17:13:00 +02:00
Guo Xiang Tan	32c0ff4831	DEV: Install dependencies before running smoke test.	2018-06-05 18:46:41 +08:00
Guo Xiang Tan	41c4e32e64	Initialize the v8 context after forking.	2018-06-05 11:36:38 +08:00
Arpit Jalan	46fc57222f	FEATURE: improve handling of site setting secrets	2018-06-04 21:31:34 +05:30
Arpit Jalan	313ff264f2	use generic example domain	2018-06-01 14:20:41 +05:30
Blake Erickson	7750b30016	FIX: Allow a user to remove their title ... Somewhere there was a regression and a user couldn't remove their own title. If they selected '(none)' in the UI it would say it was saved, but it would not actually be updated in the db.	2018-05-31 17:16:52 -06:00
Neil Lalonde	1a55948525	Version bump to v2.1.0.beta1	2018-05-31 18:29:10 -04:00
Sam	5086fdc76d	FIX: add protection for scss removal during upgrade ... In some cases plugins would remove scss files or change them, but CSS was still calculated based off stale data in old instance cache	2018-05-31 17:02:48 +10:00
Sam	5a8d2b5e45	FIX: rake assets:precompile should be re-runnable	2018-05-31 16:18:01 +10:00
Dax74	5bd38e3a29	Add Github Linkback plugin	2018-05-31 01:02:35 +02:00
Régis Hanol	f10af7e449	FIX: don't generate an exception when trying to cleanup unexisting tmp letter avatars	2018-05-30 15:33:58 +02:00
Guo Xiang Tan	db4af262dc	DEV: Create smoke test screenshot directory in rake task.	2018-05-30 16:20:18 +08:00
Guo Xiang Tan	fe5a48997c	DEV: Store smoke tests failure image in a dedicated tmp folder.	2018-05-30 15:59:07 +08:00
Guo Xiang Tan	543b7cddfb	FIX: Extra comma resulted in Github auth email result being an array. ... https://meta.discourse.org/t/github-2fa-flow-broken/88674	2018-05-30 12:15:12 +08:00
Joshua Rosenfeld	4ad924bcf5	Add discourse-policy as official plugin	2018-05-29 16:57:05 -04:00
Neil Lalonde	1b0a3023bb	fix rake task usage	2018-05-29 16:29:12 -04:00
Vinoth Kannan	a7be1ddf4f	variable name typo	2018-05-28 19:21:06 +05:30
Vinoth Kannan	586e45edb9	FIX: Split by space to support multiple categories export	2018-05-28 19:19:26 +05:30
Guo Xiang Tan	81b5d61fa7	FIX: topic_destroyed web hook couldn't find topic.	2018-05-28 17:38:02 +08:00
Gerhard Schlager	ef84099db1	Add rake task for updating username in posts	2018-05-28 11:25:24 +02:00
Sam	e501936405	FIX: search server side error in rare condition	2018-05-28 15:28:18 +10:00
Sam	c677877e4f	FIX: Korean needs no word segmentation	2018-05-28 09:37:57 +10:00
Régis Hanol	f988fa31aa	FIX: ensure 'notifications_state' is up to date after creating a notification	2018-05-26 02:09:48 +02:00
Régis Hanol	c91071bb2a	FIX: don't 💥 when 'FastImage.size' has trouble with SSL	2018-05-26 00:55:19 +02:00
Gerhard Schlager	20b94bc714	FIX: Extraction of quoted posts failed in some cases ... * It stored only oneboxed "quotes" when [quote] and links to topics or posts were mixed. * Revising a post didn't add or remove records from the quoted_posts table.	2018-05-25 12:00:17 +02:00
Sam	80adc1ee80	DEV: stabilize site setting spec ... side effects could cause specs to fail in rare conditions	2018-05-25 12:16:00 +10:00
Guo Xiang Tan	d43895e2a0	Don't log 404s for FinalDestination. ... * We can't do anything about 404s	2018-05-25 10:11:16 +08:00
Régis Hanol	71f66cd679	FIX: ensure PostAlerter is always run in sidekiq	2018-05-24 17:27:43 +02:00
Guo Xiang Tan	3bfd9698c7	PERF: Avoid running the same query twice in TopicViewSerializer#details.	2018-05-24 16:46:13 +08:00
Andrew Schleifer	4be0e31459	fix s3_cdn_url when the s3 bucket contains a folder	2018-05-23 15:51:02 -05:00
Gerhard Schlager	ea7ffac17e	FIX: Paths used by PrettyText were not always initialized	2018-05-23 22:16:59 +02:00
Ryan Mulligan	fac4bf2f85	ignore emails that are from the reply by email addresses (#5843)	2018-05-23 10:04:45 +02:00
Sam	6974b7d6a8	FIX: run deferred jobs inline in sidekiq	2018-05-23 12:05:37 +10:00
Andrew Schleifer	ff15d95983	FIX s3_helper.list for buckets with folders ... s3_bucket_folder_path does not contain a trailing slash so it was smashingstufftogether	2018-05-22 20:09:08 -05:00
Guo Xiang Tan	ad9e0d6bea	Merge pull request #5848 from OsamaSayegh/fix-social-login-groups ... FIX: apply automatic group rules when using social login providers	2018-05-23 08:17:42 +08:00
OsamaSayegh	f6d412465b	FIX: apply automatic group rules when using social login providers	2018-05-23 02:26:07 +03:00
Sam	db23e10efa	DEV: watch plugin.rb in autospec	2018-05-21 15:19:10 +10:00
jomaxro	be01491c04	Revert "Correct BBCode plugin name" ... This reverts commit 10dfdd7d2a.	2018-05-19 20:03:49 -04:00
Joshua Rosenfeld	10dfdd7d2a	Correct BBCode plugin name	2018-05-19 19:53:39 -04:00
Sam	efe7b6dbc1	DEV: after installing official plugins, install the gems	2018-05-17 17:18:22 +10:00
Sam	0e92dfa818	bump version to beta 10	2018-05-17 12:09:19 +10:00
Régis Hanol	a9ebde5111	FEATURE: new 'staged' users list for admins	2018-05-17 01:52:49 +02:00
Arpit Jalan	2a9b4e4bb5	FIX: do not replace hashtags in URLs	2018-05-17 00:34:17 +05:30
Arpit Jalan	6cd0b7316a	FIX: do not replace twitter handles in URLs	2018-05-17 00:20:11 +05:30
Sam	ff90881238	DEV: fix live refresh if you have a custom theme selected in dev	2018-05-16 17:25:49 +10:00
Gerhard Schlager	a024e5e9ac	Retry on read timeouts while warming up for qunit tests	2018-05-15 21:26:59 +02:00
Régis Hanol	a512b181d9	FIX: automatically in/decrement topic_tags.pm_topic_count	2018-05-15 16:05:48 +02:00
Gerhard Schlager	34d4712133	Smoke test should wait up to 5 minutes before it fails	2018-05-15 14:40:33 +02:00
Régis Hanol	93ed8d2522	PERF: defer user notifications (#5827)	2018-05-15 09:51:32 +02:00
Arpit Jalan	8d6a9eb511	FIX: scrub all settings that has '_secret' in name	2018-05-15 09:37:13 +05:30
Arpit Jalan	abcb6af8f9	FIX: scrub secret setting values from logs	2018-05-15 09:19:26 +05:30
Régis Hanol	2cf6fb7359	FIX: always unstage users when they log in	2018-05-13 17:00:02 +02:00
Gerhard Schlager	f4e9d47a27	Make linter happy	2018-05-13 15:20:39 +02:00
Jay Pfaffman	c9f959f9cb	Add emails:test rake task (#5816)	2018-05-13 14:15:15 +02:00
Régis Hanol	6a006b3646	FIX: format posts for embedded comments as we do for emails	2018-05-09 19:24:44 +02:00
Régis Hanol	86eb3528ec	FEATURE: clearer error message when receiving a reply to an old notification	2018-05-09 18:51:01 +02:00
Régis Hanol	6b1ff0edd3	FIX: always update bounce score (instead of doing it once per day)	2018-05-09 16:40:52 +02:00
Matt Palmer	1ce8b7def8	Run a plugin's integration tests via autospec when anything changes	2018-05-09 12:33:12 +10:00
Guo Xiang Tan	bbc85258c9	Rename display_plugins -> visible_plugins.	2018-05-09 07:52:45 +08:00
Gerhard Schlager	52db0b31c1	FIX: Automatically add user to groups after updating email address	2018-05-08 21:27:22 +02:00
Robin Ward	8262fc5d15	Merge pull request #5807 from discourse/min-flags-by-topic ... FEATURE: New site setting `min_flags_staff_visibility`	2018-05-08 09:17:29 -04:00
Arpit Jalan	e9d92da9ee	minor optimizations to categories:move_topics rake task	2018-05-08 15:14:19 +05:30
Arpit Jalan	62c266f987	add a rake task to move all topics from one category to another	2018-05-08 15:05:56 +05:30
Sam	858a266031	FIX: exact matching should also match on title	2018-05-08 15:59:03 +10:00
Guo Xiang Tan	c6f45fcfdb	Expose an API for plugins to be hidden on the admin plugin page.	2018-05-08 13:24:58 +08:00
Guo Xiang Tan	8cf0f51eb2	UX: Display site settings shortcut for poll and discourse-nginx-performance-report. ... https://meta.discourse.org/t/improving-admin-plugins/84585/29?u=tgxworld	2018-05-08 10:34:32 +08:00
Robin Ward	ac60a84329	FEATURE: New site setting min_flags_staff_visibility ... When set higher than 1, flags won't show up for staff in the admin section unless the minimum threshold of flags on a post is reached.	2018-05-07 16:05:13 -04:00
Régis Hanol	a98aae3bcd	FIX: topic search wasn't working for unlisted topics	2018-05-07 11:43:55 +02:00
Misaka 0x4e21	ff6be3c2e3	FEATURE: add profile_background fields into SSO (#5701) ... Add profile_background and card_background fields into Discourse SSO.	2018-05-07 10:03:26 +02:00
Guo Xiang Tan	0d74c30fa7	Remove more uses of rescue nil.	2018-05-07 11:38:23 +08:00
Régis Hanol	738f3f5229	Load missing libraries for server-side PrettyText	2018-05-05 11:21:07 +02:00
Régis Hanol	bae7203f42	FIX: proper category > subcategory order in List-Id description header	2018-05-05 01:51:53 +02:00
Neil Lalonde	4c9f6e192f	Version bump to v2.0.0.beta9	2018-05-04 15:32:22 -04:00
Sam	c81854ad14	FEATURE: Rename discourse-cronos to discourse-local-dates	2018-05-04 16:11:50 +10:00
Sam	3d6dc764be	needed to remove legacy from a few more spots	2018-05-04 11:12:01 +10:00
Jeff Wong	62a8904729	Feature: Include participants at the bottom of PM emails (#5797) ... * Feature: Include participants at the bottom of PM emails ... as undecorated links. https://meta.discourse.org/t/email-notification-recipients-unclear-when-pm-is-sent-to-multiple-users/26934/13?u=featheredtoast Fix: missing translation for PM mentions * display membership count as `group (count)`	2018-05-03 15:50:06 -07:00
Neil Lalonde	eca7017a2b	Version bump to v2.0.0.beta8	2018-05-03 16:57:15 -04:00
Joffrey JAFFEUX	78435833a5	FEATURE: discourse-cronos is now a core plugin	2018-05-03 20:15:57 +02:00
Régis Hanol	7d223c0e55	FEATURE: add description in 'List-Id' mail headers ... https://meta.discourse.org/t/minor-feature-request-descriptions-in-list-id-headers/86681	2018-05-03 16:39:25 +02:00
Joffrey JAFFEUX	980972182f	dashboard next: caching, mobile support and new charts	2018-05-03 15:41:41 +02:00
Régis Hanol	2d561a0422	FIX: don't extract divs with a 'gmail_default' class	2018-05-03 12:29:21 +02:00
Sam	b7037808bb	PERF: stop using exec which is blocking for direct sql	2018-05-03 15:50:30 +10:00
scossar	a2bc2ca08f	Set catogory text_color for box style	2018-05-02 16:57:35 +10:00
Gerhard Schlager	3be3c50c7e	FEATURE: Rename user in mentions and quotes ... Co-authored-by: Robin Ward <robin.ward@gmail.com>	2018-05-01 13:49:14 -04:00
Joffrey JAFFEUX	1eee517ae2	adds moment-timezone.js to the list of vendorable libs	2018-05-01 16:00:05 +02:00
Joffrey JAFFEUX	691174fa8f	FEATURE: adds emoji search aliases	2018-05-01 15:43:49 +02:00
Joffrey JAFFEUX	9e7150a2ad	Revert "add a few emoji aliases" ... This reverts commit d942bf6282.	2018-05-01 11:04:26 +02:00
Sam	d942bf6282	add a few emoji aliases	2018-05-01 15:07:59 +10:00
Robin Ward	93b40d5e59	Don't use puts here since it happens in tests	2018-04-30 12:26:43 -04:00
Neil Lalonde	f7c4c71409	FIX: title selector needs to flag whether title comes from badge or not	2018-04-26 16:51:11 -04:00
Jeff Atwood	00a0a9ac52	Merge pull request #5791 from yanokwa/patch-1 ... Correct spelling errors	2018-04-26 13:02:55 -07:00
Neil Lalonde	e52d914c08	add discourse-user-card-badges to official plugins	2018-04-26 15:28:06 -04:00
Yaw Anokwa	02cd035164	Correct spelling errors	2018-04-26 09:46:32 -07:00
Joffrey JAFFEUX	0732c69f73	updates moment.js 2.22.1 and vendor moment-timezone 0.5.14	2018-04-26 09:15:53 +02:00
Sam	88f5251415	FIX: disallow invalid top_menu and post_menu and share_links ... In the past any text could be entered there causing big potential issues	2018-04-26 17:00:56 +10:00
Sam	c7a0ced656	FIX: remove facebook_request_extra_profile_details ... Since this no longer works	2018-04-26 14:14:35 +10:00
Sam	98d142b1c1	also causes test failure, removing	2018-04-26 13:48:44 +10:00
Sam	0a82d739f9	unofficialize plugin	2018-04-26 13:23:14 +10:00
Sam	4ded5e18e6	add more official plugins	2018-04-26 12:33:07 +10:00
Robin Ward	a5172a37e0	Allow staff members to enable safe mode, even if disabled	2018-04-25 11:49:57 -04:00
Gerhard Schlager	afe1a2793d	Mark discourse-signatures plugin as official	2018-04-25 11:58:39 +02:00
Guo Xiang Tan	0e38481d6d	Add docker_manager to official plugin list.	2018-04-25 13:02:50 +08:00
Sam	aad7df2a1b	correct return value	2018-04-25 08:44:07 +10:00
Neil Lalonde	18c27883e9	Version bump to v2.0.0.beta7	2018-04-24 11:13:52 -04:00
Sam	035312d501	FIX: specify path for dosp cookie	2018-04-24 11:07:58 -04:00
Guo Xiang Tan	bf6e548692	Remove plugin that is internal to us.	2018-04-24 11:07:49 -04:00
Joffrey JAFFEUX	42a848f88f	linting	2018-04-23 10:26:33 +02:00
Régis Hanol	69c32a2651	Refresh site settings after a remap	2018-04-23 09:57:13 +02:00
Guo Xiang Tan	c148500d51	FIX: Deadlock when topic with auto close topic timers exceeds auto_close_topics_post_count.	2018-04-23 13:34:24 +08:00
Sam	6a0aeae91b	DEV: clean up JavaScript testing ... - Unify runner for autospec and qunit:test - Report on slowest 30 tests - Use async await instead of promise tower	2018-04-23 14:43:04 +10:00
Sam	ded84a4b58	PERF: improve performance once logged in rate limiter hits ... If "logged in" is being forced anonymous on certain routes, trigger the protection for any requests that spend 50ms queueing This means that ... 1. You need to trip it by having 3 requests take longer than 1 second in 10 second interval 2. Once tripped, if your route is still spending 50m queueuing it will continue to be protected This means that site will continue to function with almost no delays while it is scaling up to handle the new load	2018-04-23 11:55:25 +10:00
Guo Xiang Tan	80847d83a8	Mark discourse-voting and discourse-staff-notes as official.	2018-04-23 09:26:13 +08:00
Sam	86c1457c40	correct typo	2018-04-23 10:55:38 +10:00
Neil Lalonde	70f2c5d3fd	FEATURE: move staff tags setting to tag group settings	2018-04-20 15:34:23 -04:00
Robin Ward	cfcdc4b420	Output when a locale is invalid	2018-04-20 15:29:18 -04:00
Guo Xiang Tan	45fe5dc793	$redis.client -> $redis._client. ... See c239abb43c	2018-04-20 13:01:17 +08:00
Arpit Jalan	91bf10bd12	FIX: create upload record for exported csv files	2018-04-20 00:27:49 +05:30
Régis Hanol	2b0e505121	Extract signatures from emails sent with Newton	2018-04-19 12:39:55 +02:00
Neil Lalonde	5b93d69939	FIX: error when non-staff user edits their topic after a hidden tag is added to it	2018-04-18 12:51:25 -04:00
Sam	4810ce3607	correct regression	2018-04-18 21:04:08 +10:00
Sam	59cd7894d9	FEATURE: if site is under extreme load show anon view ... If a particular path is being hit extremely hard by logged on users, revert to anonymous cached view. This will only come into effect if 3 requests queue for longer than 2 seconds on a *single* path. This can happen if a URL is shared with the entire forum base and everyone is logged on	2018-04-18 16:58:57 +10:00
Arpit Jalan	3566c6f02b	FIX: strip emoji string from slug	2018-04-18 11:32:32 +05:30
Neil Lalonde	8fc1289172	move topic excerpt code to one method to DRY it up and for extensibility	2018-04-17 15:08:21 -04:00
Neil Lalonde	b87fa6d749	FIX: blacklisted crawlers could get through by omitting the accept header	2018-04-17 12:39:30 -04:00
Régis Hanol	2585ada5ca	FIX: don't allow spaces in 'reply_by_email_address' site setting	2018-04-17 17:08:12 +02:00
Guo Xiang Tan	ad4c25e004	PERF: Only save site setting if values have been changed.	2018-04-17 21:07:39 +08:00
Sam	9980f18d86	FEATURE: track request queueing as early as possible	2018-04-17 18:06:17 +10:00
Guo Xiang Tan	1b9a38c5e2	FIX: Incorrect formatter used when logstash formatter is enabled.	2018-04-17 12:07:52 +08:00
Régis Hanol	001b0710c7	FIX: don't add diff classes more than once	2018-04-16 15:41:45 +02:00
Arpit Jalan	c74c933996	SECURITY: escape HTML entities from topic title	2018-04-15 18:44:28 +05:30
Arpit Jalan	0183656631	FIX: verify filtered tags when checking for category minimum required tags	2018-04-14 23:20:43 +05:30
Régis Hanol	fe32733a57	extract signatures from emails sent using Zimbra	2018-04-13 19:04:27 +02:00
Neil Lalonde	e8d35653ae	Version bump to v2.0.0.beta6	2018-04-13 10:47:01 -04:00
Régis Hanol	a0a06492d8	FIX: make get_hostname more lenient to user input	2018-04-12 17:09:09 +02:00
Régis Hanol	3c8b43bb01	FIX: non-oneboxed links on separate lines should stay on separate lines	2018-04-11 21:33:45 +02:00
Sam	f0803e9611	sleep here is a better fit	2018-04-11 16:46:27 +10:00
Sam	be0366d587	add debugging for docker test	2018-04-11 16:39:39 +10:00
Arpit Jalan	48d43b33cc	add client side validation for category minimum_required_tags	2018-04-11 07:17:52 +05:30
Arpit Jalan	9ca6ebe8fe	FEATURE: enforce tagging on categories	2018-04-11 07:15:24 +05:30
Gerhard Schlager	64f2086cca	rake task should allow reordering posts of single topic	2018-04-10 13:52:08 +02:00
Joffrey JAFFEUX	45f657336e	FEATURE: adds support for loading existing core asset in pretty text	2018-04-10 08:37:16 +02:00
Guo Xiang Tan	874003b7b1	FIX: Group can't be deleted if certain users are demoted.	2018-04-10 14:19:35 +08:00
Sam	afaeb20f27	FEATURE: Add option to have sso synchronize group membership ... In some cases add_groups and remove_groups is too much work, some sites may wish to simply synchronize group membership based on a list. When sso_overrides_groups is on all not automatic group membership is sourced from SSO. Note if you omit to specify groups, they will be cleared out.	2018-04-10 13:17:23 +10:00
Arpit Jalan	adb93716ca	FIX: rake task should rebake posts in descending ID order	2018-04-10 00:18:49 +05:30
Gerhard Schlager	62aacce8f4	FEATURE: Notify flaggers when flagged post is edited by author	2018-04-09 16:45:33 +02:00
Arpit Jalan	cd66dd1404	fix admin rake task	2018-04-07 16:57:17 +05:30
Neil Lalonde	f6cfff3cea	UX: user preferences allows users to choose which title to use from their badges and groups	2018-04-06 14:34:36 -04:00
jose-hms	b87205831b	FEATURE: Staged user moderation (#5721)	2018-04-06 11:41:25 +02:00
Angus McLeod	fa7ddf7238	Add wizard_js to translations that can be overridden from a plugin	2018-04-06 11:34:25 +02:00
Guo Xiang Tan	2ddcdf8704	UX: Add an icon to indicate if a plugin is official. ... https://meta.discourse.org/t/improving-admin-plugins/84585	2018-04-06 10:54:58 +08:00
Guo Xiang Tan	5da7c2a4ad	FIX: Restorer wasn't rolling back if restore fails. ... * This only applies to backup file taken with pg_dump 10.3+ and pg_dump 9.5.12+.	2018-04-06 09:43:32 +08:00
Robin Ward	e27edfe597	FIX: Don't give two errors about not being able to post links	2018-04-05 12:54:48 -04:00
Gerhard Schlager	35efdb39b3	FEATURE: Show the current reply count of the flagged post	2018-04-05 14:03:02 +02:00
Gerhard Schlager	f2d00e5eff	FEATURE: Use Message-ID for detecting email replies to group ... Ignores the site setting "find_related_post_with_key" and always tries to honor the `In-Reply-To` and `References` header for emails sent to a group. The senders email address must be included in the `To` or `CC` header of a previous email sent to the group and the `Message-ID` of that email must be included in the current email's `In-Reply-To` or `References` header.	2018-04-05 11:00:38 +02:00
Arpit Jalan	10759677db	FIX: when uploading image newuser restrictions should not apply to staff	2018-04-05 09:51:03 +05:30
Sam	0d6cfe45bf	tl1 should be enough for grant admin. tl4 is hard to revert	2018-04-05 10:53:11 +10:00
Guo Xiang Tan	4f7f733ab0	Upgrade docker:test to use PG 10.	2018-04-04 10:28:23 +08:00
Sam	f1ef46d7b7	FIX: unable to import private themes due to key checking	2018-04-03 16:11:03 +10:00
Guo Xiang Tan	142571bba0	Remove use of rescue nil. ... * `rescue nil` is a really bad pattern to use in our code base. We should rescue errors that we expect the code to throw and not rescue everything because we're unsure of what errors the code would throw. This would reduce the amount of pain we face when debugging why something isn't working as expexted. I've been bitten countless of times by errors being swallowed as a result during debugging sessions.	2018-04-02 13:52:51 +08:00
Blake Erickson	31ce955487	Add destroy rake task ... Adds several rake tasks to delete users, topics, pm's and site stats so that you can have a fresh site but maintain site settings and category structure.	2018-03-30 18:32:21 -06:00
Régis Hanol	a0386655a6	Add support to elide content from ProtonMail emails	2018-03-30 10:41:32 +02:00
Gerhard Schlager	cf9965fd54	Add rake task for reordering posts by creation_date	2018-03-29 14:42:41 +02:00
Robin Ward	eab64710ff	FIX: Shared draft performance fix + missing avatars	2018-03-28 16:11:43 -04:00
Robin Ward	4b5977aa6a	Revert "PERF: Don't join on shared drafts unless you have to" ... This reverts commit efedd9745f.	2018-03-28 15:35:13 -04:00
Robin Ward	a8f211bd41	Extensibility for custom staff check	2018-03-28 14:48:14 -04:00
Robin Ward	efedd9745f	PERF: Don't join on shared drafts unless you have to	2018-03-28 13:57:39 -04:00
Régis Hanol	9e7d5a3cdf	FIX: 'uploads:recover_from_tombstone' rake task wasn't restoring attachments	2018-03-28 15:51:47 +02:00
Guo Xiang Tan	ee69d58a59	FIX: Tests could get stucked in infinite loop if it fails to resolve IP of a hostname.	2018-03-28 14:49:05 +08:00
Neil Lalonde	7311023a52	Merge pull request #5700 from discourse/crawl-block ... FEATURE: control web crawlers access with white/blacklist	2018-03-27 15:06:03 -04:00
Neil Lalonde	4d12ff2e8a	when writing cache, remove elements from the user agents list. also return a message and content type when blocking a crawler.	2018-03-27 13:44:14 -04:00
Gerhard Schlager	fcd352e089	FIX: Try fixing unparsable email addresses ... The mail gem returns `UnstructuredField` when it fails to parse email addresses, but the `Receiver` always expects an `AddressList`.	2018-03-27 18:28:54 +02:00
Gerhard Schlager	b945a2dc39	Call on_drop only when tables/columns are dropped	2018-03-27 13:18:13 +11:00
Gerhard Schlager	4ad401bac5	Ignore delay when first migration was < 10min ago	2018-03-27 13:18:13 +11:00
Gerhard Schlager	19c5afc69d	Protect against accidental table renames	2018-03-27 13:18:13 +11:00
Neil Lalonde	f2c060bdf2	FEATURE: option for tags in a tag group to be visible only to staff	2018-03-26 17:05:09 -04:00
Robin Ward	f03b6bd8c9	FIX: Update last_version_at when publishing	2018-03-26 16:06:20 -04:00
Robin Ward	d4296f33ff	FIX: Publishing should update the public_version too	2018-03-26 15:46:25 -04:00
Neil Lalonde	09ea27ed89	Version bump to v2.0.0.beta5	2018-03-26 11:22:52 -04:00
Robin Ward	2b161a2391	FIX: Don't include shared drafts in global latest	2018-03-26 10:43:55 -04:00
Arpit Jalan	b75b6de982	FIX: respect nofollow settings for onebox links	2018-03-26 18:21:16 +05:30
Régis Hanol	c5c1d8e180	Add support for the '/p/:post_id' route on the client-side	2018-03-24 02:44:39 +01:00
Blake Erickson	9fdf139235	Add tests for Site Settings import/export ... - extracted out site settings rake task to a class - added tests for import and export of site settings	2018-03-23 14:55:17 -06:00
Arpit Jalan	17584bca5e	UX: wrap full-size Twitter onebox images in aspect-ratio	2018-03-23 18:25:04 +05:30
Arpit Jalan	9a184b355d	Merge pull request #5696 from techAPJ/instagram-aspect-image ... UX: wrap instagram images with aspect ratio	2018-03-23 04:00:52 +05:30
Neil Lalonde	a84bb81ab5	only applies to get html requests	2018-03-22 17:57:44 -04:00
Robin Ward	c686ae8d8f	FIX: Ambiguous column name	2018-03-22 16:38:53 -04:00
Robin Ward	41fc8e32e2	FIX: N+1 query for shared drafts	2018-03-22 16:24:30 -04:00
Neil Lalonde	ced7e9a691	FEATURE: control which web crawlers can access using a whitelist or blacklist	2018-03-22 15:41:02 -04:00
Arpit Jalan	33c1aeb2ac	UX: wrap instagram images with aspect ratio	2018-03-22 21:35:10 +05:30
Joffrey JAFFEUX	e053697cfa	FEATURES: updates emojis and adds support for more women emojis!	2018-03-22 11:08:06 +01:00
Guo Xiang Tan	f3b402ffd5	UX: Allow users to filter members on group page. ... * Only admins are allowed to filter users by email.	2018-03-22 14:02:41 +08:00
Arpit Jalan	d96c1058a2	FEATURE: add staff action log for 'restore topic'	2018-03-21 18:04:13 +05:30
Gerhard Schlager	eebe1d8c56	Allow delayed dropping and renaming of tables	2018-03-21 12:05:12 +01:00
Sam	6a3c8fe69c	FEATURE: protect against accidental column or table drops ... Often we need to amend our schema, it is tempting to use drop_table, rename_column and drop_column to amned schema trouble though is that existing code that is running in production can depend on the existance of previous schema leading to application breaking until new code base is deployed. The commit enforces new rules to ensure we can never drop tables or columns in migrations and instead use Migration::ColumnDropper and Migration::TableDropper to defer drop the db objects	2018-03-21 15:43:32 +11:00
Robin Ward	b9abd7dc9e	FEATURE: Shared Drafts ... This feature can be enabled by choosing a destination for the `shared drafts category` site setting. * Staff members can create shared drafts, choosing a destination category for the topic when it is published. * Shared Drafts can be viewed in their category, or above the topic list for the destination category where it will end up. * When the shared draft is ready, it can be published to the appropriate category by clicking a button on the topic view. * When published, Drafts change their timestamps to the current time, and any edits to the original post are removed.	2018-03-20 17:15:26 -04:00
Michael Brown	63a1e9b60a	backup restorer: tidy pg_dump schema portability logic, add test	2018-03-20 10:32:39 +08:00
Neil Lalonde	6ca71e1319	FIX: when creating a topic in a category that only allows tags from a tag group, don't allow creation of new tags	2018-03-19 11:42:10 -04:00
Vinoth Kannan	c5d26992d4	Prefer to use primary email for new user creation over other available emails	2018-03-19 17:10:35 +05:30
Guo Xiang Tan	ec57ca54b5	FEATURE: Admins should be able to view PMs of any group.	2018-03-19 14:12:01 +08:00
Guo Xiang Tan	52b9af10a1	PERF: PG queries for the UserEmail#email column was not using the index.	2018-03-19 11:31:14 +08:00
Guo Xiang Tan	da8e15f954	FIX: Restorer was not extracting the patch version in dump file.	2018-03-16 11:09:56 +08:00
Michael Brown	90291318eb	restorer: clarify logging	2018-03-15 12:14:08 -04:00
Vinoth Kannan	58bb3967e5	SECURITY: Oneboxer should escape the URL before processing	2018-03-15 19:57:55 +05:30
Guo Xiang Tan	a35227918f	UX: Display group topics in a topic list.	2018-03-15 11:37:55 +08:00
Régis Hanol	20ba54d536	FIX: extracting mail content from exchange emails	2018-03-14 22:02:43 +01:00
Robin Ward	135195363b	FIX: Not logging old post contents properly	2018-03-14 15:01:36 -04:00
Guo Xiang Tan	58b8ea4f41	Upgrade mail gem to remove dependency on mime-types. ... * Use a EmailValidator.email_regexp for `Email.is_valid?` check as we're seeing an increase in allocation when parsing email addresses wih `Mail::Address`.	2018-03-14 14:37:55 +08:00
Neil Lalonde	6b13fbccc2	tag-choosers with everyTag should also be able to get more results	2018-03-13 17:17:16 -04:00
Neil Lalonde	58508e553d	FIX: tag input should not include tags you've already chosen in the search results	2018-03-13 17:17:16 -04:00
Robin Ward	c75fd34328	Allow Discourse installs to name the token cookie	2018-03-13 16:48:40 -04:00
Robin Ward	31a0c4a9be	FEATURE: Add quote-modified class if a quote has been modified	2018-03-13 13:41:06 -04:00
Arpit Jalan	7d375690c1	Merge pull request #5667 from techAPJ/pm-tags-page ... FEATURE: replace PM tags dropdown with a dedicated tags page	2018-03-13 13:08:21 +05:30
Arpit Jalan	24338fbbe8	FEATURE: replace PM tags dropdown with a dedicated tags page	2018-03-13 13:06:58 +05:30
Guo Xiang Tan	a9713ca20b	REFACTOR: Always prefer to raise an error if record fails to save.	2018-03-13 12:01:01 +08:00
Guo Xiang Tan	2ad2ed2eb2	FIX: Couldn't move a topic into the uncategorized category.	2018-03-13 10:20:47 +08:00
Robin Ward	65ac80b014	FEATURE: Log Staff edits in Staff Action Logs ... Why? Some edits by staff are not tracked. For example, during the grace period, or via the flags/silence dialog. If a staff member is editing someone else's post, it now goes into the Staff Action Logs so it can be audited by other staff members.	2018-03-12 13:51:40 -04:00
Gerhard Schlager	d243b82fb3	FIX: Calculation of text length for <details> in excerpt was wrong	2018-03-12 16:55:23 +01:00
Guo Xiang Tan	5782a23a69	Allow uploads:missing to skip optimized image check.	2018-03-12 20:08:53 +08:00
Gerhard Schlager	ec3a2d2762	Stop retrying tests three times if qunit tests fail ... Warming up the Rails server should be enough	2018-03-12 12:51:26 +01:00
Arpit Jalan	345b453ee1	optimize query for fetching PM created in previous hour	2018-03-12 16:40:17 +05:30
Sam	758b9a7dda	FEATURE: prototype of local theme directory watcher ... (note this will be documented a bit late)	2018-03-12 18:36:06 +11:00
Arpit Jalan	3a35f459c7	optimize last pm log fetching	2018-03-11 09:34:08 +05:30
Arpit Jalan	f862122978	FIX: do not log personal message view if there exists a similar log in previous hour	2018-03-11 09:23:32 +05:30
Guo Xiang Tan	5ef75c9c61	Improve grep pattern in restorer.	2018-03-09 15:48:12 +08:00
Guo Xiang Tan	766b41d9f4	Fix version check in restorer.	2018-03-09 15:01:10 +08:00
Sam	800760e353	also watch CSS in unicorn on dev	2018-03-09 17:47:57 +11:00
Guo Xiang Tan	8fd47314d9	FIX: Restore process for dump taken with pg_dump 10.3+. ... * Since we can no longer restore into a different schema, we will move tables in the public schema into the backup schema first before restoring the dump file which goes into the public schema. The downside to this approach is that we will increase the downtime experienced during the restore process. Downtime would equal the duration of restoring the dump file.	2018-03-09 13:24:58 +08:00
Sam	39e679d3cb	FEATURE: allow themes to live in private git repos ... This feature allows themes sourced from git to live on private servers, it automatically generates key pairs.	2018-03-09 16:14:38 +11:00
Guo Xiang Tan	a89f3160a5	Add new config to ensure backup/restore connects to PG directly. ... * In `pg_dump` 10.3+ and 9.5.12+, in it does a `SELECT pg_catalog.set_config('search_path', '', false)` which changes the state of the current connection. This is known to be problematic with Pgbouncer which reuses connections. As such, we'll always try to connect directly to PG directly during the backup/restore process.	2018-03-09 10:28:03 +08:00
Sam	5b6e49ae1d	FEATURE: split out max diff to 2 settings ... We trust staff + tl2 and up to perform edits in grace period. Allow them significantly more edit room in grace period prior to storing a revision. editing_grace_period_max_diff_high_trust applies to users with tl2 and up. So tl0 / 1 : we store an extra revision if more than 100 chars change tl2 and up : we store an extra revision if more than 400 chars change We may tweak these numbers as we go.	2018-03-09 11:58:50 +11:00
Arpit Jalan	0c2be8b775	Merge pull request #5655 from techAPJ/pm-tags-dropdown ... FEATURE: filter personal messages by tags	2018-03-08 16:30:38 +05:30
Arpit Jalan	a8149f8969	FIX: user should not be able to invite to PM if trust level requirment not met ... FIX: when personal messages are disabled let user invite to a public topic	2018-03-08 14:59:04 +05:30
Arpit Jalan	c29660c8f1	FEATURE: filter personal messages by tags	2018-03-08 14:42:07 +05:30
Guo Xiang Tan	152f64a18b	Trigger is dropped along with the table.	2018-03-08 15:28:00 +08:00
Guo Xiang Tan	9dc72537e5	FIX: TableMigrationHelper didn't clean up after itself.	2018-03-08 15:10:05 +08:00
Neil Lalonde	a8f825d6a9	Version bump to v2.0.0.beta4	2018-03-07 15:18:26 -05:00
Sam	e162cd16b6	FEATURE: editing_grace_period_max_diff to force revisions in grace period ... If a user performs a substantive edit of 20 chars or more during grace period we will store a revision to track the change This allows for better auditing of changes that happen during the grace period	2018-03-07 18:34:34 +11:00
Guo Xiang Tan	76e2b6c825	Add "discourse-assign" to the list of official plugins.	2018-03-06 21:45:37 +08:00
Guo Xiang Tan	7068b90c01	Merge pull request #5651 from tgxworld/live_update_group_messages ... Live update group messages	2018-03-06 18:55:13 +08:00
Gerhard Schlager	832f0a9c4d	FIX: Typo prevented extraction of email signatures	2018-03-06 11:34:47 +01:00
Guo Xiang Tan	1365bab0d7	FEATURE: Live updates for user's messages page. ... https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189	2018-03-06 18:15:21 +08:00
Sam	0134e41286	FEATURE: detect when client thinks user is logged on but is not ... This cleans up an error condition where UI thinks a user is logged on but the user is not. If this happens user will be prompted to refresh.	2018-03-06 16:49:31 +11:00
Sam	f0d5f83424	FEATURE: limit assets less that non asset paths ... By default assets can be requested up to 200 times per 10 seconds from the app, this includes CSS and avatars	2018-03-06 15:20:39 +11:00
Robin Ward	17a615165c	FIX: Don't lock wiki posts when they're edited	2018-03-05 14:50:06 -05:00
Arpit Jalan	003b03d939	allow staff to delete user if posts are 5 or less irrespective of delete_user_max_post_age	2018-03-05 23:31:29 +05:30
Joffrey JAFFEUX	ce1994beea	FIX: do not treat :: as a valid emoji	2018-03-05 15:35:24 +01:00
Guo Xiang Tan	2f65393706	REFACTOR: Use Topic#private_message? to reduce duplication.	2018-03-05 15:39:22 +08:00
OsamaSayegh	282f53f0cd	FEATURE: Theme settings (2) (#5611) ... Allows theme authors to specify custom theme settings for the theme. Centralizes the theme/site settings into a single construct	2018-03-04 19:04:23 -05:00
Robin Ward	cd6c5fc5fb	FIX: Disable "Make Personal Message" if they are disabled	2018-03-02 20:28:39 -05:00
Régis Hanol	6a78669ca3	FIX: 'reply by email addresses' site settings should allow email addresses without a 'reply_key' when 'find related post with key' is disabled	2018-03-02 17:53:18 +01:00
Robin Ward	b3883f5c32	FIX: Don't lock a post on edit unless the raw changes	2018-03-01 20:40:19 -05:00
Sam	75172024ca	SECURITY: ensure users have permission when moving categories	2018-03-02 12:13:27 +11:00
Régis Hanol	482c615ef8	FEATURE: extract signatures from most popular email services/software	2018-03-02 01:51:15 +01:00
Will Jordan	a41446a502	single quote password in restore command ... > Followup to #3283. Quotes passwords passed to shell for backup restore.	2018-03-01 12:08:35 -08:00
Gerhard Schlager	7a2183e8ab	FEATURE: rake task for merging users	2018-03-01 12:28:12 +01:00
Guo Xiang Tan	fb75f188ba	FEATURE: Disallow login via omniauth when user has 2FA enabled.	2018-03-01 15:47:07 +08:00
Guo Xiang Tan	81ca3677f7	Add guard for nil in our RateLimiter.	2018-03-01 13:20:42 +08:00
Guo Xiang Tan	5d9f9c2614	FIX: RateLimiter max of zero or less should raise rate limit exceeded.	2018-03-01 13:14:46 +08:00
Neil Lalonde	baf1c385eb	UX: when a post is blocked due to a watched word, message includes the word being blocked	2018-02-28 11:22:18 -05:00
Guo Xiang Tan	e7a7356986	Remove ancient votes code that is no longer used.	2018-02-28 14:37:22 +08:00
Guo Xiang Tan	902c5d11cf	FIX: Don't allow other flag actions after notify_moderator has happened. ... https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5	2018-02-28 11:27:56 +08:00
Sam	f295a18e94	FIX: stop double counting net calls in logs	2018-02-28 10:45:11 +11:00
Sam	2a7b7add59	oops	2018-02-28 09:35:46 +11:00
Sam	182aaffbd5	Keep second semantics for method	2018-02-28 09:21:38 +11:00
Robin Ward	33340071e7	FIX: Use 60 minutes, not 60 seconds for column dropper	2018-02-27 16:45:20 -05:00
Régis Hanol	3c430a3949	FEATURE: begone gmail signatures!	2018-02-27 15:19:34 +01:00
Régis Hanol	73ee62f55f	FEATURE: automatically elide forwarded emails and signature from outlook	2018-02-27 15:00:50 +01:00
Gerhard Schlager	4a54c09e46	FIX: Retry with GET request when HEAD fails with error 400	2018-02-27 12:07:16 +01:00
Guo Xiang Tan	cb0c443343	Merge pull request #5615 from jjaffeux/puke ... Adds :puke: as alias to :face_vomiting:	2018-02-27 10:20:54 +08:00
Régis Hanol	fd33090646	FEATURE: automatically elides gmail quotes	2018-02-26 23:54:02 +01:00
Régis Hanol	26d5ae61dd	FIX: handle <pre> inside <blockquote> in html_to_markdown	2018-02-26 23:28:02 +01:00
Neil Lalonde	3313072957	Remove censored_pattern site setting, which is replaced by watched words	2018-02-26 16:29:27 -05:00
Régis Hanol	3be0294465	FIX: local post onebox was always pointing to 1st post	2018-02-26 16:05:35 +01:00
Régis Hanol	7d7f6faf40	FIX: properly render emojis in local oneboxes	2018-02-26 11:16:53 +01:00
Sam	b301c9f6c1	more prep work for jRuby	2018-02-26 10:25:58 +11:00
Arpit Jalan	b9a669ba32	FIX: do not log personal message view if user can't see the message	2018-02-25 22:39:25 +05:30
Joffrey JAFFEUX	aa990604c5	Adds :puke: as alias to :face_vomiting:	2018-02-24 17:11:04 +01:00
Régis Hanol	0559a4736a	FIX: don't double request when downloading a file	2018-02-24 12:35:57 +01:00
Arpit Jalan	a1ea477604	rescue error when cleaning avatars	2018-02-23 18:15:55 +05:30
Robin Ward	69af881f7f	New site setting trusted_users_can_edit_others ... The default is true to keep with previous discourse behavior. If disabled, high trust level users cannot edit the topics or posts of other users.	2018-02-22 20:39:24 -05:00
Guo Xiang Tan	24d0a7a4c7	Take 2 on f74d6bb605. ... New options are left out by default when not configured so that an incorrect default configuration doesn't blow up google oauth for everyone.	2018-02-23 07:53:01 +08:00
Guo Xiang Tan	dd26bbe868	Merge pull request #5610 from discourse/pm-tags ... FEATURE: Allow staffs to tag PMs	2018-02-23 07:07:41 +08:00
Joffrey JAFFEUX	1c790ae6bc	Revert "Add prompt and HD settings to the Google OAuth2 plugin." ... This reverts commit f74d6bb605.	2018-02-22 19:17:02 +01:00
Régis Hanol	ca1fd774a1	Revert "WIP" ... This reverts commit 2cf5479678.	2018-02-22 18:15:42 +01:00
Régis Hanol	2cf5479678	WIP	2018-02-22 17:56:56 +01:00
Vinoth Kannan	7cbda949f1	REFACTOR: New spec tests and code improvement	2018-02-22 20:27:02 +05:30
Felix Wolfsteller	c302c28a7d	Switch ids in References-Header field of mails. (#5567) ... This change allows email-clients to show threaded views of mails as expected. Apparently most algorithms expect the message ids of mails in the Reference-header-field to be sorted such that they build a traversal through the thread, so the oldest (original) message being first, then its child, grandchild and so on until it arrives at the message id that the "new" mail (that is to be sent) is the reply to. MSGA [1] +- Re: MSGA [1-1] | +- Re: Re: MSGA [1-2-1] | +- Re: Re: MSGA [1-2-2] +- Re: MSGA [1-1] If the stuff in brackets would be the message ID, the References-Header field of a message that is a reply to [1-2-1] should look like: References: 1, 1-1, 1-2-1 Discussion took place in: https://meta.discourse.org/t/e-mail-threading-in-ml-mode-does-not-work-in-thunderbird Main information taken from: https://www.jwz.org/doc/threading.html	2018-02-22 10:48:23 +01:00
Geoffrey Challen	f74d6bb605	Add prompt and HD settings to the Google OAuth2 plugin.	2018-02-22 12:29:19 +08:00
Vinoth Kannan	84867c1c07	Rename site setting to allow_staff_to_tag_pms from allow_staff_to_tag_in_pm	2018-02-22 06:48:34 +05:30
Guo Xiang Tan	1b04d881c5	UX: Display lock icon in admin user lists when user has 2FA enabled.	2018-02-22 09:00:09 +08:00
Sam	720e1965e3	FEATURE: add category suppress from latest ... In the past we used suppress_from_homepage, it had mixed semantics it would remove from category list if category list was on home and unconditionally remove from latest. New setting explicitly only removes from latest list but leaves the category list alond	2018-02-22 09:56:35 +11:00
Vinoth Kannan	2b509eaa91	Merge branch 'master' into pm-tags	2018-02-21 23:55:59 +05:30
Vinoth Kannan	776ab73a8d	FIX: can_tag method called without guardian variable	2018-02-21 21:22:56 +05:30
Vinoth Kannan	84ce1acfef	FEATURE: Allow staffs to tag PMs	2018-02-21 20:11:46 +05:30
Guo Xiang Tan	8964e75ad6	Merge pull request #5612 from discourse/featheredtoast-two-factor-login ... Featheredtoast two factor login	2018-02-21 15:00:10 +08:00
Sam	26450f7587	allow for no lograge ... (fixes tests)	2018-02-21 15:40:37 +11:00
Sam	ca1a3f37e3	FEATURE: add instrumentation for all external net calls	2018-02-21 15:20:29 +11:00
Jeff Wong	f4f8a293e7	FEATURE: Implement 2factor login TOTP ... implemented review items. Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds. I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail. Translatable texts. Move second factor logic to a helper class. Move second factor specific controller endpoints to its own controller. Move serialization logic for 2-factor details in admin user views. Add a login ember component for de-duplication Fix up code formatting Change verbiage of google authenticator add controller tests: second factor controller tests change email tests change password tests admin login tests add qunit tests - password reset, preferences fix: check for 2factor on change email controller fix: email controller - only show second factor errors on attempt fix: check against 'true' to enable second factor. Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP add two factor to email signin link rate limit if second factor token present add rate limiter test for second factor attempts	2018-02-21 09:04:07 +08:00
Robin Ward	3ea272f4f1	New setting: minimum trust level to embed images in a post	2018-02-20 20:00:06 -05:00
Régis Hanol	0799831dbe	FIX: use the avatar of the post rather than the topic in local oneboxes	2018-02-20 19:49:39 +01:00
Arpit Jalan	a4bc54a686	FIX: strip zero width spaces from topic title	2018-02-21 00:12:39 +05:30
Sam	de5418a905	correct search in topic list	2018-02-20 20:47:44 +11:00
Sam	86d12bd44b	FEATURE: search within title using in:title ... Also - Significantly improved search ranking, title is treated most strongly - Adds tag names to the index - Run search re-indexer more aggressively - Re-index topic and all posts on category change	2018-02-20 14:41:21 +11:00
Guo Xiang Tan	e5cec28eae	FIX: Stylesheet::Manager.stylesheet_link_tag cache should account for Discourse.current_hostname.	2018-02-20 09:53:15 +08:00
Régis Hanol	60ec483caa	FIX: include title in local onebox when linking to a different topic	2018-02-19 22:40:14 +01:00
Arpit Jalan	c419c26f56	FEATURE: new site setting 'max_emojis_in_title'	2018-02-19 18:15:26 +05:30
Gerhard Schlager	b6277e208b	FIX: Cookies header didn't have the right format	2018-02-19 12:46:57 +01:00
OsamaSayegh	f3815cd785	FEATURE: New site setting for additional allowed filetypes for staff (#5364) ... * FEATURE: New site setting for additional allowed filetypes for staff * Problematic variable name * feedback * small issues * fix indentation * failing tests * Remove message bus and fix minor issues * Missed this message bus	2018-02-19 10:44:24 +01:00
Leo McArdle	5d9d0fcb4f	FEATURE: add setting which adds group name to PM email subject (#5475)	2018-02-19 10:20:17 +01:00
Sam	a3c7ee09b6	FIX: ruby bench not working properly ... - Remove thin which is no longer supported - Bypass admin api rate limiting in profile environment - Admin password was too short - Run by default in concurrency 1 mode - A skip bundle assets flag to speed up local testing	2018-02-19 11:37:16 +11:00
Régis Hanol	61930e092a	FIX: support incoming emails with just an attachment	2018-02-16 18:14:56 +01:00
Régis Hanol	93b1829f04	tiny refactor	2018-02-16 11:21:11 +01:00
Blake Erickson	49ad983050	fix extra blank line	2018-02-15 16:54:22 -07:00
Blake Erickson	925d1a7869	FEATURE: add rake task for import/export of site settings	2018-02-15 16:23:42 -07:00
Neil Lalonde	322aa9ed85	Version bump to v2.0.0.beta3	2018-02-15 17:48:34 -05:00
Sam	cda3f72ab8	SECURITY: don't onebox whispers	2018-02-16 08:57:20 +11:00
Sam	57e140dc07	FIX: oneboxing to private messages	2018-02-16 08:00:22 +11:00
Régis Hanol	8e0da35857	FIX: allow local oneboxes to public topics/posts in PM	2018-02-15 18:14:41 +01:00
Sam	94b2c70c0d	PERF: remove oga gem ... oga gem is automatically required by the aws gem the oga gem retains about 1mb of memory, aws now uses nokogiri This also removes the html normalize from the pretty text specs that was a fair bit buggy as the polls test shows.	2018-02-15 14:36:40 +11:00
Robin Ward	b4aa0b096e	FIX: Couldn't like staff when allow_flagging_staff was set	2018-02-14 15:46:04 -05:00
Sam	f028ffaf29	SECURITY: correct local onebox category checks ... Also removes ugly "source_topic_id" from cooked posts Patch was authored by @zogstrip Signed-off-by: Sam <sam.saffron@gmail.com>	2018-02-14 10:40:46 +11:00
Erick Guan	03b3e57a44	FEATURE: login by a link from email ... Co-authored-by: tgxworld <tgx@discourse.org>	2018-02-13 16:14:39 +08:00
Guo Xiang Tan	3e835047da	Remove "already initialized" constant warning.	2018-02-13 08:55:15 +08:00
Robin Ward	4dfe659189	Rename allow staff flags to allow flagging staff	2018-02-12 15:27:26 -05:00
Robin Ward	6287631745	FEATURE: New site setting, allow staff flags, false by default ... For some large communities, it makes sense to disable flagging of staff posts.	2018-02-12 14:56:21 -05:00
Guo Xiang Tan	932a1a1187	Remove use of deprecated site setting.	2018-02-12 14:26:22 +08:00
Robin Ward	569e57f0a9	FIX: Delete the invalid auth cookie even if you hit the rate limit	2018-02-09 19:09:54 -05:00
Robin Ward	5466389f4e	FIX: Consider oneboxes links wrt to min_trust_level_to_post_links	2018-02-08 18:27:40 -05:00
Robin Ward	dedeb2deb8	FIX: Don't show the link button in the composer if linking is disabled	2018-02-08 12:56:10 -05:00
Robin Ward	6a5dad0b86	FIX: Too much Javascript :)	2018-02-07 11:46:05 -05:00
Robin Ward	8c04893a04	FIX: Don't throttle local lookups	2018-02-07 00:31:05 -05:00
Robin Ward	016b9cd0e9	FIX: Count the links in the post	2018-02-06 20:16:48 -05:00
Robin Ward	1bab15c757	FEATURE: A site setting for a minimum TL to post links	2018-02-06 18:07:58 -05:00
Robin Ward	b2b6dc68a6	FEATURE: a setting to customize the minimum TL to flag a post	2018-02-06 17:12:27 -05:00
Sam Saffron	df8e43abdd	use lazy & instead of try ... unregister ip skipper in test raise if called when a skipper is in play	2018-02-06 10:38:15 +11:00
Robin Ward	eefd226611	Add extensibility point to request_tracker to skip IP addresses ... This is useful if you want to run a per IP rate limiter but want to be able to skip some IPs with custom logic.	2018-02-05 17:49:40 -05:00
Robin Ward	2f19588311	FIX: If personal messages are disabled, don't show messages for groups	2018-02-02 16:35:54 -05:00
Neil Lalonde	0edd386b48	FEATURE: Vanilla bulk importer	2018-02-02 16:28:51 -05:00
Robin Ward	8ff4104555	Many enhancements to the flagging / suspending interface.	2018-02-01 17:13:02 -05:00
Arpit Jalan	350cbb1700	deprecate existing site settings	2018-02-01 13:25:29 +05:30
Arpit Jalan	9bbfad1081	rename private to personal	2018-02-01 13:25:29 +05:30
Arpit Jalan	7e48c47d37	rename 'enable_private_email_messages' to 'enable_personal_email_messages'	2018-02-01 13:25:29 +05:30
Arpit Jalan	ff0376a80b	rename 'enable_private_messages' to 'enable_personal_messages'	2018-02-01 13:25:29 +05:30
Arpit Jalan	25ec077eca	rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length'	2018-02-01 13:25:29 +05:30
Sam	ee0d3f15c1	FEATURE: allow better fidelity for auto linkify, disable most tlds based linkify ... New site settings: enable_markdown_linkify: which is default on, auto links https:// and http:// and mail:// markdown_linkify_tlds: which allows control of what tlds get autolinked for cases such as www.site.com, default is com|net|gov	2018-02-01 13:22:38 +11:00
Régis Hanol	7d2283167a	UX: only crops images taller than 18:9 instead of 16:9	2018-01-31 22:31:16 +01:00
Neil Lalonde	c598db28e7	Version bump to v2.0.0.beta2	2018-01-31 12:18:35 -05:00
Régis Hanol	361030d8ad	Also try popular Windows-1252 encoding when decoding incoming email	2018-01-30 23:45:04 +01:00
Régis Hanol	b2f18fc98f	FIX: system user edits should not generate notifications	2018-01-30 22:21:07 +01:00
Maja Komel	018cb7f36b	add a custom user onebox (#5542) ... * add custom user onebox * add specs	2018-01-30 11:03:08 +01:00
Sam	f946db4afe	FIX: inline oneboxer min title length of 2 ... also: cache mini onebox misses as well to cut down traffic	2018-01-30 08:40:04 +11:00
Kris	2eef9b3295	UX: Adding a sticky footer to the post history modal, removing bootstrap columns	2018-01-29 15:15:50 -05:00
Sam	fa5880e04f	PERF: ability to crawl for titles without extra HEAD req ... Also, introduces a much more aggressive timeout for title crawling and introduces gzip to body that is crawled	2018-01-29 15:40:12 +11:00
Arpit Jalan	1f6adbea5c	FEATURE: log private message views	2018-01-29 08:08:08 +05:30
Robin Ward	9721fb7573	Linting	2018-01-26 14:35:04 -05:00
Robin Ward	44e2038b53	Setting to automatically lock posts when edited by staff	2018-01-26 14:01:30 -05:00
Robin Ward	6b04967e2f	FEATURE: Staff members can lock posts ... Locking a post prevents it from being edited. This is useful if the user has posted something which has been edited out, and the staff members don't want them to be able to edit it back in again.	2018-01-26 14:01:30 -05:00
Régis Hanol	e2d82b882e	FIX: redirect to original URL after social login	2018-01-26 18:52:27 +01:00
Robin Ward	feec968801	Add extensibility to admin constraints	2018-01-25 13:56:08 -05:00
Arpit Jalan	7b4e6d508b	improve reviving_old_topic education message	2018-01-26 00:06:53 +05:30
Gerhard Schlager	eb52c5469e	FEATURE: Allow plugins to register a new locale	2018-01-25 14:57:41 +01:00
Gerhard Schlager	ce060e2b86	FIX: Server didn't use default_locale as fallback locale	2018-01-25 14:57:41 +01:00
Sam	1fac2ecb56	FIX: uploads not working on themes admin page	2018-01-25 21:13:06 +11:00
Sam	adae963751	ensure we do not override charset for content type	2018-01-25 18:43:42 +11:00
Neil Lalonde	594efa37b6	add some output to category and topic importer	2018-01-24 12:33:47 -05:00
Régis Hanol	cbf4204ecc	FIX: uploads:migrate_from_s3 wasn't destroying records before creating new ones	2018-01-24 13:22:07 +01:00
Robin Ward	782d75069e	FIX: UX improvements for system messages when PMs are disabled	2018-01-23 13:12:11 -05:00
Régis Hanol	28d432263e	rework the uploads:migrate_from_s3 rake task	2018-01-23 18:48:06 +01:00
Robin Ward	17ebfd1715	FIX: Don't show suggested messages if private messages are disabled	2018-01-23 12:05:44 -05:00
Sam	2437b0d531	FIX: regression, missing 404 page	2018-01-23 09:00:28 +11:00
Régis Hanol	cbb321658f	FIX: support for generating excerpt when nesting <details> blocks	2018-01-22 19:17:35 +01:00
Sam	f26ff290c3	FEATURE: Shorten setting name to max_reqs ... So it is consistent with other settings	2018-01-22 13:18:30 +11:00
Sam	83a346cd68	FIX: migrate_from_s3 rake task not working	2018-01-22 11:42:09 +11:00
Sam	fc36f095a7	FIX: ensure proper header transfer (except for cache control) ... allows discourse special headers to be visible on hijacked reqs	2018-01-21 14:26:42 +11:00
Robin Ward	b68799e081	FIX: Allow plugins to register importers	2018-01-19 16:24:41 -05:00
Régis Hanol	24dcfc2db5	remove constant warning in base62 file	2018-01-19 19:52:42 +01:00
Régis Hanol	b6c9d7a9d2	move requires to top of file	2018-01-19 17:51:42 +01:00
Robin Ward	9009cb5963	OOPS: Deleted file	2018-01-19 11:43:09 -05:00
Robin Ward	a8b46df4bd	More extensibility for custom silence/suspend messages	2018-01-19 11:35:19 -05:00
Régis Hanol	2d49250107	FIX: support recovering images using 'upload://' scheme	2018-01-19 15:40:17 +01:00
Sam	8bf91b8dca	correct tracking of x runtime	2018-01-19 17:51:19 +11:00
Sam	8ad43f01c2	FIX: correctly log topic timings as background	2018-01-19 10:37:43 +11:00
Sam	4f946319b4	improve warning text	2018-01-19 08:32:15 +11:00
Sam	12872d03be	PERF: run post timings in background ... This means that if a very large amount of registered users hit a single topic we will handle it gracefully, even if db gets slow.	2018-01-19 08:27:29 +11:00
Régis Hanol	5f4f617689	FIX: cache_file storage cleanup logic was wrong ... https://meta.discourse.org/t/68296	2018-01-18 17:00:04 +01:00
Gerhard Schlager	2a22b90538	SECURITY: email domain whitelist could be bypassed	2018-01-17 21:45:32 +01:00
Robin Ward	34ed6088b9	FEATURE: New modal to show flags received for a user	2018-01-17 15:08:08 -05:00
Gerhard Schlager	bb54eb1192	Improvements to mbox importer ... * store time it took to index message in DB (to find performance issues) * ignore listserv specific files * better examples for split_regex * first email in mbox shouldn't contain the split string * always lock the DB in exclusive mode * save email within transaction * messages can be grouped by subject and use original order (for Listserv) * adds option to index emails without running the import	2018-01-17 12:04:57 +01:00
Arpit Jalan	79eb9d7086	FEATURE: show header search results on search log term details page	2018-01-17 12:47:16 +05:30
Sam	650ec9c73f	minor test the developer cache first before digging into email	2018-01-17 15:50:41 +11:00
Arpit Jalan	1208254961	FIX: validate presence of 'top menu' setting	2018-01-17 01:43:53 +05:30
Neil Lalonde	f274a5234f	FIX: topic and category exporters were only exporting users who created the first post	2018-01-16 12:51:53 -05:00
Sam	d7657d8e47	correct specs, ensure crawler layout only applies to html	2018-01-16 16:28:11 +11:00
Sam	7b562d2f46	FEATURE: much improved and simplified crawler detection ... - phase one does it match 'trident|webkit|gecko|chrome|safari|msie|opera' yes- well it is possibly a browser - phase two does it match 'rss|bot|spider|crawler|facebook|archive|wayback|ping|monitor' probably a crawler then Based off: https://gist.github.com/SamSaffron/6cfad7ea3e6df321ffb7a84f93720a53	2018-01-16 15:41:45 +11:00
Sam	fcfce3e426	PERF: avoid expensive OR clause query info more efficiently	2018-01-15 16:38:58 +11:00
Sam	38c018a84b	FIX: invalid cache for parent category with limit_suggested_to_category	2018-01-15 16:13:29 +11:00
Sam	41a604a764	PERF: improve perf of topic suggested query with limit_suggested_to_category	2018-01-15 15:32:25 +11:00
Sam	442a17bfb2	PERF: bypass omniauth unless in an auth path	2018-01-15 12:44:54 +11:00
Mohammad AlTawil	234aa68bf8	Correct Arabic month names ... Correct Arabic month names. It's not right to concatenate month names from two different calendars [Assyrian calendar](https://en.wikipedia.org/wiki/Assyrian_calendar) and [Gregorian calendar](https://en.wikipedia.org/wiki/Gregorian_calendar)	2018-01-14 20:01:45 +01:00
Sam	215c0d5569	FEATURE: allow system api to target users via external id or user id ... usage ?api_key=XYZ&api_user_external_id=ABC usage ?api_key=XYZ&api_user_id=123	2018-01-12 17:40:18 +11:00
Vinoth Kannan	988b13ac77	FIX: GitHub auth always asking to verify email for new users (#5487)	2018-01-12 15:17:29 +11:00
Sam	49ed382c2a	FIX: return 429 when admin api key is limited on admin route ... This also handles a general case where exceptions leak out prior to being handled by the application controller	2018-01-12 14:15:26 +11:00
Arpit Jalan	7fea15ca4d	FIX: rescue login required / broken images	2018-01-11 22:18:56 +05:30
Sam	fc05164667	demo script for demonizing using fork exec ... minor refinements to demon	2018-01-11 13:51:52 +11:00
Joffrey JAFFEUX	cc819539b0	FIX: makes rake qunit:test task work on macOS	2018-01-10 14:51:08 +01:00
Sam	8ff5f5f2ef	FIX: cache admin locale file for 24 hours	2018-01-09 10:23:49 +11:00
Sam	cecd7d0d07	FEATURE: global rate limiter can bypass local IPs	2018-01-08 08:39:17 +11:00
Gerhard Schlager	e0d73a957d	FEATURE: Allow posting via email to read-only mailing list mirror category	2018-01-05 11:21:53 +01:00
Gerhard Schlager	d7cd7e4dc7	FIX: Never mark emails sent to mailing list mirror as auto-generated	2018-01-05 11:21:53 +01:00
Joffrey JAFFEUX	754fa3d2f5	FIX: facebook deprecated facebook messenger emojis	2018-01-05 11:01:23 +01:00
Joffrey JAFFEUX	e7d1d4eddf	FIX: correct shushing_face name	2018-01-05 11:01:23 +01:00
Sam	715cb98e95	add better diagnostics for rate limits	2018-01-05 12:14:28 +11:00
Sam	25f4d98307	improve error logging for warn_exception	2018-01-05 09:54:42 +11:00
Neil Lalonde	c2c0a81a4f	Version bump to v2.0.0.beta1	2018-01-03 16:54:55 -05:00
Gerhard Schlager	ceb7590bcb	FIX: bounced email can contain multiple status codes	2018-01-03 17:59:20 +01:00
Guo Xiang Tan	ad02437358	FIX: Missing post/topic created web hooks due to race condition.	2018-01-03 17:24:01 +08:00
Gerhard Schlager	81427e26ea	Ignore errors when remapping posts	2017-12-28 15:13:01 +01:00
Régis Hanol	f5e170c6b5	FIX: catch all server-side error when uploading a file ... UX: always show a message to the user whenever an error happens on the server when uploading a file	2017-12-27 16:33:25 +01:00
Guo Xiang Tan	805d1c25d3	Merge pull request #5451 from tgxworld/treat_non_ascii_urls_as_valid ... Treat non-ascii URLs in `UrlValidator`.	2017-12-27 14:14:20 +08:00
Arpit Jalan	0514ac4ee2	FIX: verify presence of 'sso url' before enabling 'enable sso'	2017-12-23 13:30:49 +05:30
Régis Hanol	d6b22e6cc1	FIX: whitelist oneboxed iframes	2017-12-23 01:56:33 +01:00
blokovi	364e6fdd53	FIX: pluralization rules for Serbian language (#5453) ... Updated SR pluralization to use 3 keys: one, few, other (as by Transifex)	2017-12-22 12:20:19 +01:00
Jeff Atwood	cedfd6b68c	Merge pull request #5449 from Supermathie/google_fix ... FIX: google oauth flow should automatically update the google account used for login when appropriate	2017-12-21 17:46:43 -08:00
Guo Xiang Tan	6f89db4c24	Re-enable check for yarn when running qunit:test rake task.	2017-12-22 09:11:49 +08:00
Robin Ward	aed37770e3	FIX: Load the route format before discourse	2017-12-21 16:29:11 -05:00
Robin Ward	063e449ce5	FIX: RouteFormat is a better class name than RouteFormats	2017-12-21 15:30:32 -05:00
Robin Ward	2908aab0da	Allow extensibility on username route format (non-english usernames)	2017-12-21 14:32:51 -05:00
Guo Xiang Tan	4b51871f6a	Treat non-ascii URLs in UrlValidator.	2017-12-21 14:22:55 +08:00
Guo Xiang Tan	6ecf37c482	Improve URL validation to check for a valid host. ... Parsing a URL with `URI` is not sufficient as the following cases are considered valid: URI.parse("http://https://google.com") => #<URI::HTTP http://https//google.com>	2017-12-21 13:50:15 +08:00
Sam	081959227d	FIX: unicode titles missing when visiting topic from topic list	2017-12-21 15:20:47 +11:00
Guo Xiang Tan	aabac55edd	Better ENV name for QUnit's seed.	2017-12-21 09:47:32 +08:00
Neil Lalonde	e17ce65aab	Version bump to v1.9.0.beta17	2017-12-20 18:50:35 -05:00
Michael Brown	105cf61ed9	Implements https://meta.discourse.org/t/issue-user-changed-google-account-and-cant-connect-thru-his-profile/35028/18?u=supermathie	2017-12-20 17:59:36 -05:00
Sam	88a4ec5f1b	FIX: stop forking regular backup jobs	2017-12-21 09:00:48 +11:00
Robin Ward	21e1b05c7e	FIX: Don't disable details when below truncate limit	2017-12-20 15:45:00 -05:00
Guo Xiang Tan	4986132e1b	Fix missing variable in smoke test rake task.	2017-12-20 14:49:41 +08:00
Sam	bbc606988f	improve message	2017-12-20 10:12:33 +11:00
Robin Ward	b3fda0ea86	FIX: details tags broke excerpts	2017-12-19 17:28:55 -05:00
Guo Xiang Tan	ca8e4dfb43	Allow seed to be passed via ENV.	2017-12-19 21:35:51 +08:00
Guo Xiang Tan	141a4a059d	QUnit tests should be run in random order.	2017-12-19 21:33:31 +08:00
Guo Xiang Tan	349dc8da29	Disable check for yarn in qunit tests first.	2017-12-19 20:09:36 +08:00
Guo Xiang Tan	fc6cb7bbe3	Merge pull request #5444 from tgxworld/remove_phantomjs ... Switch to chrome headless mode instead of phantomjs.	2017-12-19 19:42:40 +08:00
Gerhard Schlager	b47b378cb6	Retry PNG to JPG conversion with debug enabled on failure	2017-12-19 11:49:04 +01:00
Guo Xiang Tan	6a4f391e38	Switch to chrome headless mode instead of phantomjs.	2017-12-19 16:00:43 +08:00
Matt Palmer	f315c142b1	BUG: Load the appropriate file for AlternativeReplyByEmailAddressesValidator ... Autoloading only works when the class names are namespaced appropriately.	2017-12-19 09:43:41 +11:00
Régis Hanol	8e55400392	FIX: add 'SiteSetting.port' to 'Onebox.allowed_ports' in development mode	2017-12-18 18:31:41 +01:00
Guo Xiang Tan	8d44642b97	Add smoke test script that runs in chrome headless.	2017-12-18 16:39:01 +08:00
Guo Xiang Tan	f2565f6c7e	SECURITY: Any group can be invited into a PM.	2017-12-14 14:57:48 +08:00
Sam	67aecff59c	FEATURE: store twitter supplied email for auditing	2017-12-14 15:54:32 +11:00
Gerhard Schlager	b15059418b	FIX: rake task for updating posts received by email should not crash	2017-12-13 22:03:31 +01:00
Gerhard Schlager	f525d83b53	FIX: empty uploads and blank filenames caused errors during validation	2017-12-13 22:03:31 +01:00
Sam	dee498a281	correct regression	2017-12-13 17:36:36 +11:00
Sam	9d925f6b26	FIX: correctly count participants when more than 24 ... Also cuts out one query for the normal case	2017-12-13 17:19:42 +11:00
Gerhard Schlager	e30851e45a	Move escape_uri method to a more suitable place	2017-12-12 20:17:46 +01:00
Neil Lalonde	3016901a34	Version bump to v1.9.0.beta16	2017-12-12 11:38:15 -05:00
Guo Xiang Tan	6ade508f39	FIX: Prevent 'rack.input' missing error.	2017-12-12 16:40:35 +08:00
Arpit Jalan	ff6dda85b7	FIX: replace curly quotes to regular quotes in search terms	2017-12-12 11:17:28 +05:30
Sam	4986ebcf24	FEATURE: optional default off global per ip rate limiter	2017-12-11 17:52:57 +11:00
Sam	68d3c2c74f	FEATURE: add global rate limiter for admin api 60 per minute ... Also move configuration of admin and user api rate limiting into global settings. This is not intended to be configurable per site	2017-12-11 11:07:22 +11:00
Vinoth Kannan	6b3aa81c11	FIX: Remove other whitespaces except the line intents	2017-12-09 02:36:27 +05:30
Vinoth Kannan	dcc63a8ead	FIX: Keep all the indenting in the text	2017-12-09 01:11:00 +05:30
Sam	47c44356f8	FIX: load balanced servers do not share monotonic clock ... This means then when a service is load balanced and you reach rate limits there was a case where they counting was way off also remove the stub from clock_gettime cause we need to be super careful with it, so we should probably just stub by hand when needed	2017-12-07 11:48:11 +11:00
Sam	90a55d6f7c	FIX: handle CORS in hijacked requests	2017-12-07 10:31:04 +11:00
Gerhard Schlager	16738cfb1b	FEATURE: convert plain text emails to markdown	2017-12-06 01:47:51 +01:00
Kyle Zhao	5f318a5241	FEATURE: Replace SimpleRSS with Ruby RSS module (#5311) ... * SPEC: PollFeedJob parsing atom feed * add FeedItemAccessor It is to provide a consistent interface to access a feed item's tag content. * add FeedElementInstaller to install non-standard and non-namespaced feed elements * FEATURE: replace SimpleRSS with Ruby RSS module * get FinalDestination and download with Excon * support namespaced element with FeedElementInstaller	2017-12-06 10:45:09 +11:00
Neil Lalonde	85a59c632d	allow header_instructions to be passed in to message builder	2017-12-05 15:12:24 -05:00
Arpit Jalan	a5e58e7afa	UX: add onebox favicon styling in email	2017-12-05 14:08:30 +05:30
Sam	5a9622163d	FIX: regression around rate limiter	2017-12-04 21:44:16 +11:00
Sam	dd70ef3abf	Revert "Revert "PERF: improve speed of rate limiter"" ... This reverts commit 2373d85239.	2017-12-04 21:23:11 +11:00
Sam	2373d85239	Revert "PERF: improve speed of rate limiter" ... This reverts commit a9bcdd7f27.	2017-12-04 21:19:28 +11:00
Sam	a9bcdd7f27	PERF: improve speed of rate limiter ... Also - adds a global rate limiter option - cleans up usage in tests - fixes freeze_time so it handles clock_gettime	2017-12-04 18:17:30 +11:00
Sam	6c82a50903	Improve error handling in hijacked code	2017-12-01 16:23:32 +11:00
Vinoth Kannan	7f2eeaf767	FIX: Password required flag should be cleared whenever clearing the raw password (#5384)	2017-12-01 15:19:24 +11:00
Neil Lalonde	49371d668f	Version bump to v1.9.0.beta15	2017-11-30 16:32:43 -05:00
Sam	3334a4b539	Simplify hijack code	2017-11-29 11:54:35 +11:00
Gerhard Schlager	44ee388070	FEATURE: omit images from og and twitter description tags	2017-11-28 21:34:02 +01:00
Sam	f80522671b	improve instrumentation and defer hijacking till last moment	2017-11-28 18:21:56 +11:00
Jeff Wong	b094894c94	Feature: Add service worker registration method to plugin API	2017-11-28 14:01:41 +08:00
Sam	df84e1c358	Correctly track hijacked requests	2017-11-28 16:47:20 +11:00
Sam	b3b55e18d1	UX: stop warping tiny onebox images	2017-11-28 12:32:35 +11:00
Sam	0caa335ef0	FIX: Handle more cases where HTTP status is not correct ... HTTP status was not correct with send_file which uses streaming	2017-11-28 11:00:13 +11:00
Sam	ca7af7b88f	FIX: displaying wrong avatar and letter avatar ... correct regression where params and env is reused in production	2017-11-28 09:28:40 +11:00
Robin Ward	5a959ca4e4	FIX: We also need a base key for admin_js	2017-11-27 11:57:06 -05:00
Robin Ward	77f90876d3	REFACTOR: Track manual locked user levels separately from groups	2017-11-27 11:23:44 -05:00
Vinoth Kannan	1f3e9a4350	FIX: Should skip the loop if the image src is blank	2017-11-27 13:41:28 +05:30
Sam	608207b2e5	FEATURE: avatar proxy happens in background ... This ensures that even if it is slow to download avatars site will continue to work Also simplifies hijack pattern	2017-11-27 17:43:24 +11:00
Sam	e48c280c7e	correct regression	2017-11-27 15:07:13 +11:00
Sam	d5e7691ae9	favicon proxy now uses hijack	2017-11-27 14:51:14 +11:00
Sam	eb428ef54d	FEATURE: uploads are processed a faster ... Also cleans up API to always return 422 on upload error. (previously returned 200) Uploads are processed using new hijack pattern	2017-11-27 12:43:35 +11:00
Guo Xiang Tan	71942e4f62	Merge pull request #5352 from tgxworld/method_for_replica_postgres_connection ... Expose `replica_postgresql_connection` to `ActiveRecord::Base`.	2017-11-27 08:38:10 +08:00
Neil Lalonde	6f8f2c494d	FIX: admin strings in plugins should fallback to english when untranslated	2017-11-24 14:11:01 -05:00
Michael Brown	45c19e44f0	assets rake task: only try and detect brotli if COMPRESS_BROTLI is set	2017-11-24 12:00:38 -05:00
Michael Brown	5584085943	assets rake task: detect the brotli version on the image as the usage changes	2017-11-24 10:40:57 -05:00
Michael Brown	3c60702663	assets rake task: gzip and brotli exit codes exist for a reason - to be checked	2017-11-24 09:52:08 -05:00
Sam	e0e99d4bbd	PERF: hijack onebox requests so they do not use up a unicorn worker	2017-11-24 15:31:40 +11:00
Guo Xiang Tan	a509f466a0	Expose replica_postgresql_connection to ActiveRecord::Base.	2017-11-24 09:35:45 +08:00
Gerhard Schlager	613f4d737a	FIX: updating topic stats failed silently for invalid topics	2017-11-23 18:47:45 +01:00
Sam	2b8d4508e5	PERF: stop running background work between requests ... Use a dedicated thread to run Scheduler::Defer This avoids blocking of a worker during operations that require waiting. In particular uploads risked blocking a unicorn. This also add a queue "length" that discourse prometheus consumes.	2017-11-23 15:48:47 +11:00
Neil Lalonde	6c86e0c94a	FEATURE: remove the featured link by editing the topic	2017-11-22 14:53:35 -05:00
Guo Xiang Tan	26d14dbcbb	Remove onceoff job in migrate rake task.	2017-11-22 12:50:01 +08:00
Guo Xiang Tan	edfa2c3af9	FIX: Don't enqueue onceoff job in migration. ... * Deployment of app servers may happen minutes after migrations.	2017-11-22 12:07:48 +08:00
Guo Xiang Tan	f7642e076d	REFACTOR: Avoid duplicated logic on server and client.	2017-11-21 17:10:04 +08:00
Guo Xiang Tan	c390169b71	Move monkey patch into freedom_patchers.	2017-11-21 14:15:11 +08:00
Guo Xiang Tan	337ccfa3a6	MONKEYPATCH: Allow us to disable the use of advisory locks during migration.	2017-11-21 14:06:22 +08:00
Robin Ward	f8164956dd	Add quote and mention support for username formatters	2017-11-20 16:28:03 -05:00
Guo Xiang Tan	385372e384	Revert "PERF: Reduce number of topics to filter while querying for unread." ... This reverts commit c06b782cab.	2017-11-20 11:49:09 +08:00
Gerhard Schlager	546b206da0	replace indentation with non-breaking spaces when cooking emails	2017-11-18 17:16:44 +01:00
Régis Hanol	de037da731	FIX: FinalDestination's small_get method wasn't using proper request headers	2017-11-17 17:24:35 +01:00
Régis Hanol	aebcd56300	FIX: try a GET for error code 406	2017-11-17 16:59:51 +01:00
Régis Hanol	221ff24418	SQL != Ruby	2017-11-17 16:12:20 +01:00
Régis Hanol	a0fc8bd924	don't log 404s to gravatar.com	2017-11-17 15:38:26 +01:00
Gerhard Schlager	1a3ab7c02e	ignore some site settings for emails sent to mailinglist mirror category	2017-11-17 15:29:14 +01:00
Gerhard Schlager	aea161fabd	suppress rejection email when email was sent to mailinglist mirror category	2017-11-17 15:29:14 +01:00
Guo Xiang Tan	3a472b507e	FIX: severity_name was being logged incorrectly.	2017-11-17 08:55:21 +08:00
Robin Ward	2974faee68	FIX: Support client locales defined in plugins	2017-11-16 16:21:53 -05:00
Robin Ward	fc346d207b	Only return unique paths	2017-11-16 15:22:05 -05:00
Robin Ward	966c7e7f07	FEATURE: Allow plugins to dynamically add seed fixture paths ... This is useful if your plugin wants different seed data for different locales for example.	2017-11-16 14:43:17 -05:00
Robin Ward	8cd0026cde	FIX: If there is an invalid locale in the site setting, default to en	2017-11-16 10:58:29 -05:00
Régis Hanol	678e28794a	FIX: properly handle too large & broken images in posts	2017-11-16 15:45:07 +01:00
Sam	f52111f787	FEATURE: allow plugins to easily detect if running in Rack ... Usage: Discourse.running_in_rack? to tell if rack was booted	2017-11-16 08:39:29 +11:00
Neil Lalonde	0cdded8079	Merge pull request #5303 from vinothkannans/export-multiple-categories ... FEATURE: Option to export multiple categories using export_category method	2017-11-15 16:07:21 -05:00
Gerhard Schlager	9207dee69a	FEATURE: escape HTML when cooking plaintext emails	2017-11-15 20:22:11 +01:00
Vinoth Kanan	5c11104f9f	FIX: Duplicate a tag if image url is same to href	2017-11-15 17:36:48 +05:30
Vinoth Kannan	7b494a65c9	NEW: large image placeholder added in cooked html (#5291)	2017-11-15 11:30:47 +01:00
Guo Xiang Tan	89d9ffa884	EXPERIMENTAL: Allow logs to be shipped via different methods. ... See https://github.com/dwbutler/logstash-logger#uri-configuration for a list of available methods.	2017-11-15 09:11:33 +08:00
Robin Ward	d07ebf9d4c	UX: Support for custom error pages and headers in plugins	2017-11-14 16:31:44 -05:00
Régis Hanol	23baaa5dcc	FIX: don't crop iPhone X screenshots	2017-11-14 20:37:27 +01:00
Robin Ward	971e302ff2	FEATURE: Support an end date for user silencing	2017-11-14 13:20:19 -05:00
Sam	075a458489	FIX: child theme component vars not resolved in parent	2017-11-14 15:22:59 +11:00
Gerhard Schlager	d3baae5365	removes whitespaces and uses scope	2017-11-13 15:23:24 +01:00
Sam	ed0751f288	always double check there is a class first	2017-11-13 16:06:18 +11:00
Sam	4f28c71b50	FIX: error setting tombstone bucket when set to old version	2017-11-13 15:36:45 +11:00
Sam	3ac7d041ae	UX: generic onebox treats all square images as avatars and renders them smaller	2017-11-13 11:21:19 +11:00
Gerhard Schlager	5210e3e744	FEATURE: accept incoming email with reply_key mismatch when original email was forwarded	2017-11-12 23:44:22 +01:00
Gerhard Schlager	4dc4bc70c8	FIX: ignore_by_title should match case-insensitive	2017-11-12 01:43:18 +01:00
Vinoth Kanan	d9823f69c6	FEATURE: Option to export multiple categories using export_category method	2017-11-11 19:11:16 +05:30
Robin Ward	1f14350220	Rename "Blocked" to "Silenced"	2017-11-10 14:10:27 -05:00
Neil Lalonde	9dc9ca4ac0	FIX: be consistent with how first posts in topics are counted. do like DirectoryItem.refresh_period :all	2017-11-10 12:18:25 -05:00
Michael Howell	38b8d68c68	FEATURE: Allow the user to select a custom home page (#5268) ... * Add user_home configuration option * Use the new user_home preference to actually show the right home page * Fix trailing whitespace * Update user_option_serializer.rb * Fix JavaScript default homepage tests * Use an object instead of a giant switch * Remove trailing whitespace * Make the default `user_home` set to `null` instead of `0` * Rename user_home to homepage_id	2017-11-10 06:45:19 +11:00
Robin Ward	16407dfc11	Add a failed_code we can check for when using Auth::Result	2017-11-09 10:49:42 -05:00
Sam	06365023c4	FEATURE: new API to search for a user by email	2017-11-09 17:04:21 +11:00
Sam	2d5bf0705a	PERF: exact email match bypass ... instead of scanning full table when there is an exact email match ONLY return the actual user.	2017-11-09 16:53:14 +11:00
Guo Xiang Tan	7777a44673	FIX: Don't skip validations when updating user's email.	2017-11-08 11:38:51 +08:00
Sam	fc7dca58fe	UX: oneboxes with avatars now display consistently ... Onebox avatar size is reduced to 60px Also fixes regression with some oneboxes not cooking after post	2017-11-08 11:50:01 +11:00
Régis Hanol	be0c7609f1	FIX: validates attachments against current authorized extensions	2017-11-07 19:17:33 +01:00
Arpit Jalan	8f560f0bf4	Merge pull request #5282 from vinothkannans/local_onebox_slash ... FIX: Topic links onebox differently if end in /	2017-11-07 17:39:38 +05:30
Guo Xiang Tan	8970bdd4fa	FIX: Undefined method before unicorn boots.	2017-11-07 11:52:22 +08:00
Guo Xiang Tan	d9602fe729	Fix incorrect severity field.	2017-11-07 11:24:54 +08:00
Guo Xiang Tan	6a47491afe	Fix the build.	2017-11-06 16:56:22 +08:00
Guo Xiang Tan	ffe823ed32	Ensure we log the datetime in the format that we want.	2017-11-06 16:40:11 +08:00
Guo Xiang Tan	96a414d0a5	Log progname as empty string if nil.	2017-11-06 16:01:32 +08:00
Guo Xiang Tan	c9df21e131	FEATURE: Allow Unicorn logs to be JSON formatted.	2017-11-06 12:46:14 +08:00
Vinoth Kannan	230fec68ca	FIX: Topic links onebox differently if end in /	2017-11-06 01:41:36 +05:30
Robin Ward	2f0c9793f1	FEATURE: Allow multiple html builders to be registered via plugins	2017-11-03 11:32:32 -04:00
ckeboss	93633865d9	Adds primary user group as a class to quote (#5285) ... * Adds primary user group as a class to quote This feature addition will add the class `group-PRIMARY_USER_GROUP` to the quote `aside`. `PRIMARY_USER_GROUP` will be the primary user group of the user being quoted. This is similar to the class that is added to a `topic-post`. * Remove trailing whitespace * Fix avatar in test * Address PR comments * Fix trailing whitespace	2017-11-03 09:51:40 -04:00
Guo Xiang Tan	470b1a5bc1	Don't print Sidekiq starting message to STDERR.	2017-11-03 21:02:31 +08:00
Guo Xiang Tan	88492b2b94	Merge pull request #5283 from viktorbenei/patch-1 ... Fix "duplicate method" issue	2017-11-03 09:32:45 +08:00
Neil Lalonde	18d65fe7e5	FIX: post counts in user stats when changing post owner	2017-11-02 18:05:23 -04:00
Neil Lalonde	21dd2ccd43	FIX: only count regular posts in user stats when deleting	2017-11-02 18:05:23 -04:00
Neil Lalonde	30689783db	don't decrement post_count for a post in a deleted topic that has already been uncounted	2017-11-02 18:05:23 -04:00
Neil Lalonde	f29290ad11	FIX: don't count whispers in user stats post_count	2017-11-02 18:05:23 -04:00
Neil Lalonde	24af9b7d97	FIX: when a topic is deleted, update the post count stats of all user who replied	2017-11-02 18:05:23 -04:00
Robin Ward	64cb8a3ce3	FIX: Normalizer wasn't working with attributes without values	2017-11-02 14:11:20 -04:00
Viktor Benei	54e4ff34f8	Fix "duplicate method" issue ... Fixing http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/DuplicateMethods Readers are defined (https://github.com/discourse/discourse/blob/master/lib/single_sign_on.rb#L61), so only writers have to be generated.	2017-11-02 12:33:35 +01:00
Arpit Jalan	5849bae9df	FIX: rescue error when importing category structure	2017-11-01 22:21:37 +05:30
Arpit Jalan	7f33f7850a	Merge pull request #5270 from vinothkannans/rake_categories ... FEATURE: Rake task to export and import category structure	2017-11-01 21:36:03 +05:30
Vinoth Kannan	a00af4d85a	FEATURE: Rake task to export and import category structure	2017-11-01 17:17:05 +05:30
Arpit Jalan	2792c3c80e	fix typo	2017-11-01 15:51:17 +05:30
Sam	deb79a8fff	DEV: private means nothing for class methods	2017-11-01 16:43:19 +11:00
Sam	f5cc28d740	UX: correct regression with twitter onebox	2017-11-01 16:42:56 +11:00
Gerhard Schlager	d1f257d275	FinalDestination should only log when verbose is enabled	2017-10-31 17:16:59 +01:00
Gerhard Schlager	880d154381	FIX: deleting staged user of rejected email shouldn't delete incoming email	2017-10-31 15:13:23 +01:00
Gerhard Schlager	8c27f28dcb	add more logging to FinalDestination	2017-10-31 12:26:35 +01:00
Sam	9197feefb8	UX: onebox images no longer cause jiggle ... This stops pages from "jiggling" while oneboxes download. see: http://cssmojo.com/aspect-ratio-using-custom-properties-and-calc/	2017-10-31 13:50:58 +11:00
Neil Lalonde	9705f8b9c2	Version bump to v1.9.0.beta14	2017-10-30 11:20:55 -04:00
Sam	7ca08216bd	FIX: ensure we have no dangling db connections on threads ... This correct 10 second timeouts in dev mode, when reloader kicks in	2017-10-30 14:24:15 +11:00
Guo Xiang Tan	401fbdbfe7	FIX: Topic#title were being parameterized when encoded slug is ... enabled.	2017-10-27 11:02:47 +08:00
Sam	70aed105a6	FIX: bypass all site setting work for shadowed method	2017-10-27 11:12:44 +11:00
Guo Xiang Tan	f30366744a	Fix the build.	2017-10-26 17:09:00 +08:00
Erick Guan	7c3123a2dd	Downcase encoded slug by default and more specs	2017-10-26 16:50:29 +08:00
Rafael dos Santos Silva	a173511681	Merge pull request #5259 from discourse/groups_in_sso_provider ... Add groups to the SSO provider payload	2017-10-25 23:02:53 -02:00
Rafael dos Santos Silva	5d5268a82b	Feature: Group handling	2017-10-25 22:49:17 -02:00
Arpit Jalan	efbd923f60	Merge pull request #5261 from xrav3nz/fix-rebake-match-rake ... FIX: `post:rebake_match` rake task	2017-10-25 10:22:56 +05:30
Sam	877b7be579	FIX: in readonly mode don't double count pages	2017-10-25 13:19:43 +11:00
Kyle Zhao	82c18f6ca3	fix: undefined variable in post:rebake_match	2017-10-24 20:05:58 -04:00
Neil Lalonde	2c15e9c6fe	FIX: search couldn't find tags from before 2017-08-25	2017-10-24 17:55:05 -04:00
Neil Lalonde	fb5b9b6d06	FIX: don't offer the "Something Else" flag reason to TL0 users since they don't have permission to send private messages	2017-10-24 11:47:42 -04:00
Guo Xiang Tan	5c8dac3ae5	Replace discourse-slack-official with discourse-chat-integration.	2017-10-24 09:44:11 +08:00
Sam	d4d5e6965e	FEATURE: discourse-prometheus is an official plugin	2017-10-24 10:27:28 +11:00
Neil Lalonde	4452d67a23	Revert "FIX: TL0 users' messages to moderators were not being posted when flagging private messages"	2017-10-23 18:17:53 -04:00
Neil Lalonde	214fdad155	FEATURE: category and topic importer can support data from different sources using IMPORT_SOURCE	2017-10-23 14:01:57 -04:00
Régis Hanol	17e5fb0dc0	fix the build	2017-10-23 19:09:38 +02:00
Régis Hanol	80ad32094d	Small re-organization of CookedPostProcessor workflow ... - only 'limit_size!' of oneboxed images once - update post image at the end - move 'enforce_nofollow' in its own method	2017-10-23 18:15:51 +02:00
Régis Hanol	04ae79896c	Exit early when the 'img is already inside an 'a' tag	2017-10-23 17:43:53 +02:00
Guo Xiang Tan	54455fa40b	Use MessageBus to get other processes to failover faster.	2017-10-23 17:58:24 +08:00
Sam	361fbfa518	FEATURE: raise an event when a sidekiq job runs	2017-10-23 17:30:17 +11:00
Sam	55d096ee8b	FEATURE: add event for scheduled_job_ran	2017-10-23 17:22:17 +11:00
Sam	8eb00984ea	improve plugin autospec watcher	2017-10-23 10:49:42 +11:00
Guo Xiang Tan	7673684d91	Allow DistributedCache#delete to not publish changes.	2017-10-20 23:03:42 +08:00
Arpit Jalan	804b4f32f8	better error message when API authentication fails	2017-10-20 20:05:34 +05:30
Guo Xiang Tan	57d9830bd2	FIX: DistributedCache without namespace mode wasn't working.	2017-10-20 22:32:41 +08:00
Guo Xiang Tan	fe1e78ddf4	Make PostgreSQL failover work with distributed cache.	2017-10-20 17:15:29 +08:00
Gerhard Schlager	4205c1ad2b	FIX: postprocessing ignored cook method	2017-10-20 10:26:45 +02:00
Gerhard Schlager	1481462cbf	PERF: Move oneboxing from cook method "email" to postprocessing	2017-10-20 10:26:45 +02:00
Guo Xiang Tan	d3003592cd	Connection may be nil.	2017-10-20 12:10:03 +08:00
Guo Xiang Tan	057571d173	Raise errors in PostgreSQLFallbackHandler threads.	2017-10-20 12:06:03 +08:00
Guo Xiang Tan	24e3e321e1	Only initialize distributed cache once.	2017-10-20 07:17:41 +08:00
Guo Xiang Tan	c7402ef794	FIX: Use a distributed cache to store failover state.	2017-10-20 05:46:19 +08:00
Robin Ward	838568cbc3	Refactor flag types for more customization	2017-10-19 13:55:23 -04:00
Michael Brown	e600fb79b3	Merge pull request #5241 from Supermathie/s_encode ... single_sign_on: encode the payload with strict_encode64 which doesn't add extraneous newlines	2017-10-19 11:38:00 -04:00
Guo Xiang Tan	25c25ae423	FEATURE: Allow user to leave a PM.	2017-10-19 12:32:55 +08:00
Guo Xiang Tan	79de10b212	FEATURE: Allow users to disable new PMs. ... https://meta.discourse.org/t/is-it-possible-to-disable-private-messaging-for-a-specific-user/46391	2017-10-19 12:32:55 +08:00
Régis Hanol	cbdfc85466	FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd)	2017-10-18 23:54:36 +02:00
Sam	a4c539bade	FEATURE: Allow registration of detailed request logger ... Detailed request loggers can be used to gather rich timing info from all requests (which in turn can be forwarded to monitoring solution) Middleware::RequestTracker.detailed_request_logger(->|env, data| do # do stuff with env and data end	2017-10-18 12:10:30 +11:00
Régis Hanol	65dc47adb4	FIX: prevent infinite 'pull_hotlinked_images' jobs when a oneboxed image has a different scheme	2017-10-18 01:50:23 +02:00
Michael Brown	518e101ad6	single_sign_on: encode the payload with strict_encode64 which doesn't add extraneous newlines	2017-10-17 13:41:52 -04:00
Guo Xiang Tan	1b5ee0ae72	FIX: Couldn't boot Discourse app with a readonly postgres.	2017-10-17 13:44:30 +08:00
Sam Saffron	8185b8cb06	FEATURE: cache https redirects per hostname ... If a hostname does an https redirect we cache that so next lookup does not incur it. Also, only rate limit per ip once per final destination Raise final destination protection to 1000 ip lookups an hour	2017-10-17 16:22:54 +11:00
Sam Saffron	646c6eb7cd	FEATURE: add :before_post_process_cooked hook ... Also reduce amount of image downloading	2017-10-17 16:22:54 +11:00
Neil Lalonde	2db66072d7	SECURITY: signup without verified email using Google auth	2017-10-16 13:51:41 -04:00
Guo Xiang Tan	5f76e5062d	Pause Sidekiq when postgres failovers.	2017-10-16 19:48:31 +08:00
Neil Lalonde	b124e5f19f	FIX: TL0 users' messages to moderators were not being posted when flagging private messages	2017-10-13 11:55:49 -04:00
Neil Lalonde	6f923d5964	Version bump to v1.9.0.beta13	2017-10-13 11:30:21 -04:00
Vinoth Kannan	f176d114f2	FIX: with_email method won't support hash param (#5236)	2017-10-13 11:49:02 +02:00
Guo Xiang Tan	d2ac7a9476	Partially revert 4e89d3f778. ... * SiteSetting uses DistributedCache which depends on MessageBus. Therefore, we need to initialize MessageBus first.	2017-10-12 15:15:24 +08:00
Gerhard Schlager	c0bb97b5cb	FIX: delete staged users when the incoming email is rejected	2017-10-11 16:17:01 +02:00
Guo Xiang Tan	9dcb11f553	Fix the build.	2017-10-11 17:45:19 +08:00
Guo Xiang Tan	36f8697a59	FIX: Exception has to be wrapped in the connection as well.	2017-10-11 17:19:26 +08:00
Guo Xiang Tan	09721090a3	FIX: Ensure that we revert back to default connection after running jobs.	2017-10-11 17:17:03 +08:00
Sam	9b4fd0b26b	correct multisite issues with scheduler	2017-10-11 18:46:53 +11:00
Sam	61f32ed431	FIX: we can not namespace eval automatically, it is impossible	2017-10-11 16:41:26 +11:00
Sam	6b4a1af160	FIX: don't attempt to schedule if there is no next run	2017-10-11 14:27:16 +11:00
Sam	233299982f	keep time consistent, we always use to_i	2017-10-11 14:26:50 +11:00
Sam	4ea87b5ab8	Merge branch 's3_refactor'	2017-10-09 10:27:52 +11:00
Sam	a8b4255bae	Correct rule installation in AWS	2017-10-09 10:26:58 +11:00
Robin Ward	127c13314a	We can use avatar_template here rather than recreating the logic	2017-10-06 14:02:43 -04:00
Neil Lalonde	7ed522c890	Version bump to v1.9.0.beta12	2017-10-06 11:28:49 -04:00
Régis Hanol	3bdd8f57c1	FIX: invited staged users would sometimes not get notified of replies	2017-10-06 16:37:28 +02:00
Gerhard Schlager	1477a0e910	Adds a rake task for refreshing posts received via email ... This is useful when the email_reply_trimmer gem was updated and you want to apply those changes to existing posts.	2017-10-06 14:29:11 +02:00
Guo Xiang Tan	4552840e54	REFACTOR: DRY update code that uses duplicated logic.	2017-10-06 14:33:38 +08:00
Sam	70bb2aa426	FEATURE: allow specifying s3 config via globals ... This refactors handling of s3 so it can be specified via GlobalSetting This means that in a multisite environment you can configure s3 uploads without actual sites knowing credentials in s3 It is a critical setting for situations where assets are mirrored to s3.	2017-10-06 16:20:01 +11:00
Guo Xiang Tan	4ba5e678d8	Require dependencies to enable live reload in dev for Sidekiq.	2017-10-06 11:39:00 +08:00
Robin Ward	0c84352386	Add support for transformations	2017-10-05 16:24:58 -04:00
Robin Ward	07d04aba1d	Support {{unless}} in virtual dom templates	2017-10-05 14:35:07 -04:00
Guo Xiang Tan	b2127600fb	Remove use of concurrent timer for Redis failover. ... * Uses the same logic for Postgres failover.	2017-10-05 15:57:08 +08:00
Neil Lalonde	f5a2ed99b0	FIX: deleting category background images sometimes has no effect	2017-10-04 17:04:37 -04:00
Robin Ward	051b49efdb	FIX: Properly encode string literals in hbs compiler	2017-10-04 15:53:06 -04:00
Neil Lalonde	ddbd1d5ab8	allow regex options on username site settings	2017-10-04 15:08:51 -04:00
Neil Lalonde	c29334cf23	FEATURE: the hide_email_address_taken setting works with the change email address form in user preferences	2017-10-04 11:41:25 -04:00
Sam	a4d4db4f0c	PERF: code not correctly caching git commands ... Every check for Discourse version could result in shelling out.	2017-10-04 14:22:38 +11:00
Kyle Zhao	0342324b47	FEATURE: support regex in rake post:remap (#5201)	2017-10-04 11:47:53 +11:00
Gerhard Schlager	9ff1c23a38	fix typo	2017-10-04 00:01:33 +02:00
Gerhard Schlager	7f50380221	FIX: respect email domain whitelist/blacklist when creating staged users	2017-10-03 16:36:08 +02:00
Gerhard Schlager	76706f9144	FIX: don't create staged users when incoming email is rejected ... FIX: don't send subscription mail to new users	2017-10-03 16:36:08 +02:00
Sam	5b96463c40	in production there is no cached it seems	2017-10-03 18:27:09 +11:00
Sam	ac01885b60	FEATURE: rake tasks for uploading assets to S3 ... This opens the door to serving application.js and so on from s3. Also updates s3 gem for some tagging support	2017-10-03 18:00:53 +11:00
Guo Xiang Tan	3e53dbcade	UX: Only include tag hashtag postfix when necessary. ... https://meta.discourse.org/t/links-to-tags-not-working-in-final-post-unless-autocompleted/69884/6?u=tgxworld	2017-10-03 13:54:50 +08:00
Robin Ward	823936ca9c	A plugin API to catch exceptions	2017-10-02 12:05:12 -04:00
Régis Hanol	47e79570cc	FIX: frequent posters wasn't displaying the correct information	2017-10-02 17:47:04 +02:00
OsamaSayegh	79f3d299a1	Don't allow category definition topics to be converted to PMs (#5216)	2017-10-02 10:04:58 +02:00
Arpit Jalan	df09599531	FIX: use different method name for topic rake task ... https://kevinjalbert.com/defined_methods-in-rake-tasks-you-re-gonna-have-a-bad-time/ cc @gschlager	2017-09-29 22:47:03 +05:30
Robin Ward	00b190af75	Revert "A safe way to create class variables in a multisite environment." ... The approach taken by this interface was flawed. We need a better solution.	2017-09-29 11:06:12 -04:00
Robin Ward	0caf6a0f7d	Support for HTML values in widget hbs templates	2017-09-29 09:56:14 -04:00
Sam	f6fdc1ebe8	FEATURE: flexible crawler detection ... You can use the crawler user agents site setting to amend what user agents are considered crawlers based on a string match in the user agent Also improves performance of crawler detection slightly	2017-09-29 12:31:50 +10:00
Robin Ward	df81d109e5	The ability to attach attrs when embedding widgets	2017-09-28 16:08:43 -04:00
Neil Lalonde	502f910eb5	Version bump to v1.9.0.beta11	2017-09-28 15:27:46 -04:00
Robin Ward	e980322ed6	Allow hbs widgets to access their parent state	2017-09-28 15:19:44 -04:00
Robin Ward	34f98f362f	Add a plugin hook to specify a class on the body of the document	2017-09-28 13:17:09 -04:00
Robin Ward	07e84a3afa	FIX: Hack our title retriever so that it parses YouTube URLs	2017-09-28 09:30:22 -04:00
OsamaSayegh	ab68379abb	Use PostDestroyer to delete topics when performing bulk operation (#5202) ... * Use `PostDestroyer` to delete topics when performing bulk operation This PR should fix this bug: https://meta.discourse.org/t/bulk-deletion-of-topics-not-logged/50407?u=osama * failing test	2017-09-28 14:22:49 +02:00
Sam	8ecf313a81	FIX: correctly raise errors when downloads fail ... This corrects an issue where we are hitting Gravatar for 404 over and over Also ensures file download properly reports errors	2017-09-28 16:35:43 +10:00
Guo Xiang Tan	426d2178c3	Fix undefined variable in TopicCreator.	2017-09-28 12:25:42 +08:00
Guo Xiang Tan	3e6bf38394	Merge pull request #5207 from tgxworld/try_travis_fix ... Fix randomly failing test.	2017-09-28 10:56:05 +08:00
Guo Xiang Tan	d4388f54a2	FIX: Use exact patht to ensure we always redirect with the right format.	2017-09-28 10:29:41 +08:00
Sam	b80320da5e	no verbose logging for failed downloads of gravatars	2017-09-28 11:32:26 +10:00
Régis Hanol	165b388158	fix indentation	2017-09-28 01:07:43 +02:00
Régis Hanol	3a75242c38	add more logs to pull hotlinked images	2017-09-28 01:00:13 +02:00
Robin Ward	3e13becf33	A safe way to create class variables in a multisite environment. ... This should allow plugins to set class variables that will not stomp on other plugins.	2017-09-27 13:00:47 -04:00
Guo Xiang Tan	5324c01209	FIX: Don't raise an error if reading from URL timeout.	2017-09-27 14:53:22 +08:00
Robin Ward	460ed3c8cf	Revert "Allow NotFound to specify an optional Location for the resource" ... This reverts commit 4ae66c9e01.	2017-09-26 12:58:24 -04:00
Robin Ward	4ae66c9e01	Allow NotFound to specify an optional Location for the resource	2017-09-26 09:10:18 -04:00
Guo Xiang Tan	367fb1c524	FIX: Onebox fails on encoded URL. ... https://meta.discourse.org/t/onebox-breaks-if-theres-chinese-text-in-url/67364	2017-09-26 18:34:54 +08:00
Guo Xiang Tan	c25730935e	FIX: Do not include non-human users on suspected users list. ... https://meta.discourse.org/t/discobot-is-a-suspect-user/70558	2017-09-26 15:04:08 +08:00
Guo Xiang Tan	c06b782cab	PERF: Reduce number of topics to filter while querying for unread.	2017-09-26 12:36:52 +08:00
Robin Ward	81f2b38b78	FIX: Don't include flags on non-human users	2017-09-25 16:15:48 -04:00
Robin Ward	d1ebc62065	The ability to display errors on flagging actions.	2017-09-25 12:28:01 -04:00
Robin Ward	561fa7d0cd	FEATURE: Site Setting to hide suspension reason on the public profile	2017-09-25 12:25:14 -04:00
Robin Ward	d7c37d9369	Add front end service for staff controls	2017-09-25 12:25:14 -04:00
Robin Ward	5cf50f0034	Adjust flagged posts to use the store	2017-09-25 12:25:14 -04:00
Robin Ward	5e69217793	Add filtering support to flags	2017-09-25 12:25:14 -04:00
Robin Ward	40eba8cd93	FEATURE: View flags grouped by topic	2017-09-25 12:25:14 -04:00
Guo Xiang Tan	9540b952fd	Fix broken condition in PostgresqlFallbackAdapter.	2017-09-25 13:48:59 +08:00
Guo Xiang Tan	23b787e0a6	Require dependency otherwise it causes Sidekiq to lock up in development.	2017-09-25 13:48:59 +08:00
Guo Xiang Tan	5be5def217	PERF: Bypass AR and just use raw SQL.	2017-09-25 13:48:59 +08:00
Guo Xiang Tan	77d4c4d8dc	Fix all the errors to get our tests green on Rails 5.1.	2017-09-25 13:48:58 +08:00
Gerhard Schlager	e08b5feb8a	improved status output during auto-closing and ignore deleted topic timers	2017-09-21 10:58:09 +02:00
Gerhard Schlager	26d10370c6	Adds a rake task for applying auto-close to old topics	2017-09-20 15:49:53 +02:00
Régis Hanol	8ed318c4fe	display 'similar to' earlier when composing a post	2017-09-16 01:03:29 +02:00
Régis Hanol	32972de2d7	Version bump to v1.9.0.beta10	2017-09-16 00:55:41 +02:00
Guo Xiang Tan	1a9762a9c0	Fixed private group messages being exposed in suggested topics. ... Revert "Revert "PERF: Avoid unnecessary expensive joins if possible."" This reverts commit d9714c21c8.	2017-09-15 23:40:53 +08:00
Gerhard Schlager	6e04f05173	that shouldn't have been there...	2017-09-15 17:33:31 +02:00
Gerhard Schlager	d51eee4dbc	FIX: don't try to send a rejection message when the sender was not detected	2017-09-15 17:30:02 +02:00
Gerhard Schlager	a2187b0acd	FIX: better error handling for incoming emails	2017-09-15 17:30:02 +02:00
Guo Xiang Tan	d9714c21c8	Revert "PERF: Avoid unnecessary expensive joins if possible." ... This reverts commit f3fadf41b7. * This ended up exposing group pms to users that are not part of a group.	2017-09-15 22:22:07 +08:00
Arpit Jalan	041ace5d3b	new rake task to defer all flags	2017-09-15 16:42:58 +05:30
Régis Hanol	797936d2c5	FIX: don't leak whisper count in user card	2017-09-14 20:08:16 +02:00
Robin Ward	8c2d6118ff	Remove some of the last few fa-icon helpers	2017-09-14 11:20:36 -04:00
Neil Lalonde	f698de0bbf	Version bump to v1.9.0.beta9	2017-09-14 11:08:22 -04:00
Guo Xiang Tan	de46d59a94	Remove comment that is no longer relevant.	2017-09-14 19:57:50 +08:00
Guo Xiang Tan	195982fd41	PERF: Remove N+1 query when generating posters summary.	2017-09-14 12:07:35 +08:00