Arpit Jalan
24338fbbe8
FEATURE: replace PM tags dropdown with a dedicated tags page
2018-03-13 13:06:58 +05:30
Guo Xiang Tan
2ad2ed2eb2
FIX: Couldn't move a topic into the uncategorized category.
2018-03-13 10:20:47 +08:00
Guo Xiang Tan
d5c828213f
FIX: Circular references warning in TopicTrackingState.
2018-03-13 08:35:15 +08:00
Neil Lalonde
ab2f3e43eb
FIX: excerpts in summary email are too short when there are images or links
2018-03-12 18:12:09 -04:00
Robin Ward
65ac80b014
FEATURE: Log Staff edits in Staff Action Logs
...
Why? Some edits by staff are not tracked. For example, during the grace
period, or via the flags/silence dialog.
If a staff member is editing someone else's post, it now goes into the
Staff Action Logs so it can be audited by other staff members.
2018-03-12 13:51:40 -04:00
Arpit Jalan
82143a421c
FIX: max topic invitations per day should apply on PM invites as well
...
FIX: do not apply `max topic invitations per day` on email invites
2018-03-12 23:17:58 +05:30
Gerhard Schlager
d243b82fb3
FIX: Calculation of text length for <details> in excerpt was wrong
2018-03-12 16:55:23 +01:00
Sam
758b9a7dda
FEATURE: prototype of local theme directory watcher
...
(note this will be documented a bit late)
2018-03-12 18:36:06 +11:00
Leo McArdle
89f41f8236
FIX: error when group_in_subject enabled but no group in pm
2018-03-11 12:22:11 +00:00
Arpit Jalan
f862122978
FIX: do not log personal message view if there exists a similar log in previous hour
2018-03-11 09:23:32 +05:30
Arpit Jalan
12706c4b29
FEATURE: support markdown rendering for embedded posts
2018-03-11 08:00:48 +05:30
Michael Brown
3c3d205180
FIX: sso_overrides_username may inappropriately change the username if the case changed
2018-03-09 16:06:55 -05:00
Arpit Jalan
aac7796124
FIX: do not show tags with 0 count on /tags page
2018-03-09 20:57:31 +05:30
Gerhard Schlager
dc77cce8d9
FIX: Create notifications for mentions in PMs
2018-03-09 11:04:29 +01:00
Sam
39e679d3cb
FEATURE: allow themes to live in private git repos
...
This feature allows themes sourced from git to live on private
servers, it automatically generates key pairs.
2018-03-09 16:14:38 +11:00
Neil Lalonde
34a0e79bec
FIX: use digest_min_excerpt_length site setting in summary emails
2018-03-08 23:35:10 -05:00
Sam
5b6e49ae1d
FEATURE: split out max diff to 2 settings
...
We trust staff + tl2 and up to perform edits in grace period.
Allow them significantly more edit room in grace period prior to storing
a revision.
editing_grace_period_max_diff_high_trust applies to users with tl2 and up.
So
tl0 / 1 : we store an extra revision if more than 100 chars change
tl2 and up : we store an extra revision if more than 400 chars change
We may tweak these numbers as we go.
2018-03-09 11:58:50 +11:00
Arpit Jalan
4b23634092
FIX: converting topic to message for a second time was broken
2018-03-08 17:59:04 +05:30
Arpit Jalan
0c2be8b775
Merge pull request #5655 from techAPJ/pm-tags-dropdown
...
FEATURE: filter personal messages by tags
2018-03-08 16:30:38 +05:30
Arpit Jalan
a8149f8969
FIX: user should not be able to invite to PM if trust level requirment not met
...
FIX: when personal messages are disabled let user invite to a public topic
2018-03-08 14:59:04 +05:30
Arpit Jalan
c29660c8f1
FEATURE: filter personal messages by tags
2018-03-08 14:42:07 +05:30
Simon Cossar
88fdc926d1
Move external_id from UserSerializer to CurrentUserSerializer ( #5658 )
2018-03-07 22:54:31 -05:00
Sam
b57d4c87a4
FEATURE: update CommonMark to version 0.28
2018-03-08 12:19:53 +11:00
Sam
e162cd16b6
FEATURE: editing_grace_period_max_diff to force revisions in grace period
...
If a user performs a substantive edit of 20 chars or more during grace period
we will store a revision to track the change
This allows for better auditing of changes that happen during the grace period
2018-03-07 18:34:34 +11:00
Guo Xiang Tan
3045c589f6
FIX: Publish live messages to both team inbox and archive on update.
2018-03-07 14:01:20 +08:00
Guo Xiang Tan
5169be6080
FIX: User archiving message should also publish to sent section.
2018-03-07 11:39:23 +08:00
Guo Xiang Tan
bef35f7be5
FIX: User archive messages should only publish to the user.
2018-03-07 11:28:29 +08:00
Robin Ward
81780d8607
Merge remote-tracking branch 'origin/analyze-code-fix'
2018-03-06 13:16:37 -05:00
Gerhard Schlager
07649cd42d
FIX: email_domains_whitelist prevented creation of anonymous users
2018-03-06 18:14:53 +01:00
Robin Ward
c74d10cf34
FIX: Consider live links in <code> as links when counting
2018-03-06 11:46:12 -05:00
Guo Xiang Tan
1365bab0d7
FEATURE: Live updates for user's messages page.
...
https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189
2018-03-06 18:15:21 +08:00
Guo Xiang Tan
d576056cff
REFACTOR: Add basic tests for TopicTrackingState#publish_*.
...
* Ensure we don't publish events for PMs.
2018-03-06 17:37:53 +08:00
Sam
0134e41286
FEATURE: detect when client thinks user is logged on but is not
...
This cleans up an error condition where UI thinks a user is logged on
but the user is not. If this happens user will be prompted to refresh.
2018-03-06 16:49:31 +11:00
Sam
f0d5f83424
FEATURE: limit assets less that non asset paths
...
By default assets can be requested up to 200 times per 10 seconds
from the app, this includes CSS and avatars
2018-03-06 15:20:39 +11:00
Gerhard Schlager
8e48b339fa
Drop unused tables ( #5630 )
2018-03-05 17:27:30 -05:00
Robin Ward
17a615165c
FIX: Don't lock wiki posts when they're edited
2018-03-05 14:50:06 -05:00
Robin Ward
0f66a99eb2
Setting to prevent logging details when anonymizing
2018-03-05 14:38:18 -05:00
Arpit Jalan
003b03d939
allow staff to delete user if posts are 5 or less irrespective of delete_user_max_post_age
2018-03-05 23:31:29 +05:30
Joffrey JAFFEUX
ce1994beea
FIX: do not treat :: as a valid emoji
2018-03-05 15:35:24 +01:00
Guo Xiang Tan
07f1d90b88
FIX: Inviting a group that I am part of creates a notification.
...
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509/10?u=tgxworld
2018-03-05 13:51:32 +08:00
Guo Xiang Tan
42e0aaed61
FIX: Set first visit PM notification level to group default notification level.
...
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/21?u=tgxworld
2018-03-05 13:39:00 +08:00
Sam
9331b4849d
FEATURE: we need access to settings in theme js
2018-03-05 15:35:41 +11:00
OsamaSayegh
282f53f0cd
FEATURE: Theme settings (2) ( #5611 )
...
Allows theme authors to specify custom theme settings for the theme.
Centralizes the theme/site settings into a single construct
2018-03-04 19:04:23 -05:00
Robin Ward
31e3bf6d8d
FEATURE: New "Categories and Top" homepage style
...
Select this option if you want to show top topics on the homepage
instead of latest topics.
2018-03-03 14:26:57 -05:00
Robin Ward
cd6c5fc5fb
FIX: Disable "Make Personal Message" if they are disabled
2018-03-02 20:28:39 -05:00
Robin Ward
730201d423
New interface to upsert custom fields
2018-03-02 12:45:52 -05:00
Régis Hanol
6a78669ca3
FIX: 'reply by email addresses' site settings should allow email addresses without a 'reply_key' when 'find related post with key' is disabled
2018-03-02 17:53:18 +01:00
Arpit Jalan
2e202495a3
FIX: do not allow invite notifications from muted user/topic
2018-03-02 12:24:51 +05:30
Sam
d39d2b9352
FEATURE: whitelist data for themes
2018-03-02 14:52:09 +11:00
Guo Xiang Tan
939180efa8
FIX: Missing 2FA guards when sso is enabled or when local login is disabled.
2018-03-02 10:39:10 +08:00
Guo Xiang Tan
4f301905b6
Make rubocop happy.
2018-03-02 10:15:53 +08:00
Robin Ward
b3883f5c32
FIX: Don't lock a post on edit unless the raw changes
2018-03-01 20:40:19 -05:00
Guo Xiang Tan
5c93d07d2a
Remove duplication of params in tests.
2018-03-02 09:25:46 +08:00
Sam
75172024ca
SECURITY: ensure users have permission when moving categories
2018-03-02 12:13:27 +11:00
Gerhard Schlager
79590e4bec
FIX: Merging users shouldn't add more than 1 secondary email
2018-03-01 17:50:13 +01:00
Gerhard Schlager
a7c50039de
FIX: Allow changing post owner even when topic validations fail
2018-03-01 17:31:58 +01:00
Gerhard Schlager
7a2183e8ab
FEATURE: rake task for merging users
2018-03-01 12:28:12 +01:00
Gerhard Schlager
fffd1a6602
FIX: Associated Instagram account was missing at some places
2018-03-01 12:26:40 +01:00
Guo Xiang Tan
fb75f188ba
FEATURE: Disallow login via omniauth when user has 2FA enabled.
2018-03-01 15:47:07 +08:00
Guo Xiang Tan
0fabf80dca
Migrate controller type specs to request types for omniauth.
2018-03-01 15:33:00 +08:00
Guo Xiang Tan
81ca3677f7
Add guard for nil in our RateLimiter.
2018-03-01 13:20:42 +08:00
Guo Xiang Tan
5d9f9c2614
FIX: RateLimiter max of zero or less should raise rate limit exceeded.
2018-03-01 13:14:46 +08:00
Guo Xiang Tan
47c41f474d
Missing indentation.
2018-03-01 13:12:13 +08:00
Guo Xiang Tan
947b6fdf46
FIX: Incorrect rate limit applied to topics invitation flow.
2018-03-01 12:50:00 +08:00
Robin Ward
b283bb2ba7
FIX: Don't include unlisted topic in groups/posts
2018-02-28 14:40:18 -05:00
Neil Lalonde
baf1c385eb
UX: when a post is blocked due to a watched word, message includes the word being blocked
2018-02-28 11:22:18 -05:00
Guo Xiang Tan
e7a7356986
Remove ancient votes code that is no longer used.
2018-02-28 14:37:22 +08:00
Guo Xiang Tan
902c5d11cf
FIX: Don't allow other flag actions after notify_moderator has happened.
...
https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5
2018-02-28 11:27:56 +08:00
scossar
51544047dc
Add external_id to User Serializer
2018-02-28 10:13:27 +08:00
Sam
f295a18e94
FIX: stop double counting net calls in logs
2018-02-28 10:45:11 +11:00
Gerhard Schlager
c22e56499a
FIX: Allow changing post owner even when validations fail
2018-02-27 15:46:20 +01:00
Guo Xiang Tan
486bbe9cc2
FIX: Auto re-opened topics should restore category auto close settings.
...
https://meta.discourse.org/t/topic-closed-temporarily-due-to-community-flags-overwrites-category-auto-close-timer/77421
2018-02-27 15:33:31 +08:00
Guo Xiang Tan
06891ce51d
FIX: Direct link to group activity page results in 400 error.
...
https://meta.discourse.org/t/following-a-direct-link-to-group-activity-results-in-400-error/81596
2018-02-27 13:43:22 +08:00
Guo Xiang Tan
519026a31f
Trim attributes that are not useful from WebHookTopicViewSerializer.
2018-02-27 11:28:31 +08:00
Guo Xiang Tan
66d620f7b1
FEATURE: Trigger topic webhook when topic status is updated.
2018-02-27 11:07:37 +08:00
Régis Hanol
fd33090646
FEATURE: automatically elides gmail quotes
2018-02-26 23:54:02 +01:00
Régis Hanol
26d5ae61dd
FIX: handle <pre> inside <blockquote> in html_to_markdown
2018-02-26 23:28:02 +01:00
Neil Lalonde
3313072957
Remove censored_pattern site setting, which is replaced by watched words
2018-02-26 16:29:27 -05:00
Gerhard Schlager
5ca5817902
FIX: Only likes should change the given daily likes
2018-02-26 22:27:18 +01:00
Régis Hanol
3be0294465
FIX: local post onebox was always pointing to 1st post
2018-02-26 16:05:35 +01:00
Régis Hanol
7d7f6faf40
FIX: properly render emojis in local oneboxes
2018-02-26 11:16:53 +01:00
Guo Xiang Tan
c1f53e1ece
UX: Invited users should watch PM topic once topic has been visited.
...
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/11
2018-02-26 17:58:58 +08:00
Guo Xiang Tan
65cb785374
Improve specs for Topic#invite.
2018-02-26 15:18:34 +08:00
Guo Xiang Tan
6a88f7db61
Notification created for wrong user after invite.
...
Introduced in c64f09b6b7
2018-02-26 13:21:19 +08:00
Guo Xiang Tan
6c1c5fe2d6
Fix the build take 2.
2018-02-26 13:09:13 +08:00
Guo Xiang Tan
1b5d955a34
Fix the build.
2018-02-26 12:46:15 +08:00
Guo Xiang Tan
c64f09b6b7
REFACTOR: Simplify and DRY Group#invite.
2018-02-26 11:59:07 +08:00
Arpit Jalan
b9a669ba32
FIX: do not log personal message view if user can't see the message
2018-02-25 22:39:25 +05:30
Régis Hanol
0559a4736a
FIX: don't double request when downloading a file
2018-02-24 12:35:57 +01:00
Gerhard Schlager
23498e54aa
Fix the build
2018-02-23 13:35:15 +01:00
Arpit Jalan
ff12dee922
make rubocop happy
2018-02-23 15:25:15 +05:30
Arpit Jalan
709f201bd4
FIX: update group user count when bulk adding users
2018-02-23 14:29:56 +05:30
Guo Xiang Tan
ea1733ca64
Fix failing spec.
2018-02-23 11:31:10 +08:00
Guo Xiang Tan
1f74509a75
FIX: 2FA prompt incorrectly displayed on admin login page.
2018-02-23 11:05:39 +08:00
Robin Ward
69af881f7f
New site setting trusted_users_can_edit_others
...
The default is true to keep with previous discourse behavior. If
disabled, high trust level users cannot edit the topics or posts of
other users.
2018-02-22 20:39:24 -05:00
Guo Xiang Tan
dd26bbe868
Merge pull request #5610 from discourse/pm-tags
...
FEATURE: Allow staffs to tag PMs
2018-02-23 07:07:41 +08:00
Vinoth Kannan
7cbda949f1
REFACTOR: New spec tests and code improvement
2018-02-22 20:27:02 +05:30
Régis Hanol
7a13e50aa6
fix build
2018-02-22 11:17:49 +01:00
Maja Komel
76a2fc3d07
UX: Add og metadata for groups.
...
https://meta.discourse.org/t/onebox-for-groups/79155
2018-02-22 15:03:41 +08:00
scossar
9d0807224b
Don't enqueue topic webhook unless a post has a topic
2018-02-22 14:34:59 +08:00
Guo Xiang Tan
964624f3ab
FIX: No error displayed when 2FA token is invalid on admin login page.
2018-02-22 09:45:57 +08:00
Vinoth Kannan
84867c1c07
Rename site setting to allow_staff_to_tag_pms from allow_staff_to_tag_in_pm
2018-02-22 06:48:34 +05:30
Sam
720e1965e3
FEATURE: add category suppress from latest
...
In the past we used suppress_from_homepage, it had mixed semantics
it would remove from category list if category list was on home and
unconditionally remove from latest.
New setting explicitly only removes from latest list but leaves the
category list alond
2018-02-22 09:56:35 +11:00
Vinoth Kannan
2b509eaa91
Merge branch 'master' into pm-tags
2018-02-21 23:55:59 +05:30
Neil Lalonde
81e873138f
FIX: error when deleting a tag associated with a deleted topic
2018-02-21 12:35:53 -05:00
Vinoth Kannan
4d842ef2d5
Additional spec test function added and fixed the existing
2018-02-21 21:47:02 +05:30
Vinoth Kannan
84ce1acfef
FEATURE: Allow staffs to tag PMs
2018-02-21 20:11:46 +05:30
Gerhard Schlager
97e19a7d02
Fix the build
2018-02-21 11:26:41 +01:00
Guo Xiang Tan
c7c8f38eac
Use proper encoding for email fixtures.
2018-02-21 17:06:35 +08:00
Vinoth Kannan
1446753fd2
FIX: Include deleted topics in the post serializer
2018-02-21 14:31:52 +05:30
Guo Xiang Tan
b16471edfb
FIX: Invalid token error incorrectly displayed on email login page.
2018-02-21 15:46:53 +08:00
Guo Xiang Tan
8964e75ad6
Merge pull request #5612 from discourse/featheredtoast-two-factor-login
...
Featheredtoast two factor login
2018-02-21 15:00:10 +08:00
Guo Xiang Tan
14f3594f9f
Review Changes for f4f8a293e7.
2018-02-21 14:55:49 +08:00
Arpit Jalan
94fb8094c6
further optimize spec
...
thanks @tgxworld for the review.
2018-02-21 11:32:40 +05:30
Robin Ward
5c40ae9e63
FIX: Links in quotes should be counted for rate limits
2018-02-20 20:42:01 -05:00
Jeff Wong
f4f8a293e7
FEATURE: Implement 2factor login TOTP
...
implemented review items.
Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator
add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests
add qunit tests - password reset, preferences
fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.
Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP
add two factor to email signin link
rate limit if second factor token present
add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
Guo Xiang Tan
b6e82815bd
Fix rspec description.
2018-02-21 09:02:42 +08:00
Robin Ward
3ea272f4f1
New setting: minimum trust level to embed images in a post
2018-02-20 20:00:06 -05:00
Régis Hanol
0799831dbe
FIX: use the avatar of the post rather than the topic in local oneboxes
2018-02-20 19:49:39 +01:00
Arpit Jalan
a4bc54a686
FIX: strip zero width spaces from topic title
2018-02-21 00:12:39 +05:30
Arpit Jalan
ed422285f0
optimize spec
2018-02-20 22:03:13 +05:30
Sam
86d12bd44b
FEATURE: search within title using in:title
...
Also
- Significantly improved search ranking, title is treated most strongly
- Adds tag names to the index
- Run search re-indexer more aggressively
- Re-index topic and all posts on category change
2018-02-20 14:41:21 +11:00
Régis Hanol
6b67192d99
fix the build
2018-02-19 22:52:54 +01:00
Régis Hanol
60ec483caa
FIX: include title in local onebox when linking to a different topic
2018-02-19 22:40:14 +01:00
Arpit Jalan
c419c26f56
FEATURE: new site setting 'max_emojis_in_title'
2018-02-19 18:15:26 +05:30
Gerhard Schlager
b6277e208b
FIX: Cookies header didn't have the right format
2018-02-19 12:46:57 +01:00
OsamaSayegh
f3815cd785
FEATURE: New site setting for additional allowed filetypes for staff ( #5364 )
...
* FEATURE: New site setting for additional allowed filetypes for staff
* Problematic variable name
* feedback
* small issues
* fix indentation
* failing tests
* Remove message bus and fix minor issues
* Missed this message bus
2018-02-19 10:44:24 +01:00
Leo McArdle
5d9d0fcb4f
FEATURE: add setting which adds group name to PM email subject ( #5475 )
2018-02-19 10:20:17 +01:00
Régis Hanol
61930e092a
FIX: support incoming emails with just an attachment
2018-02-16 18:14:56 +01:00
Sam
cda3f72ab8
SECURITY: don't onebox whispers
2018-02-16 08:57:20 +11:00
Sam
57e140dc07
FIX: oneboxing to private messages
2018-02-16 08:00:22 +11:00
Sam
e456ae1b6c
Revert "Upgrade mail gem to drop dependency on mime-types."
...
This reverts commit 498cc15aa9
2018-02-16 07:04:22 +11:00
Régis Hanol
8e0da35857
FIX: allow local oneboxes to public topics/posts in PM
2018-02-15 18:14:41 +01:00
Arpit Jalan
c66405df7e
correct spec description
2018-02-15 17:49:57 +05:30
Guo Xiang Tan
498cc15aa9
Upgrade mail gem to drop dependency on mime-types.
...
Boot Memory Usage
```
Total allocated: 225695379 bytes (1990663 objects)
Total retained: 32795116 bytes (291607 objects)
```
```
Total allocated: 218342892 bytes (1897350 objects)
Total retained: 30123426 bytes (261198 objects)
```
2018-02-15 16:24:26 +08:00
Sam
94b2c70c0d
PERF: remove oga gem
...
oga gem is automatically required by the aws gem
the oga gem retains about 1mb of memory, aws now uses nokogiri
This also removes the html normalize from the pretty text specs that was
a fair bit buggy as the polls test shows.
2018-02-15 14:36:40 +11:00
Robin Ward
b4aa0b096e
FIX: Couldn't like staff when allow_flagging_staff was set
2018-02-14 15:46:04 -05:00
Arpit Jalan
f07b1a5c05
FIX: activate user even if email token is already confirmed
2018-02-14 20:44:48 +05:30
Sam
38f4acd55a
FIX: rate limiter text is confusing, should not say daily
...
Also, adds easily parseable JSON so users can figure out
how long to wait when the API is limited. ("extras" "wait_seconds")
2018-02-14 15:29:50 +11:00
Sam
f028ffaf29
SECURITY: correct local onebox category checks
...
Also removes ugly "source_topic_id" from cooked posts
Patch was authored by @zogstrip
Signed-off-by: Sam <sam.saffron@gmail.com>
2018-02-14 10:40:46 +11:00
Gerhard Schlager
5a56746610
FIX: Embedded topic was not found when URL contained query string
2018-02-14 00:28:30 +01:00
Robin Ward
7348513848
FIX: Include post in staff action logs when silencing a user
2018-02-13 15:59:10 -05:00
Erick Guan
03b3e57a44
FEATURE: login by a link from email
...
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
Maja Komel
1c27d93dcf
anonymous shadow users are approved on creation if must_approve_users is enabled ( #5569 )
2018-02-13 01:58:38 -05:00
Vinoth Kannan
e924de71e7
Spec test to make sure we do not skip trashed post
2018-02-13 12:23:47 +05:30
Muhlis Cahyono
cc3cf6588b
FEATURE: Notification API Endpoints for Admins
...
* create/update/delete notification api with external url
* remove external url feature
* Fix Travis CI build error (add new line)
* Fix Travis CI build error
2018-02-13 01:38:26 -05:00
Robin Ward
4c9959f795
FIX: Don't allow silenced users to reach TL3
2018-02-12 17:20:11 -05:00
Neil Lalonde
1bafbc8c5c
Merge pull request #5576 from discourse/top-tags
...
PERF: a faster way to count tags used per category
2018-02-12 16:25:18 -05:00
Robin Ward
4dfe659189
Rename allow staff flags to allow flagging staff
2018-02-12 15:27:26 -05:00
Neil Lalonde
76c309fe6b
PERF: a faster way to count tags used per category
2018-02-12 15:16:47 -05:00
Robin Ward
6287631745
FEATURE: New site setting, allow staff flags, false by default
...
For some large communities, it makes sense to disable flagging of
staff posts.
2018-02-12 14:56:21 -05:00
Robin Ward
cee3337357
Don't allow users to auto-hide staff posts
2018-02-09 19:53:58 -05:00
Robin Ward
569e57f0a9
FIX: Delete the invalid auth cookie even if you hit the rate limit
2018-02-09 19:09:54 -05:00
Robin Ward
5466389f4e
FIX: Consider oneboxes links wrt to min_trust_level_to_post_links
2018-02-08 18:27:40 -05:00
Robin Ward
dedeb2deb8
FIX: Don't show the link button in the composer if linking is disabled
2018-02-08 12:56:10 -05:00
Gerhard Schlager
0ecdf90023
FIX: Validations could prevent moving posts
2018-02-08 13:36:13 +01:00
Gerhard Schlager
8ab6689f43
FIX: Preserve original date when moving first post
2018-02-08 12:55:32 +01:00
Gerhard Schlager
8765279c90
FIX: Customizing site texts ignored current locale for _MF keys
2018-02-07 16:57:08 +01:00
Gerhard Schlager
890ffb1eb5
FIX: overriding _MF translations worked only for English
2018-02-07 12:47:15 +01:00
Robin Ward
1bab15c757
FEATURE: A site setting for a minimum TL to post links
2018-02-06 18:07:58 -05:00
Robin Ward
b2b6dc68a6
FEATURE: a setting to customize the minimum TL to flag a post
2018-02-06 17:12:27 -05:00
Sam Saffron
df8e43abdd
use lazy & instead of try
...
unregister ip skipper in test
raise if called when a skipper is in play
2018-02-06 10:38:15 +11:00
Neil Lalonde
d7e90edeb5
PERF: Tl3Promotions job can limit the number of TL3 candidates by using some simple requirements in the query
2018-02-05 17:54:36 -05:00
Robin Ward
eefd226611
Add extensibility point to request_tracker to skip IP addresses
...
This is useful if you want to run a per IP rate limiter but want to be
able to skip some IPs with custom logic.
2018-02-05 17:49:40 -05:00
Régis Hanol
130974d58d
FIX: automatically unsilence users
2018-02-05 17:45:47 +01:00
Régis Hanol
a7603b1cfb
remove unused file
2018-02-05 16:58:57 +01:00
Vinoth Kannan
e8559f222c
FIX: After moving the posts topic timestamp should be updated with newest post
2018-02-02 19:30:52 +05:30
Robin Ward
8ff4104555
Many enhancements to the flagging / suspending interface.
2018-02-01 17:13:02 -05:00
Neil Lalonde
ef2a7ac0f7
FIX: admin reports would sometimes return fewer than 30 days of data, causing current 30 day period counts to be too small and prev30day counts to count the wrong days
2018-02-01 15:50:51 -05:00
Arpit Jalan
350cbb1700
deprecate existing site settings
2018-02-01 13:25:29 +05:30
Arpit Jalan
f88b8a8945
rename 'default_email_private_messages' to 'default_email_personal_messages'
2018-02-01 13:25:29 +05:30
Arpit Jalan
7cda3a37af
rename 'private_email_time_window_seconds' to 'personal_email_time_window_seconds'
2018-02-01 13:25:29 +05:30
Arpit Jalan
7e48c47d37
rename 'enable_private_email_messages' to 'enable_personal_email_messages'
2018-02-01 13:25:29 +05:30
Arpit Jalan
ff0376a80b
rename 'enable_private_messages' to 'enable_personal_messages'
2018-02-01 13:25:29 +05:30
Arpit Jalan
25ec077eca
rename 'min_private_message_{post/title}_length' to 'min_personal_message_{post/title}_length'
2018-02-01 13:25:29 +05:30
Sam
ee0d3f15c1
FEATURE: allow better fidelity for auto linkify, disable most tlds based linkify
...
New site settings:
enable_markdown_linkify: which is default on, auto links https:// and http:// and mail://
markdown_linkify_tlds: which allows control of what tlds get autolinked for cases such as www.site.com, default is com|net|gov
2018-02-01 13:22:38 +11:00
Sam
f2e7b74d88
FIX: don't return 200s when login is required to paths
...
When running `ensure_login_required` it should always happen prior to
`check_xhr` cause check xhr will trigger a 200 response
2018-02-01 12:26:45 +11:00
Régis Hanol
7d2283167a
UX: only crops images taller than 18:9 instead of 16:9
2018-01-31 22:31:16 +01:00
Régis Hanol
4bcf9c5bf3
FIX: only count 'human' users in group.user_count
2018-01-31 21:55:01 +01:00
Régis Hanol
b2f18fc98f
FIX: system user edits should not generate notifications
2018-01-30 22:21:07 +01:00
Maja Komel
018cb7f36b
add a custom user onebox ( #5542 )
...
* add custom user onebox
* add specs
2018-01-30 11:03:08 +01:00
Maja Komel
330912e1e5
FIX: allowed href scheme link can start with a + ( #5537 )
...
* allowed href scheme link can start with a +
* allow tel:// links only to start with +
* add missing semicolon
* add test
2018-01-30 11:02:23 +11:00
Sam
f3502853fa
correct spec regression
2018-01-30 08:54:37 +11:00
Sam
f946db4afe
FIX: inline oneboxer min title length of 2
...
also: cache mini onebox misses as well to cut down traffic
2018-01-30 08:40:04 +11:00
Régis Hanol
77ac14d475
prevent users with a tiny number of posts to dominate the 'new user of the month' leaderboard
2018-01-29 12:09:17 +01:00
Arpit Jalan
8ab585e25f
add more tests for 'log private message views' feature
2018-01-29 13:11:20 +05:30
Sam
fa5880e04f
PERF: ability to crawl for titles without extra HEAD req
...
Also, introduces a much more aggressive timeout for title crawling
and introduces gzip to body that is crawled
2018-01-29 15:40:12 +11:00
Arpit Jalan
1f6adbea5c
FEATURE: log private message views
2018-01-29 08:08:08 +05:30
Robin Ward
44e2038b53
Setting to automatically lock posts when edited by staff
2018-01-26 14:01:30 -05:00
Robin Ward
6b04967e2f
FEATURE: Staff members can lock posts
...
Locking a post prevents it from being edited. This is useful if the user
has posted something which has been edited out, and the staff members don't
want them to be able to edit it back in again.
2018-01-26 14:01:30 -05:00
Neil Lalonde
179ecee11e
FIX: featured links are 'undefined' in suggested topics
2018-01-25 14:40:07 -05:00
Arpit Jalan
7b4e6d508b
improve reviving_old_topic education message
2018-01-26 00:06:53 +05:30
Gerhard Schlager
b784c1eda4
FIX: Remove all notifications of staged user during sign-up
2018-01-25 14:58:43 +01:00
Gerhard Schlager
d9515c37b3
FIX: Show message from discobot when staged user signs up
2018-01-25 14:58:43 +01:00
Gerhard Schlager
eb52c5469e
FEATURE: Allow plugins to register a new locale
2018-01-25 14:57:41 +01:00
Gerhard Schlager
ce060e2b86
FIX: Server didn't use default_locale as fallback locale
2018-01-25 14:57:41 +01:00
Sam
adae963751
ensure we do not override charset for content type
2018-01-25 18:43:42 +11:00
Sam
3492a91056
FEATURE: allow site operators to disable emoji shortcuts
2018-01-24 12:21:44 +11:00
Robin Ward
782d75069e
FIX: UX improvements for system messages when PMs are disabled
2018-01-23 13:12:11 -05:00
Robin Ward
17ebfd1715
FIX: Don't show suggested messages if private messages are disabled
2018-01-23 12:05:44 -05:00
Guo Xiang Tan
80c41a0e59
Merge pull request #5510 from discourse/add-posts-count-to-web-hook-post-serializer
...
Feature: add topic posts count to webhook post serializer
2018-01-23 07:46:59 +08:00
Régis Hanol
cbb321658f
FIX: support for generating excerpt when nesting <details> blocks
2018-01-22 19:17:35 +01:00
Régis Hanol
5c1eaeca9e
FIX: prevent users from moving whispers to new topic
2018-01-22 17:23:19 +01:00
Gerhard Schlager
dde0fcc658
FEATURE: Allow sending invites to staged users
2018-01-22 15:37:18 +01:00
Kyle Zhao
83c549bd31
FEATURE: grant badges in post admin wrench ( #5498 )
...
* FEATURE: grant badges in post admin wrench
* only grant manually grantable badges
* extract GrantBadgeController mixin
2018-01-22 14:10:53 +11:00
Sam
f26ff290c3
FEATURE: Shorten setting name to max_reqs
...
So it is consistent with other settings
2018-01-22 13:18:30 +11:00
Sam
47058b29d3
FEATURE: emit external_id field with user webhook
2018-01-22 10:09:26 +11:00
Sam
fc36f095a7
FIX: ensure proper header transfer (except for cache control)
...
allows discourse special headers to be visible on hijacked reqs
2018-01-21 14:26:42 +11:00
Guo Xiang Tan
54dc191a91
Update rails_multisite to 2.0.1.
2018-01-19 10:19:16 +08:00
Sam
12872d03be
PERF: run post timings in background
...
This means that if a very large amount of registered users hit
a single topic we will handle it gracefully, even if db gets slow.
2018-01-19 08:27:29 +11:00
Gerhard Schlager
2a22b90538
SECURITY: email domain whitelist could be bypassed
2018-01-17 21:45:32 +01:00
Robin Ward
34ed6088b9
FEATURE: New modal to show flags received for a user
2018-01-17 15:08:08 -05:00
scossar
22ca5a772d
Expect 41 keys in the serializer
2018-01-17 11:48:00 -08:00
Rafael dos Santos Silva
70c5f6ae17
Merge pull request #5489 from discourse/fix-shared-s3-cdn
...
FIX: Allow shared CDN for s3 and assets
2018-01-17 16:32:11 -02:00
Arpit Jalan
e04fb9a877
fix the build
2018-01-17 12:57:33 +05:30
Arpit Jalan
79eb9d7086
FEATURE: show header search results on search log term details page
2018-01-17 12:47:16 +05:30
Sam
b7023da894
PERF: reduce queries required for post timings
...
- also freezes a bunch of strings
- bypass active record for an exists query
2018-01-17 15:50:41 +11:00
Arpit Jalan
1208254961
FIX: validate presence of 'top menu' setting
2018-01-17 01:43:53 +05:30
Neil Lalonde
f274a5234f
FIX: topic and category exporters were only exporting users who created the first post
2018-01-16 12:51:53 -05:00
Sam
d7657d8e47
correct specs, ensure crawler layout only applies to html
2018-01-16 16:28:11 +11:00
Sam
7b562d2f46
FEATURE: much improved and simplified crawler detection
...
- phase one does it match 'trident|webkit|gecko|chrome|safari|msie|opera'
yes- well it is possibly a browser
- phase two does it match 'rss|bot|spider|crawler|facebook|archive|wayback|ping|monitor'
probably a crawler then
Based off: https://gist.github.com/SamSaffron/6cfad7ea3e6df321ffb7a84f93720a53
2018-01-16 15:41:45 +11:00
Neil Lalonde
ce79ec0127
FIX: subfolder: top referred topics report was missing subfolder in links
2018-01-15 17:28:35 -05:00
Arpit Jalan
785d063a6b
Merge pull request #5496 from techAPJ/admin-graphs
...
FIX: graphs should go to zero for missing dates
2018-01-15 11:10:29 +05:30
Arpit Jalan
b7ba490df7
FIX: graphs should go to zero for missing dates
2018-01-15 10:16:34 +05:30
Sam
906f189914
have to clear debounce cache for tests
2018-01-15 15:29:54 +11:00
Sam
d9788a5fb3
missed a spec
2018-01-15 14:51:04 +11:00
Sam
bf68d394f4
PERF: handle debounce in redis cause SQL can be slow
2018-01-15 14:48:28 +11:00
Neil Lalonde
ad58a1743b
rename topic_list.tags to topic_list.top_tags
2018-01-12 16:35:27 -05:00
Neil Lalonde
6d68275ef9
don't show tag groups if they're restricted to categories you can't access
2018-01-12 14:25:42 -05:00
Sam
215c0d5569
FEATURE: allow system api to target users via external id or user id
...
usage ?api_key=XYZ&api_user_external_id=ABC
usage ?api_key=XYZ&api_user_id=123
2018-01-12 17:40:18 +11:00
Vinoth Kannan
988b13ac77
FIX: GitHub auth always asking to verify email for new users ( #5487 )
2018-01-12 15:17:29 +11:00
Sam
49ed382c2a
FIX: return 429 when admin api key is limited on admin route
...
This also handles a general case where exceptions leak out prior to being handled by the application controller
2018-01-12 14:15:26 +11:00
Rafael dos Santos Silva
b9a343afe7
FIX: Allow shared CDN for s3 and assets
2018-01-12 01:08:15 -02:00
Vinoth Kannan
b96ae14261
FEATURE: Display force_https warning in admin problems dashboard
2018-01-11 12:16:10 +05:30
Gerhard Schlager
9f7ae908d8
Add specs to check email domain whitelist/blacklist for To and Cc
2018-01-10 16:57:26 +01:00
Neil Lalonde
8f21c96ea5
FIX: don't downcase watched words on input since it can break the watched_words_regular_expressions setting
2018-01-09 16:51:59 -05:00
Arpit Jalan
672888f526
FIX: handle invalid password reset token
2018-01-09 23:48:17 +05:30
Jan Suchal
bc56d86a63
Support ruby 2.5.0
2018-01-09 16:03:17 +01:00
Arpit Jalan
6c1ebbb95c
add test case for csv BOM handling
2018-01-09 15:49:41 +05:30
Guo Xiang Tan
e90187cbf7
Merge pull request #5469 from tgxworld/add_guard_to_prevent_primary_email_from_being_reassigned
...
FIX: Add guard to prevent a primary `UserEmail` from being reassigned.
2018-01-09 13:35:08 +08:00
Sam
8ff5f5f2ef
FIX: cache admin locale file for 24 hours
2018-01-09 10:23:49 +11:00
Sam
cecd7d0d07
FEATURE: global rate limiter can bypass local IPs
2018-01-08 08:39:17 +11:00
Vinoth Kannan
e5affdf230
FIX: URI must be ascii only for URI.parse command
2018-01-07 02:31:35 +05:30
Joffrey JAFFEUX
642645ba9a
FIX: broken select badge as user title ( #5474 )
...
* FIX: broken select badge as user title
* selected id wasn’t pass to underlying component
* <none> was rendered as an html tag <none></none>
* overriding a badge name wouldn’t work as it was using badge.name and not badge.display_name
* adds a spec to ensure this behavior is correct
2018-01-05 16:58:15 +01:00
Gerhard Schlager
f086d28b30
FIX: Do not validate messages sent to mailing list mirror
2018-01-05 11:21:53 +01:00
Gerhard Schlager
e0d73a957d
FEATURE: Allow posting via email to read-only mailing list mirror category
2018-01-05 11:21:53 +01:00
Gerhard Schlager
d7cd7e4dc7
FIX: Never mark emails sent to mailing list mirror as auto-generated
2018-01-05 11:21:53 +01:00
Arpit Jalan
9030d3ef63
FIX: do not create duplicate topics
...
https://meta.discourse.org/t/duplicate-http-https-topics-are-randomly-created/77190
2018-01-04 23:53:52 +05:30
Guo Xiang Tan
8a3bbcb19a
FIX: Add guard to prevent a primary UserEmail from being reassigned.
2018-01-04 19:40:50 +08:00
Gerhard Schlager
ceb7590bcb
FIX: bounced email can contain multiple status codes
2018-01-03 17:59:20 +01:00
Guo Xiang Tan
9644569a28
FIX: Wildcard webhooks could send duplicated events.
2018-01-03 17:00:44 +08:00
Guo Xiang Tan
647cf7545d
Fix randomly failing spec.
2018-01-03 14:42:16 +08:00
Gerhard Schlager
38269c416d
FIX: return regular notification level for categories when not set by user
2017-12-30 20:36:58 +01:00
Guo Xiang Tan
805d1c25d3
Merge pull request #5451 from tgxworld/treat_non_ascii_urls_as_valid
...
Treat non-ascii URLs in `UrlValidator`.
2017-12-27 14:14:20 +08:00
Sam
a9e2fc59c4
FIX: [constructor] bbcode would cause markdown crash
2017-12-27 16:11:30 +11:00
Arpit Jalan
ef4c6c67ba
fix the build
2017-12-23 14:42:40 +05:30
Arpit Jalan
0514ac4ee2
FIX: verify presence of 'sso url' before enabling 'enable sso'
2017-12-23 13:30:49 +05:30
Régis Hanol
d6b22e6cc1
FIX: whitelist oneboxed iframes
2017-12-23 01:56:33 +01:00
Robin Ward
69a90f31fb
FEATURE: Allow Forums to disable the Backups feature
2017-12-21 15:22:04 -05:00
Gerhard Schlager
7b58afe677
FIX: ProcessPost job failed for posts that have no user
2017-12-21 14:45:59 +01:00
Guo Xiang Tan
4b51871f6a
Treat non-ascii URLs in UrlValidator.
2017-12-21 14:22:55 +08:00
Guo Xiang Tan
6ecf37c482
Improve URL validation to check for a valid host.
...
Parsing a URL with `URI` is not sufficient as the following cases
are considered valid:
URI.parse("http://https://google.com ")
=> #<URI::HTTP http://https//google.com >
2017-12-21 13:50:15 +08:00
Robin Ward
21e1b05c7e
FIX: Don't disable details when below truncate limit
2017-12-20 15:45:00 -05:00
Régis Hanol
7f69362d9d
FIX: external links in whisper ended up in a white page
...
FIX: clicking a link in a onebox wasn't properly extracting the post_id
2017-12-20 17:55:15 +01:00
Guo Xiang Tan
6c4ee9d5b5
FEATURE: Trigger user webhook when a user logs in/out.
...
https://meta.discourse.org/t/how-do-you-learn-how-to-build-these-plugins/57946/10?u=tgxworld
2017-12-20 17:47:30 +08:00
Philipp Daniels
6a2bce1931
FIX: Data loss on update of single user_field.
...
https://meta.discourse.org/t/api-data-loss-caused-by-changed-behaviour-of-custom-user-field-update/74990
2017-12-20 16:33:23 +08:00
Sam
7aa56fc9d9
refinement and test for batch mode on feature_topics
2017-12-20 13:58:05 +11:00
Arpit Jalan
eab66065d1
FEATURE: search log term details page ( #5445 )
2017-12-20 13:41:31 +11:00
Robin Ward
a0aca83c12
FIX: Broken spec
2017-12-19 17:55:41 -05:00
Robin Ward
b3fda0ea86
FIX: details tags broke excerpts
2017-12-19 17:28:55 -05:00
Régis Hanol
24e89b6b38
FIX: validates 'ThemeField' name when used in a SCSS variable
2017-12-19 16:10:44 +01:00
Guo Xiang Tan
fc6cb7bbe3
Merge pull request #5444 from tgxworld/remove_phantomjs
...
Switch to chrome headless mode instead of phantomjs.
2017-12-19 19:42:40 +08:00
Guo Xiang Tan
6a4f391e38
Switch to chrome headless mode instead of phantomjs.
2017-12-19 16:00:43 +08:00
Sam
57a1190b07
FIX: correct issue with search omitting words with multiple dots
...
Previously we used to break up words with dots incorrectly leading to
missing search terms
2017-12-19 16:04:24 +11:00
Guo Xiang Tan
30ddc1f222
Don't swallow errors when failing to create message for post action.
2017-12-19 10:58:26 +08:00
Guo Xiang Tan
b39d3a863d
FIX: moderators group wasn't being updated to be messagable by everyone.
...
https://meta.discourse.org/t/custom-flag-not-showing-text/76244
2017-12-19 10:14:56 +08:00
Sam
1abc276451
FIX: properly omit inactive and silenced users from directory
2017-12-19 12:53:59 +11:00
Guo Xiang Tan
97ceebb570
SECURITY: Don't pass email backup token to sidekiq as a parameter.
...
* This exposes the token in the Sidekiq dashboard which can be
viewed by an admin and defeats the purpose of using a token
in the download backup email ink.
2017-12-18 11:25:22 +08:00
Sam
5e90abfaea
FIX: use hijack for emoji uploads
2017-12-18 10:31:19 +11:00
Sam
81b3a4a3da
improve spec
2017-12-15 11:42:51 +11:00
Régis Hanol
b91f83eb7d
Ignore auto-quote/reply when counting replies
2017-12-15 00:38:14 +01:00
Régis Hanol
092c976d7c
FIX: prevent 💥 when selecting replies to posts quoting themselves
2017-12-15 00:23:51 +01:00
Neil Lalonde
3cbaea81bd
Merge pull request #5428 from discourse/fix-pending-users-count
...
FIX: incorrect pending_users_reminder user count
2017-12-14 14:05:37 -05:00
Guo Xiang Tan
f2565f6c7e
SECURITY: Any group can be invited into a PM.
2017-12-14 14:57:48 +08:00
Sam
96584403cd
SECURITY: prevent staged accounts from changing email
2017-12-14 17:16:49 +11:00
Sam
67aecff59c
FEATURE: store twitter supplied email for auditing
2017-12-14 15:54:32 +11:00
scossar
11050e5d10
Don't override count value that has been set by query.count
2017-12-13 18:48:46 -08:00
Régis Hanol
5db3d39b05
FIX: Post.reply_ids should also handle quotes
2017-12-14 00:43:48 +01:00
Régis Hanol
1b4483c942
FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts
2017-12-13 22:12:06 +01:00
Gerhard Schlager
f525d83b53
FIX: empty uploads and blank filenames caused errors during validation
2017-12-13 22:03:31 +01:00
Neil Lalonde
3f1d6a302e
FIX: links with query params to external sites fail to load if ga universal auto link domains is used
2017-12-13 13:58:44 -05:00
Guo Xiang Tan
7aee1e3083
Remove specs that makes the build very sad.
2017-12-13 17:51:52 +08:00
Guo Xiang Tan
d5293aeae2
Clean Topic#slug when SiteSetting.slug_generation_method changes.
...
https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/24?u=tgxworld
2017-12-13 16:11:07 +08:00
Sam
b998efdc94
FIX: do not send mailing list emails to unapproved users
2017-12-13 15:13:17 +11:00
Sam
a393d3bcbb
FIX: ensure staged accounts are always inactive
...
If for any reason active is stored in the user model, clear it out
prior to creating an account
2017-12-13 14:22:16 +11:00
Gerhard Schlager
a7c1b0c81f
FIX: path whitelist for embedded comments didn't work with non-ASCII chars
2017-12-12 20:17:46 +01:00
Gerhard Schlager
e30851e45a
Move escape_uri method to a more suitable place
2017-12-12 20:17:46 +01:00
Arpit Jalan
492af81e67
FIX: save registration_ip_address for staged users logging in via social auth
2017-12-12 17:41:16 +05:30
Régis Hanol
62a5b174e1
FIX: wasn't able to use the same username when taking over a staged account
2017-12-12 11:26:00 +01:00
Guo Xiang Tan
6ade508f39
FIX: Prevent 'rack.input' missing error.
2017-12-12 16:40:35 +08:00
Arpit Jalan
1d43d7f136
optimize spec
2017-12-12 13:00:53 +05:30
Arpit Jalan
ff6dda85b7
FIX: replace curly quotes to regular quotes in search terms
2017-12-12 11:17:28 +05:30
Arpit Jalan
d21db0f186
add a test case to verify presence of registration_ip_address for staged users
2017-12-11 21:33:00 +05:30
Guo Xiang Tan
365bd771d9
Fix the build.
2017-12-11 17:03:05 +08:00
Guo Xiang Tan
4bd5acec47
FIX: Topic#featured_link may contain more than a URL.
2017-12-11 16:36:19 +08:00
Arpit Jalan
3c56c9b637
FIX: strip webhook payload_url
2017-12-11 13:48:11 +05:30
Sam
63bdc4056d
More log suppressions for rate limit exceeded
2017-12-11 17:52:57 +11:00
Sam
4986ebcf24
FEATURE: optional default off global per ip rate limiter
2017-12-11 17:52:57 +11:00
Sam
68d3c2c74f
FEATURE: add global rate limiter for admin api 60 per minute
...
Also move configuration of admin and user api rate limiting into global
settings. This is not intended to be configurable per site
2017-12-11 11:07:22 +11:00
Robin Ward
74b9828731
FIX: Remove mentions filters from user and groups
...
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
Arpit Jalan
5003f07b2c
FEATURE: new site setting show_inactive_accounts
2017-12-07 19:22:41 +05:30
Joffrey JAFFEUX
f0ef307d2d
FIX: topic timer offset applied two times
...
timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone.
This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1 hour to your timezone offset.
2017-12-07 14:42:58 +01:00
Sam
47c44356f8
FIX: load balanced servers do not share monotonic clock
...
This means then when a service is load balanced and you reach rate limits
there was a case where they counting was way off
also remove the stub from clock_gettime cause we need to be super careful with
it, so we should probably just stub by hand when needed
2017-12-07 11:48:11 +11:00
Sam
90a55d6f7c
FIX: handle CORS in hijacked requests
2017-12-07 10:31:04 +11:00
Gerhard Schlager
16738cfb1b
FEATURE: convert plain text emails to markdown
2017-12-06 01:47:51 +01:00
Kyle Zhao
5f318a5241
FEATURE: Replace SimpleRSS with Ruby RSS module ( #5311 )
...
* SPEC: PollFeedJob parsing atom feed
* add FeedItemAccessor
It is to provide a consistent interface to access a feed item's tag
content.
* add FeedElementInstaller
to install non-standard and non-namespaced feed elements
* FEATURE: replace SimpleRSS with Ruby RSS module
* get FinalDestination and download with Excon
* support namespaced element with FeedElementInstaller
2017-12-06 10:45:09 +11:00
Robin Ward
410994b7f5
FEATURE: Show a button to Staff for "Moderation History" on posts/topics
...
When clicked, it pops up a modal showing a history of moderation actions
taken on the post or topic.
2017-12-05 15:20:20 -05:00
Vinoth Kannan
6e054b2572
FEATURE: Convert HTML to Markdown while pasting in composer
2017-12-05 12:23:39 -05:00
Sam
995bf3c84e
correct spec on Ruby 2.3
2017-12-05 07:04:41 +11:00
Sam
5a9622163d
FIX: regression around rate limiter
2017-12-04 21:44:16 +11:00
Sam
dd70ef3abf
Revert "Revert "PERF: improve speed of rate limiter""
...
This reverts commit 2373d85239
2017-12-04 21:23:11 +11:00
Sam
2373d85239
Revert "PERF: improve speed of rate limiter"
...
This reverts commit a9bcdd7f27
2017-12-04 21:19:28 +11:00
Sam
d041377ccf
correct test that does not work with discobot
2017-12-04 18:20:05 +11:00
Sam
a9bcdd7f27
PERF: improve speed of rate limiter
...
Also
- adds a global rate limiter option
- cleans up usage in tests
- fixes freeze_time so it handles clock_gettime
2017-12-04 18:17:30 +11:00
Sam
af061efcf5
DEV: if plugins are installed do not fail the test
2017-12-04 18:17:30 +11:00
Guo Xiang Tan
b18cc81609
Make rubocop happy.
2017-12-04 10:55:31 +08:00
Guo Xiang Tan
22140efa70
Tests are still leaking connection after skipping.
...
* Could be in the setup.
2017-12-04 10:46:30 +08:00
Guo Xiang Tan
e73fbfe265
FIX: Topic#featured_link_root_domain extracts URL before parsing.
2017-12-04 10:00:07 +08:00
Guo Xiang Tan
4c8402c50f
Skip test that is leaking connections.
2017-12-04 09:26:51 +08:00
Arpit Jalan
496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
...
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
Arpit Jalan
e3925278e2
FEATURE: support search click through tracking for user, category and tags
...
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj
This commit adds following features:
- support for tracking click through to user, tag and category
- new filter for search type (header, full page)
This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
Vinoth Kannan
7f2eeaf767
FIX: Password required flag should be cleared whenever clearing the raw password ( #5384 )
2017-12-01 15:19:24 +11:00
Guo Xiang Tan
c128e421c4
FIX: Don't run job if topic timer has already been deleted.
2017-11-30 15:26:26 +08:00
Guo Xiang Tan
1c2d1682ae
Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check
...
FIX: Re-enable invalid interpolation keys check and allow default key…
2017-11-30 13:04:54 +08:00
Guo Xiang Tan
9fbe1436b6
UX: Replace heuristic solution root domain extraction for topic featured link.
2017-11-29 21:52:41 +08:00
Guo Xiang Tan
b1375ef44e
Ensure that we disconnect connection in test.
2017-11-29 20:57:13 +08:00
Guo Xiang Tan
8491c5fba5
UX: Replace heuristic solution for extracting root domain.
2017-11-29 16:26:46 +08:00
Gerhard Schlager
44ee388070
FEATURE: omit images from og and twitter description tags
2017-11-28 21:34:02 +01:00
Guo Xiang Tan
1d8b834301
Merge pull request #5369 from vinothkannans/queued
...
FIX: Error if queued post not found while updating
2017-11-28 17:51:05 +08:00
Jeff Wong
b094894c94
Feature: Add service worker registration method to plugin API
2017-11-28 14:01:41 +08:00
Sam
df84e1c358
Correctly track hijacked requests
2017-11-28 16:47:20 +11:00
Sam
0caa335ef0
FIX: Handle more cases where HTTP status is not correct
...
HTTP status was not correct with send_file which uses streaming
2017-11-28 11:00:13 +11:00
Sam
ca7af7b88f
FIX: displaying wrong avatar and letter avatar
...
correct regression where params and env is reused in production
2017-11-28 09:28:40 +11:00
Robin Ward
77f90876d3
REFACTOR: Track manual locked user levels separately from groups
2017-11-27 11:23:44 -05:00
Vinoth Kannan
31aa21b5a4
FIX: Error if queued post not found while updating
2017-11-27 19:25:51 +05:30
Sam
608207b2e5
FEATURE: avatar proxy happens in background
...
This ensures that even if it is slow to download avatars site will
continue to work
Also simplifies hijack pattern
2017-11-27 17:43:24 +11:00
Sam
d5e7691ae9
favicon proxy now uses hijack
2017-11-27 14:51:14 +11:00
Guo Xiang Tan
5805979e88
FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides.
...
https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16
2017-11-27 11:00:08 +08:00
Guo Xiang Tan
2e04ef97d9
Fix the build.
2017-11-27 10:53:05 +08:00
Guo Xiang Tan
a7030e80bf
Skip randomly failing test.
2017-11-27 10:51:18 +08:00
Sam
eb428ef54d
FEATURE: uploads are processed a faster
...
Also cleans up API to always return 422 on upload error. (previously returned 200)
Uploads are processed using new hijack pattern
2017-11-27 12:43:35 +11:00
Guo Xiang Tan
71942e4f62
Merge pull request #5352 from tgxworld/method_for_replica_postgres_connection
...
Expose `replica_postgresql_connection` to `ActiveRecord::Base`.
2017-11-27 08:38:10 +08:00
Gerhard Schlager
b3094e9954
FIX: incoming and outgoing emails got lost when post was moved
2017-11-24 11:45:36 +01:00
Sam
e0e99d4bbd
PERF: hijack onebox requests so they do not use up a unicorn worker
2017-11-24 15:31:40 +11:00
Guo Xiang Tan
a509f466a0
Expose replica_postgresql_connection to ActiveRecord::Base.
2017-11-24 09:35:45 +08:00
Guo Xiang Tan
82222e8d18
Improve specs to test for the right response status.
2017-11-24 09:32:44 +08:00
Arpit Jalan
406ad1a1f2
Merge pull request #5357 from techAPJ/invite-trust-level
...
FIX: invited users were not granted trust level based on their group
2017-11-23 23:42:20 +05:30
Robin Ward
ad07e6e172
FEATURE: group_removes_trust_level setting
...
By default in Discourse, if a group grants a user a particular trust
level that is locked even if they are removed from the group.
With this new setting, when a user is removed from a group their
trust level is set to either the next highest trust level based on group
membership, or they are unlocked and promoted based on the default
mechanisms.
2017-11-23 13:03:24 -05:00
Gerhard Schlager
613f4d737a
FIX: updating topic stats failed silently for invalid topics
2017-11-23 18:47:45 +01:00
Arpit Jalan
3508046e33
FIX: invited users were not granted trust level based on their group
...
https://meta.discourse.org/t/bulk-invites-and-trust-level/73535
If the user enters password when accepting invite they were not granted
trust level based on their group privileges. It was because `password_required` was set to true when creating user record and when the user was updated again when granting trust level the password validation was raising error saying that the password is empty. This commit fetches fresh user record after the user is created so that the user record can be updated successfully.
2017-11-23 22:19:28 +05:30
Gerhard Schlager
39810e4425
FIX: do not move small post actions
2017-11-23 17:25:53 +01:00
Sam
e61629ed84
remove spec containing mock
2017-11-23 17:54:27 +11:00
Sam
2b8d4508e5
PERF: stop running background work between requests
...
Use a dedicated thread to run Scheduler::Defer
This avoids blocking of a worker during operations that require waiting.
In particular uploads risked blocking a unicorn.
This also add a queue "length" that discourse prometheus consumes.
2017-11-23 15:48:47 +11:00
Robin Ward
628275fc31
FIX: Some badge routes were still working even with badges disabled
2017-11-21 12:22:44 -05:00
Guo Xiang Tan
f7642e076d
REFACTOR: Avoid duplicated logic on server and client.
2017-11-21 17:10:04 +08:00
Régis Hanol
2d48caffdf
FIX: be more lenient when deleting a custom emoji
2017-11-20 23:50:23 +01:00
Robin Ward
0a9daba627
FIX: Support for long suspension emails
2017-11-20 12:45:46 -05:00
Sam
7e841a0495
FIX: stop counting PMs, deleted topics and whispers in directory and user stats
2017-11-20 16:44:09 +11:00
Guo Xiang Tan
385372e384
Revert "PERF: Reduce number of topics to filter while querying for unread."
...
This reverts commit c06b782cab
2017-11-20 11:49:09 +08:00
Gerhard Schlager
41673c322c
dear Rubocop, don't be so pedantic ;-)
2017-11-19 12:45:33 +01:00
Gerhard Schlager
92a831bae6
FEATURE: user directory returns staged users during search
2017-11-19 01:17:31 +01:00
Gerhard Schlager
546b206da0
replace indentation with non-breaking spaces when cooking emails
2017-11-18 17:16:44 +01:00
Neil Lalonde
87ec11e298
FIX: more accurate counting of posts read. Skipping to the end of a topic does not count all posts as read in user stats.
2017-11-17 16:08:46 -05:00
Robin Ward
d755c9c90f
FIX: Allow regular expressions to specify boundaries
2017-11-17 14:13:44 -05:00
Gerhard Schlager
d47fa6653b
do not notify staged users about posts withing mailinglist mirror category
2017-11-17 15:29:14 +01:00
Gerhard Schlager
1a3ab7c02e
ignore some site settings for emails sent to mailinglist mirror category
2017-11-17 15:29:14 +01:00
Gerhard Schlager
aea161fabd
suppress rejection email when email was sent to mailinglist mirror category
2017-11-17 15:29:14 +01:00
Régis Hanol
a586738f25
fix randomly failing spec
2017-11-16 18:16:16 +01:00
Régis Hanol
678e28794a
FIX: properly handle too large & broken images in posts
2017-11-16 15:45:07 +01:00
Vinoth Kannan
6f2a3cb026
Remove unwanted triggers to CookedPostProcessor ( #5319 )
2017-11-16 15:20:44 +05:30
Sam
9c22c68d39
FIX: only save custom fields if they actually change
2017-11-16 15:14:10 +11:00
Guo Xiang Tan
3ab6318e5f
Disable postgresql adapter tests until we figure out what is leaking
...
connections.
2017-11-16 07:17:22 +08:00
Sam
f52111f787
FEATURE: allow plugins to easily detect if running in Rack
...
Usage: Discourse.running_in_rack? to tell if rack was booted
2017-11-16 08:39:29 +11:00
Sam
20fbf81505
FEATURE: Allow plugins to easily add defaults to GlobalSetting
...
usage:
GlobalSetting.add_default("plugin_setting_name", "value")
2017-11-16 08:39:29 +11:00
Neil Lalonde
0cdded8079
Merge pull request #5303 from vinothkannans/export-multiple-categories
...
FEATURE: Option to export multiple categories using export_category method
2017-11-15 16:07:21 -05:00
Gerhard Schlager
9207dee69a
FEATURE: escape HTML when cooking plaintext emails
2017-11-15 20:22:11 +01:00
Robin Ward
fc73de9578
Support for finding new locales in plugins
2017-11-15 11:20:04 -05:00
Vinoth Kannan
cbc0afb399
REFACTOR: Instance methods added to 'PluginStore' model for easy access ( #5315 )
2017-11-15 10:10:20 -05:00
Régis Hanol
648832a643
fix the build
2017-11-15 11:53:14 +01:00
Vinoth Kannan
7b494a65c9
NEW: large image placeholder added in cooked html ( #5291 )
2017-11-15 11:30:47 +01:00
Guo Xiang Tan
89d9ffa884
EXPERIMENTAL: Allow logs to be shipped via different methods.
...
See https://github.com/dwbutler/logstash-logger#uri-configuration for
a list of available methods.
2017-11-15 09:11:33 +08:00
Sam
813e21d0e8
FIX: current user serializer consistently returns {} for custom_fields
...
Resolves : #5210
2017-11-15 11:55:37 +11:00
OsamaSayegh
4c4410225e
UX: cap likes 2 ( #5237 )
2017-11-15 11:28:54 +11:00
Arpit Jalan
3831663fea
FEATURE: search logs page ( #5313 )
2017-11-15 11:13:50 +11:00
Régis Hanol
23baaa5dcc
FIX: don't crop iPhone X screenshots
2017-11-14 20:37:27 +01:00
Robin Ward
971e302ff2
FEATURE: Support an end date for user silencing
2017-11-14 13:20:19 -05:00
Gerhard Schlager
4be8f17e66
FIX: counting invites didn't work
...
PostgreSQL reported the following error:
"for SELECT DISTINCT, ORDER BY expressions must appear in select list"
2017-11-14 11:40:07 +01:00
Sam
47e4c9bb46
FIX: import/export theme should work with uploads
2017-11-14 16:30:23 +11:00
Sam
075a458489
FIX: child theme component vars not resolved in parent
2017-11-14 15:22:59 +11:00
Guo Xiang Tan
bf5ba5fbd1
Remove readonly alert smoke test.
2017-11-14 11:18:38 +08:00
Gerhard Schlager
d3baae5365
removes whitespaces and uses scope
2017-11-13 15:23:24 +01:00
Régis Hanol
7370adeae3
FIX: don't delete uploads referenced in drafts or queued posts when using the short_url
2017-11-13 15:01:31 +01:00
Sam
8a66446849
FEATURE: add overflow-y auto to Markdown tables
2017-11-13 17:52:15 +11:00
Sam
4f28c71b50
FIX: error setting tombstone bucket when set to old version
2017-11-13 15:36:45 +11:00
Sam
3ac7d041ae
UX: generic onebox treats all square images as avatars and renders them smaller
2017-11-13 11:21:19 +11:00
Gerhard Schlager
5210e3e744
FEATURE: accept incoming email with reply_key mismatch when original email was forwarded
2017-11-12 23:44:22 +01:00
Gerhard Schlager
fc6de6863b
WIP
2017-11-12 21:12:34 +01:00
Gerhard Schlager
4dc4bc70c8
FIX: ignore_by_title should match case-insensitive
2017-11-12 01:43:18 +01:00
Vinoth Kanan
d9823f69c6
FEATURE: Option to export multiple categories using export_category method
2017-11-11 19:11:16 +05:30
Robin Ward
4270c93666
FIX: Missing yml file
2017-11-10 14:29:36 -05:00
Robin Ward
1f14350220
Rename "Blocked" to "Silenced"
2017-11-10 14:10:27 -05:00
Neil Lalonde
9dc9ca4ac0
FIX: be consistent with how first posts in topics are counted. do like DirectoryItem.refresh_period :all
2017-11-10 12:18:25 -05:00
Gerhard Schlager
0ccefb0365
make RuboCop happy
2017-11-10 17:57:28 +01:00
Gerhard Schlager
31e2385316
FEATURE: do not send notification emails to users who are included in the To and CC header of an incoming email
2017-11-10 17:44:20 +01:00
Joffrey JAFFEUX
73aa7edb8b
Temporarily skip multisite spec
2017-11-09 15:38:34 -08:00
Neil Lalonde
16ff2a4715
FIX: topic counts after converting topic to/from public and private
2017-11-09 15:33:44 -05:00
Sam
06365023c4
FEATURE: new API to search for a user by email
2017-11-09 17:04:21 +11:00
Sam
2d5bf0705a
PERF: exact email match bypass
...
instead of scanning full table when there is an exact email match ONLY
return the actual user.
2017-11-09 16:53:14 +11:00
Sam
86e6732f78
FEATURE: update rails multisite
...
always allow /srv/status through even if host does not match
2017-11-09 15:40:56 +11:00
Arpit Jalan
b21d5d3633
FIX: SSO email match should be case insensitive
2017-11-08 20:37:41 +05:30
Guo Xiang Tan
6090994cdf
FEATURE: Retain the latest 30 days of WebHookEvent records by default.
2017-11-08 14:11:01 +08:00
Guo Xiang Tan
4bb454d889
FIX: JSON custom fields incorrectly being converted to an array.
...
https://meta.discourse.org/t/custom-fields-simultaneous-save-with-json-becomes-an-array/73647
2017-11-08 11:17:37 +08:00
Neil Lalonde
d7880af0bb
FIX: change password form validation should instruct admins to use min password length for admin accounts
2017-11-07 16:14:56 -05:00
Régis Hanol
be0c7609f1
FIX: validates attachments against current authorized extensions
2017-11-07 19:17:33 +01:00
Arpit Jalan
8f560f0bf4
Merge pull request #5282 from vinothkannans/local_onebox_slash
...
FIX: Topic links onebox differently if end in /
2017-11-07 17:39:38 +05:30
Guo Xiang Tan
d9602fe729
Fix incorrect severity field.
2017-11-07 11:24:54 +08:00
Guo Xiang Tan
c9df21e131
FEATURE: Allow Unicorn logs to be JSON formatted.
2017-11-06 12:46:14 +08:00
Vinoth Kannan
230fec68ca
FIX: Topic links onebox differently if end in /
2017-11-06 01:41:36 +05:30
Robin Ward
9ebb1412d3
FIX: Brittle, order dependent spec
2017-11-04 09:30:17 -04:00
Vinoth Kannan
59529ea54a
generalize spec fixture
2017-11-04 11:47:26 +05:30
Robin Ward
2f0c9793f1
FEATURE: Allow multiple html builders to be registered via plugins
2017-11-03 11:32:32 -04:00
ckeboss
93633865d9
Adds primary user group as a class to quote ( #5285 )
...
* Adds primary user group as a class to quote
This feature addition will add the class `group-PRIMARY_USER_GROUP` to
the quote `aside`. `PRIMARY_USER_GROUP` will be the primary user group
of the user being quoted. This is similar to the class that is added to
a `topic-post`.
* Remove trailing whitespace
* Fix avatar in test
* Address PR comments
* Fix trailing whitespace
2017-11-03 09:51:40 -04:00
Guo Xiang Tan
d320f4840d
FIX: Unable to invite groups that are not public visible into pms.
...
https://meta.discourse.org/t/inviting-groups-broken-in-head/73346/6
2017-11-03 21:40:33 +08:00
Sam
56412adad5
FEATURE: custom setting for large square site icon
...
This icon is used for android splash screen
2017-11-03 16:19:31 +11:00
Guo Xiang Tan
af01860a3d
Clear all active connections after PostgreSQL failover tests.
2017-11-03 09:21:10 +08:00
Neil Lalonde
c7d7cb940c
FIX: dashboard posts report was including posts in daily data, but not in totals
2017-11-02 18:46:28 -04:00
Neil Lalonde
18d65fe7e5
FIX: post counts in user stats when changing post owner
2017-11-02 18:05:23 -04:00
Neil Lalonde
21dd2ccd43
FIX: only count regular posts in user stats when deleting
2017-11-02 18:05:23 -04:00
Neil Lalonde
30689783db
don't decrement post_count for a post in a deleted topic that has already been uncounted
2017-11-02 18:05:23 -04:00
Neil Lalonde
f29290ad11
FIX: don't count whispers in user stats post_count
2017-11-02 18:05:23 -04:00
Neil Lalonde
24af9b7d97
FIX: when a topic is deleted, update the post count stats of all user who replied
2017-11-02 18:05:23 -04:00
Robin Ward
64cb8a3ce3
FIX: Normalizer wasn't working with attributes without values
2017-11-02 14:11:20 -04:00
Arpit Jalan
4634935fe6
DEV: suppress puts output while running specs
2017-11-02 15:03:36 +05:30
Guo Xiang Tan
edf4af608e
FIX: Better match when searching for groups.
2017-11-02 10:20:14 +08:00
Guo Xiang Tan
ab2a5cef38
FIX: Can't edit membership request template on group page.
2017-11-02 08:51:43 +08:00
Arpit Jalan
7f33f7850a
Merge pull request #5270 from vinothkannans/rake_categories
...
FEATURE: Rake task to export and import category structure
2017-11-01 21:36:03 +05:30
Vinoth Kannan
a00af4d85a
FEATURE: Rake task to export and import category structure
2017-11-01 17:17:05 +05:30
Gerhard Schlager
880d154381
FIX: deleting staged user of rejected email shouldn't delete incoming email
2017-10-31 15:13:23 +01:00
Arpit Jalan
b3e61ebb38
suppress print output when running specs
2017-10-31 16:06:11 +05:30
Sam
1bd9e64a36
FIX: offline controller regression
2017-10-31 15:44:50 +11:00
Guo Xiang Tan
53cadbdfc5
Skip failing tests on Travis first.
2017-10-28 00:22:41 +08:00
Guo Xiang Tan
b636e858bb
Fix randomly failing spec on Travis.
2017-10-27 23:53:58 +08:00
Guo Xiang Tan
401fbdbfe7
FIX: Topic#title were being parameterized when encoded slug is
...
enabled.
2017-10-27 11:02:47 +08:00
Sam
70aed105a6
FIX: bypass all site setting work for shadowed method
2017-10-27 11:12:44 +11:00
Erick Guan
7c3123a2dd
Downcase encoded slug by default and more specs
2017-10-26 16:50:29 +08:00
Guo Xiang Tan
1c7b4381cc
Improve postgresql failover specs.
2017-10-26 15:54:50 +08:00
Guo Xiang Tan
f1615c2148
Merge pull request #5263 from tgxworld/improve_pattern
...
REFACTOR: Always validate email by default.
2017-10-26 14:34:09 +08:00
Guo Xiang Tan
94782152c6
Ensure we clean up state in PostgreSQL failover specs.
2017-10-26 09:22:51 +08:00
Rafael dos Santos Silva
a173511681
Merge pull request #5259 from discourse/groups_in_sso_provider
...
Add groups to the SSO provider payload
2017-10-25 23:02:53 -02:00
Rafael dos Santos Silva
5d5268a82b
Feature: Group handling
2017-10-25 22:49:17 -02:00
Guo Xiang Tan
defea6245c
REFACTOR: Always validate email by default.
2017-10-25 13:48:34 +08:00
Arpit Jalan
efbd923f60
Merge pull request #5261 from xrav3nz/fix-rebake-match-rake
...
FIX: `post:rebake_match` rake task
2017-10-25 10:22:56 +05:30
Sam
1db4c2d1a0
moving redis to readonly mode destablizes the test suite
2017-10-25 14:39:49 +11:00
Sam
0d816302e2
Explicitly avoid all readonly protection and scoping
2017-10-25 13:31:44 +11:00
Sam
7ca8853861
don't risk being stuck in readonly
2017-10-25 13:22:50 +11:00
Sam
877b7be579
FIX: in readonly mode don't double count pages
2017-10-25 13:19:43 +11:00
Kyle Zhao
82c18f6ca3
fix: undefined variable in post:rebake_match
2017-10-24 20:05:58 -04:00
Neil Lalonde
fb5b9b6d06
FIX: don't offer the "Something Else" flag reason to TL0 users since they don't have permission to send private messages
2017-10-24 11:47:42 -04:00
Neil Lalonde
4452d67a23
Revert "FIX: TL0 users' messages to moderators were not being posted when flagging private messages"
2017-10-23 18:17:53 -04:00
Panayotis Matsinopoulos
821ed23799
Use the CategoryHashtag::SEPARATOR ( #5258 )
...
Use the CategoryHashtag::SEPARATOR like in the previous examples.
2017-10-23 14:59:08 +02:00
Guo Xiang Tan
54455fa40b
Use MessageBus to get other processes to failover faster.
2017-10-23 17:58:24 +08:00
Guo Xiang Tan
509ecbe9fb
Fix test not starting with the right state.
2017-10-23 12:20:39 +08:00
Guo Xiang Tan
19f3b81161
Revert "FIX: always trigger the ':user_updated' event"
...
This reverts commit 519b70ea46https://meta.discourse.org/t/creating-a-topic-or-a-post-sends-the-user-updated-webhook/71643
2017-10-23 11:44:22 +08:00
Guo Xiang Tan
e91a631978
REFACTOR: DRY up code and add better test coverage.
2017-10-23 11:16:14 +08:00
Arpit Jalan
9586f0bdc9
fix the build - take 2
2017-10-20 21:34:56 +05:30
Arpit Jalan
13b2bf52c9
fix the build
2017-10-20 20:31:49 +05:30
Arpit Jalan
804b4f32f8
better error message when API authentication fails
2017-10-20 20:05:34 +05:30
Guo Xiang Tan
57d9830bd2
FIX: DistributedCache without namespace mode wasn't working.
2017-10-20 22:32:41 +08:00
Guo Xiang Tan
fe1e78ddf4
Make PostgreSQL failover work with distributed cache.
2017-10-20 17:15:29 +08:00
Gerhard Schlager
4205c1ad2b
FIX: postprocessing ignored cook method
2017-10-20 10:26:45 +02:00
Gerhard Schlager
1481462cbf
PERF: Move oneboxing from cook method "email" to postprocessing
2017-10-20 10:26:45 +02:00
Guo Xiang Tan
057571d173
Raise errors in PostgreSQLFallbackHandler threads.
2017-10-20 12:06:03 +08:00
Robin Ward
838568cbc3
Refactor flag types for more customization
2017-10-19 13:55:23 -04:00
Gerhard Schlager
1cae875146
FIX: topic link extraction shouldn't fail when the parsed URL has no path
2017-10-19 15:26:37 +02:00
Gerhard Schlager
3cd73cdf18
FIX: fancy topic title must fit into column
2017-10-19 14:34:30 +02:00
Guo Xiang Tan
22ba70fb01
Merge pull request #5226 from tgxworld/allow_user_to_disable_private_messages
...
FEATURE: Allow users to disable new PMs.
2017-10-19 16:46:18 +08:00
Guo Xiang Tan
38123a4246
Add readonly test to smoke tests.
2017-10-19 16:34:54 +08:00
Guo Xiang Tan
5b9ddaf972
FIX: Topic#fancy_title should not write in readonly mode.
2017-10-19 16:07:03 +08:00
Guo Xiang Tan
25c25ae423
FEATURE: Allow user to leave a PM.
2017-10-19 12:32:55 +08:00
Guo Xiang Tan
79de10b212
FEATURE: Allow users to disable new PMs.
...
https://meta.discourse.org/t/is-it-possible-to-disable-private-messaging-for-a-specific-user/46391
2017-10-19 12:32:55 +08:00
Guo Xiang Tan
814c7ab503
Skip randomly failing tests first.
2017-10-19 12:25:50 +08:00
Régis Hanol
cbdfc85466
FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd)
2017-10-18 23:54:36 +02:00
Sam
a4c539bade
FEATURE: Allow registration of detailed request logger
...
Detailed request loggers can be used to gather rich timing info
from all requests (which in turn can be forwarded to monitoring solution)
Middleware::RequestTracker.detailed_request_logger(->|env, data| do
# do stuff with env and data
end
2017-10-18 12:10:30 +11:00
Sam
1dd2b51059
remove redundent stubs
2017-10-18 12:10:30 +11:00
Guo Xiang Tan
bdd3713ca4
Allow smoke tests that writes data to be skipped.
2017-10-17 16:20:41 +08:00
Guo Xiang Tan
1b5ee0ae72
FIX: Couldn't boot Discourse app with a readonly postgres.
2017-10-17 13:44:30 +08:00
Sam Saffron
8185b8cb06
FEATURE: cache https redirects per hostname
...
If a hostname does an https redirect we cache that so next
lookup does not incur it.
Also, only rate limit per ip once per final destination
Raise final destination protection to 1000 ip lookups an hour
2017-10-17 16:22:54 +11:00
Sam Saffron
646c6eb7cd
FEATURE: add :before_post_process_cooked hook
...
Also reduce amount of image downloading
2017-10-17 16:22:54 +11:00
Neil Lalonde
2db66072d7
SECURITY: signup without verified email using Google auth
2017-10-16 13:51:41 -04:00
Guo Xiang Tan
5f76e5062d
Pause Sidekiq when postgres failovers.
2017-10-16 19:48:31 +08:00
Sam
229a10e142
Missed a whitelist, compensate for strict classes
2017-10-16 10:46:01 +11:00
Robin Ward
f73a3cc0d4
Don't include suspended_at or suspended_till unless suspended
2017-10-13 12:17:54 -04:00
Neil Lalonde
b124e5f19f
FIX: TL0 users' messages to moderators were not being posted when flagging private messages
2017-10-13 11:55:49 -04:00
Neil Lalonde
c53f41f4f2
FIX: don't flag watched words when rebaking posts
2017-10-12 15:34:22 -04:00
Gerhard Schlager
c0bb97b5cb
FIX: delete staged users when the incoming email is rejected
2017-10-11 16:17:01 +02:00
Guo Xiang Tan
9dcb11f553
Fix the build.
2017-10-11 17:45:19 +08:00
Guo Xiang Tan
09721090a3
FIX: Ensure that we revert back to default connection after running jobs.
2017-10-11 17:17:03 +08:00
Arpit Jalan
a2183c3f1d
SECURITY: verify that inviter can invite new user to a topic
2017-10-09 15:59:41 +05:30
Guo Xiang Tan
a6f2533d38
SECURITY: Fix XSS on unsubscribed page.
2017-10-09 09:04:46 +08:00
Guo Xiang Tan
6fe604b93e
Revert "SECURITY: Fix XSS on unsubscribed page."
...
This reverts commit 190558db9d
2017-10-09 09:03:07 +08:00
Guo Xiang Tan
190558db9d
SECURITY: Fix XSS on unsubscribed page.
2017-10-09 08:59:03 +08:00
Sam
4ea87b5ab8
Merge branch 's3_refactor'
2017-10-09 10:27:52 +11:00
Régis Hanol
3bdd8f57c1
FIX: invited staged users would sometimes not get notified of replies
2017-10-06 16:37:28 +02:00
Sam
70bb2aa426
FEATURE: allow specifying s3 config via globals
...
This refactors handling of s3 so it can be specified via GlobalSetting
This means that in a multisite environment you can configure s3 uploads
without actual sites knowing credentials in s3
It is a critical setting for situations where assets are mirrored to s3.
2017-10-06 16:20:01 +11:00
Guo Xiang Tan
3efde2618d
UX: Do not display non-human users on group page.
...
https://meta.discourse.org/t/members-of-groups-staff/71437
2017-10-06 10:35:40 +08:00
Neil Lalonde
beca02c046
FIX: moderators couldn't see flagged topics list
2017-10-05 14:12:07 -04:00
Guo Xiang Tan
b2127600fb
Remove use of concurrent timer for Redis failover.
...
* Uses the same logic for Postgres failover.
2017-10-05 15:57:08 +08:00
Guo Xiang Tan
b0557c6692
UX: Allow users to remove a remind me topic timer.
2017-10-05 11:50:08 +08:00
Neil Lalonde
f5a2ed99b0
FIX: deleting category background images sometimes has no effect
2017-10-04 17:04:37 -04:00
Régis Hanol
e212435545
FIX: redirect to top wasn't working
2017-10-04 22:08:41 +02:00
Neil Lalonde
ddbd1d5ab8
allow regex options on username site settings
2017-10-04 15:08:51 -04:00
Neil Lalonde
c29334cf23
FEATURE: the hide_email_address_taken setting works with the change email address form in user preferences
2017-10-04 11:41:25 -04:00
Guo Xiang Tan
1310181664
FIX: Adding a public topic timer deletes a private topic timer.
2017-10-04 16:31:40 +08:00
Sam
5881355006
remove uneeded assertion
2017-10-04 15:59:16 +11:00
Kyle Zhao
0342324b47
FEATURE: support regex in rake post:remap ( #5201 )
2017-10-04 11:47:53 +11:00
Sam
4ee2fcd3d5
correct flaky spec
2017-10-04 10:47:24 +11:00
Neil Lalonde
1faae3c765
rename forgot_password_strict to hide_email_address_taken
2017-10-03 15:28:31 -04:00
Neil Lalonde
e47f5cedd2
FEATURE: forgot_password_strict setting also prevents reporting that an email address is taken during signup
2017-10-03 15:28:30 -04:00
Gerhard Schlager
7f50380221
FIX: respect email domain whitelist/blacklist when creating staged users
2017-10-03 16:36:08 +02:00
Gerhard Schlager
76706f9144
FIX: don't create staged users when incoming email is rejected
...
FIX: don't send subscription mail to new users
2017-10-03 16:36:08 +02:00
Régis Hanol
fafe7cc661
remove trailing whitespaces
2017-10-03 13:02:04 +02:00
Régis Hanol
daf1dda700
FIX: username autocomplete in assign modal wasn't working
2017-10-03 12:49:45 +02:00
Guo Xiang Tan
a5b7d34fe2
Merge pull request #5199 from xrav3nz/poll-feed-integration-test
...
TEST ONLY: PollFeed integration test
2017-10-03 14:33:22 +08:00
Guo Xiang Tan
a966f2134c
Merge pull request #5215 from gschlager/email_templates
...
Add specs for EmailTemplatesController
2017-10-03 14:30:19 +08:00
Guo Xiang Tan
3e53dbcade
UX: Only include tag hashtag postfix when necessary.
...
https://meta.discourse.org/t/links-to-tags-not-working-in-final-post-unless-autocompleted/69884/6?u=tgxworld
2017-10-03 13:54:50 +08:00
Guo Xiang Tan
85c5bb4ea4
Fix randomly failing spec.
2017-10-03 11:59:26 +08:00
Gerhard Schlager
5bb326a452
Add specs for EmailTemplatesController
2017-10-02 14:53:27 +02:00
Guo Xiang Tan
8140e54675
FIX: More fixes for Group#mentionable and Group#messageable feature.
2017-10-02 17:45:58 +08:00
OsamaSayegh
79f3d299a1
Don't allow category definition topics to be converted to PMs ( #5216 )
2017-10-02 10:04:58 +02:00
Kyle Zhao
15cd3b78ae
integration test for PollFeed job
2017-10-02 01:16:11 -04:00
Guo Xiang Tan
b5bbb8ae8a
Fix failing spec.
2017-10-02 13:16:01 +08:00
Guo Xiang Tan
0f2c5f5fc9
FIX: Don't raise error when trying to download avatar from URL.
2017-10-02 12:59:41 +08:00
Guo Xiang Tan
c872225762
Improve MessageBus.track_publish to allow filter by channel.
2017-10-02 11:34:57 +08:00
Guo Xiang Tan
b295a39977
Fix randomly failing spec.
2017-10-02 11:24:48 +08:00
Guo Xiang Tan
049d925213
Remove controller spec that is rewritten as request spec.
2017-10-02 10:47:22 +08:00
Guo Xiang Tan
4e07bbfbbf
FIX: Only allow intergers for page params.
2017-10-02 10:45:54 +08:00
Eleanor Demis
ac04f5e0cc
update response error when deleting tags ( #5213 )
2017-09-30 16:31:32 +02:00
Robin Ward
00b190af75
Revert "A safe way to create class variables in a multisite environment."
...
The approach taken by this interface was flawed. We need a better
solution.
2017-09-29 11:06:12 -04:00
Arpit Jalan
689f949fdb
Merge pull request #5209 from techAPJ/has-messages
...
FIX: update group.has_messages field weekly
2017-09-29 09:12:26 +05:30
Sam
0358931b9f
correct erratic spec
2017-09-29 12:58:15 +10:00
Arpit Jalan
d64853dfa0
FIX: update group.has_messages field weekly
2017-09-29 08:23:07 +05:30
Sam
f6fdc1ebe8
FEATURE: flexible crawler detection
...
You can use the crawler user agents site setting to amend what user agents
are considered crawlers based on a string match in the user agent
Also improves performance of crawler detection slightly
2017-09-29 12:31:50 +10:00
Guo Xiang Tan
6baea9948b
Revert "fix the build"
...
This reverts commit 8b74c7d325
2017-09-29 08:57:06 +08:00
Guo Xiang Tan
8dae98a3f6
Skip randomly failing test on Travis for now.
2017-09-29 08:32:19 +08:00
Régis Hanol
8b74c7d325
fix the build
2017-09-28 15:50:01 +02:00
Robin Ward
07e84a3afa
FIX: Hack our title retriever so that it parses YouTube URLs
2017-09-28 09:30:22 -04:00
OsamaSayegh
ab68379abb
Use PostDestroyer to delete topics when performing bulk operation ( #5202 )
...
* Use `PostDestroyer` to delete topics when performing bulk operation
This PR should fix this bug: https://meta.discourse.org/t/bulk-deletion-of-topics-not-logged/50407?u=osama
* failing test
2017-09-28 14:22:49 +02:00
Guo Xiang Tan
5f1c29e424
FIX: Display json response when Discourse::InvalidAccess is raised for
...
non json requests.
2017-09-28 15:31:16 +08:00
Sam
8ecf313a81
FIX: correctly raise errors when downloads fail
...
This corrects an issue where we are hitting Gravatar for 404 over and over
Also ensures file download properly reports errors
2017-09-28 16:35:43 +10:00
Guo Xiang Tan
426d2178c3
Fix undefined variable in TopicCreator.
2017-09-28 12:25:42 +08:00
Guo Xiang Tan
4319d8a142
FIX: Missing template error when rendering topics#show error message.
2017-09-28 11:06:44 +08:00
Guo Xiang Tan
3e6bf38394
Merge pull request #5207 from tgxworld/try_travis_fix
...
Fix randomly failing test.
2017-09-28 10:56:05 +08:00
Guo Xiang Tan
d4388f54a2
FIX: Use exact patht to ensure we always redirect with the right format.
2017-09-28 10:29:41 +08:00
Robin Ward
4f0fee1ce7
FIX: Test failures
2017-09-27 17:02:36 -04:00
Robin Ward
41c3941c4c
FEATURE: Support regular expressions for watched words
2017-09-27 15:48:57 -04:00
Robin Ward
fa41913ba5
FIX: Don't count private content in New User of the Month
2017-09-27 15:03:24 -04:00
Régis Hanol
6a7920ad75
FIX: wasn't able to change default theme
2017-09-27 20:05:31 +02:00
Robin Ward
7578d8fc44
Add a DiscourseEvent for when a topic is closed
2017-09-27 14:00:53 -04:00
Robin Ward
3e13becf33
A safe way to create class variables in a multisite environment.
...
This should allow plugins to set class variables that will not
stomp on other plugins.
2017-09-27 13:00:47 -04:00
Guo Xiang Tan
5324c01209
FIX: Don't raise an error if reading from URL timeout.
2017-09-27 14:53:22 +08:00
Régis Hanol
af01e62b14
FIX: wasn't allowed to set a user's title anymore
2017-09-26 20:13:24 +02:00
Régis Hanol
28c54b42c5
FIX: wasn't able to update user options anymore
2017-09-26 20:00:10 +02:00
Guo Xiang Tan
367fb1c524
FIX: Onebox fails on encoded URL.
...
https://meta.discourse.org/t/onebox-breaks-if-theres-chinese-text-in-url/67364
2017-09-26 18:34:54 +08:00
Guo Xiang Tan
c25730935e
FIX: Do not include non-human users on suspected users list.
...
https://meta.discourse.org/t/discobot-is-a-suspect-user/70558
2017-09-26 15:04:08 +08:00
Guo Xiang Tan
5d37f8673b
PERF: Only send down suggested payload when loading last chunk.
2017-09-26 14:42:27 +08:00
Guo Xiang Tan
c06b782cab
PERF: Reduce number of topics to filter while querying for unread.
2017-09-26 12:36:52 +08:00
Guo Xiang Tan
c37598ddbc
Merge pull request #5200 from gschlager/embed
...
FIX: do not escape already escaped chars in URL
2017-09-26 09:07:57 +08:00
Robin Ward
383d771265
Fix broken tests
2017-09-25 12:52:45 -04:00
Robin Ward
09ed2ed749
Add Suspend User to flags page
2017-09-25 12:28:00 -04:00
Robin Ward
6bce3004d9
UX: Nicer selection of suspend duration
2017-09-25 12:28:00 -04:00
Robin Ward
677b016387
Send a suspension message via email to a user
2017-09-25 12:26:41 -04:00
Robin Ward
561fa7d0cd
FEATURE: Site Setting to hide suspension reason on the public profile
2017-09-25 12:25:14 -04:00
Robin Ward
d7c37d9369
Add front end service for staff controls
2017-09-25 12:25:14 -04:00
Robin Ward
5e69217793
Add filtering support to flags
2017-09-25 12:25:14 -04:00
Guo Xiang Tan
b8d9a6f747
Fix randomly failing spec.
2017-09-25 20:50:03 +08:00
Guo Xiang Tan
4e5e7dc736
FIX: Fix ActiveRecord API that was removed in Rails 5.1.
2017-09-25 16:16:37 +08:00
Guo Xiang Tan
88555f32cf
Improve specs.
2017-09-25 13:49:00 +08:00
Guo Xiang Tan
9540b952fd
Fix broken condition in PostgresqlFallbackAdapter.
2017-09-25 13:48:59 +08:00
Guo Xiang Tan
e542884b00
FIX: Incorrect notification state being published.
2017-09-25 13:48:59 +08:00
Guo Xiang Tan
77d4c4d8dc
Fix all the errors to get our tests green on Rails 5.1.
2017-09-25 13:48:58 +08:00
Gerhard Schlager
6f6b47f096
FIX: do not escape already escaped chars in URL
2017-09-22 17:36:44 +02:00
Gerhard Schlager
1a435414d5
FIX: handle URL encoded email addresses
2017-09-22 14:26:06 +02:00
Gerhard Schlager
e582e86da3
Merge pull request #5197 from lidimayra/workspace
...
Add spec to cover "Badge Type has many Badges" relation
2017-09-20 11:37:53 +02:00
Guo Xiang Tan
bfda6884b1
Fix randomly failing spec.
2017-09-20 13:30:15 +08:00
Lidiane Taquehara
66ed7195d6
Add spec to cover Badge Type has many Badges relation
...
Also: fix filename. `_spec` suffix was missing.
By default, RSpec ignores files in this situation.
Ref: https://github.com/rspec/rspec-core/issues/642
2017-09-20 00:51:32 -03:00
Gerhard Schlager
87b4246c14
FIX: notify about whispered reply
2017-09-19 15:51:10 +02:00
Régis Hanol
8ed318c4fe
display 'similar to' earlier when composing a post
2017-09-16 01:03:29 +02:00
Guo Xiang Tan
1a9762a9c0
Fixed private group messages being exposed in suggested topics.
...
Revert "Revert "PERF: Avoid unnecessary expensive joins if possible.""
This reverts commit d9714c21c8
2017-09-15 23:40:53 +08:00
Régis Hanol
797936d2c5
FIX: don't leak whisper count in user card
2017-09-14 20:08:16 +02:00
Neil Lalonde
16fe7aa307
FEATURE: automatically handle flags and posts that have been waiting in a queue for a long time. Flags will be deferred. Posts waiting for approval will be rejected. Control how old the records need to be with the auto_handle_queued_age site setting.
2017-09-14 12:01:06 -04:00
Gerhard Schlager
f3d3129113
FIX: Use default locale for edit reason when owner of post gets changed
2017-09-14 17:17:37 +02:00
Gerhard Schlager
efef422416
FIX: Use default locale for moderator post when posts are moved
2017-09-14 17:17:37 +02:00
Régis Hanol
eb61ad0114
fix the build
2017-09-13 18:25:58 +02:00
Régis Hanol
d9465bac13
add 'staged' column to user export
2017-09-13 18:09:11 +02:00
Régis Hanol
0096ee40da
FIX: only show participants the user can see
2017-09-13 17:14:03 +02:00
Vinoth Kannan
6e9671c2c3
UX: Placeholder images color changed & tootip added
2017-09-13 15:16:38 +05:30
Neil Lalonde
beea5cac48
FIX: send the queued posts reminder as a message to moderators instead of an email to the contact_email
2017-09-12 18:00:51 -04:00
Gerhard Schlager
31ecb4fecf
FIX: Handle incoming emails without email address in From header ( #5177 )
2017-09-12 22:35:24 +02:00
Neil Lalonde
6831efe2e9
FIX: no notification was being sent when a post is hidden by community flags
2017-09-12 15:43:44 -04:00
Robin Ward
9b3b39d8a2
FIX: Users should be able to activate their emails even if unapproved
...
Note in discourse `active` means "Email is active" - they still can't
login until approved
2017-09-12 15:04:39 -04:00
Leo McArdle
104d97695d
FIX: don't activate un-confirmed email on omniauth authentication ( #5176 )
2017-09-12 17:36:17 +02:00
Robin Ward
171d9e5aed
SECURITY: Prevent users from updating to blacklisted email domains
2017-09-12 10:11:08 -04:00
Guo Xiang Tan
07bfe3d053
FIX: Use a distrbuted cache for site locale.
2017-09-12 19:36:17 +08:00
Neil Lalonde
d7d9923b8e
FIX: display email validation error messages
2017-09-11 13:22:14 -04:00
Guo Xiang Tan
5d4221fbe1
PERF: Avoid calling expensive PostGuardian#can_see_post? multiple times.
...
Before
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 19
75: 19
90: 21
99: 27
topic:
50: 56
75: 62
90: 64
99: 99
timings:
load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```
After
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 18
75: 18
90: 20
99: 28
topic:
50: 41
75: 42
90: 46
99: 49
timings:
load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
Guo Xiang Tan
a0daa7cad0
Oops fix build again.
2017-09-07 18:59:02 +08:00
Robin Ward
db929e58fc
FIX: Don't allow staff to approve users with unverified emails
2017-09-04 12:55:39 -04:00
Joffrey JAFFEUX
caedefd675
FIX: correctly resets user_themes template
...
This commit adds tests for this behaviour and also adds support for
reseting cache when updating a theme name and destroying a theme.
2017-09-04 13:27:58 +02:00
Guo Xiang Tan
5c1143cd55
Add missing test case for PostController#timings.
2017-09-04 16:36:02 +08:00
Sam Saffron
4cef3cd762
move fix to top of test
2017-09-01 13:12:47 -04:00
Sam Saffron
936582b8d1
Correct flaky spec
...
Can fail if the machine running tests has less that 10% free space
2017-09-01 13:10:01 -04:00
Vinoth Kannan
0fb7831749
FEATURE: Add placeholders to broken and large image files ( #5113 )
2017-09-01 10:26:13 -04:00
Sam Saffron
e283e6aea0
FEATURE: allowed_iframes site setting for allowing iframes
...
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
Sam Saffron
3bdade8970
correct fragile spec
2017-08-31 15:55:56 -04:00
Arpit Jalan
66f2925348
SECURITY: do not include links from whispers in topic summary map
...
https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj
2017-08-31 23:44:54 +05:30
Sam
04e3526096
Only remove default locale which is the only column we touch
...
see: https://meta.discourse.org/t/failing-tests-in-discourse-dev-due-to-multisite/68720/5
2017-08-29 14:02:24 -04:00
Sam
c705159d22
Remove email column from user table
2017-08-29 11:50:56 -04:00
Guo Xiang Tan
37e5ee858f
REFACTOR: Just pass a block instead of using a lambda.
2017-08-29 08:26:48 +08:00
Sam
50203794e6
FIX: staged users should get emails on must_approve_users sites
2017-08-28 17:32:07 -04:00
Sam
9f0f086b3e
FEATURE: allow API to mark accounts as approved on creation
2017-08-28 15:36:46 -04:00
Bianca Nenciu
6bc74ceb50
Split alias levels in mentionable and messageable levels. ( #5065 )
...
* Split alias levels in mentionable and messageable levels.
* Fixed some tests.
* Set messageable level to everyone by default.
* By defaults, groups are not mentionable or messageable.
* Made staff groups messageable by the system.
2017-08-28 12:32:08 -04:00
Bianca Nenciu
bb3a5910d7
Support for sending PMs to email addresses ( #4988 )
...
* Added support for sending PMs to email addresses.
* Made changes after review.
* Added settings validator.
* Fixed tests.
2017-08-28 12:07:30 -04:00
Neil Lalonde
398604ac71
FEATURE: set purge_unactivated_users_grace_period_days to 0 to disable purging unactivated users
2017-08-25 15:20:06 -04:00
Neil Lalonde
2c56f8df7c
FEATURE: show tags in search results
2017-08-25 11:52:59 -04:00
Sam
bcbee91f0c
lint
2017-08-24 13:24:52 -04:00
Sam
f60a1b0275
correct erratic spec
2017-08-24 13:19:26 -04:00
Sam
a4e3e081c9
correct spec
2017-08-24 10:40:14 -04:00
Guo Xiang Tan
41ca527d7a
Fix Rubocop error.
2017-08-24 15:28:18 +09:00
Guo Xiang Tan
8779490ce4
Move new controller specs to reqeusts folder.
2017-08-24 12:01:11 +09:00
Guo Xiang Tan
68b8acbcfa
Make Redis test less brittle.
2017-08-24 10:00:15 +09:00
Guo Xiang Tan
4b4169c8fd
Merge pull request #5053 from fantasticfears/session-controller
...
Spec for local auth check
2017-08-24 09:42:54 +09:00
Guo Xiang Tan
d0f5a3d7a4
Sidekiq::Testing.fake! is the default mode.
2017-08-24 09:40:19 +09:00
Guo Xiang Tan
027b999828
Merge pull request #5071 from LeoMcA/remove_duplicated_without_posts
...
FIX: removed the duplicated staged users without posts
2017-08-24 09:23:36 +09:00
Sam
f766ea4257
Correct short url decoding for sha1s leading with zero
...
This was picked up cause we had a flaky test!
2017-08-23 11:08:18 -04:00
Sam
c7532003f3
add more diagnostics for flaky spec
2017-08-23 10:41:57 -04:00
Leo McArdle
3986367f3f
update pr based on review
2017-08-23 14:55:34 +01:00
Guo Xiang Tan
7c15b27a90
Merge pull request #5073 from xrav3nz/extract-github-avatar
...
FEATURE: import Github profile picture
2017-08-23 16:18:46 +09:00
Kyle Zhao
5868508e98
GH#retrieve_avatar: simplify conditional and restructured testing
2017-08-22 23:46:50 -04:00
Kyle Zhao
49f0119c12
FEATURE: import Github profile picture
2017-08-22 20:23:47 -04:00
Sam
8dfb1be4d1
FEATURE: unlisted *only* means not listed in topic lists
...
Remove security by obscurity feature that tries for exact slug match
If you need to hide a topic from users either move to a secure category
or convert to a PM
2017-08-22 17:53:54 -04:00
Neil Lalonde
224796a7d4
FIX: wrongs counts on tags with deleted topics
2017-08-22 16:55:05 -04:00
Sam
e8cdb1d8a7
correct flaky spec
2017-08-22 16:54:29 -04:00
Sam
d7a2584c6e
FEATURE: image uploads now have short urls
...
Shorten all image uploads to use short urls, this is the client
side implementation.
2017-08-22 16:40:08 -04:00
Sam
117ce24ac3
Correct a flaky spec
2017-08-22 13:56:38 -04:00
Sam
d4c28f6fcb
remove stray puts from spec
2017-08-22 11:46:51 -04:00
Sam
bcf7dc38c2
FEATURE: server side support for upload:// markdown
...
This allows uploads to be specified using short sha1 hash instead of full
URL
Client side change is pending
2017-08-22 11:46:23 -04:00
Leo McArdle
be1df3ba75
FIX: transfer posts by duplicated staged users to original
2017-08-22 09:58:51 +01:00
Arpit Jalan
b00747fd49
FIX: do not create topic link reflection for unlisted topics
2017-08-22 14:28:01 +05:30
Guo Xiang Tan
bc3e43b496
FIX: Topic timers being incorrectly trashed!.
...
https://meta.discourse.org/t/temporary-timed-closure-of-topic-not-re-opening-topic/67877
2017-08-22 15:23:09 +09:00
Guo Xiang Tan
87994a86ce
FIX: Don't set topic timer for close topics when changing category.
...
https://meta.discourse.org/t/moving-a-topic-after-closure-reopens-topic/67659/4
2017-08-22 12:54:34 +09:00
Guo Xiang Tan
2d4d76472d
FIX: Broken suspect user lists.
...
https://meta.discourse.org/t/server-error-code-500/68404
2017-08-22 11:16:55 +09:00
Sam
505939eab7
correct spec
2017-08-21 14:40:44 -04:00
Guo Xiang Tan
0d46c7a19b
Ensure we reset state for Messagebus.track_publish.
2017-08-21 22:29:14 +09:00
Guo Xiang Tan
e8f19e004e
Use find instead.
2017-08-21 22:28:43 +09:00
Sam
aeedecd27c
correct erratically failing spec
2017-08-18 15:10:37 -04:00
Sam
c2a6616035
Correct erratic spec failure
2017-08-17 15:26:31 -04:00
Sam Saffron
aea9db56d4
fix formatting
2017-08-17 08:10:57 -04:00
Mudasir Raza
84c83afd35
Allow optional import_mode param for posts in api ( #4952 )
2017-08-17 07:53:04 -04:00
Régis Hanol
629810bd07
FIX: when registering custom_field types, ensure we're casting them before checking for equality
2017-08-16 23:04:40 +02:00
Robin Ward
b78958fbfc
Silence CSS logging in development - it's way too noisy
2017-08-16 10:59:56 -04:00
Erick Guan
6e59149a77
FIX: rebuild index when engine replaced ( #5021 )
2017-08-16 07:38:34 -04:00
Erick Guan
c7a101476e
Spec for local auth check
2017-08-16 11:01:00 +02:00
Guo Xiang Tan
b77aa29e71
Merge pull request #5013 from LeoMcA/alternate-emails-phase-1.5
...
FIX: add additional email to tests and clean up resulting mess
2017-08-16 16:19:28 +09:00
Guo Xiang Tan
ed851dbfff
FIX: Avoid publishing a gigantic payload.
...
* Certain sites have way too many categories.
2017-08-16 11:38:30 +09:00
Guo Xiang Tan
996ce8c443
Merge pull request #5024 from fantasticfears/site-setting
...
FIX: fails loud if default setting is not set
2017-08-16 09:36:38 +09:00
Kyle Zhao
c3249f6e93
FEATURE: add full editing access to queued posts ( #5047 )
...
For pending new topics: the body of the post, title, categories
and the tags are editable.
For pending new replies: only the body is applicable and thus
editable
DISCUSSION: https://meta.discourse.org/t/66754
2017-08-15 12:44:05 -04:00
Erick Guan
1146772deb
Fix: unlinked topic search model ( #5044 )
2017-08-15 11:46:57 -04:00
Erick Guan
1646bc0031
FIX: fails loud if default setting is not set
...
Noted:
- `push_api_secret_key` is set in initializer. Shimed with ''
- `default_theme_key` is set in seeding. Shimed with ''
2017-08-15 12:07:25 +02:00
Joffrey JAFFEUX
506572bf04
FIX: display emojis (set, custom and native) in bio excerpt
2017-08-15 10:05:09 +02:00
Sam
6002f2ca4a
FIX: not splitting words correctly for search tokenizer
2017-08-14 16:19:39 -04:00
Leo McArdle
0ef7a969f2
Some more HTML to Markdown fixes ( #5046 )
...
* FIX: handle spaces better within emphasis tags in html_to_markdown
* FIX: handle line breaks at beginning of emphasis tags in html_to_markdown
2017-08-14 22:13:24 +02:00
Neil Lalonde
94d8f6d734
FIX: digest emails should not include posts that are still in the edit grace period
2017-08-14 12:47:33 -04:00
Régis Hanol
89e919ec42
UX: keep emojis in excerpts in flag queue
2017-08-14 15:16:47 +02:00
Neil Lalonde
9813f9f0f8
FIX: more cases of case sensitive group membership in sso
2017-08-11 18:09:29 -04:00
Bianca Nenciu
117417848e
Remove like on change of ownership. ( #5038 )
2017-08-11 09:55:00 +02:00
Guo Xiang Tan
f2539a86d0
Merge pull request #5036 from tgxworld/another_pass_at_removing_duplicated_users
...
FIX: Staged users were incorrectly created multiple times with same e…
2017-08-11 12:30:28 +09:00
Guo Xiang Tan
59423b693b
Merge pull request #5035 from nbianca/remove_spork
...
Remove Spork dependency.
2017-08-11 09:52:16 +09:00
Bianca Nenciu
1c079bec33
Remove Spork dependency.
2017-08-10 22:54:52 +01:00
Neil Lalonde
15a74d6d3e
FIX: don't enforce newuser_spam_host_threshold on private messages
2017-08-10 17:19:08 -04:00
Guo Xiang Tan
793eccf6c5
FIX: Staged users were incorrectly created multiple times with same email.
2017-08-10 18:56:15 +09:00
Guo Xiang Tan
f7d3702454
FIX: Return 404 if API access is invalid.
2017-08-10 18:27:01 +09:00
Guo Xiang Tan
b404a4b97c
Merge pull request #5034 from tgxworld/fix_staged_primary_email
...
FIX: Staged users are still missing primary email.
2017-08-10 10:30:51 +09:00
Neil Lalonde
ca1609c821
FIX: user directory didn't update stats of users with no recent activity
2017-08-09 15:57:42 -04:00
Guo Xiang Tan
90d7dd1f05
FIX: Ensure that post action moderation post uses the site's default locale.
...
https://meta.discourse.org/t/a-post-in-looking-for-someone-to-customize-discourse-to-create-a-forum-site-requires-staff-attention/67468/5?u=tgxworld
2017-08-09 18:20:20 +09:00
Arpit Jalan
bf2c35aa99
FEATURE: add RSS feed for badge pages
2017-08-09 13:43:49 +05:30
Guo Xiang Tan
898c6ba037
Merge pull request #5033 from tgxworld/reason_when_requesting_to_join_a_group
...
FEATURE: Force user to enter reason when requesting for group members…
2017-08-09 15:54:21 +09:00
Guo Xiang Tan
a9613163b5
FEATURE: Force user to enter reason when requesting for group membership.
2017-08-09 15:45:28 +09:00
Guo Xiang Tan
0bc690ed11
FIX: Staged users are still missing primary email.
2017-08-09 12:03:49 +09:00
Rafael dos Santos Silva
5324c9817f
FIX: Title prettify shoundn't downcase all non-ascii titles
2017-08-08 14:03:24 -03:00
Joffrey JAFFEUX
6cd8203686
FIX: allows onebox to force GET hosts returning wrong headers on HEAD
2017-08-08 11:44:27 +02:00
Guo Xiang Tan
2c39743d5d
Introduce multisite tests for better coverage.
2017-08-08 12:58:22 +09:00
Guo Xiang Tan
c5850422f0
FIX: SiteSettings defaults cache leaking across multisite.
2017-08-07 15:16:57 +09:00
Guo Xiang Tan
3f24ed2b3e
Can't revert due to incompatibility of new site setting types.
...
Revert "Revert "FEATURE: Site settings defaults per locale""
This reverts commit 439fe8ba24
2017-08-07 10:43:09 +09:00
Guo Xiang Tan
439fe8ba24
Revert "FEATURE: Site settings defaults per locale"
...
This reverts commit 468a8fcd20
2017-08-07 10:31:50 +09:00
Leo McArdle
a7b7fe335f
FIX: allow an admin to click on blank errors ( #5027 )
...
* FIX: allow an admin to click on blank errors
* i18nlize strings
* what would a rails master do?
2017-08-04 20:04:26 +02:00
Régis Hanol
3c0de22bf0
FIX: wasn't able to remove a user's primary group
2017-08-04 18:13:20 +02:00
Régis Hanol
519b70ea46
FIX: always trigger the ':user_updated' event
...
We don't always use the UserUpdated class to update a user's record
2017-08-04 18:12:10 +02:00
Leo McArdle
99527af38a
FIX: show rejected emails with unrecognized errors ( #5026 )
...
Although 407a23663d
2017-08-04 16:20:44 +02:00
Guo Xiang Tan
40fc6c429a
Merge pull request #5018 from discourse/wekbit-embedded-referer
...
FIX: First load of embed comments would always fail on WebKit
2017-08-04 14:12:26 +09:00
Guo Xiang Tan
8cc8010564
Maintain backwards compatibility before Jobs::MigrateUploadExtensions runs.
2017-08-03 11:56:55 +09:00
Guo Xiang Tan
a47e297508
Merge pull request #5019 from tgxworld/more_resiliency_to_readonly_redis
...
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-03 06:34:36 +09:00
Sam
5942ad83c0
Skip inline onebox for domain only
2017-08-02 17:27:58 -04:00
Leo McArdle
65d5cd7239
FIX: generate valid markdown from <br></b> in an email ( #5022 )
...
* FIX: generate valid markdown from <br></b> in an email
* FIX: don't generate markdown for empty <strong> or <em> tags in emails
2017-08-02 23:02:59 +02:00
Rafael dos Santos Silva
57a214e920
FIX: First load of embed comments would always fail on WebKit
2017-08-02 17:43:31 -03:00
Sam
a4e1920604
FIX: inline oneboxer not applying to lists
2017-08-02 16:10:08 -04:00
Sam
f6bc572fb8
FEATURE: option to enable inline oneboxes for all domains
...
Also, change to prefer title over open graph which is often way too sparse
2017-08-02 14:27:31 -04:00
Erick Guan
468a8fcd20
FEATURE: Site settings defaults per locale
...
This change-set allows setting different defaults for different locales.
It also:
- Adds extensive testing around site setting validation
- raises deprecation error if site setting has the default property based on env
- relocated site settings for dev and tests in the initializer
- deprecated client_setting in the site setting's loading process
- ensure it raises when a enum site setting being set
- default_locale is promoted to `required` category.
- fixes incorrect default setting and validation
- fixes ensure type check for site settings
- creates a benchmark for site setting
- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
Neil Lalonde
3de45ce0cd
FIX: use case insensitive group name search when applying group rules from SSO
2017-08-02 11:30:37 -04:00
Guo Xiang Tan
9bc3038728
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-02 21:33:56 +09:00
Guo Xiang Tan
b6ce93a965
Add specs for 1c80c233cf
2017-08-02 20:58:35 +09:00
Régis Hanol
e43799134c
fix the regexp used to valide user's website
2017-08-02 10:19:24 +02:00
Sam
97fa64d846
FIX: non tag/category # searches should be passed through
2017-08-01 18:15:14 -04:00
Sam
71ad3a48c2
Correct flaky distributed cache test
...
make distributed cache more testable
2017-08-01 16:11:48 -04:00
Guo Xiang Tan
5b76b9e888
Ensure that we cleanup after tests.
2017-08-01 23:42:26 +09:00
Guo Xiang Tan
7d5b6e2b3c
Disable MessageBus's keepalive when Redis is readonly.
2017-08-01 23:07:52 +09:00
Neil Lalonde
24edbbb89c
fix rubocop offenses
2017-07-31 20:34:02 -04:00
Neil Lalonde
fa3c240e8b
Merge pull request #4981 from dmacjam/fix_limited_search_results
...
FIX: limited search results
2017-07-31 20:23:57 -04:00
Leo McArdle
836dee1120
FIX: add additional email to tests and clean up resulting mess
2017-07-31 22:27:29 +00:00
Régis Hanol
88ba052446
secure default for the 'find_related_post_with_key' site setting
2017-08-01 00:03:04 +02:00
Sam
cdf7a020c1
correct mistake in spec
2017-07-31 16:40:59 -04:00
Neil Lalonde
7c1d7fb423
Merge branch 'master' into fix_limited_search_results
2017-07-31 15:55:31 -04:00
Erick Guan
f1eccd113c
Replace rmmseg gem for cppjieba_rb since better dictionary ( #5006 )
...
* Rename locale to ts config in search module to make it clear
* Replace rmmese-cpp for cppjieba_rb
2017-07-31 15:28:48 -04:00
Arpit Jalan
6c997b65d9
optimize enqueuing activation email code
2017-07-31 22:57:39 +05:30
Arpit Jalan
0b01d0e95d
FIX: staff cannot manually activate accounts after 48 hours has elapsed
...
https://meta.discourse.org/t/staff-cannot-manually-activate-invited-accounts-after-48-hours-has-elapsed/66292/14?u=techapj
2017-07-31 22:24:09 +05:30
Neil Lalonde
5d528f0d15
Merge pull request #4958 from dmacjam/search_posts_by_filetype
...
FEATURE: Search posts by filetype
2017-07-31 11:55:34 -04:00
Neil Lalonde
4a5907b116
Merge branch 'master' into search_posts_with_images
2017-07-31 10:44:41 -04:00
Jakub Macina
f8edf2636c
Fix rspec tests for search pagination.
2017-07-31 12:16:23 +02:00
Régis Hanol
c7f76aa554
fix the receiver_spec
2017-07-31 11:29:39 +02:00
Guo Xiang Tan
305b9b2da0
Add spec to ensure that even staged users contain a primary email.
2017-07-31 12:16:08 +09:00
Guo Xiang Tan
24e0e000b9
FIX: Always validate presence of user's primary_email.
2017-07-31 11:47:29 +09:00
Arpit Jalan
b059a0f789
extract url escaping to a dedicated class method and improved tests
2017-07-29 22:16:51 +05:30
Arpit Jalan
1fe553873c
FIX: preserve fragment identifier when escaping url
2017-07-29 17:22:45 +05:30
Sam
56fd3e1cd4
attempt to stablise flaky spec
2017-07-28 16:59:37 -04:00
Robin Ward
9a76559345
FIX: Remove unused test
2017-07-28 11:59:12 -04:00
Guo Xiang Tan
4620dfe92d
FEATURE: Add group settngs to allow users to leave a group freely.
...
https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565
2017-07-28 15:00:25 +09:00
Guo Xiang Tan
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
Sam
4f574e7c93
FEATURE: support inline bbcode blocks eg: [quote]test[/quote]
2017-07-27 17:55:17 -04:00
Neil Lalonde
68b3dd43ce
fix intermittent failing tests, some watched word refactoring
2017-07-27 12:27:01 -04:00
Guo Xiang Tan
75374c76b3
UX: Display button to message group on group page.
...
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
2017-07-27 17:51:25 +09:00
Guo Xiang Tan
2442bba131
UX: Better group creation workflow.
...
* Owners and users can now be added to a group during creation.
https://meta.discourse.org/t/you-cannot-allow-membership-requests-without-any-owners/64760/3
2017-07-27 16:12:42 +09:00
Sam
dc42d4411d
correct flaky spec
2017-07-26 13:22:19 -04:00
Neil Lalonde
24cb950432
FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block
2017-07-26 11:01:09 -04:00
David Taylor
27539e15e1
Allow whitespace around % scaler in markdown image syntax ( #5000 )
2017-07-26 10:54:20 -04:00
Neil Lalonde
ea0e90b2b0
Merge branch 'master' into search_posts_with_images
2017-07-26 10:15:55 -04:00
Guo Xiang Tan
b59dfb86f4
UX: Include group name in email when group is invited to a PM.
...
https://meta.discourse.org/t/xyz-invited-you-to-a-message-but-really-invited-a-group-im-in/65996
2017-07-26 15:51:44 +09:00
Guo Xiang Tan
d3a975e99a
Improve specs to check top level stylesheets for SCSS compilation errors.
...
https://meta.discourse.org/t/fwd-growth-institute-pm-error-in-css-on-embed/66824/4
2017-07-26 10:50:51 +09:00
Guo Xiang Tan
e3ac6585bd
FIX: Search by topic_id should not be restricted by SiteSetting.min_search_term_length.
2017-07-26 09:52:39 +09:00
Guo Xiang Tan
96267f0845
Merge pull request #4960 from discourse/category-description-error
...
FIX: Explicit error when category description post is bad
2017-07-26 08:54:22 +09:00
Sam
658c2f52c0
add diagnostics for flaky test
2017-07-25 17:09:13 -04:00
Sam
ad8643bfe2
attempt to stablise spec in travis
2017-07-25 16:58:19 -04:00
Sam
ccbcbd0343
remove 2 failures that happen if discobot booted
2017-07-25 16:08:03 -04:00
Sam
a20bb931b1
FIX: specs failed if discourse-push-notifications booted
2017-07-25 15:52:53 -04:00
Neil Lalonde
d8c27e3871
Merge branch 'master' into search_posts_by_filetype
2017-07-25 14:41:20 -04:00
Régis Hanol
d67fe4c674
FIX: block all emails associated to a user when destroying their record
2017-07-25 17:44:46 +02:00
Sam
f2d5bcd439
Stop writing to STDOUT/ERR during tests
2017-07-25 11:37:25 -04:00
Sam
c5b5c861f6
extend wait_for in case redis chokes up in test
2017-07-25 11:29:12 -04:00
Guo Xiang Tan
4cd9822611
Remove warnings in ColumnDropper.mark_readonly test.
2017-07-25 09:38:55 +09:00
Guo Xiang Tan
be3c9bca0b
Remove comment that is no longer relevant.
2017-07-25 08:58:40 +09:00
Sam
4da98cdcfe
FIX: allow bbcode to be unquoted for default
2017-07-24 18:36:17 -04:00
Sam
04eac9f14a
lets attempt to get these specs working!
2017-07-24 18:35:20 -04:00
Sam
f67e715ef1
comment out specs that break others
...
will check in a fixed spec tomorrow
2017-07-24 17:28:24 -04:00
Sam
c08a7aee8f
clean up skipped tests
...
tighter connection handling in scheduler
2017-07-24 15:06:24 -04:00
Sam
80bb127cd3
use time zone for extra safety
2017-07-24 13:08:17 -04:00
Sam
7ebb9874a8
freeze time in spec
2017-07-24 13:00:15 -04:00
Sam
40abcfc2f5
FIX: smart quote edge case with quotes
2017-07-24 12:21:49 -04:00
Sam Saffron
045a2abcec
FEATURE: remove the timecop gem
...
We should only have one way of mocking time, misuse of timecop
was causing build stability issues
2017-07-24 12:11:10 -04:00
Guo Xiang Tan
d940166a89
Re-enable skipped Scheduler::ScheduleInfo test.
2017-07-25 00:03:03 +09:00
Guo Xiang Tan
8ee31d3c85
Re-enable skip tests for Email::Styles.
2017-07-24 23:16:54 +09:00
Guo Xiang Tan
e82efc7b03
Fix SiteSetingExtension specs to coerce int to string.
2017-07-24 22:54:42 +09:00
Guo Xiang Tan
0ab0c82f11
Reenable skipped Email::Receiver spec.
2017-07-24 22:27:24 +09:00
Guo Xiang Tan
6b17178533
Validate uniquness of api_key.
2017-07-24 21:46:08 +09:00
Guo Xiang Tan
54b508dda3
Add back test to ensure user can't edit name after SiteSetting.username_change_period.
2017-07-24 20:47:34 +09:00
Guo Xiang Tan
d9c3ebe299
Reintroduce specs that wasn't causing random failures.
2017-07-24 19:32:38 +09:00
Régis Hanol
640ced004d
FIX: wasn't unfreezing time in email processor spec
2017-07-24 11:01:53 +02:00
Guo Xiang Tan
1b0750d7ef
Merge pull request #4983 from tgxworld/group_owners_can_invite_users_to_groups
...
Group owners can invite users to groups
2017-07-24 16:21:19 +09:00
Guo Xiang Tan
fa09a02201
Fix specs.
2017-07-24 15:56:08 +09:00
Guo Xiang Tan
25448b70e4
Fix specs.
2017-07-24 15:52:56 +09:00
Guo Xiang Tan
c12edda766
Use Timecop.freeze instead of Timecop.travel.
2017-07-24 15:40:57 +09:00
Guo Xiang Tan
86dbd76191
Fix random spec failure due to ordering.
2017-07-24 15:25:07 +09:00
Guo Xiang Tan
7f1e74a272
Not sure how this spec actually worked in the past.
2017-07-24 14:13:23 +09:00
Guo Xiang Tan
381a2a55be
Clear the cache after each test otherwise we are leaking state.
2017-07-24 11:41:37 +09:00
Sam Saffron
93f2c97266
simplify spec
2017-07-22 22:49:04 -04:00
Sam Saffron
687fbf5f09
simplify spec
2017-07-22 22:47:16 -04:00
Sam Saffron
b9757bd02e
remove readonly column specs for now
2017-07-22 22:20:57 -04:00
Sam Saffron
7caf82f03c
simplify spec
2017-07-22 22:01:11 -04:00
Sam
8ef4d6d812
this was failing erratically
2017-07-21 17:14:06 -04:00
Robin Ward
2f8f2aa1dd
FEATURE: Whitelists for inline oneboxing
2017-07-21 15:41:47 -04:00
Rafael dos Santos Silva
89ef5d36a9
FIX: Explicit error when category description post is bad
2017-07-21 16:07:29 -03:00
Régis Hanol
fff5e2c3a5
Merge pull request #4984 from LeoMcA/unrecognized-error-email
...
FEATURE: send rejection email for unrecognized errors
2017-07-21 20:40:18 +02:00
Robin Ward
574681dc47
FIX: Show emoji in inline oneboxes
2017-07-21 14:24:48 -04:00
Leo McArdle
407a23663d
FEATURE: send rejection email for unrecognized errors
2017-07-21 18:26:52 +01:00
Sam
e1ce47a901
Pass the full CommonMark spec
2017-07-21 13:20:52 -04:00
Leo McArdle
ddc0134b48
add DiscourseEvent triggers necessary to update a user's permissions before they're notified
2017-07-21 11:03:54 -04:00
Guo Xiang Tan
2a17f1ccd7
FIX: Group owners should be able to invite users to their groups.
...
https://meta.discourse.org/t/group-owner-cannot-send-an-invite-to-a-group/60617/12
2017-07-21 23:48:25 +09:00
Jakub Macina
4eb7f7cd10
Add rspec tests for search pagination.
2017-07-21 10:43:02 +02:00
Guo Xiang Tan
fe05587134
Fix incorrect filename.
2017-07-21 13:37:32 +09:00
Sam
fc90dd3592
Work in progress, CommonMark spec
2017-07-20 17:47:16 -04:00
Robin Ward
d2490cbbb8
Test failures for Inline Onebox
2017-07-20 16:01:16 -04:00
Robin Ward
3882722195
FEATURE: Inline (Mini) Oneboxing
...
see:
https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 15:38:04 -04:00
Sam
44fb2a2833
DEV: support multiple capture groups for text post process
2017-07-20 15:33:44 -04:00
Sam
e7c170bb00
test v8 heap stats and aggregate all
2017-07-20 13:23:48 -04:00
Sam
1096dcd602
correct bbcode parsing edge case
2017-07-20 13:02:40 -04:00
Sam
911ffbb98c
Correct mention edge cases
...
@sam. was not correctly detected as a mention
2017-07-20 11:52:38 -04:00
Leo McArdle
d0b027d88d
FEATURE: phase 1 of supporting multiple email addresses
2017-07-20 11:22:27 +09:00
Guo Xiang Tan
b534778f46
FIX: Escape URL before attempting to resolve it.
2017-07-18 10:04:24 +09:00
Sam
627f5ddbd1
Correct specs
2017-07-17 18:00:25 -04:00
Sam
c7b0764089
correct more edge cases with new engine
2017-07-17 17:44:48 -04:00
Sam
8921058c67
FIX: medium URL with @ incorrectly handled as mention
...
Also:
- remove unused code
- rename bbcode_ruler to bbcode.ruler
- add md.core.textPostProcess.ruler to apply at end of chain (excluding links)
2017-07-17 17:44:48 -04:00
Robin Ward
cdb3706025
Track clicks on topics in search results
2017-07-17 15:42:32 -04:00
Robin Ward
21e02d6969
Include the search_log_id in search results
2017-07-17 12:10:32 -04:00
Sam Saffron
d0c5205a52
Feature: Change markdown engine to markdown it
...
This commit removes the old evilstreak markdownjs engine.
- Adds specs to WhiteLister and changes it to stop using globals
(Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs
2017-07-17 11:41:34 -04:00
Robin Ward
6b6ad9391b
Clean up job for search logs
2017-07-14 14:30:58 -04:00
Robin Ward
d7f783ffed
Replace search mock tests with integration test
2017-07-14 14:30:58 -04:00
Robin Ward
97e211f837
FEATURE: Log Search Queries
2017-07-14 14:30:58 -04:00
Guo Xiang Tan
9792e03c63
FIX: Group name was being reverted to non-localized version.
...
https://meta.discourse.org/t/localized-staff-group-names-changed/65360/16
2017-07-14 14:15:33 +09:00
Sam
79a084dd58
Revert "remove old markdown engine work-in-progress"
...
This reverts commit ee470b5317
2017-07-12 18:10:51 -04:00
Sam
bcbb9f208d
Revert "Integrate new engine, correct old specs"
...
This reverts commit f1b38ba4fb
2017-07-12 18:10:07 -04:00
Sam
3613ebee5b
Revert "correct specs"
...
This reverts commit 2c6284ece3
2017-07-12 18:09:57 -04:00
Sam
2c6284ece3
correct specs
2017-07-12 18:03:56 -04:00
Sam
f1b38ba4fb
Integrate new engine, correct old specs
...
corrects edge cases with
- full quotes
- [url] with nested tags
- engine overrides
- onebox applying to non http srcs
2017-07-12 17:44:40 -04:00
Sam Saffron
ee470b5317
remove old markdown engine work-in-progress
2017-07-12 17:44:40 -04:00
Arpit Jalan
76981605fa
FIX: don't raise error when inviting existing user to private topic via email
...
https://meta.discourse.org/t/inviting-existing-user-to-a-private-topic-message-via-email-shows-error-message/65994
2017-07-12 21:51:21 +05:30
Jakub Macina
677267ae78
Add onceoff job for uploads migration of column extension. Simplify filetype search and related rspec tests.
2017-07-12 17:19:27 +02:00
Sam
5d139e461c
FIX: multi option poll not working (new engine)
2017-07-11 14:43:34 -04:00
Bianca Nenciu
1c917cc391
Added test.
2017-07-11 13:59:37 -04:00
Sam
3f950a756a
FEATURE: support image dimensions via Markdown image
2017-07-11 12:13:03 -04:00
Guo Xiang Tan
45f4ce379e
Fix broken specs.
2017-07-11 13:16:48 +09:00
Guo Xiang Tan
b605d5d61b
FIX: Translation should return overrides first before attempting to fallback.
...
https://meta.discourse.org/t/errors-after-migrating-to-a-new-version-1-9-0-beta3/65709/14?u=tgxworld
2017-07-11 12:51:12 +09:00
Guo Xiang Tan
f529cb1674
Remove validation for invalid interpolation keys.
...
* Our codebase currently supports custom interpolations keys that are
not present in the original translation. The proper fix should
be to make `TranslateOverride` aware of such keys.
2017-07-11 11:12:11 +09:00
Guo Xiang Tan
c5b1317a15
Remove code that is no longer being used.
2017-07-11 11:11:51 +09:00
Sam
ba9898c5a9
FIX: smarter newline handling for <img> tags on line alone
...
Run all of pretty text spec on new engine
2017-07-10 12:22:15 -04:00
Régis Hanol
c66b9dcdbd
add 'us-east-2' S3 region
2017-07-10 15:36:38 +02:00
Guo Xiang Tan
a338a7a53e
Fix the build.
2017-07-10 11:12:21 +09:00
Guo Xiang Tan
2255724637
UX: Add validator for SiteSetting#sso_overrides_email.
2017-07-10 10:08:55 +09:00
Robin Ward
f1a6449e4b
SECURITY: Remove disposable invite feature
2017-07-07 20:24:39 -04:00
Blake Erickson
fcfc895167
FIX: new sign-ups via google are added to groups
...
This fix ensures that users that are signing up via google oauth are
automatically added to any groups.
A similar fix will probably need to be added to other oauth providers.
2017-07-07 14:08:58 -06:00
Neil Lalonde
a509146ea5
FIX: support non-english tags in tag input field
2017-07-07 14:48:08 -04:00
Sam
6f09df0deb
FIX: don't create tags autolinks inside links (new engine)
2017-07-07 13:04:25 -04:00
Sam
74f6894606
oops checked in a broken test
2017-07-07 11:08:04 -04:00
Sam
436b894f7a
FIX: mention not working after a newline (new engine)
2017-07-07 11:06:50 -04:00
Guo Xiang Tan
13f3de4bf6
Nuke all SiteSetting.stubs from our codebase.
2017-07-07 15:09:14 +09:00
Guo Xiang Tan
e7e16de3e0
Remove use of stubs in specs.
2017-07-07 13:18:53 +09:00
Guo Xiang Tan
a4399c2eab
FIX: Translation overrides were not cached by locale properly.
2017-07-07 12:28:00 +09:00
Arpit Jalan
5b67cd1937
Merge pull request #4956 from techAPJ/pm-recipients
...
FEATURE: new site setting to limit message recipients
2017-07-06 22:57:33 +05:30
Arpit Jalan
7cffbc8ba8
FEATURE: new site setting to limit message recipients
...
New site setting `max_allowed_message_recipients` to limit message
recipients
https://meta.discourse.org/t/one-of-my-users-just-group-messaged-100-other-user-with-a-spam-offer/65612/7?u=techapj
2017-07-06 22:52:49 +05:30
Jakub Macina
8c445e9f17
Fix backend code for searching by a filetype as a combination of uploads and topic links. Add rspec test for extracting file extension in upload.
2017-07-06 19:19:31 +02:00
Jakub Macina
f0a674d620
Add extraction of upload extension. Add rspec test for search of post
...
with upload by extension.
2017-07-06 19:16:07 +02:00
Guo Xiang Tan
e92acb4c40
FIX: Jobs::PullHotlinkedImages#is_valid_image_src returns true for a generic string.
2017-07-06 18:31:15 +09:00
Neil Lalonde
fcb2f68565
FIX: duplicate topics and posts in summary email because user has muted tags and topics contain multiple tags
2017-07-04 16:12:10 -04:00
Neil Lalonde
3964929c75
FIX: summary email excludes all untagged topics if user has muted some tags
2017-07-04 12:52:25 -04:00
Guo Xiang Tan
a7a8ccb100
Merge pull request #4948 from tgxworld/fix_translation_fallback_not_using_overrides
...
FIX: Translation fallback was not using fallback's translation override.
2017-07-04 09:08:22 +09:00
Sam
d2ba543ed3
correct case where %20 decoded as space in auto link
...
correct case where onebox is not applied when url is decoded
2017-07-03 16:32:53 -04:00
Sam
340a3ee5cb
correct spec to handle not null visibility_level
2017-07-03 16:03:26 -04:00
Sam
845170bd6b
FEATURE: add support for group visibility level
...
There are 4 visibility levels
- public (default)
- members only
- staff
- owners
Note, admins and group owners ALWAYS have visibility to groups
Migration treated old "non public" as "members only"
2017-07-03 15:26:57 -04:00
Sam
c79418d334
DEV: Move RTL into lib where it belongs
2017-07-03 15:26:57 -04:00
Arpit Jalan
984778d3ac
FIX: handle moving first post to a closed/archived topic
2017-07-03 21:21:20 +05:30
Arpit Jalan
72c92b0f4e
FIX: include canonical meta tag on category pages
2017-07-03 13:25:22 +05:30
Guo Xiang Tan
52e654b3ac
FIX: Translation fallback was not using fallback's translation override.
...
https://meta.discourse.org/t/discobot-falling-back-to-site-locale-is-not-using-customized-copies/65140
2017-07-03 14:52:27 +09:00
Arpit Jalan
16d356ab4e
FEATURE: resending invite should include original custom message
...
https://meta.discourse.org/t/will-resent-invite-include-original-custom-message/64699
2017-06-30 18:13:33 +05:30
Sam
d941ed90d6
support for bbcode [code] blocks
2017-06-29 16:04:10 -04:00
Sam
de50d8cd35
Support for [email] [url] [img] bbcodes
2017-06-29 14:00:09 -04:00
Arpit Jalan
e7b9b1312e
FEATURE: remove all invites
...
https://meta.discourse.org/t/remove-all-invitations-button-for-the-admin-panel/65207
2017-06-29 22:30:10 +05:30
Sam
c6b83f4714
Correct logic so hashtags are properly ignored in links
2017-06-29 12:48:20 -04:00
Guo Xiang Tan
5e156fbe85
FIX: Group.search should look up Group#full_name too.
...
https://meta.discourse.org/t/mentioning-group-by-full-name-doesnt-work/63437/3
2017-06-29 16:37:59 +09:00
David Taylor
9294826f31
Allow inclusion of elided text from emails when sending to a category… ( #4844 )
...
* Allow inclusion of elided text from emails when sending to a category address
2017-06-29 13:03:14 +09:00
Sam
0e391a72a1
use custom whitelister for tables
2017-06-28 16:08:29 -04:00
Sam
cfbda863e8
implement unicode emoji replacements
2017-06-28 13:47:30 -04:00
Robin Ward
b93edc9945
FIX: Make sure censored words are on boundaries in topic titles
2017-06-28 13:13:40 -04:00
Sam
4c5109ff5b
FEATURE: site setting for Markdown typographer
...
It ships anyway with markdown.it so we might as well expose it
2017-06-27 16:50:13 -04:00
Sam
0d62420cbe
Space prior to onebox stops onebox resolution
2017-06-27 16:16:17 -04:00
Sam
232de90607
explicit autolink should not be oneboxed
2017-06-27 15:34:16 -04:00
Sam
5897ae945a
FIX: stop using inline quote for local onebox
2017-06-27 10:57:38 -04:00
Sam
0e0092d738
corrected a parsing edge cases for bbcode blocks
2017-06-27 10:07:06 -04:00
Régis Hanol
cdf8baac3b
fix specs due to new default emoji set
2017-06-26 23:36:30 +02:00
Sam
21f7ac1f25
correct spec, require closing tag for bbcode blocks
2017-06-26 16:51:55 -04:00
Robin Ward
db485ae0da
FIX: Support for skipping redirects on certain domains (like steam)
2017-06-26 15:38:43 -04:00
Sam
8967d50dc2
Clean up sanitization code
...
- remove html table test, this is soon to be deprecated
- move sanitization tests into pretty text.rb
- fix up whitelister so it makes a copy of options
2017-06-26 15:21:47 -04:00
Neil Lalonde
69b2d64334
FIX: letter avatars in quotes on subfolders installs are broken
2017-06-23 17:12:13 -04:00
Sam
814c8804d4
correct text highlighting for no highlight
2017-06-23 14:35:46 -04:00
Sam
b7386958ed
don't leak state into other tests
2017-06-23 12:01:33 -04:00
Sam
234694b50f
Feature: CommonMark support
...
This adds the markdown.it engine to Discourse.
https://github.com/markdown-it/markdown-it
As the migration is going to take a while the new engine is default
disabled. To enable it you must change the hidden site setting:
enable_experimental_markdown_it.
This commit is a squash of many other commits, it also includes some
improvements to autospec (ability to run plugins), and a dev dependency
on the og gem for html normalization.
2017-06-23 12:01:33 -04:00
Régis Hanol
a9c0df0b58
FIX: always try to convert PNG to JPG when pasting an image
2017-06-23 12:13:48 +02:00
Guo Xiang Tan
80e348d226
PERF: Speed up slow tests in our test suite.
...
Before
```
Finished in 7 minutes 23 seconds (files took 4.15 seconds to load)
7145 examples, 0 failures, 10 pending
```
After
```
Finished in 6 minutes 12 seconds (files took 4.41 seconds to load)
7145 examples, 0 failures, 10 pending
```
2017-06-22 11:23:31 +09:00
Neil Lalonde
8fd915a11a
Revert "FIX: add path to cookies so sessions on the same domain but different subfolders don't log each other out"
2017-06-21 16:18:24 -04:00
Robin Ward
aaaa93c216
FIX: Full page search was removing advanced search terms
2017-06-21 15:51:15 -04:00
Arpit Jalan
6796de8bf2
FIX: replace site_name with email_prefix in subject when use_site_subject is true
2017-06-21 21:15:49 +05:30
Guo Xiang Tan
4c98bd9d5f
FIX: Can't update status_type of topic timers.
...
https://meta.discourse.org/t/topic-timers-internal-error-500/64805
2017-06-21 15:31:15 +09:00
Jakub Macina
aad1c9bef2
Add rspec tests for searching by a filetype.
2017-06-20 21:21:56 +02:00
Neil Lalonde
1716747810
FIX: add path to cookies so sessions on the same domain but different subfolders don't log each other out
2017-06-20 13:30:36 -04:00
Jakub Macina
eaf46431d4
Add extraction of file extension in TopicLink and related rspec tests.
2017-06-19 17:09:54 +02:00
Jakub Macina
bf002e0873
Add extraction of image_url for oneboxed images. Fix search by images filter name.
2017-06-19 15:18:02 +02:00
Guo Xiang Tan
b9fbc95ef4
Add spec to notify us when translations have invalid interpolation keys.
2017-06-19 12:39:30 +09:00
Alberto Aguirre
b24bdc5b20
FIX: discourse_hub_spec stub_request should include query params
2017-06-18 14:40:28 -05:00
Neil Lalonde
c5f42f0e97
fix discourse_hub_spec
2017-06-16 15:31:13 -04:00
Guo Xiang Tan
a6450f7377
REFACTOR: Allow delete_removed_posts_after SiteSetting to be bypassed.
2017-06-16 12:27:51 +09:00
Guo Xiang Tan
d82dbd565b
FIX: Remove dependency on rest-client.
2017-06-16 09:42:41 +09:00
Guo Xiang Tan
cae09ee4c8
Fix failing specs.
2017-06-16 09:39:54 +09:00
Guo Xiang Tan
b5ec241716
FIX: Validate interpolation keys used in translation overrides.
...
https://meta.discourse.org/t/discobot-translation-missing-error/64429/6?u=tgxworld
2017-06-16 08:54:48 +09:00
Neil Lalonde
eb9f306e64
FIX: fail to send email notification if post has img tag with no src attribute
2017-06-15 10:36:19 -04:00
Sam
ac1f84d3e1
SECURITY: theme key should be an anon cache breaker
2017-06-15 09:36:27 -04:00
Joffrey JAFFEUX
f1750be2be
Fixes woman_shrugging name conversion
2017-06-15 08:26:29 +02:00
Guo Xiang Tan
b5249fb4ca
FIX: Send request membership PM to last 5 active group owner.
2017-06-15 11:37:09 +08:00
Neil Lalonde
b98a930364
Merge pull request #4896 from dmacjam/multiple-tags-logical-and-search
...
FEATURE: Advanced search supports logical AND of multiple tags
2017-06-14 14:39:23 -04:00
Régis Hanol
d6c63cc5b2
FIX: user's default group should only be set once
...
Setting a user's default groups based on their email address should only be done once, ie. when they confirm their email address.
Previously we were doing this everytime we'd save a user record 🤷
2017-06-14 19:20:18 +02:00
Joffrey JAFFEUX
95e1843d33
Improves native emoji conversion
2017-06-14 17:42:52 +02:00
Joffrey JAFFEUX
ab6086bce9
Transforms native skin toned emojis to valid names
2017-06-14 15:35:37 +02:00
Guo Xiang Tan
2fdf9068eb
FIX: Create notification for group users when group has been invited.
...
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509
2017-06-14 14:53:49 +09:00
Joffrey JAFFEUX
299339a373
Fixes emoji name to code missing tones
2017-06-13 14:10:26 -04:00
Arpit Jalan
34996b4eff
FIX: show invite validation error message in response
2017-06-13 22:41:53 +05:30
Robin Ward
009f0921dc
FEATURE: Whitelist hosts for internal crawling
2017-06-13 12:59:54 -04:00
Sam
826f332766
Merge pull request #4901 from jjaffeux/emoji-5.0
...
Emoji next
2017-06-13 11:12:41 -04:00
Régis Hanol
5d63a7f4a6
FIX: pull hotlinked images even when they have no extension
2017-06-13 13:27:05 +02:00
Guo Xiang Tan
a5d3abc9b6
FIX: Create group membership request on behalf of user.
2017-06-13 17:49:21 +09:00
Régis Hanol
54e8fb0d89
FEATURE: new 'allow_staff_to_upload_any_file_in_pm' site setting
2017-06-12 22:41:29 +02:00
Robin Ward
a3729b51eb
FIX: Always allow the host the forum is hosted on
2017-06-12 13:22:51 -04:00
Arpit Jalan
b9c94aa234
FEATURE: add required user fields to invite accept form
...
UX: make "accept invitation" page consistent with sign up modal
2017-06-12 20:43:07 +05:30
Guo Xiang Tan
eab3562864
Merge pull request #4905 from tgxworld/strip-zero-width-chars-from-search-term
...
FIX: Strip zero-width characters from search terms.
2017-06-12 18:01:02 +09:00
Guo Xiang Tan
5994c85ea9
FIX: Raise the right error when email params is missing.
2017-06-12 17:48:32 +09:00
Guo Xiang Tan
e888369f51
UX: Don't send emails for discobot notifications.
2017-06-12 17:00:27 +09:00
Robin Ward
b5bead1fe3
FIX: Don't use target=_blank for local oneboxes
2017-06-09 12:15:36 -04:00
Jakub Macina
76712da166
Add backend code for searching posts with images.
2017-06-09 10:30:21 +02:00
Robin Ward
602e4d0da4
FIX: Return nil when the reply_key is missing
2017-06-08 14:28:48 -04:00
Régis Hanol
038454bde2
FIX: always confirm emails when SSO says so
2017-06-08 01:05:33 +02:00
Régis Hanol
e8f0771dc9
FIX: the 'clean_up_uploads' jobs would delete images used in site settings
...
when they were entered using absolute URLs, with the CDN or simple a different format than the one used in the database
2017-06-07 22:53:15 +02:00
Robin Ward
54bb2a6bc2
FIX: Don't redirect to wizard when resetting password
2017-06-07 12:36:52 -04:00
Guo Xiang Tan
5794ff53a1
FIX: Copy custom fields when moving first post of a topic.
...
https://meta.discourse.org/t/transfer-poll-votes-when-moving-a-topic-into-an-existing-one/63678
2017-06-07 19:04:48 +09:00
Guo Xiang Tan
684b05f510
FIX: Strip zero-width characters from search terms.
2017-06-07 18:19:47 +09:00
Guo Xiang Tan
2cad739262
FIX: Better error message when username change fails.
...
https://meta.discourse.org/t/500-error-on-username-edit/64064
2017-06-07 10:45:53 +09:00
Guo Xiang Tan
da736f70a4
Merge pull request #4845 from vinothkannans/download-onebox-images
...
FEATURE: pull onebox images
2017-06-07 09:55:04 +09:00
Robin Ward
53b95f009f
FIX: If HEAD is not supported, try GET. Also set cookies
2017-06-06 13:53:49 -04:00
Vinoth Kannan
209383faab
FEATURE: pull onebox images
2017-06-06 18:51:58 +05:30
Jakub Macina
8f7d81fde6
Add rspec test for searching posts with images.
2017-06-06 14:39:53 +02:00
Joffrey JAFFEUX
09d34b7642
emoji images are now v5 not v3
...
TODO: we should not hardcode this
2017-06-05 16:10:36 +02:00
Guo Xiang Tan
ac6c1acbed
FIX: Groups that do not have any owners should not allow membership requests.
2017-06-05 10:02:37 +09:00
Arpit Jalan
a10c939775
FIX: do not show website name on TL0 profile
2017-06-04 18:30:28 +05:30
Arpit Jalan
a1ebd67237
Revert "FEATURE: new setting to prioritize open topics in search"
2017-06-03 01:54:35 +05:30
Arpit Jalan
b8a87a0996
FEATURE: new setting to prioritize open topics in search
2017-06-03 00:33:53 +05:30
Sam
b4060778d9
FIX: you should always be allowed to see actions you created
2017-06-02 14:24:06 -04:00
Sam
096177d0d5
confirm we notify on the destination, not source
2017-06-02 11:20:40 -04:00
Jakub Macina
eaec35d230
Fix tag related advanced search tests into one context. Fix dynamic locale and select clause in search by all tags. Fix separator for all tags to plus sign.
2017-06-02 12:39:07 +02:00
Guo Xiang Tan
af3dc4e537
FIX: Publish group's categories to user when adding user to group.
...
https://meta.discourse.org/t/joining-a-group-doesnt-take-effect-unless-the-browser-is-hard-refreshed/57357/11?u=tgxworld
2017-06-02 17:38:14 +09:00
Sam
a7fc93acac
FIX: post mover not clearing reply_to_user_id
2017-06-01 18:00:14 -04:00
Guo Xiang Tan
2ee144c27f
FEATURE: Add DiscourseEvent trigger when a user logs in.
...
* Also adds a event trigger when user logs in for the first time.
2017-06-01 17:44:49 +09:00
Guo Xiang Tan
bd486100c0
Remove stubs on DiscourseEvent in tests.
2017-06-01 16:21:00 +09:00
Guo Xiang Tan
b0dd05fdc6
FIX: Inherit topic auto close when changing topic's category.
2017-05-31 17:40:21 +09:00
Sam
607998af33
FEATURE: dropdown to filter staff action logs
2017-05-30 11:25:42 -04:00
Jakub Macina
6d1fafaff6
Add rspec tests for advanced search by tags.
2017-05-30 13:01:17 +02:00
Sam
0aed2533ac
Revert unread optimisation, has too many edge cases
2017-05-26 09:04:13 -04:00
Guo Xiang Tan
4d9481bf47
Fix build.
2017-05-26 16:04:59 +08:00
Guo Xiang Tan
56f98de7b2
Use webmock to stub external web requests.
2017-05-26 15:19:09 +08:00
Guo Xiang Tan
f8f1548fd4
Revert "FIX: Use Excon to do its own stubbing"
...
This reverts commit 80af54460a
2017-05-26 13:04:25 +08:00
Guo Xiang Tan
e57d2f5cb8
FIX: Don't do anything if avatar url returns an invalid status code.
2017-05-26 13:02:40 +08:00
Robin Ward
b584264d82
FIX: Don't show "resend email" option when user approval is on
2017-05-25 15:29:05 -04:00
Sam
29fac1ac18
PERF: improve performance of unread queries
...
Figuring out what unread topics a user has is a very expensive
operation over time.
Users can easily accumulate 10s of thousands of tracking state rows
(1 for every topic they ever visit)
When figuring out what a user has that is unread we need to join
the tracking state records to the topic table. This can very quickly
lead to cases where you need to scan through the entire topic table.
This commit optimises it so we always keep track of the "first" date
a user has unread topics. Then we can easily filter out all earlier
topics from the join.
We use pg functions, instead of nested queries here to assist the
planner.
2017-05-25 15:07:30 -04:00
Robin Ward
cdbe027c1c
Refactor FileHelper to use keyword arguments.
2017-05-24 13:54:26 -04:00
Sam
f12490eae0
FIX: order:latest not working for search within topic
...
FEATURE: use 'l' as a shorthand for order:latest
2017-05-24 11:24:41 -04:00
Robin Ward
3b0cbf7013
FIX: Always allow downloads from CDN
2017-05-23 16:32:54 -04:00
Robin Ward
d2121ca272
FIX: Missing HTTP stub
2017-05-23 15:08:19 -04:00
Robin Ward
b81e7be9a1
FEATURE: Rate limit how often we'll crawl a destination IP
2017-05-23 15:03:04 -04:00
Robin Ward
36e477750c
FIX: Use same code path for downloading images
2017-05-23 14:51:30 -04:00
Robin Ward
e5e7a15a85
SECURITY: Never crawl by IP
2017-05-23 13:07:18 -04:00
Robin Ward
93a5fc62bf
FEATURE: A site setting to prevent crawling on private IP blocks
2017-05-23 11:56:06 -04:00
Robin Ward
80af54460a
FIX: Use Excon to do its own stubbing
2017-05-22 18:19:20 -04:00
Robin Ward
b51126dd5e
FIX: Reset the WebMock after before every test
2017-05-22 17:52:31 -04:00
Régis Hanol
9dddb81cf6
FIX: remove memoization on class method used in a job
2017-05-22 23:35:41 +02:00
Blake Erickson
4e8beda332
Merge pull request #4866 from JaredReisinger/admin-user-pagination
...
Add pagination to /admin/users/list API
2017-05-22 15:12:59 -06:00
Robin Ward
d4b16b487e
FIX: Another onebox head request
2017-05-22 17:00:19 -04:00
Robin Ward
a8d1e44943
FIX: Onebox will do a HEAD request first for redirects
2017-05-22 16:52:26 -04:00
Robin Ward
4c690f7089
Use FinalDestination to ensure public redirects for onebox
2017-05-22 16:42:49 -04:00
Robin Ward
b23fc2bf84
Helper to find the final destination for a URL
2017-05-22 15:52:41 -04:00
Sam
6231318462
Merge pull request #4877 from rimian/plugin_helper
...
FEATURE: Require spec helpers for plugins
2017-05-22 15:22:55 -04:00
Régis Hanol
a7f337fa93
FIX: CDN wasn't properly applied to category background images when using S3
2017-05-22 18:37:01 +02:00
Guo Xiang Tan
76229535ac
Remove old test case.
2017-05-22 18:23:09 +08:00
Guo Xiang Tan
08c36fa968
REFACTOR: Clean up some code associated with topic timers.
2017-05-22 18:10:29 +08:00
Guo Xiang Tan
238a156300
FIX: TopicTimestampChanger should not allow timestamps in the future.
2017-05-22 16:03:49 +08:00
Guo Xiang Tan
4382a0bb07
Rename PostTimestampChanger -> TopicTimestampChanger.
2017-05-22 15:01:33 +08:00
Rimian Perkins
2b5dfb6e8e
avoid double lookup for plugin helpers
2017-05-22 14:50:53 +10:00
Guo Xiang Tan
330338af3a
FIX: Don't hardcode text in smoke test.
2017-05-22 08:01:33 +08:00
Robin Ward
908433a7a0
SECURITY: Validate the entity when downloading a CSV
2017-05-19 16:00:51 -04:00
Robin Ward
28f486cb7a
FIX: Regular users shouldn't be able to invite to PMs if disabled
2017-05-19 12:57:21 -04:00
Guo Xiang Tan
2b66918199
Wrong function call.
2017-05-19 22:33:06 +08:00
Guo Xiang Tan
130e7f214b
Account for sites using text site logo in smoke test.
2017-05-19 22:25:08 +08:00
Guo Xiang Tan
8ab9f30bbd
FIX: User can't remove bookmark from a deleted post.
2017-05-19 12:25:12 +08:00
Rimian Perkins
8febaa8be7
FEATURE: Require spec helpers for plugins
...
* Follows any symlinked plugins
2017-05-19 12:38:36 +10:00
Régis Hanol
4fb335f1f0
FIX: don't process the same incoming email more than once
2017-05-18 16:43:07 +02:00
Régis Hanol
13e489b4ca
replace the upload type whitelist with a sanitizer
2017-05-18 12:13:13 +02:00
Guo Xiang Tan
f4cc71d643
Allow username and password to be passed via ENV for smoke test.
2017-05-18 12:17:31 +08:00
Neil Lalonde
cbe8e05f79
disable test that fails randomly
2017-05-17 12:46:50 -04:00
Neil Lalonde
a0f03936ff
FIX: saving invisible primary group field that you don't belong to
2017-05-17 12:46:50 -04:00
Régis Hanol
a1b8a3b52b
FIX: supports bare <li> when converting html to markdown
2017-05-17 15:05:11 +02:00
Guo Xiang Tan
92036616db
Make test less vulnerable to changes.
2017-05-17 19:30:13 +08:00
Guo Xiang Tan
b0e4555a86
Allow Basic Authentication to be set in smoke test.
2017-05-17 19:24:43 +08:00
Guo Xiang Tan
3df46833b3
Fix the build.
2017-05-17 16:14:06 +08:00
Sam
6a1f579c6e
FIX: don't search for plugins in nested subdirectories
2017-05-16 17:28:56 -04:00
Jared Reisinger
645f648ea7
Merge remote-tracking branch 'upstream/master' into admin-user-pagination
2017-05-16 13:36:47 -07:00
Sam
763f156d91
FIX: require re-activation if SSO changes email and updates it
2017-05-16 16:18:18 -04:00
Sam
4b449914b8
FIX: admins could never remove self from messages
2017-05-16 16:06:24 -04:00
Neil Lalonde
7821400141
FEATURE: staff can set a timer to remind them about a topic
2017-05-16 14:49:50 -04:00
Robin Ward
dd0cb6a117
FIX: Add missing test
2017-05-15 16:57:09 -04:00
Robin Ward
bd0bb879e5
FIX: Don't count likes from system users in the new user of the month
2017-05-15 13:14:32 -04:00
Sam
e1dd543a93
FEATURE: allow users to select theme on single device
2017-05-15 12:48:16 -04:00
Sam
44d7fe89ed
FIX: unescape emoji in pretty title
...
This makes emoji in title consistent, it is later escaped back when needed
2017-05-15 10:28:05 -04:00
Sam
8491f8c48b
add smoke test for visiting categories
2017-05-12 17:42:38 -04:00
Robin Ward
62d245dde3
Try bumping the timeout for the smoke test
2017-05-12 16:40:38 -04:00
Jared Reisinger
1dcd61fa34
Add pagination to /admin/users/list API
...
Prior to this, only the first 100 active/new/etc. users were available
via the `/admin/users/list` API. This change adds support for a
`page=#` querystring parameter so that *all* of the users can be
retrieved. Requests for pages past the last user result in an
empty-list response; requests for negative pages (or zero) just return
the first page.
Added tests to cover pagination.
2017-05-12 13:28:35 -07:00
Robin Ward
1fb08d24d9
FIX: Latest onebox adds more attributes to links for security
2017-05-12 15:49:56 -04:00
Neil Lalonde
8b9799507c
fix deploy problems due to renamed table
2017-05-12 15:17:25 -04:00
Sam
2d96a0785d
FEATURE: theme selection is now global per-user
2017-05-12 12:41:34 -04:00
Sam
47ce674798
PERF: bypass wizard check after 15 topics are created
2017-05-12 10:18:43 -04:00
Guo Xiang Tan
b479aa0598
Set custom fields before saving in fabricator.
2017-05-12 14:01:31 +08:00
Guo Xiang Tan
41711e53b7
Fix typo.
2017-05-12 10:31:31 +08:00
Guo Xiang Tan
8eecd42856
FIX: Delete topic timer after completion.
2017-05-12 10:28:51 +08:00
Neil Lalonde
55b61e9bea
rename topic_status_update to topic_timer
2017-05-11 18:27:53 -04:00
Sam
52ae63d5d7
FIX: when searching PMs also search group PMs
...
Users belonging to a group could not search for PMs unless explicitly added
to the PM unless admin
2017-05-11 15:59:03 -04:00
Pat David
10f2db67ba
Add test for class_name in EmbedController
2017-05-11 15:16:16 -04:00
Sam
9b84cd832c
confirm in:private works for non staff
2017-05-11 15:06:45 -04:00
Neil Lalonde
1019bbda46
FEATURE: set a timer to delete a topic
2017-05-11 12:52:29 -04:00
Robin Ward
3ade46de0b
FIX: Don't send system message for new user of the month if disabled
2017-05-11 11:33:16 -04:00
Régis Hanol
9641d2413d
REFACTOR: upload workflow creation into UploadCreator
...
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
Sam
7d9b5514ba
FIX: correctly invalidate theme css cache on scheme change
2017-05-10 15:47:11 -04:00
Sam
04b5516bf2
improve upload functionality
2017-05-10 15:47:11 -04:00
Sam
27362c5a4b
improve spec
2017-05-10 15:47:11 -04:00
Sam
bc0b9af576
FEATURE: support uploads for themes
...
This allows themes to bundle various assets
2017-05-10 15:47:11 -04:00
Sam
f709899a1d
Allow theme field object model to support uploads
2017-05-10 15:46:42 -04:00
Robin Ward
4db76796b9
FEATURE: Setting to poll feeds more frequently
2017-05-10 14:30:12 -04:00
Robin Ward
b57b635d30
FIX: Extract div tags within spans
2017-05-09 12:33:54 -04:00
Sam Saffron
c2829dce22
FIX: base sql vanishes after badge creation
2017-05-09 09:25:57 -04:00
Guo Xiang Tan
55d3547540
Fix random test failure.
2017-05-09 11:27:05 +08:00
Robin Ward
fc00032ec8
Check for 404 from spec rather than failure
2017-05-08 16:33:43 -04:00
Robin Ward
addc85cd08
FIX: Don't let users edit wiki posts unless they can reply
2017-05-08 16:23:11 -04:00
Robin Ward
009e120e13
FIX: Don't raise an error when the img attribute cannot be found
2017-05-08 15:35:31 -04:00
Robin Ward
afe04b8bbb
FIX: Possible 500 error if category saved incorrectly
2017-05-08 15:17:58 -04:00
Robin Ward
4f6e5fed2a
We don't need to raise an error when no post is present. Just noop.
2017-05-08 15:08:29 -04:00
Robin Ward
96c59c5b82
FIX: Don't notify or return flags on system users
2017-05-08 13:13:35 -04:00
Sam
257c0dea70
Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list
...
Remove daily mailing mode option as it doesn't scale.
2017-05-08 09:10:46 -04:00
Arpit Jalan
e89d0a6b20
FIX: importing a theme via file was broken
2017-05-08 12:03:24 +05:30
Guo Xiang Tan
e61959e6a8
FIX: CustomEmoji may contain an invalid upload_id.
...
https://meta.discourse.org/t/white-screen-after-deleting-custom-emoji/61608
2017-05-05 14:53:38 +08:00
Guo Xiang Tan
2b21e5ea7e
UX: Display translated group name for automatic groups.
2017-05-05 14:34:47 +08:00
Guo Xiang Tan
71a266b673
Remove daily mailing mode option as it doesn't scale.
...
https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld
2017-05-05 12:21:50 +08:00
Guo Xiang Tan
441e0059af
Fix tests that was testing the wrong class.
2017-05-05 10:59:07 +08:00
Robin Ward
777f1f0f47
FIX: Return a 404 if the auth session is not present
2017-05-04 15:35:24 -04:00
Sam
4ebbad991e
FIX: properly clean up related color schemes on delete
2017-05-04 14:03:17 -04:00
Sam
7a15b44ac3
rename on_remove, on_drop
2017-05-04 14:03:17 -04:00
Sam
6a6eed4ed2
DEV: column dropper class for cleaner removal of superflous columns
...
Also fixes issues during deploy cause target column was renamed in
theme_fields
2017-05-04 10:15:41 -04:00
Guo Xiang Tan
4101db8b36
FIX: Invalid creation of Theme in wizard builder.
2017-05-04 11:44:23 +08:00
Régis Hanol
bf322281e3
Improve handling of inlined images in incoming emails
2017-05-03 23:02:02 +02:00
Régis Hanol
768c63c103
Add 'keep_cid_imgs' option to HTML to Markdown converter to improve incoming email parsing
2017-05-03 23:01:55 +02:00
Guo Xiang Tan
3eb920e2b0
Merge pull request #4841 from fantasticfears/webhook-ping
...
add event name for ping webhooks in the header
2017-05-04 04:54:40 +08:00
Neil Lalonde
389a0e1a1c
FIX: emails should use default theme colors
2017-05-03 14:35:13 -04:00
Régis Hanol
e38014772b
FIX: skip hidden <img> (no tracking for you)
2017-05-03 19:40:34 +02:00
Régis Hanol
c8044c6956
FIX: skip hidden nodes when converting from HTML to Markdown
2017-05-03 19:34:03 +02:00
Régis Hanol
bff36de130
FIX: HtmlToMarkdown should not convert empty/bad <img> tags
2017-05-03 18:29:25 +02:00
Régis Hanol
c880af8120
FIX: properly trim whitespaces (including those pesky html entities)
2017-05-03 18:04:31 +02:00
Sam
342ef5f81a
FEATURE: out-of-the-box dark/light user selectable themes
2017-05-03 11:31:33 -04:00
Robin Ward
81190f5d66
FIX: Redirect away from account-created if you're logged in
2017-05-03 11:18:01 -04:00
Robin Ward
12fb20fe1b
FEATURE: Allow users to resend/update email from confirmation page
2017-05-03 11:18:01 -04:00
Régis Hanol
edbf12622b
FIX: HtmlToMarkdown should not convert empty/bad <a> tags
2017-05-03 16:42:37 +02:00
Arpit Jalan
75300b6356
improve specs
2017-05-03 17:48:33 +05:30
Arpit Jalan
86f1cc8c92
FIX: don't apply max_emails_per_day_per_user on critical emails
2017-05-03 17:07:39 +05:30
Arpit Jalan
cdce060a38
FIX: don't apply max emails per day per user to forgot password
2017-05-03 14:02:37 +05:30
Sam
946f25098f
Refactor theme fields so they support custom theme defined vars
...
This paves the way to allowing themes to specify uploads and so on.
2017-05-02 16:02:14 -04:00
Arpit Jalan
77a8cae094
FIX: rescue specific errors on invite failure
2017-05-02 15:13:33 +05:30
Erick Guan
9f8a917d65
add event name for ping webhooks in the header
2017-05-02 08:13:23 +02:00
Sam
ba9339b8d7
FIX: missing image-url helper
2017-05-01 15:32:02 -04:00
Neil Lalonde
0722ffadf1
Remove site settings enforce_global_nicknames and discourse_org_access_key
2017-05-01 14:53:16 -04:00
Robin Ward
b99aedeccc
Merge pull request #4838 from vinothkannans/fix/read
...
FIX: 'read' filter in top menu showing new topics
2017-05-01 11:21:13 -04:00
Claus Strasburger
e9bb9a167b
Fix reply-by-mail for 8-bit transfer encodings
...
The mail class seems to handle mails sent with Content-Transfer-Encoding: 8bit
somewhat weirdly: It decodes them (to utf-8), changes the raw source to base64,
and does not modify the Content-Type:charset= header.
This leads to Discourse trying the message encoding (in my example ISO-8859-1)
first, and if that does not contain any unparseable characters, it uses that.
Sadly, in ISO-8859-1, every byte sequence is valid.
Fix this by always trying to decode as UTF-8 first. The probability of someone
using another encoding that cleanly (but wrongly) decodes as UTF-8 should be
fairly low.
2017-04-30 23:30:40 +02:00
Vinoth Kannan
1241660c2c
FIX: 'read' filter in top menu showing new topics
2017-04-29 14:37:45 +05:30
Régis Hanol
aba76bace6
add support to keep img tags when converting to html
2017-04-28 22:14:46 +02:00
Régis Hanol
51ee49aad2
FIX: properly support HTML document when converting to markdown
2017-04-28 22:02:20 +02:00
Robin Ward
f05f1a24d3
Change Anniversary badge to be multiple grant, once per year
2017-04-28 14:22:54 -04:00
Régis Hanol
0ec15af970
restore the 'incoming_email_prefer_html' site setting
2017-04-27 14:31:11 +02:00
Guo Xiang Tan
304ace926e
FIX: Raise right response when post_action does not exist.
2017-04-27 17:29:53 +08:00
Guo Xiang Tan
7873a2efb7
Merge pull request #4843 from tgxworld/disable_post_min_length_for_pm
...
FEATURE: Disable minimum post length check when in PM with non human …
2017-04-27 16:35:19 +08:00
Guo Xiang Tan
59b906ab0d
FEATURE: Disable minimum post length check when in PM with non human users.
...
https://meta.discourse.org/t/discourse-narrative-bot-beta-feedback/58621/65?u=tgxworld
2017-04-27 16:00:22 +08:00
Guo Xiang Tan
85d9342ff0
Merge pull request #4836 from tgxworld/fix_clean_up_staged_users_job
...
FIX: Clean up unused staged users job not completing.
2017-04-27 15:41:46 +08:00
Arpit Jalan
9b0ecdaf7e
Merge pull request #4839 from techAPJ/bulk-add-group
...
FEATURE: provide more details when performing a bulk add to group
2017-04-27 02:39:57 +05:30
Arpit Jalan
285c167fae
FEATURE: provide more details when performing a bulk add to group
2017-04-27 01:37:51 +05:30
Robin Ward
bf9c4a7828
FEATURE: secure_email site setting to prevent data going out in email
2017-04-26 13:05:56 -04:00
Régis Hanol
b76674f640
FEATURE: convert incoming emails in HTML to markdown
...
- remove incoming_email_prefer_html site setting
- remove HtmlCleaner class
2017-04-26 16:49:06 +02:00
Guo Xiang Tan
daa97c40ce
FIX: Clean up unused staged users job not completing.
2017-04-26 10:51:36 +08:00
Arpit Jalan
aeead60036
FIX: make TopicEmbed trashable
2017-04-25 18:40:39 +05:30
Guo Xiang Tan
aef89c4850
REFACTOR: Load Post records in batches when destroying stubs.
2017-04-25 10:19:21 +08:00
Guo Xiang Tan
6f7c6b0fd0
FIX: Incorrect error raised.
2017-04-25 09:59:01 +08:00
Régis Hanol
d5630d6160
HtmlToMarkdown library
...
Small library to transform HTML to Discourse-flavored markdown (mostly used for imports)
2017-04-24 22:01:41 +02:00
Guo Xiang Tan
423f2ab228
FIX: Processing incoming email should be done in a background job.
2017-04-24 13:57:28 +08:00
Arpit Jalan
dad2024094
FIX: do not impose default min/max validation on hidden site setting
2017-04-22 12:08:39 +05:30
Sam
b077335a30
make stat socket much more robust
2017-04-21 17:12:29 -04:00
Arpit Jalan
b0151ab66a
Merge pull request #4826 from techAPJ/site-setting-max-value
...
FIX: all basic integer settings should have min & max value validation
2017-04-21 20:21:10 +05:30
Sam
52306c393a
FEATURE: basic implementation of stats socket
2017-04-21 10:24:43 -04:00
cpradio
20c2c66dd4
FEATURE: Add normal as a preference for topic subscription state when replying to a topic
2017-04-20 22:33:10 -04:00
Guo Xiang Tan
8b2e3bf5f1
FIX: Topic title should be included in post webhook payload.
2017-04-21 10:04:21 +08:00
Arpit Jalan
9eff4f0807
FIX: all basic integer settings should have max value validation
2017-04-21 07:09:41 +05:30
Sam
aec73d4003
correct the spec again
2017-04-20 17:41:35 -04:00
Sam
47b99e0922
group is now default watched
2017-04-20 17:38:46 -04:00
Sam
d4111c8676
correct spec
2017-04-20 17:24:21 -04:00
Sam
5365973c0a
FIX: detection of error changed, so you can clear errors
2017-04-20 16:55:18 -04:00
Sam
7a9eee1b71
FEATURE: default notification level for group messages
...
also fixes it so staff can amend other user's group notification level
2017-04-20 15:47:35 -04:00
Sam
e119c6e01e
FIX: embedded comments not working when theme is missing
2017-04-20 10:31:33 -04:00
Arpit Jalan
ea26c56631
FIX: redirect to login page for anonymous user when profiles are hidden
2017-04-20 13:00:45 +05:30
Sam
7eabb90b71
FEATURE: added error messages for bad theme CSS / JS
2017-04-19 16:46:46 -04:00
Neil Lalonde
3835e16cf7
FIX: New implementation of the "notify about flag after" setting. Only notify about new flags since the last notification. Send a private message to staff. Mention the 3 most active moderators in the message so they get notification emails.
2017-04-19 16:17:45 -04:00
cpradio
2dccaff25d
FIX: Correct behavior of auto-notification state updating to exclude when the topic already has a state of normal/muted
2017-04-19 06:29:35 -04:00
Sam
2bc3aa7ed4
remove no digest refs
...
the digestless special dev behavior is no longer needed
2017-04-18 17:05:33 -04:00
Arpit Jalan
f968b4e662
Fix the build
2017-04-18 16:34:58 +05:30
Arpit Jalan
1c23aedccf
FIX: always send password reset email when accepting invite if password is not set
2017-04-18 14:37:06 +05:30
Arpit Jalan
8dea70d354
Revert "FIX: User website allows new TLDs"
2017-04-18 13:18:51 +05:30
Rafael dos Santos Silva
4289dbe3e5
FIX: User website allows new TLDs
2017-04-18 00:30:37 -03:00
Robin Ward
1363988cd7
Support for an HTML builder that can create dynamic HTML
2017-04-17 17:32:55 -04:00
Sam
5e3a0846f7
FEATURE: allow themes to share color schemes
2017-04-17 15:56:24 -04:00
Arpit Jalan
7389831961
Fix the build
2017-04-15 15:52:35 +05:30
Arpit Jalan
0954367bf4
FIX: send activation email when accepting invite if password is set
2017-04-15 14:59:50 +05:30
Guo Xiang Tan
04016f0dec
Support Ruby 2.4.
2017-04-15 12:29:00 +08:00
Jeff Atwood
d12ba0548c
Merge pull request #4812 from cpradio/spec-auto-notification-update
...
Add spec for auto notification update
2017-04-14 16:01:38 -07:00
cpradio
e3ad50de05
Add spec for auto notification update
...
It should update the topic subscription so long as what is being requested is higher than what is currently set for the user and the given topic
It should not update the topic subscription if the requested subscription is less than what is currently set for the user and given topic
2017-04-14 18:30:01 -04:00
Sam
4b6c49b13f
correct specs
2017-04-14 15:25:34 -04:00
Sam
def7348777
FIX: display custom sections with default theme
...
also cleans up mechanism for previewing themes, cleans up naming,
gets rid of old janky "preview_style", secures local theme key
2017-04-14 13:35:12 -04:00
Sam
809fbb25ce
FIX: blanking theme field was not properly removing it
2017-04-13 17:24:15 -04:00
Guo Xiang Tan
3d76fb9c2c
FIX: Don't show category options for reports that can't be scoped to a category.
2017-04-13 17:10:55 +08:00
Guo Xiang Tan
bda20cc44a
FIX: Don't enqueue topic status update job if topic is deleted.
2017-04-13 12:02:35 +08:00
Guo Xiang Tan
57788200ec
REFACTOR: Add User.reserved_username?.
2017-04-13 10:44:26 +08:00
Sam
a7ed8a0310
correct theme importer to support embedded.scss
2017-04-12 11:30:16 -04:00
Sam
95d095c97d
test should be configuring git info
2017-04-12 11:19:47 -04:00
Sam
a3e8c3cd7b
FEATURE: Native theme support
...
This feature introduces the concept of themes. Themes are an evolution
of site customizations.
Themes introduce two very big conceptual changes:
- A theme may include other "child themes", children can include grand
children and so on.
- A theme may specify a color scheme
The change does away with the idea of "enabled" color schemes.
It also adds a bunch of big niceties like
- You can source a theme from a git repo
- History for themes is much improved
- You can only have a single enabled theme. Themes can be selected by
users, if you opt for it.
On a technical level this change comes with a whole bunch of goodies
- All CSS is now compiled using a custom pipeline that uses libsass
see /lib/stylesheet
- There is a single pipeline for css compilation (in the past we used
one for customizations and another one for the rest of the app
- The stylesheet pipeline is now divorced of sprockets, there is no
reliance on sprockets for CSS bundling
- CSS is generated with source maps everywhere (including themes) this
makes debugging much easier
- Our "live reloader" is smarter and avoid a flash of unstyled content
we run a file watcher in "puma" in dev so you no longer need to run
rake autospec to watch for CSS changes
2017-04-12 10:53:49 -04:00
Dean Taylor
1a9afa976d
FEATURE: Add AWS S3 EU (London) "eu-west-2" region
2017-04-12 10:38:17 -04:00
Guo Xiang Tan
24d3c77d19
Fix the build.
2017-04-12 10:38:17 -04:00
Guo Xiang Tan
7cb389a235
Add DiscourseEvent trigger when user's topic notification level changes.
2017-04-12 11:56:50 +08:00
Arpit Jalan
8fb41bf5fb
FIX: update timestamp when resending invite
2017-04-11 20:02:32 +05:30
Guo Xiang Tan
5a57278a8e
Fix build.
2017-04-11 21:37:57 +08:00
Guo Xiang Tan
73180c8a19
FIX: Private message can be set to publish in the future.
2017-04-11 20:44:25 +08:00
Guo Xiang Tan
3861bd2793
FIX: Quotes should be ignored when parsing for onebox source.
2017-04-11 15:22:21 +08:00
Guo Xiang Tan
0a4c30bce3
FIX: Handle cases where alt and title tag is blank when parsing excerpt.
2017-04-11 14:18:27 +08:00
Guo Xiang Tan
c076f7b1aa
Fix broken specs.
2017-04-11 10:43:34 +08:00
Guo Xiang Tan
aadf4805a5
FIX: Topic status update not being deleted once it has been executed.
2017-04-11 10:32:13 +08:00
Guo Xiang Tan
e49f3a408e
FEATURE: Add option for ExcerptParser to keep onebox source.
2017-04-10 16:11:58 +08:00
Robin Ward
e2ff06ce02
FIX: rounding error in spec
2017-04-07 17:44:02 -04:00
Robin Ward
40cee37bcc
FIX: Don't insert topic status messages unless the status changes
2017-04-07 17:10:43 -04:00
Guo Xiang Tan
9663a74445
FIX: Ensure username param is valid in NotificationsController.
2017-04-07 17:32:52 +08:00
Guo Xiang Tan
71501feaf3
Improve validation for TopicStatusUpdate.
2017-04-07 15:32:00 +08:00
Guo Xiang Tan
690d2f4bd3
UX: Publish topic changes when topic is published.
2017-04-07 15:32:00 +08:00
Guo Xiang Tan
48a9860f07
FIX: Publish topic to a category should unlist it as well.
2017-04-07 13:58:52 +08:00
David Rodríguez
934bff43d9
FIX: Copy post actions when moving a topic.
2017-04-06 12:16:22 +08:00
Robin Ward
40ab2e5667
FEATURE: Let users update their emails before confirming
...
This allows users who entered a typo or invalid email address when
signing up an opportunity to fix it and resending the confirmation
email to that address.
2017-04-05 16:44:49 -04:00
Sam Saffron
48d9c69117
remove confusing comment
2017-04-05 08:46:35 -04:00
Sam Saffron
cd39049262
SECURITY: do not send push notifications to suspended users
2017-04-05 08:28:24 -04:00
Robin Ward
17f2974d0a
SECURITY: Confirm new administrator accounts via email
2017-04-04 15:59:01 -04:00
Robin Ward
a649014adf
Add spec for validation on group mention updater
2017-04-04 11:22:39 -04:00
Guo Xiang Tan
ad44d2a400
Merge pull request #4790 from tgxworld/add_publish_to_topic_status_update
...
FEATURE: Allow admins to schedule a topic to be published in the future.
2017-04-04 11:18:53 +08:00
Guo Xiang Tan
f4758a4c4d
FEATURE: Allow admins to schedule a topic to be published in the future.
2017-04-04 11:16:05 +08:00
Robin Ward
ebe232da47
Weigh staff votes more for New User of the Month badges
2017-04-03 16:52:31 -04:00
Robin Ward
a13a8dc96c
FIX: Safeguard to not award NewUserOfTheMonth if it hasn't been a month
2017-04-03 13:26:51 -04:00
Arpit Jalan
5ff29ce321
add test case for topic status update based on last post
2017-04-03 22:35:56 +05:30
Robin Ward
3d64f33d40
Require at least two likes to get the "New User of the Month" badge
2017-04-03 13:03:28 -04:00
Robin Ward
b189486fc0
We can do a lot less work in the test since we eased the criteria
2017-04-03 12:15:24 -04:00
Guo Xiang Tan
dc5a6e7cda
Remove empty test.
2017-04-03 21:12:20 +08:00
Guo Xiang Tan
5cf75c67df
FIX: Callback undefined error when topic has been deleted.
2017-04-03 09:06:15 +08:00
Robin Ward
e4b1376146
Change New User of the Month Badge to use trust level rather than age
2017-03-31 16:56:58 -04:00
Robin Ward
a8d3779f0b
Update New User of the Month badge to require 4 posts in 2 topics
2017-03-31 16:52:00 -04:00
Robin Ward
fc7fa4c0ad
Rename "Rookie of the Month" to "New User of the Month"
2017-03-31 16:30:30 -04:00
Robin Ward
893e93dfbe
New badge, Rookie of the Month, for two new high quality users.
2017-03-31 15:06:31 -04:00
Guo Xiang Tan
0bbad5040a
topic-status-info component wasn't updated when topic is closed/opened.
2017-03-31 15:58:26 +08:00
Guo Xiang Tan
b6e9871b4b
Update Topic#closed client side when closing/opening a topic temporarily.
2017-03-31 15:05:00 +08:00
Guo Xiang Tan
ed577fbff8
FEATURE: Pause a topic instead of permanently closing when flag threshold is reached.
2017-03-31 14:35:05 +08:00
Guo Xiang Tan
34b7bee568
FEATURE: Allow admin to auto reopen at topic.
...
* This commit also introduces a `TopicStatusUpdate`
model to support other forms of deferred topic
status update in the future.
2017-03-31 11:14:18 +08:00
Robin Ward
7b6242bfbb
Minor cleanup of /users/ rename
2017-03-30 10:23:24 -04:00
Robin Ward
14410b71fb
Convert server side paths to use /u/
2017-03-30 10:23:24 -04:00
Robin Ward
45a257815a
Convert front end paths from /users/ to /u/
2017-03-30 10:23:24 -04:00
Robin Ward
6b976433c9
Support for both /users/ and /u/ paths
2017-03-30 10:23:24 -04:00
Yana Agun Siswanto
cd2d2f16e5
Allow to order search results by the topic creation date
...
based on: https://meta.discourse.org/t/allow-to-order-search-results-by-the-topic-creation-date/38544
2017-03-30 01:18:38 +07:00
Guo Xiang Tan
7cf0f39066
Require Sidekiq::Testing in rails helper.
2017-03-29 11:10:25 +08:00
Arpit Jalan
4812417192
FIX: do not add user to group based on email domain unless email is confirmed
2017-03-28 15:02:40 +05:30
Arpit Jalan
8bf12502bd
Merge pull request #4780 from techAPJ/send-statistics
...
FEATURE: Send anonymized usage statistics to Discourse if "Discourse Hub" can't reach the site
2017-03-28 10:02:05 +05:30
Arpit Jalan
f3cd5f61c5
FEATURE: Send anonymized usage statistics to Discourse if Discourse Hub can't reach the site
2017-03-28 09:07:23 +05:30
Régis Hanol
dd1cc23caf
fix randomly failing specs
2017-03-27 22:47:41 +02:00
Arpit Jalan
3378e2d49f
FIX: update topic fancy title when updating category name
2017-03-26 12:29:53 +05:30
Régis Hanol
dfe1d3adfd
Merge pull request #4778 from techAPJ/admin-message-format
...
FIX: admin locales were not getting converted to message format
2017-03-25 11:59:56 +01:00
Guo Xiang Tan
7c17966171
FEATURE: Include email in User webhook.
...
https://meta.discourse.org/t/should-the-email-address-of-a-new-user-be-included-in-the-webhook/59255
2017-03-25 08:23:01 +08:00
Arpit Jalan
3449339fea
FIX: admin locales were not getting converted to message format
2017-03-25 01:12:23 +05:30
Guo Xiang Tan
b87c5eb1b6
Fix randomly failing spec.
2017-03-24 15:46:42 +08:00
Guo Xiang Tan
3ef82bb32c
SECURITY: CSRF vulnerabilities in Admin::BackupsController.
2017-03-23 10:29:35 +08:00
Neil Lalonde
11ce73b8ed
FEATURE: category setting for default top period
2017-03-22 16:54:18 -04:00
Arpit Jalan
786fd6bbd2
Merge pull request #4774 from techAPJ/email-prefix
...
FIX: use email prefix only in subject
2017-03-22 14:18:50 +05:30
Arpit Jalan
295cf8839e
FIX: better error message when invited user already exists
2017-03-22 13:55:28 +05:30
Arpit Jalan
1853a4852c
FIX: use email prefix only in subject
2017-03-21 20:29:57 +05:30
Arpit Jalan
df246c79b6
FEATURE: add user profile fields in user list export
2017-03-21 15:51:52 +05:30
Arpit Jalan
82c0f5f587
Merge pull request #4767 from techAPJ/activate-account
...
FIX: send activation email if user have unconfirmed email address
2017-03-21 09:44:23 +05:30
Arpit Jalan
7c3ae50dcd
FIX: send activation email if user have unconfirmed email
2017-03-21 09:41:50 +05:30
Sam
74dbe877d8
test for side effect without mock
2017-03-20 16:15:23 -04:00
Sam
c106ca6778
FEATURE: fallback asset path for multi host setups
2017-03-20 15:59:17 -04:00
Arpit Jalan
8cbfa24ca2
Fix failing test
2017-03-20 20:14:25 +05:30
Arpit Jalan
521c88fe58
FIX: enqueue activation email for invited user that has password set
2017-03-20 17:13:21 +05:30
Guo Xiang Tan
a1d04a7a9a
Fix rspec tests.
2017-03-20 12:35:08 +08:00
Guo Xiang Tan
6057e17ae7
Fix weird test failure.
2017-03-20 12:06:37 +08:00
Robin Ward
fd591257a8
Merge pull request #4759 from kennym/support-ports-for-ip-addresses-in-embedding
...
FIX: Allow ports for embed host IPs
2017-03-16 11:23:42 -04:00
Guo Xiang Tan
5169ef8814
Fix broken specs.
2017-03-16 15:05:28 +08:00
Guo Xiang Tan
bf78c228f4
FIX: User created web hook being enqueued before record has been saved.
...
* Improve web hook tests as well.
2017-03-16 14:44:09 +08:00
Erick Guan
cfbfea0596
FEATURE: Allow easier customization to the web hook event serialization.
2017-03-16 10:09:05 +08:00
Guo Xiang Tan
bbc85e1e29
Merge pull request #4750 from discourse/group_login_registration_flow
...
FEATURE: Redirect to groups page and apply group actions upon login/s…
2017-03-16 09:50:56 +08:00
Guo Xiang Tan
ca965bb455
FEATURE: Redirect to groups page after login/registration flow.
2017-03-16 09:48:51 +08:00
Kenny Meyer
ae957bca25
Allow ports for embed host IPs
2017-03-15 18:16:34 -03:00
Guo Xiang Tan
685c26961f
Fix randomly failing specs.
2017-03-14 16:28:05 +08:00
Guo Xiang Tan
6312b8b7e4
Fix failing specs.
2017-03-14 14:58:22 +08:00
Guo Xiang Tan
d173473509
Fix randomly failing specs.
2017-03-14 14:43:48 +08:00
Guo Xiang Tan
1a7e954e09
FIX: Store custom emojis as uploads.
...
* Depending on a hardcoded directory was a flawed design
which made it impossible to debug when custom emojis go
missing.
2017-03-14 13:07:18 +08:00
Sam
64680286f4
correct logic, so revalidation is reset
...
correct test so it can run at any point
2017-03-13 10:47:43 -04:00
Sam
a690121805
SECURITY: always allow staff to resend activation mails
2017-03-13 10:32:24 -04:00
Sam
ef24fd54ba
FEATUE: automatically validate token is stored in redis
...
This ensures we have some handling for redis flushall
We attempt to recover our in-memory session token once every 30 seconds
Code is careful to only set the token if it is nil, to allow for manual
cycling to remain safe if needed
2017-03-13 10:19:02 -04:00
Sam
82ca0e368e
FEATURE: stop escaping special chars in title prettify
...
This feature is confusting and just leads to inconsistency
2017-03-13 10:02:20 -04:00
Guo Xiang Tan
9364d8ce71
FIX: Store user's id instead for sending activation email.
...
* Email and username are both allowed to be used for logging in.
Therefore, it is easier to just store the user's id rather than
to store the username and email in the session.
2017-03-13 20:24:55 +08:00
Guo Xiang Tan
7ebfa3c901
SECURITY: Only allow users to resend activation email with a valid session.
...
* Improve error when an active user tries to request for an activation email.
2017-03-13 19:35:29 +08:00
Arpit Jalan
848120c098
FEATURE: RSS feed for top page period filters
2017-03-13 15:23:46 +05:30
Guo Xiang Tan
4d4a1a1552
Add scope for human users.
2017-03-11 14:25:09 +08:00
Sam
6ebddc42d1
FIX: include children categories when searching a category
2017-03-10 15:58:47 -05:00
Neil Lalonde
402ddb810c
FIX: email customizations now apply to both html and text parts
2017-03-10 14:08:03 -05:00
Sam
bc1a6ccb90
Merge pull request #4741 from tgxworld/allow_bookmark_removal
...
FIX: Allow user to remove bookmark from posts as long as bookmark is …
2017-03-10 12:49:20 -05:00
Arpit Jalan
f7e7ca3937
FEATURE: anonymized site statistics
2017-03-10 18:50:26 +05:30
Guo Xiang Tan
9cc79363e0
Merge pull request #4744 from tgxworld/feature_seen_unseen_search
...
FEATURE: Search can be scoped to posts that the current user has seen…
2017-03-09 07:11:19 +08:00
Régis Hanol
23b06d2895
FIX: should not try to send digest to users who reached the bounce threshold
2017-03-08 19:19:11 +01:00
Guo Xiang Tan
c623951306
FEATURE: Search can be scoped to posts that the current user has seen/unseen.
...
https://meta.discourse.org/t/advanced-search-posts-that-i-have-seen/57966
2017-03-09 01:01:33 +08:00
Arpit Jalan
801b5838e1
FIX: do not show faq/guidelines page to anonymous users for private forums
2017-03-08 16:00:49 +05:30
Régis Hanol
cf8bc4483f
FIX: always send critical emails even when bounce score threshold has been reached
2017-03-08 10:06:16 +01:00
Arpit Jalan
090236b15b
FIX: do not show about page to anonymous users for private forums
2017-03-08 13:15:44 +05:30
Guo Xiang Tan
689dd16be0
FIX: Allow user to remove bookmark from posts as long as bookmark is present.
...
https://meta.discourse.org/t/bookmark-issue-when-access-to-topic-is-lost-pms/51993
2017-03-08 13:53:49 +08:00
Régis Hanol
ee9d621d9c
FIX: surround the FROM alias with " in order to support the @ character
2017-03-07 23:37:21 +01:00
Sam
99f4d5082b
FIX: Improve token rotation and increase logging
...
- avoid access denied on bad cookie, instead just nuke it
- avoid marking a token unseen for first minute post rotation
- log path in user auth token logs
2017-03-07 13:27:43 -05:00
Neil Lalonde
0661cebbcf
fix intermittent failing spec
2017-03-07 11:59:05 -05:00
Neil Lalonde
d95e4102c1
FIX: tags created in secured categories should not be forbidden outside those categories
2017-03-07 11:46:46 -05:00
Robin Ward
dad57fa033
FIX: More errors with non-ascii URLs
2017-03-07 11:21:41 -05:00
Guo Xiang Tan
d1e587c10a
Merge pull request #4737 from oblakeerickson/approve_invited_user
...
FIX: approve invited user
2017-03-07 21:14:34 +08:00
Régis Hanol
0abe433495
Merge pull request #4736 from techAPJ/group-bulk-add
...
FIX: grant trust level when bulk adding users to group
2017-03-06 12:43:26 +01:00
Guo Xiang Tan
7d82a53dfe
FIX: Group#name is case insensitive.
2017-03-06 17:24:03 +08:00
Arpit Jalan
d5bcc70e9c
FIX: grant trust level when bulk adding users to group
2017-03-06 14:39:53 +05:30
Guo Xiang Tan
66b5f97743
Merge pull request #4739 from tgxworld/fix_cant_recover_a_topic_that_belongs_to_a_deleted_user
...
Fix cant recover a topic that belongs to a deleted user
2017-03-06 15:12:54 +08:00
Guo Xiang Tan
8aea3caf00
FIX: Ensure that we only move posts that belong to the original topic.
2017-03-06 15:04:10 +08:00
Guo Xiang Tan
477eb0591e
FIX: Posts in a deleted topic couldn't be moved.
...
https://meta.discourse.org/t/moving-posts-to-new-topic/58436/4
2017-03-06 14:56:20 +08:00
Guo Xiang Tan
a28704bcee
FIX: Can't recover a post when its user has been deleted.
...
https://meta.discourse.org/t/moving-posts-to-new-topic/58436
2017-03-06 14:29:06 +08:00
Blake Erickson
dbb3ddc7a6
FIX: approve invited user
...
This commit fixes the case where invited users who typed in a password
would not be approved by default. Because we moved the user create logic
for an invited user there was a clash with the `save` in the user model
and the `save` in the invite_redeemer class.
- added approve logic into invite_redeemer class.
- added tests to verify that the user is approved
- added a check to see if must_approve_users is on
- added a check to see if the inviter is staff
- go ahead and approve the user if must_approve_users is off
- keep existing User.approve workflow if user exists
- improve if/else logic to remove duplicate code
- use `Time.zone.now`
2017-03-05 06:58:23 -07:00
Sam
c99f4260c0
Merge pull request #4729 from tgxworld/dont_mark_user_as_valid
...
FIX: Don't mark user as `active` if verified email is different.
2017-03-03 15:57:30 -05:00
Neil Lalonde
6aab8cb331
FEATURE: new category setting for whether to show latest topics or top topics by default
2017-03-03 11:30:44 -05:00
Guo Xiang Tan
bcf634ca85
Merge pull request #4728 from nbianca/username-regex
...
Add support for username regex.
2017-03-03 22:59:23 +08:00
Bianca Nenciu
30909ec54e
Add support for username regex.
2017-03-02 13:53:45 +02:00
Guo Xiang Tan
3d347fb9c4
FIX: Don't mark user as active if verified email is different.
2017-03-02 14:24:30 +08:00
Neil Lalonde
51d7dc4355
switch contents of embeddable_host_fabricator.rb and category_fabricator.rb
2017-03-01 15:13:31 -05:00
Neil Lalonde
262016604d
FEATURE: each category can control how many topics to show on categories page
2017-03-01 15:12:57 -05:00
Blake Erickson
80858bae2c
FEATURE: further restrict downloading of backups
...
- send email to logged in admin when they press the "download" button
- show pop-up that email was sent
- create email template
- require a valid token to download backup
2017-03-01 08:28:34 -07:00
Arpit Jalan
e27b1b98d1
FIX: handle new user when logging name change
2017-03-01 13:43:57 +05:30
Guo Xiang Tan
107d6783a9
Remove use of stubs in tests.
2017-03-01 10:53:03 +08:00
Guo Xiang Tan
76dd6933d2
Revert "Revert "Revert "SECURITY: Ensure oAuth authenticated email is the same as created user's email."""
...
This reverts commit e6d75f6844
2017-03-01 10:16:59 +08:00
Robin Ward
d27575176a
Enforce a minimum amount of posters in a topic for get_a_room
2017-02-28 16:47:16 -05:00
Sam
122fb8025d
FIX: last seen date erroneously updated when browser in background
...
In some cases user may be "last seen" even though browser tab is in
the background or computer is locked
2017-02-28 12:35:10 -05:00
Neil Lalonde
292dd8623c
Merge pull request #4622 from dmacjam/master
...
FEATURE: Append tags bulk action for topics
2017-02-28 11:36:58 -05:00
Sam
3ac4709903
FIX: on initial token issue stop unmarking token as unseen
...
prev and current are the same so we need special logic to bypass
2017-02-28 10:38:22 -05:00
Guo Xiang Tan
e6d75f6844
Revert "Revert "SECURITY: Ensure oAuth authenticated email is the same as created user's email.""
...
This reverts commit 0e3def7d2b
2017-02-28 11:27:14 +08:00
Sam
1e980ad4e6
Merge pull request #4721 from oblakeerickson/sort_admin_users_api
...
FEATURE: Add order logic to admin users controller
2017-02-27 16:13:42 -05:00
Arpit Jalan
6661cebff8
FIX: do not log duplicate username changes
2017-02-28 01:32:00 +05:30
Neil Lalonde
e634b37f9a
FIX: from field of emails should be including email_site_title or site title settings
2017-02-27 14:23:07 -05:00
Arpit Jalan
b32d3d66e5
FEATURE: log all username and name changes
2017-02-28 00:23:27 +05:30
Robin Ward
0e3def7d2b
Revert "SECURITY: Ensure oAuth authenticated email is the same as created user's email."
...
This reverts commit 1060239e2d
2017-02-27 13:19:26 -05:00
Robin Ward
bf9626d031
FIX: Embedding was broken with non-english URLs and ports
2017-02-27 12:17:52 -05:00
Arpit Jalan
877957ae88
Merge pull request #4715 from techAPJ/login-per-ip
...
FEATURE: new site setting for max logins per ip per hour/minute
2017-02-27 18:24:53 +05:30
Arpit Jalan
cba51e1c38
FEATURE: new site setting for max logins per ip per hour/minute
2017-02-27 16:58:03 +05:30
jomaxro
f5673fbd47
Remove references to elder
...
The use of the TL4 name Elder was changed in 2014 to Leader. The spec function was changed to `:trust_level_4`, but the it statement was not changed.
2017-02-26 17:40:42 -07:00
Sam Saffron
7e8f0dc967
FIX: attempt to handle ios edge case where token is seen but unsaved
...
This relaxes our security in the following way
- prev auth token is always accepted as long as rotation
date is within our window of SiteSetting.maximum_session_age.hours
(previously old token expired within a minute of new one being seen)
- new auth token is marked unseen if we are presented with an old token
after we already saw new one
This attempts to fix an issue where ios webkit is not committing new cookies
2017-02-26 17:09:57 -05:00
Blake Erickson
0e6cb752da
Clean up valid order names
...
Add a sortable mappings list to match other endpoints and so that you
don't have to use database column names.
Example: 'created' => 'created_at'
Also cleaned up some of the logic since a lot of it got moved into the
SORTABLE_MAPPING hash.
2017-02-25 11:51:40 -07:00
Blake Erickson
e9d5c3265c
Change param asc to ascending
...
For consistency, change param asc to ascending:
https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649/17?u=oblakeerickson
2017-02-25 09:13:31 -07:00
Blake Erickson
0a41da6bad
FEATURE: Add order logic to admin users controller
...
Added order and direction parameters for sorting admin user pages. This
commit only includes backend api changes.
https://meta.discourse.org/t/make-admin-users-list-sortable-suggestion/47649
Now you can pass in `order` and `asc` parameters to the
`/admin/users/list/<query>.json` endpoint.
Example:
`/admin/users/list/active.json?&order=post_count` which defaults to desc
and
`/admin/users/list/active.json?order=post_count&asc=true`
2017-02-24 17:11:17 -07:00
Régis Hanol
ecdae9f863
FIX: i18n integrity specs
...
FIX: check all .yml files in the project for integrity
FIX: ensure localized yamls are compatible with english
2017-02-24 11:35:33 +01:00
Régis Hanol
a2c04be718
FIX: eradicate I18n fallback issues 💣
...
FIX: client's translation overrides were not working when the current locale was missing a key
FIX: ExtraLocalesController.show was not properly handling multiple translations
FIX: JsLocaleHelper#output_locale was not properly handling multiple translations
FIX: ExtraLocalesController.show's spec which was randomly failing
FIX: JsLocaleHelper#output_locale was muting cached translations hashes
REFACTOR: move 'enableVerboseLocalization' to the 'localization' initializer
REFACTOR: remove unused I18n.js methods (getFallbacks, localize, parseDate, toTime, strftime, toCurrency, toPercentage)
REFACTOR: remove all I18n.pluralizationRules and instead use MessageFormat's pluralization rules
TEST: add tests for localization initializer
TEST: add tests for I18n.js
2017-02-24 11:31:21 +01:00
Guo Xiang Tan
1060239e2d
SECURITY: Ensure oAuth authenticated email is the same as created user's email.
2017-02-24 13:13:10 +08:00
Guo Xiang Tan
0847b4258a
Revert "SECURITY: Ensure that user has been authenticated."
...
This reverts commit fbe51d68a7
2017-02-24 13:12:29 +08:00
Guo Xiang Tan
fbe51d68a7
SECURITY: Ensure that user has been authenticated.
2017-02-24 10:47:48 +08:00
Sam
f15f61da0a
FEATURE: add immutable caching to rails site of things
2017-02-23 13:05:00 -05:00
Sam
ea1007e954
FEATURE: add support for same site cookies
...
Defaults to Lax, can be disabled or set to Strict.
Strict will only work if you require login and use SSO. Otherwise when clicking on links to your site you will appear logged out till you refresh the page.
2017-02-23 12:01:28 -05:00
Neil Lalonde
0551b3f5ee
FEATURE: replace emoji with unicode in title and description meta tags
2017-02-22 16:24:13 -05:00
Sam Saffron
b7d2edc7dc
FIX: allow some auth token misses prior to clearing cookie
...
It appears that in some cases ios queues up requests up front
and "releases" them when tab gets focus, this allows for a certain
number of cookie misses for this case. Otherwise you get logged off.
2017-02-22 12:37:11 -05:00
Arpit Jalan
213a496203
FIX: show all staff events related to the target user
2017-02-22 13:31:40 +05:30
Arpit Jalan
b32f33b3f0
FIX: allow staff members to send PMs when enable_private_messages is disabled
2017-02-22 11:32:09 +05:30
Neil Lalonde
c94fdcea38
FIX: admin dashboard posts count should not include system posts and whispers
2017-02-21 14:45:41 -05:00
Arpit Jalan
046cbad10b
FEATURE: add a button on admin user page that links to action log
2017-02-21 21:38:37 +05:30
Jakub Macina
4a2f13348a
ADD: Append tags bulk action for topics
2017-02-20 18:14:32 +01:00
Régis Hanol
f51e3b2131
FIX: should not be able to rename a system badge
2017-02-20 14:35:05 +01:00
Régis Hanol
cb99f59ec3
reset bounce score when email is successfully changed
2017-02-20 10:37:01 +01:00
Robin Ward
e62c0a42fa
FIX: Support multiple embeddable host records with the same host
2017-02-17 12:41:34 -05:00
Sam
7a85469c4c
SECURITY: inactive/suspended accounts should be banned from api
...
Also fixes edge cases around users presenting multiple credentials
2017-02-17 11:03:09 -05:00
Neil Lalonde
c0e1722ca6
fix intermittent spec failure due to Time comparison with TimeWithZone
2017-02-17 10:30:29 -05:00
Neil Lalonde
3fb50d587d
FIX: invited users and new TL1 users will see their first notification highlighted
2017-02-17 10:30:29 -05:00
Jeff Atwood
9b263a0559
increase req min unique pw chars from 5 to 6
2017-02-16 17:06:19 -08:00
Neil Lalonde
4b28bfaa15
Merge pull request #4710 from ento/fix-s3-config-check
...
FIX: admin dashboard shouldn't complain when using IAM profile for S3 access
2017-02-15 17:02:07 -05:00
Neil Lalonde
d0fbb27f3e
FEATURE: new invite acceptance page, where username can be chosen and password can be set
2017-02-15 16:51:57 -05:00
Sam
74d4209d24
FEATURE: allow plugins to register custom topic list filters
2017-02-15 15:25:43 -05:00
Sam
9c51e3e8e7
amend preloader api to supply topic list
2017-02-15 12:04:02 -05:00
Sam
2c59ffeb2c
FIX: token rotation not accounting for overlapping tokens correctly
...
also... freeze_time has no block form, correct all usages and specs
2017-02-15 10:58:18 -05:00
Marica Odagaki
af9c97ec43
Add failing tests
2017-02-15 00:05:58 -08:00
Marica Odagaki
2c1279b740
Fix typo to be more consistent with other test descriptions
2017-02-15 00:04:10 -08:00
Sam
f2099c3811
adjust API
2017-02-14 16:32:33 -05:00
Sam
89d5e8ab4b
FEATURE: allow plugins to preload data in topic list
2017-02-14 16:29:06 -05:00
Sam
8feb94e13f
FIX: password validator was being too strict
2017-02-14 09:18:04 -05:00
Sam
783bac9ff7
less stubbing for better clarity and robustness
2017-02-13 14:34:15 -05:00
Sam
7652901b75
reduce mocking and stubbing in controller spec
2017-02-13 14:31:15 -05:00
Sam
0ab96a7691
FEATURE: add hidden setting for verbose auth token logging
...
This is only needed to debug auth token issues, will result in lots
of logging
2017-02-13 14:01:09 -05:00
Robin Ward
e1d358ffbf
FIX: Don't clear the login hint when the system user is saved
2017-02-13 10:54:20 -05:00
Jeff Atwood
3ee7a9266c
Merge pull request #4686 from tgxworld/group_is_visible_if_user_is_group_owner
...
FIX: Show groups that user is owner of on groups page.
2017-02-11 22:18:44 -08:00
Neil Lalonde
94e1105af7
fix unique char counting in password validator
2017-02-10 10:38:17 -05:00
Sam Saffron
4332f0dde1
FEATURE: allow user search API to restrict to group
2017-02-09 18:45:39 -05:00
Neil Lalonde
1bcb835446
FEATURE: passwords must have a minimum number of unique characters, configurable with a new setting
2017-02-09 15:00:22 -05:00
Robin Ward
9fe4427071
Clean up get_a_room following review
2017-02-08 12:24:26 -05:00
Neil Lalonde
5a8bbe663a
FEATURE: include most popular tag in page title for webcrawlers of tagged uncategorized topics
2017-02-07 16:55:42 -05:00
Sam Saffron
df8f365d99
FEATURE: improve search so it searches sub categories by default
...
If you want an exact category match use `category:=howto` or `#=howto"
2017-02-07 15:53:37 -05:00
Régis Hanol
02bb7beaaf
FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled
2017-02-07 18:06:44 +01:00
Sam
49e7124a5e
clarify override semantics in spec
2017-02-07 10:41:27 -05:00
Sam
f34907b523
Merge pull request #4681 from vietqhoang/feature/add-user-title-to-sso-payload
...
FEATURE: Add user title to SSO payload
2017-02-07 10:25:32 -05:00
Sam
ff49f72ad9
FEATURE: per client user tokens
...
Revamped system for managing authentication tokens.
- Every user has 1 token per client (web browser)
- Tokens are rotated every 10 minutes
New system migrates the old tokens to "legacy" tokens,
so users still remain logged on.
Also introduces weekly job to expire old auth tokens.
2017-02-07 09:22:16 -05:00
Sam
2dec731da3
SECURITY: correctly validate input when admin searches for screened ips
2017-02-06 16:11:16 -05:00
Régis Hanol
84af84dc52
prevent inactive & staged users from being automatically added to a group
2017-02-06 17:49:27 +01:00
Régis Hanol
ba115480ba
FIX: wasn't extracting links to quoted posts
2017-02-06 14:45:04 +01:00
Régis Hanol
27fb9c8804
FIX: bounce webhooks should also use recipient address
2017-02-05 19:06:35 +01:00
Robin Ward
f1e7bca3c9
FEATURE: Warn a user when they're replying to the same user too much
2017-02-03 17:00:54 -05:00
Neil Lalonde
c4e10f2a9d
FEATURE: redesign the change password page to use javascript and validations
2017-02-03 16:09:24 -05:00
Robin Ward
b251d11518
FIX: If you make a new banner, clear the old dismissed values
2017-02-03 15:07:38 -05:00
Guo Xiang Tan
61111a3f9b
FIX: Show groups that user is owner of on groups page.
2017-02-03 16:51:32 +08:00
Arpit Jalan
6b8691ecea
Merge pull request #4685 from techAPJ/approve-users-invite-fix
...
FIX: allow existing users to be invited to topic/message when must_approve_users is enabled
2017-02-03 13:22:18 +05:30
Arpit Jalan
dc2171960b
FIX: allow existing users to be invited to topic/message when must_approve_users is enabled
2017-02-03 13:01:23 +05:30
Guo Xiang Tan
c392994793
Fix specs.
2017-02-03 08:38:19 +08:00
Neil Lalonde
b91cb92af0
FIX: reports for time to first reply and topics without replies were counting whispers and moderator actions
2017-02-02 17:27:41 -05:00
Guo Xiang Tan
3c28d94706
FIX: Don't configure Redis connector if Redis slave config is not set.
2017-02-02 13:48:55 +08:00
Régis Hanol
82555ca761
FIX: mail threading wasn't working properly in Mac Mail
2017-02-01 23:02:41 +01:00
Viet Hoang
40164ccd4a
Add user title to SSO payload
2017-01-31 16:42:27 -08:00
Arpit Jalan
a525563eea
Optimize spec for ProcessPost job
2017-01-31 14:10:56 +05:30
Rimian Perkins
25516874b5
FIX: Escape regexp chars in SiteSetting.censored_words.
2017-01-31 10:14:51 +08:00
Régis Hanol
8fc7420f83
FIX: prevent huge custom emojis in emails
2017-01-30 18:06:48 +01:00
Arpit Jalan
19f7beaa2c
FIX: topic links were getting dropped when post is rebaked
2017-01-30 14:55:53 +05:30
Arpit Jalan
28e8d32d53
Suppress console output when running RSpec
2017-01-28 11:04:47 +05:30
Guo Xiang Tan
0e5d490b05
No need for special helper to reset SiteSetting state.
...
* SiteSetting in tests uses a local provider that resets it.
2017-01-28 10:55:49 +08:00
Neil Lalonde
7ead3e1f18
fix failing specs
2017-01-27 16:17:10 -05:00
Arpit Jalan
c36dda70ae
spec for posts:remap rake task
2017-01-28 00:13:08 +05:30
Leo McArdle
c76f6856ea
FEATURE: reply as new message to the same recipients
2017-01-27 12:24:31 +08:00
Robin Ward
496682c442
Merge pull request #4662 from tgxworld/fix_localized_group_name_change
...
Fix localized group name change
2017-01-26 10:50:00 -05:00
Arpit Jalan
9dd09e453b
FEATURE: add explicit confirmation button to accept the invite
2017-01-25 15:50:30 +05:30
Guo Xiang Tan
781d83a46f
FIX: Toggling a post's wiki status should not skip revision.
2017-01-25 13:34:55 +08:00
Guo Xiang Tan
ce07da1d8b
UX: Only display the words that fails censored words validations.
2017-01-24 13:11:05 +08:00
Régis Hanol
7e52d29a5b
Merge pull request #4643 from LeoMcA/fix-pull-img
...
FIX: Handle img src starting with "//" in pull_hotlinked_images job
2017-01-23 17:56:53 +01:00
Guo Xiang Tan
32846aad2a
FIX: Toggling post's wiki status should not create a new version.
2017-01-20 15:42:33 +08:00
Jeff Atwood
521ced38c5
fix spec for default email title
2017-01-19 14:01:51 -08:00
Neil Lalonde
6b93b09404
FIX: when blocking a user results in hiding their posts, only hide posts made in the last 24 hours
2017-01-19 15:56:22 -05:00
Régis Hanol
07660ecedb
bump onebox
2017-01-19 00:28:37 +01:00
Guo Xiang Tan
706b4f6b9f
FEATURE: Remap group mentions when group name has been changed.
2017-01-18 13:39:34 +08:00
Guo Xiang Tan
59dfb51a35
FIX: Don't change automatic group name if localized name has been taken.
2017-01-18 12:20:23 +08:00
Guo Xiang Tan
1e1e40c75f
Dump the page's content as well on failure.
2017-01-17 18:40:46 +08:00
Régis Hanol
fbf9172db8
FIX: log backups download/destroy staff action
...
FIX: clean up junk left by the specs
RENAME: 'backup_operation' to 'backup_create' to match other backup log types
2017-01-16 19:53:31 +01:00
Robin Ward
86c52c72f6
FIX: Deleting a user was not deleting their directory items
2017-01-16 11:46:52 -05:00
Leo McArdle
b60e9b7330
FIX: Handle img src starting with "//" in pull_hotlinked_images job
2017-01-16 10:50:07 +00:00
Guo Xiang Tan
63954c1b33
FIX: Same user record being saved twice causing validation to fail.
2017-01-16 16:41:03 +08:00
Guo Xiang Tan
e3b6f9b8ae
FIX: Do not update user stats like counts for private messages.
2017-01-16 11:07:53 +08:00
Guo Xiang Tan
ed5fa20b0c
Revert "FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level"
...
This reverts commit 9c40657ba4
2017-01-16 09:44:10 +08:00
Neil Lalonde
e8307ac24c
FIX: mailing list mode digest emails included whispers
2017-01-13 13:46:33 -05:00
Robin Ward
adb73180f7
FEATURE: Let plugins register themes easily
2017-01-13 11:50:52 -05:00
Régis Hanol
499a83270a
FIX: don't onebox to IP addresses
2017-01-12 22:35:33 +01:00
Guo Xiang Tan
38496985ef
Fix syntax error.
2017-01-12 10:03:37 +08:00
Guo Xiang Tan
23d4435af1
Oops.
2017-01-12 09:56:20 +08:00
Guo Xiang Tan
515f50e42e
FEATURE: Log admin action when readonly mode is changed.
2017-01-12 09:41:02 +08:00
Régis Hanol
887e9af84f
FEATURE: new 'max_image_megapixels' site setting
2017-01-11 23:37:12 +01:00
Neil Lalonde
b177827841
more specs for staff action logging
2017-01-11 11:41:21 -05:00
Guo Xiang Tan
1758af9a1d
FIX: Perform emoji unescape for topic titles in quotes.
2017-01-11 17:23:13 +08:00
Guo Xiang Tan
cdd550e947
Use a different Redis key when PG failover sets site to readonly mode.
2017-01-11 16:38:49 +08:00
Régis Hanol
185dcb2ca1
handle emails with localized headers 😠
2017-01-09 22:59:30 +01:00
Guo Xiang Tan
3d21ccd4a5
FIX: Add validation to disallow censored words in topic title.
2017-01-09 16:55:41 +08:00
Régis Hanol
98c62bccb5
FIX: mark forwarded email as read by the forwarder
...
FIX: 'Re:' prefix is mostly used for replies and not forwarded emails
2017-01-06 15:33:55 +01:00
Guo Xiang Tan
58f3a2e9a9
Fix randomly failing spec.
2017-01-06 15:25:49 +08:00
Guo Xiang Tan
68300f515c
FIX: Return 404 if id is not valid.
2017-01-06 10:39:44 +08:00
Guo Xiang Tan
d10fe51b72
Fix broken specs since all urls will be oneboxed.
2017-01-06 10:05:51 +08:00
Guo Xiang Tan
f473a119ff
Remove unnecessary stub.
2017-01-06 08:53:30 +08:00
Arpit Jalan
7a1ff59822
FIX: PM email to suspended member was broken
2017-01-05 13:58:14 +05:30
Guo Xiang Tan
a89f60b85b
Merge pull request #4631 from tgxworld/prevent_users_from_changing_permissions_of_non_real_users
...
FIX: Do not allow admins to meddle with admin and moderation access o…
2017-01-04 09:10:27 +08:00
Robin Ward
cf7774bdd9
FEATURE: Block muted users from sending you PMs
2017-01-03 14:51:53 -05:00
Guo Xiang Tan
c68bcfeb72
Improve spec.
2017-01-03 15:36:36 +08:00
Guo Xiang Tan
ad4a96d387
FIX: Only send membership request to the last 5 active group owners.
2017-01-03 15:33:57 +08:00
Arpit Jalan
495a511862
simplify quote markup in emails
2017-01-02 21:37:01 +05:30
Guo Xiang Tan
f1beef43a8
Merge pull request #4618 from tgxworld/fix_invalid_emails
...
FIX: Don't allow invalid email to be saved.
2016-12-30 07:11:48 +08:00
Guo Xiang Tan
c7b151683d
FIX: Do not allow admins to meddle with admin and moderation access of non real users.
2016-12-29 11:11:33 +08:00
Neil Lalonde
9c40657ba4
FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level
2016-12-28 17:36:04 -05:00
Sam
d28d8a1f85
FIX: order by op_likes leads to broken browsing
2016-12-27 19:08:54 +11:00
Arpit Jalan
d72cbcb2a4
FEATURE: new setting to validate user website
2016-12-26 21:29:27 +05:30
Guo Xiang Tan
5aee2673c7
FIX: Push null fields to last when sorting group members.
2016-12-22 14:55:24 +08:00
Guo Xiang Tan
8551d821a0
FEATURE: Add site setting to disable group directory.
2016-12-22 14:14:22 +08:00
Sam
c531f4ded5
remove rails-observers
...
Rails yanked out observers many many years ago, instead the functionality
was yanked out to a gem that is very lightly maintained.
For example: if we want to upgrade to rails 5 there is no published gem
Internally the usage of observers had quite a few problem.
The series of refactors renamed a bunch of classes to give us more clarity
and removed some magic.
2016-12-22 16:46:53 +11:00
Sam
019f1a1d06
UserEmailObserver is now removed
...
no big surprises here was pretty straightforward
after_commit semantics sure are weird though
2016-12-22 16:46:53 +11:00
Sam
2f6a4cc6de
remove UserActionObserver, replace with after_save and service
...
interestingly there was some left over dead code from when stars
existed in the topic_users table
2016-12-22 16:46:53 +11:00
Sam
0a78ae739d
Remove SearchObserver, aim is to remove all observers
...
rails-observers gem is mostly unmaintained and is a pain to carry forward
new implementation contains significantly less magic as a bonus
2016-12-22 13:13:14 +11:00
Guo Xiang Tan
28befcb5d4
Fix specs.
2016-12-21 21:21:39 +08:00
Guo Xiang Tan
076a08d8e1
FIX: Unactivated users should not be automatically added into groups as well.
2016-12-21 18:15:01 +08:00
Guo Xiang Tan
7228081820
FIX: Automatic group membership should not add staged or unactivated users.
2016-12-21 18:04:26 +08:00
Guo Xiang Tan
13c6191e89
FIX: Don't allow invalid email to be saved.
2016-12-21 17:47:11 +08:00
Guo Xiang Tan
5d7f3223f0
SECURITY: Users can only bookmark posts which they can see.
2016-12-21 12:01:26 +08:00
Neil Lalonde
c75bebdea2
FIX: uncategorized setting to control whether topic featured links are allowed
2016-12-20 15:55:30 -05:00
Guo Xiang Tan
9db5d5b6a7
FIX: Incorrect serializer for groups page.
2016-12-20 15:44:22 +08:00
Guo Xiang Tan
7c7c233c1c
FIX: Can't update Groups#allow_membership_requests in admin.
2016-12-20 15:14:35 +08:00
Guo Xiang Tan
502e114c60
FIX: Incorrect count when loading more groups.
2016-12-20 14:39:44 +08:00
Guo Xiang Tan
193f8301a4
FIX: Do not show automatic groups to normal users.
2016-12-20 14:26:49 +08:00
Régis Hanol
52cd9972bb
FIX: prevent DDoS with lots of _oneboxable_ links
...
FIX: ensure the onebox route is only allowed to logged in users
FIX: only allow 1 outgoing onebox preview per user
FIX: client should only do 1 preview at a time
2016-12-20 00:31:10 +01:00
Sam
2b808ad9da
Merge pull request #4609 from joebuhlig/category-topics-wiki
...
FEATURE: Category setting to make all topics wikis
2016-12-20 09:15:51 +11:00
Neil Lalonde
74956694e5
If summary email finds no topics, show topics more than 1 day old from new users
2016-12-19 14:54:08 -05:00
Neil Lalonde
923cf73c6e
Topic Featured Links: move data from custom fields to topics and categories tables. Invert behaviour of topic_featured_link_allowed checkbox. Fix a bug with invalid topic records due to changing that category checkbox.
2016-12-19 14:54:07 -05:00
Arpit Jalan
a2096a01fb
add test case for handling uploads without extension
2016-12-20 00:46:47 +05:30
Robin Ward
e03d5e2140
Reapply Ember 2.10 for good this time!
...
This reverts commit ddd299f4aa
2016-12-19 11:19:10 -05:00
Joe Buhlig
87251fded7
FEATURE: Category setting to make all topics wikis
...
FEATURE: Category setting to make all topics wikis
2016-12-19 06:42:18 -06:00
Guo Xiang Tan
18c8323987
FIX: Incorrect path for redirect.
2016-12-19 18:12:15 +08:00
Sam
e0ff57ca75
SECURITY: prevent reuse of password reset
2016-12-19 18:00:22 +11:00
Sam
eb2db23b40
FEATURE: remove email_token_grace_period_hours
...
The site setting email_token_grace_period_hours just causes confusion and
should not be used anyway.
Out of the box, tokens stop working once confirmed, no need to add complexity here
2016-12-19 17:15:20 +11:00
Sam
0599bd0154
FEATURE: add referrer never tag to password reset page
2016-12-19 11:01:58 +11:00
Sam
15b5fddd49
SECURITY: protect upload params, only allow very strict filenames
2016-12-19 10:16:18 +11:00
Arpit Jalan
ab6843dcde
FIX: username route was broken
2016-12-16 23:56:22 +05:30
Guo Xiang Tan
d8541c589a
FIX: Incorrect route for updating username.
2016-12-17 00:23:12 +08:00
Robin Ward
ddd299f4aa
Revert "Revert "Revert Ember 2.10+ for a short while""
...
This reverts commit 76bbc481cb
2016-12-16 10:29:30 -05:00
Robin Ward
76bbc481cb
Revert "Revert Ember 2.10+ for a short while"
...
This reverts commit 21682fd60b
2016-12-16 09:52:29 -05:00
Sam
61eb134181
FEATURE: setting to allow arbitrary redirects from sso origin
...
if sso_allows_all_return_paths is set to true you can redirect off-site from sso success
2016-12-16 13:37:44 +11:00
Sam
6ff309aa80
SECURITY: don't grant same privileges to user_api and api access
...
User API is no longer gets bypasses that standard API gets.
Only bypasses are CSRF and XHR requirements.
2016-12-16 12:05:43 +11:00
Régis Hanol
197517d55e
FIX: locally uploaded audio & video files should onebox even when the extension is uppercase
2016-12-15 23:21:44 +01:00
Robin Ward
21682fd60b
Revert Ember 2.10+ for a short while
2016-12-15 16:43:38 -05:00
Robin Ward
ba8c6fd840
FIX: PhantomJS was crashing
2016-12-15 12:30:20 -05:00
Sam
98f4a2adcb
FIX: on 404 from brotli asset path return a correctly encoded doc
...
old implementation would cache the 404 for 1 year with incorrect encoding
hilarity would ensue
2016-12-15 16:05:20 +11:00
Guo Xiang Tan
13c344245d
Merge pull request #4603 from tgxworld/group_index_page
...
FEATURE: Add groups page.
2016-12-14 23:26:05 +08:00
Guo Xiang Tan
20f9aad539
Merge pull request #4599 from tgxworld/remove_rspec_given
...
Remove RSpec given.
2016-12-14 17:42:30 +08:00
Guo Xiang Tan
4b940dc8bd
FEATURE: Add groups page.
2016-12-14 17:27:47 +08:00
Guo Xiang Tan
18f400e652
Remove RSpec given.
2016-12-14 10:29:22 +08:00
Neil Lalonde
2d61d7d644
update embed_controller_spec
2016-12-13 16:29:51 -05:00
Guo Xiang Tan
2686ee5ab2
FIX: Admin can't add/remove public group users.
2016-12-13 16:39:44 +08:00
Guo Xiang Tan
43ee9f884e
FEATURE: Add Group#full_name.
2016-12-13 16:16:26 +08:00
Guo Xiang Tan
69330f8bc2
Add user_updated event to webhooks.
2016-12-13 11:26:26 +08:00
Guo Xiang Tan
da7009a968
FEATURE: Add request membership button for allowed groups.
2016-12-12 22:48:08 +08:00
Régis Hanol
664feca199
FIX: don't send emails from muted users in mailing list mode
2016-12-12 15:28:26 +01:00
Guo Xiang Tan
9a800107cb
FIX: Associate category logo and background to uploads record.
2016-12-12 17:37:28 +08:00
Guo Xiang Tan
05f55dbc10
FEATURE: Group logs.
2016-12-12 17:29:54 +08:00
Guo Xiang Tan
be5b5f6bea
FEATURE: Public groups.
2016-12-12 17:00:30 +08:00
Neil Lalonde
24d2973108
enable featured links by default
2016-12-09 16:08:17 -05:00
Neil Lalonde
fb2633366a
FIX: featured link topics shouldn't require the same min post length
2016-12-09 15:46:26 -05:00
Neil Lalonde
a4c4f13901
Remove the topic_featured_link_onebox setting. We will always try to onebox a link and add it to the body if topic_featured_link_enabled is enabled.
2016-12-09 13:28:12 -05:00
Sam
846597f563
FIX: staff tags are stripped by non-staff
2016-12-09 17:24:26 +11:00
Guo Xiang Tan
b9b4b0c175
FIX: Members should be ordered by username.
2016-12-08 14:27:38 +08:00
Guo Xiang Tan
a2da2971af
FEATURE: Allow columns on group members page to be sortable.
2016-12-08 10:49:12 +08:00
Guo Xiang Tan
545dfa7191
FEATURE: Allow group owners to edit title.
2016-12-07 10:26:28 +08:00
Sam
1135e00c83
FIX: regression unable to dismiss unread
2016-12-06 08:49:40 +11:00
Erick Guan
52763f5115
FEATURE: Allow posting a link with topics
2016-12-05 17:20:54 +01:00
Régis Hanol
06469ef0ce
FIX: don't extract links from .elided parts
2016-12-05 15:19:15 +01:00
Guo Xiang Tan
37b256e7f2
Fix specs.
2016-12-05 17:13:58 +08:00
Arpit Jalan
431aa79bb3
Merge pull request #4587 from techAPJ/invite-upload
...
FIX: simplify CSV file upload
2016-12-05 14:30:13 +05:30
Guo Xiang Tan
adb7fcb6b3
FEATURE: Add bio to group page.
2016-12-05 16:58:04 +08:00
Arpit Jalan
ce974da9e5
FIX: simplify CSV file upload
2016-12-05 14:09:08 +05:30
Guo Xiang Tan
31acd311e5
FEATURE: Allow group owners to edit group name and avatar flair.
2016-12-05 14:27:46 +08:00
Guo Xiang Tan
b45fd21ed9
FIX: Clean up specs.
2016-12-05 13:37:33 +08:00
Sam
dc66f6681a
add spec for brotli controller, ensure cached correctly
2016-12-05 16:08:36 +11:00
Guo Xiang Tan
22059d4df9
Add Rake task to clean up unused multisite Redis keys.
2016-12-05 11:46:34 +08:00
Sam
39a524aac8
FEATURE: brotli cdn bypass for assets
...
Allow CDNS that strip out brotli encoding to use brotli regardless
2016-12-05 13:57:09 +11:00
Sam
33d0a23d84
Merge branch 'fix_whisper'
2016-12-05 10:01:03 +11:00
Neil Lalonde
dafd1453d6
FIX: topic list filters for bookmarked, posted, and read now work with tag filter
2016-12-02 15:58:14 -05:00
Guo Xiang Tan
3971f96aa6
Merge pull request #4536 from fantasticfears/webhooks-edit
...
FIX: missing post and topic edited webhooks
2016-12-02 10:16:19 +01:00
Guo Xiang Tan
bc0a8142fe
PERF: Only show members count on group page.
2016-12-02 16:28:54 +08:00
Sam
9b885c039a
Merge branch 'master' into fix_whisper
2016-12-02 17:44:05 +11:00
Sam
c04d4171ff
FIX: whisper no longer experimental
...
- Regular users are not notified of whispers
- Regular users no longer have "stuck" topics in unread
- Additional tracking for staff highest post number
- Remove a bunch of unused columns in topics table
2016-12-02 17:03:31 +11:00
Régis Hanol
eb453d0f82
the note in a FWed email should be a whisper only in PM and when the author is member of the group
2016-12-01 18:43:56 +01:00
Régis Hanol
62763f025c
FIX: wasn't able to parse FROM email in the embedded email
2016-12-01 18:34:47 +01:00
Neil Lalonde
985daf5c72
FIX: summary should not include certain post types
2016-12-01 12:01:32 -05:00
Erick Guan
8c8549b27b
FIX: missing post and topic edited webhooks
2016-11-30 20:49:45 +01:00
Régis Hanol
dec8a861f0
FIX: don't raise exception when a quote was already extracted
2016-11-30 17:18:34 +01:00
Guo Xiang Tan
b8441fba27
Merge pull request #4546 from tgxworld/fix_postgresql_failover
...
Fix postgresql failover
2016-11-30 09:36:52 +01:00
Sam
b8dc58be90
got to be careful with integrity specs
2016-11-29 18:01:09 +11:00
Sam
266322ce2e
FEATURE: add help text for no bookmarks in user page
2016-11-29 17:56:00 +11:00
Sam
0631a84ca0
Merge pull request #4576 from cpradio/min-posts-search
...
FEATURE: Add min_post_count search filter
2016-11-29 10:19:33 +11:00
cpradio
66ca6d622e
FEATURE: Add min_post_count search filter
2016-11-28 11:43:12 -05:00
Régis Hanol
6edd3c347c
FIX: automatically disable digests when enabling mailing list mode
2016-11-28 15:52:35 +01:00
Régis Hanol
a03287f2ee
FIX: 'In-Reply-To' header should default to topic_message_id
2016-11-28 14:18:02 +01:00
Régis Hanol
74b6fe8739
FIX: respect RFCs when setting 'In-Reply-To' and 'References' email headers
2016-11-25 23:25:39 +01:00
Guo Xiang Tan
559918c6c6
PERF: Add endpoint to check if a group can be mentioned by user.
2016-11-26 02:20:46 +08:00
Guo Xiang Tan
5794f1619d
PERF: Fix N+1 queries when loading groups.
2016-11-26 02:20:26 +08:00
Guo Xiang Tan
63a88ee6e7
Merge pull request #4566 from tgxworld/fix_perf_redirect_to_top
...
Fix perf redirect to top
2016-11-25 03:39:56 +01:00
Sam
88a46be051
FEATURE: display text excerpts when scrolling on mobile
2016-11-25 11:35:29 +11:00
Guo Xiang Tan
b889bfefbb
PERF: Don't calculate the same query twice.
2016-11-24 14:05:26 +08:00
Neil Lalonde
79dc0518c9
FIX: popular posts in digest need to use same restrictions as topics
2016-11-23 11:24:18 -05:00
Guo Xiang Tan
02025207d5
FIX: Make sure Redis fallback don't fall into a permanent readonly state.
2016-11-23 11:31:20 +08:00
Sam
bfd0418f07
added a test for safe mode
2016-11-23 13:31:05 +11:00
Neil Lalonde
86deec3528
FIX: exclude popular posts from deleted topics
2016-11-22 13:23:21 -05:00
Guo Xiang Tan
3909f342f6
FEATURE: Allow options to be set when adding model callbacks.
2016-11-21 10:20:31 +08:00
Arpit Jalan
2d0c99636a
do not add rel noreferrer
2016-11-20 18:19:14 +05:30
Arpit Jalan
7cb76f7333
FIX: add rel noopener and noreferrer in addition to nofollow
2016-11-20 17:07:27 +05:30
Guo Xiang Tan
f824afb4d3
FEATURE: Allow date_of_field column to be updated.
2016-11-17 15:16:58 +08:00
Guo Xiang Tan
e8a3043129
Spawn a single thread that checks for PostgreSQL fallback.
2016-11-17 13:52:08 +08:00
Guo Xiang Tan
8c6d8c85db
Stop showing first notification prompt once user sees the notification.
2016-11-17 09:44:00 +08:00
Guo Xiang Tan
98c1e0832c
FIX: Track first notification read using Redis.
2016-11-16 16:20:38 +08:00
Guo Xiang Tan
16fdcdfc00
FIX: Add conditions on when to show first pm notification.
2016-11-16 14:17:47 +08:00
Guo Xiang Tan
b5dc68cd52
Merge pull request #4552 from tgxworld/extract_test_logic
...
Ensure we don't run `$redis.keys` in production.
2016-11-16 10:05:02 +08:00
Robin Ward
32a8d5ed1f
Merge pull request #4550 from cpradio/cannot-see-mention
...
FEATURE: Notify user when mention can't see the reply they were mentioned in
2016-11-15 16:40:47 -05:00
Guo Xiang Tan
95c6e97587
Ensure we don't run $redis.keys in production.
2016-11-15 23:23:41 +08:00
Sam
63d9d4f301
FIX: properly specify default on no cache on all resources
2016-11-15 17:00:44 +11:00
cpradio
824c235760
FEATURE: Notify user when mention can't see the reply they were mentioned in
...
FIX: Group Mention Notifications
2016-11-14 22:03:16 -05:00
Sam
f4c754b389
FEATURE: split JavaScript application bundle, so plugins live in own file
...
This adds plugin.js and plugin_third_party.js files
2016-11-15 11:43:13 +11:00
Leo McArdle
784366f1a0
FIX: display only 1 trust level badge on user card
...
refactoring graciously provided by @xfalcox
2016-11-14 20:53:24 +00:00
Sam
115c454002
FIX: if prioritizing names in ux choose name over username in email
2016-11-14 11:09:24 +11:00
Sam
3d76ce1421
FEATURE: SSO support for adding and removing a user to groups
...
Use: add_groups with a comma delimited list to ensure a user is in groups (using group names)
Use: remove_groups with a comma delimited list to ensure a user is removed from groups (using group names)
2016-11-11 16:57:31 +11:00
Arpit Jalan
9e69798285
FEATURE: watch first post default site setting
2016-11-10 00:09:52 +05:30
Guo Xiang Tan
2d2998f5e0
Fix specs.
2016-11-09 11:31:53 +08:00
Neil Lalonde
86522a52b7
FEATURE: add censored_pattern setting to censor posts using regex
2016-11-08 16:39:26 -05:00
Guo Xiang Tan
b18439a1e2
Fix build.
2016-11-08 17:00:44 +08:00
Guo Xiang Tan
a8b7599d4a
FEATURE: Add a radial ping when user's first notification has not been read.
2016-11-08 16:23:12 +08:00
Sam
ac2c035856
FIX: stop raising exceptions when a post goes missing
2016-11-08 14:51:56 +11:00
Sam
a1a7094604
Merge pull request #4539 from tgxworld/use_a_time_task_for_redis_failover
...
PERF: Spawn a seperate timer task to check if Redis master is up.
2016-11-08 11:18:54 +11:00
Régis Hanol
9ef724a065
FIX: self-onebox in read protected categories
2016-11-07 18:14:28 +01:00
Guo Xiang Tan
fbbcde1230
FIX: Don't treat master as up if it is still loading data.
2016-11-07 15:28:10 +08:00
Guo Xiang Tan
9375dcb6fe
PERF: Spawn a seperate timer task to check if Redis master is up.
2016-11-07 15:04:28 +08:00
Sam
2ddabc3928
FIX: protect against future regressions of google omniauth
2016-11-07 12:48:00 +11:00
Guo Xiang Tan
9fd317306c
FIX: Do not show educational message for PMs.
2016-11-04 17:06:53 +08:00
Régis Hanol
a655e4b092
ensure we allow self oneboxing of login required sites
2016-11-03 22:48:32 +01:00
Neil Lalonde
764a572070
FIX: when subcategories with the same name exist, filtering by tags might use the wrong subcategory
2016-11-02 15:29:33 -04:00
Guo Xiang Tan
f03d9cad06
PERF: NOT IN query is really inefficient for large tables.
2016-11-02 13:09:18 +08:00
Neil Lalonde
9ef1688a76
FEATURE: per-category default topic list sort order
2016-11-01 12:18:41 -04:00
Arpit Jalan
382803cb05
FEATURE: include post image in OpenGraph image tag
2016-10-31 15:11:33 +05:30
Régis Hanol
f8caae0be7
FIX: don't overwrite custom email headers when using mandrill/sparkpost
2016-10-30 11:38:55 +01:00
Neil Lalonde
092ad7810d
add the spec for unused tag count
2016-10-28 16:14:20 -04:00
Neil Lalonde
8c9d390cac
FIX: Tags used only on deleted topics could not be used again
2016-10-28 15:11:50 -04:00
Régis Hanol
71f940d478
FIX: use metadata to hold the message_id with sparkpost
2016-10-27 19:35:50 +02:00
Guo Xiang Tan
49c27d9a88
FEATURE: Add interface in Plugin::Instance to register a seedfu fixture.
2016-10-25 14:57:31 +08:00
Régis Hanol
01001b167e
fix the build
2016-10-25 01:55:47 +02:00
Régis Hanol
750338954c
FIX: download SSO avatars in a background job to prevent hangs when avatars are huge
2016-10-24 19:55:30 +02:00
Régis Hanol
3841cd9a7f
FEATURE: onebox everything by default
...
FEATURE: new 'max_oneboxes_per_post' site setting
FEATURE: change onebox whitelist to a blacklist
PERF: debounce the loading of oneboxes
PERF: improve perf of mention links in preview
FIX: sort loading of custom oneboxer
2016-10-24 12:46:22 +02:00
Régis Hanol
81e2a0099f
FIX: ensure the group 'everyone' is never shown when using a different locale
2016-10-24 10:53:31 +02:00
Guo Xiang Tan
efea296c7a
FIX: Do not cook post if Post#raw has not been changed.
2016-10-24 12:02:38 +08:00
Guo Xiang Tan
ee9946388c
Merge pull request #4507 from ming-relax/feat-delete-by-email
...
Remove user from a group by user email
2016-10-24 11:28:27 +08:00
Ming HU
7803a06e50
Use expect change for groups_controller_spec.rb
2016-10-24 10:32:21 +08:00
Sam
9a94d1b212
FIX: everyone is not a visible group
2016-10-24 13:03:22 +11:00
Régis Hanol
3c8e0a8348
Merge pull request #4508 from kstaikov/mailing_list_exclude_own_replies
...
FEATURE:'No Echo' option for mailing list mode.
2016-10-22 10:45:14 +02:00
Robin Ward
19e2eec219
Allow step 0 to resend the confirmation email
2016-10-21 11:34:19 -04:00
Régis Hanol
2a61cc8c88
FIX: email styling with blacklisted iframes
2016-10-21 12:37:03 +02:00
Jeff Atwood
febbd27ba6
remove gmail/live SMTP warning
2016-10-20 14:49:06 -07:00
Régis Hanol
8d48779b5c
FIX: don't 💥 with an invalid URI
2016-10-20 12:34:42 +02:00
Kiril Staikov
aee943486a
FEATURE:'No Echo' option for mailing list mode.
...
Mailing list mode now includes the 'no echo' option: to only receive emails of posts not created
by you. If you reply to an email thread in mailing list mode, your reply will not then be echoed
back to you in a duplicate email by the system.
2016-10-19 13:14:36 -04:00
Robin Ward
c03d25f170
FEATURE: Configure Admin Account
...
Adds a "Step 0" to the wizard if the site has no admin accounts where
the user is prompted to finish setting up their admin account from the
list of acceptable email addresses.
Once confirmed, the wizard begins.
2016-10-19 11:27:56 -04:00
Sam
674264726d
FIX: should not be allowed to see users list of people who started a PM
2016-10-19 17:36:35 +11:00
Ming HU
dffd8baa91
Remove user from a group by user email
2016-10-18 17:10:47 +08:00
Guo Xiang Tan
7db33cc512
FIX: Videos and audio files were not associated to the post.
2016-10-18 16:13:39 +08:00
Guo Xiang Tan
2a9331d061
Remove stubs from tests.
2016-10-18 13:39:16 +08:00
Régis Hanol
3949c24f80
FIX: sparkpost webhooks support
2016-10-17 11:26:49 +02:00
Sam
aaf947356b
correct regression where notifications scope is not pushing to push server
2016-10-14 22:52:39 +11:00
Régis Hanol
bd1328c189
FIX: show the wizard to developers too
2016-10-14 11:09:55 +02:00
Sam
f4f5524190
FEATURE: user API now contains scopes so permission is granular
...
previously we supported blanket read and write for user API, this
change amends it so we can define more limited scopes. A scope only
covers a few routes. You can not grant access to part of the site and
leave a large amount of the information hidden to API consumer.
2016-10-14 16:05:42 +11:00
Régis Hanol
2826d4eb88
Merge pull request #4487 from cpradio/use-top-default-for-new-users
...
FEATURE: Use the top period default for users who have been inactive or are new
2016-10-13 10:47:18 +02:00
cpradio
489e1bf643
Stub the TopTopic.topics_per_period so the logic is fully tested
2016-10-12 19:28:54 -04:00
Neil Lalonde
0328141e05
FIX: prevent creation of tags with invalid characters
2016-10-12 15:44:36 -04:00
Sam
3ad8616f44
Merge pull request #4476 from xfalcox/localize-badge-notifications
...
FIX: Properly localize badge notification on batch grant
2016-10-12 15:16:35 +11:00
Rafael dos Santos Silva
48fa1f141f
Add specs for localized notifications on backfilled badges
2016-10-11 19:15:36 -03:00
cpradio
9cbf7d036a
FEATURE: Use the top period default for users who have been inactive or are new
2016-10-11 13:22:43 -04:00
Régis Hanol
ddcc084d22
Revert "FEATURE: Use the top period default for users who have been inactive or are new"
2016-10-11 17:56:46 +02:00
cpradio
2de50a616d
FEATURE: Use the top period default for users who have been inactive or are new
2016-10-11 09:55:15 -04:00
Sam
89daa43754
FEATURE: remap emojis back for push notifications and desktop alerts
2016-10-11 13:03:48 +11:00
Sam
6031e692f0
Merge pull request #4366 from xfalcox/print
...
Print Support
2016-10-11 11:47:20 +11:00
Sam
0f0b657182
Merge pull request #4447 from pmusaraj/approve_new_topics_setting
...
FEATURE: add "Approve new topics unless user level" setting
2016-10-11 10:14:28 +11:00
Sam
ea1f0683c8
Merge pull request #4477 from cpradio/watching-state-on-reply
...
FEATURE: Add notification level user preference when replying to a topic
2016-10-11 10:05:37 +11:00
Régis Hanol
8f68a95e56
FIX: trim leading & trailing whitespaces in admin user search
2016-10-10 16:18:57 +02:00
Sam
3e513f5c05
Merge pull request #4459 from vibol/master
...
FEATURE: sparkpost webhook
2016-10-10 17:17:17 +11:00
Sam Saffron
647ee46edf
FIX: don't stem the search term
...
Search for "canned" not working correctly and "butted", "ands" and many more :)
2016-10-07 12:40:57 +11:00
Neil Lalonde
c70f52c4dd
remove some problem reports from the admin dashboard since they're covered by the setup wizard now
2016-10-05 12:14:56 -04:00
Guo Xiang Tan
1302db2683
Skip randomly failing test first.
2016-10-01 05:14:35 +08:00
cpradio
6f1c31d777
Add notification level user preference when replying to a topic
2016-09-30 14:58:07 -04:00
Robin Ward
f62d01ff1b
FIX: Clear the session after a reset token was used
2016-09-30 12:20:23 -04:00
Sam Saffron
4d8d5613e4
FEATURE: add min_trust_level_to_edit_post
...
add minimum trust level to edit post (default 0)
2016-10-01 02:12:27 +10:00
Guo Xiang Tan
cde18834f8
Fix randomly failing spec.
2016-09-30 05:18:54 +08:00
Vibol Hou
c3d60d5d1d
Merge remote-tracking branch 'upstream/master'
2016-09-29 02:12:05 -07:00
Guo Xiang Tan
40b83ebb47
Reset I18n.locale in tests.
2016-09-29 13:42:56 +08:00
Guo Xiang Tan
72ccb4e11d
FIX: Plugin "admin_js" translations bundle was not fetched.
2016-09-29 04:42:26 +08:00
Vibol Hou
34af73c7cb
FEATURE: sparkpost webhook
2016-09-26 22:13:34 -07:00
Rafael dos Santos Silva
0229df4c73
Second review fixes
2016-09-26 20:46:55 -03:00
Rafael dos Santos Silva
f96fffeb34
Add tests
2016-09-26 20:46:55 -03:00
Sam
df751ed6ec
Merge pull request #4457 from JaredReisinger/github-auth-with-email-whitelist
...
Add support for email whitelist/blacklist to GitHub auth
2016-09-23 09:49:14 +10:00
Robin Ward
3c12dd6549
FIX: Consider lazyYT divs as links when extracting
2016-09-22 16:50:24 -04:00
Neil Lalonde
e0be2f482e
FEATURE: tag filter dropdown menu is scoped to user and category
2016-09-22 15:23:37 -04:00
pmusaraj
0344388924
added tests and enabled queue when new setting is > 0
2016-09-22 14:51:36 -04:00
Jared Reisinger
2ae7c47a3c
Add support for email whitelist/blacklist to GitHub auth
...
If a site is configured for GitHub logins, _**and**_ has an email domain
whitelist, it's possible to get in a state where a new user is locked to
a non-whitelist email (their GitHub primary) even though they have an
alternate email that's on the whitelist. In all cases, the GitHub
primary email is attempted first so that previously existing behavior
will be the default.
- Add whitelist/blacklist support to GithubAuthenticator (via
EmailValidator)
- Add multiple email support GithubAuthenticator
- Add test specs for GithubAuthenticator
- Add authenticator-agnostic "none of your email addresses are allowed"
error message.
2016-09-22 11:31:10 -07:00
Robin Ward
7f66cf618c
FIX: You should be an admin to do the wizard
2016-09-22 11:12:51 -04:00
Robin Ward
14bee641aa
Can choose categories or latest as homepage style
2016-09-22 09:52:19 -04:00
Robin Ward
2a0443445b
New step to choose emoji set
2016-09-22 09:52:19 -04:00
Robin Ward
2545c2ffa6
Add new welcome message step
2016-09-22 09:52:19 -04:00
Robin Ward
b0ee7930e8
Server side support for inviting as a moderator via the wizard
2016-09-22 09:52:19 -04:00
Robin Ward
28cd49f02b
Split Logos and Icons into separate steps
2016-09-22 09:52:19 -04:00
Robin Ward
4f9a7aa769
FIX: Prompt for the wizard for the first admin who logs in
2016-09-22 09:52:19 -04:00
Robin Ward
644bcbc253
Make the site contact a drop down of admin users
2016-09-22 09:52:19 -04:00
Robin Ward
74ed2e82ac
UX: Wiggle invalid form elements. Don't allow a site title of Discourse
2016-09-22 09:52:19 -04:00
Robin Ward
29cf47cfb2
Track steps the user has completed, nag them to finish it.
2016-09-22 09:52:19 -04:00
Robin Ward
ef84981e38
Invite Users step
2016-09-22 09:52:19 -04:00
Robin Ward
35b767f6af
Company Name Step which updates the TOS
2016-09-22 09:52:19 -04:00
Robin Ward
28b6c300a0
Clean up wizard updater API for better plugin use
2016-09-22 09:52:19 -04:00
Robin Ward
e3640ee5f6
Privacy Step
2016-09-22 09:52:19 -04:00
Robin Ward
af83c8dc14
Upload Logos Step
2016-09-22 09:52:19 -04:00
Robin Ward
c94e6f1b96
Add locale step
2016-09-22 09:52:19 -04:00
Robin Ward
3f6e3b9aff
Wizard - Color Scheme Step
2016-09-22 09:52:19 -04:00
Robin Ward
9f12b571ef
Wizard: Server Side Validation + Finished Step
2016-09-22 09:52:19 -04:00
Robin Ward
3a4615c205
Wizard: Step 1
2016-09-22 09:48:58 -04:00
Robin Ward
0471ad393c
Scaffold for new Wizard - Rails / Ember / Tests
2016-09-22 09:48:58 -04:00
Robin Ward
6070939daa
Support for other i18n bundles
2016-09-22 09:48:58 -04:00
Guo Xiang Tan
73fdf443fd
This should have been removed.
2016-09-22 17:17:11 +08:00
Guo Xiang Tan
9374e5d42d
Revert "FIX: don't overwrite category's logo & background URLs"
...
This reverts commit 641b95f655
2016-09-22 11:30:19 +08:00
Guo Xiang Tan
d312c82474
Revert "FIX: wasn't able to update category's settings"
...
This reverts commit 282f9948cb
2016-09-22 11:29:44 +08:00
Régis Hanol
641b95f655
FIX: don't overwrite category's logo & background URLs
2016-09-21 22:11:31 +02:00
Robin Ward
2766b2edc3
FIX: Allow redirection for slugs that start with digits
2016-09-19 13:31:19 -04:00
Sam
8dc4329094
FEATURE: optionally get extra profile info from facebook
...
This feature requires the application be approved by facebook, so it is
default off
2016-09-19 16:14:11 +10:00
Sam
5b3cd3fac9
FEATURE: Import facebook avatars when logging in via facebook
...
FIX: warning about popup dimensions when using facebook login
Rules are:
- On account creation we always import
- If you already have an avatar uploaded, nothing is changed
- If you have no avatar uploaded, we upload from facebook on login
- If you have no avatar uploaded, we select facebook unless gravatar already selected
This also fixes SSO issues where on account creation accounts had missing avatar uploads
2016-09-19 15:10:23 +10:00
Erick Guan
c463cf63d4
FEATURE: Webhook for user creation and approval
2016-09-19 10:12:55 +08:00
cpradio
0d2d8797b6
FIX: Backup validation wasn't escaping hyphens
2016-09-16 15:20:42 -04:00
Guo Xiang Tan
a04dadf9b4
FIX: Randomly failing specs try 2.
2016-09-16 15:10:37 +08:00
Guo Xiang Tan
903d1dd326
FIX: Randomly failing specs.
2016-09-16 14:56:59 +08:00
Sam
75f3f7fcbd
FEATURE: clean API method for reading a single notification
2016-09-16 16:14:15 +10:00
Guo Xiang Tan
512922d776
SECURITY: Add filename validation for backup uploads.
2016-09-16 11:58:14 +08:00
Sam
33578a2c17
FIX: always import avatars during SSO if they are missing
2016-09-16 09:45:00 +10:00
Arpit Jalan
e46204d195
FIX: allow long words if they contain periods
2016-09-13 09:15:05 +05:30
Robin Ward
2c9a47dda5
FIX: Validate the raw content of posts before enqueuing them
2016-09-12 12:26:49 -04:00
Neil Lalonde
06eb256d0a
FIX: blocking users should never hide all posts if they are trust level 1 or higher
2016-09-12 11:58:10 -04:00
Sam
2d859ba0ed
FIX: user api should always be available to staff
2016-09-12 15:42:06 +10:00
Robin Ward
e78b7a243e
FIX: Don't enqueue posts if the user can't create them (ex: closed)
2016-09-09 12:15:56 -04:00
Robin Ward
9609a47016
Ability to skip email validation via a plugin
2016-09-07 14:05:46 -04:00
Guo Xiang Tan
35bc0c943f
More randomly failing specs fixes.
2016-09-05 19:33:03 +08:00
Erick Guan
9ce61b4586
FEATURE: Webhooks.
2016-09-05 18:44:00 +08:00
Guo Xiang Tan
1f70fc9e11
Make sure we reset global in specs.
2016-09-05 18:18:14 +08:00
Guo Xiang Tan
31d900f7e7
Fix build.
2016-09-05 17:03:41 +08:00
Guo Xiang Tan
aa1f306894
Properly clean up plugin event in specs..
2016-09-05 16:10:03 +08:00
Guo Xiang Tan
aabb7a8592
FIX: DiscourseEvent should not be triggered from within the controller.
2016-09-05 15:58:04 +08:00
Guo Xiang Tan
ec90655c41
FIX: Clean up specs properly.
2016-09-05 15:48:59 +08:00
Guo Xiang Tan
aa9decf6fd
Remove DiscourseEvent.clear.
2016-09-05 15:17:49 +08:00
Sam
e0a2346b92
no more protocol-less CDN urls
2016-09-05 16:05:48 +10:00
Sam
59640bae3b
FIX: absolute URL for CDN should always be rooted with a protocol
2016-09-05 15:57:46 +10:00
Guo Xiang Tan
e4b75f604c
FIX: Make clean up upload script a safer task to run.
2016-09-05 10:06:02 +08:00
Sam
340874d345
FIX: post notifications in JSON so we properly support arrays and so on
2016-09-04 15:51:16 +10:00
Sam
1d281e02c7
id is optional if already specified in header
2016-09-02 17:08:46 +10:00
Sam
be0fd5b4cc
FEATURE: allow user api key revocation for read only keys
2016-09-02 17:04:00 +10:00
Sam
0a39ba43ed
FIX: always respect avatar_force_update
2016-09-02 12:04:22 +10:00
Sam
211c374df6
Merge pull request #4213 from fantasticfears/sso
...
FIX: Importing user avatar when new user login by SSO
2016-09-01 18:05:18 -07:00
Guo Xiang Tan
90a0327fd2
FIX: Check against reserved usernames should be case insensitive.
2016-08-31 21:53:41 +08:00
Robin Ward
7da44e3bf0
FEATURE: Support author meta tags for embedding
2016-08-30 12:01:04 -04:00
Erick Guan
0217973374
FIX: Importing user avatar when new user login by SSO
2016-08-29 20:47:19 +08:00
Neil Lalonde
2251104e32
FEATURE: avatar flair can be font awesome icons
2016-08-26 17:15:37 -04:00
Robin Ward
20241a01e9
FIX: Run the regular expression against query parameters
2016-08-26 12:47:47 -04:00
Sam
ca79c4b276
stop eating up push_urls
2016-08-26 13:23:06 +10:00
Sam
fcdf13f52d
add some more testing
2016-08-26 13:18:20 +10:00
Sam
a37db9448f
correctly return access rights in auth redirect
2016-08-26 13:12:38 +10:00
Sam
4fe52c8cbe
FEATURE: backend support for pushing notifications to clients
2016-08-26 12:47:10 +10:00
Guo Xiang Tan
2f39293867
FIX: User enabled readonly mode was not working.
2016-08-25 23:31:59 +08:00
Neil Lalonde
7a81669c18
SECURITY: don't allow re-using the current password during password reset
2016-08-24 12:27:21 -04:00
Régis Hanol
038eb6f645
FIX: translations with a symbol as key should also be overridable
2016-08-24 11:53:03 +02:00
Robin Ward
c3a3aff120
FEATURE: Support for a whitelist for embeddable host paths
2016-08-23 14:56:12 -04:00
Robin Ward
1468616465
FIX: Support links with google analytics tracking and hashes
2016-08-23 12:13:31 -04:00
Guo Xiang Tan
17f0727b04
FIX: Don't track user profile view when viewed by system user.
2016-08-23 16:25:31 +08:00
Robin Ward
884bdf7240
FEATURE: Ability to scrub titles when importing embeddable content
2016-08-22 12:43:02 -04:00
Arpit Jalan
4a2f0e772c
add specs for post ownership change without revision
2016-08-20 01:27:48 +05:30
Robin Ward
4061725a95
FIX: Don't ever grant badges when they're disabled
2016-08-19 15:16:37 -04:00
Guo Xiang Tan
3141c179f7
REFACTOR: Get bucket name from S3Helper.
2016-08-19 14:08:37 +08:00
Régis Hanol
eb953c0904
FIX: /categories page on mobile
2016-08-19 01:47:00 +02:00
Neil Lalonde
7195a103ab
FEATURE: digests choose topics you're watching or tracking first
2016-08-18 17:16:52 -04:00
Guo Xiang Tan
9a6f54de6c
Allow other directories to be specified when accessing fixtures.
2016-08-18 16:34:43 +08:00
Sam
3ea68f8f6c
tweak headers so they can be consumed
2016-08-18 14:38:33 +10:00
Régis Hanol
45b1f9c0d3
fix smoke test
2016-08-17 23:59:18 +02:00
Régis Hanol
6d1d7b7c8f
UX: new /categories layout
2016-08-17 23:23:16 +02:00
Neil Lalonde
d079f69b7b
FEATURE: add flair to avatars using new settings in the groups admin UI
2016-08-17 15:13:15 -04:00
Sam
a25a8115e8
FEATURE: support HEAD request to /user-api-key/new
...
This allows us to cleanly sniff to find if it exists
2016-08-17 09:58:19 +10:00
Guo Xiang Tan
7ff1f6cb9d
Allow custom bucket name for FileStore::S3Store.
2016-08-16 15:25:42 +08:00
Sam
416e7e0d1e
FEATURE: basic UI to view user api keys
2016-08-16 17:06:52 +10:00
Neil Lalonde
3b792054f2
Merge pull request #4387 from gdpelican/feature/tags-intersection
...
FEATURE: Tags intersection page
2016-08-15 16:24:29 -04:00
Neil Lalonde
5849c345cc
FEATURE: digest emails will try to choose topics from your tracked and watched categories first
2016-08-15 16:16:04 -04:00
James Kiesel
554d15fdd4
Add extra spec for topic_query
2016-08-15 15:42:06 -04:00
James Kiesel
037e9bb7b8
Support any number of tag intersections
2016-08-15 15:30:17 -04:00
Guo Xiang Tan
0433163866
FEATURE: Support subfolders in SiteSetting.s3_backup_bucket.
2016-08-15 16:14:51 +08:00
Sam
fc095acaaa
Feature: User API key support (server side implementation)
...
- Supports throttled read and write
- No support for push yet, but data is captured about intent
2016-08-15 17:59:36 +10:00
Guo Xiang Tan
aa5de3c40a
FEATURE: Support subfolders in S3 bucket name.
...
This commit also fixes a bug where s3 uploads are not
moved to a tombstone folder when removed.
2016-08-15 13:07:41 +08:00
Guo Xiang Tan
3378ee223f
FIX: Incorrect path being passed to S3Store#remove_file.
2016-08-15 11:35:30 +08:00
Robin Ward
aef954784a
FIX: nofollow was being added during post processing when it shouldn't
2016-08-12 15:35:13 -04:00
James Kiesel
7e73b933c7
First pass
2016-08-12 15:28:46 -04:00
Régis Hanol
7db2083d45
FIX: 'cancel_scheduled_job' was deleting all jobs in multisite
2016-08-12 13:10:52 +02:00
Sam
7e4503dd99
FEATURE: basic info route for all sites, even ones that require login
...
This information is public in meta tags already on home page, providing a
route allows consumers to check it way more cheaply
2016-08-12 17:10:35 +10:00
Sam
afaba56de3
FEATURE: missing API endpoint for topic tracking states
2016-08-12 17:10:35 +10:00
Robin Ward
7e165d031b
FIX: Short terms will be searched for if at least one is long enough
2016-08-11 11:53:14 -04:00
Guo Xiang Tan
6075debc90
Add specs to hidding settings when shadowed by a global.
2016-08-11 16:04:45 +08:00
Guo Xiang Tan
11afb20772
SECURITY: Escape HTML in filename.
2016-08-11 11:27:12 +08:00
Guo Xiang Tan
6288d4c995
FIX: Revised post not updated correctly when merging posts.
2016-08-11 09:01:54 +08:00
Robin Ward
fc311dbe3b
FEATURE: An option to search more recent posts for very large sites.
...
On very large forums searching posts can be slow, so this commit
introduces the ability to try and search only the most recent posts
first, and then going for a larger breadth search if there aren't
enough results.
Enable `search_prefer_recent_posts` and you can customize how many
recent posts to filter with `search_recent_posts_size`
2016-08-10 15:43:42 -04:00
Régis Hanol
e55e2aff94
FIX: FirstReplyByEmail badge wasn't granted
...
DEPRECATED: PostProcess badge trigger
2016-08-10 19:24:01 +02:00
Robin Ward
cc366d5a60
FIX: Search in non-english should have a smaller minimum
2016-08-09 15:20:28 -04:00
Robin Ward
28436a604a
FIX: Prevent tricking the search from ignoring minimum lengths
2016-08-09 14:49:46 -04:00
Régis Hanol
282f9948cb
FIX: wasn't able to update category's settings
2016-08-09 20:14:49 +02:00
Sam
5cc8bb535b
SECURITY: do cookie auth rate limiting earlier
2016-08-09 10:02:18 +10:00
Régis Hanol
51322a46b3
FEATURE: retry processing incoming emails on rate limit
2016-08-08 22:28:27 +02:00
Neil Lalonde
17b51bb465
FIX: topics tagged with muted tags should not be included in digest emails
2016-08-08 15:14:25 -04:00
Robin Ward
fb1b119462
Merge pull request #4342 from acshi/embeddedhost-localhost
...
Allow localhost as an embeddable host
2016-08-08 14:31:58 -04:00
Robin Ward
8b252f19d7
Merge pull request #4365 from gdpelican/fix/daily-mlm-notifications
...
Don't halt notification emails for those on daily mailing list mode
2016-08-08 14:30:56 -04:00
Robin Ward
3d62e5dd98
SECURITY: XSS issue on Admin users list
2016-08-05 12:01:16 -04:00
Robin Ward
429f27ec96
SECURITY: Avoid mass assignment on user create
2016-08-05 11:57:13 -04:00
Régis Hanol
d0962d6e5a
FIX: serve category images from the CDN
2016-08-05 13:03:49 +02:00
Robin Ward
e5b529f8e1
FIX: Couldn't move posts with deleted replies
2016-08-04 11:56:01 -04:00
Neil Lalonde
f10c4682cd
FIX: muted tags showing in latest topic list
2016-08-04 11:54:48 -04:00
Neil Lalonde
5f67cd7b45
FIX: tag input detects when a tag is not allowed and won't offer to create it anyway
2016-08-03 13:18:56 -04:00
James Kiesel
c2819e99f4
Don't halt notification emails for those on daily mailing list mode
2016-08-03 12:29:38 -04:00
Régis Hanol
b08ab829b8
added 'X-Auto-Response-Suppress' email header (props to elijah)
2016-08-03 11:02:07 +02:00
Robin Ward
f4c8070d09
FIX: Couldn't update category notification level
2016-08-02 11:22:02 -04:00
Guo Xiang Tan
bf683178a8
FIX: Remove tag plugin code from tag hashtag check.
2016-08-02 10:59:12 +08:00
Régis Hanol
681f566a66
FIX: staff members should be able to see raw email of deleted posts
2016-08-01 23:55:22 +02:00
Régis Hanol
829143bf88
FIX: 'List-Unsubscribe' header wasn't added to emails sent when mailing_list_mode was enabled
2016-08-01 20:19:00 +02:00
Régis Hanol
c591429868
FIX: don't destroy uploads in queued posts and drafts
2016-08-01 18:35:57 +02:00
Sam
9018de39ed
FEATURE: allow shipping bio markdown via SSO
...
- Also adds site setting for sso_overrides_bio to disable bio editing by end users
2016-08-01 15:29:28 +10:00
Neil Lalonde
82e170d6a6
FIX: 404 when filtering by category, no sub-category, and a tag
2016-07-28 16:19:03 -04:00
Robin Ward
2891f230d1
SECURITY: Make sure uploaded_urls have corresponding upload records
2016-07-28 13:54:17 -04:00
Robin Ward
cf5b756b1a
SECURITY: Cross-Site Scripting in Category and Group Settings
2016-07-28 11:57:59 -04:00
Robin Ward
dc1a830d3d
SECURITY: SQL Injection in Admin List Active Users
2016-07-28 11:42:06 -04:00
Robin Ward
2f8ab8cd30
SECURITY: XSS in "Account Suspended" Messages and Badge Descriptions
2016-07-28 11:38:12 -04:00
Sam
16a383ea1e
SECURITY: limit bad cookie auth attempts
...
- Also cleans up the _t cookie if it is invalid
2016-07-28 12:58:49 +10:00
Sam
ab68e0c9db
FEATURE: allow "developer" account flagging via developers table
...
This mechanism for flagging developer accounts will eventually replace
DISCOURSE_DEVELOPER_EMAILS
2016-07-28 10:14:06 +10:00
Sam
c6dbaca0dc
SECURITY: disable user entered badge SQL by default
...
- Hidden site settings now must be change via rails console
2016-07-28 09:03:00 +10:00
Sam
cb3afd11b4
SECURITY: limit route access when using external avatars
2016-07-28 09:00:43 +10:00
Andre Pereira
8cbd585e20
FEATURE: Allow staff users to merge posts.
2016-07-27 12:04:14 +08:00
Robin Ward
2a4006fe0c
Add YandexBot to our list of crawlers
2016-07-26 13:21:37 -04:00
Sam
b5fbff947b
FIX: don't expire old sessions when logging in
2016-07-26 11:37:41 +10:00
Jeff Atwood
1379bd5053
fix all v=2 spec / test errors for emoji
2016-07-25 15:53:48 -07:00
Sam
12ecf8624a
FIX: tokenize words with dots correctly
...
hello.world is now tokenized as "hello.world" and "world" that way the word
"world" will find the post with "hello.world"
2016-07-25 16:26:33 +10:00
Sam
e01802a13b
FIX: strip quote from search term when searching within topic
2016-07-25 15:06:25 +10:00
Sam
df535c6346
FEATURE: refresh session cookie at most once an hour
...
This feature ensures session cookie lifespan is extended
when user is online.
Also decreases session timeout from 90 to 60 days.
Ensures all users (including logged on ones) get expiring sessions.
2016-07-25 12:07:31 +10:00
Acshi Haggenmiller
afa88f68ce
added spec for localhost embeddable host validation
2016-07-22 17:12:57 -04:00
Sam
12dc511fea
PERF: make score calculator cheaper when site has long topics
2016-07-22 09:48:44 +10:00
Robin Ward
c279889191
FIX: Watching First Post in groups was working incorrectly
2016-07-21 15:05:10 -04:00
Neil Lalonde
7c092b0fe0
FEATURE: add filter to show topics that have not been tagged
2016-07-20 16:21:51 -04:00
Robin Ward
09be741820
FIX: Don't alert on new posts in a topic unless it's a new record
2016-07-19 15:57:05 -04:00
Robin Ward
12cfc8cedd
FIX: Email cooker should support links within blockquotes
2016-07-18 14:38:40 -04:00
Robin Ward
6db50b820d
FIX: Email cooker should link links that don't begin a line
2016-07-18 13:46:13 -04:00
Vinoth Kannan
e99a73e16d
New AWS S3 Storage Mumbai region added ( #4335 )
...
* ap-south-1 region added
* Update client.en.yml
* ap-south-1 region added
2016-07-18 09:03:26 +02:00
cpradio
64bdededd3
Allow plugins that implement OAuth and OAuth2 to show up under associated accounts in the Admin area. ( #4333 )
2016-07-18 09:02:41 +02:00
Guo Xiang Tan
d55da4fe1b
Revert "Revert "Update rails.""
...
This reverts commit 4d27d7e1d3
2016-07-18 11:00:23 +08:00
Sam Saffron
46b34e3c62
FEATURE: remove user option for edit history public
...
Users can no longer opt-in for "public" edit history
if site owner disables it.
This feature adds cost and complexity to post rendering since
user options need to be premeptively loaded for every user in the
stream. It is also confusing to explain to communities with private edit
history.
2016-07-16 21:30:00 +10:00
Robin Ward
4d27d7e1d3
Revert "Update rails."
...
This reverts commit 898ec43989
2016-07-15 16:35:57 -04:00
Régis Hanol
caa1aea995
FIX: ensure emojis have absolute URLs and uses CDN
2016-07-15 18:37:51 +02:00
Régis Hanol
7848a84e0e
FIX: ensure summary emails have the 'List-Unsubscribe' header set
2016-07-15 11:39:29 +02:00
Guo Xiang Tan
9353013b40
Merge pull request #4332 from tgxworld/bunch_of_fixes_for_backup
...
Bunch of fixes for backup
2016-07-15 17:26:30 +08:00
Guo Xiang Tan
898ec43989
Update rails.
2016-07-15 13:18:30 +08:00
Guo Xiang Tan
5fe4837e28
Add PostCreator#create!.
2016-07-15 11:36:06 +08:00
Hu Ming
f8a12d4940
Add support for AWS cn ( #4327 )
2016-07-14 16:56:09 +02:00
Guo Xiang Tan
5fed886c8f
FIX: Update post replies when we move posts. ( #4324 )
2016-07-13 17:34:21 +02:00
Guo Xiang Tan
41cbdb5dfa
Fix the build.
2016-07-13 19:14:40 +08:00
Guo Xiang Tan
973a7c9d3a
FIX: Redeeming an invitation fails if inviter has been destroyed.
2016-07-13 11:58:31 +08:00
Robin Ward
bb90129731
Improvements to email cook text rendering
2016-07-12 13:49:03 -04:00
Robin Ward
0c3b049176
FIX: Autolinking in email formatter was broken
2016-07-12 13:33:13 -04:00
Rafael dos Santos Silva
5915929166
FIX: Unicode aware text sentinel ( #4301 )
...
* FIX: Handle unicode text on Text Sentinel
Uses active_support to properly handle unicode text
* Adds test cases to unicode Text Sentinel
2016-07-12 11:08:55 -04:00
Robin Ward
c1d4ca4031
FIX: Raw templates in customizations were broken
2016-07-11 12:57:05 -04:00
Robin Ward
7ff5b228cd
REFACTOR: Raw Handlebars ported to ES6
2016-07-11 12:57:05 -04:00
Robin Ward
a546395397
REFACTOR: Migrate markdown functionality in ES6
2016-07-11 12:57:05 -04:00
Neil Lalonde
304f7040a3
FIX: tag filter dropdown was gone if some tags were restricted to a category.
2016-07-08 17:13:40 -04:00
Arpit Jalan
c626558d36
UX: group pages should not show Messages tab to unauthorised users ( #4318 )
2016-07-09 00:50:04 +05:30
Sam
4161ee210a
FEATURE: improved tag and category watching and tracking
...
- present tags watched on the user prefs page
- automatically watch or unwatch old topics based on watch status
New watching and tracking logic takes care of handling old topics
(either with or without read state)
When you watch a topic you now watch historically
Also removes confusing warnings from user.
2016-07-08 12:58:30 +10:00
Guo Xiang Tan
423dc37f6c
Merge pull request #4315 from tgxworld/fix_tags_not_in_category_showing
...
Tags which are not allowed in a category showing in drop down.
2016-07-08 10:28:10 +08:00
Guo Xiang Tan
8fd0414cdf
WIP: Tags which are not allowed in a category showing in drop down.
2016-07-08 10:27:56 +08:00
Robin Ward
5f91919663
Email support for watching first post
2016-07-07 12:23:19 -04:00
Robin Ward
2005565c9c
Server side code for Watching First Post Only
2016-07-07 11:21:50 -04:00
Robin Ward
1eb64151f6
User interface for watching first post
2016-07-07 11:21:50 -04:00
Arpit Jalan
2facb6190f
FEATURE: new site setting download_remote_images_max_days_old
2016-07-06 19:33:51 +05:30
Robin Ward
3fe4903e63
FIX: Support unicode replacements with multiple codepoints
2016-07-05 13:55:41 -04:00
James Kiesel
3588780ac3
Don't reject likes by email for closed topics ( #4311 )
2016-07-05 17:33:08 +02:00
Guo Xiang Tan
f256e3afb6
Merge pull request #4297 from tgxworld/handle_user_enabled_readonly_mode
...
Handle user enabled readonly mode
2016-07-05 19:54:32 +08:00
Guo Xiang Tan
e4a82cdd85
Merge pull request #4306 from tgxworld/add_discourse_event_trigger_when_user_logs_out
...
FEATURE: Add event trigger when a user is logged out.
2016-07-05 19:50:46 +08:00
Régis Hanol
17890f95a1
FIX: don't send emails to mailing_list users when bounce threshold is reached
2016-07-05 12:20:07 +02:00
Régis Hanol
59680af329
disable email white/blacklisting for staged users
2016-07-04 16:05:01 +02:00
Guo Xiang Tan
22ade1f811
FEATURE: Add event trigger when a user is logged out.
2016-07-04 17:20:30 +08:00
Guo Xiang Tan
bd07658a37
PERF: Split queries when cleaning uploads.
...
This reduces the number of scans that the db has to do in the query
to fetch orphan uploads. Futheremore, we were not batching our
records which bloats memory.
2016-07-04 16:34:32 +08:00
Sam
d61df21d69
FEATURE: allow people to send messages to themselves (for notes etc)
2016-07-04 11:36:43 +10:00
Sam
92daf44daf
correct random suggested topic selection
2016-07-04 10:34:54 +10:00
Sam
e858def372
remove invalid specs
2016-07-04 10:34:26 +10:00
Arpit Jalan
2f3ee3b658
FEATURE: new site setting suggested_topics_max_days_old
2016-07-03 15:07:56 +05:30
Sam
813fcebdd1
FIX: email_always was not respected correctly
...
In the past email always meant, email me even if active UNLESS I read post
Now emails always means, always, even if I read the post
2016-07-01 11:22:07 +10:00
Matt Palmer
7a1e99dacb
Add some clarifying specs around new-topic-creating emails work
...
Strangers get to create new topics (if the appropriate tickbox is ticked)
but low-TL existing users don't. That might seem a bit backwards, but
the tickbox says 'strangers', not 'everyone'.
2016-06-30 22:24:25 +10:00
Sam
b15f6bd211
FIX: s3 cdn urls not remapped correctly
2016-06-30 18:58:38 +10:00
Guo Xiang Tan
8db3ab5f2a
Merge pull request #4292 from tgxworld/rename_use_https_to_force_https
...
Rename `SiteSetting#use_https` to `force_https`.
2016-06-29 15:17:57 +08:00
Guo Xiang Tan
64858c10fe
FIX: Set a not expiring key for user enabled readonly mode.
2016-06-29 15:10:01 +08:00
Guo Xiang Tan
20359788dc
Rename SiteSetting#use_https to force_https.
2016-06-29 15:02:43 +08:00
Guo Xiang Tan
7619c2fa2f
FIX: Make sure we add a TTL when we enable readonly mode.
2016-06-29 13:55:17 +08:00
Sam
ef93e75f80
correct #4293 no need to muck with site settings, messes up repeat runs
2016-06-29 12:01:37 +10:00
Robin Ward
61ce5c210c
FIX: S3Cdn link clicks weren't working
2016-06-28 15:52:38 -04:00
Régis Hanol
214f5bff5c
don't send more than 1 reply per day to auto-generated emails
2016-06-28 16:42:05 +02:00
Sam
1411eedad3
FEATURE: offer to unwatch categories when unwatching category
2016-06-28 18:34:20 +10:00
Régis Hanol
800081f606
FIX: staged users weren't able to reply in restricted categories
2016-06-26 19:25:45 +02:00
Robin Ward
ccf9b70671
When restoring a backup, disable emails.
...
This prevents accidental sending of emails after a restore before
the admin has had a chance to review everything.
2016-06-24 17:15:15 -04:00
Robin Ward
94a4af6af7
FIX: If posts are deleted they should be updated in consistency jobs
2016-06-21 13:05:56 -04:00
James Kiesel
7a6bc3f1d7
Apply notification styles to mailing list email manually ( #4283 )
...
* Apply notification styles to mailing list email manually
* Fix failing spec
2016-06-21 20:42:30 +05:30
Régis Hanol
874c18cbc1
FIX: unstage users when using SSO
2016-06-21 11:28:58 +02:00
Neil Lalonde
487c20959c
FEATURE: max topics/replies per day for new users now starts counting from the first post, not signup date
2016-06-20 16:55:11 -04:00
Régis Hanol
e9a293beeb
FIX: clean up uploads job
2016-06-20 22:05:41 +02:00
Guo Xiang Tan
b3a8f7d369
Merge pull request #4277 from tgxworld/fix_bug_when_post_creator_returns_nil
...
Fix bug when post creator returns nil
2016-06-20 18:15:52 +08:00
Guo Xiang Tan
9a0797204a
FIX: Add check to ensure post has been created.
2016-06-20 15:51:26 +08:00
Guo Xiang Tan
dfdc54957c
FIX: A blocked user should not be able to moderate anything.
2016-06-20 15:51:26 +08:00
Sam
8866169879
FEATURE: can invite/revoke groups on private messages
2016-06-20 16:29:27 +10:00
Robin Ward
83e46cc302
FIX: Restrict changing ownership to one topic
2016-06-17 14:20:14 -04:00
Sam
dd1a184955
Correct mailing list mode unsubscribe
2016-06-17 11:57:23 +10:00
Sam
852860de66
FEATURE: simpler and friendlier unsubscribe workflow
...
- All unsubscribes go to the exact same page
- You may unsubscribe from watching a category on that page
- You no longer need to be logged in to unsubscribe from a topic
- Simplified footer on emails
2016-06-17 11:28:49 +10:00
Robin Ward
84f0e5ad4d
SECURITY: Unapproved, active users should not receive emails
2016-06-16 12:55:47 -04:00
Neil Lalonde
d62f2b4d67
UX: rename setting num_flags_to_block_new_user to num_spam_flags_to_block_new_user
2016-06-15 13:19:06 -04:00
Guo Xiang Tan
169d17edc3
Include cdn path in the stylesheet digest.
2016-06-16 00:19:38 +08:00
Neil Lalonde
1c9519636c
FEATURE: new users can be blocked from posting if enough TL3 users flag their posts
2016-06-15 10:51:34 -04:00
Guo Xiang Tan
bf64280661
FIX: Incorrect scope when checking for existing topic link.
2016-06-15 14:13:30 +08:00
Régis Hanol
470da6205c
FIX: staged users should not watch/track/mute categories by default
2016-06-14 16:45:47 +02:00
Régis Hanol
49f8a2baa7
FEATURE: support for mandrill webhooks
2016-06-13 12:32:14 +02:00
Guo Xiang Tan
95efdce74f
Improve spec.
2016-06-13 13:16:24 +08:00
Guo Xiang Tan
1fe499e893
FIX: Don't include reflections when checking for duplication topic links.
2016-06-13 13:14:35 +08:00
Guo Xiang Tan
0c8dd28395
FIX: Post count wasn't recovered when a post is recovered.
2016-06-13 11:25:06 +08:00
Robin Ward
3b9b492ea6
FIX: Weird spec
2016-06-10 11:32:32 -04:00
Régis Hanol
dffe50a2e6
new alternative reply by email addresses
2016-06-10 16:14:42 +02:00
Sam
65f466cf8c
FIX: topic link reflections deleted on second save
2016-06-10 17:25:59 +10:00
Sam
3015030fe2
FIX: unlisted topics do not get "slug auto correct" logic
2016-06-10 10:53:26 +10:00
Neil Lalonde
a6090339a7
FEATURE: tag group options: limit usage of one tag per group, tags in a group can't be used unless a prerequisite tag is used
2016-06-09 16:01:19 -04:00
Robin Ward
c3ad0f447a
FIX: Broken spec
2016-06-09 14:31:32 -04:00
Neil Lalonde
5047979f96
FIX: cannot remove tags from a topic
2016-06-09 12:04:34 -04:00
Guo Xiang Tan
ff577405ae
FIX: Randomly failing TopicList specs.
2016-06-09 22:03:13 +08:00
Régis Hanol
214e25f1b5
use proper 'Message-Id' field
2016-06-09 00:33:13 +02:00
Régis Hanol
3e3538d603
loosen security a bit on mailgun's webhook
2016-06-08 22:38:38 +02:00
Robin Ward
e38f17524b
FIX: Reflected links weren't being cleaned up properly
2016-06-08 16:09:01 -04:00
Robin Ward
b9df18360d
If you search a category by id, also include its children
2016-06-08 13:50:52 -04:00
Robin Ward
2169b1ecbc
FIX: Duplicate link message should link to the post
2016-06-08 12:35:11 -04:00
Arpit Jalan
40e9e1be66
FEATURE: user-friendly custom message
2016-06-08 18:23:22 +05:30
Neil Lalonde
a49ace0ffb
FEATURE: ability to restrict tags to categories using groups
2016-06-07 15:36:20 -04:00
Robin Ward
431179dd25
FEATURE: Prompt users when they are entering duplicate links
2016-06-07 14:47:22 -04:00
Robin Ward
6aaa484baa
REFACTOR: Move composer messages to store
2016-06-07 14:47:22 -04:00
Arpit Jalan
4253141700
FEATURE: custom email message for topic invites
2016-06-07 23:43:15 +05:30
Jeff Atwood
cc66bff730
we forgot to update the mailgun tests
2016-06-06 16:55:24 -07:00
Jeff Atwood
5c3e36aec2
Merge pull request #4252 from techAPJ/invite-email-improvements
...
FEATURE: customize invite email message
2016-06-06 14:24:39 -07:00
Neil Lalonde
f3f6c2f98f
FEATURE: tag groups
2016-06-06 14:18:48 -04:00
Régis Hanol
fe595f1653
FEATURE: mailjet webhook
2016-06-06 19:47:45 +02:00
Arpit Jalan
7b205ebba4
FEATURE: customize invite email message
2016-06-06 20:15:30 +05:30
Guo Xiang Tan
ecb2a0b9c7
Skip tests for now.
2016-06-06 18:18:12 +08:00
Guo Xiang Tan
bb92be5784
Clean up Redis after each test.
2016-06-06 17:32:09 +08:00
Régis Hanol
99ad251731
different email footer when mailing_list_mode is enabled
2016-06-03 15:48:54 +02:00
Arpit Jalan
a166869d67
FEATURE: search fallback to tags when category not found
2016-06-02 18:14:41 +05:30
Sam
e01dc54f2a
UX: we should always simply use emoji codes as opposed to treating as image
2016-06-02 12:29:25 +10:00
Régis Hanol
9704603fab
FEATURE: sendgrid webhooks
2016-06-01 21:48:06 +02:00
Neil Lalonde
0f8b4dcc86
FIX: trust level 3 should not be able to edit topics in categories that restrict them from doing so
2016-06-01 15:42:10 -04:00
Neil Lalonde
deb93044b4
FEATURE: new tags can be created from the "edit category" modal when defining the set of permitted tags
2016-05-31 17:27:22 -04:00
Robin Ward
6da097d91c
FIX: Deleted posts were showing the wrong dates in the timeline
2016-05-31 10:51:55 -04:00
Robin Ward
559fa36c18
FEATURE: Topic timeline widget
2016-05-31 10:51:39 -04:00
Neil Lalonde
6796b15857
FEATURE: restrict tags to be used in a category
2016-05-30 16:56:33 -04:00
Régis Hanol
116efffdaa
FEATURE: webhooks support for mailgun
2016-05-30 17:11:17 +02:00
Sam
3eec0a83b0
clean up stop semantics and bypass test
2016-05-30 13:59:58 +10:00
Guo Xiang Tan
cb5be1fe8f
Upgrade rspec to 3.4.0.
2016-05-30 11:38:38 +08:00
Sam
e11c83341c
add more specs
2016-05-30 12:43:01 +10:00
Sam
cc088956bc
correct some test concurrency bugs
2016-05-30 12:28:05 +10:00
Sam
c9dcffe434
FEATURE: store history for scheduled job execution
2016-05-30 11:38:08 +10:00
Sam
efc45aa704
correct specs
2016-05-27 12:35:22 +10:00
Neil Lalonde
884779b5c1
FIX: N+1 query when tagging enabled and no tags in topic list query. Topic query ignored tags input when tagging is disabled.
2016-05-26 18:03:50 -04:00
Neil Lalonde
f13470b96b
Use db schema for tags instead of plugin store and custom fields
2016-05-26 14:29:48 -04:00
David McClure
a92fd9d701
Add Site Setting to use HTML from incoming email when available. ( #4236 )
2016-05-26 10:13:01 +02:00
Neil Lalonde
a4cd068481
FEATURE: add caps to trust level 3 requirements for posts read and topics viewed, configurable in settings
2016-05-25 14:55:49 -04:00
Sam
a19e43fd3b
enough with the malloc limit, not needed
2016-05-25 21:09:07 +10:00
Sam
b3965eb069
was failing on latest phantom, fix test
2016-05-24 13:26:07 +10:00
Régis Hanol
667dd54a23
FEATURE: new 'crop_tall_images' site setting
2016-05-23 16:18:30 +02:00
Guo Xiang Tan
3a140a982f
Fix build.
2016-05-23 11:22:25 +08:00
Sam
695773db1c
FEATURE: upgrade from therubyracer to mini_racer
...
This pushes our internal V8 JavaScript engine from Chrome 32 to 50.
It also resolves some long standing issues we had with the old wrapper.
2016-05-23 09:57:15 +10:00
Arpit Jalan
f387dfe226
FIX: mixed case group mentions were not getting highligted in composer
2016-05-22 18:32:49 +05:30
James Kiesel
feffe23cc5
FEATURE: More granular mailing list mode ( #4068 )
...
* Rearrange frontend to account for mailing list mode
* Allow update of user preference for mailing list frequency
* Add mailing list frequency estimate
* Simplify frequency estimate; disable activity summary for mailing list mode
* Remove combined updates
* Add specs for enqueue mailing list mode job
* Write mailing list method for mailer
* Fix linting error
* Account for stale topics
* Add translations for default mailing list setting
* One query for mailing list topics
* Fix failing spec
* WIP
* Flesh out html template
* First pass at text-based mailing list summary
* Add user avatar
* Properly format posts for mailing list
* Move make_all_links_absolute into Email::Styles
* Apply first_seen_at to user
* Send mailing list email summary hourly based on first_seen_at
* Branch and test cleanup
* Use existing mailing list mode estimate
* Fix failing specs
2016-05-21 15:17:54 +02:00
Régis Hanol
c75d58ab21
FEATURE: new 'ignore_by_title' site setting
2016-05-18 23:07:01 +02:00
Guo Xiang Tan
e3e31441b8
FIX: Random Redis connection timeout failure in Travis.
2016-05-18 10:42:40 +08:00
Guo Xiang Tan
b68860ee28
FIX: Do not send email when user of the post has been deleted. ( #4228 )
2016-05-17 17:42:15 +02:00
Sam
b04ab83f12
FIX: refresh automatic group if SSO specifies admin/mod
2016-05-17 17:31:34 +10:00
Régis Hanol
5f76287b18
FEATURE: cap number of staged users (defaults to 10) created per incoming email
2016-05-16 21:45:34 +02:00
Guo Xiang Tan
4e59ec5a60
Fix the build.
2016-05-16 18:22:03 +08:00
Guo Xiang Tan
96f07053b2
FIX: Ensure unique fields in TopicList.preloaded_custom_fields.
2016-05-16 17:56:00 +08:00
Régis Hanol
6137bb46d3
FIX: a User is *not* a Topic
2016-05-14 10:06:29 +02:00
Arpit Jalan
5b030017d9
FEATURE: new search filter in:wiki
2016-05-13 13:56:53 +05:30
Arpit Jalan
00893ef1de
FEATURE: new search filter - @username
2016-05-12 14:26:26 +05:30
Arpit Jalan
2e0350ee74
FEATURE: new search filter - #category-slug
2016-05-11 15:37:27 +05:30
Robin Ward
49a6d0b789
FIX: Don't bother with negative offsets
2016-05-09 16:33:55 -04:00
Konrad Borowski
9d737d894d
FIX: Don't diplay character reference in HTML diffs ( #4204 )
...
* FIX: Don't diplay character reference in HTML diffs
Before this change, HTML escaping was done before splitting text into
tokens, so token splitter saw literals like "'", and split them as
it was normal text into parts into ["&", "#", "39", ";"]. This caused
diff to display character references, as those tokens used separate
HTML tags to display their insertion/deletion status.
* Avoid making one element arrays while generating diffs
2016-05-09 08:44:21 +02:00
Sam
7c888c9a77
Merge pull request #4062 from xfalcox/patch-6
...
FIX: Properly downcase unicode chars
2016-05-08 21:39:00 +10:00
Régis Hanol
aa5ea719ee
fix build
2016-05-06 19:50:44 +02:00
Régis Hanol
1e57bbf5c8
Lots bounce emails related fixes
...
- Show bounce score on user admin page
- Added reset bounce score button on user admin page
- Only whitelisted email types are sent to emails with high bounce score
- FIX: properly detect bounces even when there is no TO: header in the email
- Don't desactivate a user when reaching the bounce threshold
2016-05-06 19:34:33 +02:00
Arpit Jalan
53809d526c
FIX: show proper error message when no user selected for private message
2016-05-05 18:47:08 +05:30
Arpit Jalan
b25d950d99
FEATURE: allow moderators to convert a private message to public topic or vice versa
2016-05-04 22:47:32 +05:30
Arpit Jalan
9427e0c732
FIX: bootstrap mode should not amend setting that is not in default state
2016-05-04 16:46:46 +05:30
Arpit Jalan
82daf93eb3
Merge pull request #4206 from techAPJ/convert-topic
...
FEATURE: move a topic from PM to regular topic or vice versa
2016-05-04 01:33:15 +05:30
Régis Hanol
df14926e42
SECURITY: check magic bytes before using ImageMagick tools
2016-05-03 21:54:07 +02:00
Robin Ward
b061ba5c52
FIX: Broken spec. Stupid mocking.
2016-05-03 15:30:48 -04:00
Régis Hanol
8e611ec7a1
FEATURE: handle bounced emails
2016-05-02 23:15:32 +02:00
Arpit Jalan
acfb540952
FEATURE: move a topic from PM to regular topic or vice versa
2016-05-02 21:34:05 +05:30
Sam
d25dc126f7
FIX: Post does not save if it contains a tag link
2016-05-02 11:36:09 +10:00
Arpit Jalan
7151c16c79
FEATURE: create permalink when category slug is changed
2016-04-27 17:34:03 +05:30
Robin Ward
de82bd946d
FIX: Group members should be able to see their groups even if private
2016-04-26 14:17:53 -04:00
Arpit Jalan
74b3807f60
FEATURE: new bootstrap mode settings for brand new Discourse community ( #4193 )
...
* FEATURE: new bootstrap mode settings for brand new Discourse community
* new SiteSetting.set_and_log method
2016-04-26 13:08:19 -04:00
Régis Hanol
84d4ebd910
use 'reply_by_email_address' setting for handling bounce emails using VERP
2016-04-25 20:06:45 +02:00
shaktikatare1989
d1f61015c0
Fix: Editing a topic with an invalid title will still push it to the top ( #4185 )
...
* fix: Editing a topic with an invalid title will still push it to the top
* add specs to check topic not bumped with invalid title
2016-04-25 10:33:38 +02:00
Guo Xiang Tan
b4e0c5afe0
FIX: Fetch stats if it has not been cached.
2016-04-21 14:50:25 +08:00
Neil Lalonde
cf1fefe236
add more specs for Image Lightbox on Subfolder Install
2016-04-20 15:42:40 -04:00
Régis Hanol
4960b62110
FEATURE: new 'block_auto_generated_emails' site setting
2016-04-20 21:29:27 +02:00
Neil Lalonde
f62ffce03b
Merge pull request #4053 from xfalcox/patch-5
...
FIX: Image Lightbox on Subfolder Install
2016-04-20 15:16:35 -04:00
Régis Hanol
7d9f2265b9
FIX: improve support for handling emails coming from screened email addresses
2016-04-18 23:01:54 +02:00
Régis Hanol
de9136a8f2
FIX: bypass TL0-specific validations on posts in a PM
2016-04-18 22:08:42 +02:00
Sam
fad017d842
FEATURE: add support for bounce emails
...
We now optionally add a Variable Email Return Path to every email we send.
This allows us to cleanly handle email bounces, which in turn will improve
deliverability.
2016-04-18 17:14:01 +10:00
Guo Xiang Tan
36e3f1f5e4
FIX: Reset state of DiscourseRedis::FallbackHandler in tests.
2016-04-18 10:41:40 +08:00
