osr-discourse-src

osr-plastic/osr-discourse-src

Archived

Fork 0

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Martin Brennan	dbfe9540fa	FIX: be more tactical with replacing markdown chars * instead of using encodeURIComponent in imageNameFromFileName, we just replace the bad characters that we wanted to get rid of in the first place where we introduced encodeURIComponent. as per review	2019-11-25 16:38:13 +10:00
Martin Brennan	b89e634dd4	FIX: Replace %20 with space in markdown file name for uploads (#8405 ) Meta: https://meta.discourse.org/t/image-name-has-20-in-file-name/134136 We were ending up with [file%20name](url) in the markdown preview, which looked weird and affected the alt text. this is because we were calling encodeURIComponent, which has been left in place because this is a valid thing to do for some cases. (e.g. `f674b9e`)	2019-11-25 13:54:55 +10:00
Robin Ward	d4b7c028fa	REFACTOR: Move upload utilities to their own file	2019-11-14 12:51:08 -05:00

Martin Brennan

dbfe9540fa

FIX: be more tactical with replacing markdown chars

* instead of using encodeURIComponent in imageNameFromFileName,
  we just replace the bad characters that we wanted to get rid
  of in the first place where we introduced encodeURIComponent.
  as per review

2019-11-25 16:38:13 +10:00

Martin Brennan

b89e634dd4

FIX: Replace %20 with space in markdown file name for uploads (#8405 )

Meta: https://meta.discourse.org/t/image-name-has-20-in-file-name/134136

We were ending up with [file%20name](url) in the markdown preview, which looked weird and
affected the alt text. this is because we were calling encodeURIComponent, which has been left in place because this is a valid thing to do for some cases. (e.g. f674b9e)

2019-11-25 13:54:55 +10:00

Robin Ward d4b7c028fa REFACTOR: Move upload utilities to their own file 2019-11-14 12:51:08 -05:00

3 Commits