03d32f26bb
Recent changes surfaced the various issues with this codepath: - we were not correctly reseting `messageLookup` leading to us trying to scroll to a non existing message in the view - we were calling markAsRead which would scroll to the bottom, even if we had a target message - we were not debouncing fetchMessages, which could cause multiple reload of the messages when loading it with a targetMessageId: first fetch from last read and then immediately fetch from targetMessageId - other naming inconsistencies - not handling drawer This commit also adds tests for classic scenarios related to this use case. |
||
|---|---|---|
| .. | ||
| list_channels | ||
| page_objects | ||
| shortcuts | ||
| user_menu_notifications | ||
| user_status | ||
| anonymous_spec.rb | ||
| archive_channel_spec.rb | ||
| bookmark_message_spec.rb | ||
| browse_page_spec.rb | ||
| channel_about_page_spec.rb | ||
| channel_info_pages_spec.rb | ||
| channel_members_page_spec.rb | ||
| channel_selector_modal_spec.rb | ||
| channel_settings_page_spec.rb | ||
| chat_channel_spec.rb | ||
| chat_composer_spec.rb | ||
| closed_channel_spec.rb | ||
| create_channel_spec.rb | ||
| deleted_channel_spec.rb | ||
| edited_message_spec.rb | ||
| flag_message_spec.rb | ||
| hashtag_autocomplete_spec.rb | ||
| jit_messages_spec.rb | ||
| message_notifications_mobile_spec.rb | ||
| message_notifications_with_sidebar_spec.rb | ||
| move_message_to_channel_spec.rb | ||
| navigating_to_message_spec.rb | ||
| navigation_spec.rb | ||
| network_reconciliation_spec.rb | ||
| react_to_message_spec.rb | ||
| read_only_spec.rb | ||
| replying_indicator_spec.rb | ||
| sidebar_navigation_menu_spec.rb | ||
| sidebars_spec.rb | ||
| silenced_user_spec.rb | ||
| transcript_spec.rb | ||
| unfollow_dm_channel_spec.rb | ||
| uploads_spec.rb | ||
| user_card_spec.rb | ||
| user_chat_preferences_spec.rb | ||
| visit_channel_spec.rb | ||