This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse
David Taylor 1844bde57c
FIX: Allow mobile-nav to work without loading transitions (#12184)
Previously, the `{{mobile-nav}}` component required a `currentRouteName` property, passed from the router service. It would observe changes in this property, and update the UI accordingly.

If we change between routes which have the same `currentRouteName` (e.g. two different group message inboxes), then the `currentRouteName` does not change and does not trigger the observer. Currently in core, we are relying on the fact that currentRouteName temporarily enters a `.loading` substate during a transition. This will change when we remove the loading substate in the near future.

This commit refactors `{{mobile-nav}}` to inject the router directly, and use the `routeDidChange` event instead of an observer. The change is backwards compatible, but plugins passing the old `currentPath` property will be shown a deprecation notice.
2021-02-23 11:16:40 +00:00
..
app FIX: Allow mobile-nav to work without loading transitions (#12184) 2021-02-23 11:16:40 +00:00
config Sync up master with Ember CLI branch where possible (#11707) 2021-01-14 12:52:51 -05:00
public/assets/scripts DEV: Live reload styles in Ember CLI (#12043) 2021-02-11 10:36:34 -05:00
tests UX: Allow select-kit to have an autofocus option (#12183) 2021-02-23 13:20:32 +03:00
.ember-cli REFACTOR: Sync up master with changes for Ember-CLI (#11671) 2021-01-12 10:13:21 -05:00
ember-cli-build.js Sync up master and Ember CLI branches again (#11746) 2021-01-18 16:12:45 -05:00
package.json Sync up master and Ember CLI branches again (#11746) 2021-01-18 16:12:45 -05:00
testem.js Sync up master and Ember CLI branches again (#11746) 2021-01-18 16:12:45 -05:00
yarn.lock DEV: Migrate to Ember CLI (#11932) 2021-02-03 14:22:20 -05:00