f0b2e77abb
This change makes is so that when a time-picking modal (e.g. "Add bookmark" modal) is visible, **all** global key bindings are paused. 1. Fixes an issue where opening and closing a time-picking modal would break global single-key keybinds, so for example, <kbd>L</kbd> would no longer like posts, but <kbd>L</kbd> <kbd>L</kbd> would 2. Fixes a related issue, where doing the above would also override custom keybinds provided by plugins (e.g. <kbd>L</kbd> shortcut that discourse-reactions uses) Included: * DEV: Reset Mousetraps instead of unbinding * FIX: Make unbind use unbind * DEV: Don't check for keyTrapper twice * DEV: Use an instance of Mousetrap * DEV: Remove an invalid `for` attribute (`set_reminder` doesn't exist) * DEV: Add ability to pause all KeyboardShortcuts * FIX: Pause all keybinds when in a time-picking modal * DEV: Move bookmark keybind resets to willDestroyElement * DEV: Fix shortcuts-related tests |
||
|---|---|---|
| .. | ||
| select-kit | ||
| ace-editor-test.js | ||
| activation-controls-test.js | ||
| admin-report-test.js | ||
| badge-title-test.js | ||
| bookmark-test.js | ||
| cook-text-test.js | ||
| d-button-test.js | ||
| d-editor-test.js | ||
| d-icon-test.js | ||
| date-input-test.js | ||
| date-time-input-range-test.js | ||
| date-time-input-test.js | ||
| group-list-setting-test.js | ||
| highlighted-code-test.js | ||
| html-safe-helper-test.js | ||
| iframed-html-test.js | ||
| image-uploader-test.js | ||
| invite-panel-test.js | ||
| load-more-test.js | ||
| relative-time-picker-test.js | ||
| secret-value-list-test.js | ||
| simple-list-test.js | ||
| site-header-test.js | ||
| slow-mode-info-test.js | ||
| text-field-test.js | ||
| themes-list-item-test.js | ||
| themes-list-test.js | ||
| time-input-test.js | ||
| topic-list-item-test.js | ||
| topic-list-test.js | ||
| user-selector-test.js | ||
| value-list-test.js | ||