This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/tests
Isaac Janzen 92bb728fe5
DEV: Add search suggestions for tag-intersections (#19777)
Added `tagIntersection` search context for handling search suggestions on tag intersection and tag+category routes.

# Tag & Category Route Search Suggestions
eg. /tags/c/general/5/updates
### Before
<img width="422" alt="Screenshot 2023-01-06 at 2 58 50 PM" src="https://user-images.githubusercontent.com/50783505/211098933-ade438c6-5008-49ce-9a90-c8200ec5fe00.png">

### After
<img width="359" alt="Screenshot 2023-01-06 at 3 00 35 PM" src="https://user-images.githubusercontent.com/50783505/211099183-c3feaeac-8661-47ed-843c-da9d9fb78e9e.png">

# Tag Intersection Route Search Suggestions
eg. /tags/intersection/updates/foo
### Before
<img width="421" alt="Screenshot 2023-01-06 at 3 02 23 PM" src="https://user-images.githubusercontent.com/50783505/211099435-e8fc6d87-2772-45b5-b455-1831f80eab3a.png">

### After
<img width="362" alt="Screenshot 2023-01-09 at 2 02 09 PM" src="https://user-images.githubusercontent.com/50783505/211397349-acb350f7-8e6a-4d9f-a749-8292e49400d9.png">

I defaulted to using `+` as a separator for tag intersections. The reasoning behind this is that we don't make the tag intersection routes easily accessible, so if you are going out of your way to view multiple tags, you are most likely going to be searching by **both** of those tags as well.

# General Search
Introducing flex wrap removes whitespace causing a [test](https://github.com/discourse/discourse/pull/19777/files#diff-5d3d13fabc1a511635eb7471ffe74f4d455d77f6984543c2be6ad136dfaa6d3aR813) to fail, but to remedy this I added spacing to the `.search-item-prefix` and `.search-item-slug` which achieves the same thing.

### After
<img width="359" alt="Screenshot 2023-01-09 at 2 04 54 PM" src="https://user-images.githubusercontent.com/50783505/211397900-60220394-5596-4e13-afd0-b6130afa0de2.png">
2023-01-11 13:02:22 -06:00
..
acceptance DEV: Add search suggestions for tag-intersections (#19777) 2023-01-11 13:02:22 -06:00
addons/truth-helpers/integration/helpers DEV: adds includes helper to templates (#18259) 2022-09-15 14:20:37 +02:00
fixtures DEV: Remove user options from current user serializer (#19089) 2022-12-05 18:25:30 +02:00
helpers DEV: Deprecate controllerFor test helper (#19606) 2022-12-23 11:33:42 +01:00
integration FIX: DButton ellipsis argument (#19640) 2022-12-28 14:03:58 +00:00
unit FIX: Avoid race conditions when toggling presence state (#19648) 2022-12-29 00:44:31 +00:00
index.html DEV: Update Twitter meta tags while navigating in app (#19468) 2022-12-14 14:33:09 -05:00
setup-tests.js DEV: Drop helper context setup in tests (#19423) 2022-12-12 15:20:48 +01:00
test-boot-ember-cli.js DEV: Make the setupTests a regular import (#19046) 2022-11-16 16:11:18 +08:00