Alan Guo Xiang Tan 24db6fbb73
PERF: Memoize topic level checks in PostGuardian ( #19647 ) ...
When loading posts in a topic, the topic level guardian
checks are run multiple times even though all the posts belong to the
same topic. Profiling in production revealed that this accounted for a
significant amount of request time for a user that is not staff or anon.
Therefore, we're optimizing this by adding memoizing the topic level
calls in `PostGuardian`. Speficifally, the result of
`TopicGuardian#can_see_topic?` and `PostGuardian#can_create_post?`
method calls are memoized per topic.
Locally profiling shows a significant improvement for normal users
loading a topic with 100 posts.
Benchmark script command: `ruby script/bench.rb --unicorn --skip-bundle-assets --iterations 100`
Before:
```
topic user:
50: 114
75: 117
90: 122
99: 209
topic.json user:
50: 67
75: 69
90: 72
99: 162
```
After:
```
topic user:
50: 101
75: 104
90: 107
99: 184
topic.json user:
50: 53
75: 53
90: 56
99: 138
```
2023-01-03 09:00:42 +08:00
2022-04-28 11:51:03 +02:00
2022-11-24 06:46:06 +03:00
2022-07-11 22:29:33 +02:00
2022-08-24 01:43:42 +02:00
2022-04-28 11:51:03 +02:00
2022-09-29 20:00:38 +02:00
2022-12-08 10:36:20 +00:00
2022-02-04 16:28:20 +00:00
2022-07-25 11:54:43 -03:00
2022-12-16 18:42:51 +02:00
2022-06-21 15:49:47 -03:00
2022-01-14 17:51:13 -03:00
2022-01-05 18:45:08 +01:00
2022-10-06 13:44:53 +01:00
2022-12-28 10:30:20 +08:00
2022-11-24 12:13:59 +00:00
2021-08-20 11:29:06 +02:00
2023-01-03 09:00:42 +08:00
2022-04-28 11:51:03 +02:00
2022-05-10 10:02:28 -05:00
2022-10-05 15:22:16 -04:00
2022-12-14 18:56:46 +01:00
2022-12-22 08:13:43 -05:00
2022-04-28 11:51:03 +02:00
2022-12-16 09:59:40 -05:00
2022-12-21 19:02:40 +02:00
2022-12-19 11:05:37 +10:00
2021-11-17 23:27:30 +03:00
2022-04-28 11:51:03 +02:00
2022-05-24 11:31:24 -04:00
2022-04-13 15:04:09 +03:00
2022-11-14 11:09:57 -07:00
2022-12-16 17:07:18 -03:00
2022-11-07 16:13:35 +00:00
2022-12-30 11:35:40 +00:00
2022-12-01 10:50:06 -06:00
2022-11-01 14:05:13 -05:00
2022-12-28 10:47:57 +00:00
2022-11-14 11:09:57 -07:00
2022-12-19 17:24:09 -07:00
2022-02-17 12:12:59 +03:00
2022-02-07 21:05:19 +03:00
2022-05-04 14:07:22 -03:00
2022-10-13 16:04:42 +01:00
2022-08-24 01:43:42 +02:00
2020-04-30 16:48:53 +10:00
2021-07-27 16:32:59 +10:00
2021-05-21 11:43:47 +10:00
2022-12-16 08:50:31 +10:00
2022-09-01 13:04:00 +03:00
2022-05-23 10:07:15 +10:00
2021-10-27 11:39:28 +03:00
2021-11-25 16:58:39 -03:00
2022-03-19 11:00:06 +01:00
2022-04-28 11:51:03 +02:00
2022-11-22 21:11:53 +01:00
2020-10-09 12:51:24 +01:00
2021-06-21 11:06:58 +08:00
2022-11-25 12:40:31 +11:00
2022-11-25 12:40:31 +11:00
2021-03-22 19:41:42 +02:00
2022-04-28 11:51:03 +02:00
2022-05-31 15:24:04 +10:00
2022-05-31 15:24:04 +10:00
2021-06-14 20:34:44 +05:30
2021-08-10 10:25:15 -04:00
2021-12-02 09:33:03 -06:00
2022-03-03 09:24:58 +08:00
2022-10-18 18:20:10 +01:00
2022-12-19 13:46:17 +10:00
2022-12-08 06:48:44 +08:00
2022-08-22 09:56:39 +01:00
2022-12-15 13:01:44 +10:00
2022-12-23 15:41:30 +03:00
2022-12-22 08:13:43 -05:00
2022-02-17 14:52:14 +00:00
2022-04-05 19:29:58 +02:00
2022-12-13 17:27:13 -05:00
2021-05-19 13:57:21 +04:00
2021-02-02 17:34:00 +01:00
2022-09-30 00:49:17 +03:00
2022-02-17 21:49:22 -05:00
2022-09-21 12:38:02 +01:00
2022-12-01 10:56:16 +10:00
2022-05-10 11:14:26 +10:00
2022-01-21 17:54:18 +02:00
2022-06-17 11:50:30 +01:00
2022-11-30 14:21:09 -06:00
2021-11-11 12:21:25 -06:00
2022-05-19 21:56:55 +02:00
2022-11-01 16:33:17 +00:00
2022-02-17 12:12:59 +03:00
2022-01-04 10:14:33 +10:00
2022-12-20 13:11:14 +10:00
2022-09-21 19:08:21 -03:00
2020-10-22 12:50:22 +08:00
2021-11-17 23:27:30 +03:00
2020-04-30 16:48:53 +10:00
2022-10-25 10:57:03 +02:00
2020-07-22 18:00:07 +01:00
2022-10-05 15:22:16 -04:00
2022-05-26 14:01:44 +10:00
2022-06-17 19:34:08 +02:00
2022-01-05 18:45:08 +01:00
2021-03-19 17:48:30 +10:00
2022-02-03 10:00:28 +00:00
2022-04-06 11:09:12 +01:00
2021-09-24 11:55:15 +03:00
2021-11-12 08:52:59 -06:00
2022-07-13 06:37:38 +03:00
2022-04-06 17:10:51 +02:00
2022-11-30 12:42:15 +10:00
2022-02-03 16:19:30 +11:00
2020-04-30 16:48:53 +10:00
2022-03-07 13:20:43 +08:00
2022-04-28 11:51:03 +02:00
2022-09-22 14:44:27 +02:00
2022-05-09 17:23:39 -03:00
2022-04-28 11:51:03 +02:00
2022-12-07 14:35:13 -05:00
2022-11-29 14:18:07 -03:00
2021-08-26 15:16:35 +10:00
2021-04-27 18:24:27 +02:00
2022-11-21 13:11:29 -03:00
2022-02-28 10:20:58 +08:00
2022-12-09 10:34:25 +10:00
2022-08-29 13:00:48 +03:00
2022-05-12 10:07:43 -05:00
2022-12-30 07:25:11 +08:00
2022-05-17 13:06:08 -05:00
2022-05-10 08:19:02 +10:00
2022-04-28 11:51:03 +02:00
2022-12-28 10:30:20 +08:00
2022-07-01 10:18:24 +02:00
2022-04-28 11:51:03 +02:00
2022-11-07 12:53:14 +00:00
2022-11-22 21:41:22 +01:00
2022-12-12 17:57:20 +02:00
2022-11-10 12:43:56 +01:00
2022-06-21 09:23:36 +08:00
2021-06-04 09:13:18 +08:00
2022-12-08 09:44:29 +08:00
2021-01-12 17:28:33 +02:00
2020-07-27 10:23:54 +10:00
2021-11-17 23:27:30 +03:00
2022-12-15 20:12:53 +03:00
2022-05-30 14:01:21 +01:00
2022-08-04 16:15:06 -05:00
2021-06-23 07:38:43 +03:00
2022-11-25 10:56:59 -03:00
2021-05-21 11:43:47 +10:00
2022-12-07 14:24:03 +00:00
2021-06-21 11:06:58 +08:00
2021-11-22 13:16:56 +01:00
2021-11-22 13:16:56 +01:00
2022-09-02 18:28:18 +02:00
2021-01-25 11:30:59 +01:00
2022-02-07 09:21:14 +08:00
2022-12-01 10:26:35 +00:00
2020-07-24 10:11:30 +08:00
2022-07-20 19:07:18 +03:00
2022-11-01 16:17:17 -06:00
2022-12-29 10:07:03 -06:00
2021-03-15 11:58:53 -03:00
2022-09-29 09:24:33 +10:00
2023-01-03 08:17:52 +08:00
2022-06-30 10:18:12 +10:00
2022-08-29 13:00:48 +03:00
2021-12-07 13:07:45 -06:00
2022-08-21 19:26:24 +02:00
2020-07-21 15:55:03 +08:00
2022-06-30 10:18:12 +10:00
2022-09-29 09:24:33 +10:00
2022-02-14 15:48:27 +10:00
2021-10-05 11:25:00 -04:00
2022-10-07 11:00:44 -04:00
2022-09-29 09:24:33 +10:00
2022-08-04 10:16:54 +10:00
2022-12-22 05:30:29 +08:00
2021-12-21 21:13:05 +04:00
2021-10-25 12:53:50 +01:00
2022-11-29 10:59:53 -06:00
2022-02-08 14:07:47 +02:00
2022-08-09 21:52:39 +05:30
Alan Guo Xiang Tan
24db6fbb73