This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app
Blake Erickson 367de2594d
FIX: Unlike own posts on ownership transfer (#10446)
* FIX: Unlike own posts on ownership transfer

If a user has liked a post that has passed the
`post_undo_action_window_mins` system setting window and you transfer ownership
of that post to that user you will be the owner of a post that you have
liked, but cannot unlike resulting in a weird UI behavior. This commit
fixes this issue.

The existing tests didn't check for the timeout window for unliking
posts so I added that in.

I couldn't find a good way to do this logic inside of the guardian class
so rather than duplicating behavior of the `PostActionDestroyer` class
inside of the `PostOwnerChanger` I decided to pass in a "bypass"
variable that could be used to check if the calling class is the
'post_owner_changer' and bypass the guardian instead. I went this route
because the guardian `can_delete_post_action` method has no way of
distinguishing how to allow a user to be able to unlike their own posts
after the timeout window but only on a post owner change.

* use an options hash instead
2020-08-19 09:21:02 -06:00
..
assets FEATURE - Moderators can create and manage groups (#10432) 2020-08-19 10:41:40 -04:00
controllers FEATURE - Moderators can create and manage groups (#10432) 2020-08-19 10:41:40 -04:00
helpers DEV: Let themes extend color definitions (#10429) 2020-08-18 13:02:13 -04:00
jobs DEV: IMAP log to database (#10435) 2020-08-14 12:01:31 +10:00
mailers PERF: Replace video and audio links in search blurb while indexing. 2020-08-06 12:25:03 +08:00
models DEV: adds event_reminder (27) and event_invitation (28) (#10473) 2020-08-19 12:07:51 +02:00
serializers FEATURE - Moderators can create and manage groups (#10432) 2020-08-19 10:41:40 -04:00
services FIX: Unlike own posts on ownership transfer (#10446) 2020-08-19 09:21:02 -06:00
views FIX: Fix css var issues + button :active gradient (#10469) 2020-08-18 14:25:38 -05:00