When creating a direct message to a group with group SMTP set up, and adding another person to that message in the OP, we send an email to the second person in the OP via the group_smtp job. This in turn creates an IncomingEmail record to guard against IMAP double sync. The issue with this was that this IncomingEmail (which is essentialy a placeholder/dummy one) was having its Message-ID used as the canonical References Message-ID for subsequent emails sent out to user_private_message recipients (such as members of the group), causing threading issues in the mail client. The canonical <topic/ID@HOST> format should be used instead for these cases. This commit fixes the issue by only using the IncomingEmail for the OP's Message-ID if the OP was created via our handle_mail email receiver pipeline. It does not make sense to use it in other cases. |
||
|---|---|---|
| .. | ||
| auth | ||
| backup_restore | ||
| compression | ||
| content_security_policy | ||
| i18n | ||
| imap/providers | ||
| onebox | ||
| seed_data | ||
| site_settings | ||
| topic_query | ||
| validators | ||
| webauthn | ||
| bookmark_manager_spec.rb | ||
| bookmark_query_spec.rb | ||
| bookmark_reminder_notification_handler_spec.rb | ||
| browser_detection_spec.rb | ||
| content_security_policy_spec.rb | ||
| db_helper_spec.rb | ||
| discourse_js_processor_spec.rb | ||
| encodings_spec.rb | ||
| group_email_credentials_check_spec.rb | ||
| introduction_updater_spec.rb | ||
| message_id_service_spec.rb | ||
| mini_sql_multisite_connection_spec.rb | ||
| onebox_spec.rb | ||
| post_jobs_enqueuer_spec.rb | ||
| s3_cors_rulesets_spec.rb | ||
| search_spec.rb | ||
| shrink_uploaded_image_spec.rb | ||
| theme_flag_modifier_spec.rb | ||
| theme_javascript_compiler_spec.rb | ||
| topic_upload_security_manager_spec.rb | ||
| upload_creator_spec.rb | ||
| upload_recovery_spec.rb | ||
| upload_security_spec.rb | ||