821bb1e8cb
The 'Discourse SSO' protocol is being rebranded to DiscourseConnect. This should help to reduce confusion when 'SSO' is used in the generic sense. This commit aims to: - Rename `sso_` site settings. DiscourseConnect specific ones are prefixed `discourse_connect_`. Generic settings are prefixed `auth_` - Add (server-side-only) backwards compatibility for the old setting names, with deprecation notices - Copy `site_settings` database records to the new names - Rename relevant translation keys - Update relevant translations This commit does **not** aim to: - Rename any Ruby classes or methods. This might be done in a future commit - Change any URLs. This would break existing integrations - Make any changes to the protocol. This would break existing integrations - Change any functionality. Further normalization across DiscourseConnect and other auth methods will be done separately The risks are: - There is no backwards compatibility for site settings on the client-side. Accessing auth-related site settings in Javascript is fairly rare, and an error on the client side would not be security-critical. - If a plugin is monkey-patching parts of the auth process, changes to locale keys could cause broken error messages. This should also be unlikely. The old site setting names remain functional, so security-related overrides will remain working. A follow-up commit will be made with a post-deploy migration to delete the old `site_settings` rows.
46 lines
1.3 KiB
JavaScript
46 lines
1.3 KiB
JavaScript
import { acceptance, exists } from "discourse/tests/helpers/qunit-helpers";
|
|
import { test } from "qunit";
|
|
import { visit } from "@ember/test-helpers";
|
|
|
|
acceptance("Create Account - external auth", function (needs) {
|
|
needs.hooks.beforeEach(() => {
|
|
const node = document.createElement("meta");
|
|
node.dataset.authenticationData = JSON.stringify({
|
|
auth_provider: "test",
|
|
email: "blah@example.com",
|
|
can_edit_username: true,
|
|
can_edit_name: true,
|
|
});
|
|
node.id = "data-authentication";
|
|
document.querySelector("head").appendChild(node);
|
|
});
|
|
needs.hooks.afterEach(() => {
|
|
document
|
|
.querySelector("head")
|
|
.removeChild(document.getElementById("data-authentication"));
|
|
});
|
|
|
|
test("when skip is disabled (default)", async function (assert) {
|
|
await visit("/");
|
|
|
|
assert.ok(
|
|
exists("#discourse-modal div.create-account"),
|
|
"it shows the registration modal"
|
|
);
|
|
|
|
assert.ok(exists("#new-account-username"), "it shows the fields");
|
|
});
|
|
|
|
test("when skip is enabled", async function (assert) {
|
|
this.siteSettings.auth_skip_create_confirm = true;
|
|
await visit("/");
|
|
|
|
assert.ok(
|
|
exists("#discourse-modal div.create-account"),
|
|
"it shows the registration modal"
|
|
);
|
|
|
|
assert.not(exists("#new-account-username"), "it does not show the fields");
|
|
});
|
|
});
|