0df1c4eab2
Prior to this commit, we had a default Glimmer component that was responsible for handling generic rendering of notifications in the user menu, and many notification types had a custom Glimmer component that inherited from the default component to customize how they were rendered. That implementation was less than ideal because it meant plugins would have to create Glimmer components to customize notification types added by them and that would make the surface area of the API too big. This commit changes the implementation so there's only one Glimmer component for rendering notifications, and then notification types that need to be customized can create a regular JavaScript class - `renderDirector` in the code - that provides the Glimmer component with the content it should display. We also introduce an API for plugins to register a renderer for a notification type or override an existing one. Some of the changes are partially extracted from https://github.com/discourse/discourse/pull/17379.
86 lines
2.6 KiB
JavaScript
86 lines
2.6 KiB
JavaScript
import { discourseModule } from "discourse/tests/helpers/qunit-helpers";
|
|
import { test } from "qunit";
|
|
import { NOTIFICATION_TYPES } from "discourse/tests/fixtures/concerns/notification-types";
|
|
import { deepMerge } from "discourse-common/lib/object";
|
|
import { createRenderDirector } from "discourse/tests/helpers/notification-items-helper";
|
|
import { htmlSafe } from "@ember/template";
|
|
import Notification from "discourse/models/notification";
|
|
import I18n from "I18n";
|
|
|
|
function getNotification(overrides = {}) {
|
|
return Notification.create(
|
|
deepMerge(
|
|
{
|
|
id: 11,
|
|
user_id: 1,
|
|
notification_type: NOTIFICATION_TYPES.bookmark_reminder,
|
|
read: false,
|
|
high_priority: true,
|
|
created_at: "2022-07-01T06:00:32.173Z",
|
|
post_number: 113,
|
|
topic_id: 449,
|
|
fancy_title: "This is fancy title <a>!",
|
|
slug: "this-is-fancy-title",
|
|
data: {
|
|
title: "this is unsafe bookmark title <a>!",
|
|
display_username: "osama",
|
|
bookmark_name: null,
|
|
bookmarkable_url: "/t/sometopic/3232",
|
|
},
|
|
},
|
|
overrides
|
|
)
|
|
);
|
|
}
|
|
|
|
discourseModule("Unit | Notification Items | bookmark-reminder", function () {
|
|
test("linkTitle", function (assert) {
|
|
const notification = getNotification({
|
|
data: { bookmark_name: "My awesome bookmark" },
|
|
});
|
|
const director = createRenderDirector(
|
|
notification,
|
|
"bookmark_reminder",
|
|
this.siteSettings
|
|
);
|
|
assert.strictEqual(
|
|
director.linkTitle,
|
|
I18n.t("notifications.titles.bookmark_reminder_with_name", {
|
|
name: "My awesome bookmark",
|
|
}),
|
|
"content includes the bookmark name when the bookmark has a name"
|
|
);
|
|
|
|
delete notification.data.bookmark_name;
|
|
assert.strictEqual(
|
|
director.linkTitle,
|
|
"bookmark reminder",
|
|
"derived from the notification name when there's no bookmark name"
|
|
);
|
|
});
|
|
|
|
test("description", function (assert) {
|
|
const notification = getNotification({
|
|
fancy_title: "my fancy title!",
|
|
data: { topic_title: null, title: "custom bookmark title" },
|
|
});
|
|
const director = createRenderDirector(
|
|
notification,
|
|
"bookmark_reminder",
|
|
this.siteSettings
|
|
);
|
|
assert.deepEqual(
|
|
director.description,
|
|
htmlSafe("my fancy title!"),
|
|
"description is the fancy title by default"
|
|
);
|
|
|
|
delete notification.fancy_title;
|
|
assert.strictEqual(
|
|
director.description,
|
|
"custom bookmark title",
|
|
"description falls back to the bookmark title if there's no fancy title"
|
|
);
|
|
});
|
|
});
|