This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/tests/unit/lib
Jarek Radosz a17d54d0bf
DEV: De-arrowify tests (#11068)
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks.

Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps.

It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli.

(I might later add a custom rule to eslint-discourse-ember to enforce this)
2020-10-30 17:37:32 +01:00
..
allow-lister-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
bbcode-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
bookmark-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
break-string-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
category-badge-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
click-track-edit-history-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
click-track-profile-page-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
click-track-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
computed-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
emoji-store-test.js REFACTOR: Import QUnit and related helpers rather than globals 2020-10-07 11:50:49 -04:00
emoji-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
formatter-test.js REFACTOR: Use imports for sinon and setResolver 2020-10-09 13:54:54 -04:00
get-url-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
highlight-search-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
i18n-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
icon-library-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
key-value-store-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
link-mentions-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
load-script-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
oneboxer-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
preload-store-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
pretty-text-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
sanitizer-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
screen-track-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
search-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
sharing-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
text-direction-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
to-markdown-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
upload-short-url-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
uploads-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
url-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
user-search-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
utilities-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00