This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/app/lib/settings.js
Isaac Janzen 196b791365
DEV: Prioritize full name when display_name_on_posts active (#16078)
See: https://meta.discourse.org/t/display-full-name-not-username-when-attributing-quote-or-reply/203533?u=isaacjanzen for context

The initial release [broke quoting](https://meta.discourse.org/t/quoting-broken-when-name-matches-username/217633?u=isaacjanzen) but we now pass the username when 
```
siteSettings.display_name_on_posts && !siteSettings.prioritize_username_in_ux && post.name
```
as well as the full name to guarantee that we are not getting any mismatches when querying for user / avatar.

eg. 
```
[quote="Isaac Janzen, post:3, topic:7, full:true, username:isaac.janzen"]
bing bong
[/quote]
```
2022-04-20 10:07:51 -05:00

30 lines
727 B
JavaScript

import { helperContext } from "discourse-common/lib/helpers";
export function prioritizeNameInUx(name) {
let siteSettings = helperContext().siteSettings;
return (
!siteSettings.prioritize_username_in_ux && name && name.trim().length > 0
);
}
export function prioritizeNameFallback(name, username) {
let siteSettings = helperContext().siteSettings;
if (
siteSettings.display_name_on_posts &&
!siteSettings.prioritize_username_in_ux
) {
return name || username;
} else {
return username;
}
}
export function emojiBasePath() {
let siteSettings = helperContext().siteSettings;
return siteSettings.external_emoji_url === ""
? "/images/emoji"
: siteSettings.external_emoji_url;
}