This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/app
David Taylor 76d5e54aab
PERF: Check for modal visibility in a more efficient way
This code runs on every keyup event in the application, so it needs to be efficient. Previously we were iterating over the whole document using the JQuery :visible selector. Per the JQuery docs at https://api.jquery.com/visible-selector/

> Using this selector heavily can have performance implications, as it may force the browser to re-render the page before it can determine visibility. Tracking the visibility of elements via other methods, using a class for example, can provide better performance.

We already had a `hidden` class on the modal element which we can check, so we can check that instead.
2020-07-01 17:49:23 +01:00
..
adapters DEV: Move Discourse.getURL and related functions to a module (#9966) 2020-06-03 12:45:26 -04:00
components PERF: Check for modal visibility in a more efficient way 2020-07-01 17:49:23 +01:00
controllers FEATURE: allows published pages to be public (#10053) 2020-06-17 12:42:20 +02:00
helpers DEV: Move Discourse.getURL and related functions to a module (#9966) 2020-06-03 12:45:26 -04:00
initializers UX: Send background color to iPad app too 2020-06-11 23:20:25 -04:00
lib FIX: emoji_autocomplete_min_chars failing when not 0 2020-06-30 17:39:52 +10:00
mixins FIX: Do not destroy $.fileupload element (#9888) 2020-06-02 16:14:41 +10:00
models FIX: Do not incorrectly add topic bookmark on Escape (#10088) 2020-06-19 11:17:18 +10:00
pre-initializers FEATURE: category setting for default list filter. (#9975) 2020-06-04 00:56:56 +05:30
raw-views DEV: import I18n instead of global usage (#9768) 2020-05-13 16:23:41 -04:00
routes FEATURE: Improve UX support for multiple email addresses (#9691) 2020-06-10 19:11:49 +03:00
services DEV: Move Discourse.getURL and related functions to a module (#9966) 2020-06-03 12:45:26 -04:00
templates DEV: Add group name as class to group-box (#10150) 2020-06-30 10:49:31 -05:00
widgets FIX: ensures moderation history is accessible from topic/post admin menu (#10118) 2020-06-24 10:49:47 +02:00
app.js DEV: Move Discourse.getURL and related functions to a module (#9966) 2020-06-03 12:45:26 -04:00
mapping-router.js DEV: Move Discourse.getURL and related functions to a module (#9966) 2020-06-03 12:45:26 -04:00