Unfortunately, I couldn't refactor as much as I would like here. My original idea was the component to handle message bus subscriptions and callbacks to isolate post-send warnings from the `chat-live-pane` and `chat-message`. However, I couldn't make it work because we can't set the message ID inmediately after sending a message, meaning we won't be able to subscribe to the channel in time and miss the update. For this reason, we can't break the current design where the pane acts as a message broker, which dispatches updates to specific messages. The change accomplished two things. It simplifies the warning MB message homogenizing all the different warning types into a single array, and renders a component that know how to translate them without needing multiple functions like the old implementation. |
||
|---|---|---|
| .. | ||
| chat_channel_archive_service_spec.rb | ||
| chat_channel_fetcher_spec.rb | ||
| chat_channel_hashtag_data_source_spec.rb | ||
| chat_channel_membership_manager_spec.rb | ||
| chat_message_bookmarkable_spec.rb | ||
| chat_message_processor_spec.rb | ||
| chat_message_reactor_spec.rb | ||
| chat_notifier_spec.rb | ||
| chat_review_queue_spec.rb | ||
| chat_statistics_spec.rb | ||
| chat_transcript_service_spec.rb | ||
| direct_message_channel_creator_spec.rb | ||
| duplicate_message_validator_spec.rb | ||
| endpoint_spec.rb | ||
| guardian_extensions_spec.rb | ||
| message_mover_spec.rb | ||
| post_notification_handler_spec.rb | ||
| slack_compatibility_spec.rb | ||
| steps_inspector_spec.rb | ||