osr-plastic/osr-discourse-src
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
82ebc706aa
osr-discourse-src/app/assets/javascripts/discourse/tests/unit/models
History
Martin Brennan e15c86e8c5
DEV: Topic tracking state improvements (#13218) 
I merged this PR in yesterday, finally thinking this was done https://github.com/discourse/discourse/pull/12958 but then a wild performance regression occurred. These are the problem methods:

1aa20bd681/app/serializers/topic_tracking_state_serializer.rb (L13-L21)

Turns out date comparison is super expensive on the backend _as well as_ the frontend.

The fix was to just move the `treat_as_new_topic_start_date` into the SQL query rather than using the slower `UserOption#treat_as_new_topic_start_date` method in ruby. After this change, 1% of the total time is spent with the `created_in_new_period` comparison instead of ~20%.

----

History:

Original PR which had to be reverted **https://github.com/discourse/discourse/pull/12555**. See the description there for what this PR is achieving, plus below.

The issue with the original PR is addressed in 92ef54f402

If you went to the `x unread` link for a tag Chrome would freeze up and possibly crash, or eventually unfreeze after nearly 10 mins. Other routes for unread/new were similarly slow. From profiling the issue was the `sync` function of `topic-tracking-state.js`, which calls down to `isNew` which in turn calls `moment`, a change I had made in the PR above. The time it takes locally with ~1400 topics in the tracking state is 2.3 seconds.

To solve this issue, I have moved these calculations for "created in new period" and "unread not too old" into the tracking state serializer.

When I was looking at the profiler I also noticed this issue which was just compounding the problem. Every time we modify topic tracking state we recalculate the sidebar tracking/everything/tag counts. However this calls `forEachTracked` and `countTags` which can be quite expensive as they go through the whole tracking state (and were also calling the removed moment functions).

I added some logs and this was being called 30 times when navigating to a new /unread route because  `sync` is being called from `build-topic-route` (one for each topic loaded due to pagination). So I just added a debounce here and it makes things even faster.

Finally, I changed topic tracking state to use a Map so our counts of the state keys is faster (Maps have .size whereas objects you have to do Object.keys(obj) which is O(n).)

<!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->
2021-06-02 09:06:29 +10:00
..
badge-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
category-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
composer-test.js DEV: Correct typos and spelling mistakes (#12812) 2021-05-21 11:43:47 +10:00
email-log-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
group-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
invite-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
nav-item-test.js DEV: Topic tracking state improvements (#13218) 2021-06-02 09:06:29 +10:00
post-stream-test.js DEV: Correct typos and spelling mistakes (#12812) 2021-05-21 11:43:47 +10:00
post-test.js DEV: prettier 2.2.1 (#11862) 2021-01-27 12:39:20 +01:00
report-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
rest-model-test.js DEV: Correct typos and spelling mistakes (#12812) 2021-05-21 11:43:47 +10:00
result-set-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
session-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
site-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
staff-action-log-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
theme-test.js FIX: Tests in admin/tests were not running (#12391) 2021-03-17 13:02:12 -04:00
topic-details-test.js FIX: Base topic details message on current category and tag tracking state (#12937) 2021-05-06 09:14:07 +10:00
topic-test.js DEV: Remove JoyPixels emoji option (#12197) 2021-02-26 07:44:52 -05:00
topic-tracking-state-test.js DEV: Topic tracking state improvements (#13218) 2021-06-02 09:06:29 +10:00
user-action-test.js DEV: prettier 2.2.1 (#11862) 2021-01-27 12:39:20 +01:00
user-badge-test.js FEATURE: lets users favorite 2 badges to show on user-card (#13151) 2021-06-01 10:33:40 +02:00
user-drafts-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
user-stream-test.js FEATURE: Add "Recently read topics" tab to user activity page (#12047) 2021-02-11 22:36:50 +05:30
user-test.js DEV: prettier 2.2.1 (#11862) 2021-01-27 12:39:20 +01:00