This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse
Jarek Radosz 8881ae4af4
DEV: Remove dead code (latestTopicOnly) (#11833)
Background: I wanted to see `categories.latest_by` translation in context in a live app but couldn't find it, so I traced it throughout the code.

My step-by-step reasoning for the removal is:

1. `categories-only` does not use `latestTopicOnly`, so there's no need to call it with that argument
2. `parent-category-row` is never called with `latestTopicOnly` argument, so the reference to that arg can be removed from its template
3. after that, `featured-topic` is now no longer ever called with `latestTopicOnly` argument (except in the `ghost` theme, but that's because its override of `categories-only` template 4e2fba963c/common/header.html (L119) is based on the old version of that template from core), so it seems safe to remove it there too (`categories.latest_by` i18n string is also no longer needed)
4. then, nothing is using `latestTopicOnly` anymore so it can be removed from `categories` hbs/js

I checked in each step that there are no plugins or themes (in all-the-plugins/all-the-themes) using those properties/arguments/strings.
2021-01-28 11:48:51 +01:00
..
app DEV: Remove dead code (latestTopicOnly) (#11833) 2021-01-28 11:48:51 +01:00
config Sync up master with Ember CLI branch where possible (#11707) 2021-01-14 12:52:51 -05:00
public/assets/scripts Sync up master and Ember CLI branches again (#11746) 2021-01-18 16:12:45 -05:00
tests FIX: Translated button title didn't work (#11872) 2021-01-28 08:32:02 +01:00
.ember-cli REFACTOR: Sync up master with changes for Ember-CLI (#11671) 2021-01-12 10:13:21 -05:00
ember-cli-build.js Sync up master and Ember CLI branches again (#11746) 2021-01-18 16:12:45 -05:00
package.json Sync up master and Ember CLI branches again (#11746) 2021-01-18 16:12:45 -05:00
testem.js Sync up master and Ember CLI branches again (#11746) 2021-01-18 16:12:45 -05:00