This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.

Osama Sayegh 8c2c96af25 DEV: Ensure experimental user menu is always closed after clicking on items (#18231) ... Because Discourse is a single-page application, clicks on the majority of `<a>` elements in the app need to be intercepted by JavaScript to prevent browsers' default action (full page reload). Links in the user menu - which include notifications, reviewables, bookmarks etc. - are no exception to this rule and currently clicks on these items are handled by the global [click-interceptor](1fa21ed415/app/assets/javascripts/discourse/app/lib/intercept-click.js (L20)) which calls the `preventDefault` function on the click event object and uses the `DiscourseURL.routeTo` function to route the user to the page they request. However, for links in the user menu, there's an extra step which is to let the header know that it should close the user menu after clicking an item in the menu, but the global interceptor doesn't know that because the step is specific to links in the user menu. This can cause a bug on mobile devices where the menu remains open after clicking on a notification which results in the user having to close the menu to see the page that the notification takes them to. This commit adds a click handler to user menu items that ensures the menu is closed when an item is clicked and navigates the user to wherever the item links to. There's a small downside to this change which is that user menu items now have their own click interceptor instead of relying on the global interceptor, i.e. duplicated logic, but since it's only a couple of lines, I think we can live with it for a while. I did try to make the click handler of the user menu items only close the menu (call the `closeUserMenu` function), but for some reasons it caused a full page reload to happen when clicking a notification item due to some weird interactions between the header widget and the user menu. I didn't debug this thoroughly because we have plans to change the header implementation from widgets/virtual-dom to Glimmer component, which will likely resolve that weird full page reload issue and we'll be able to make the click handler just close the menu and let the global interceptor prevents the default action and do the routing. Internal topic: t/71911/118.		2022-09-13 15:44:45 +03:00
..
acceptance	DEV: Ensure experimental user menu is always closed after clicking on items (#18231)	2022-09-13 15:44:45 +03:00
fixtures	DEV: Refactor self-delete dialog (#18180)	2022-09-12 09:45:53 -04:00
helpers	DEV: Add model transformer plugin API (#18081)	2022-08-25 15:41:58 +03:00
integration	FEATURE: other notifications tab for redesign user menu (#18164)	2022-09-02 14:49:49 +03:00
unit	DEV: extract until date formatting in a library function (#18003)	2022-08-29 15:45:36 +04:00
active-plugins.js.erb	DEV: Support for running theme test with Ember CLI (third attempt)	2022-01-13 16:02:07 -05:00
core-tests.js	DEV: Support for running theme test with Ember CLI (third attempt)	2022-01-13 16:02:07 -05:00
index.html	DEV: Compile markdown-it-bundle with ember-cli (#18104)	2022-08-29 19:11:59 +01:00
plugin-tests.js.erb	DEV: Transpile all plugin js by default (#17175)	2022-06-21 22:07:10 +02:00
setup-tests.js	DEV: Abort qunit tests when clicking in the toolbar (#17989)	2022-08-18 23:32:38 +01:00
test-boot-ember-cli.js	DEV: Skip loading plugin JS when running only core tests (#18047)	2022-08-23 10:25:07 +01:00