Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks. Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps. It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli. (I might later add a custom rule to eslint-discourse-ember to enforce this)
17 lines
655 B
JavaScript
17 lines
655 B
JavaScript
import { exists } from "discourse/tests/helpers/qunit-helpers";
|
|
import { visit } from "@ember/test-helpers";
|
|
import { test } from "qunit";
|
|
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
|
|
|
|
acceptance("Admin - Search Log Term", function (needs) {
|
|
needs.user();
|
|
|
|
test("show search log term details", async function (assert) {
|
|
await visit("/admin/logs/search_logs/term?term=ruby");
|
|
|
|
assert.ok($("div.search-logs-filter").length, "has the search type filter");
|
|
assert.ok(exists("canvas.chartjs-render-monitor"), "has graph canvas");
|
|
assert.ok(exists("div.header-search-results"), "has header search results");
|
|
});
|
|
});
|