Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks. Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps. It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli. (I might later add a custom rule to eslint-discourse-ember to enforce this)
47 lines
1.4 KiB
JavaScript
47 lines
1.4 KiB
JavaScript
import { exists } from "discourse/tests/helpers/qunit-helpers";
|
|
import { visit } from "@ember/test-helpers";
|
|
import { test } from "qunit";
|
|
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
|
|
|
|
acceptance("Create Account - external auth", function (needs) {
|
|
needs.hooks.beforeEach(() => {
|
|
const node = document.createElement("meta");
|
|
node.dataset.authenticationData = JSON.stringify({
|
|
auth_provider: "test",
|
|
email: "blah@example.com",
|
|
can_edit_username: true,
|
|
can_edit_name: true,
|
|
});
|
|
node.id = "data-authentication";
|
|
document.querySelector("head").appendChild(node);
|
|
});
|
|
needs.hooks.afterEach(() => {
|
|
document
|
|
.querySelector("head")
|
|
.removeChild(document.getElementById("data-authentication"));
|
|
});
|
|
|
|
test("when skip is disabled (default)", async function (assert) {
|
|
await visit("/");
|
|
|
|
assert.ok(
|
|
exists("#discourse-modal div.create-account"),
|
|
"it shows the registration modal"
|
|
);
|
|
|
|
assert.ok(exists("#new-account-username"), "it shows the fields");
|
|
});
|
|
|
|
test("when skip is enabled", async function (assert) {
|
|
this.siteSettings.external_auth_skip_create_confirm = true;
|
|
await visit("/");
|
|
|
|
assert.ok(
|
|
exists("#discourse-modal div.create-account"),
|
|
"it shows the registration modal"
|
|
);
|
|
|
|
assert.not(exists("#new-account-username"), "it does not show the fields");
|
|
});
|
|
});
|