This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/tests/acceptance/group-manage-logs-test.js
Jarek Radosz a17d54d0bf
DEV: De-arrowify tests (#11068)
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks.

Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps.

It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli.

(I might later add a custom rule to eslint-discourse-ember to enforce this)
2020-10-30 17:37:32 +01:00

111 lines
3.2 KiB
JavaScript

import { queryAll } from "discourse/tests/helpers/qunit-helpers";
import { click, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("Group logs", function (needs) {
needs.user();
needs.pretender((server, helper) => {
server.get("/groups/snorlax.json", () => {
return helper.response({
group: {
id: 41,
automatic: false,
name: "snorlax",
user_count: 1,
alias_level: 0,
visible: true,
automatic_membership_email_domains: "",
primary_group: true,
title: "Team Snorlax",
grant_trust_level: null,
incoming_email: null,
has_messages: false,
flair_url: "",
flair_bg_color: "",
flair_color: "",
bio_raw: "",
bio_cooked: null,
public: true,
is_group_user: true,
is_group_owner: true,
},
});
});
// Workaround while awaiting https://github.com/tildeio/route-recognizer/issues/53
server.get("/groups/snorlax/logs.json", (request) => {
if (request.queryParams["filters[action]"]) {
return helper.response({
logs: [
{
action: "change_group_setting",
subject: "title",
prev_value: null,
new_value: "Team Snorlax",
created_at: "2016-12-12T08:27:46.408Z",
acting_user: {
id: 1,
username: "tgx",
avatar_template: "/images/avatar.png",
},
target_user: null,
},
],
all_loaded: true,
});
} else {
return helper.response({
logs: [
{
action: "change_group_setting",
subject: "title",
prev_value: null,
new_value: "Team Snorlax",
created_at: "2016-12-12T08:27:46.408Z",
acting_user: {
id: 1,
username: "tgx",
avatar_template: "/images/avatar.png",
},
target_user: null,
},
{
action: "add_user_to_group",
subject: null,
prev_value: null,
new_value: null,
created_at: "2016-12-12T08:27:27.725Z",
acting_user: {
id: 1,
username: "tgx",
avatar_template: "/images/avatar.png",
},
target_user: {
id: 1,
username: "tgx",
avatar_template: "/images/avatar.png",
},
},
],
all_loaded: true,
});
}
});
});
test("Browsing group logs", async function (assert) {
await visit("/g/snorlax/manage/logs");
assert.ok(
queryAll("tr.group-manage-logs-row").length === 2,
"it should display the right number of logs"
);
await click(queryAll(".group-manage-logs-row button")[0]);
assert.ok(
queryAll("tr.group-manage-logs-row").length === 1,
"it should display the right number of logs"
);
});
});